@xenon-device-management/xenon 2.12.0 → 2.13.0

package/lib/test/unit/device-allocation-routes.spec.js

@@ -0,0 +1,232 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const express_1 = __importDefault(require("express"));
+const sinon_1 = __importDefault(require("sinon"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
+const grid_1 = __importDefault(require("../../src/app/routers/grid"));
+const reservation_1 = __importDefault(require("../../src/app/routers/reservation"));
+const device_store_1 = require("../../src/data-service/device-store");
+/**
+ * Blocking and reserving a phone act on exactly the phone named, by udid and
+ * host, and a reservation is changed only by whoever took it, or an admin.
+ */
+const UDID = 'R5CT32ABCDE';
+const HOST = 'http://192.168.1.100:4723';
+const OTHER_HOST = 'http://192.168.1.101:4723';
+const HOUR = 60 * 60 * 1000;
+const DANA = { userId: 'usr_dana', role: 'MEMBER', scopes: 'devices,sessions,read' };
+const LEE = { userId: 'usr_lee', role: 'MEMBER', scopes: 'devices,sessions,read' };
+const ADMIN = { userId: 'usr_admin', role: 'ADMIN', scopes: 'admin,devices,sessions,read' };
+/** A store with the phone on HOST, and each phone write recorded. */
+function fakeStore(phone = {}) {
+    const rows = [
+        Object.assign({ udid: UDID, host: HOST, name: 'Pixel 7', platform: 'android', teamId: null }, phone),
+        { udid: UDID, host: OTHER_HOST, name: 'Pixel 7', platform: 'android', teamId: null },
+    ];
+    const writes = [];
+    const store = {
+        findDevice: (filter) => __awaiter(this, void 0, void 0, function* () { var _a; return (_a = rows.find((r) => r.udid === filter.udid && r.host === filter.host)) !== null && _a !== void 0 ? _a : null; }),
+        updateDevice: (udid, host, data) => __awaiter(this, void 0, void 0, function* () {
+            writes.push({ udid, host, data });
+            const row = rows.find((r) => r.udid === udid && r.host === host);
+            if (row)
+                Object.assign(row, data);
+        }),
+    };
+    sinon_1.default.stub(device_store_1.DeviceStoreFactory, 'getStore').returns(store);
+    return { rows, writes };
+}
+function appAs(caller, mount) {
+    const app = (0, express_1.default)();
+    app.use(express_1.default.json());
+    app.use((req, _res, next) => {
+        req.auth = Object.assign({ kind: 'user-session', rateLimit: 1000 }, caller);
+        next();
+    });
+    mount(app);
+    return app;
+}
+describe('device allocation routes', () => {
+    afterEach(() => sinon_1.default.restore());
+    describe('POST /block and /unblock', () => {
+        const app = () => appAs(ADMIN, (a) => {
+            const router = express_1.default.Router();
+            grid_1.default.register(router, { bindHostOrIp: '127.0.0.1' });
+            a.use(router);
+        });
+        for (const path of ['/block', '/unblock']) {
+            for (const [what, body] of [
+                ['an empty body', {}],
+                ['no host', { udid: UDID }],
+                ['no udid', { host: HOST }],
+                ['a udid that is not a string', { udid: 42, host: HOST }],
+            ]) {
+                it(`${path} answers 400 for ${what}, and changes nothing`, () => __awaiter(void 0, void 0, void 0, function* () {
+                    const { writes } = fakeStore();
+                    const r = yield (0, loopbackRequest_1.default)(app()).post(path).send(body).timeout(5000);
+                    (0, chai_1.expect)(r.status).to.equal(400);
+                    (0, chai_1.expect)(r.body).to.deep.equal({
+                        success: false,
+                        error: 'bad_request',
+                        message: 'udid and host are required',
+                    });
+                    (0, chai_1.expect)(writes).to.deep.equal([]);
+                }));
+            }
+            it(`${path} answers 404 for a host the phone is not on`, () => __awaiter(void 0, void 0, void 0, function* () {
+                const { writes } = fakeStore();
+                const r = yield (0, loopbackRequest_1.default)(app())
+                    .post(path)
+                    .send({ udid: UDID, host: 'http://10.0.0.9:4723' })
+                    .timeout(5000);
+                (0, chai_1.expect)(r.status).to.equal(404);
+                (0, chai_1.expect)(writes).to.deep.equal([]);
+            }));
+        }
+        it('blocks the phone on the host named, not another row of its udid', () => __awaiter(void 0, void 0, void 0, function* () {
+            const { writes } = fakeStore();
+            const r = yield (0, loopbackRequest_1.default)(app())
+                .post('/block')
+                .send({ udid: UDID, host: OTHER_HOST })
+                .timeout(5000);
+            (0, chai_1.expect)(r.status).to.equal(200);
+            (0, chai_1.expect)(writes).to.deep.equal([{ udid: UDID, host: OTHER_HOST, data: { userBlocked: true } }]);
+        }));
+    });
+    describe('/reservation', () => {
+        const app = (caller) => appAs(caller, (a) => a.use('/reservation', reservation_1.default));
+        const reserved = (userId) => ({
+            reservedBy: 'Dana',
+            reservedByUserId: userId,
+            reservedUntil: Date.now() + HOUR,
+            reservationReason: 'release testing',
+        });
+        const hostPath = encodeURIComponent(HOST);
+        it('answers 404 when the phone is not on the host named, and reserves nothing', () => __awaiter(void 0, void 0, void 0, function* () {
+            const { writes } = fakeStore();
+            const r = yield (0, loopbackRequest_1.default)(app(DANA))
+                .post('/reservation')
+                .send({ udid: UDID, host: 'http://10.0.0.9:4723', reservedBy: 'Dana', duration: '1h' })
+                .timeout(5000);
+            (0, chai_1.expect)(r.status).to.equal(404);
+            (0, chai_1.expect)(writes).to.deep.equal([]);
+        }));
+        it('records who reserved the phone', () => __awaiter(void 0, void 0, void 0, function* () {
+            const { rows } = fakeStore();
+            const r = yield (0, loopbackRequest_1.default)(app(DANA))
+                .post('/reservation')
+                .send({ udid: UDID, host: HOST, reservedBy: 'Dana', duration: '1h' })
+                .timeout(5000);
+            (0, chai_1.expect)(r.status).to.equal(200);
+            (0, chai_1.expect)(rows[0]).to.include({ reservedBy: 'Dana', reservedByUserId: DANA.userId });
+        }));
+        it("refuses someone else's reservation even under the same name", () => __awaiter(void 0, void 0, void 0, function* () {
+            fakeStore(reserved(DANA.userId));
+            const r = yield (0, loopbackRequest_1.default)(app(LEE))
+                .post('/reservation')
+                .send({ udid: UDID, host: HOST, reservedBy: 'Dana', duration: '1h' })
+                .timeout(5000);
+            (0, chai_1.expect)(r.status).to.equal(409);
+        }));
+        it('lets the holder renew their own reservation', () => __awaiter(void 0, void 0, void 0, function* () {
+            fakeStore(reserved(DANA.userId));
+            const r = yield (0, loopbackRequest_1.default)(app(DANA))
+                .post('/reservation')
+                .send({ udid: UDID, host: HOST, reservedBy: 'Dana', duration: '2h' })
+                .timeout(5000);
+            (0, chai_1.expect)(r.status).to.equal(200);
+        }));
+        for (const [what, call] of [
+            ['release', (a) => (0, loopbackRequest_1.default)(a).delete(`/reservation/${UDID}/${hostPath}`)],
+            [
+                'extend',
+                (a) => (0, loopbackRequest_1.default)(a).post(`/reservation/${UDID}/${hostPath}/extend`).send({ duration: '1h' }),
+            ],
+        ]) {
+            it(`refuses to let another member ${what} it, and changes nothing`, () => __awaiter(void 0, void 0, void 0, function* () {
+                const { writes } = fakeStore(reserved(DANA.userId));
+                const r = yield call(app(LEE)).timeout(5000);
+                (0, chai_1.expect)(r.status).to.equal(403);
+                (0, chai_1.expect)(r.body).to.deep.equal({
+                    success: false,
+                    error: 'not_reservation_holder',
+                    message: 'Only the person who reserved this device, or an admin, can change the reservation.',
+                });
+                (0, chai_1.expect)(writes).to.deep.equal([]);
+            }));
+            it(`lets the holder ${what} it`, () => __awaiter(void 0, void 0, void 0, function* () {
+                fakeStore(reserved(DANA.userId));
+                (0, chai_1.expect)((yield call(app(DANA)).timeout(5000)).status).to.equal(200);
+            }));
+            it(`lets an admin ${what} it`, () => __awaiter(void 0, void 0, void 0, function* () {
+                fakeStore(reserved(DANA.userId));
+                (0, chai_1.expect)((yield call(app(ADMIN)).timeout(5000)).status).to.equal(200);
+            }));
+            it(`lets anyone ${what} a reservation that names no user (taken before 2.13)`, () => __awaiter(void 0, void 0, void 0, function* () {
+                fakeStore(reserved(null));
+                (0, chai_1.expect)((yield call(app(LEE)).timeout(5000)).status).to.equal(200);
+            }));
+            it(`answers 404 for ${what} on a host the phone is not on`, () => __awaiter(void 0, void 0, void 0, function* () {
+                fakeStore(reserved(DANA.userId));
+                const a = app(DANA);
+                const r = what === 'release'
+                    ? yield (0, loopbackRequest_1.default)(a).delete(`/reservation/${UDID}/${encodeURIComponent('http://10.0.0.9:4723')}`)
+                    : yield (0, loopbackRequest_1.default)(a)
+                        .post(`/reservation/${UDID}/${encodeURIComponent('http://10.0.0.9:4723')}/extend`)
+                        .send({ duration: '1h' });
+                (0, chai_1.expect)(r.status).to.equal(404);
+            }));
+        }
+        it('keeps the holder when a reservation is extended', () => __awaiter(void 0, void 0, void 0, function* () {
+            const { rows } = fakeStore(reserved(DANA.userId));
+            yield (0, loopbackRequest_1.default)(app(ADMIN))
+                .post(`/reservation/${UDID}/${hostPath}/extend`)
+                .send({ duration: '1h' })
+                .timeout(5000);
+            (0, chai_1.expect)(rows[0].reservedByUserId).to.equal(DANA.userId);
+        }));
+        for (const [what, duration] of [
+            ['past 24 hours from now', 24 * HOUR],
+            ['by a negative duration', -HOUR],
+            ['by less than a minute', 1000],
+        ]) {
+            it(`refuses to extend it ${what}`, () => __awaiter(void 0, void 0, void 0, function* () {
+                const { writes } = fakeStore(reserved(DANA.userId));
+                const r = yield (0, loopbackRequest_1.default)(app(DANA))
+                    .post(`/reservation/${UDID}/${hostPath}/extend`)
+                    .send({ duration })
+                    .timeout(5000);
+                (0, chai_1.expect)(r.status).to.equal(400);
+                (0, chai_1.expect)(writes).to.deep.equal([]);
+            }));
+        }
+        it('extends it up to 24 hours from now', () => __awaiter(void 0, void 0, void 0, function* () {
+            const { rows } = fakeStore(reserved(DANA.userId));
+            const r = yield (0, loopbackRequest_1.default)(app(DANA))
+                .post(`/reservation/${UDID}/${hostPath}/extend`)
+                .send({ duration: 22 * HOUR })
+                .timeout(5000);
+            (0, chai_1.expect)(r.status).to.equal(200);
+            (0, chai_1.expect)(rows[0].reservedUntil).to.be.at.most(Date.now() + 24 * HOUR);
+        }));
+        it('clears the holder when the reservation is released', () => __awaiter(void 0, void 0, void 0, function* () {
+            const { rows } = fakeStore(reserved(DANA.userId));
+            yield (0, loopbackRequest_1.default)(app(DANA)).delete(`/reservation/${UDID}/${hostPath}`).timeout(5000);
+            (0, chai_1.expect)(rows[0]).to.include({ reservedBy: null, reservedByUserId: null, reservedUntil: null });
+        }));
+    });
+});

package/lib/test/unit/healing-state-endpoints.spec.js

@@ -284,16 +284,19 @@ describe('GET /healing/state/:strategy/:value — getSelectorStateByTuple', () =
         findUniqueStub = sinon_1.default.stub(prisma_1.prisma.selectorState, 'findUnique');
     });
     afterEach(() => sinon_1.default.restore());
-    it('returns the row for a URL-encoded tuple', () => __awaiter(void 0, void 0, void 0, function* () {
+    // Express has decoded the path params before the handler runs, so they
+    // arrive here plain. The handler used to decode them again, which made a
+    // selector containing `%` need encoding twice.
+    it('returns the row for the tuple Express decoded, a `%` included', () => __awaiter(void 0, void 0, void 0, function* () {
         findUniqueStub.resolves({
             original_strategy: 'accessibility id',
-            original_selector: 'login-btn',
+            original_selector: "//*[@text='50% off']",
             status: 'pending',
         });
         const { req, res, jsonStub } = mockReqRes({
             params: {
-                strategy: encodeURIComponent('accessibility id'),
-                value: encodeURIComponent('login-btn'),
+                strategy: 'accessibility id',
+                value: "//*[@text='50% off']",
             },
         });
         yield (0, dashboard_1.getSelectorStateByTuple)(req, res);
@@ -302,7 +305,7 @@ describe('GET /healing/state/:strategy/:value — getSelectorStateByTuple', () =
             where: {
                 original_strategy_original_selector: {
                     original_strategy: 'accessibility id',
-                    original_selector: 'login-btn',
+                    original_selector: "//*[@text='50% off']",
                 },
             },
         });

package/lib/test/unit/install-repository-app-team.spec.js

@@ -107,7 +107,10 @@ describe('POST /control/:udid/install-repository-app follows the app team rule',
         const hidden = yield install(['team-a'], 'app-b');
         const unknown = yield install(['team-a'], 'no-such-app');
         (0, chai_1.expect)(hidden.status).to.equal(404);
-        (0, chai_1.expect)(hidden.text).to.equal('App not found in repository');
+        (0, chai_1.expect)(hidden.body).to.deep.equal({
+            error: 'not_found',
+            message: 'App not found in repository',
+        });
         (0, chai_1.expect)(unknown.status).to.equal(hidden.status);
         (0, chai_1.expect)(unknown.text).to.equal(hidden.text);
         (0, chai_1.expect)(manager.installApp.called).to.equal(false);

package/lib/test/unit/lease/LeaseService.spec.js

@@ -67,13 +67,14 @@ describe('LeaseService', () => {
                 deleteMany: sinon_1.default.stub().resolves({ count: 0 }),
             },
         };
+        const phone = {
+            udid: 'u1', host: 'h1', platform: 'android', sdk: '14', name: 'Pixel 7', teamId: null,
+        };
         storeStub = {
-            findAndLockDevice: sinon_1.default.stub().resolves({
-                udid: 'u1', host: 'h1', platform: 'android', sdk: '14', name: 'Pixel 7', teamId: null,
-            }),
+            findAndLockDevice: sinon_1.default.stub().resolves(phone),
             updateDevice: sinon_1.default.stub().resolves(),
             releaseLeaseLock: sinon_1.default.stub().resolves(true),
-            getDevices: sinon_1.default.stub().resolves([]),
+            getDevices: sinon_1.default.stub().resolves([phone]),
         };
         portClientStub = {
             allocate: sinon_1.default.stub().resolves({ systemPort: 9001, chromedriverPort: 9002, mjpegServerPort: 9003 }),

package/lib/test/unit/lease/lease-device-match.spec.js

@@ -0,0 +1,161 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const sinon_1 = __importDefault(require("sinon"));
+const express_1 = __importDefault(require("express"));
+const loopbackRequest_1 = __importDefault(require("../../helpers/loopbackRequest"));
+const sdk_leases_1 = require("../../../src/app/routers/sdk-leases");
+const LeaseService_1 = require("../../../src/services/lease/LeaseService");
+const device_store_1 = require("../../../src/data-service/device-store");
+const prisma_1 = require("../../../src/prisma");
+/**
+ * Which device a lease takes. Through 2.12 the lease took the first free
+ * device of the platform: one an admin had blocked, one reserved for someone
+ * else, or one failing its health check, and it dropped the `sdk` and
+ * `deviceName` filters. An unknown udid answered 409 "all busy" whenever any
+ * device of the platform existed.
+ *
+ * The router, LeaseService and the in-memory device store are real here.
+ * Only the port RPC and the lease rows are faked.
+ */
+// Unique, so the match is held to this suite's phones: other specs in the
+// same process leave their own devices in the in-memory store.
+const HOST = `lease-match-${Date.now()}`;
+const FREE = 'MATCH-FREE';
+const BLOCKED = 'MATCH-BLOCKED';
+const RESERVED = 'MATCH-RESERVED';
+const UNHEALTHY = 'MATCH-UNHEALTHY';
+const OLD = 'MATCH-OLD';
+const ALL = [FREE, BLOCKED, RESERVED, UNHEALTHY, OLD];
+describe('SDK leases take only a device that is free to use', () => {
+    let store;
+    let previousStore;
+    let previousEnv;
+    let svc;
+    before(() => {
+        previousEnv = process.env.NODE_ENV;
+        process.env.NODE_ENV = 'test';
+        previousStore = device_store_1.DeviceStoreFactory._deviceStore;
+        device_store_1.DeviceStoreFactory._deviceStore = undefined;
+        store = device_store_1.DeviceStoreFactory.getStore();
+        (0, chai_1.expect)(store.constructor.name).to.equal('LokiDeviceStore');
+    });
+    after(() => __awaiter(void 0, void 0, void 0, function* () {
+        for (const udid of ALL)
+            yield store.removeDevices({ udid });
+        device_store_1.DeviceStoreFactory._deviceStore = previousStore;
+        process.env.NODE_ENV = previousEnv;
+    }));
+    beforeEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        const phone = (udid, extra = {}) => (Object.assign({ udid, host: HOST, name: 'Pixel 7', platform: 'android', sdk: '14', teamId: null, busy: false, offline: false, userBlocked: false, healthStatus: 'Healthy' }, extra));
+        for (const udid of ALL)
+            yield store.removeDevices({ udid });
+        yield store.addDevices([
+            phone(BLOCKED, { userBlocked: true }),
+            phone(RESERVED, { reservedBy: 'Dana', reservedUntil: Date.now() + 60 * 60 * 1000 }),
+            phone(UNHEALTHY, { healthStatus: 'Unhealthy' }),
+            phone(OLD, { sdk: '12', name: 'Galaxy S9+' }),
+            phone(FREE),
+        ]);
+        sinon_1.default.stub(prisma_1.prisma.lease, 'findMany').resolves([]);
+        let n = 0;
+        const db = {
+            lease: {
+                create: (_a) => __awaiter(void 0, [_a], void 0, function* ({ data }) { return (Object.assign(Object.assign({}, data), { id: `lse_${++n}` })); }),
+                update: () => __awaiter(void 0, void 0, void 0, function* () { return ({}); }),
+                delete: () => __awaiter(void 0, void 0, void 0, function* () { return ({}); }),
+            },
+            portLease: {
+                updateMany: () => __awaiter(void 0, void 0, void 0, function* () { return ({ count: 0 }); }),
+                deleteMany: () => __awaiter(void 0, void 0, void 0, function* () { return ({ count: 0 }); }),
+            },
+        };
+        const ports = {
+            allocate: () => __awaiter(void 0, void 0, void 0, function* () { return ({ systemPort: 9001, chromedriverPort: 9002, mjpegServerPort: 9003 }); }),
+        };
+        svc = new LeaseService_1.LeaseService(db, store, ports, {
+            nodePairAuth: () => __awaiter(void 0, void 0, void 0, function* () { return ({ accessKey: 'k', token: 't' }); }),
+        });
+    }));
+    afterEach(() => sinon_1.default.restore());
+    function lease(filters) {
+        const app = (0, express_1.default)();
+        app.use(express_1.default.json());
+        app.use((req, _res, next) => {
+            req.auth = {
+                kind: 'bearer',
+                userId: 'usr_admin',
+                role: 'ADMIN',
+                scopes: 'admin,devices,sessions,read',
+                rateLimit: 100,
+            };
+            next();
+        });
+        app.use('/sdk/leases', (0, sdk_leases_1.makeRouter)({ leaseService: svc }));
+        return (0, loopbackRequest_1.default)(app)
+            .post('/sdk/leases')
+            .send({ filters: Object.assign({ platform: 'android', filterByHost: HOST }, filters) });
+    }
+    const busy = (udid) => __awaiter(void 0, void 0, void 0, function* () { var _a; return !!((_a = (yield store.findDevice({ udid, host: HOST }))) === null || _a === void 0 ? void 0 : _a.busy); });
+    it('skips blocked, reserved and unhealthy devices', () => __awaiter(void 0, void 0, void 0, function* () {
+        const got = [];
+        for (let i = 0; i < 5; i++) {
+            const res = yield lease({ sdk: '14' });
+            if (res.status === 201)
+                got.push(res.body.device.udid);
+        }
+        (0, chai_1.expect)(got).to.deep.equal([FREE]);
+        for (const udid of [BLOCKED, RESERVED, UNHEALTHY])
+            (0, chai_1.expect)(yield busy(udid)).to.equal(false);
+    }));
+    for (const [what, udid] of [
+        ['blocked', BLOCKED],
+        ['reserved', RESERVED],
+        ['unhealthy', UNHEALTHY],
+    ]) {
+        it(`answers 409 for a device named by udid that is ${what}, and leaves it free`, () => __awaiter(void 0, void 0, void 0, function* () {
+            const res = yield lease({ udid });
+            (0, chai_1.expect)(res.status).to.equal(409);
+            (0, chai_1.expect)(res.body.error).to.equal('all_matching_busy');
+            (0, chai_1.expect)(yield busy(udid)).to.equal(false);
+        }));
+    }
+    it('answers 404 for an unknown udid, though other devices of the platform exist', () => __awaiter(void 0, void 0, void 0, function* () {
+        const res = yield lease({ udid: 'MATCH-NO-SUCH-PHONE' });
+        (0, chai_1.expect)(res.status).to.equal(404);
+        (0, chai_1.expect)(res.body).to.deep.equal({
+            error: 'no_matching_device',
+            message: 'No device matches the filters',
+        });
+    }));
+    it('applies the sdk filter', () => __awaiter(void 0, void 0, void 0, function* () {
+        const res = yield lease({ sdk: '12' });
+        (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(201);
+        (0, chai_1.expect)(res.body.device.udid).to.equal(OLD);
+        (0, chai_1.expect)((yield lease({ sdk: '9' })).status).to.equal(404);
+    }));
+    it('applies the deviceName filter, ignoring case', () => __awaiter(void 0, void 0, void 0, function* () {
+        const res = yield lease({ deviceName: 'galaxy s9+' });
+        (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(201);
+        (0, chai_1.expect)(res.body.device.udid).to.equal(OLD);
+        (0, chai_1.expect)((yield lease({ deviceName: 'Pixel 9' })).status).to.equal(404);
+    }));
+    it('ignores availability fields the client puts in the filter', () => __awaiter(void 0, void 0, void 0, function* () {
+        const res = yield lease({ udid: BLOCKED, userBlocked: true, busy: true });
+        (0, chai_1.expect)(res.status).to.equal(409);
+        (0, chai_1.expect)(yield busy(BLOCKED)).to.equal(false);
+    }));
+});

package/lib/test/unit/lease/lease-session-ownership.spec.js

@@ -45,17 +45,18 @@ describe('LeaseService — who may use a lease for a session', () => {
                 deleteMany: sinon_1.default.stub().resolves({ count: 0 }),
             },
         };
+        const phone = {
+            udid: 'u1',
+            host: 'h1',
+            platform: 'android',
+            sdk: '14',
+            name: 'Pixel 7',
+            teamId: null,
+        };
         store = {
-            findAndLockDevice: sinon_1.default.stub().resolves({
-                udid: 'u1',
-                host: 'h1',
-                platform: 'android',
-                sdk: '14',
-                name: 'Pixel 7',
-                teamId: null,
-            }),
+            findAndLockDevice: sinon_1.default.stub().resolves(phone),
             updateDevice: sinon_1.default.stub().resolves(),
-            getDevices: sinon_1.default.stub().resolves([]),
+            getDevices: sinon_1.default.stub().resolves([phone]),
         };
         const ports = { allocate: sinon_1.default.stub().resolves({ systemPort: 9001, mjpegServerPort: 9003 }) };
         svc = new LeaseService_1.LeaseService(db, store, ports, {

package/lib/test/unit/omni-vision-failures.spec.js

@@ -0,0 +1,81 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const sinon_1 = __importDefault(require("sinon"));
+const OmniVisionService_1 = require("../../src/services/omni-vision/OmniVisionService");
+const AIService_1 = require("../../src/services/AIService");
+/**
+ * Device control's "Test locator" answered 200 with no matches when OCR or
+ * the AI call failed, which reads as "the locator finds nothing". The search
+ * now fails for a caller that asks it to (`throwOnError`). An Appium
+ * findElement still gets an empty result, which it turns into
+ * NoSuchElement, as before.
+ */
+describe('OmniVisionService search failures', () => {
+    const driver = { sessionId: 'manual_x', getScreenshot: sinon_1.default.stub() };
+    let service;
+    beforeEach(() => {
+        service = new OmniVisionService_1.OmniVisionService();
+        driver.getScreenshot = sinon_1.default.stub().resolves('aGVsbG8=');
+    });
+    afterEach(() => sinon_1.default.restore());
+    describe('findByText', () => {
+        beforeEach(() => {
+            sinon_1.default.stub(service, 'performOcr').rejects(new Error('OCR worker crashed'));
+        });
+        it('keeps answering an empty list for Appium', () => __awaiter(void 0, void 0, void 0, function* () {
+            (0, chai_1.expect)(yield service.findByText(driver, 'Login')).to.deep.equal([]);
+        }));
+        it('fails when asked to', () => __awaiter(void 0, void 0, void 0, function* () {
+            const err = yield service.findByText(driver, 'Login', { throwOnError: true }).then(() => null, (e) => e);
+            (0, chai_1.expect)(err === null || err === void 0 ? void 0 : err.message).to.equal('OCR worker crashed');
+        }));
+    });
+    describe('findByIcon', () => {
+        beforeEach(() => {
+            sinon_1.default.stub(AIService_1.AI_SERVICE, 'visualFind').rejects(new Error('AI provider timed out'));
+        });
+        it('keeps answering null for Appium', () => __awaiter(void 0, void 0, void 0, function* () {
+            (0, chai_1.expect)(yield service.findByIcon(driver, 'gear icon')).to.equal(null);
+        }));
+        it('fails when asked to', () => __awaiter(void 0, void 0, void 0, function* () {
+            const err = yield service.findByIcon(driver, 'gear icon', { throwOnError: true }).then(() => null, (e) => e);
+            (0, chai_1.expect)(err === null || err === void 0 ? void 0 : err.message).to.equal('AI provider timed out');
+        }));
+        it('still answers null, without failing, when nothing matches', () => __awaiter(void 0, void 0, void 0, function* () {
+            AIService_1.AI_SERVICE.visualFind.resolves(null);
+            (0, chai_1.expect)(yield service.findByIcon(driver, 'gear icon', { throwOnError: true })).to.equal(null);
+        }));
+    });
+    describe('AIService.visualFind', () => {
+        beforeEach(() => {
+            sinon_1.default.stub(AIService_1.AI_SERVICE, 'initializeProvider');
+        });
+        it('answers null without a provider, or fails when asked to', () => __awaiter(void 0, void 0, void 0, function* () {
+            sinon_1.default.stub(AIService_1.AI_SERVICE, 'isEnabled').returns(false);
+            (0, chai_1.expect)(yield AIService_1.AI_SERVICE.visualFind('aGVsbG8=', 'gear icon')).to.equal(null);
+            const err = yield AIService_1.AI_SERVICE.visualFind('aGVsbG8=', 'gear icon', { throwOnError: true }).then(() => null, (e) => e);
+            (0, chai_1.expect)(err === null || err === void 0 ? void 0 : err.message).to.equal('No AI provider is configured');
+        }));
+        it('answers null when the provider fails, or fails when asked to', () => __awaiter(void 0, void 0, void 0, function* () {
+            sinon_1.default.stub(AIService_1.AI_SERVICE, 'isEnabled').returns(true);
+            sinon_1.default.stub(AIService_1.AI_SERVICE, 'callProvider').rejects(new Error('429 quota exceeded'));
+            (0, chai_1.expect)(yield AIService_1.AI_SERVICE.visualFind('aGVsbG8=', 'gear icon')).to.equal(null);
+            const err = yield AIService_1.AI_SERVICE.visualFind('aGVsbG8=', 'gear icon', { throwOnError: true }).then(() => null, (e) => e);
+            (0, chai_1.expect)(err === null || err === void 0 ? void 0 : err.message).to.equal('429 quota exceeded');
+        }));
+    });
+});