@xenon-device-management/xenon 2.12.0 → 2.13.0

package/lib/src/app/routers/bug-report.js

@@ -69,7 +69,10 @@ router.post('/sessions/:sessionId/bug-report', (req, res) => __awaiter(void 0, v
     const svc = typedi_1.Container.get(BugReportService_1.BugReportService);
     let bundle;
     try {
-        bundle = yield svc.assemble({ sessionId, mode, windowSec });
+        // The network capture only for an admin, as /interceptor serves it.
+        // Through 2.12 any member who could see the session got it here.
+        const includeNetwork = (auth === null || auth === void 0 ? void 0 : auth.role) === 'ADMIN' || (auth === null || auth === void 0 ? void 0 : auth.role) === 'SUPER_ADMIN';
+        bundle = yield svc.assemble({ sessionId, mode, windowSec, includeNetwork });
     }
     catch (err) {
         if (/not found/i.test(err.message)) {

package/lib/src/app/routers/config.js

@@ -1,37 +1,4 @@
 "use strict";
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || (function () {
-    var ownKeys = function(o) {
-        ownKeys = Object.getOwnPropertyNames || function (o) {
-            var ar = [];
-            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
-            return ar;
-        };
-        return ownKeys(o);
-    };
-    return function (mod) {
-        if (mod && mod.__esModule) return mod;
-        var result = {};
-        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
-        __setModuleDefault(result, mod);
-        return result;
-    };
-})();
 var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
     return new (P || (P = Promise))(function (resolve, reject) {
@@ -43,40 +10,19 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 const express_1 = require("express");
-const config_service_1 = require("../../data-service/config-service");
-const typedi_1 = require("typedi");
-const logger_1 = __importStar(require("../../logger"));
 const AIService_1 = require("../../services/AIService");
 const scopeGuard_1 = require("../../middleware/scopeGuard");
 const roleGuard_1 = require("../../middleware/roleGuard");
 class ConfigRouter {
-    static register(router, pluginArgs) {
+    static register(router) {
         const configRouter = (0, express_1.Router)();
-        // ADMIN-tier baseline: reads (GET /config) require ADMIN+; mutations
-        // (POST /config, /test-ai) step up to SUPER_ADMIN per the matrix.
+        // GET and POST /config, and /config/reset-metrics, are the dashboard
+        // router's (dashboard.ts), which is registered first. This router's own
+        // GET and POST were never reached, and are gone. What is left: testing an
+        // AI provider, SUPER_ADMIN with the admin scope.
         configRouter.use((0, roleGuard_1.roleGuard)('ADMIN'));
-        // All mutations under /config require admin scope (global plugin
-        // config + AI provider test probes). GET passthrough for read scope.
         configRouter.use((0, scopeGuard_1.mutationScopeGuard)(['admin']));
-        function getMaskedConfig(args) {
-            const masked = Object.assign({}, args);
-            // Boolean flags for secret status
-            masked.geminiSet = !!(process.env.XENON_GEMINI_API_KEY || process.env.GEMINI_API_KEY);
-            masked.openaiSet = !!(process.env.XENON_OPENAI_API_KEY || process.env.OPENAI_API_KEY);
-            masked.anthropicSet = !!(process.env.XENON_ANTHROPIC_API_KEY || process.env.ANTHROPIC_API_KEY);
-            // Remove actual keys from the response completely
-            delete masked.geminiApiKey;
-            delete masked.openaiApiKey;
-            delete masked.anthropicApiKey;
-            if (masked.databaseUrl) {
-                masked.databaseUrl = '********';
-            }
-            return masked;
-        }
-        configRouter.get('/', (req, res) => __awaiter(this, void 0, void 0, function* () {
-            res.json(getMaskedConfig(pluginArgs));
-        }));
-        configRouter.post('/test-ai', (0, roleGuard_1.roleGuard)('SUPER_ADMIN'), (req, res) => __awaiter(this, void 0, void 0, function* () {
+        configRouter.post('/test-ai', (0, roleGuard_1.superAdminGuard)('Only a super admin can test an AI provider.'), (req, res) => __awaiter(this, void 0, void 0, function* () {
             const testConfig = req.unredactedBody || req.body;
             try {
                 const result = yield AIService_1.AI_SERVICE.testConnection(testConfig);
@@ -86,54 +32,7 @@ class ConfigRouter {
                 res.status(500).json({ success: false, message: err.message });
             }
         }));
-        configRouter.post('/', (0, roleGuard_1.roleGuard)('SUPER_ADMIN'), (req, res) => __awaiter(this, void 0, void 0, function* () {
-            const newConfig = (req.unredactedBody || req.body);
-            if (!newConfig || Object.keys(newConfig).length === 0) {
-                return res.status(400).json({ error: 'No configuration provided' });
-            }
-            // Environment-Only Enforcement: Ignore any keys sent via UI
-            delete newConfig.geminiApiKey;
-            delete newConfig.openaiApiKey;
-            delete newConfig.anthropicApiKey;
-            // Handle Database URL mask preservation
-            if (newConfig.databaseUrl && newConfig.databaseUrl.includes('****')) {
-                delete newConfig.databaseUrl;
-            }
-            try {
-                logger_1.default.debug(`Updating configuration with payload: ${JSON.stringify((0, logger_1.redactSecrets)(newConfig))}`);
-                // 1. Persist (also updates global config singleton and env vars)
-                yield typedi_1.Container.get(config_service_1.ConfigService).updateConfig(newConfig);
-                // 2. Update Runtime Object (for Appium Plugin lifecycle)
-                Object.assign(pluginArgs, newConfig);
-                logger_1.default.info('Configuration updated via API');
-                res.json({
-                    success: true,
-                    config: getMaskedConfig(pluginArgs),
-                    restartRequired: checkRestartRequired(newConfig),
-                    message: 'Configuration updated. Some changes may require a server restart to take full effect.',
-                });
-            }
-            catch (err) {
-                logger_1.default.error(`Failed to update config: ${err.message}`, err);
-                res
-                    .status(500)
-                    .json({ success: false, error: `Failed to update configuration: ${err.message}` });
-            }
-        }));
         router.use('/config', configRouter);
     }
 }
 exports.default = ConfigRouter;
-function checkRestartRequired(newConfig) {
-    // List of keys that definitely require restart
-    const RESTART_KEYS = [
-        'hub',
-        'platform',
-        'bindHostOrIp',
-        'proxy',
-        'cloud',
-        'iosDeviceType',
-        'androidDeviceType',
-    ];
-    return Object.keys(newConfig).some((key) => RESTART_KEYS.includes(key));
-}