@xenon-device-management/xenon 2.0.0 → 2.2.0

package/lib/test/unit/recordings-library-routes.spec.js

@@ -49,7 +49,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const fs = __importStar(require("fs"));
 const os = __importStar(require("os"));
 const path = __importStar(require("path"));
@@ -198,7 +198,7 @@ describe('recordings library routes', () => {
                 rec({ id: 'b', group_id: 'g2', started_at: new Date(T0 + 1000) }),
                 rec({ id: 'c', group_id: 'g3', device_udid: 'HIDDEN', started_by: 'usr_carol' }),
             ];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.recordings.map((s) => s.groupId)).to.deep.equal(['g2', 'g1']);
             (0, chai_1.expect)(res.body.recordings[0].phones[0].name).to.equal('Galaxy S9+');
@@ -211,15 +211,15 @@ describe('recordings library routes', () => {
                 rec({ id: 'a', group_id: 'g1' }),
                 rec({ id: 'b', group_id: 'g2', device_udid: 'U2', started_at: new Date(T0 + 1000) }),
             ];
-            const one = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings?limit=1');
+            const one = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings?limit=1');
             (0, chai_1.expect)(one.body.recordings.map((s) => s.groupId)).to.deep.equal(['g2']);
-            const two = yield (0, supertest_1.default)(buildApp(alice)).get(`/xenon/api/recordings?limit=1&cursor=${encodeURIComponent(one.body.nextCursor)}`);
+            const two = yield (0, loopbackRequest_1.default)(buildApp(alice)).get(`/xenon/api/recordings?limit=1&cursor=${encodeURIComponent(one.body.nextCursor)}`);
             (0, chai_1.expect)(two.body.recordings.map((s) => s.groupId)).to.deep.equal(['g1']);
-            const byPhone = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings?udid=U2');
+            const byPhone = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings?udid=U2');
             (0, chai_1.expect)(byPhone.body.recordings.map((s) => s.groupId)).to.deep.equal(['g2']);
         }));
         it('answers 400 for a bad query', () => __awaiter(void 0, void 0, void 0, function* () {
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings?since=nope');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings?since=nope');
             (0, chai_1.expect)(res.status).to.equal(400);
             (0, chai_1.expect)(res.body.error).to.equal('since must be an ISO time');
         }));
@@ -238,7 +238,7 @@ describe('recordings library routes', () => {
                     started_at: new Date(now - 40 * 24 * 60 * 60 * 1000),
                 }),
             ];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.facets.phones).to.deep.equal([
                 { udid: 'U1', name: 'Galaxy S9+', count: 1 },
@@ -250,7 +250,7 @@ describe('recordings library routes', () => {
         }));
         it('names the synthetic user of an auth-disabled server "Auth disabled"', () => __awaiter(void 0, void 0, void 0, function* () {
             rows = [rec({ started_by: 'auth-disabled' })];
-            const res = yield (0, supertest_1.default)(buildApp(admin)).get('/xenon/api/recordings');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(admin)).get('/xenon/api/recordings');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.recordings[0].startedBy).to.deep.equal({
                 id: 'auth-disabled',
@@ -266,7 +266,7 @@ describe('recordings library routes', () => {
             ctx.pluginArgs = Object.assign(Object.assign({}, original), { recordingCleanupDays: 7, recordingCleanupMaxCount: 20 });
             try {
                 rows = [rec()];
-                const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
+                const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
                 (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
                 (0, chai_1.expect)(res.body.retention).to.deep.equal({ days: 7, maxCount: 20 });
             }
@@ -296,7 +296,7 @@ describe('recordings library routes', () => {
                     ],
                 }),
             ];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(res.status).to.equal(200);
             (0, chai_1.expect)(res.body.summary.groupId).to.equal('g1');
             (0, chai_1.expect)(res.body.recordings).to.have.length(1);
@@ -312,9 +312,9 @@ describe('recordings library routes', () => {
             });
         }));
         it('answers 404 for a group that does not exist or is not visible', () => __awaiter(void 0, void 0, void 0, function* () {
-            (0, chai_1.expect)((yield (0, supertest_1.default)(buildApp(admin)).get('/xenon/api/recordings/nope')).status).to.equal(404);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(buildApp(admin)).get('/xenon/api/recordings/nope')).status).to.equal(404);
             rows = [rec({ device_udid: 'HIDDEN' })];
-            (0, chai_1.expect)((yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1')).status).to.equal(404);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1')).status).to.equal(404);
         }));
         it('sorts bookmarks and marks by timecode across every recording in the group', () => __awaiter(void 0, void 0, void 0, function* () {
             rows = [
@@ -357,7 +357,7 @@ describe('recordings library routes', () => {
                     ],
                 }),
             ];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.bookmarks.map((b) => b.id)).to.deep.equal(['b1', 'b2']);
             (0, chai_1.expect)(res.body.annotations.map((a) => a.id)).to.deep.equal(['a1', 'a2']);
@@ -388,8 +388,8 @@ describe('recordings library routes', () => {
         });
         /** hasComposite as the list, then the detail, reports it. */
         const reported = (who) => __awaiter(void 0, void 0, void 0, function* () {
-            const list = yield (0, supertest_1.default)(buildApp(who)).get('/xenon/api/recordings');
-            const detail = yield (0, supertest_1.default)(buildApp(who)).get('/xenon/api/recordings/g1');
+            const list = yield (0, loopbackRequest_1.default)(buildApp(who)).get('/xenon/api/recordings');
+            const detail = yield (0, loopbackRequest_1.default)(buildApp(who)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(list.status, JSON.stringify(list.body)).to.equal(200);
             (0, chai_1.expect)(detail.status, JSON.stringify(detail.body)).to.equal(200);
             return [list.body.recordings[0].hasComposite, detail.body.summary.hasComposite];
@@ -419,7 +419,7 @@ describe('recordings library routes', () => {
                 });
             });
             const enabled = (who) => __awaiter(void 0, void 0, void 0, function* () {
-                const res = yield (0, supertest_1.default)(buildApp(who)).get('/xenon/api/recordings/active');
+                const res = yield (0, loopbackRequest_1.default)(buildApp(who)).get('/xenon/api/recordings/active');
                 (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
                 return res.body.groups.map((g) => [g.groupId, g.compositeEnabled]);
             });
@@ -435,7 +435,7 @@ describe('recordings library routes', () => {
                 devices.set('U2', { name: 'Team B phone', platform: 'android' });
                 visible = new Set(['U1']);
                 rows = rows.map((r) => (Object.assign(Object.assign({}, r), { annotations: [{ id: `a-${r.id}`, t_ms: 1, kind: 'rect', color: '#f00', payload: '{}' }] })));
-                const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/active');
+                const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/active');
                 (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
                 const [group] = res.body.groups;
                 (0, chai_1.expect)(group.recordings.map((r) => r.udid)).to.deep.equal(['U1']);
@@ -452,14 +452,14 @@ describe('recordings library routes', () => {
                         });
                     }),
                 });
-                const res = yield (0, supertest_1.default)(buildApp(admin)).get('/xenon/api/recordings/active');
+                const res = yield (0, loopbackRequest_1.default)(buildApp(admin)).get('/xenon/api/recordings/active');
                 (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
                 (0, chai_1.expect)(res.body.groups[0].recordings.map((r) => r.udid)).to.deep.equal(['U1', 'U2']);
             }));
         });
     });
     describe('DELETE /recordings/:groupId', () => {
-        const del = (who) => (0, supertest_1.default)(buildApp(who)).delete('/xenon/api/recordings/g1');
+        const del = (who) => (0, loopbackRequest_1.default)(buildApp(who)).delete('/xenon/api/recordings/g1');
         it('lets the person who recorded it delete it: rows, then files', () => __awaiter(void 0, void 0, void 0, function* () {
             rows = [
                 rec(),
@@ -596,20 +596,20 @@ describe('recordings library routes', () => {
         const unplugged = (over = {}) => rec(Object.assign({ id: 'r2', device_udid: 'GONE', started_at: new Date(T0 + 500) }, over));
         it('still lists it, and opens it with every phone', () => __awaiter(void 0, void 0, void 0, function* () {
             rows = [rec({ group_id: 'gone', id: 'solo', device_udid: 'GONE' }), rec(), unplugged()];
-            const list = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
+            const list = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
             (0, chai_1.expect)(list.status, JSON.stringify(list.body)).to.equal(200);
             (0, chai_1.expect)(list.body.recordings.map((s) => s.groupId).sort()).to.deep.equal(['g1', 'gone']);
             const g1 = list.body.recordings.find((s) => s.groupId === 'g1');
             (0, chai_1.expect)(g1.phones.map((p) => p.udid)).to.deep.equal(['U1', 'GONE']);
-            const detail = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/gone');
+            const detail = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/gone');
             (0, chai_1.expect)(detail.status, JSON.stringify(detail.body)).to.equal(200);
             (0, chai_1.expect)(detail.body.summary.phones.map((p) => p.udid)).to.deep.equal(['GONE']);
-            const both = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
+            const both = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(both.body.summary.phones.map((p) => p.udid)).to.deep.equal(['U1', 'GONE']);
         }));
         it('can still delete it', () => __awaiter(void 0, void 0, void 0, function* () {
             rows = [rec({ device_udid: 'GONE' })];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).delete('/xenon/api/recordings/g1');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).delete('/xenon/api/recordings/g1');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(204);
             (0, chai_1.expect)(store.deleteGroupRows.calledOnceWith('g1')).to.equal(true);
         }));
@@ -617,7 +617,7 @@ describe('recordings library routes', () => {
             const file = path.join(dir, 'r2.mp4');
             fs.writeFileSync(file, 'x');
             rows = [rec(), unplugged({ file_path: file })];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r2');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r2');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
         }));
         it('is the person who started it, not someone who added a phone later', () => __awaiter(void 0, void 0, void 0, function* () {
@@ -630,14 +630,14 @@ describe('recordings library routes', () => {
                 unplugged(),
                 rec({ id: 'r3', started_by: 'usr_bob', started_at: new Date(T0 + 900) }),
             ];
-            const asAlice = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
+            const asAlice = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(asAlice.body.summary.phones.map((p) => p.recordingId).sort()).to.deep.equal([
                 'r0',
                 'r2',
                 'r3',
                 'rn',
             ]);
-            const asBob = yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1');
+            const asBob = yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(asBob.body.summary.phones.map((p) => p.recordingId).sort()).to.deep.equal([
                 'r0',
                 'r3',
@@ -650,9 +650,9 @@ describe('recordings library routes', () => {
             const file = path.join(dir, 'r2.mp4');
             fs.writeFileSync(file, 'x');
             rows = [rec(), unplugged({ started_by: 'usr_bob', file_path: file })];
-            const detail = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
+            const detail = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(detail.body.summary.phones.map((p) => p.recordingId)).to.deep.equal(['r1']);
-            const src = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r2');
+            const src = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r2');
             (0, chai_1.expect)(src.status).to.equal(404);
         }));
         // The exemption is for a phone that is gone, not for one that moved to
@@ -662,13 +662,13 @@ describe('recordings library routes', () => {
             fs.writeFileSync(file, 'x');
             devices.set('OTHER', { name: 'Team B phone', platform: 'android' });
             rows = [rec(), rec({ id: 'r2', device_udid: 'OTHER', file_path: file })];
-            const list = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
+            const list = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings');
             (0, chai_1.expect)(list.status, JSON.stringify(list.body)).to.equal(200);
             (0, chai_1.expect)(list.body.recordings[0].phones.map((p) => p.udid)).to.deep.equal(['U1']);
-            const detail = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
+            const detail = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(detail.body.summary.phones.map((p) => p.udid)).to.deep.equal(['U1']);
             (0, chai_1.expect)(detail.body.recordings.map((r) => r.id)).to.deep.equal(['r1']);
-            const src = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r2');
+            const src = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r2');
             (0, chai_1.expect)(src.status).to.equal(404);
         }));
         // The Delete button shows for the group's owner. A member who only added
@@ -679,23 +679,23 @@ describe('recordings library routes', () => {
                 rec({ device_udid: 'HIDDEN' }),
                 rec({ id: 'r2', started_by: 'usr_bob', started_at: new Date(T0 + 500) }),
             ];
-            const list = yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings');
+            const list = yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings');
             (0, chai_1.expect)(list.body.recordings[0].phones.map((p) => p.recordingId)).to.deep.equal(['r2']);
             (0, chai_1.expect)(list.body.recordings[0].startedBy).to.deep.equal({ id: 'usr_alice', name: 'Alice' });
-            const detail = yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1');
+            const detail = yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1');
             (0, chai_1.expect)(detail.body.summary.startedBy).to.deep.equal({ id: 'usr_alice', name: 'Alice' });
-            (0, chai_1.expect)((yield (0, supertest_1.default)(buildApp(bob)).delete('/xenon/api/recordings/g1')).status).to.equal(403);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(buildApp(bob)).delete('/xenon/api/recordings/g1')).status).to.equal(403);
         }));
         it('does not open it to another member: 404 everywhere', () => __awaiter(void 0, void 0, void 0, function* () {
             const file = path.join(dir, 'r1.mp4');
             fs.writeFileSync(file, 'x');
             rows = [rec({ device_udid: 'GONE', file_path: file })];
-            const list = yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings');
+            const list = yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings');
             (0, chai_1.expect)(list.body.recordings).to.deep.equal([]);
-            (0, chai_1.expect)((yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1')).status).to.equal(404);
-            (0, chai_1.expect)((yield (0, supertest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r1'))
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1')).status).to.equal(404);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(buildApp(bob)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r1'))
                 .status).to.equal(404);
-            (0, chai_1.expect)((yield (0, supertest_1.default)(buildApp(bob)).delete('/xenon/api/recordings/g1')).status).to.equal(404);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(buildApp(bob)).delete('/xenon/api/recordings/g1')).status).to.equal(404);
             (0, chai_1.expect)(store.deleteGroupRows.called).to.equal(false);
         }));
     });
@@ -738,7 +738,7 @@ describe('recordings library routes', () => {
                 { id: 'r-a', udid: 'U1', status: 'STOPPED', durationMs: 1000, sizeBytes: 10 },
                 { id: 'r-b', udid: 'U2', status: 'STOPPED', durationMs: 2000, sizeBytes: 20 },
             ]));
-            const res = yield (0, supertest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.groupId).to.equal('g1');
             (0, chai_1.expect)(res.body.recordings.map((r) => r.id)).to.deep.equal(['r-a']);
@@ -752,7 +752,7 @@ describe('recordings library routes', () => {
                 { id: 'r-a', udid: 'U1', status: 'STOPPED' },
                 { id: 'r-b', udid: 'U2', status: 'STOPPED' },
             ]));
-            const res = yield (0, supertest_1.default)(buildApp(admin)).post('/xenon/api/recordings/g1/stop');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(admin)).post('/xenon/api/recordings/g1/stop');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.recordings.map((r) => r.id).sort()).to.deep.equal(['r-a', 'r-b']);
         }));
@@ -773,7 +773,7 @@ describe('recordings library routes', () => {
                 { id: 'r-a', udid: 'U1', status: 'STOPPED' },
                 { id: 'r-b', udid: 'U2', status: 'STOPPED' },
             ]));
-            const res = yield (0, supertest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
             (0, chai_1.expect)(res.body.recordings.map((r) => r.id).sort()).to.deep.equal(['r-a', 'r-b']);
         }));
@@ -786,21 +786,21 @@ describe('recordings library routes', () => {
                 { id: 'r-a', udid: 'U1', status: 'STOPPED' },
                 { id: 'r-b', udid: 'U2', status: 'STOPPED' },
             ]));
-            const res = yield (0, supertest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
             (0, chai_1.expect)(res.body.recordings.map((r) => r.id)).to.deep.equal(['r-a']);
         }));
         it('still 500s when the orchestrator throws, without ever filtering', () => __awaiter(void 0, void 0, void 0, function* () {
             twoTeamRows();
             visible = new Set(['U1']);
             stop.rejects(new Error('ffmpeg exploded'));
-            const res = yield (0, supertest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
             (0, chai_1.expect)(res.status).to.equal(500);
             (0, chai_1.expect)(res.body).to.deep.equal({ error: 'internal', message: 'ffmpeg exploded' });
         }));
         it('a group with no visible phones is not found, and is not stopped', () => __awaiter(void 0, void 0, void 0, function* () {
             twoTeamRows();
             visible = new Set(); // neither U1 nor U2 is on alice's team
-            const res = yield (0, supertest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).post('/xenon/api/recordings/g1/stop');
             (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(404);
             (0, chai_1.expect)(res.body).to.deep.equal({ error: 'not_found' });
             (0, chai_1.expect)(stop.called).to.equal(false);
@@ -820,7 +820,7 @@ describe('recordings library routes', () => {
             typedi_1.Container.set(annotation_render_1.AnnotationRenderService, { renderForRecording: render });
         });
         afterEach(() => restoreRender());
-        const get = (who, id) => (0, supertest_1.default)(buildApp(who))
+        const get = (who, id) => (0, loopbackRequest_1.default)(buildApp(who))
             .get(`/xenon/api/recordings/g1/exports/annotated.mp4?recordingId=${id}`)
             .buffer(true)
             .parse((r, cb) => {
@@ -865,7 +865,7 @@ describe('recordings library routes', () => {
             const file = path.join(dir, 'r1.mp4');
             fs.writeFileSync(file, Buffer.from('0123456789'));
             rows = [rec({ file_path: file })];
-            const res = yield (0, supertest_1.default)(buildApp(alice))
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice))
                 .get('/xenon/api/recordings/g1/source.mp4?recordingId=r1')
                 .set('Range', 'bytes=2-5')
                 .buffer(true)
@@ -891,7 +891,7 @@ describe('recordings library routes', () => {
                 rec({ file_path: visibleFile }),
                 rec({ id: 'r2', device_udid: 'GONE', file_path: file }),
             ];
-            const get = (who, id) => (0, supertest_1.default)(buildApp(who)).get(`/xenon/api/recordings/g1/source.mp4?recordingId=${id}`);
+            const get = (who, id) => (0, loopbackRequest_1.default)(buildApp(who)).get(`/xenon/api/recordings/g1/source.mp4?recordingId=${id}`);
             (0, chai_1.expect)((yield get(bob, 'r1')).status).to.equal(200);
             (0, chai_1.expect)(store.findVideo.calledWith('r1')).to.equal(true);
             (0, chai_1.expect)(store.listGroupStarts.called, 'a visible phone needs no owner').to.equal(false);
@@ -908,9 +908,9 @@ describe('recordings library routes', () => {
             fs.writeFileSync(file, Buffer.from('0123456789'));
             rows = [rec({ file_path: file })];
             const url = '/xenon/api/recordings/g1/source.mp4?recordingId=r1&download=1';
-            const fileEtag = (yield (0, supertest_1.default)(buildApp(alice)).get(url)).headers.etag;
+            const fileEtag = (yield (0, loopbackRequest_1.default)(buildApp(alice)).get(url)).headers.etag;
             (0, chai_1.expect)(fileEtag, "the file's own ETag").to.be.a('string');
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get(url).set('Range', 'bytes=9999-10000');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get(url).set('Range', 'bytes=9999-10000');
             (0, chai_1.expect)(res.status).to.equal(416);
             (0, chai_1.expect)(res.headers['content-type']).to.match(/^application\/json/);
             (0, chai_1.expect)(res.headers['content-range']).to.equal('bytes */10');
@@ -922,13 +922,13 @@ describe('recordings library routes', () => {
             const file = path.join(dir, 'r1.mp4');
             fs.writeFileSync(file, 'x');
             rows = [rec({ file_path: file })];
-            const res = yield (0, supertest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r1&download=1');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(alice)).get('/xenon/api/recordings/g1/source.mp4?recordingId=r1&download=1');
             (0, chai_1.expect)(res.status).to.equal(200);
             (0, chai_1.expect)(res.headers['content-disposition']).to.match(/attachment; filename="U1\.mp4"/);
         }));
         it('answers 400 without a recording, and 404 for another group, an invisible phone or a missing file', () => __awaiter(void 0, void 0, void 0, function* () {
             rows = [rec(), rec({ id: 'rx', group_id: 'g2' }), rec({ id: 'rh', device_udid: 'HIDDEN' })];
-            const get = (q) => (0, supertest_1.default)(buildApp(bob)).get(`/xenon/api/recordings/g1/source.mp4${q}`);
+            const get = (q) => (0, loopbackRequest_1.default)(buildApp(bob)).get(`/xenon/api/recordings/g1/source.mp4${q}`);
             (0, chai_1.expect)((yield get('')).status).to.equal(400);
             (0, chai_1.expect)((yield get('?recordingId=rx')).status).to.equal(404);
             (0, chai_1.expect)((yield get('?recordingId=rh')).status).to.equal(404);

package/lib/test/unit/recordings-write-visibility.spec.js

@@ -49,7 +49,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const typedi_1 = require("typedi");
 const recordings_1 = __importDefault(require("../../src/app/routers/recordings"));
 const RecordingOrchestrator_1 = require("../../src/services/recording/RecordingOrchestrator");
@@ -164,7 +164,7 @@ describe('recording write routes: team visibility', () => {
     const alice = { userId: 'usr_alice', teamIds: ['t1'] };
     const bob = { userId: 'usr_bob', teamIds: ['t1'] };
     const admin = { userId: 'usr_root', role: 'ADMIN' };
-    const post = (who, url, body = {}) => (0, supertest_1.default)(buildApp(who)).post(`/xenon/api/recordings${url}`).send(body);
+    const post = (who, url, body = {}) => (0, loopbackRequest_1.default)(buildApp(who)).post(`/xenon/api/recordings${url}`).send(body);
     const notFound = (res) => {
         (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(404);
         (0, chai_1.expect)(res.body).to.deep.equal({ error: 'not_found' });

package/lib/test/unit/remote-session-create.spec.js

@@ -0,0 +1,130 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const sinon_1 = __importDefault(require("sinon"));
+const express_1 = __importDefault(require("express"));
+const typedi_1 = require("typedi");
+const SessionLifecycleService_1 = require("../../src/services/SessionLifecycleService");
+const PluginContext_1 = require("../../src/PluginContext");
+const IPluginArgs_1 = require("../../src/interfaces/IPluginArgs");
+const deviceService = __importStar(require("../../src/data-service/device-service"));
+const SessionManager_1 = require("../../src/sessions/SessionManager");
+const SessionType_1 = __importDefault(require("../../src/enums/SessionType"));
+const nodeWebDriverUrl_1 = require("../../src/gateway/nodeWebDriverUrl");
+const container_registration_1 = require("../helpers/container-registration");
+const loopbackServer_1 = require("../helpers/loopbackServer");
+const loki_stores_1 = require("../helpers/loki-stores");
+/**
+ * A session the hub creates on a node's phone (today's createSession path,
+ * through the plugin):
+ * - it is created under the node's own base path, which need not be the hub's;
+ * - it is registered in SESSION_MANAGER whatever the dashboard and video
+ *   settings, because that is where the session gateway finds it.
+ */
+describe('a session the hub creates on a node', () => {
+    // The in-memory stores, also when this file runs on its own: without
+    // NODE_ENV=test the factory handed out the Prisma stores, which are the
+    // developer's ~/.cache/xenon/xenon.db.
+    (0, loki_stores_1.useLokiStores)();
+    const loopback = (0, loopbackServer_1.loopbackServers)();
+    let nodeOrigin;
+    let created;
+    let context;
+    let saved;
+    let restore;
+    const SESSION = 'node-session-1';
+    beforeEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        created = [];
+        const node = (0, express_1.default)();
+        node.use(express_1.default.json());
+        // The node's Appium runs at the root; the hub's at /wd/hub.
+        node.get('/xenon/api/webdriver', (0, nodeWebDriverUrl_1.webdriverInfoHandler)(() => ''));
+        node.post('/session', (req, res) => {
+            created.push({ url: req.originalUrl, body: req.body });
+            res.json({ value: { sessionId: SESSION, capabilities: { platformName: 'Android' } } });
+        });
+        const server = yield loopback.serve(node);
+        nodeOrigin = `http://127.0.0.1:${server.address().port}`;
+        restore = (0, container_registration_1.saveRegistrations)(nodeWebDriverUrl_1.NodeBasePathResolver);
+        typedi_1.Container.set(nodeWebDriverUrl_1.NodeBasePathResolver, new nodeWebDriverUrl_1.NodeBasePathResolver());
+        context = typedi_1.Container.get(PluginContext_1.PluginContext);
+        saved = Object.assign({}, context);
+        context.pluginArgs = Object.assign(Object.assign({}, IPluginArgs_1.DefaultPluginArgs), { enableDashboard: false });
+        context.nodeId = 'hub-node-id';
+        context.nodeBasePath = '/wd/hub';
+        sinon_1.default.stub(deviceService, 'updatedAllocatedDevice').resolves();
+    }));
+    afterEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        SessionManager_1.SESSION_MANAGER.removeSession(SESSION);
+        Object.assign(context, saved);
+        sinon_1.default.restore();
+        restore();
+        yield loopback.closeAll();
+    }));
+    const device = () => ({ udid: 'u1', host: nodeOrigin, nodeId: 'node-peer', platform: 'android' });
+    const caps = {
+        alwaysMatch: { platformName: 'Android', 'xe:options': { recordVideo: false } },
+        firstMatch: [{}],
+    };
+    it('is created under the node’s own base path', () => __awaiter(void 0, void 0, void 0, function* () {
+        const svc = new SessionLifecycleService_1.SessionLifecycleService();
+        const response = yield svc.forwardSessionRequest(device(), caps);
+        (0, chai_1.expect)(created.map((c) => c.url)).to.deep.equal(['/session']);
+        (0, chai_1.expect)(response.value[0]).to.equal(SESSION);
+    }));
+    it('is registered in SESSION_MANAGER with the node’s URL, with the dashboard and video off', () => __awaiter(void 0, void 0, void 0, function* () {
+        const svc = new SessionLifecycleService_1.SessionLifecycleService();
+        sinon_1.default.stub(svc, 'getFreshDevice').callsFake((d) => __awaiter(void 0, void 0, void 0, function* () { return d; }));
+        yield svc.finalizeSession({ protocol: 'W3C', value: [SESSION, { platformName: 'Android' }, 'W3C'] }, device(), caps, {}, true);
+        const session = SessionManager_1.SESSION_MANAGER.getSession(SESSION);
+        (0, chai_1.expect)(session, 'registered').to.not.equal(undefined);
+        (0, chai_1.expect)(session.getType()).to.equal(SessionType_1.default.REMOTE);
+        (0, chai_1.expect)(session.getWebDriverUrl()).to.equal(nodeOrigin);
+    }));
+});

package/lib/test/unit/reservation-team-visibility.spec.js

@@ -49,7 +49,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const reservation_1 = __importDefault(require("../../src/app/routers/reservation"));
 const deviceService = __importStar(require("../../src/data-service/device-service"));
 const prisma_1 = require("../../src/prisma");
@@ -105,13 +105,13 @@ function buildApp(caller) {
     app.use('/reservation', reservation_1.default);
     return app;
 }
-const reserve = (caller, udid) => (0, supertest_1.default)(buildApp(caller))
+const reserve = (caller, udid) => (0, loopbackRequest_1.default)(buildApp(caller))
     .post('/reservation')
     .send({ udid, host: HOST, reservedBy: 'alice', duration: '1h' });
-const extend = (caller, udid) => (0, supertest_1.default)(buildApp(caller))
+const extend = (caller, udid) => (0, loopbackRequest_1.default)(buildApp(caller))
     .post(`/reservation/${udid}/${encodeURIComponent(HOST)}/extend`)
     .send({ duration: '1h' });
-const release = (caller, udid) => (0, supertest_1.default)(buildApp(caller)).delete(`/reservation/${udid}/${encodeURIComponent(HOST)}`);
+const release = (caller, udid) => (0, loopbackRequest_1.default)(buildApp(caller)).delete(`/reservation/${udid}/${encodeURIComponent(HOST)}`);
 describe('reservations respect the team boundary', () => {
     let reserveDevice;
     let releaseReservation;
@@ -176,7 +176,7 @@ describe('reservations respect the team boundary', () => {
     }));
     describe('the list', () => {
         const listed = (caller) => __awaiter(void 0, void 0, void 0, function* () {
-            const res = yield (0, supertest_1.default)(buildApp(caller)).get('/reservation');
+            const res = yield (0, loopbackRequest_1.default)(buildApp(caller)).get('/reservation');
             (0, chai_1.expect)(res.status).to.equal(200);
             return res.body.reservations.map((r) => r.udid).sort();
         });