@xenon-device-management/xenon 2.0.0 → 2.2.0

package/lib/test/unit/port-allocator-os-probe.spec.js

@@ -0,0 +1,151 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const net_1 = __importDefault(require("net"));
+const sinon_1 = __importDefault(require("sinon"));
+const PortAllocator_1 = require("../../src/services/PortAllocator");
+const scratch_port_leases_1 = require("../helpers/scratch-port-leases");
+const SHAPES = [
+    { host: '127.0.0.1', label: 'IPv4 loopback (127.0.0.1)' },
+    { host: '::1', label: 'IPv6 loopback (::1)' },
+    { host: '0.0.0.0', label: 'IPv4 wildcard (0.0.0.0)' },
+    { host: '::', label: 'IPv6 wildcard, dual-stack (::) — what iproxy does' },
+    { host: '::', ipv6Only: true, label: 'IPv6 wildcard, v6-only (::)' },
+];
+function listen(port, host, ipv6Only = false) {
+    return new Promise((resolve, reject) => {
+        const server = net_1.default.createServer((socket) => socket.destroy());
+        server.once('error', reject);
+        server.listen({ port, host, ipv6Only }, () => resolve(server));
+    });
+}
+function close(server) {
+    return new Promise((resolve) => server.close(() => resolve()));
+}
+describe('PortAllocator OS probe and lease ownership (real sockets, scratch DB)', () => {
+    const scratch = (0, scratch_port_leases_1.useScratchPortLeases)();
+    let allocator;
+    let servers;
+    beforeEach(() => {
+        allocator = new PortAllocator_1.PortAllocator();
+        allocator.configure({
+            mjpeg: [scratch.base, scratch.base + 1],
+            wda: [scratch.base + 50, scratch.base + 51],
+        });
+        servers = [];
+    });
+    afterEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        yield Promise.all(servers.map(close));
+        sinon_1.default.restore();
+    }));
+    function occupy(port, shape) {
+        return __awaiter(this, void 0, void 0, function* () {
+            servers.push(yield listen(port, shape.host, shape.ipv6Only));
+        });
+    }
+    function leaseOf(port) {
+        return __awaiter(this, void 0, void 0, function* () {
+            return scratch.db.portLease.findUnique({ where: { port } });
+        });
+    }
+    describe('acquire skips a port something is listening on', () => {
+        for (const shape of SHAPES) {
+            it(`a listener on ${shape.label}`, () => __awaiter(void 0, void 0, void 0, function* () {
+                var _a;
+                yield occupy(scratch.base, shape);
+                const port = yield allocator.acquire('mjpeg', 'android-s9');
+                (0, chai_1.expect)(port, `must not lease a port with a listener on ${shape.host}`).to.equal(scratch.base + 1);
+                (0, chai_1.expect)(yield leaseOf(scratch.base)).to.equal(null);
+                (0, chai_1.expect)((_a = (yield leaseOf(scratch.base + 1))) === null || _a === void 0 ? void 0 : _a.leasedToUdid).to.equal('android-s9');
+            }));
+        }
+        it("drops the udid's own stale lease when an iproxy-shaped listener holds the port", () => __awaiter(void 0, void 0, void 0, function* () {
+            // The reuse path: the S9+ still has a lease row on the port while the
+            // iPhone's iproxy is the one listening there.
+            const now = Date.now();
+            yield scratch.db.portLease.create({
+                data: {
+                    port: scratch.base,
+                    purpose: 'mjpeg',
+                    leasedToUdid: 'android-s9',
+                    leasedAt: now,
+                    expiresAt: now + 60000,
+                },
+            });
+            yield occupy(scratch.base, SHAPES[3]);
+            const port = yield allocator.acquire('mjpeg', 'android-s9');
+            (0, chai_1.expect)(port).to.equal(scratch.base + 1);
+            (0, chai_1.expect)(yield leaseOf(scratch.base)).to.equal(null);
+        }));
+    });
+    it('still leases a port nothing is listening on', () => __awaiter(void 0, void 0, void 0, function* () {
+        const port = yield allocator.acquire('mjpeg', 'android-s9');
+        (0, chai_1.expect)(port).to.equal(scratch.base);
+        const row = yield leaseOf(scratch.base);
+        (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.leasedToUdid).to.equal('android-s9');
+        (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.purpose).to.equal('mjpeg');
+    }));
+    describe('a host without IPv6', () => {
+        it('does not count an IPv6 address it cannot bind as "in use"', () => __awaiter(void 0, void 0, void 0, function* () {
+            const probe = sinon_1.default.stub(allocator, 'bindProbe').callsFake((...args) => __awaiter(void 0, void 0, void 0, function* () {
+                const host = args[1];
+                if (host === '::')
+                    return 'EAFNOSUPPORT';
+                if (host === '::1')
+                    return 'EADDRNOTAVAIL';
+                return null;
+            }));
+            (0, chai_1.expect)(yield allocator.acquire('mjpeg', 'android-s9')).to.equal(scratch.base);
+            const hosts = probe.getCalls().map((c) => c.args[1]);
+            (0, chai_1.expect)(hosts).to.include.members(['127.0.0.1', '0.0.0.0', '::1', '::']);
+        }));
+        it('still counts EADDRINUSE on an IPv6 address as in use', () => __awaiter(void 0, void 0, void 0, function* () {
+            sinon_1.default.stub(allocator, 'bindProbe').callsFake((...args) => __awaiter(void 0, void 0, void 0, function* () {
+                const [port, host] = args;
+                return host === '::' && port === scratch.base ? 'EADDRINUSE' : null;
+            }));
+            (0, chai_1.expect)(yield allocator.acquire('mjpeg', 'android-s9')).to.equal(scratch.base + 1);
+        }));
+    });
+    describe('release is scoped to the lease holder', () => {
+        it("leaves another udid's lease on the same port alone", () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            const port = yield allocator.acquire('mjpeg', 'android-s9');
+            yield allocator.release(port, 'iphone-17');
+            (0, chai_1.expect)((_a = (yield leaseOf(port))) === null || _a === void 0 ? void 0 : _a.leasedToUdid, 'a stale owner must not free a live lease').to.equal('android-s9');
+        }));
+        it('deletes the lease when the holder releases it', () => __awaiter(void 0, void 0, void 0, function* () {
+            const port = yield allocator.acquire('mjpeg', 'android-s9');
+            yield allocator.release(port, 'android-s9');
+            (0, chai_1.expect)(yield leaseOf(port)).to.equal(null);
+        }));
+    });
+    describe('claim: leasing a port the udid is already serving on', () => {
+        it('leases a port with a live listener, which acquire would refuse', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield occupy(scratch.base + 50, SHAPES[3]);
+            (0, chai_1.expect)(yield allocator.claim('wda', 'iphone-17', scratch.base + 50)).to.equal(true);
+            const row = yield leaseOf(scratch.base + 50);
+            (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.leasedToUdid).to.equal('iphone-17');
+            (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.purpose).to.equal('wda');
+        }));
+        it("refuses, and keeps the row, when another udid holds the port's lease", () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            const held = yield allocator.acquire('wda', 'iphone-other');
+            (0, chai_1.expect)(yield allocator.claim('wda', 'iphone-17', held)).to.equal(false);
+            (0, chai_1.expect)((_a = (yield leaseOf(held))) === null || _a === void 0 ? void 0 : _a.leasedToUdid).to.equal('iphone-other');
+        }));
+    });
+});

package/lib/test/unit/profile-router.test.js

@@ -16,7 +16,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const profile_1 = require("../../src/app/routers/profile");
 const typedi_1 = require("typedi");
 const ApiKeyService_1 = require("../../src/services/ApiKeyService");
@@ -34,13 +34,13 @@ describe('profile router', () => {
     it('GET /profile/access-key returns the caller accessKey', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(typedi_1.Container.get(UserService_1.UserService), 'findById').resolves({ accessKey: 'xen_abc' });
         const app = appWithAuth({ userId: 'u1', role: 'ADMIN', scopes: 'devices,sessions,read' });
-        const r = yield (0, supertest_1.default)(app).get('/profile/access-key');
+        const r = yield (0, loopbackRequest_1.default)(app).get('/profile/access-key');
         (0, chai_1.expect)(r.body.accessKey).to.equal('xen_abc');
     }));
     it('POST /profile/access-key/rotate returns a new accessKey', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(typedi_1.Container.get(UserService_1.UserService), 'rotateAccessKey').resolves({ id: 'u1', accessKey: 'xen_NEW' });
         const app = appWithAuth({ userId: 'u1', role: 'ADMIN', scopes: 'devices,sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/access-key/rotate');
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/access-key/rotate');
         (0, chai_1.expect)(r.body.accessKey).to.equal('xen_NEW');
     }));
     it('GET /profile/tokens lists caller tokens without secrets', () => __awaiter(void 0, void 0, void 0, function* () {
@@ -48,7 +48,7 @@ describe('profile router', () => {
             { id: 'k1', name: 'CI', scopes: 'sessions,read', expiresAt: null, createdAt: new Date(), lastUsedAt: null },
         ]);
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).get('/profile/tokens');
+        const r = yield (0, loopbackRequest_1.default)(app).get('/profile/tokens');
         (0, chai_1.expect)(r.body[0].name).to.equal('CI');
         (0, chai_1.expect)(r.body[0].keyHash).to.be.undefined;
     }));
@@ -56,14 +56,14 @@ describe('profile router', () => {
         const create = sinon_1.default.stub(typedi_1.Container.get(ApiKeyService_1.ApiKeyService), 'create')
             .resolves({ id: 'k2', raw: 'rawsecret' });
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI' });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI' });
         (0, chai_1.expect)(r.status).to.equal(201);
         (0, chai_1.expect)(r.body.token).to.equal('rawsecret');
         (0, chai_1.expect)(create.firstCall.args[0].scopes).to.deep.equal(['sessions', 'read']);
     }));
     it('POST /profile/tokens rejects an attempt to widen scopes', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', scopes: ['admin'] });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', scopes: ['admin'] });
         (0, chai_1.expect)(r.status).to.equal(400);
         (0, chai_1.expect)(r.body.error).to.match(/cannot widen/);
     }));
@@ -73,7 +73,7 @@ describe('profile router', () => {
             .resolves({ id: 'k3', raw: 'rawsecret' });
         const future = new Date(Date.now() + 30 * 24 * 60 * 60000).toISOString();
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: future });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: future });
         (0, chai_1.expect)(r.status).to.equal(201);
         (0, chai_1.expect)(r.body.expiresAt).to.equal(future);
         (0, chai_1.expect)((_a = create.firstCall.args[0].expiresAt) === null || _a === void 0 ? void 0 : _a.toISOString()).to.equal(future);
@@ -81,13 +81,13 @@ describe('profile router', () => {
     it('POST /profile/tokens rejects a past expiresAt with 400', () => __awaiter(void 0, void 0, void 0, function* () {
         const past = new Date(Date.now() - 60000).toISOString();
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: past });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: past });
         (0, chai_1.expect)(r.status).to.equal(400);
         (0, chai_1.expect)(r.body.error).to.match(/future/);
     }));
     it('POST /profile/tokens rejects an unparseable expiresAt with 400', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: 'not-a-date' });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: 'not-a-date' });
         (0, chai_1.expect)(r.status).to.equal(400);
         (0, chai_1.expect)(r.body.error).to.match(/ISO-8601/);
     }));
@@ -95,14 +95,14 @@ describe('profile router', () => {
         sinon_1.default.stub(prisma_1.prisma.apiKey, 'findFirst').resolves({ id: 'k1', userId: 'u1' });
         const revoke = sinon_1.default.stub(typedi_1.Container.get(ApiKeyService_1.ApiKeyService), 'revoke').resolves(undefined);
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).delete('/profile/tokens/k1');
+        const r = yield (0, loopbackRequest_1.default)(app).delete('/profile/tokens/k1');
         (0, chai_1.expect)(r.status).to.equal(204);
         (0, chai_1.expect)(revoke.calledOnceWithExactly('k1')).to.be.true;
     }));
     it('DELETE /profile/tokens/:id 404s when the token belongs to someone else', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(prisma_1.prisma.apiKey, 'findFirst').resolves(null);
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).delete('/profile/tokens/k1');
+        const r = yield (0, loopbackRequest_1.default)(app).delete('/profile/tokens/k1');
         (0, chai_1.expect)(r.status).to.equal(404);
     }));
 });

package/lib/test/unit/queue-requester.spec.js

@@ -61,6 +61,7 @@ const IPluginArgs_1 = require("../../src/interfaces/IPluginArgs");
 const config_1 = require("../../src/config");
 const prisma_1 = require("../../src/prisma");
 const container_registration_1 = require("../helpers/container-registration");
+const loki_stores_1 = require("../helpers/loki-stores");
 /**
  * createSession writes who asked onto the pending-session row, so the queue
  * can show a member her own and her team's requests. It goes on that row only:
@@ -79,6 +80,10 @@ const caps = (extra = {}) => ({
 });
 const withKey = (accessKey, extra = {}) => caps(Object.assign({ 'xe:options': { accessKey, token: 'tk' } }, extra));
 describe('createSession records who asked on the pending-session row', () => {
+    // The in-memory stores, also when this file runs on its own: without
+    // NODE_ENV=test the factory handed out the Prisma stores, which are the
+    // developer's ~/.cache/xenon/xenon.db.
+    (0, loki_stores_1.useLokiStores)();
     let svc;
     let device;
     let context;

package/lib/test/unit/queue-team-scope-routes.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const sinon_1 = __importDefault(require("sinon"));
 const grid_1 = __importDefault(require("../../src/app/routers/grid"));
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
@@ -120,24 +120,24 @@ describe('the session queue is team-scoped: own teams + a count', () => {
     afterEach(() => sinon_1.default.restore());
     describe('a member in team A', () => {
         it("GET /queue shows the request for her team's phone and her teammate's, nothing else", () => __awaiter(void 0, void 0, void 0, function* () {
-            const r = yield (0, supertest_1.default)(alice()).get('/queue');
+            const r = yield (0, loopbackRequest_1.default)(alice()).get('/queue');
             (0, chai_1.expect)(r.status).to.equal(200);
             (0, chai_1.expect)(ids(r.body)).to.deep.equal(['targets-a', 'untargeted-a']);
             (0, chai_1.expect)(JSON.stringify(r.body)).to.not.include('bob-secret-release');
             (0, chai_1.expect)(JSON.stringify(r.body)).to.not.include('bob-targeted');
         }));
         it('GET /queue never returns who asked', () => __awaiter(void 0, void 0, void 0, function* () {
-            const r = yield (0, supertest_1.default)(alice()).get('/queue');
+            const r = yield (0, loopbackRequest_1.default)(alice()).get('/queue');
             for (const shown of r.body)
                 (0, chai_1.expect)(shown).to.not.have.property(REQUESTER);
         }));
         it('GET /queue/length is the whole queue, the number every caller gets', () => __awaiter(void 0, void 0, void 0, function* () {
-            const r = yield (0, supertest_1.default)(alice()).get('/queue/length');
+            const r = yield (0, loopbackRequest_1.default)(alice()).get('/queue/length');
             (0, chai_1.expect)(r.status).to.equal(200);
             (0, chai_1.expect)(r.body).to.equal(4);
         }));
         it('GET /queue/summary agrees with /queue/length, and counts what she cannot see', () => __awaiter(void 0, void 0, void 0, function* () {
-            const r = yield (0, supertest_1.default)(alice()).get('/queue/summary');
+            const r = yield (0, loopbackRequest_1.default)(alice()).get('/queue/summary');
             (0, chai_1.expect)(r.status).to.equal(200);
             (0, chai_1.expect)(r.body.total).to.equal(4);
             (0, chai_1.expect)(r.body.otherCount).to.equal(2);
@@ -145,17 +145,17 @@ describe('the session queue is team-scoped: own teams + a count', () => {
             (0, chai_1.expect)(byPlatform.reduce((n, p) => n + p.count, 0)).to.equal(4);
         }));
         it("GET /queue/status answers for another team's request exactly as for an unknown id", () => __awaiter(void 0, void 0, void 0, function* () {
-            const unknown = yield (0, supertest_1.default)(alice()).get('/queue/status/no-such-request');
+            const unknown = yield (0, loopbackRequest_1.default)(alice()).get('/queue/status/no-such-request');
             (0, chai_1.expect)(unknown.status).to.equal(404);
             for (const hidden of ['targets-b', 'untargeted-b']) {
-                const r = yield (0, supertest_1.default)(alice()).get(`/queue/status/${hidden}`);
+                const r = yield (0, loopbackRequest_1.default)(alice()).get(`/queue/status/${hidden}`);
                 (0, chai_1.expect)(r.status, hidden).to.equal(404);
                 (0, chai_1.expect)(r.body, hidden).to.deep.equal(unknown.body);
             }
         }));
         it('GET /queue/status still answers for the requests she can see', () => __awaiter(void 0, void 0, void 0, function* () {
             for (const shown of ['targets-a', 'untargeted-a']) {
-                const r = yield (0, supertest_1.default)(alice()).get(`/queue/status/${shown}`);
+                const r = yield (0, loopbackRequest_1.default)(alice()).get(`/queue/status/${shown}`);
                 (0, chai_1.expect)(r.status, shown).to.equal(200);
                 (0, chai_1.expect)(r.body.platform, shown).to.equal('android');
             }
@@ -163,25 +163,25 @@ describe('the session queue is team-scoped: own teams + a count', () => {
     });
     describe('an admin', () => {
         it('GET /queue shows all four', () => __awaiter(void 0, void 0, void 0, function* () {
-            const r = yield (0, supertest_1.default)(admin()).get('/queue');
+            const r = yield (0, loopbackRequest_1.default)(admin()).get('/queue');
             (0, chai_1.expect)(r.status).to.equal(200);
             (0, chai_1.expect)(ids(r.body)).to.deep.equal(['targets-a', 'targets-b', 'untargeted-a', 'untargeted-b']);
             for (const shown of r.body)
                 (0, chai_1.expect)(shown).to.not.have.property(REQUESTER);
         }));
         it('with no lookup of phones or teams', () => __awaiter(void 0, void 0, void 0, function* () {
-            yield (0, supertest_1.default)(admin()).get('/queue');
+            yield (0, loopbackRequest_1.default)(admin()).get('/queue');
             (0, chai_1.expect)(prisma_1.prisma.device.findMany.called).to.equal(false);
             (0, chai_1.expect)(prisma_1.prisma.teamMember.findMany.called).to.equal(false);
         }));
         it('GET /queue/summary counts nothing as hidden', () => __awaiter(void 0, void 0, void 0, function* () {
-            const r = yield (0, supertest_1.default)(admin()).get('/queue/summary');
+            const r = yield (0, loopbackRequest_1.default)(admin()).get('/queue/summary');
             (0, chai_1.expect)(r.body.total).to.equal(4);
             (0, chai_1.expect)(r.body.otherCount).to.equal(0);
         }));
         it('GET /queue/length and /queue/status answer as before', () => __awaiter(void 0, void 0, void 0, function* () {
-            (0, chai_1.expect)((yield (0, supertest_1.default)(admin()).get('/queue/length')).body).to.equal(4);
-            const r = yield (0, supertest_1.default)(admin()).get('/queue/status/untargeted-b');
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(admin()).get('/queue/length')).body).to.equal(4);
+            const r = yield (0, loopbackRequest_1.default)(admin()).get('/queue/status/untargeted-b');
             (0, chai_1.expect)(r.status).to.equal(200);
         }));
     });
@@ -195,13 +195,14 @@ describe('the session queue is team-scoped: own teams + a count', () => {
             ['an admin', admin],
         ]) {
             it(`are never returned to ${who}`, () => __awaiter(void 0, void 0, void 0, function* () {
-                const r = yield (0, supertest_1.default)(caller()).get('/queue');
+                const r = yield (0, loopbackRequest_1.default)(caller()).get('/queue');
                 const shown = r.body.find((x) => x.capability_id === 'untargeted-a');
                 (0, chai_1.expect)(shown, 'the request itself is shown').to.not.equal(undefined);
                 (0, chai_1.expect)(JSON.stringify(r.body)).to.not.include('amy-api-token');
                 (0, chai_1.expect)(JSON.stringify(r.body)).to.not.include('amy.session.jwt');
-                // What isn't a secret still reads as before.
-                (0, chai_1.expect)(shown['xe:options'].accessKey).to.equal('ak_amy');
+                // Nor the access key: half of the pair, and it names Amy's key.
+                (0, chai_1.expect)(JSON.stringify(r.body)).to.not.include('ak_amy');
+                // What isn't a credential still reads as before.
                 (0, chai_1.expect)(shown['xenon:options'].sessionName).to.equal('amy-login');
             }));
         }

package/lib/test/unit/queue-visibility.spec.js

@@ -102,7 +102,7 @@ describe('queue visibility', () => {
             (0, chai_1.expect)(yield seen([untargeted, targeted], alice)).to.deep.equal([false, false]);
         }));
         it('a credential narrowed to her team, whatever teams its user is in', () => __awaiter(void 0, void 0, void 0, function* () {
-            // A team-bound key, a session token's teamId claim, or xenon:team.
+            // A team-bound key, a session token's teamId claim, or xe:options.team.
             (0, chai_1.expect)(yield seen([req({ userId: 'bob', teamId: 'team-a' })], alice)).to.deep.equal([true]);
         }));
         it("not a teammate's request narrowed to another team", () => __awaiter(void 0, void 0, void 0, function* () {

package/lib/test/unit/recording-downloads-visibility.spec.js

@@ -49,7 +49,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const fs = __importStar(require("fs"));
 const os = __importStar(require("os"));
 const path = __importStar(require("path"));
@@ -104,7 +104,7 @@ function binary(res, cb) {
 }
 function get(caller_1, url_1) {
     return __awaiter(this, arguments, void 0, function* (caller, url, headers = {}) {
-        let req = (0, supertest_1.default)(buildApp(caller)).get(`/xenon/api/recordings/${GROUP}/${url}`);
+        let req = (0, loopbackRequest_1.default)(buildApp(caller)).get(`/xenon/api/recordings/${GROUP}/${url}`);
         for (const [k, v] of Object.entries(headers))
             req = req.set(k, v);
         const res = yield req.buffer(true).parse(binary);

package/lib/test/unit/recording-instrumentation.spec.js

@@ -21,6 +21,7 @@ const path_1 = __importDefault(require("path"));
 const api_1 = require("@opentelemetry/api");
 const attributes_1 = require("../../src/services/telemetry/attributes");
 const artifact_store_1 = require("../helpers/artifact-store");
+const loki_stores_1 = require("../helpers/loki-stores");
 // Stub metrics + trace BEFORE the module loads so the module-level
 // ensureOtelInstruments() picks up our mocks. Inline import after stubbing.
 function makeMockMeter() {
@@ -56,6 +57,10 @@ function makeMockSpan() {
     };
 }
 describe('RecordingOrchestrator instrumentation', () => {
+    // The in-memory stores, also when this file runs on its own: without
+    // NODE_ENV=test the factory handed out the Prisma stores, which are the
+    // developer's ~/.cache/xenon/xenon.db.
+    (0, loki_stores_1.useLokiStores)();
     // RecordingOrchestrator resolves ARTIFACT_STORE from the container at runtime.
     (0, artifact_store_1.useArtifactStore)();
     let getMeterStub;

package/lib/test/unit/recording-source-ended.spec.js

@@ -21,6 +21,7 @@ const path_1 = __importDefault(require("path"));
 const RecordingOrchestrator_1 = require("../../src/services/recording/RecordingOrchestrator");
 const concurrency_gate_1 = require("../../src/services/recording/concurrency-gate");
 const artifact_store_1 = require("../helpers/artifact-store");
+const loki_stores_1 = require("../helpers/loki-stores");
 // Issue #203. When the ffmpeg process for a recording exits on its own nothing
 // told the orchestrator, so the row sat at RECORDING — no ended_at, no duration,
 // no size — until a human clicked Stop. Observed live during the #200 cable-pull
@@ -69,6 +70,10 @@ function makeOrch(row, overrides = {}) {
     return { orch, store, gate, videoPipeline, eventMgr, unblockDeviceFn, probeDurationMsFn };
 }
 describe('RecordingOrchestrator: ffmpeg exiting on its own', () => {
+    // The in-memory stores, also when this file runs on its own: without
+    // NODE_ENV=test the factory handed out the Prisma stores, which are the
+    // developer's ~/.cache/xenon/xenon.db.
+    (0, loki_stores_1.useLokiStores)();
     // compositeOutputPath and per-device paths resolve through ArtifactStore.
     (0, artifact_store_1.useArtifactStore)();
     afterEach(() => sinon_1.default.restore());

package/lib/test/unit/recording-store.spec.js

@@ -13,12 +13,18 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const recording_store_1 = require("../../src/services/recording/recording-store");
 const prisma_1 = require("../../src/prisma");
+const scratch_database_1 = require("../helpers/scratch-database");
 describe('RecordingStore (Prisma round-trip)', () => {
+    // Its own migrated database: the round trip wrote these rows to the
+    // developer's ~/.cache/xenon/xenon.db, and failed where it lacked the tables.
+    const scratch = (0, scratch_database_1.useScratchDatabase)();
     const store = new recording_store_1.RecordingStore();
+    // Through the scratch client itself: the helper's own afterEach, which
+    // runs first, has already put `prisma` back on the server's database.
     afterEach(() => __awaiter(void 0, void 0, void 0, function* () {
-        yield prisma_1.prisma.annotation.deleteMany({ where: { recording_id: { contains: 'test-' } } });
-        yield prisma_1.prisma.bookmark.deleteMany({ where: { recording_id: { contains: 'test-' } } });
-        yield prisma_1.prisma.recording.deleteMany({ where: { group_id: { startsWith: 'test-' } } });
+        yield scratch.db.annotation.deleteMany({ where: { recording_id: { contains: 'test-' } } });
+        yield scratch.db.bookmark.deleteMany({ where: { recording_id: { contains: 'test-' } } });
+        yield scratch.db.recording.deleteMany({ where: { group_id: { startsWith: 'test-' } } });
     }));
     it('creates a recording row with status=RECORDING', () => __awaiter(void 0, void 0, void 0, function* () {
         const rec = yield store.create({