@workbench-kit/react 0.0.2-prototype.0.2.4 → 0.0.2-prototype.0.2.41

package/src/workbench/chat/ChatCommandProposalCard.tsx

@@ -1,13 +1,13 @@
 import { Badge } from '../../primitives/badge';
 import { Button } from '../../primitives/button';
 import { cx } from '../../utils/cx';
-import { getWorkbenchCommandExecutionPolicyLabel } from '../command-execution-policy';
-import type { WorkbenchCommandExecutionPolicy } from '../command-model';
+import { getWorkbenchCommandExecutionPolicyLabel } from '../commands/command-execution-policy';
+import type { WorkbenchCommandExecutionPolicy } from '../commands/command-model';
 import type { ChatCommandProposal, ChatCommandProposalStatus } from './types';
 
 export interface ChatCommandProposalCardProps {
-  onAllow?: ((proposal: ChatCommandProposal) => void) | undefined;
-  onDeny?: ((proposal: ChatCommandProposal) => void) | undefined;
+  onAllow?: (proposal: ChatCommandProposal) => void;
+  onDeny?: (proposal: ChatCommandProposal) => void;
   proposal: ChatCommandProposal;
 }
 

package/src/workbench/chat/ChatConversationBar.tsx

@@ -12,14 +12,14 @@ import { defaultWorkbenchChatConversationLabels } from './chatConversation';
 export interface ChatConversationBarProps {
   activeConversationId: string;
   conversations: readonly WorkbenchChatConversation[];
-  labels?: Partial<WorkbenchChatConversationLabels> | undefined;
-  moreMenuItems?: readonly ContextMenuItem[] | undefined;
+  labels?: Partial<WorkbenchChatConversationLabels>;
+  moreMenuItems?: readonly ContextMenuItem[];
   onActivate: (conversationId: string) => void;
   onCreate: () => void;
   onDelete: (conversationId: string) => void;
   onRename: (conversationId: string, title: string) => void;
   /** Optional slot for a second pill next to the active conversation control. */
-  secondaryPill?: ReactNode | undefined;
+  secondaryPill?: ReactNode;
 }
 
 export function ChatConversationBar({

package/src/workbench/chat/ChatHistoryMenu.tsx

@@ -15,7 +15,7 @@ import { buildChatHistoryRowMenuItems } from './chatHistoryRowMenuItems';
 export interface ChatHistoryMenuProps {
   activeConversationId: string;
   conversations: readonly WorkbenchChatConversation[];
-  labels?: Partial<WorkbenchChatConversationLabels> | undefined;
+  labels?: Partial<WorkbenchChatConversationLabels>;
   x: number;
   y: number;
   onActivate: (conversationId: string) => void;

package/src/workbench/chat/ChatMessageCollapsible.tsx

@@ -5,6 +5,8 @@ import { cx } from '../../utils/cx';
 export const CHAT_MESSAGE_COLLAPSE_MAX_LINES = 8;
 
 export interface ChatMessageCollapsibleProps {
+  /** In-bubble region after message body (file chips, etc.). */
+  attachments?: ReactNode;
   children: ReactNode;
   className?: string;
   content: string;
@@ -26,6 +28,7 @@ function measureChatMessageNeedsCollapse(body: HTMLElement, maxLines: number): b
 }
 
 export function ChatMessageCollapsible({
+  attachments,
   children,
   className,
   content,
@@ -99,6 +102,7 @@ export function ChatMessageCollapsible({
         >
           {children}
         </div>
+        {attachments ? <div className="message__attachments">{attachments}</div> : null}
         {needsCollapse && !isStreaming ? (
           <Button
             aria-expanded={expanded}

package/src/workbench/chat/ChatMessageItem.tsx

@@ -1,7 +1,11 @@
 import Markdown from 'react-markdown';
 import type { ReactNode } from 'react';
 import { cx } from '../../utils/cx';
-import { workbenchMarkdownRemarkPlugins } from '../markdownRemarkPlugins';
+import {
+  workbenchMarkdownRemarkPlugins,
+  workbenchMarkdownRehypePlugins,
+} from '../markdown/markdownRemarkPlugins';
+import { sanitizeMarkdownHref } from '../markdown/sanitizeMarkdownHref';
 import { ChatCommandProposalCard } from './ChatCommandProposalCard';
 import { ChatMessageCollapsible } from './ChatMessageCollapsible';
 import { ChatMessageTime, resolveChatMessageTimestamp } from './chatMessageMeta';
@@ -16,26 +20,38 @@ import type {
 export interface ChatMessageItemProps {
   /**
    * Rendered after the bubble (and before command proposals). Use for
-   * attachments or host chrome that should stay outside the collapsible surface.
+   * host chrome that should stay outside the collapsible surface.
+   * Prefer `attachments` for in-bubble file chips.
    */
-  afterMessage?: ReactNode | undefined;
+  afterMessage?: ReactNode;
+  /**
+   * In-bubble attachment region (file chips, etc.). Renders inside the bubble
+   * surface after the message body. Prefer this over `afterMessage` when chips
+   * must stay end-aligned with user bubbles.
+   */
+  attachments?: ReactNode;
   assistantLabel?: string;
   /** Overrides `message.contentMode` when set. */
-  contentMode?: ChatMessageContentMode | undefined;
+  contentMode?: ChatMessageContentMode;
   /**
    * Forwarded into `ChatMessageCollapsible` in-bubble footer (progress, actions).
    */
-  footer?: ReactNode | undefined;
+  footer?: ReactNode;
   isStreaming?: boolean;
+  /**
+   * Assistant-layout label icon. Defaults to sparkle; error/warning tones use
+   * status icons. Pass a custom node to override, or `false` to hide.
+   */
+  labelIcon?: ReactNode | false;
   layout?: ChatMessageLayout;
   message: ChatMessage;
-  onCommandProposalAllow?: ((messageId: string, proposal: ChatCommandProposal) => void) | undefined;
-  onCommandProposalDeny?: ((messageId: string, proposal: ChatCommandProposal) => void) | undefined;
+  onCommandProposalAllow?: (messageId: string, proposal: ChatCommandProposal) => void;
+  onCommandProposalDeny?: (messageId: string, proposal: ChatCommandProposal) => void;
   showSenderLabel?: boolean;
   /** When true, keeps the inline timestamp visible without hover. */
   showTimestamp?: boolean;
   /** Overrides `message.tone` when set. */
-  tone?: ChatMessageTone | undefined;
+  tone?: ChatMessageTone;
   userLabel?: string;
 }
 
@@ -151,6 +167,25 @@ function resolveChatMessageToneClass(
   return undefined;
 }
 
+function resolveAssistantLabelIcon(
+  labelIcon: ReactNode | false | undefined,
+  tone: ChatMessageTone | undefined,
+): ReactNode | null {
+  if (labelIcon === false) {
+    return null;
+  }
+  if (labelIcon !== undefined) {
+    return labelIcon;
+  }
+  if (tone === 'error') {
+    return <i className="codicon codicon-error message__label-icon" />;
+  }
+  if (tone === 'warning') {
+    return <i className="codicon codicon-warning message__label-icon" />;
+  }
+  return <i className="codicon codicon-sparkle message__label-icon" />;
+}
+
 function ChatMessageBody({
   content,
   contentMode,
@@ -165,7 +200,23 @@ function ChatMessageBody({
       <div className="md-content">
         <Markdown
           remarkPlugins={workbenchMarkdownRemarkPlugins}
+          rehypePlugins={workbenchMarkdownRehypePlugins}
           components={{
+            a: ({ children, href }) => {
+              const safeHref = sanitizeMarkdownHref(href);
+              if (!safeHref) {
+                return <span>{children}</span>;
+              }
+              return (
+                <a
+                  href={safeHref}
+                  rel="noreferrer"
+                  target={safeHref.startsWith('#') ? undefined : '_blank'}
+                >
+                  {children}
+                </a>
+              );
+            },
             code: ({ children, className }) => (
               <code className={cx('ui-workbench-scrollbar', className)}>{children}</code>
             ),
@@ -188,10 +239,12 @@ function ChatMessageBody({
 
 export function ChatMessageItem({
   afterMessage,
+  attachments,
   assistantLabel = 'Assistant',
   contentMode: contentModeProp,
   footer,
   isStreaming = false,
+  labelIcon,
   layout = 'assistant',
   message,
   onCommandProposalAllow,
@@ -204,7 +257,9 @@ export function ChatMessageItem({
   const timestamp = renderMessageTimestamp(message, showTimestamp);
   const bubbleAlign = message.source === 'user' ? 'end' : 'start';
   const contentMode = resolveChatMessageContentMode(message, layout, contentModeProp);
-  const toneClass = resolveChatMessageToneClass(toneProp ?? message.tone);
+  const resolvedTone = toneProp ?? message.tone;
+  const toneClass = resolveChatMessageToneClass(resolvedTone);
+  const assistantLabelIcon = resolveAssistantLabelIcon(labelIcon, resolvedTone);
   const body = (
     <ChatMessageBody
       content={message.content}
@@ -234,6 +289,7 @@ export function ChatMessageItem({
             ) : null}
             <MessageBubbleLine align={bubbleAlign} timestamp={timestamp}>
               <ChatMessageCollapsible
+                attachments={attachments}
                 content={message.content}
                 footer={footer}
                 isStreaming={isStreaming}
@@ -266,6 +322,7 @@ export function ChatMessageItem({
             {peerLabel ? <div className="message__peer-label">{peerLabel}</div> : null}
             <MessageBubbleLine align={bubbleAlign} timestamp={timestamp}>
               <ChatMessageCollapsible
+                attachments={attachments}
                 content={message.content}
                 footer={footer}
                 isStreaming={isStreaming}
@@ -291,11 +348,12 @@ export function ChatMessageItem({
       <div className="message__row">
         <div className="message__main">
           <div className="message__label message__label--assistant">
-            <i className="codicon codicon-sparkle message__label-icon" />
+            {assistantLabelIcon}
             {message.label ?? assistantLabel}
           </div>
           <MessageBubbleLine align={bubbleAlign} timestamp={timestamp}>
             <ChatMessageCollapsible
+              attachments={attachments}
               className="message__assistant-collapsible"
               content={message.content}
               footer={footer}

package/src/workbench/chat/ChatMessageList.tsx

@@ -23,7 +23,7 @@ export interface ChatMessageListProps {
    * Host slot rendered inside the message list area after messages, or as a
    * sibling before the empty state when there are no messages.
    */
-  messageListAddon?: ReactNode | undefined;
+  messageListAddon?: ReactNode;
   messages: ChatMessage[];
   onCommandProposalAllow?: ChatMessageItemProps['onCommandProposalAllow'];
   onCommandProposalDeny?: ChatMessageItemProps['onCommandProposalDeny'];

package/src/workbench/chat/ChatPanel.tsx

@@ -22,18 +22,23 @@ export interface ChatPanelProps
       | 'showTools'
       | 'value'
     > {
-  className?: string | undefined;
-  composerRef?: Ref<HTMLTextAreaElement> | undefined;
+  className?: string;
+  composerRef?: Ref<HTMLTextAreaElement>;
   /** Label shown on the file-drop overlay. Defaults to "Drop files to attach". */
-  filesDropLabel?: string | undefined;
-  headerAddon?: ReactNode | undefined;
+  filesDropLabel?: string;
+  headerAddon?: ReactNode;
   /** Called when files are dropped onto the panel (disabled while `disabled` or `isRunning`). */
-  onFilesDrop?: ((files: File[]) => void) | undefined;
+  onFilesDrop?: (files: File[]) => void;
   /**
    * Wrap or replace the default `<ChatMessageList />` so hosts can inject
    * hybrid timelines around the kit list.
    */
-  renderMessageList?: ((defaultList: ReactNode) => ReactNode) | undefined;
+  renderMessageList?: (defaultList: ReactNode) => ReactNode;
+  /**
+   * Wrap or replace the default `<ChatComposer />` while keeping panel chrome
+   * and file-drop overlay behavior.
+   */
+  renderComposer?: (defaultComposer: ReactNode) => ReactNode;
   title?: string;
 }
 
@@ -53,6 +58,7 @@ export function ChatPanel({
   filesDropLabel = 'Drop files to attach',
   headerAddon,
   onFilesDrop,
+  renderComposer,
   renderMessageList,
   title = 'Chat',
   value,
@@ -125,6 +131,25 @@ export function ChatPanel({
     ? renderMessageList(defaultMessageList)
     : defaultMessageList;
 
+  const defaultComposer = (
+    <ChatComposer
+      ref={composerRef}
+      commandLabel={commandLabel}
+      commandSuggestPopover={commandSuggestPopover}
+      disabled={disabled}
+      isRunning={isRunning}
+      placeholder={placeholder}
+      showTools={showTools}
+      value={value}
+      onCancel={onCancel}
+      onCommandClick={onCommandClick}
+      onKeyDown={onKeyDown}
+      onSubmit={onSubmit}
+      onValueChange={onValueChange}
+    />
+  );
+  const composer = renderComposer ? renderComposer(defaultComposer) : defaultComposer;
+
   return (
     <div
       className={cx('chat-panel-drop-target', isFileDragActive && 'chat-panel-drop-target--active')}
@@ -135,23 +160,7 @@ export function ChatPanel({
     >
       <SideBarViewFrame
         className={cx('chat-sidebar-view', className)}
-        footer={
-          <ChatComposer
-            ref={composerRef}
-            commandLabel={commandLabel}
-            commandSuggestPopover={commandSuggestPopover}
-            disabled={disabled}
-            isRunning={isRunning}
-            placeholder={placeholder}
-            showTools={showTools}
-            value={value}
-            onCancel={onCancel}
-            onCommandClick={onCommandClick}
-            onKeyDown={onKeyDown}
-            onSubmit={onSubmit}
-            onValueChange={onValueChange}
-          />
-        }
+        footer={composer}
         footerPlacement="overlay"
         headerAddon={headerAddon}
         title={title}

package/src/workbench/chat/ChatPhasedRunProgress.tsx

@@ -7,7 +7,7 @@ import {
   getWorkbenchStatusDescriptor,
   type WorkbenchStatus,
   type WorkbenchStatusVariant,
-} from '../status';
+} from '../shell/status';
 
 /** Product-neutral phase lifecycle for run-progress UIs. */
 export type ChatRunPhaseStatus =
@@ -29,6 +29,20 @@ export interface ChatPhasedRunProgressAction {
   readonly variant?: 'default' | 'primary' | 'danger';
 }
 
+/**
+ * Overridable chrome strings for locale-aware hosts. Unset keys keep English defaults.
+ */
+export interface ChatPhasedRunProgressLabels {
+  readonly expand?: string;
+  readonly collapse?: string;
+  readonly noPhases?: string;
+  readonly phasesComplete?: (completed: number, total: number) => string;
+  /** Summary badge label for the aggregate run status. */
+  readonly summaryStatus?: (status: ChatRunPhaseStatus) => string;
+  /** Per-phase status badge label (also used when `summaryStatus` is omitted). */
+  readonly getStatusLabel?: (status: ChatRunPhaseStatus) => string;
+}
+
 function toBadgeVariant(variant: WorkbenchStatusVariant): 'accent' | 'muted' | 'danger' {
   if (variant === 'danger' || variant === 'warning') {
     return 'danger';
@@ -50,6 +64,8 @@ export interface ChatPhasedRunProgressProps {
   /** Extra footer content (host-owned). */
   readonly footer?: ReactNode;
   readonly className?: string;
+  /** Locale-aware chrome labels; defaults preserve English copy. */
+  readonly labels?: ChatPhasedRunProgressLabels;
 }
 
 function mapPhaseStatusToWorkbenchStatus(status: ChatRunPhaseStatus): WorkbenchStatus {
@@ -73,26 +89,73 @@ function mapPhaseStatusToWorkbenchStatus(status: ChatRunPhaseStatus): WorkbenchS
   }
 }
 
-function summarizePhases(phases: readonly ChatRunPhase[]): {
+const DEFAULT_SUMMARY_STATUS_LABELS: Record<ChatRunPhaseStatus, string> = {
+  pending: 'Pending',
+  running: 'Running',
+  completed: 'Completed',
+  failed: 'Failed',
+  skipped: 'Idle',
+  cancelled: 'Cancelled',
+};
+
+function resolveStatusLabel(
+  status: ChatRunPhaseStatus,
+  labels: ChatPhasedRunProgressLabels | undefined,
+  prefer: 'summary' | 'phase' = 'summary',
+): string {
+  const primary =
+    prefer === 'summary'
+      ? (labels?.summaryStatus?.(status) ?? labels?.getStatusLabel?.(status))
+      : (labels?.getStatusLabel?.(status) ?? labels?.summaryStatus?.(status));
+  if (primary) {
+    return primary;
+  }
+  if (status === 'skipped') {
+    return getWorkbenchStatusDescriptor(mapPhaseStatusToWorkbenchStatus(status)).label;
+  }
+  return (
+    DEFAULT_SUMMARY_STATUS_LABELS[status] ??
+    getWorkbenchStatusDescriptor(mapPhaseStatusToWorkbenchStatus(status)).label
+  );
+}
+
+function summarizePhases(
+  phases: readonly ChatRunPhase[],
+  labels: ChatPhasedRunProgressLabels | undefined,
+): {
   label: string;
   status: ChatRunPhaseStatus;
 } {
   if (phases.some((phase) => phase.status === 'failed')) {
-    return { label: 'Failed', status: 'failed' };
+    return { label: resolveStatusLabel('failed', labels, 'summary'), status: 'failed' };
   }
   if (phases.some((phase) => phase.status === 'running')) {
-    return { label: 'Running', status: 'running' };
+    return { label: resolveStatusLabel('running', labels, 'summary'), status: 'running' };
   }
   if (phases.some((phase) => phase.status === 'cancelled')) {
-    return { label: 'Cancelled', status: 'cancelled' };
+    return { label: resolveStatusLabel('cancelled', labels, 'summary'), status: 'cancelled' };
   }
   if (
     phases.length > 0 &&
     phases.every((phase) => phase.status === 'completed' || phase.status === 'skipped')
   ) {
-    return { label: 'Completed', status: 'completed' };
+    return { label: resolveStatusLabel('completed', labels, 'summary'), status: 'completed' };
+  }
+  return { label: resolveStatusLabel('pending', labels, 'summary'), status: 'pending' };
+}
+
+function resolvePhaseBadgeLabel(
+  status: ChatRunPhaseStatus,
+  labels: ChatPhasedRunProgressLabels | undefined,
+): string {
+  if (labels?.getStatusLabel) {
+    return labels.getStatusLabel(status);
+  }
+  // Pending maps to workbench "waiting" / "Waiting"; keep summary vocabulary ("Pending").
+  if (status === 'pending') {
+    return resolveStatusLabel('pending', labels, 'summary');
   }
-  return { label: 'Pending', status: 'pending' };
+  return getWorkbenchStatusDescriptor(mapPhaseStatusToWorkbenchStatus(status)).label;
 }
 
 /**
@@ -108,14 +171,24 @@ export function ChatPhasedRunProgress({
   actions,
   footer,
   className,
+  labels,
 }: ChatPhasedRunProgressProps) {
   const panelId = useId();
   const [uncontrolledExpanded, setUncontrolledExpanded] = useState(defaultExpanded);
   const isExpanded = expanded ?? uncontrolledExpanded;
-  const summary = summarizePhases(phases);
+  const summary = summarizePhases(phases, labels);
   const summaryDescriptor = getWorkbenchStatusDescriptor(
     mapPhaseStatusToWorkbenchStatus(summary.status),
   );
+  const expandLabel = labels?.expand ?? 'Expand';
+  const collapseLabel = labels?.collapse ?? 'Collapse';
+  const noPhasesLabel = labels?.noPhases ?? 'No phases';
+  const completedCount = phases.filter(
+    (phase) => phase.status === 'completed' || phase.status === 'skipped',
+  ).length;
+  const phasesCompleteLabel =
+    labels?.phasesComplete?.(completedCount, phases.length) ??
+    `${completedCount}/${phases.length} phases complete`;
 
   const setExpanded = (next: boolean) => {
     if (expanded === undefined) {
@@ -143,7 +216,7 @@ export function ChatPhasedRunProgress({
           aria-controls={panelId}
           onClick={() => setExpanded(!isExpanded)}
         >
-          {isExpanded ? 'Collapse' : 'Expand'}
+          {isExpanded ? collapseLabel : expandLabel}
         </Button>
       </header>
 
@@ -162,7 +235,9 @@ export function ChatPhasedRunProgress({
               >
                 <div className="chat-phased-run-progress__phase-main">
                   <span className="chat-phased-run-progress__phase-label">{phase.label}</span>
-                  <Badge variant={toBadgeVariant(descriptor.variant)}>{descriptor.label}</Badge>
+                  <Badge variant={toBadgeVariant(descriptor.variant)}>
+                    {resolvePhaseBadgeLabel(phase.status, labels)}
+                  </Badge>
                 </div>
                 {phase.detail ? (
                   <p className="chat-phased-run-progress__phase-detail">{phase.detail}</p>
@@ -173,9 +248,7 @@ export function ChatPhasedRunProgress({
         </ol>
       ) : (
         <p className="chat-phased-run-progress__summary" id={panelId}>
-          {phases.length === 0
-            ? 'No phases'
-            : `${phases.filter((phase) => phase.status === 'completed' || phase.status === 'skipped').length}/${phases.length} phases complete`}
+          {phases.length === 0 ? noPhasesLabel : phasesCompleteLabel}
         </p>
       )}
 

package/src/workbench/chat/ChatRenameDialog.tsx

@@ -10,7 +10,7 @@ import { defaultWorkbenchChatConversationLabels } from './chatConversation';
 
 export interface ChatRenameDialogProps {
   conversation: WorkbenchChatConversation;
-  labels?: Partial<WorkbenchChatConversationLabels> | undefined;
+  labels?: Partial<WorkbenchChatConversationLabels>;
   onCancel: () => void;
   onRename: (title: string) => void;
 }

package/src/workbench/chat/chat-conversation.css

@@ -65,7 +65,7 @@
 .chat-conversation-bar__pill-wrap {
   position: relative;
   flex: 1 1 auto;
-  min-width: 7.5rem;
+  min-width: var(--workbench-chat-conversation-pill-min-width, 7.5rem);
   max-width: min(160px, 100%);
   overflow: visible;
   z-index: 1;
@@ -78,7 +78,7 @@
 .chat-conversation-bar__pill--session {
   flex: 0 1 auto;
   flex-shrink: 1;
-  min-width: 5.5rem;
+  min-width: var(--workbench-chat-conversation-session-pill-min-width, 5.5rem);
   max-width: min(108px, 100%);
   color: var(--color-text-subtle);
 }

package/src/workbench/chat/chat-ui.css

@@ -379,6 +379,14 @@
   margin-top: 2px;
 }
 
+.message__attachments {
+  display: flex;
+  flex-wrap: wrap;
+  gap: 6px;
+  margin-top: 6px;
+  max-width: 100%;
+}
+
 .message__after {
   display: flex;
   flex-wrap: wrap;

package/src/workbench/chat/chatConversation.ts

@@ -4,9 +4,9 @@ export interface WorkbenchChatConversation {
   id: string;
   title: string;
   /** Short secondary line shown in history menu rows. */
-  metaSummary?: string | undefined;
+  metaSummary?: string;
   /** Tooltip content for the active conversation pill. */
-  metaTooltip?: ReactNode | undefined;
+  metaTooltip?: ReactNode;
 }
 
 export interface WorkbenchChatConversationLabels {

package/src/workbench/chat/chatMessageMeta.tsx

@@ -118,8 +118,8 @@ export function toChatMessageTimeDateTime(value: ChatMessageTimestampInput): str
 export function getPeerChatSenderKey(
   message: ChatMessage,
   options: {
-    assistantLabel?: string | undefined;
-    userLabel?: string | undefined;
+    assistantLabel?: string;
+    userLabel?: string;
   } = {},
 ): string {
   if (message.source === 'user') {
@@ -133,8 +133,8 @@ export function shouldShowPeerChatSenderLabel(
   messages: readonly ChatMessage[],
   index: number,
   options: {
-    assistantLabel?: string | undefined;
-    userLabel?: string | undefined;
+    assistantLabel?: string;
+    userLabel?: string;
   } = {},
 ): boolean {
   const message = messages[index];

package/src/workbench/chat/index.ts

@@ -5,6 +5,7 @@ export type { ChatCommandProposalCardProps } from './ChatCommandProposalCard';
 export { ChatPhasedRunProgress } from './ChatPhasedRunProgress';
 export type {
   ChatPhasedRunProgressAction,
+  ChatPhasedRunProgressLabels,
   ChatPhasedRunProgressProps,
   ChatRunPhase,
   ChatRunPhaseStatus,

package/src/workbench/chat/types.ts

@@ -1,6 +1,6 @@
 import type { ReactNode } from 'react';
 
-import type { WorkbenchCommandExecutionPolicy } from '../command-model';
+import type { WorkbenchCommandExecutionPolicy } from '../commands/command-model';
 
 export type ChatMessageSource = 'assistant' | 'user';
 
@@ -15,11 +15,11 @@ export type ChatCommandProposalStatus =
   'pending' | 'running' | 'allowed' | 'denied' | 'blocked' | 'executed' | 'failed';
 
 export interface ChatCommandProposal {
-  args?: readonly unknown[] | undefined;
+  args?: readonly unknown[];
   commandId: string;
-  description?: string | undefined;
+  description?: string;
   id: string;
-  label?: string | undefined;
+  label?: string;
   policy: WorkbenchCommandExecutionPolicy;
   status: ChatCommandProposalStatus;
 }
@@ -27,13 +27,13 @@ export interface ChatCommandProposal {
 export type ChatMessageTimestamp = number | Date | string;
 
 export interface ChatMessage {
-  commandProposals?: readonly ChatCommandProposal[] | undefined;
+  commandProposals?: readonly ChatCommandProposal[];
   content: string;
   /**
    * How `content` is rendered. Defaults to markdown for assistant-layout
    * assistant messages; otherwise plain text.
    */
-  contentMode?: ChatMessageContentMode | undefined;
+  contentMode?: ChatMessageContentMode;
   createdAt?: string;
   id: string;
   label?: ReactNode;
@@ -41,5 +41,5 @@ export interface ChatMessage {
   /** Preferred timestamp for display; falls back to `createdAt` when omitted. */
   timestamp?: ChatMessageTimestamp;
   /** Optional visual tone for host-driven status / error messages. */
-  tone?: ChatMessageTone | undefined;
+  tone?: ChatMessageTone;
 }

package/src/workbench/chat/useCancelRuntimeOnUnmount.ts

@@ -5,10 +5,10 @@ export const DEFAULT_RUNTIME_UNMOUNT_CANCELLABLE_STATUSES = ['running'] as const
 
 export interface UseCancelRuntimeOnUnmountOptions<TStatus extends string = RuntimeStatus> {
   cancel: () => void;
-  cancellableStatuses?: readonly TStatus[] | undefined;
-  enabled?: boolean | undefined;
-  getStatus?: (() => TStatus) | undefined;
-  status?: TStatus | undefined;
+  cancellableStatuses?: readonly TStatus[];
+  enabled?: boolean;
+  getStatus?: () => TStatus;
+  status?: TStatus;
 }
 
 export function shouldCancelRuntimeOnUnmount(