@workbench-kit/react 0.0.2-prototype.0.2.4 → 0.0.2-prototype.0.2.41

package/src/workbench/{Timeline.tsx → shell/Timeline.tsx}

@@ -1,8 +1,18 @@
-import type { ComponentPropsWithRef, ReactNode } from 'react';
-import { EmptyState } from '../primitives/empty-state';
-import { cxCodicon } from '../utils/codicon';
-import { cx } from '../utils/cx';
-import { getWorkbenchStatusLabel, isWorkbenchStatusBusy, type WorkbenchStatus } from './status';
+import type {
+  ComponentPropsWithRef,
+  KeyboardEvent as ReactKeyboardEvent,
+  MouseEvent as ReactMouseEvent,
+  ReactNode,
+} from 'react';
+import { EmptyState } from '../../primitives/empty-state';
+import { cxCodicon } from '../../utils/codicon';
+import { cx } from '../../utils/cx';
+import {
+  getWorkbenchStatusLabel,
+  isWorkbenchStatusBusy,
+  isWorkbenchStatusDisabled,
+  type WorkbenchStatus,
+} from './status';
 
 export type WorkbenchTimelineEventKind =
   'message' | 'operation-call' | 'operation-result' | 'file-write' | 'progress' | 'error';
@@ -11,16 +21,16 @@ export type WorkbenchTimelineMessageSource = 'assistant' | 'system' | 'user' | (
 export type WorkbenchTimelineVariant = 'compact' | 'expanded';
 
 export interface WorkbenchTimelineEvent {
-  content?: ReactNode | undefined;
-  description?: ReactNode | undefined;
+  content?: ReactNode;
+  description?: ReactNode;
   id: string;
   kind: WorkbenchTimelineEventKind;
-  metadata?: Record<string, unknown> | undefined;
+  metadata?: Record<string, unknown>;
   payload?: unknown;
-  source?: WorkbenchTimelineMessageSource | undefined;
-  status?: WorkbenchStatus | undefined;
-  timestamp?: ReactNode | undefined;
-  title?: ReactNode | undefined;
+  source?: WorkbenchTimelineMessageSource;
+  status?: WorkbenchStatus;
+  timestamp?: ReactNode;
+  title?: ReactNode;
 }
 
 export interface WorkbenchTimelineRenderContext {
@@ -172,10 +182,53 @@ export interface WorkbenchTimelineItemProps extends Omit<
   'children'
 > {
   event: WorkbenchTimelineEvent;
-  index?: number | undefined;
-  renderMetadata?: WorkbenchTimelineRenderMetadata | undefined;
-  renderPayload?: WorkbenchTimelineRenderPayload | undefined;
-  variant?: WorkbenchTimelineVariant | undefined;
+  index?: number;
+  renderMetadata?: WorkbenchTimelineRenderMetadata;
+  renderPayload?: WorkbenchTimelineRenderPayload;
+  variant?: WorkbenchTimelineVariant;
+}
+
+type WorkbenchTimelineActivationEvent =
+  ReactKeyboardEvent<HTMLElement> | ReactMouseEvent<HTMLElement>;
+
+const timelineInteractiveDescendantSelector =
+  'a[href],button,input,select,textarea,[contenteditable],[role="button"],[role="link"]';
+
+function createTimelineActivationProps(
+  event: WorkbenchTimelineEvent,
+  onEventActivate: WorkbenchTimelineProps['onEventActivate'],
+): Pick<
+  WorkbenchTimelineItemProps,
+  'aria-description' | 'aria-disabled' | 'aria-keyshortcuts' | 'onClick' | 'onKeyDown' | 'tabIndex'
+> {
+  if (onEventActivate === undefined) return {};
+  if (isWorkbenchStatusDisabled(getWorkbenchTimelineEventStatus(event))) {
+    return { 'aria-disabled': true, tabIndex: -1 };
+  }
+
+  const activate = (activationEvent: WorkbenchTimelineActivationEvent) => {
+    const { currentTarget, target } = activationEvent;
+    const fromNestedControl =
+      target instanceof Element &&
+      target !== currentTarget &&
+      target.closest(timelineInteractiveDescendantSelector) !== null;
+    if (activationEvent.defaultPrevented || fromNestedControl) return;
+
+    if ('key' in activationEvent) {
+      if (activationEvent.key !== 'Enter' && activationEvent.key !== ' ') return;
+      activationEvent.preventDefault();
+    }
+
+    onEventActivate(event);
+  };
+
+  return {
+    'aria-description': 'Press Enter or Space to activate.',
+    'aria-keyshortcuts': 'Enter Space',
+    onClick: activate,
+    onKeyDown: activate,
+    tabIndex: 0,
+  };
 }
 
 export function WorkbenchTimelineItem({
@@ -245,17 +298,20 @@ export function WorkbenchTimelineItem({
 }
 
 export interface WorkbenchTimelineProps extends Omit<ComponentPropsWithRef<'div'>, 'children'> {
-  emptyLabel?: ReactNode | undefined;
+  emptyLabel?: ReactNode;
   events: readonly WorkbenchTimelineEvent[];
-  renderMetadata?: WorkbenchTimelineRenderMetadata | undefined;
-  renderPayload?: WorkbenchTimelineRenderPayload | undefined;
-  variant?: WorkbenchTimelineVariant | undefined;
+  /** Activates an enabled event from pointer or Enter/Space input. */
+  onEventActivate?: (event: WorkbenchTimelineEvent) => void;
+  renderMetadata?: WorkbenchTimelineRenderMetadata;
+  renderPayload?: WorkbenchTimelineRenderPayload;
+  variant?: WorkbenchTimelineVariant;
 }
 
 export function WorkbenchTimeline({
   className,
   emptyLabel = 'No timeline events',
   events,
+  onEventActivate,
   renderMetadata,
   renderPayload,
   variant = 'expanded',
@@ -290,6 +346,7 @@ export function WorkbenchTimeline({
           renderMetadata={renderMetadata}
           renderPayload={renderPayload}
           variant={variant}
+          {...createTimelineActivationProps(event, onEventActivate)}
         />
       ))}
     </div>

package/src/workbench/{WorkbenchCanvasShell.defaults.ts → shell/WorkbenchCanvasShell.defaults.ts}

@@ -1,4 +1,4 @@
-import type { WorkbenchDocument } from './schema';
+import type { WorkbenchDocument } from '../schema';
 
 export const DEFAULT_CANVAS_ACTIVITY_ID = 'design' as const;
 export const DEFAULT_CANVAS_THEME = 'dark' as const;

package/src/workbench/{WorkbenchCanvasShell.model.ts → shell/WorkbenchCanvasShell.model.ts}

@@ -1,10 +1,10 @@
-import type { WorkbenchDocumentNode, WorkbenchNodeLayout } from './schema';
+import type { WorkbenchDocumentNode, WorkbenchNodeLayout } from '../schema';
 
 export interface WorkbenchCanvasLayoutInput {
-  readonly height?: string | undefined;
-  readonly width?: string | undefined;
-  readonly x?: string | undefined;
-  readonly y?: string | undefined;
+  readonly height?: string;
+  readonly width?: string;
+  readonly x?: string;
+  readonly y?: string;
 }
 
 export function getWorkbenchCanvasNodeChildren(node: WorkbenchDocumentNode): readonly string[] {

package/src/workbench/{WorkbenchCanvasShell.tsx → shell/WorkbenchCanvasShell.tsx}

@@ -1,11 +1,11 @@
 import { type CSSProperties, type ReactElement, useEffect, useMemo, useState } from 'react';
 import { createCommandRegistryFromContributions } from '@workbench-kit/platform';
 import { integratedShellWorkspaceFiles } from '@workbench-kit/adapters';
-import { Button } from '../primitives/button';
-import { TextArea } from '../primitives/text-area';
-import { TextInput } from '../primitives/text-input';
-import { SideBarViewFrame } from '../layout/sidebar';
-import { createWorkbenchShellCommands } from './commands';
+import { Button } from '../../primitives/button';
+import { TextArea } from '../../primitives/text-area';
+import { TextInput } from '../../primitives/text-input';
+import { SideBarViewFrame } from '../../layout/sidebar';
+import { createWorkbenchShellCommands } from '../commands/commands';
 import { WorkbenchStandaloneShell } from './WorkbenchStandaloneShell';
 import type { WorkbenchActivityDescriptor, WorkbenchStandaloneBootstrap } from './standalone';
 import {
@@ -19,7 +19,7 @@ import {
   type WorkbenchDocumentPatchHistory,
   type WorkbenchDocumentPatchHistoryState,
   type WorkbenchDocumentPatchResult,
-} from './schema';
+} from '../schema';
 import {
   DEFAULT_CANVAS_ACTIVITY_ID,
   DEFAULT_CANVAS_THEME,

package/src/workbench/{WorkbenchDesktopTitleBar.tsx → shell/WorkbenchDesktopTitleBar.tsx}

@@ -1,7 +1,7 @@
-import './chrome/workbench-desktop-titlebar.css';
+import '../chrome/workbench-desktop-titlebar.css';
 import type { ReactNode } from 'react';
-import { cx } from '../utils/cx';
-import { useWorkbenchHostPlatform } from './WorkbenchPlatformContext';
+import { cx } from '../../utils/cx';
+import { useWorkbenchHostPlatform } from '../chrome/WorkbenchPlatformContext';
 import {
   shouldUseDarwinPlatformChrome,
   WorkbenchWindowChromeControls,
@@ -9,19 +9,19 @@ import {
 import {
   resolveWorkbenchWindowChromeDataAttributes,
   type WorkbenchWindowChromeMode,
-} from './workbenchPlatformChrome';
+} from '../chrome/workbenchPlatformChrome';
 
 export interface WorkbenchDesktopWindowControlsProps {
   /** Defaults to `platform` so standalone controls match `WorkbenchDesktopTitleBar`. */
-  chrome?: WorkbenchWindowChromeMode | undefined;
-  closeLabel?: string | undefined;
+  chrome?: WorkbenchWindowChromeMode;
+  closeLabel?: string;
   isMaximized: boolean;
-  maximizeLabel?: string | undefined;
-  minimizeLabel?: string | undefined;
+  maximizeLabel?: string;
+  minimizeLabel?: string;
   onClose: () => void;
   onMinimize: () => void;
   onToggleMaximized: () => void;
-  restoreLabel?: string | undefined;
+  restoreLabel?: string;
 }
 
 /**
@@ -59,20 +59,20 @@ export function WorkbenchDesktopWindowControls({
 
 export interface WorkbenchDesktopTitleBarProps {
   /** Optional center area, e.g. a command-menu trigger. Omit to leave it empty. */
-  centerSlot?: ReactNode | undefined;
+  centerSlot?: ReactNode;
   /**
    * `platform` (default): darwin traffic lights / win32 caption buttons via host platform context.
    * `generic`: maximize + close only (modal-like), no OS-specific placement.
    */
-  chrome?: WorkbenchWindowChromeMode | undefined;
-  className?: string | undefined;
-  leading?: ReactNode | undefined;
-  trailing?: ReactNode | undefined;
+  chrome?: WorkbenchWindowChromeMode;
+  className?: string;
+  leading?: ReactNode;
+  trailing?: ReactNode;
   /**
    * Host-supplied window actions (Electron IPC callbacks). Omit on platforms that keep a native frame.
    * Kit owns chrome markup; the host owns minimize / maximize / close side effects only.
    */
-  windowControls?: WorkbenchDesktopWindowControlsProps | undefined;
+  windowControls?: WorkbenchDesktopWindowControlsProps;
 }
 
 /**

package/src/workbench/{WorkbenchShell.tsx → shell/WorkbenchShell.tsx}

@@ -1,12 +1,22 @@
 import { type CSSProperties, type ReactNode, useState } from 'react';
-import './chrome/workbench-layout-regions.css';
-import { cx } from '../utils/cx';
+import '../chrome/workbench-layout-regions.css';
+import { cx } from '../../utils/cx';
 import { ActivityBar, type ActivityBarProps, type ActivityBarItem } from './ActivityBar';
 import { SplitView } from './SplitView';
 import { StatusBar, type StatusBarItemModel, type StatusBarSectionModel } from './StatusBar';
 import { DEFAULT_PRIMARY_SIDEBAR_SIZE_PX } from './shellState';
-import { suppressNativeBrowserContextMenu } from './workbenchContextMenu';
-import { WorkbenchOverlaysProvider } from './workbenchOverlaysContext';
+import { suppressNativeBrowserContextMenu } from '../commands/workbenchContextMenu';
+import { WorkbenchOverlaysProvider } from '../chrome/workbenchOverlaysContext';
+
+const DEFAULT_BOTTOM_PANEL_SIZE_PERCENT = 30;
+
+function clampBottomPanelSizePercent(value: number): number {
+  return Math.min(70, Math.max(10, value));
+}
+
+function clampBottomPanelPrimarySizePercent(value: number): number {
+  return Math.min(90, Math.max(30, value));
+}
 
 export type WorkbenchShellActivityBarPosition = 'left' | 'top';
 
@@ -15,7 +25,7 @@ export interface WorkbenchShellProps {
     items: ActivityBarItem[];
     visible?: boolean;
   };
-  activityBarPosition?: WorkbenchShellActivityBarPosition | undefined;
+  activityBarPosition?: WorkbenchShellActivityBarPosition;
   auxiliarySidebar?: {
     isVisible: boolean;
     node: ReactNode;
@@ -25,10 +35,18 @@ export interface WorkbenchShellProps {
   bottomPanel?: {
     isVisible: boolean;
     node: ReactNode;
+    /**
+     * Panel track size as a percent of the vertical editor+panel split.
+     * When set with `onSizePercentChange`, the split is controlled.
+     */
+    sizePercent?: number;
+    onSizePercentChange?: (sizePercent: number) => void;
     className?: string;
     style?: CSSProperties;
   };
   compactStatus?: boolean;
+  /** Accessible name for the status bar region (default “Status bar”). */
+  statusBarAriaLabel?: string;
   onStatusItemActivate?: (item: StatusBarItemModel) => void;
   primarySidebar?: {
     isVisible: boolean;
@@ -58,6 +76,7 @@ export function WorkbenchShell({
   auxiliarySidebar,
   bottomPanel,
   compactStatus = true,
+  statusBarAriaLabel,
   onStatusItemActivate,
   overlays,
   primarySidebar,
@@ -85,17 +104,36 @@ export function WorkbenchShell({
   const isBottomPanelCollapsed = bottomPanel !== undefined && !bottomPanel.isVisible;
   const isAuxiliarySidebarCollapsed = auxiliarySidebar !== undefined && !auxiliarySidebar.isVisible;
 
+  const bottomPanelSizePercent =
+    bottomPanel?.onSizePercentChange !== undefined
+      ? (bottomPanel.sizePercent ?? DEFAULT_BOTTOM_PANEL_SIZE_PERCENT)
+      : undefined;
+  const bottomPanelPrimarySizePercent =
+    bottomPanelSizePercent !== undefined
+      ? clampBottomPanelPrimarySizePercent(100 - bottomPanelSizePercent)
+      : undefined;
+
   const editorArea = bottomPanel ? (
     <SplitView
       className={cx(
         bottomPanel.className,
         isBottomPanelCollapsed && 'ui-workbench-split-view--secondary-collapsed',
       )}
-      defaultPrimarySizePercent={70}
+      defaultPrimarySizePercent={100 - DEFAULT_BOTTOM_PANEL_SIZE_PERCENT}
       maxPrimarySizePercent={90}
       minPrimarySizePercent={30}
+      onPrimarySizePercentChange={
+        bottomPanel.onSizePercentChange
+          ? (primarySizePercent) => {
+              bottomPanel.onSizePercentChange?.(
+                clampBottomPanelSizePercent(100 - primarySizePercent),
+              );
+            }
+          : undefined
+      }
       orientation="vertical"
       primary={secondaryArea}
+      primarySizePercent={bottomPanelPrimarySizePercent}
       secondary={bottomPanel.node}
     />
   ) : (
@@ -178,6 +216,7 @@ export function WorkbenchShell({
             {body}
           </div>
           <StatusBar
+            aria-label={statusBarAriaLabel}
             compact={compactStatus}
             sections={statusSections}
             onItemActivate={onStatusItemActivate}

package/src/workbench/{WorkbenchShellTitleBarLayoutControls.tsx → shell/WorkbenchShellTitleBarLayoutControls.tsx}

@@ -1,25 +1,22 @@
-import './chrome/workbench-shell-titlebar.css';
+import '../chrome/workbench-shell-titlebar.css';
 import type { JSX } from 'react';
 
-import { IconButton } from '../primitives/icon-button';
+import { IconButton } from '../../primitives/icon-button';
+import { cx } from '../../utils/cx';
 
 export interface WorkbenchShellTitleBarLayoutControlsProps {
-  readonly isAuxiliarySidebarVisible?: boolean | undefined;
-  readonly isPanelVisible?: boolean | undefined;
+  readonly isAuxiliarySidebarVisible?: boolean;
+  readonly isPanelVisible?: boolean;
   readonly isPrimarySidebarVisible: boolean;
-  readonly onToggleAuxiliarySidebar?: (() => void) | undefined;
-  readonly onTogglePanel?: (() => void) | undefined;
+  readonly onToggleAuxiliarySidebar?: () => void;
+  readonly onTogglePanel?: () => void;
   readonly onTogglePrimarySidebar: () => void;
-  readonly panelHideLabel?: string | undefined;
-  readonly panelShowLabel?: string | undefined;
-  readonly primarySidebarHideLabel?: string | undefined;
-  readonly primarySidebarShowLabel?: string | undefined;
-  readonly secondarySidebarHideLabel?: string | undefined;
-  readonly secondarySidebarShowLabel?: string | undefined;
-}
-
-function joinClasses(...classNames: Array<string | false | null | undefined>): string {
-  return classNames.filter(Boolean).join(' ');
+  readonly panelHideLabel?: string;
+  readonly panelShowLabel?: string;
+  readonly primarySidebarHideLabel?: string;
+  readonly primarySidebarShowLabel?: string;
+  readonly secondarySidebarHideLabel?: string;
+  readonly secondarySidebarShowLabel?: string;
 }
 
 export function WorkbenchShellTitleBarLayoutControls({
@@ -40,7 +37,7 @@ export function WorkbenchShellTitleBarLayoutControls({
     <div className="workbench-shell-titlebar__layout-controls">
       <IconButton
         aria-pressed={isPrimarySidebarVisible}
-        className={joinClasses(
+        className={cx(
           'workbench-shell-titlebar__layout-control',
           isPrimarySidebarVisible && 'workbench-shell-titlebar__layout-control--active',
         )}
@@ -52,7 +49,7 @@ export function WorkbenchShellTitleBarLayoutControls({
       {onTogglePanel ? (
         <IconButton
           aria-pressed={isPanelVisible}
-          className={joinClasses(
+          className={cx(
             'workbench-shell-titlebar__layout-control',
             isPanelVisible && 'workbench-shell-titlebar__layout-control--active',
           )}
@@ -65,7 +62,7 @@ export function WorkbenchShellTitleBarLayoutControls({
       {onToggleAuxiliarySidebar ? (
         <IconButton
           aria-pressed={isAuxiliarySidebarVisible}
-          className={joinClasses(
+          className={cx(
             'workbench-shell-titlebar__layout-control',
             isAuxiliarySidebarVisible && 'workbench-shell-titlebar__layout-control--active',
           )}

package/src/workbench/{WorkbenchStandaloneShell.tsx → shell/WorkbenchStandaloneShell.tsx}

@@ -1,16 +1,16 @@
 import { useMemo, useRef } from 'react';
-import { useResolvedWorkbenchTheme } from './theme';
+import { useResolvedWorkbenchTheme } from '../theme/theme';
 import type { CSSProperties, MouseEvent, ReactNode } from 'react';
 import { useWorkbenchStandaloneShellStateSync } from './useWorkbenchStandaloneShellStateSync';
 import {
   WorkbenchStandaloneShellReactContextProvider,
   type WorkbenchStandaloneShellStateChange,
 } from './workbenchStandaloneShellReactContext';
-import { cxCodicon } from '../utils/codicon';
+import { cxCodicon } from '../../utils/codicon';
 import type { StatusBarItemModel, StatusBarSectionModel } from './StatusBar';
 import type { WorkbenchShellProps } from './WorkbenchShell';
 import { WorkbenchShell } from './WorkbenchShell';
-import type { WorkbenchShellCommandContext } from './commands';
+import type { WorkbenchShellCommandContext } from '../commands/commands';
 import { DEFAULT_PRIMARY_SIDEBAR_SIZE_PX, useWorkbenchShellState } from './shellState';
 import type {
   WorkbenchActivityChangeEvent,
@@ -19,7 +19,7 @@ import type {
   WorkbenchStandaloneBootstrapEvent,
   WorkbenchTheme,
 } from './standalone';
-import { WorkspaceDraftsProvider } from './workspace/WorkspaceDraftsContext';
+import { WorkspaceDraftsProvider } from '../workspace/WorkspaceDraftsContext';
 
 const DEFAULT_THEME: WorkbenchTheme = 'dark';
 const DEFAULT_ACTIVITY_ID = 'explorer';
@@ -391,6 +391,15 @@ export function WorkbenchStandaloneShell<
       }),
     );
   };
+  const togglePrimarySidebar = () => {
+    const nextSidebarVisible = !isPrimarySidebarVisible;
+    setPrimarySidebarLifecycle(
+      activeActivityId,
+      nextSidebarVisible,
+      nextSidebarVisible ? 'sidebar-show' : 'sidebar-hide',
+    );
+    shell.togglePrimarySidebar();
+  };
   const createContext = ({
     activityId,
     shell,
@@ -403,15 +412,7 @@ export function WorkbenchStandaloneShell<
       isPrimarySidebarVisible,
       openSettings: shell.openSettings,
       showActivity,
-      togglePrimarySidebar: () => {
-        const nextSidebarVisible = !isPrimarySidebarVisible;
-        setPrimarySidebarLifecycle(
-          activeActivityId,
-          nextSidebarVisible,
-          nextSidebarVisible ? 'sidebar-show' : 'sidebar-hide',
-        );
-        shell.togglePrimarySidebar();
-      },
+      togglePrimarySidebar,
     },
     isPrimarySidebarVisible,
     isSettingsOpen,
@@ -430,15 +431,7 @@ export function WorkbenchStandaloneShell<
       );
       shell.setPrimarySidebarVisible(isVisible);
     },
-    togglePrimarySidebar: () => {
-      const nextSidebarVisible = !isPrimarySidebarVisible;
-      setPrimarySidebarLifecycle(
-        activeActivityId,
-        nextSidebarVisible,
-        nextSidebarVisible ? 'sidebar-show' : 'sidebar-hide',
-      );
-      shell.togglePrimarySidebar();
-    },
+    togglePrimarySidebar,
     openSettings: shell.openSettings,
     closeSettings: shell.closeSettings,
     setSettingsCategoryId: shell.setSettingsCategoryId,

package/src/workbench/{WorkbenchViewEditor.tsx → shell/WorkbenchViewEditor.tsx}

@@ -7,8 +7,8 @@ import {
   type WorkbenchEditorBodyProps,
   type WorkbenchEditorFrameProps,
   type WorkbenchPanelSurfaceProps,
-} from '../layout/WorkbenchLayoutBase';
-import { EmptyState, type EmptyStateProps } from '../primitives/empty-state';
+} from '../../layout/WorkbenchLayoutBase';
+import { EmptyState, type EmptyStateProps } from '../../primitives/empty-state';
 
 export type WorkbenchViewEditorDataAttributes = {
   readonly [key: `data-${string}`]: boolean | number | string | undefined;
@@ -26,15 +26,15 @@ export type WorkbenchViewEditorEmptyStateSurfaceProps = Omit<
 export interface WorkbenchViewEditorEmptyState {
   readonly children: ReactNode;
   readonly icon: EmptyStateProps['icon'];
-  readonly props?: WorkbenchViewEditorEmptyStateProps | undefined;
-  readonly surfaceProps?: WorkbenchViewEditorEmptyStateSurfaceProps | undefined;
+  readonly props?: WorkbenchViewEditorEmptyStateProps;
+  readonly surfaceProps?: WorkbenchViewEditorEmptyStateSurfaceProps;
 }
 
 export interface WorkbenchViewEditorProps extends Omit<WorkbenchEditorFrameProps, 'children'> {
-  readonly bodyProps?: Omit<WorkbenchEditorBodyProps, 'children'> | undefined;
+  readonly bodyProps?: Omit<WorkbenchEditorBodyProps, 'children'>;
   readonly children?: ReactNode;
-  readonly emptyState?: WorkbenchViewEditorEmptyState | undefined;
-  readonly tabs?: ReactNode | undefined;
+  readonly emptyState?: WorkbenchViewEditorEmptyState;
+  readonly tabs?: ReactNode;
 }
 
 export function WorkbenchViewEditor({

package/src/workbench/{WorkbenchViewSidebar.tsx → shell/WorkbenchViewSidebar.tsx}

@@ -6,15 +6,15 @@ import {
   SideBarViewFrame,
   type SideBarListProps,
   type SideBarViewFrameProps,
-} from '../layout/sidebar';
-import { cx } from '../utils/cx';
+} from '../../layout/sidebar';
+import { cx } from '../../utils/cx';
 
 export interface WorkbenchViewSidebarItem<TViewId extends string, TIcon = unknown> {
-  readonly disabled?: boolean | undefined;
+  readonly disabled?: boolean;
   readonly icon: TIcon;
   readonly id: TViewId;
   readonly label: string;
-  readonly title?: string | undefined;
+  readonly title?: string;
 }
 
 export interface WorkbenchViewSidebarProps<TViewId extends string, TIcon = unknown> extends Omit<
@@ -22,10 +22,10 @@ export interface WorkbenchViewSidebarProps<TViewId extends string, TIcon = unkno
   'children' | 'onSelect'
 > {
   readonly [key: `data-${string}`]: boolean | number | string | undefined;
-  readonly activeId?: TViewId | undefined;
-  readonly itemDataAttributeName?: string | undefined;
+  readonly activeId?: TViewId;
+  readonly itemDataAttributeName?: string;
   readonly items: ReadonlyArray<WorkbenchViewSidebarItem<TViewId, TIcon>>;
-  readonly listProps?: Omit<SideBarListProps, 'children'> | undefined;
+  readonly listProps?: Omit<SideBarListProps, 'children'>;
   readonly onSelect?:
     ((viewId: TViewId, item: WorkbenchViewSidebarItem<TViewId, TIcon>) => void) | undefined;
   readonly renderIcon: (icon: TIcon, item: WorkbenchViewSidebarItem<TViewId, TIcon>) => ReactNode;

package/src/workbench/{WorkbenchWindowChromeControls.tsx → shell/WorkbenchWindowChromeControls.tsx}

@@ -1,21 +1,24 @@
 import type { ReactNode } from 'react';
 
-import { cx } from '../utils/cx';
-import { useWorkbenchHostPlatform } from './WorkbenchPlatformContext';
-import type { WorkbenchHostPlatform, WorkbenchWindowChromeMode } from './workbenchPlatformChrome';
+import { cx } from '../../utils/cx';
+import { useWorkbenchHostPlatform } from '../chrome/WorkbenchPlatformContext';
+import type {
+  WorkbenchHostPlatform,
+  WorkbenchWindowChromeMode,
+} from '../chrome/workbenchPlatformChrome';
 
 export interface WorkbenchWindowChromeControlsProps {
-  chrome?: WorkbenchWindowChromeMode | undefined;
-  closeLabel?: string | undefined;
-  isMaximized?: boolean | undefined;
-  maximizeLabel?: string | undefined;
-  minimizeLabel?: string | undefined;
+  chrome?: WorkbenchWindowChromeMode;
+  closeLabel?: string;
+  isMaximized?: boolean;
+  maximizeLabel?: string;
+  minimizeLabel?: string;
   onClose: () => void;
-  onMinimize?: (() => void) | undefined;
-  onToggleMaximized?: (() => void) | undefined;
-  restoreLabel?: string | undefined;
-  showMaximize?: boolean | undefined;
-  showMinimize?: boolean | undefined;
+  onMinimize?: () => void;
+  onToggleMaximized?: () => void;
+  restoreLabel?: string;
+  showMaximize?: boolean;
+  showMinimize?: boolean;
   surface: 'desktop-titlebar' | 'modal';
 }
 
@@ -88,8 +91,8 @@ interface SharedControlProps {
   maximizeLabel: string;
   minimizeLabel: string;
   onClose: () => void;
-  onMinimize?: (() => void) | undefined;
-  onToggleMaximized?: (() => void) | undefined;
+  onMinimize?: () => void;
+  onToggleMaximized?: () => void;
   restoreLabel: string;
   showMaximize: boolean;
   showMinimize: boolean;