@woosh/meep-engine 3.14.2 → 3.14.3

package/src/shade/renderer/animation/skinning/GPUMeshSkinningContext.js

@@ -25,7 +25,7 @@ import {
 import {
     MESHLET_METADATA_STRUCT
 } from "../../geometry/meshlet/encoding/MESHLET_METADATA_STRUCT.js";
-import { record_blas_refit } from "../../geometry/bvh/record_blas_refit.js";
+import { GPUBLASRefitBatch } from "../../geometry/bvh/GPUBLASRefitBatch.js";
 
 /**
  * Initial bindings-buffer capacity (in binding records). 16 × 16 bytes
@@ -296,6 +296,15 @@ export class GPUMeshSkinningContext {
      */
     #scene_context;
 
+    /**
+     * The per-frame refit of every bound mesh's clone BLAS, as one batch. Its entries are the
+     * binding list, re-listed whenever that changes; when the trees themselves become resident,
+     * and where, is the BLAS manager's business, and the batch asks it.
+     *
+     * @type {GPUBLASRefitBatch}
+     */
+    #refit_batch;
+
     /**
      * @param {{
      *     geometries: GPUGeometryManager,
@@ -314,6 +323,8 @@ export class GPUMeshSkinningContext {
         this.#animation_manager = animation_manager;
         this.#scene_context = scene_context;
         this.#device = device;
+
+        this.#refit_batch = new GPUBLASRefitBatch(device);
     }
 
     /**
@@ -571,10 +582,15 @@ export class GPUMeshSkinningContext {
         }
 
         if (this.#bindings_dirty) {
-            // Neither of these reads anything outside the binding list, so a scene edit that left
+            // None of these reads anything outside the binding list, so a scene edit that left
             // the list alone cannot have moved them.
             this.#upload_dispatch_lookup();
             this.#upload_prev_position_offsets();
+            this.#refit_batch.set_entries(this.#bindings.map(binding => ({
+                // the identity the clone's BLAS is registered under, and the row skinning deforms
+                owner: binding.clone_metadata,
+                geometry_index: binding.clone_geometry_index,
+            })));
             this.#bindings_dirty = false;
         }
 
@@ -729,7 +745,7 @@ export class GPUMeshSkinningContext {
             }
         }
 
-        // ── 5. BLAS refit: the clone's tree catches up with its vertices ──
+        // ── 5. BLAS refit: every clone's tree catches up with its vertices ──
         //
         // The chain above fixes what the *rasterizer* culls by — meshlet boxes, a mesh sphere. A
         // ray does not consult any of those; it walks the clone's BLAS, whose boxes still describe
@@ -737,15 +753,23 @@ export class GPUMeshSkinningContext {
         // longer in: rays miss where the mesh now is and hit where it no longer is.
         //
         // Topology is untouched. Refitting a tree whose triangles moved but whose shape did not is
-        // two dispatches, against the full build's sort-and-emit — which is why a clone gets a copy
-        // of the source's nodes rather than a build of its own.
+        // a fraction of the full build's sort-and-emit — which is why a clone gets a copy of the
+        // source's nodes rather than a build of its own. And it is one batch for every clone at
+        // once, not a dispatch per clone: the command count is the same for one skinned mesh as
+        // for three hundred, and each tree's climb overlaps the next's instead of waiting on it.
         this.#record_blas_refits(cmd_ctx);
     }
 
     /**
      * Refit every skinned clone's BLAS against the vertices this frame's skinning just deformed.
      *
-     * Per binding rather than per dispatch-pair: a refit is scoped to a tree, and a clone has one.
+     * The batch's entries are the binding list, set whenever that changes; which of those trees
+     * are resident, and where, the batch asks the BLAS manager — and only when the manager says the
+     * answer may have moved.
+     *
+     * Recorded here and nowhere else, on purpose: the batch binds the manager's arena buffers as
+     * they are at this moment, and those are replaced when an arena grows in the geometry update,
+     * which runs before this frame's command context exists. See {@link GPUBLASRefitBatch}.
      *
      * @param {ShadeGPUCommandContext} cmd_ctx
      */
@@ -758,14 +782,7 @@ export class GPUMeshSkinningContext {
             return;
         }
 
-        for (const binding of this.#bindings) {
-            record_blas_refit(cmd_ctx, {
-                blas,
-                geometries,
-                owner: binding.clone_metadata,
-                geometry_index: binding.clone_geometry_index,
-            });
-        }
+        this.#refit_batch.record(cmd_ctx, { blas, geometries });
     }
 
     /**
@@ -1051,5 +1068,6 @@ export class GPUMeshSkinningContext {
             this.#prev_position_offsets_buffer.destroy();
             this.#prev_position_offsets_buffer = null;
         }
+        this.#refit_batch.destroy();
     }
 }

package/src/shade/renderer/geometry/GPUGeometryManager.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"GPUGeometryManager.d.ts","sourceRoot":"","sources":["../../../../../src/shade/renderer/geometry/GPUGeometryManager.js"],"names":[],"mappings":"AAWA;;;;GAIG;AACH;IA8HI;;;OAGG;IACH,+BAUC;IAtID;;;OAGG;IACH,iBAFU,YAAU,IAAI,CAED;IA4BvB;;;OAGG;IACH,mEAEC;IAED;;;;OAIG;IACH,8BAA0B;IAE1B;;;;OAIG;IACH,uBAAsB;IAOtB;;;OAGG;IACH,kCAEC;IAeD;;;OAGG;IACH,kCAEC;IAGD;;;OAGG;IACH,iCAEC;IAED;;;OAGG;IACH,+BAiBC;IAkBD;;;;OAIG;IACH,qBAHW,mBAAmB,GAClB,MAAM,CAMjB;IAED;;;;OAIG;IACH,gCAFY,OAAO,CAIlB;IAGD;;;;OAIG;IACH,gCAFa,OAAO,CAqCnB;IAED;;;;;;;;;;;;;;;;;;;;;;;;;OAyBG;IACH,6CANa,mBAAmB,CA8B/B;IAED;;;;;;;OAOG;IACH,yCAFa,mBAAmB,GAAC,SAAS,CAIzC;IAED;;;;OAIG;IACH,mCAFa,OAAO,CA6BnB;IAED,gBAWC;IAED;;;;;;OAMG;IACH,mDA0BC;IAsDD,cAmCC;IAED,0CASC;;CA+BJ;oCA1emC,0BAA0B;kCAC5B,gCAAgC;sCAH5B,gCAAgC"}
+{"version":3,"file":"GPUGeometryManager.d.ts","sourceRoot":"","sources":["../../../../../src/shade/renderer/geometry/GPUGeometryManager.js"],"names":[],"mappings":"AAaA;;;;GAIG;AACH;IAqJI;;;OAGG;IACH,+BAUC;IA7JD;;;OAGG;IACH,iBAFU,YAAU,IAAI,CAED;IA0CvB;;;OAGG;IACH,mEAEC;IAED;;;;OAIG;IACH,8BAA0B;IAE1B;;;;OAIG;IACH,uBAAsB;IAOtB;;;OAGG;IACH,kCAEC;IAwBD;;;OAGG;IACH,kCAEC;IAGD;;;OAGG;IACH,iCAEC;IAED;;;OAGG;IACH,+BAiBC;IAkBD;;;;OAIG;IACH,qBAHW,mBAAmB,GAClB,MAAM,CAMjB;IAED;;;;OAIG;IACH,gCAFY,OAAO,CAIlB;IAGD;;;;OAIG;IACH,gCAFa,OAAO,CAiEnB;IAED;;;;;;;;;;;;;;;;;;;;;;;;;OAyBG;IACH,6CANa,mBAAmB,CAiC/B;IAED;;;;;;;OAOG;IACH,yCAFa,mBAAmB,GAAC,SAAS,CAIzC;IAED;;;;OAIG;IACH,mCAFa,OAAO,CAsCnB;IAyBD,gBAWC;IAED;;;;;;OAMG;IACH,mDAiCC;IAmDD,cAmCC;IAED,0CAWC;;CA+BJ;oCAtkBmC,0BAA0B;kCAC5B,gCAAgC;sCAH5B,gCAAgC"}