@windyroad/architect 0.20.3 → 0.20.4-preview.1058

package/skills/capture-adr/test/capture-adr.bats

@@ -1,362 +0,0 @@
-#!/usr/bin/env bats
-# Behavioural fixtures for /wr-architect:capture-adr (P156).
-#
-# Per ADR-052 (Behavioural-tests-default for skill testing), these tests
-# exercise the load-bearing primitives the skill dispatches and assert
-# observable state — NOT the prose contents of SKILL.md.
-#
-# Behavioural surfaces under test:
-#   1. Next-ID computation — capture-adr reuses create-adr Step 3 P056-safe
-#      local_max + origin_max formula. Test runs the formula against a
-#      fixture decisions directory and asserts the computed next ID
-#      matches the expected zero-padded value (including the empty-dir
-#      first-ADR base case).
-#   2. Derive-fill MADR shape (RFC-045 derived-substance amendment) —
-#      captured ADR has Title + status proposed + human-oversight:
-#      unconfirmed + real derived content in every section, and matches
-#      NOTHING in the shared deferral-marker vocabulary
-#      (DEFERRAL_MARKER_RE, packages/retrospective/hooks/lib/
-#      deferral-markers.sh) — no placeholder/pointer/sentinel of any kind.
-#   3. Default reassessment-date — 3 months from today is computed
-#      correctly and lands in frontmatter.
-#   4. Frontmatter derived values — decision-makers carries a real name
-#      (git user.name), never a sentinel.
-#
-# Structural assertions are limited to existence/wiring (file presence +
-# frontmatter name + allowed-tools surface) per the precedent set by the
-# capture-problem bats fixtures (P155). Anything else asserts behaviour.
-#
-# @problem P156
-# @jtbd JTBD-001 (enforce governance without slowing down — lightweight
-#                  ADR-capture path)
-# @jtbd JTBD-005 (invoke governance assessments on demand — discoverable
-#                  via / autocomplete)
-# @jtbd JTBD-006 (progress backlog while AFK — mid-iter design-decision
-#                  capture in iter subprocesses)
-# @jtbd JTBD-101 (extend the suite — symmetric with capture-problem on
-#                  the architect plugin namespace)
-# @adr ADR-032 (governance skill invocation patterns — foreground-
-#                lightweight-capture variant for capture-adr)
-# @adr ADR-038 (progressive disclosure — SKILL.md + REFERENCE.md split)
-# @adr ADR-044 (decision-delegation contract — framework-mediated
-#                mechanical-stage carve-outs; no AskUserQuestion)
-# @adr ADR-049 (bin/ on PATH — capture-adr is self-contained, no shim
-#                required, same as create-adr)
-# @adr ADR-052 (behavioural-tests-default — these tests exercise
-#                primitives, not SKILL.md prose)
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  SKILL_DIR="${REPO_ROOT}/packages/architect/skills/capture-adr"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-  REF_FILE="${SKILL_DIR}/REFERENCE.md"
-
-  # Fresh per-test scratch directory.
-  TMPROOT=$(mktemp -d)
-}
-
-teardown() {
-  rm -rf "$TMPROOT"
-}
-
-# ---------------------------------------------------------------------------
-# Existence / wiring tests — minimum surface required for the skill to be
-# discoverable. Not structural prose-greps; these assert artefacts exist.
-# ---------------------------------------------------------------------------
-
-@test "capture-adr: SKILL.md and REFERENCE.md both exist (ADR-038 split)" {
-  [ -f "$SKILL_FILE" ]
-  [ -f "$REF_FILE" ]
-}
-
-@test "capture-adr: SKILL.md frontmatter declares wr-architect:capture-adr name" {
-  # Discoverable on / autocomplete depends on the canonical name.
-  # ADR-032 names this skill at line 81 + P156 amendment block.
-  run grep -E '^name: wr-architect:capture-adr$' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Next-ID computation — capture-adr reuses create-adr Step 3 formula.
-# P056-safe via `git ls-tree --name-only` to avoid blob-SHA false-match.
-# ---------------------------------------------------------------------------
-
-@test "capture-adr: next-ID formula is P056-safe (origin/local max + 1)" {
-  # Build a fixture decisions directory with mixed status suffixes.
-  # The formula must pick the max ID across all suffixes and zero-pad.
-  mkdir -p "$TMPROOT/docs/decisions"
-  : > "$TMPROOT/docs/decisions/001-foo.accepted.md"
-  : > "$TMPROOT/docs/decisions/032-bar.proposed.md"
-  : > "$TMPROOT/docs/decisions/057-baz.proposed.md"
-  : > "$TMPROOT/docs/decisions/123-qux.superseded.md"
-
-  # Mirror create-adr Step 3 / capture-adr Step 2 local-max formula exactly.
-  local_max=$(ls "$TMPROOT/docs/decisions"/*.md 2>/dev/null \
-              | sed 's/.*\///' \
-              | grep -oE '^[0-9]+' \
-              | sort -n | tail -1)
-  [ "$local_max" = "123" ]
-
-  # No origin available in the fixture; default to 0 then increment.
-  next=$(printf '%03d' $(( 10#$(echo -e "${local_max:-0}\n0" | sort -n | tail -1) + 1 )))
-  [ "$next" = "124" ]
-}
-
-@test "capture-adr: next-ID handles empty decisions dir (first ADR)" {
-  mkdir -p "$TMPROOT/docs/decisions"
-  local_max=$(ls "$TMPROOT/docs/decisions"/*.md 2>/dev/null \
-              | sed 's/.*\///' \
-              | grep -oE '^[0-9]+' \
-              | sort -n | tail -1)
-  next=$(printf '%03d' $(( 10#$(echo -e "${local_max:-0}\n0" | sort -n | tail -1) + 1 )))
-  [ "$next" = "001" ]
-}
-
-@test "capture-adr: next-ID prefers origin_max when origin > local (collision guard)" {
-  # Simulate the case where origin has a higher ADR number than local
-  # (parallel session pushed a new ADR before this session captures).
-  mkdir -p "$TMPROOT/docs/decisions"
-  : > "$TMPROOT/docs/decisions/050-local.proposed.md"
-  local_max=50
-  origin_max=175   # parallel session pushed ADR-175
-
-  next=$(printf '%03d' $(( 10#$(echo -e "${local_max:-0}\n${origin_max:-0}" | sort -n | tail -1) + 1 )))
-  [ "$next" = "176" ]
-}
-
-@test "capture-adr: next-ID handles 099 → 100 transition without octal-eval failure (P164)" {
-  # P164 regression: bash $(( ... )) parses leading-zero numbers as octal.
-  # `099` is invalid octal (digits >= 8). Without `10#` prefix, this fires:
-  #   bash: 099: value too great for base (error token is "099")
-  # The fix is the standard `10#` base-10 prefix on the inner $(echo ... | tail -1).
-  mkdir -p "$TMPROOT/docs/decisions"
-  : > "$TMPROOT/docs/decisions/098-foo.proposed.md"
-  : > "$TMPROOT/docs/decisions/099-bar.proposed.md"
-
-  local_max=$(ls "$TMPROOT/docs/decisions"/*.md 2>/dev/null \
-              | sed 's/.*\///' \
-              | grep -oE '^[0-9]+' \
-              | sort -n | tail -1)
-  [ "$local_max" = "099" ]
-
-  next=$(printf '%03d' $(( 10#$(echo -e "${local_max:-0}\n0" | sort -n | tail -1) + 1 )))
-  [ "$next" = "100" ]
-}
-
-# ---------------------------------------------------------------------------
-# Derive-fill MADR shape (RFC-045 / P375) — capture-adr writes a fully-
-# derived ADR at status: proposed. Load-bearing primitives:
-#   - Title at H1
-#   - status: proposed + human-oversight: unconfirmed in frontmatter
-#   - decision-makers derived (real name, no sentinel)
-#   - reassessment-date 3 months from today
-#   - >=2 REAL numbered options (chosen + actually-rejected alternative)
-#   - Every section carries real derived prose; the file matches NOTHING
-#     in the shared deferral-marker vocabulary (DEFERRAL_MARKER_RE).
-# ---------------------------------------------------------------------------
-
-@test "capture-adr: derived-substance ADR matches nothing in the deferral-marker vocabulary" {
-  # RFC-045: no placeholder, pointer, or sentinel strings of any kind.
-  # Asserted against the single source of truth for the deferred-work
-  # vocabulary (P375 census) so "no placeholder of any kind" is the
-  # behavioural contract, not just "not the one old literal string".
-  MARKERS_LIB="${REPO_ROOT}/packages/retrospective/hooks/lib/deferral-markers.sh"
-  [ -f "$MARKERS_LIB" ]
-  # shellcheck disable=SC1090
-  source "$MARKERS_LIB"
-  [ -n "$DEFERRAL_MARKER_RE" ]
-
-  mkdir -p "$TMPROOT/docs/decisions"
-  TITLE="example-mid-iter-decision"
-  ID="200"
-  TODAY=$(date -u +%Y-%m-%d)
-  REASSESS=$(date -u -v+3m +%Y-%m-%d 2>/dev/null || date -u -d "+3 months" +%Y-%m-%d)
-  CONTEXT_LINE="Iter-bound design choice that needs codification."
-  DECISION_LINE="Adopt Option A because it preserves invariants X and Y."
-
-  # Mirror the SKILL.md derive-fill template with real derived content.
-  cat > "$TMPROOT/docs/decisions/${ID}-${TITLE}.proposed.md" <<EOF
----
-status: "proposed"
-date: ${TODAY}
-human-oversight: unconfirmed
-decision-makers: [Test User]
-consulted: []
-informed: []
-reassessment-date: ${REASSESS}
----
-
-# ${TITLE}
-
-> Captured via /wr-architect:capture-adr (foreground-lightweight aside-invocation per ADR-032, derived-substance amendment 2026-07-06 / RFC-045). Section content was derived by the capturing agent from the in-session decision context; human-oversight: unconfirmed until ratified at the /wr-architect:review-decisions drain.
-
-## Context and Problem Statement
-
-${CONTEXT_LINE}
-
-## Decision Drivers
-
-- Invariant X must survive iter restarts.
-- Option B would couple the loop to session state.
-
-## Considered Options
-
-1. **Option A (chosen)** — ${DECISION_LINE}
-2. **Option B (session-state coupling)** — rejected: couples the loop to session state.
-
-## Decision Outcome
-
-Chosen option: **"Option A"**, because ${DECISION_LINE}
-
-## Consequences
-
-### Good
-
-- Invariants X and Y hold across iters.
-
-### Neutral
-
-- No neutral consequences identified at capture.
-
-### Bad
-
-- One extra lookup per iter.
-
-## Confirmation
-
-Run the iter loop twice; invariant X holds on the second run.
-
-## Pros and Cons of the Options
-
-### Option A
-
-- Good, because invariants survive restarts.
-- Bad, because of the extra lookup.
-
-### Option B
-
-- Good, because no extra lookup.
-- Bad, because session-state coupling breaks AFK iters.
-
-## Reassessment Criteria
-
-Reopen if the extra-lookup cost exceeds one turn per iter.
-EOF
-
-  ADR="$TMPROOT/docs/decisions/${ID}-${TITLE}.proposed.md"
-  [ -f "$ADR" ]
-
-  # Load-bearing fields present.
-  run grep -F 'status: "proposed"' "$ADR"
-  [ "$status" -eq 0 ]
-  run grep -F 'human-oversight: unconfirmed' "$ADR"
-  [ "$status" -eq 0 ]
-  # Decision-makers carries a real name — no sentinel.
-  run grep -F 'decision-makers: [Test User]' "$ADR"
-  [ "$status" -eq 0 ]
-  # Title from input lands at H1.
-  run grep -F "# ${TITLE}" "$ADR"
-  [ "$status" -eq 0 ]
-  # Context + Decision survive verbatim from input.
-  run grep -F "$CONTEXT_LINE" "$ADR"
-  [ "$status" -eq 0 ]
-  run grep -F "$DECISION_LINE" "$ADR"
-  [ "$status" -eq 0 ]
-
-  # THE contract: nothing in the file matches the deferral vocabulary.
-  run grep -Eic "$DEFERRAL_MARKER_RE" "$ADR"
-  [ "$output" = "0" ]
-  # And the legacy sentinel shape is gone too.
-  run grep -F 'unspecified — fill at canonical review' "$ADR"
-  [ "$status" -ne 0 ]
-}
-
-@test "capture-adr: derived ADR carries >=2 REAL numbered options (no placeholder sibling)" {
-  # RFC-045: MADR >=2-options is satisfied by substance — the chosen
-  # option plus an actually-weighed alternative — never by a numbered
-  # placeholder.
-  mkdir -p "$TMPROOT/docs/decisions"
-  ID="201"
-  TITLE="another-decision"
-
-  cat > "$TMPROOT/docs/decisions/${ID}-${TITLE}.proposed.md" <<'EOF'
-## Considered Options
-
-1. **Option A (chosen)** — One-line summary
-2. **Status quo (do nothing)** — rejected: the symptom recurs every session
-EOF
-
-  ADR="$TMPROOT/docs/decisions/${ID}-${TITLE}.proposed.md"
-  # Numbered option 1 with chosen marker.
-  run grep -F '1. **Option A (chosen)**' "$ADR"
-  [ "$status" -eq 0 ]
-  # Numbered option 2 is real content, not a deferral.
-  run grep -E '^2\. \*\*' "$ADR"
-  [ "$status" -eq 0 ]
-  run grep -F '(deferred' "$ADR"
-  [ "$status" -ne 0 ]
-}
-
-@test "capture-adr: default reassessment-date is 3 months from today (matches create-adr)" {
-  # The 3-month default matches create-adr Step 4 default and is
-  # framework-policy per ADR-044. Computed value lands in frontmatter.
-  TODAY=$(date -u +%Y-%m-%d)
-  # Compute 3 months from today using BSD date or GNU date.
-  REASSESS=$(date -u -v+3m +%Y-%m-%d 2>/dev/null || date -u -d "+3 months" +%Y-%m-%d)
-
-  # The reassess date is non-empty and parseable as YYYY-MM-DD.
-  [ -n "$REASSESS" ]
-  echo "$REASSESS" | grep -qE '^[0-9]{4}-[0-9]{2}-[0-9]{2}$'
-
-  # The reassess date is strictly later than today (3 months ahead).
-  [ "$REASSESS" \> "$TODAY" ]
-}
-
-# ---------------------------------------------------------------------------
-# Skill-allowed-tools surface contract — capture-adr MUST NOT carry
-# AskUserQuestion (per design Q4 + ADR-044 framework-mediated mechanical-
-# stage decisions). This is observable from the frontmatter declaration
-# the runtime consumes.
-# ---------------------------------------------------------------------------
-
-@test "capture-adr: allowed-tools omits AskUserQuestion (no interactive branches)" {
-  # The skill's contract is NO AskUserQuestion at all — Considered Options
-  # / Decision Drivers / Consequences / Confirmation / Reassessment are
-  # framework-mediated mechanical stages per ADR-044. AskUserQuestion in
-  # allowed-tools would let future drift sneak prompts back in.
-  run grep -E '^allowed-tools:' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -E '^allowed-tools:.*AskUserQuestion' "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "capture-adr: allowed-tools includes Bash (for next-ID + commit primitives)" {
-  # next-ID via git ls-tree | grep | sort + commit gate via Bash invocation.
-  run grep -E '^allowed-tools:.*Bash' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "capture-adr: allowed-tools includes Write (for new ADR file)" {
-  run grep -E '^allowed-tools:.*Write' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Deferred-ratification contract — distinguishing capture-adr from
-# create-adr. capture-adr must NOT invoke the architect-agent inline; it
-# writes status: proposed + human-oversight: unconfirmed and defers human
-# ratification to the self-firing oversight drain (RFC-045).
-# ---------------------------------------------------------------------------
-
-@test "capture-adr: SKILL.md routes ratification to the review-decisions drain (no inline review handoff)" {
-  # The contract distinction from create-adr: capture-adr does NOT invoke
-  # the wr-architect:agent review inline; the derived substance is
-  # ratified at the /wr-architect:review-decisions drain surfaced by the
-  # SessionStart oversight nudge. A future maintainer who copies
-  # create-adr's Step 5 confirm pass into capture-adr would break the
-  # zero-interaction promise.
-  run grep -F '/wr-architect:review-decisions' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -F 'human-oversight: unconfirmed' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/create-adr/test/create-adr-adr-044-contract.bats

@@ -1,185 +0,0 @@
-#!/usr/bin/env bats
-# ADR-044 alignment contract assertions for create-adr SKILL.md Step 2
-# (P132 Phase 2a-iii-B derive-first refactor, 2026-05-16).
-#
-# tdd-review: structural-permitted (justification: SKILL.md prose contract
-# assertions; behavioural skill-runtime harness pending P012 + P081 Phase 2;
-# expected to migrate to behavioural form once the harness exists. Added
-# during P132 Phase 2a-iii-B per the inline plan's bridge-marker rule —
-# isomorphic precedent at manage-problem-adr-044-step4-derive-first.bats.)
-#
-# This file is the dedicated structural-grep-permitted home for the ADR-044
-# alignment contract during the bridge window. After P081 Phase 2 retrofits
-# the project's structural-grep tests to behavioural form, this file's
-# assertions migrate too.
-#
-# @problem P132 (agents over-ask in interactive sessions — Phase 2a-iii-B
-#   create-adr argument-collection derive-first refactor as 4th adopter)
-# @problem P185 (capture-problem Step 1.5 worked-example precedent)
-# @problem P136 (ADR-044 alignment audit master)
-# @adr ADR-002 (Monorepo per-plugin packages)
-# @adr ADR-017 (Shared code duplicated into per-package lib/ kept in sync)
-# @adr ADR-044 (Decision-Delegation Contract)
-# @adr ADR-013 amended Rule 1 (structured user interaction)
-# @adr ADR-026 (cost-source grounding — stderr advisory shape)
-# @adr ADR-052 (behavioural-by-default with structural bridge window)
-# @jtbd JTBD-001 (enforce governance without slowing down — primary)
-# @jtbd JTBD-006 (work backlog AFK — queued for return, not guessed at)
-# @jtbd JTBD-101 (extend the suite with consistent patterns)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-  [ -f "$SKILL_FILE" ]
-}
-
-# ----------------------------------------------------------------------
-# Step 2 derive-first refactor (P132 Phase 2a-iii-B) — cat-4 silent-framework
-# on Title + frontmatter defaults + Context-and-Problem-Statement; cat-1
-# direction-setting on Decision Drivers / Considered Options / Decision
-# Outcome / Consequences / Confirmation / decision-makers.
-# ----------------------------------------------------------------------
-
-@test "SKILL.md Step 2 cross-references ADR-044 category-4 (silent-framework) for derivable fields (P132 derive-first)" {
-  # P132 Phase 2a-iii-B: Title (kebab from prose), status (always proposed),
-  # date (today), reassessment-date (today+3mo), context-and-problem-statement
-  # (verbatim from $ARGUMENTS prose) resolve via silent-framework per
-  # ADR-044 category 4.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"silent-framework"* ]] || [[ "$output" == *"category 4"* ]] || [[ "$output" == *"category-4"* ]]
-}
-
-@test "SKILL.md Step 2 cross-references ADR-044 category-1 (direction-setting) for user-judgment fields" {
-  # Decision Drivers / Considered Options / Decision Outcome / Consequences /
-  # Confirmation retain AskUserQuestion as the genuine cat-1 surfaces —
-  # ADR creation is fundamentally user-judgment-bound; only the user knows
-  # the alternative space, the chosen-option rationale, and the testable
-  # confirmation criteria.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"direction-setting"* ]] || [[ "$output" == *"category 1"* ]] || [[ "$output" == *"category-1"* ]]
-}
-
-@test "SKILL.md Step 2 derives Title from prose silently (P132 inverse-P078)" {
-  # The 2026-05-06 I001 declaration regression cited in P132 was the agent
-  # asking "Title" with N candidate options when kebab-casing the description
-  # would have produced the slug directly. create-adr Step 2 must ship the
-  # same derive-first pattern as the 3 itil declaration-skill surfaces.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Title"* ]] || [[ "$output" == *"title"* ]]
-  [[ "$output" == *"derive"* ]] || [[ "$output" == *"derived"* ]]
-  [[ "$output" == *"kebab"* ]] || [[ "$output" == *"prose"* ]]
-}
-
-@test "SKILL.md Step 2 derives status / date / reassessment-date silently (P132 derive-first)" {
-  # Frontmatter defaults (status=proposed, date=today, reassessment-date=
-  # today+3mo) are SKILL conventions — no user judgment required at capture.
-  # Step 4's existing template already mandates these defaults; Step 2 must
-  # name them as silent-framework cat-4 surfaces explicitly so the
-  # I2-isomorphic stderr advisory contract covers them.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"status"* ]]
-  [[ "$output" == *"date"* ]]
-  [[ "$output" == *"reassessment"* ]] || [[ "$output" == *"proposed"* ]]
-}
-
-@test "SKILL.md Step 2 retains Considered Options + Decision Outcome as AskUserQuestion (negative-of-negative guard)" {
-  # Regression-resistance: the refactor MUST preserve the genuine cat-1
-  # direction-setting surfaces on Considered Options + Decision Outcome.
-  # The framework cannot generate the alternative space — only the user
-  # knows the alternatives evaluated. Architect verdict 2026-05-16:
-  # confirmed cat-1 over cat-5.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-  [[ "$output" == *"Considered Options"* ]] || [[ "$output" == *"options"* ]] || [[ "$output" == *"alternative"* ]]
-  [[ "$output" == *"Decision Outcome"* ]] || [[ "$output" == *"chosen"* ]] || [[ "$output" == *"rationale"* ]]
-}
-
-@test "SKILL.md Step 2 retains decision-makers as AskUserQuestion (architect verdict — no silent derive from git user.name)" {
-  # Architect verdict 2026-05-16: decision-makers MUST stay cat-1
-  # AskUserQuestion. `git config user.name` would conflate "who committed
-  # the ADR" with "who made the decision" — a multi-party decision is one
-  # of the canonical mis-attribution risks ADR-013's identity model rejects.
-  # Once-per-ADR ask is low-friction in absolute terms.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"decision-makers"* ]] || [[ "$output" == *"decision makers"* ]]
-}
-
-@test "SKILL.md Step 2 cites P132 (inverse-P078 audit traceability)" {
-  # P132 + ADR-044 must appear in Step 2 or Related section so the audit
-  # trail for the Phase 2a-iii-B refactor is recoverable from the SKILL.md
-  # surface.
-  run grep -nE "P132" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 2 documents stderr advisory shape for derived fields (ADR-026 grounding)" {
-  # ADR-026 cost-source grounding: each silent derivation emits a stderr
-  # advisory citing the source. Pattern parity with capture-problem Step
-  # 1.5 + manage-incident Step 4 + manage-problem Step 4 (I2-isomorphic
-  # across the four declaration-skill surfaces per Phase 2a-iii-B).
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stderr"* ]] || [[ "$output" == *"advisory"* ]]
-}
-
-@test "SKILL.md Step 2 cross-references the 3 prior derive-first surfaces (cross-skill consistency lock-in)" {
-  # Phase 2a-iii-B is the 4th adopter. The Step 2 prose must explicitly
-  # cite the 3 prior surfaces (capture-problem + manage-incident +
-  # manage-problem) so the I2-isomorphic stderr advisory format is
-  # locked-in by reference across the 4-surface set.
-  run awk '/^### 2\. /,/^### 2b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"capture-problem"* ]]
-  [[ "$output" == *"manage-incident"* ]]
-  [[ "$output" == *"manage-problem"* ]]
-}
-
-@test "SKILL.md Step 2 references derive-first-dispatch.sh helper (sourced from architect package per ADR-017)" {
-  # Per ADR-017 self-contained-published-package property: create-adr lives
-  # in @windyroad/architect, so it MUST source the helper from its own
-  # package lib (packages/architect/lib/derive-first-dispatch.sh), NOT
-  # cross-package from packages/itil/lib/. The canonical source lives at
-  # packages/shared/derive-first-dispatch.sh; both itil and architect have
-  # synced per-package lib/ copies.
-  run grep -E "packages/architect/lib/derive-first-dispatch" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ----------------------------------------------------------------------
-# Negative-of-negative guards — Step 2b multi-decision split + Step 5
-# confirm-with-user remain unchanged.
-# ----------------------------------------------------------------------
-
-@test "SKILL.md Step 2b multi-decision AskUserQuestion is preserved (cat-1 direction-setting, not touched by Phase 2a-iii-B)" {
-  # Step 2b is a separate cat-1 direction-setting surface — only the
-  # user knows whether multiple decisions can be independently accepted.
-  # The Phase 2a-iii-B refactor MUST NOT touch Step 2b's AskUserQuestion gate.
-  run awk '/^### 2b\. /,/^### 3\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-  [[ "$output" == *"decision"* ]] || [[ "$output" == *"split"* ]]
-}
-
-@test "SKILL.md Step 5 confirm-with-user AskUserQuestion is preserved (post-write review surface)" {
-  # Step 5 is the genuine cat-2 deviation-approval post-write review
-  # surface (analogous to manage-incident Step 6 evidence-first gate).
-  # The Phase 2a-iii-B refactor MUST NOT touch Step 5's AskUserQuestion gate.
-  run awk '/^### 5\. /,/^### 6\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-}
-
-# ----------------------------------------------------------------------
-# P081 + P132 bridge marker
-# ----------------------------------------------------------------------
-
-@test "bats file carries the tdd-review: structural-permitted marker" {
-  run grep -nE "tdd-review:[[:space:]]+structural-permitted" "${BATS_TEST_FILENAME}"
-  [ "$status" -eq 0 ]
-}

package/skills/create-adr/test/create-adr-codex-eval-contract.bats

@@ -1,34 +0,0 @@
-#!/usr/bin/env bats
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  EVAL_DIR="$REPO_ROOT/packages/architect/skills/create-adr/eval"
-}
-
-@test "create-adr Codex promptfoo config sits beside Claude config" {
-  [ -f "$EVAL_DIR/promptfooconfig.yaml" ]
-  [ -f "$EVAL_DIR/promptfooconfig.codex.yaml" ]
-  run grep -n "run-codex-skill-eval.sh" "$EVAL_DIR/promptfooconfig.codex.yaml"
-  [ "$status" -eq 0 ]
-  run grep -n "grade-codex-rubric.sh" "$EVAL_DIR/promptfooconfig.codex.yaml"
-  [ "$status" -eq 0 ]
-}
-
-@test "create-adr Codex eval runner uses packed installer and codex exec" {
-  run grep -n 'npm pack' "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n 'windyroad-architect --runtime codex --scope user' "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n 'agents/wr-architect-agent.toml' "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n "codex exec" "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n -- "--ephemeral" "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n -- 'approval_policy="never"' "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n -- "--sandbox read-only" "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-  run grep -n -- '</dev/null' "$EVAL_DIR/run-codex-skill-eval.sh"
-  [ "$status" -eq 0 ]
-}

package/skills/create-adr/test/create-adr-decision-boundary.bats

@@ -1,49 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: create-adr SKILL.md must include a decision-boundary
-# analysis step for new ADR creation.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document conforms to the
-# decision-boundary splitting contract introduced by P017.
-#
-# Cross-reference:
-#   P017: docs/problems/017-create-adr-should-split-multi-decision-records.open.md
-#   ADR-013: docs/decisions/013-structured-user-interaction-for-governance-decisions.proposed.md
-#   Sibling: packages/itil/skills/manage-problem/test/manage-problem-concern-boundary.bats (P016)
-#   @jtbd JTBD-001 (enforce governance without slowing down)
-#   @jtbd JTBD-101 (extend the suite with clear patterns)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md includes a decision-boundary analysis step for new ADR creation" {
-  # P017: Before writing an ADR file, the skill must check whether the input
-  # contains multiple distinct decisions, and offer to split if it does.
-  # Conflated ADRs damage auditability and block independent status transitions.
-  run grep -in "decision.boundary\|decision-boundary\|decision boundary\|boundary.*decision\|split.*decision\|multi.decision\|single.*decision\|distinct.*decision\|decision.*distinct" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md decision-boundary step uses AskUserQuestion for split decision (ADR-013)" {
-  # ADR-013 Rule 1: all branch points must use AskUserQuestion, not prose options.
-  # The "split into separate ADRs" option must be presented via AskUserQuestion.
-  # Match: AskUserQuestion appearing in context of "split" ADR instruction.
-  run grep -in "Split into separate\|split into.*ADR\|ADR.*split\|split.*ADR" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md decision-boundary step specifies non-interactive auto-split fallback" {
-  # ADR-013 Rule 6: non-interactive fail-safe — when AskUserQuestion is unavailable,
-  # the skill must auto-split (not block/hang) for creation workflows.
-  run grep -in "auto.split\|automatically split" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md decision-boundary step is scoped to new ADR creation (not supersession)" {
-  # P017 fix must only fire during new ADR creation, not during supersession handling.
-  # Checks for explicit scope language excluding supersession from the boundary check.
-  run grep -in "not.*supersession\|supersession.*not\|new ADR creation only\|creation only\|does not apply.*supersession\|Scoped to" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/create-adr/test/create-adr-id-collision-guard.bats

@@ -1,35 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: create-adr SKILL.md step 3 (Determine sequence number)
-# must include the next-ID collision guard against origin per ADR-019
-# confirmation criterion 2.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document instructs the
-# ADR creator to compare next-number against origin/<base> before
-# assigning, so parallel sessions don't produce colliding ADR numbers.
-#
-# Cross-reference:
-#   P043 (next-ID collision guard in ticket-creator skills)
-#   ADR-019 (AFK orchestrator preflight, including next-ID guard)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md cites ADR-019 (next-ID collision guard)" {
-  run grep -n "ADR-019" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md step 3 references git ls-tree origin for next-number lookup" {
-  # ADR-019 mechanism: the ADR creator MUST re-check next-number against
-  # `git ls-tree origin/<base>` before assigning.
-  run grep -n "git ls-tree origin" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md mentions taking the max of local and origin numbers" {
-  run grep -niE "max of (the )?(two|local and origin)|max\(.*origin" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}