@windyroad/architect 0.20.3 → 0.20.4-preview.1058

package/hooks/test/architect-readme-pairing-check.bats

@@ -1,126 +0,0 @@
-#!/usr/bin/env bats
-
-# Behavioural tests for architect-readme-pairing-check.sh (RFC-014 Story B,
-# ADR-078 Phase 1 / Option 9). Exercises the hook against a real staged git
-# index; asserts on its PreToolUse allow/deny decision (exit code + deny JSON).
-# Behavioural — no grep on hook source (feedback_behavioural_tests).
-
-setup() {
-  HOOK="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)/architect-readme-pairing-check.sh"
-  REPO="$(mktemp -d)"
-  cd "$REPO"
-  git init -q
-  git config user.email t@e.x
-  git config user.name t
-  mkdir -p docs/decisions
-  echo "# compendium" > docs/decisions/README.md
-  echo "# adr 049" > docs/decisions/049-x.proposed.md
-  git add -A && git commit -q -m init
-}
-
-teardown() {
-  cd /
-  rm -rf "$REPO"
-}
-
-# Run the hook with a synthetic `git commit` Bash PreToolUse payload.
-run_commit_hook() {
-  local cmd="${1:-git commit -m wip}"
-  echo "{\"tool_name\":\"Bash\",\"tool_input\":{\"command\":\"$cmd\"}}" | bash "$HOOK"
-}
-
-@test "denies commit when an ADR body is staged without README (criterion 1)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"deny"* ]]
-  [[ "$output" == *"049-x.proposed.md"* ]]
-}
-
-@test "permits commit when ADR body AND README are both staged (criterion 2)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  echo "# compendium refreshed" > docs/decisions/README.md
-  git add docs/decisions/049-x.proposed.md docs/decisions/README.md
-  run run_commit_hook
-  [ "$status" -eq 0 ]
-}
-
-@test "permits commit when only README is staged (compendium-only edit) (criterion 3)" {
-  echo "# compendium refreshed" > docs/decisions/README.md
-  git add docs/decisions/README.md
-  run run_commit_hook
-  [ "$status" -eq 0 ]
-}
-
-@test "permits commit when no ADR-touching change is staged (criterion 4)" {
-  echo "x" > unrelated.txt
-  git add unrelated.txt
-  run run_commit_hook
-  [ "$status" -eq 0 ]
-}
-
-@test "deny message names the unpaired ADR file + recovery directive (criterion 5)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"049-x.proposed.md"* ]]
-  [[ "$output" == *"wr-architect-generate-decisions-compendium"* ]]
-}
-
-@test "allows non-commit Bash commands silently" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook "git status"
-  [ "$status" -eq 0 ]
-}
-
-@test "RISK_BYPASS token permits an intentional split" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook "git commit -m 'wip RISK_BYPASS: architect-compendium-deferred'"
-  [ "$status" -eq 0 ]
-}
-
-# --- P366 leading-token detection regression guards ---
-# These exercise the shared command_invokes_git_commit helper that the hook
-# now sources (replacing inline awk). Permit-path-only coverage is what let
-# the original BSD-awk `\b` bug hide; these are the deny-path / mention-path
-# guards the ticket asks for.
-
-@test "denies 'cd <repo> && git commit' with an unpaired ADR (P366 cd-prefix)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook "cd $REPO && git commit -m wip"
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"deny"* ]]
-}
-
-@test "denies 'VAR=1 git commit' with an unpaired ADR (P366 env-prefix)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook "GIT_AUTHOR_NAME=x git commit -m wip"
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"deny"* ]]
-}
-
-@test "permits a command that merely MENTIONS 'git commit' as a substring (P366 mention-path)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook "grep -r 'git commit' docs/"
-  [ "$status" -eq 0 ]
-}
-
-@test "permits 'git commit-tree' plumbing (P366 token-boundary)" {
-  echo "# adr 049 edited" > docs/decisions/049-x.proposed.md
-  git add docs/decisions/049-x.proposed.md
-  run run_commit_hook "git commit-tree HEAD"
-  [ "$status" -eq 0 ]
-}
-
-@test "registered in hooks.json as PreToolUse Bash (criterion 6)" {
-  HOOKS_JSON="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)/hooks.json"
-  run jq -e '.hooks.PreToolUse[] | select(.matcher=="Bash") | .hooks[] | select(.command | test("architect-readme-pairing-check"))' "$HOOKS_JSON"
-  [ "$status" -eq 0 ]
-}

package/hooks/test/architect-slide-marker.bats

@@ -1,92 +0,0 @@
-#!/usr/bin/env bats
-
-# Hook-level integration tests for architect-slide-marker.sh (P111).
-# Verifies that the PostToolUse:Agent|Bash hook correctly wires session_id
-# extraction + slide_marker_on_subprocess_return for the architect markers.
-
-setup() {
-  HOOKS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$HOOKS_DIR/architect-slide-marker.sh"
-  TEST_SESSION="bats-arch-slide-$$-${BATS_TEST_NUMBER}"
-  REVIEW_MARKER="/tmp/architect-reviewed-${TEST_SESSION}"
-  PLAN_MARKER="/tmp/architect-plan-reviewed-${TEST_SESSION}"
-  rm -f "$REVIEW_MARKER" "$PLAN_MARKER"
-}
-
-teardown() {
-  rm -f "$REVIEW_MARKER" "$PLAN_MARKER"
-}
-
-_backdate() {
-  local file="$1" seconds="$2"
-  local stamp
-  stamp=$(date -v-${seconds}S +%Y%m%d%H%M.%S 2>/dev/null \
-       || date -d "${seconds} seconds ago" +%Y%m%d%H%M.%S 2>/dev/null)
-  touch -t "$stamp" "$file"
-}
-
-@test "hook: slides architect-reviewed marker on subprocess return" {
-  touch "$REVIEW_MARKER"
-  _backdate "$REVIEW_MARKER" 60
-  BEFORE=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  echo '{"session_id":"'"$TEST_SESSION"'","tool_name":"Agent","tool_response":{"content":[]}}' | "$HOOK"
-  AFTER=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}
-
-@test "hook: slides architect-plan-reviewed marker too" {
-  touch "$PLAN_MARKER"
-  _backdate "$PLAN_MARKER" 60
-  BEFORE=$(stat -c%Y "$PLAN_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$PLAN_MARKER")
-  echo '{"session_id":"'"$TEST_SESSION"'","tool_name":"Agent","tool_response":{"content":[]}}' | "$HOOK"
-  AFTER=$(stat -c%Y "$PLAN_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$PLAN_MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}
-
-@test "hook: skips slide when tool_response.is_error=true" {
-  touch "$REVIEW_MARKER"
-  _backdate "$REVIEW_MARKER" 60
-  BEFORE=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  echo '{"session_id":"'"$TEST_SESSION"'","tool_name":"Bash","tool_response":{"is_error":true,"content":[]}}' | "$HOOK"
-  AFTER=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  [ "$BEFORE" = "$AFTER" ]
-}
-
-@test "hook: no-op when no marker exists (never creates)" {
-  [ ! -f "$REVIEW_MARKER" ]
-  echo '{"session_id":"'"$TEST_SESSION"'","tool_name":"Agent","tool_response":{"content":[]}}' | "$HOOK"
-  [ ! -f "$REVIEW_MARKER" ]
-}
-
-@test "hook: exits 0 when session_id is missing" {
-  run bash -c 'echo "{}" | '"$HOOK"
-  [ "$status" -eq 0 ]
-}
-
-@test "hook: P111 reproduction — long subprocess does not cause parent marker expiry on return" {
-  touch "$REVIEW_MARKER"
-  # Marker is 50 minutes old, well within default 60-min TTL but close.
-  # Without the slide on subprocess return, a 15-min subprocess would push
-  # the next PreToolUse check past TTL. With the slide, the next check sees
-  # a fresh marker.
-  _backdate "$REVIEW_MARKER" 3000
-  echo '{"session_id":"'"$TEST_SESSION"'","tool_name":"Bash","tool_input":{"command":"claude -p ..."},"tool_response":{"content":[{"type":"text","text":"OK"}]}}' | "$HOOK"
-  NOW=$(date +%s)
-  AFTER=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  AGE=$((NOW - AFTER))
-  [ "$AGE" -lt 5 ]
-}
-
-@test "hook: P213 — slides on Skill tool_name (Agent|Bash|Skill matcher expansion)" {
-  # Confirms hooks.json matcher expansion (Agent|Bash → Agent|Bash|Skill)
-  # composes correctly with the existing hook script. The hook script does
-  # not filter on tool_name; the matcher in hooks.json gates which tool
-  # completions fire the script. This test asserts the script handles the
-  # Skill-shaped tool_response identically to Agent|Bash.
-  touch "$REVIEW_MARKER"
-  _backdate "$REVIEW_MARKER" 60
-  BEFORE=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  echo '{"session_id":"'"$TEST_SESSION"'","tool_name":"Skill","tool_input":{"skill":"wr-risk-scorer:assess-release"},"tool_response":{"content":[{"type":"text","text":"OK"}]}}' | "$HOOK"
-  AFTER=$(stat -c%Y "$REVIEW_MARKER" 2>/dev/null || /usr/bin/stat -f%m "$REVIEW_MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}

package/hooks/test/codex-agent-completion.bats

@@ -1,64 +0,0 @@
-#!/usr/bin/env bats
-
-setup() {
-  HOOK_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  TMP="$(mktemp -d)"
-  export TMPDIR="$TMP/runtime"
-  export CLAUDE_PROJECT_DIR="$TMP/project"
-  mkdir -p "$TMPDIR" "$CLAUDE_PROJECT_DIR/docs/decisions"
-  SESSION="architect-codex-$$"
-  TARGET="agent-target"
-  MARKER="/tmp/architect-reviewed-$SESSION"
-  HASH="$MARKER.hash"
-  PLAN="/tmp/architect-plan-reviewed-$SESSION"
-  rm -f "$MARKER" "$HASH" "$PLAN"
-}
-
-teardown() {
-  rm -f "$MARKER" "$HASH" "$PLAN"
-  rm -rf "$TMP"
-}
-
-dispatch() {
-  printf '%s' "$1" | node "$HOOK_DIR/codex-agent-completion.mjs"
-}
-
-spawn() {
-  printf '{"session_id":"%s","cwd":"%s","tool_name":"multi_agent_v1__spawn_agent","tool_input":{"agent_type":"%s"},"tool_response":{"agent_id":"%s"}}' "$SESSION" "$CLAUDE_PROJECT_DIR" "$1" "$TARGET"
-}
-
-close() {
-  printf '{"session_id":"%s","cwd":"%s","tool_name":"multi_agent_v1__close_agent","tool_input":{"target":"%s"},"tool_response":{"previous_status":{"completed":"%s"}}}' "$SESSION" "$CLAUDE_PROJECT_DIR" "$TARGET" "$1"
-}
-
-@test "matched Codex architect PASS creates review markers" {
-  dispatch "$(spawn wr-architect:agent)"
-  dispatch "$(close '**Architecture Review: PASS**')"
-  [ -f "$MARKER" ]
-  [ -f "$HASH" ]
-  [ -f "$PLAN" ]
-}
-
-@test "issues and malformed output fail closed" {
-  dispatch "$(spawn wr-architect:agent)"
-  dispatch "$(close '**Architecture Review: ISSUES FOUND**')"
-  [ ! -e "$MARKER" ]
-  dispatch "$(spawn wr-architect:agent)"
-  dispatch "$(close 'review complete')"
-  [ ! -e "$MARKER" ]
-}
-
-@test "unmatched close and non-architect target do not unlock" {
-  dispatch "$(close '**Architecture Review: PASS**')"
-  [ ! -e "$MARKER" ]
-  dispatch "$(spawn default)"
-  dispatch "$(close '**Architecture Review: PASS**')"
-  [ ! -e "$MARKER" ]
-}
-
-@test "reused target clears stale architect identity" {
-  dispatch "$(spawn wr-architect:agent)"
-  dispatch "$(spawn default)"
-  dispatch "$(close '**Architecture Review: PASS**')"
-  [ ! -e "$MARKER" ]
-}

package/hooks/test/slide-marker-on-subprocess-return.bats

@@ -1,118 +0,0 @@
-#!/usr/bin/env bats
-
-# Tests for slide_marker_on_subprocess_return helper (P111).
-#
-# Behavioural contract:
-# - Slides an existing marker forward (touch) on PostToolUse:Agent|Bash
-#   completion, treating subprocess wall-clock as continuous parent-session
-#   work for TTL purposes.
-# - Never CREATES a marker (creating requires a real gate review).
-# - Skips slide on subprocess error (tool_response.is_error=true) so a failed
-#   subprocess does NOT extend the parent's trust window (ADR-009 amendment).
-# - No-op when no marker exists or session_id is empty (fail-safe).
-
-setup() {
-  HOOKS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  source "$HOOKS_DIR/lib/gate-helpers.sh"
-
-  TEST_SESSION="bats-slide-$$-${BATS_TEST_NUMBER}"
-  MARKER="/tmp/architect-reviewed-${TEST_SESSION}"
-  rm -f "$MARKER"
-}
-
-teardown() {
-  rm -f "$MARKER"
-}
-
-# Helper: backdate file mtime by N seconds (portable between macOS and Linux)
-_backdate() {
-  local file="$1" seconds="$2"
-  local stamp
-  stamp=$(date -v-${seconds}S +%Y%m%d%H%M.%S 2>/dev/null \
-       || date -d "${seconds} seconds ago" +%Y%m%d%H%M.%S 2>/dev/null)
-  touch -t "$stamp" "$file"
-}
-
-@test "slide: existing marker is touched on success response" {
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_response":{"content":[]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}
-
-@test "slide: long-running subprocess does NOT cause parent marker expiry on return (P111 reproduction)" {
-  # Simulate the P111 failure mode: parent's marker is set, then a long
-  # subprocess runs (we backdate the marker to simulate elapsed wall-clock),
-  # then PostToolUse fires with a successful tool_response. The marker mtime
-  # must be refreshed so the parent's NEXT PreToolUse gate check (which
-  # compares NOW - mtime against TTL) sees a fresh marker.
-  touch "$MARKER"
-  # Marker is 50 minutes old — under default 60-min TTL but close to expiry.
-  # Without the slide on subprocess return, a subsequent 15-min subprocess
-  # would push the mtime past TTL and the next PreToolUse would deny.
-  _backdate "$MARKER" 3000
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_response":{"content":[{"type":"text","text":"OK"}]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  NOW=$(date +%s)
-  [ "$AFTER" -gt "$BEFORE" ]
-  # And the new mtime is approximately NOW (within 5 seconds of slide call)
-  AGE=$((NOW - AFTER))
-  [ "$AGE" -lt 5 ]
-}
-
-@test "slide: does NOT touch marker when tool_response.is_error=true" {
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_response":{"is_error":true,"content":[]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  [ "$BEFORE" = "$AFTER" ]
-}
-
-@test "slide: no-op when marker does not exist (never creates)" {
-  [ ! -f "$MARKER" ]
-  _HOOK_INPUT='{"tool_response":{"content":[]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  [ ! -f "$MARKER" ]
-}
-
-@test "slide: no-op when marker path argument is empty" {
-  _HOOK_INPUT='{"tool_response":{"content":[]}}'
-  run slide_marker_on_subprocess_return ""
-  [ "$status" -eq 0 ]
-}
-
-@test "slide: malformed hook input is fail-safe (no slide)" {
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='not valid json'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  # Fail-safe: when the hook input cannot be parsed, treat as error and skip
-  [ "$BEFORE" = "$AFTER" ]
-}
-
-@test "slide: triggers correctly on Skill tool_response shape (P213, ADR-009 2026-06-08 amendment)" {
-  # hooks.json matcher expansion Agent|Bash → Agent|Bash|Skill (P213 Option D)
-  # widens slide-marker coverage to PostToolUse:Skill completions (e.g. the
-  # /wr-risk-scorer:assess-* sibling assessor SKILLs run as long subprocesses
-  # by the AFK orchestrator). The Skill tool_response shape is identical to
-  # Agent|Bash (Claude Code's uniform PostToolUse contract), so the matcher-
-  # agnostic helper composes without code changes. This test documents that
-  # contract explicitly so a future hook_input shape divergence regression
-  # surfaces here rather than at the gate-denial site.
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_name":"Skill","tool_response":{"content":[{"type":"text","text":"OK"}]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}

package/hooks/test/substance-aware-drift.bats

@@ -1,243 +0,0 @@
-#!/usr/bin/env bats
-
-# Behavioural tests for ADR-009 amendment 2026-06-06: substance-aware drift +
-# atomic verdict-write. Closes P353 (hash-marker brittleness umbrella) +
-# P303 (architect-gate multi-ADR deadlock drift-relock facet).
-#
-# Cases ratified by the user 2026-06-06:
-#   (a) Trivial edit (whitespace, CRLF, trailing newline) does NOT re-trigger.
-#   (b) Substantive edit (new content, changed line) DOES re-trigger.
-#   (c) Atomic write — marker + hash file land together on PASS, with the
-#       marker's mtime current and the hash file's content equal to the
-#       substance hash of the policy content.
-#   (d) Conservative fallback — semantic edits beyond the documented
-#       whitespace normalisation (e.g. single-numeral change) ARE treated as
-#       substantive (re-review fires).
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  source "$SCRIPT_DIR/lib/gate-helpers.sh"
-  source "$SCRIPT_DIR/lib/architect-gate.sh"
-
-  TEST_SESSION="bats-arch-substance-$$-${BATS_TEST_NUMBER}"
-  TEST_DIR=$(mktemp -d -t substance-aware-drift.XXXXXX)
-  mkdir -p "$TEST_DIR/docs/decisions"
-  CLAUDE_PROJECT_DIR="$TEST_DIR"
-  export CLAUDE_PROJECT_DIR
-
-  MARKER="/tmp/architect-reviewed-${TEST_SESSION}"
-  HASH_FILE="${MARKER}.hash"
-  rm -f "$MARKER" "$HASH_FILE"
-}
-
-teardown() {
-  rm -f "$MARKER" "$HASH_FILE"
-  rm -rf "$TEST_DIR"
-}
-
-# Helper: install ADR content, then store the substance hash + marker as the
-# architect-mark-reviewed.sh PASS path would.
-_install_and_mark() {
-  local body="$1"
-  printf '%s' "$body" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-  local hash
-  hash=$(_substance_hash_path "$TEST_DIR/docs/decisions")
-  _atomic_mark_with_hash "$MARKER" "$hash"
-}
-
-# ---------------------------------------------------------------------------
-# Case (a) — trivial whitespace / line-ending edits do NOT re-trigger
-# ---------------------------------------------------------------------------
-
-@test "substance-aware: trailing-whitespace edit does NOT re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-A line of policy content.
-"
-  # Add trailing spaces to the same line.
-  printf '%s' "# ADR-123
-
-A line of policy content.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -eq 0 ]
-  [ -f "$MARKER" ]
-  [ -f "$HASH_FILE" ]
-}
-
-@test "substance-aware: CRLF→LF edit does NOT re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-A line of policy content.
-"
-  # Convert the same content to CRLF line endings.
-  printf '# ADR-123\r\n\r\nA line of policy content.\r\n' \
-    > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -eq 0 ]
-  [ -f "$MARKER" ]
-}
-
-@test "substance-aware: extra trailing newlines do NOT re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-A line of policy content.
-"
-  # Add multiple trailing newlines.
-  printf '%s' "# ADR-123
-
-A line of policy content.
-
-
-
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -eq 0 ]
-  [ -f "$MARKER" ]
-}
-
-# ---------------------------------------------------------------------------
-# Case (b) — substantive content edits DO re-trigger
-# ---------------------------------------------------------------------------
-
-@test "substance-aware: new-word edit DOES re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-A line of policy content.
-"
-  # Real content change.
-  printf '%s' "# ADR-123
-
-A different line of policy content.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -ne 0 ]
-  [ ! -f "$MARKER" ]
-  [ ! -f "$HASH_FILE" ]
-}
-
-@test "substance-aware: added-paragraph edit DOES re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-A line of policy content.
-"
-  printf '%s' "# ADR-123
-
-A line of policy content.
-
-A whole new paragraph of substantive change.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -ne 0 ]
-  [ ! -f "$MARKER" ]
-}
-
-@test "substance-aware: new file in docs/decisions DOES re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-Content.
-"
-  # Adding a NEW ADR file is a substantive change.
-  printf '%s' "# ADR-124
-
-New ADR content.
-" > "$TEST_DIR/docs/decisions/124-new.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -ne 0 ]
-  [ ! -f "$MARKER" ]
-}
-
-# ---------------------------------------------------------------------------
-# Case (c) — atomic write persists the PASS marker reliably
-# ---------------------------------------------------------------------------
-
-@test "atomic-write: PASS write lands marker + hash together" {
-  printf '%s' "# ADR-123
-
-Policy content.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-  local hash
-  hash=$(_substance_hash_path "$TEST_DIR/docs/decisions")
-
-  run _atomic_mark_with_hash "$MARKER" "$hash"
-  [ "$status" -eq 0 ]
-  [ -f "$MARKER" ]
-  [ -f "$HASH_FILE" ]
-  # The stored hash equals the substance hash of the policy content.
-  [ "$(cat "$HASH_FILE")" = "$hash" ]
-}
-
-@test "atomic-write: failed hash-write leaves neither file (no half-state)" {
-  # Point the marker into a non-existent directory to force mv failure.
-  local bad_marker="/tmp/does-not-exist-bats-$$/architect-reviewed-${TEST_SESSION}"
-  run _atomic_mark_with_hash "$bad_marker" "deadbeef"
-  [ "$status" -ne 0 ]
-  [ ! -f "$bad_marker" ]
-  [ ! -f "${bad_marker}.hash" ]
-}
-
-@test "atomic-write: PASS write enables a subsequent gate check to allow" {
-  printf '%s' "# ADR-123
-
-Policy content.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-  local hash
-  hash=$(_substance_hash_path "$TEST_DIR/docs/decisions")
-  _atomic_mark_with_hash "$MARKER" "$hash"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Case (d) — conservative boundary: semantic edits beyond whitespace
-# normalisation ARE treated as substantive
-# ---------------------------------------------------------------------------
-
-@test "conservative: single-numeral change DOES re-trigger drift" {
-  _install_and_mark "# ADR-123
-
-Threshold is 5 minutes.
-"
-  # A single-numeral change is semantic — conservative boundary re-reviews.
-  printf '%s' "# ADR-123
-
-Threshold is 6 minutes.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -ne 0 ]
-  [ ! -f "$MARKER" ]
-}
-
-@test "conservative: frontmatter-key change DOES re-trigger drift" {
-  _install_and_mark "---
-status: proposed
-date: 2026-06-06
----
-
-# ADR-123
-
-Body.
-"
-  # Frontmatter date bump — conservative boundary re-reviews.
-  printf '%s' "---
-status: proposed
-date: 2026-06-07
----
-
-# ADR-123
-
-Body.
-" > "$TEST_DIR/docs/decisions/123-test.proposed.md"
-
-  run check_architect_gate "$TEST_SESSION"
-  [ "$status" -ne 0 ]
-  [ ! -f "$MARKER" ]
-}