@webpieces/dev-config 0.2.45 → 0.2.47

package/architecture/executors/validate-new-methods/executor.ts

@@ -2,15 +2,18 @@
  * Validate New Methods Executor
  *
  * Validates that newly added methods don't exceed a maximum line count.
- * Only runs when NX_BASE environment variable is set (affected mode).
+ * Runs in affected mode when:
+ *   1. NX_BASE environment variable is set (via nx affected), OR
+ *   2. Auto-detects base by finding merge-base with origin/main
  *
  * This validator encourages writing methods that read like a "table of contents"
  * where each method call describes a larger piece of work.
  *
  * Usage:
  * nx affected --target=validate-new-methods --base=origin/main
+ * OR: runs automatically via build's architecture:validate-complete dependency
  *
- * Escape hatch: Add eslint-disable comment with justification
+ * Escape hatch: Add webpieces-disable max-lines-new-methods comment with justification
  */
 
 import type { ExecutorContext } from '@nx/devkit';
@@ -40,6 +43,14 @@ const TMP_MD_FILE = 'webpieces.methodsize.md';
 
 const METHODSIZE_DOC_CONTENT = `# Instructions: New Method Too Long
 
+## Requirement
+
+**~50% of the time**, you can stay under the \`newMethodsMaxLines\` limit from nx.json
+by extracting logical units into well-named methods.
+
+**~99% of the time**, you can stay under the \`modifiedAndNewMethodsMaxLines\` limit from nx.json.
+Nearly all software can be written with methods under this size.
+
 ## The "Table of Contents" Principle
 
 Good code reads like a book's table of contents:
@@ -47,17 +58,16 @@ Good code reads like a book's table of contents:
 - Reading chapter titles gives you the full story
 - You can dive into chapters (implementations) for details
 
-## Why Limit New Methods to 20-30 Lines?
+## Why Limit New Methods?
 
-Methods under 20-30 lines are:
+Methods under the limit are:
 - Easy to review in a single screen
 - Simple to understand without scrolling
 - Quick for AI to analyze and suggest improvements
 - More testable in isolation
 - Self-documenting through well-named extracted methods
 
-**~50% of the time**, you can stay under 20-30 lines in new code by extracting
-logical units into well-named methods. This makes code more readable for both
+Extracting logical units into well-named methods makes code more readable for both
 AI and humans.
 
 ## How to Refactor
@@ -125,10 +135,10 @@ const result = this.buildResultObject(data);
 
 Sometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).
 
-**Escape hatch**: Add an eslint-disable comment with justification:
+**Escape hatch**: Add a webpieces-disable comment with justification:
 
 \`\`\`typescript
-// eslint-disable-next-line @webpieces/max-method-lines -- Complex state machine, splitting reduces clarity
+// webpieces-disable max-lines-new-methods -- Complex state machine, splitting reduces clarity
 async complexStateMachine(): Promise<void> {
     // ... longer method with justification
 }
@@ -140,7 +150,7 @@ async complexStateMachine(): Promise<void> {
 2. **IDENTIFY** logical units that can be extracted
 3. **EXTRACT** into well-named private methods
 4. **VERIFY** the main method now reads like a table of contents
-5. **IF NOT FEASIBLE**: Add eslint-disable with clear justification
+5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-methods comment with clear justification
 
 ## Remember
 
@@ -163,11 +173,14 @@ function writeTmpInstructions(workspaceRoot: string): string {
 }
 
 /**
- * Get changed TypeScript files between base and head
+ * Get changed TypeScript files between base and working tree.
+ * Uses `git diff base` (no three-dots) to match what `nx affected` does -
+ * this includes both committed and uncommitted changes in one diff.
  */
-function getChangedTypeScriptFiles(workspaceRoot: string, base: string, head: string): string[] {
+function getChangedTypeScriptFiles(workspaceRoot: string, base: string): string[] {
     try {
-        const output = execSync(`git diff --name-only ${base}...${head} -- '*.ts' '*.tsx'`, {
+        // Use two-dot diff (base to working tree) - same as nx affected
+        const output = execSync(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {
             cwd: workspaceRoot,
             encoding: 'utf-8',
         });
@@ -181,11 +194,14 @@ function getChangedTypeScriptFiles(workspaceRoot: string, base: string, head: st
 }
 
 /**
- * Get the diff content for a specific file
+ * Get the diff content for a specific file between base and working tree.
+ * Uses `git diff base` (no three-dots) to match what `nx affected` does -
+ * this includes both committed and uncommitted changes in one diff.
  */
-function getFileDiff(workspaceRoot: string, file: string, base: string, head: string): string {
+function getFileDiff(workspaceRoot: string, file: string, base: string): string {
     try {
-        return execSync(`git diff ${base}...${head} -- "${file}"`, {
+        // Use two-dot diff (base to working tree) - same as nx affected
+        return execSync(`git diff ${base} -- "${file}"`, {
             cwd: workspaceRoot,
             encoding: 'utf-8',
         });
@@ -203,14 +219,14 @@ function findNewMethodSignaturesInDiff(diffContent: string): Set<string> {
 
     // Patterns to match method definitions
     const patterns = [
-        // async methodName( or methodName(
-        /^\+\s*(async\s+)?(\w+)\s*\(/,
-        // function methodName(
-        /^\+\s*(async\s+)?function\s+(\w+)\s*\(/,
-        // const/let methodName = (async)? (
-        /^\+\s*(?:const|let)\s+(\w+)\s*=\s*(?:async\s*)?\(/,
-        // const/let methodName = (async)? function
-        /^\+\s*(?:const|let)\s+(\w+)\s*=\s*(?:async\s+)?function/,
+        // [export] [async] function methodName( - most explicit, check first
+        /^\+\s*(?:export\s+)?(?:async\s+)?function\s+(\w+)\s*\(/,
+        // [export] const/let methodName = [async] (
+        /^\+\s*(?:export\s+)?(?:const|let)\s+(\w+)\s*=\s*(?:async\s*)?\(/,
+        // [export] const/let methodName = [async] function
+        /^\+\s*(?:export\s+)?(?:const|let)\s+(\w+)\s*=\s*(?:async\s+)?function/,
+        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.
+        /^\+\s*(?:async\s+)?(\w+)\s*\(/,
     ];
 
     for (const line of lines) {
@@ -218,8 +234,8 @@ function findNewMethodSignaturesInDiff(diffContent: string): Set<string> {
             for (const pattern of patterns) {
                 const match = line.match(pattern);
                 if (match) {
-                    // Extract method name from different capture groups
-                    const methodName = match[2] || match[1];
+                    // Extract method name - now always in capture group 1
+                    const methodName = match[1];
                     if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {
                         newMethods.add(methodName);
                     }
@@ -232,20 +248,47 @@ function findNewMethodSignaturesInDiff(diffContent: string): Set<string> {
     return newMethods;
 }
 
+/**
+ * Check if a line contains a webpieces-disable comment that exempts from new method validation.
+ * Both max-lines-new-methods AND max-lines-new-and-modified are accepted here.
+ * - max-lines-new-methods: Exempts from 30-line check, still checked by 80-line validator
+ * - max-lines-new-and-modified: Exempts from both validators (ultimate escape hatch)
+ */
+function hasDisableComment(lines: string[], lineNumber: number): boolean {
+    // Check the line before the method (lineNumber is 1-indexed, array is 0-indexed)
+    // We need to check a few lines before in case there's JSDoc or decorators
+    const startCheck = Math.max(0, lineNumber - 5);
+    for (let i = lineNumber - 2; i >= startCheck; i--) {
+        const line = lines[i]?.trim() ?? '';
+        // Stop if we hit another function/class/etc
+        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {
+            break;
+        }
+        if (line.includes('webpieces-disable')) {
+            // Either escape hatch exempts from the 30-line new method check
+            if (line.includes('max-lines-new-methods') || line.includes('max-lines-new-and-modified')) {
+                return true;
+            }
+        }
+    }
+    return false;
+}
+
 /**
  * Parse a TypeScript file and find methods with their line counts
  */
 function findMethodsInFile(
     filePath: string,
     workspaceRoot: string
-): Array<{ name: string; line: number; lines: number }> {
+): Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> {
     const fullPath = path.join(workspaceRoot, filePath);
     if (!fs.existsSync(fullPath)) return [];
 
     const content = fs.readFileSync(fullPath, 'utf-8');
+    const fileLines = content.split('\n');
     const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);
 
-    const methods: Array<{ name: string; line: number; lines: number }> = [];
+    const methods: Array<{ name: string; line: number; lines: number; hasDisableComment: boolean }> = [];
 
     function visit(node: ts.Node): void {
         let methodName: string | undefined;
@@ -280,6 +323,7 @@ function findMethodsInFile(
                 name: methodName,
                 line: startLine,
                 lines: endLine - startLine + 1,
+                hasDisableComment: hasDisableComment(fileLines, startLine),
             });
         }
 
@@ -297,14 +341,13 @@ function findViolations(
     workspaceRoot: string,
     changedFiles: string[],
     base: string,
-    head: string,
     maxLines: number
 ): MethodViolation[] {
     const violations: MethodViolation[] = [];
 
     for (const file of changedFiles) {
         // Get the diff to find which methods are NEW (not just modified)
-        const diff = getFileDiff(workspaceRoot, file, base, head);
+        const diff = getFileDiff(workspaceRoot, file, base);
         const newMethodNames = findNewMethodSignaturesInDiff(diff);
 
         if (newMethodNames.size === 0) continue;
@@ -313,8 +356,8 @@ function findViolations(
         const methods = findMethodsInFile(file, workspaceRoot);
 
         for (const method of methods) {
-            // Only check NEW methods
-            if (newMethodNames.has(method.name) && method.lines > maxLines) {
+            // Only check NEW methods that don't have webpieces-disable comment
+            if (newMethodNames.has(method.name) && method.lines > maxLines && !method.hasDisableComment) {
                 violations.push({
                     file,
                     methodName: method.name,
@@ -329,6 +372,41 @@ function findViolations(
     return violations;
 }
 
+/**
+ * Auto-detect the base branch by finding the merge-base with origin/main.
+ * This allows the executor to run even when NX_BASE isn't set (e.g., via dependsOn).
+ */
+function detectBase(workspaceRoot: string): string | null {
+    try {
+        // First, try to get merge-base with origin/main
+        const mergeBase = execSync('git merge-base HEAD origin/main', {
+            cwd: workspaceRoot,
+            encoding: 'utf-8',
+            stdio: ['pipe', 'pipe', 'pipe'],
+        }).trim();
+
+        if (mergeBase) {
+            return mergeBase;
+        }
+    } catch {
+        // origin/main might not exist, try main
+        try {
+            const mergeBase = execSync('git merge-base HEAD main', {
+                cwd: workspaceRoot,
+                encoding: 'utf-8',
+                stdio: ['pipe', 'pipe', 'pipe'],
+            }).trim();
+
+            if (mergeBase) {
+                return mergeBase;
+            }
+        } catch {
+            // Ignore - will return null
+        }
+    }
+    return null;
+}
+
 export default async function runExecutor(
     options: ValidateNewMethodsOptions,
     context: ExecutorContext
@@ -336,26 +414,35 @@ export default async function runExecutor(
     const workspaceRoot = context.root;
     const maxLines = options.max ?? 30;
 
-    // Check if running in affected mode
-    const base = process.env['NX_BASE'];
-    const head = process.env['NX_HEAD'] || 'HEAD';
+    // Check if running in affected mode via NX_BASE, or auto-detect
+    // We use NX_BASE as the base, and compare to WORKING TREE (not NX_HEAD)
+    // This matches what `nx affected` does - it compares base to working tree
+    let base = process.env['NX_BASE'];
 
     if (!base) {
-        console.log('\n⏭️  Skipping new method validation (not in affected mode)');
-        console.log('   To run: nx affected --target=validate-new-methods --base=origin/main');
-        console.log('');
-        return { success: true };
+        // Try to auto-detect base from git merge-base
+        base = detectBase(workspaceRoot) ?? undefined;
+
+        if (!base) {
+            console.log('\n⏭️  Skipping new method validation (could not detect base branch)');
+            console.log('   To run explicitly: nx affected --target=validate-new-methods --base=origin/main');
+            console.log('');
+            return { success: true };
+        }
+
+        console.log('\n📏 Validating New Method Sizes (auto-detected base)\n');
+    } else {
+        console.log('\n📏 Validating New Method Sizes\n');
     }
 
-    console.log('\n📏 Validating New Method Sizes\n');
     console.log(`   Base: ${base}`);
-    console.log(`   Head: ${head}`);
+    console.log(`   Comparing to: working tree (includes uncommitted changes)`);
     console.log(`   Max lines for new methods: ${maxLines}`);
     console.log('');
 
     try {
-        // Get changed TypeScript files
-        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base, head);
+        // Get changed TypeScript files (base to working tree, like nx affected)
+        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);
 
         if (changedFiles.length === 0) {
             console.log('✅ No TypeScript files changed');
@@ -365,7 +452,7 @@ export default async function runExecutor(
         console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);
 
         // Find violations
-        const violations = findViolations(workspaceRoot, changedFiles, base, head, maxLines);
+        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);
 
         if (violations.length === 0) {
             console.log('✅ All new methods are under ' + maxLines + ' lines');
@@ -373,30 +460,23 @@ export default async function runExecutor(
         }
 
         // Write instructions file
-        const mdPath = writeTmpInstructions(workspaceRoot);
+        writeTmpInstructions(workspaceRoot);
 
         // Report violations
         console.error('');
         console.error('❌ New methods exceed ' + maxLines + ' lines!');
         console.error('');
         console.error('📚 Methods should read like a "table of contents" - each method call');
-        console.error('   describes a larger piece of work. ~50% of the time, you can refactor');
-        console.error('   to stay under ' + maxLines + ' lines. If not feasible, use the escape hatch.');
+        console.error('   describes a larger piece of work. You can refactor');
+        console.error('   to stay under ' + maxLines + ' lines 50% of the time. If not feasible, use the escape hatch.');
+        console.error('');
+        console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
         console.error('');
 
         for (const v of violations) {
             console.error(`  ❌ ${v.file}:${v.line}`);
             console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
-            console.error(`     READ ${mdPath} to fix this error properly`);
-            console.error('');
         }
-
-        console.error('💡 To fix:');
-        console.error('   1. Refactor the method to read like a table of contents (preferred)');
-        console.error('   2. OR add eslint-disable comment with justification:');
-        console.error('      // eslint-disable-next-line @webpieces/max-method-lines -- [reason]');
-        console.error('');
-        console.error(`⚠️  *** READ ${mdPath} for detailed guidance *** ⚠️`);
         console.error('');
 
         return { success: false };

package/architecture/lib/graph-loader.js

@@ -37,6 +37,34 @@ function loadBlessedGraph(workspaceRoot, graphPath = exports.DEFAULT_GRAPH_PATH)
         throw new Error(`Failed to load graph from ${fullPath}: ${err}`);
     }
 }
+/**
+ * Format a graph as JSON with multi-line arrays for readability
+ */
+function formatGraphJson(graph) {
+    const lines = ['{'];
+    const keys = Object.keys(graph).sort();
+    keys.forEach((key, index) => {
+        const entry = graph[key];
+        const isLast = index === keys.length - 1;
+        const comma = isLast ? '' : ',';
+        lines.push(`  "${key}": {`);
+        lines.push(`    "level": ${entry.level},`);
+        if (entry.dependsOn.length === 0) {
+            lines.push(`    "dependsOn": []`);
+        }
+        else {
+            lines.push(`    "dependsOn": [`);
+            entry.dependsOn.forEach((dep, depIndex) => {
+                const depComma = depIndex === entry.dependsOn.length - 1 ? '' : ',';
+                lines.push(`      "${dep}"${depComma}`);
+            });
+            lines.push(`    ]`);
+        }
+        lines.push(`  }${comma}`);
+    });
+    lines.push('}');
+    return lines.join('\n') + '\n';
+}
 /**
  * Save the graph to disk
  *
@@ -57,7 +85,7 @@ function saveGraph(graph, workspaceRoot, graphPath = exports.DEFAULT_GRAPH_PATH)
     for (const key of sortedKeys) {
         sortedGraph[key] = graph[key];
     }
-    const content = JSON.stringify(sortedGraph, null, 4) + '\n';
+    const content = formatGraphJson(sortedGraph);
     fs.writeFileSync(fullPath, content, 'utf-8');
 }
 /**

package/architecture/lib/graph-loader.js.map

@@ -1 +1 @@
-{"version":3,"file":"graph-loader.js","sourceRoot":"","sources":["../../../../../../packages/tooling/dev-config/architecture/lib/graph-loader.ts"],"names":[],"mappings":";AAAA;;;;;GAKG;;;AAkBH,4CAgBC;AASD,8BAsBC;AAKD,0CAMC;;AA1ED,+CAAyB;AACzB,mDAA6B;AAG7B;;GAEG;AACU,QAAA,kBAAkB,GAAG,gCAAgC,CAAC;AAEnE;;;;;;GAMG;AACH,SAAgB,gBAAgB,CAC5B,aAAqB,EACrB,YAAoB,0BAAkB;IAEtC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,SAAS,CAAC,CAAC;IAErD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC3B,OAAO,IAAI,CAAC;IAChB,CAAC;IAED,IAAI,CAAC;QACD,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QACnD,OAAO,IAAI,CAAC,KAAK,CAAC,OAAO,CAAkB,CAAC;IAChD,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,IAAI,KAAK,CAAC,6BAA6B,QAAQ,KAAK,GAAG,EAAE,CAAC,CAAC;IACrE,CAAC;AACL,CAAC;AAED;;;;;;GAMG;AACH,SAAgB,SAAS,CACrB,KAAoB,EACpB,aAAqB,EACrB,YAAoB,0BAAkB;IAEtC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,SAAS,CAAC,CAAC;IACrD,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IAEnC,0BAA0B;IAC1B,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;QACtB,EAAE,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC3C,CAAC;IAED,qCAAqC;IACrC,MAAM,WAAW,GAAkB,EAAE,CAAC;IACtC,MAAM,UAAU,GAAG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC;IAC7C,KAAK,MAAM,GAAG,IAAI,UAAU,EAAE,CAAC;QAC3B,WAAW,CAAC,GAAG,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC;IAClC,CAAC;IAED,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,WAAW,EAAE,IAAI,EAAE,CAAC,CAAC,GAAG,IAAI,CAAC;IAC5D,EAAE,CAAC,aAAa,CAAC,QAAQ,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;AACjD,CAAC;AAED;;GAEG;AACH,SAAgB,eAAe,CAC3B,aAAqB,EACrB,YAAoB,0BAAkB;IAEtC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,SAAS,CAAC,CAAC;IACrD,OAAO,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC;AACnC,CAAC","sourcesContent":["/**\n * Graph Loader\n *\n * Handles loading and saving the blessed dependency graph file.\n * The graph is stored at architecture/dependencies.json in the workspace root.\n */\n\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport type { EnhancedGraph } from './graph-sorter';\n\n/**\n * Default path for the dependencies file (relative to workspace root)\n */\nexport const DEFAULT_GRAPH_PATH = 'architecture/dependencies.json';\n\n/**\n * Load the blessed graph from disk\n *\n * @param workspaceRoot - Absolute path to workspace root\n * @param graphPath - Relative path to graph file (default: .graphs/dependencies.json)\n * @returns The blessed graph, or null if file doesn't exist\n */\nexport function loadBlessedGraph(\n    workspaceRoot: string,\n    graphPath: string = DEFAULT_GRAPH_PATH\n): EnhancedGraph | null {\n    const fullPath = path.join(workspaceRoot, graphPath);\n\n    if (!fs.existsSync(fullPath)) {\n        return null;\n    }\n\n    try {\n        const content = fs.readFileSync(fullPath, 'utf-8');\n        return JSON.parse(content) as EnhancedGraph;\n    } catch (err: unknown) {\n        throw new Error(`Failed to load graph from ${fullPath}: ${err}`);\n    }\n}\n\n/**\n * Save the graph to disk\n *\n * @param graph - The graph to save\n * @param workspaceRoot - Absolute path to workspace root\n * @param graphPath - Relative path to graph file (default: .graphs/dependencies.json)\n */\nexport function saveGraph(\n    graph: EnhancedGraph,\n    workspaceRoot: string,\n    graphPath: string = DEFAULT_GRAPH_PATH\n): void {\n    const fullPath = path.join(workspaceRoot, graphPath);\n    const dir = path.dirname(fullPath);\n\n    // Ensure directory exists\n    if (!fs.existsSync(dir)) {\n        fs.mkdirSync(dir, { recursive: true });\n    }\n\n    // Sort keys for deterministic output\n    const sortedGraph: EnhancedGraph = {};\n    const sortedKeys = Object.keys(graph).sort();\n    for (const key of sortedKeys) {\n        sortedGraph[key] = graph[key];\n    }\n\n    const content = JSON.stringify(sortedGraph, null, 4) + '\\n';\n    fs.writeFileSync(fullPath, content, 'utf-8');\n}\n\n/**\n * Check if the graph file exists\n */\nexport function graphFileExists(\n    workspaceRoot: string,\n    graphPath: string = DEFAULT_GRAPH_PATH\n): boolean {\n    const fullPath = path.join(workspaceRoot, graphPath);\n    return fs.existsSync(fullPath);\n}\n"]}
+{"version":3,"file":"graph-loader.js","sourceRoot":"","sources":["../../../../../../packages/tooling/dev-config/architecture/lib/graph-loader.ts"],"names":[],"mappings":";AAAA;;;;;GAKG;;;AAkBH,4CAgBC;AA0CD,8BAsBC;AAKD,0CAMC;;AA3GD,+CAAyB;AACzB,mDAA6B;AAG7B;;GAEG;AACU,QAAA,kBAAkB,GAAG,gCAAgC,CAAC;AAEnE;;;;;;GAMG;AACH,SAAgB,gBAAgB,CAC5B,aAAqB,EACrB,YAAoB,0BAAkB;IAEtC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,SAAS,CAAC,CAAC;IAErD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC3B,OAAO,IAAI,CAAC;IAChB,CAAC;IAED,IAAI,CAAC;QACD,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QACnD,OAAO,IAAI,CAAC,KAAK,CAAC,OAAO,CAAkB,CAAC;IAChD,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,IAAI,KAAK,CAAC,6BAA6B,QAAQ,KAAK,GAAG,EAAE,CAAC,CAAC;IACrE,CAAC;AACL,CAAC;AAED;;GAEG;AACH,SAAS,eAAe,CAAC,KAAoB;IACzC,MAAM,KAAK,GAAa,CAAC,GAAG,CAAC,CAAC;IAC9B,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC;IAEvC,IAAI,CAAC,OAAO,CAAC,CAAC,GAAG,EAAE,KAAK,EAAE,EAAE;QACxB,MAAM,KAAK,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC;QACzB,MAAM,MAAM,GAAG,KAAK,KAAK,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC;QACzC,MAAM,KAAK,GAAG,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC;QAEhC,KAAK,CAAC,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC,CAAC;QAC5B,KAAK,CAAC,IAAI,CAAC,gBAAgB,KAAK,CAAC,KAAK,GAAG,CAAC,CAAC;QAE3C,IAAI,KAAK,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC/B,KAAK,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;QACtC,CAAC;aAAM,CAAC;YACJ,KAAK,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;YACjC,KAAK,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,GAAG,EAAE,QAAQ,EAAE,EAAE;gBACtC,MAAM,QAAQ,GAAG,QAAQ,KAAK,KAAK,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC;gBACpE,KAAK,CAAC,IAAI,CAAC,UAAU,GAAG,IAAI,QAAQ,EAAE,CAAC,CAAC;YAC5C,CAAC,CAAC,CAAC;YACH,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACxB,CAAC;QAED,KAAK,CAAC,IAAI,CAAC,MAAM,KAAK,EAAE,CAAC,CAAC;IAC9B,CAAC,CAAC,CAAC;IAEH,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAChB,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;AACnC,CAAC;AAED;;;;;;GAMG;AACH,SAAgB,SAAS,CACrB,KAAoB,EACpB,aAAqB,EACrB,YAAoB,0BAAkB;IAEtC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,SAAS,CAAC,CAAC;IACrD,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IAEnC,0BAA0B;IAC1B,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;QACtB,EAAE,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC3C,CAAC;IAED,qCAAqC;IACrC,MAAM,WAAW,GAAkB,EAAE,CAAC;IACtC,MAAM,UAAU,GAAG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC;IAC7C,KAAK,MAAM,GAAG,IAAI,UAAU,EAAE,CAAC;QAC3B,WAAW,CAAC,GAAG,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC;IAClC,CAAC;IAED,MAAM,OAAO,GAAG,eAAe,CAAC,WAAW,CAAC,CAAC;IAC7C,EAAE,CAAC,aAAa,CAAC,QAAQ,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;AACjD,CAAC;AAED;;GAEG;AACH,SAAgB,eAAe,CAC3B,aAAqB,EACrB,YAAoB,0BAAkB;IAEtC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,SAAS,CAAC,CAAC;IACrD,OAAO,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC;AACnC,CAAC","sourcesContent":["/**\n * Graph Loader\n *\n * Handles loading and saving the blessed dependency graph file.\n * The graph is stored at architecture/dependencies.json in the workspace root.\n */\n\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport type { EnhancedGraph } from './graph-sorter';\n\n/**\n * Default path for the dependencies file (relative to workspace root)\n */\nexport const DEFAULT_GRAPH_PATH = 'architecture/dependencies.json';\n\n/**\n * Load the blessed graph from disk\n *\n * @param workspaceRoot - Absolute path to workspace root\n * @param graphPath - Relative path to graph file (default: .graphs/dependencies.json)\n * @returns The blessed graph, or null if file doesn't exist\n */\nexport function loadBlessedGraph(\n    workspaceRoot: string,\n    graphPath: string = DEFAULT_GRAPH_PATH\n): EnhancedGraph | null {\n    const fullPath = path.join(workspaceRoot, graphPath);\n\n    if (!fs.existsSync(fullPath)) {\n        return null;\n    }\n\n    try {\n        const content = fs.readFileSync(fullPath, 'utf-8');\n        return JSON.parse(content) as EnhancedGraph;\n    } catch (err: unknown) {\n        throw new Error(`Failed to load graph from ${fullPath}: ${err}`);\n    }\n}\n\n/**\n * Format a graph as JSON with multi-line arrays for readability\n */\nfunction formatGraphJson(graph: EnhancedGraph): string {\n    const lines: string[] = ['{'];\n    const keys = Object.keys(graph).sort();\n\n    keys.forEach((key, index) => {\n        const entry = graph[key];\n        const isLast = index === keys.length - 1;\n        const comma = isLast ? '' : ',';\n\n        lines.push(`  \"${key}\": {`);\n        lines.push(`    \"level\": ${entry.level},`);\n\n        if (entry.dependsOn.length === 0) {\n            lines.push(`    \"dependsOn\": []`);\n        } else {\n            lines.push(`    \"dependsOn\": [`);\n            entry.dependsOn.forEach((dep, depIndex) => {\n                const depComma = depIndex === entry.dependsOn.length - 1 ? '' : ',';\n                lines.push(`      \"${dep}\"${depComma}`);\n            });\n            lines.push(`    ]`);\n        }\n\n        lines.push(`  }${comma}`);\n    });\n\n    lines.push('}');\n    return lines.join('\\n') + '\\n';\n}\n\n/**\n * Save the graph to disk\n *\n * @param graph - The graph to save\n * @param workspaceRoot - Absolute path to workspace root\n * @param graphPath - Relative path to graph file (default: .graphs/dependencies.json)\n */\nexport function saveGraph(\n    graph: EnhancedGraph,\n    workspaceRoot: string,\n    graphPath: string = DEFAULT_GRAPH_PATH\n): void {\n    const fullPath = path.join(workspaceRoot, graphPath);\n    const dir = path.dirname(fullPath);\n\n    // Ensure directory exists\n    if (!fs.existsSync(dir)) {\n        fs.mkdirSync(dir, { recursive: true });\n    }\n\n    // Sort keys for deterministic output\n    const sortedGraph: EnhancedGraph = {};\n    const sortedKeys = Object.keys(graph).sort();\n    for (const key of sortedKeys) {\n        sortedGraph[key] = graph[key];\n    }\n\n    const content = formatGraphJson(sortedGraph);\n    fs.writeFileSync(fullPath, content, 'utf-8');\n}\n\n/**\n * Check if the graph file exists\n */\nexport function graphFileExists(\n    workspaceRoot: string,\n    graphPath: string = DEFAULT_GRAPH_PATH\n): boolean {\n    const fullPath = path.join(workspaceRoot, graphPath);\n    return fs.existsSync(fullPath);\n}\n"]}

package/architecture/lib/graph-loader.ts

@@ -39,6 +39,39 @@ export function loadBlessedGraph(
     }
 }
 
+/**
+ * Format a graph as JSON with multi-line arrays for readability
+ */
+function formatGraphJson(graph: EnhancedGraph): string {
+    const lines: string[] = ['{'];
+    const keys = Object.keys(graph).sort();
+
+    keys.forEach((key, index) => {
+        const entry = graph[key];
+        const isLast = index === keys.length - 1;
+        const comma = isLast ? '' : ',';
+
+        lines.push(`  "${key}": {`);
+        lines.push(`    "level": ${entry.level},`);
+
+        if (entry.dependsOn.length === 0) {
+            lines.push(`    "dependsOn": []`);
+        } else {
+            lines.push(`    "dependsOn": [`);
+            entry.dependsOn.forEach((dep, depIndex) => {
+                const depComma = depIndex === entry.dependsOn.length - 1 ? '' : ',';
+                lines.push(`      "${dep}"${depComma}`);
+            });
+            lines.push(`    ]`);
+        }
+
+        lines.push(`  }${comma}`);
+    });
+
+    lines.push('}');
+    return lines.join('\n') + '\n';
+}
+
 /**
  * Save the graph to disk
  *
@@ -66,7 +99,7 @@ export function saveGraph(
         sortedGraph[key] = graph[key];
     }
 
-    const content = JSON.stringify(sortedGraph, null, 4) + '\n';
+    const content = formatGraphJson(sortedGraph);
     fs.writeFileSync(fullPath, content, 'utf-8');
 }
 

package/executors.json

@@ -35,6 +35,11 @@
             "schema": "./architecture/executors/validate-new-methods/schema.json",
             "description": "Validate new methods don't exceed max line count (only runs in affected mode)"
         },
+        "validate-modified-methods": {
+            "implementation": "./architecture/executors/validate-modified-methods/executor",
+            "schema": "./architecture/executors/validate-modified-methods/schema.json",
+            "description": "Validate modified methods don't exceed max line count (encourages gradual cleanup)"
+        },
         "help": {
             "implementation": "./executors/help/executor",
             "schema": "./executors/help/schema.json",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webpieces/dev-config",
-  "version": "0.2.45",
+  "version": "0.2.47",
   "description": "Development configuration, scripts, and patterns for WebPieces projects",
   "type": "commonjs",
   "bin": {

package/plugin.js

@@ -36,6 +36,9 @@ const DEFAULT_OPTIONS = {
             architectureUnchanged: true,
             validatePackageJson: true,
             validateNewMethods: true,
+            validateModifiedMethods: true,
+            newMethodsMaxLines: 30,
+            modifiedAndNewMethodsMaxLines: 80,
         },
         features: {
             generate: true,
@@ -165,7 +168,10 @@ function createWorkspaceTargetsWithoutPrefix(opts) {
         targets['validate-packagejson'] = createValidatePackageJsonTarget();
     }
     if (opts.workspace.validations.validateNewMethods) {
-        targets['validate-new-methods'] = createValidateNewMethodsTarget();
+        targets['validate-new-methods'] = createValidateNewMethodsTarget(opts.workspace.validations.newMethodsMaxLines);
+    }
+    if (opts.workspace.validations.validateModifiedMethods) {
+        targets['validate-modified-methods'] = createValidateModifiedMethodsTarget(opts.workspace.validations.modifiedAndNewMethodsMaxLines);
     }
     // Add validate-complete target that runs all validations
     const validationTargets = [];
@@ -184,6 +190,9 @@ function createWorkspaceTargetsWithoutPrefix(opts) {
     if (opts.workspace.validations.validateNewMethods) {
         validationTargets.push('validate-new-methods');
     }
+    if (opts.workspace.validations.validateModifiedMethods) {
+        validationTargets.push('validate-modified-methods');
+    }
     if (validationTargets.length > 0) {
         targets['validate-complete'] = createValidateCompleteTarget(validationTargets);
     }
@@ -218,7 +227,10 @@ function createWorkspaceTargets(opts) {
         targets[`${prefix}validate-packagejson`] = createValidatePackageJsonTarget();
     }
     if (opts.workspace.validations.validateNewMethods) {
-        targets[`${prefix}validate-new-methods`] = createValidateNewMethodsTarget();
+        targets[`${prefix}validate-new-methods`] = createValidateNewMethodsTarget(opts.workspace.validations.newMethodsMaxLines);
+    }
+    if (opts.workspace.validations.validateModifiedMethods) {
+        targets[`${prefix}validate-modified-methods`] = createValidateModifiedMethodsTarget(opts.workspace.validations.modifiedAndNewMethodsMaxLines);
     }
     return targets;
 }
@@ -302,15 +314,27 @@ function createValidatePackageJsonTarget() {
         },
     };
 }
-function createValidateNewMethodsTarget() {
+function createValidateNewMethodsTarget(maxLines) {
     return {
         executor: '@webpieces/dev-config:validate-new-methods',
         cache: false, // Don't cache - depends on git state
         inputs: ['default'],
-        options: { max: 30 },
+        options: { max: maxLines },
+        metadata: {
+            technologies: ['nx'],
+            description: `Validate new methods do not exceed ${maxLines} lines (only runs in affected mode)`,
+        },
+    };
+}
+function createValidateModifiedMethodsTarget(maxLines) {
+    return {
+        executor: '@webpieces/dev-config:validate-modified-methods',
+        cache: false, // Don't cache - depends on git state
+        inputs: ['default'],
+        options: { max: maxLines },
         metadata: {
             technologies: ['nx'],
-            description: 'Validate new methods do not exceed max line count (only runs in affected mode)',
+            description: `Validate new and modified methods do not exceed ${maxLines} lines (encourages gradual cleanup)`,
         },
     };
 }

package/src/generators/init/generator.js

@@ -53,9 +53,20 @@ function registerPlugin(tree) {
     const pluginName = '@webpieces/dev-config';
     const alreadyRegistered = nxJson.plugins.some((p) => typeof p === 'string' ? p === pluginName : p.plugin === pluginName);
     if (!alreadyRegistered) {
-        nxJson.plugins.push(pluginName);
+        // Register plugin with default options for method size validation
+        nxJson.plugins.push({
+            plugin: pluginName,
+            options: {
+                workspace: {
+                    validations: {
+                        newMethodsMaxLines: 30,
+                        modifiedAndNewMethodsMaxLines: 80,
+                    },
+                },
+            },
+        });
         (0, devkit_1.updateNxJson)(tree, nxJson);
-        console.log(`✅ Registered ${pluginName} plugin in nx.json`);
+        console.log(`✅ Registered ${pluginName} plugin in nx.json with default options`);
     }
     else {
         console.log(`ℹ️  ${pluginName} plugin is already registered`);