@webpieces/dev-config 0.2.45 → 0.2.47

package/architecture/executors/validate-modified-methods/executor.d.ts

@@ -0,0 +1,26 @@
+/**
+ * Validate Modified Methods Executor
+ *
+ * Validates that modified methods don't exceed a maximum line count (default 80).
+ * This encourages gradual cleanup of legacy long methods - when you touch a method,
+ * you must bring it under the limit.
+ *
+ * Combined with validate-new-methods (30 line limit), this creates a gradual
+ * transition to cleaner code:
+ * - New methods: strict 30 line limit
+ * - Modified methods: lenient 80 line limit (cleanup when touched)
+ * - Untouched methods: no limit (legacy allowed)
+ *
+ * Usage:
+ * nx affected --target=validate-modified-methods --base=origin/main
+ *
+ * Escape hatch: Add webpieces-disable max-lines-new-and-modified comment with justification
+ */
+import type { ExecutorContext } from '@nx/devkit';
+export interface ValidateModifiedMethodsOptions {
+    max?: number;
+}
+export interface ExecutorResult {
+    success: boolean;
+}
+export default function runExecutor(options: ValidateModifiedMethodsOptions, context: ExecutorContext): Promise<ExecutorResult>;

package/architecture/executors/validate-modified-methods/executor.js

@@ -0,0 +1,505 @@
+"use strict";
+/**
+ * Validate Modified Methods Executor
+ *
+ * Validates that modified methods don't exceed a maximum line count (default 80).
+ * This encourages gradual cleanup of legacy long methods - when you touch a method,
+ * you must bring it under the limit.
+ *
+ * Combined with validate-new-methods (30 line limit), this creates a gradual
+ * transition to cleaner code:
+ * - New methods: strict 30 line limit
+ * - Modified methods: lenient 80 line limit (cleanup when touched)
+ * - Untouched methods: no limit (legacy allowed)
+ *
+ * Usage:
+ * nx affected --target=validate-modified-methods --base=origin/main
+ *
+ * Escape hatch: Add webpieces-disable max-lines-new-and-modified comment with justification
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = runExecutor;
+const tslib_1 = require("tslib");
+const child_process_1 = require("child_process");
+const fs = tslib_1.__importStar(require("fs"));
+const path = tslib_1.__importStar(require("path"));
+const ts = tslib_1.__importStar(require("typescript"));
+const TMP_DIR = 'tmp/webpieces';
+const TMP_MD_FILE = 'webpieces.methodsize.md';
+const METHODSIZE_DOC_CONTENT = `# Instructions: Method Too Long
+
+## Requirement
+
+**~50% of the time**, you can stay under the \`newMethodsMaxLines\` limit from nx.json
+by extracting logical units into well-named methods.
+
+**~99% of the time**, you can stay under the \`modifiedAndNewMethodsMaxLines\` limit from nx.json.
+Nearly all software can be written with methods under this size.
+Take the extra time to refactor - it's worth it for long-term maintainability.
+
+## The "Table of Contents" Principle
+
+Good code reads like a book's table of contents:
+- Chapter titles (method names) tell you WHAT happens
+- Reading chapter titles gives you the full story
+- You can dive into chapters (implementations) for details
+
+## Why Limit Method Sizes?
+
+Methods under reasonable limits are:
+- Easy to review in a single screen
+- Simple to understand without scrolling
+- Quick for AI to analyze and suggest improvements
+- More testable in isolation
+- Self-documenting through well-named extracted methods
+
+## Gradual Cleanup Strategy
+
+This codebase uses a gradual cleanup approach:
+- **New methods**: Must be under \`newMethodsMaxLines\` from nx.json
+- **Modified methods**: Must be under \`modifiedAndNewMethodsMaxLines\` from nx.json
+- **Untouched methods**: No limit (legacy code is allowed until touched)
+
+## How to Refactor
+
+Instead of:
+\`\`\`typescript
+async processOrder(order: Order): Promise<Result> {
+    // 100 lines of validation, transformation, saving, notifications...
+}
+\`\`\`
+
+Write:
+\`\`\`typescript
+async processOrder(order: Order): Promise<Result> {
+    const validated = this.validateOrder(order);
+    const transformed = this.applyBusinessRules(validated);
+    const saved = await this.saveToDatabase(transformed);
+    await this.notifyStakeholders(saved);
+    return this.buildResult(saved);
+}
+\`\`\`
+
+Now the main method is a "table of contents" - each line tells part of the story!
+
+## Patterns for Extraction
+
+### Pattern 1: Extract Loop Bodies
+\`\`\`typescript
+// BEFORE
+for (const item of items) {
+    // 20 lines of processing
+}
+
+// AFTER
+for (const item of items) {
+    this.processItem(item);
+}
+\`\`\`
+
+### Pattern 2: Extract Conditional Blocks
+\`\`\`typescript
+// BEFORE
+if (isAdmin(user)) {
+    // 15 lines of admin logic
+}
+
+// AFTER
+if (isAdmin(user)) {
+    this.handleAdminUser(user);
+}
+\`\`\`
+
+### Pattern 3: Extract Data Transformations
+\`\`\`typescript
+// BEFORE
+const result = {
+    // 10+ lines of object construction
+};
+
+// AFTER
+const result = this.buildResultObject(data);
+\`\`\`
+
+## If Refactoring Is Not Feasible
+
+Sometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).
+
+**Escape hatch**: Add a webpieces-disable comment with justification:
+
+\`\`\`typescript
+// webpieces-disable max-lines-new-and-modified -- Complex state machine, splitting reduces clarity
+async complexStateMachine(): Promise<void> {
+    // ... longer method with justification
+}
+\`\`\`
+
+## AI Agent Action Steps
+
+1. **READ** the method to understand its logical sections
+2. **IDENTIFY** logical units that can be extracted
+3. **EXTRACT** into well-named private methods
+4. **VERIFY** the main method now reads like a table of contents
+5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-and-modified comment with clear justification
+
+## Remember
+
+- Every method you write today will be read many times tomorrow
+- The best code explains itself through structure
+- When in doubt, extract and name it
+`;
+/**
+ * Write the instructions documentation to tmp directory
+ */
+function writeTmpInstructions(workspaceRoot) {
+    const tmpDir = path.join(workspaceRoot, TMP_DIR);
+    const mdPath = path.join(tmpDir, TMP_MD_FILE);
+    fs.mkdirSync(tmpDir, { recursive: true });
+    fs.writeFileSync(mdPath, METHODSIZE_DOC_CONTENT);
+    return mdPath;
+}
+/**
+ * Get changed TypeScript files between base and working tree.
+ * Uses `git diff base` (no three-dots) to match what `nx affected` does -
+ * this includes both committed and uncommitted changes in one diff.
+ */
+function getChangedTypeScriptFiles(workspaceRoot, base) {
+    try {
+        // Use two-dot diff (base to working tree) - same as nx affected
+        const output = (0, child_process_1.execSync)(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {
+            cwd: workspaceRoot,
+            encoding: 'utf-8',
+        });
+        return output
+            .trim()
+            .split('\n')
+            .filter((f) => f && !f.includes('.spec.ts') && !f.includes('.test.ts'));
+    }
+    catch {
+        return [];
+    }
+}
+/**
+ * Get the diff content for a specific file between base and working tree.
+ * Uses `git diff base` (no three-dots) to match what `nx affected` does -
+ * this includes both committed and uncommitted changes in one diff.
+ */
+function getFileDiff(workspaceRoot, file, base) {
+    try {
+        // Use two-dot diff (base to working tree) - same as nx affected
+        return (0, child_process_1.execSync)(`git diff ${base} -- "${file}"`, {
+            cwd: workspaceRoot,
+            encoding: 'utf-8',
+        });
+    }
+    catch {
+        return '';
+    }
+}
+/**
+ * Parse diff to find NEW method signatures.
+ * Must handle: export function, async function, const/let arrow functions, class methods
+ */
+// webpieces-disable max-lines-new-methods -- Regex patterns require inline documentation
+function findNewMethodSignaturesInDiff(diffContent) {
+    const newMethods = new Set();
+    const lines = diffContent.split('\n');
+    // Patterns to match method definitions (same as validate-new-methods)
+    const patterns = [
+        // [export] [async] function methodName( - most explicit, check first
+        /^\+\s*(?:export\s+)?(?:async\s+)?function\s+(\w+)\s*\(/,
+        // [export] const/let methodName = [async] (
+        /^\+\s*(?:export\s+)?(?:const|let)\s+(\w+)\s*=\s*(?:async\s*)?\(/,
+        // [export] const/let methodName = [async] function
+        /^\+\s*(?:export\s+)?(?:const|let)\s+(\w+)\s*=\s*(?:async\s+)?function/,
+        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.
+        /^\+\s*(?:async\s+)?(\w+)\s*\(/,
+    ];
+    for (const line of lines) {
+        if (line.startsWith('+') && !line.startsWith('+++')) {
+            for (const pattern of patterns) {
+                const match = line.match(pattern);
+                if (match) {
+                    // Extract method name - now always in capture group 1
+                    const methodName = match[1];
+                    if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {
+                        newMethods.add(methodName);
+                    }
+                    break;
+                }
+            }
+        }
+    }
+    return newMethods;
+}
+/**
+ * Parse diff to find line numbers that have changes in the new file
+ */
+function getChangedLineNumbers(diffContent) {
+    const changedLines = new Set();
+    const lines = diffContent.split('\n');
+    let currentNewLine = 0;
+    for (const line of lines) {
+        // Parse hunk header: @@ -oldStart,oldCount +newStart,newCount @@
+        const hunkMatch = line.match(/^@@ -\d+(?:,\d+)? \+(\d+)(?:,\d+)? @@/);
+        if (hunkMatch) {
+            currentNewLine = parseInt(hunkMatch[1], 10);
+            continue;
+        }
+        if (currentNewLine === 0)
+            continue;
+        if (line.startsWith('+') && !line.startsWith('+++')) {
+            // Added line
+            changedLines.add(currentNewLine);
+            currentNewLine++;
+        }
+        else if (line.startsWith('-') && !line.startsWith('---')) {
+            // Removed line - doesn't increment new line counter
+        }
+        else if (!line.startsWith('\\')) {
+            // Context line (unchanged)
+            currentNewLine++;
+        }
+    }
+    return changedLines;
+}
+/**
+ * Check what kind of webpieces-disable comment is present for a method.
+ * Returns: 'full' | 'new-only' | 'none'
+ * - 'full': max-lines-new-and-modified (ultimate escape, skips both validators)
+ * - 'new-only': max-lines-new-methods (escaped 30-line check, still needs 80-line check)
+ * - 'none': no escape hatch
+ */
+function getDisableType(lines, lineNumber) {
+    const startCheck = Math.max(0, lineNumber - 5);
+    for (let i = lineNumber - 2; i >= startCheck; i--) {
+        const line = lines[i]?.trim() ?? '';
+        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {
+            break;
+        }
+        if (line.includes('webpieces-disable')) {
+            if (line.includes('max-lines-new-and-modified')) {
+                return 'full';
+            }
+            if (line.includes('max-lines-new-methods')) {
+                return 'new-only';
+            }
+        }
+    }
+    return 'none';
+}
+/**
+ * Parse a TypeScript file and find methods with their line counts
+ */
+// webpieces-disable max-lines-new-methods -- AST traversal requires inline visitor function
+function findMethodsInFile(filePath, workspaceRoot) {
+    const fullPath = path.join(workspaceRoot, filePath);
+    if (!fs.existsSync(fullPath))
+        return [];
+    const content = fs.readFileSync(fullPath, 'utf-8');
+    const fileLines = content.split('\n');
+    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);
+    const methods = [];
+    // webpieces-disable max-lines-new-methods -- AST visitor pattern requires handling multiple node types
+    function visit(node) {
+        let methodName;
+        let startLine;
+        let endLine;
+        if (ts.isMethodDeclaration(node) && node.name) {
+            methodName = node.name.getText(sourceFile);
+            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());
+            startLine = start.line + 1;
+            endLine = end.line + 1;
+        }
+        else if (ts.isFunctionDeclaration(node) && node.name) {
+            methodName = node.name.getText(sourceFile);
+            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());
+            startLine = start.line + 1;
+            endLine = end.line + 1;
+        }
+        else if (ts.isArrowFunction(node)) {
+            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
+                methodName = node.parent.name.getText(sourceFile);
+                const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+                const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());
+                startLine = start.line + 1;
+                endLine = end.line + 1;
+            }
+        }
+        if (methodName && startLine !== undefined && endLine !== undefined) {
+            methods.push({
+                name: methodName,
+                line: startLine,
+                endLine: endLine,
+                lines: endLine - startLine + 1,
+                disableType: getDisableType(fileLines, startLine),
+            });
+        }
+        ts.forEachChild(node, visit);
+    }
+    visit(sourceFile);
+    return methods;
+}
+/**
+ * Find methods that exceed the 80-line limit.
+ *
+ * This validator checks:
+ * 1. NEW methods that have `max-lines-new-methods` escape (they passed 30-line check, now need 80-line check)
+ * 2. MODIFIED methods (existing methods with changes)
+ *
+ * Skips:
+ * - NEW methods without any escape (let validate-new-methods handle them first)
+ * - Methods with `max-lines-new-and-modified` escape (ultimate escape hatch)
+ */
+// webpieces-disable max-lines-new-methods -- Core validation logic with multiple file operations
+function findViolations(workspaceRoot, changedFiles, base, maxLines) {
+    const violations = [];
+    for (const file of changedFiles) {
+        const diff = getFileDiff(workspaceRoot, file, base);
+        if (!diff)
+            continue;
+        // Find NEW methods from the diff
+        const newMethodNames = findNewMethodSignaturesInDiff(diff);
+        // Find which lines have changes
+        const changedLineNumbers = getChangedLineNumbers(diff);
+        if (changedLineNumbers.size === 0)
+            continue;
+        // Parse the current file to get all methods
+        const methods = findMethodsInFile(file, workspaceRoot);
+        for (const method of methods) {
+            const isNewMethod = newMethodNames.has(method.name);
+            // Skip methods with full escape (max-lines-new-and-modified)
+            if (method.disableType === 'full')
+                continue;
+            // Skip methods under the limit
+            if (method.lines <= maxLines)
+                continue;
+            if (isNewMethod) {
+                // For NEW methods:
+                // - If has 'new-only' escape → check (they escaped 30-line, now need 80-line check)
+                // - If has 'none' → skip (let validate-new-methods handle first)
+                if (method.disableType !== 'new-only')
+                    continue;
+                // New method with max-lines-new-methods escape - check against 80-line limit
+                violations.push({
+                    file,
+                    methodName: method.name,
+                    line: method.line,
+                    lines: method.lines,
+                });
+            }
+            else {
+                // For MODIFIED methods: check if any changed line falls within method's range
+                let hasChanges = false;
+                for (let line = method.line; line <= method.endLine; line++) {
+                    if (changedLineNumbers.has(line)) {
+                        hasChanges = true;
+                        break;
+                    }
+                }
+                if (hasChanges) {
+                    violations.push({
+                        file,
+                        methodName: method.name,
+                        line: method.line,
+                        lines: method.lines,
+                    });
+                }
+            }
+        }
+    }
+    return violations;
+}
+/**
+ * Auto-detect the base branch by finding the merge-base with origin/main.
+ */
+function detectBase(workspaceRoot) {
+    try {
+        const mergeBase = (0, child_process_1.execSync)('git merge-base HEAD origin/main', {
+            cwd: workspaceRoot,
+            encoding: 'utf-8',
+            stdio: ['pipe', 'pipe', 'pipe'],
+        }).trim();
+        if (mergeBase) {
+            return mergeBase;
+        }
+    }
+    catch {
+        try {
+            const mergeBase = (0, child_process_1.execSync)('git merge-base HEAD main', {
+                cwd: workspaceRoot,
+                encoding: 'utf-8',
+                stdio: ['pipe', 'pipe', 'pipe'],
+            }).trim();
+            if (mergeBase) {
+                return mergeBase;
+            }
+        }
+        catch {
+            // Ignore
+        }
+    }
+    return null;
+}
+async function runExecutor(options, context) {
+    const workspaceRoot = context.root;
+    const maxLines = options.max ?? 80;
+    let base = process.env['NX_BASE'];
+    if (!base) {
+        base = detectBase(workspaceRoot) ?? undefined;
+        if (!base) {
+            console.log('\n⏭️  Skipping modified method validation (could not detect base branch)');
+            console.log('   To run explicitly: nx affected --target=validate-modified-methods --base=origin/main');
+            console.log('');
+            return { success: true };
+        }
+        console.log('\n📏 Validating Modified Method Sizes (auto-detected base)\n');
+    }
+    else {
+        console.log('\n📏 Validating Modified Method Sizes\n');
+    }
+    console.log(`   Base: ${base}`);
+    console.log('   Comparing to: working tree (includes uncommitted changes)');
+    console.log(`   Max lines for modified methods: ${maxLines}`);
+    console.log('');
+    try {
+        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);
+        if (changedFiles.length === 0) {
+            console.log('✅ No TypeScript files changed');
+            return { success: true };
+        }
+        console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);
+        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);
+        if (violations.length === 0) {
+            console.log('✅ All modified methods are under ' + maxLines + ' lines');
+            return { success: true };
+        }
+        // Write instructions file
+        writeTmpInstructions(workspaceRoot);
+        // Report violations
+        console.error('');
+        console.error('❌ Modified methods exceed ' + maxLines + ' lines!');
+        console.error('');
+        console.error('📚 When you modify a method, you must bring it under ' + maxLines + ' lines.');
+        console.error('   This encourages gradual cleanup of legacy code.');
+        console.error('   You can refactor to stay under the limit 50% of the time.');
+        console.error('   If not feasible, use the escape hatch.');
+        console.error('');
+        console.error('⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️');
+        console.error('');
+        for (const v of violations) {
+            console.error(`  ❌ ${v.file}:${v.line}`);
+            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);
+        }
+        console.error('');
+        return { success: false };
+    }
+    catch (err) {
+        const error = err instanceof Error ? err : new Error(String(err));
+        console.error('❌ Modified method validation failed:', error.message);
+        return { success: false };
+    }
+}
+//# sourceMappingURL=executor.js.map

package/architecture/executors/validate-modified-methods/executor.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"executor.js","sourceRoot":"","sources":["../../../../../../../packages/tooling/dev-config/architecture/executors/validate-modified-methods/executor.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;GAiBG;;AA4dH,8BA2EC;;AApiBD,iDAAyC;AACzC,+CAAyB;AACzB,mDAA6B;AAC7B,uDAAiC;AAiBjC,MAAM,OAAO,GAAG,eAAe,CAAC;AAChC,MAAM,WAAW,GAAG,yBAAyB,CAAC;AAE9C,MAAM,sBAAsB,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAyH9B,CAAC;AAEF;;GAEG;AACH,SAAS,oBAAoB,CAAC,aAAqB;IAC/C,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,OAAO,CAAC,CAAC;IACjD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;IAE9C,EAAE,CAAC,SAAS,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IAC1C,EAAE,CAAC,aAAa,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;IAEjD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,aAAqB,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,wBAAwB,IAAI,oBAAoB,EAAE;YACtE,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;QACH,OAAO,MAAM;aACR,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;IAChF,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;;;GAIG;AACH,SAAS,WAAW,CAAC,aAAqB,EAAE,IAAY,EAAE,IAAY;IAClE,IAAI,CAAC;QACD,gEAAgE;QAChE,OAAO,IAAA,wBAAQ,EAAC,YAAY,IAAI,QAAQ,IAAI,GAAG,EAAE;YAC7C,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;SACpB,CAAC,CAAC;IACP,CAAC;IAAC,MAAM,CAAC;QACL,OAAO,EAAE,CAAC;IACd,CAAC;AACL,CAAC;AAED;;;GAGG;AACH,yFAAyF;AACzF,SAAS,6BAA6B,CAAC,WAAmB;IACtD,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEtC,sEAAsE;IACtE,MAAM,QAAQ,GAAG;QACb,qEAAqE;QACrE,wDAAwD;QACxD,4CAA4C;QAC5C,iEAAiE;QACjE,mDAAmD;QACnD,uEAAuE;QACvE,gFAAgF;QAChF,+BAA+B;KAClC,CAAC;IAEF,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAClD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC7B,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;gBAClC,IAAI,KAAK,EAAE,CAAC;oBACR,sDAAsD;oBACtD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC5B,IAAI,UAAU,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,aAAa,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;wBAC/F,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;oBAC/B,CAAC;oBACD,MAAM;gBACV,CAAC;YACL,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;GAEG;AACH,SAAS,qBAAqB,CAAC,WAAmB;IAC9C,MAAM,YAAY,GAAG,IAAI,GAAG,EAAU,CAAC;IACvC,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAEtC,IAAI,cAAc,GAAG,CAAC,CAAC;IAEvB,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACvB,iEAAiE;QACjE,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,uCAAuC,CAAC,CAAC;QACtE,IAAI,SAAS,EAAE,CAAC;YACZ,cAAc,GAAG,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC5C,SAAS;QACb,CAAC;QAED,IAAI,cAAc,KAAK,CAAC;YAAE,SAAS;QAEnC,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAClD,aAAa;YACb,YAAY,CAAC,GAAG,CAAC,cAAc,CAAC,CAAC;YACjC,cAAc,EAAE,CAAC;QACrB,CAAC;aAAM,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YACzD,oDAAoD;QACxD,CAAC;aAAM,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;YAChC,2BAA2B;YAC3B,cAAc,EAAE,CAAC;QACrB,CAAC;IACL,CAAC;IAED,OAAO,YAAY,CAAC;AACxB,CAAC;AAED;;;;;;GAMG;AACH,SAAS,cAAc,CAAC,KAAe,EAAE,UAAkB;IACvD,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,UAAU,GAAG,CAAC,CAAC,CAAC;IAC/C,KAAK,IAAI,CAAC,GAAG,UAAU,GAAG,CAAC,EAAE,CAAC,IAAI,UAAU,EAAE,CAAC,EAAE,EAAE,CAAC;QAChD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACpC,IAAI,IAAI,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAClF,MAAM;QACV,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,CAAC,mBAAmB,CAAC,EAAE,CAAC;YACrC,IAAI,IAAI,CAAC,QAAQ,CAAC,4BAA4B,CAAC,EAAE,CAAC;gBAC9C,OAAO,MAAM,CAAC;YAClB,CAAC;YACD,IAAI,IAAI,CAAC,QAAQ,CAAC,uBAAuB,CAAC,EAAE,CAAC;gBACzC,OAAO,UAAU,CAAC;YACtB,CAAC;QACL,CAAC;IACL,CAAC;IACD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED;;GAEG;AACH,4FAA4F;AAC5F,SAAS,iBAAiB,CACtB,QAAgB,EAChB,aAAqB;IAErB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC;IACpD,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAExC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CAAC,QAAQ,EAAE,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IAExF,MAAM,OAAO,GACT,EAAE,CAAC;IAEP,uGAAuG;IACvG,SAAS,KAAK,CAAC,IAAa;QACxB,IAAI,UAA8B,CAAC;QACnC,IAAI,SAA6B,CAAC;QAClC,IAAI,OAA2B,CAAC;QAEhC,IAAI,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5C,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;YACrD,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;YACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;QAC3B,CAAC;aAAM,IAAI,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC7E,UAAU,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;gBAClD,MAAM,KAAK,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;gBACxE,MAAM,GAAG,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;gBACpE,SAAS,GAAG,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC3B,OAAO,GAAG,GAAG,CAAC,IAAI,GAAG,CAAC,CAAC;YAC3B,CAAC;QACL,CAAC;QAED,IAAI,UAAU,IAAI,SAAS,KAAK,SAAS,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;YACjE,OAAO,CAAC,IAAI,CAAC;gBACT,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,SAAS;gBACf,OAAO,EAAE,OAAO;gBAChB,KAAK,EAAE,OAAO,GAAG,SAAS,GAAG,CAAC;gBAC9B,WAAW,EAAE,cAAc,CAAC,SAAS,EAAE,SAAS,CAAC;aACpD,CAAC,CAAC;QACP,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IACjC,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,OAAO,CAAC;AACnB,CAAC;AAED;;;;;;;;;;GAUG;AACH,iGAAiG;AACjG,SAAS,cAAc,CACnB,aAAqB,EACrB,YAAsB,EACtB,IAAY,EACZ,QAAgB;IAEhB,MAAM,UAAU,GAAsB,EAAE,CAAC;IAEzC,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAC9B,MAAM,IAAI,GAAG,WAAW,CAAC,aAAa,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;QACpD,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,iCAAiC;QACjC,MAAM,cAAc,GAAG,6BAA6B,CAAC,IAAI,CAAC,CAAC;QAE3D,gCAAgC;QAChC,MAAM,kBAAkB,GAAG,qBAAqB,CAAC,IAAI,CAAC,CAAC;QACvD,IAAI,kBAAkB,CAAC,IAAI,KAAK,CAAC;YAAE,SAAS;QAE5C,4CAA4C;QAC5C,MAAM,OAAO,GAAG,iBAAiB,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC;QAEvD,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC3B,MAAM,WAAW,GAAG,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;YAEpD,6DAA6D;YAC7D,IAAI,MAAM,CAAC,WAAW,KAAK,MAAM;gBAAE,SAAS;YAE5C,+BAA+B;YAC/B,IAAI,MAAM,CAAC,KAAK,IAAI,QAAQ;gBAAE,SAAS;YAEvC,IAAI,WAAW,EAAE,CAAC;gBACd,mBAAmB;gBACnB,oFAAoF;gBACpF,iEAAiE;gBACjE,IAAI,MAAM,CAAC,WAAW,KAAK,UAAU;oBAAE,SAAS;gBAEhD,6EAA6E;gBAC7E,UAAU,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;oBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;iBACtB,CAAC,CAAC;YACP,CAAC;iBAAM,CAAC;gBACJ,8EAA8E;gBAC9E,IAAI,UAAU,GAAG,KAAK,CAAC;gBACvB,KAAK,IAAI,IAAI,GAAG,MAAM,CAAC,IAAI,EAAE,IAAI,IAAI,MAAM,CAAC,OAAO,EAAE,IAAI,EAAE,EAAE,CAAC;oBAC1D,IAAI,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;wBAC/B,UAAU,GAAG,IAAI,CAAC;wBAClB,MAAM;oBACV,CAAC;gBACL,CAAC;gBAED,IAAI,UAAU,EAAE,CAAC;oBACb,UAAU,CAAC,IAAI,CAAC;wBACZ,IAAI;wBACJ,UAAU,EAAE,MAAM,CAAC,IAAI;wBACvB,IAAI,EAAE,MAAM,CAAC,IAAI;wBACjB,KAAK,EAAE,MAAM,CAAC,KAAK;qBACtB,CAAC,CAAC;gBACP,CAAC;YACL,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACtB,CAAC;AAED;;GAEG;AACH,SAAS,UAAU,CAAC,aAAqB;IACrC,IAAI,CAAC;QACD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,iCAAiC,EAAE;YAC1D,GAAG,EAAE,aAAa;YAClB,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QAEV,IAAI,SAAS,EAAE,CAAC;YACZ,OAAO,SAAS,CAAC;QACrB,CAAC;IACL,CAAC;IAAC,MAAM,CAAC;QACL,IAAI,CAAC;YACD,MAAM,SAAS,GAAG,IAAA,wBAAQ,EAAC,0BAA0B,EAAE;gBACnD,GAAG,EAAE,aAAa;gBAClB,QAAQ,EAAE,OAAO;gBACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC;aAClC,CAAC,CAAC,IAAI,EAAE,CAAC;YAEV,IAAI,SAAS,EAAE,CAAC;gBACZ,OAAO,SAAS,CAAC;YACrB,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACL,SAAS;QACb,CAAC;IACL,CAAC;IACD,OAAO,IAAI,CAAC;AAChB,CAAC;AAEc,KAAK,UAAU,WAAW,CACrC,OAAuC,EACvC,OAAwB;IAExB,MAAM,aAAa,GAAG,OAAO,CAAC,IAAI,CAAC;IACnC,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,IAAI,EAAE,CAAC;IAEnC,IAAI,IAAI,GAAG,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IAElC,IAAI,CAAC,IAAI,EAAE,CAAC;QACR,IAAI,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,SAAS,CAAC;QAE9C,IAAI,CAAC,IAAI,EAAE,CAAC;YACR,OAAO,CAAC,GAAG,CAAC,0EAA0E,CAAC,CAAC;YACxF,OAAO,CAAC,GAAG,CAAC,yFAAyF,CAAC,CAAC;YACvG,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAChB,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;IAChF,CAAC;SAAM,CAAC;QACJ,OAAO,CAAC,GAAG,CAAC,yCAAyC,CAAC,CAAC;IAC3D,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,YAAY,IAAI,EAAE,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,8DAA8D,CAAC,CAAC;IAC5E,OAAO,CAAC,GAAG,CAAC,sCAAsC,QAAQ,EAAE,CAAC,CAAC;IAC9D,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAEhB,IAAI,CAAC;QACD,MAAM,YAAY,GAAG,yBAAyB,CAAC,aAAa,EAAE,IAAI,CAAC,CAAC;QAEpE,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,+BAA+B,CAAC,CAAC;YAC7C,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,OAAO,CAAC,GAAG,CAAC,eAAe,YAAY,CAAC,MAAM,qBAAqB,CAAC,CAAC;QAErE,MAAM,UAAU,GAAG,cAAc,CAAC,aAAa,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE/E,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1B,OAAO,CAAC,GAAG,CAAC,mCAAmC,GAAG,QAAQ,GAAG,QAAQ,CAAC,CAAC;YACvE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;QAC7B,CAAC;QAED,0BAA0B;QAC1B,oBAAoB,CAAC,aAAa,CAAC,CAAC;QAEpC,oBAAoB;QACpB,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,4BAA4B,GAAG,QAAQ,GAAG,SAAS,CAAC,CAAC;QACnE,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CAAC,uDAAuD,GAAG,QAAQ,GAAG,SAAS,CAAC,CAAC;QAC9F,OAAO,CAAC,KAAK,CAAC,oDAAoD,CAAC,CAAC;QACpE,OAAO,CAAC,KAAK,CAAC,8DAA8D,CAAC,CAAC;QAC9E,OAAO,CAAC,KAAK,CAAC,2CAA2C,CAAC,CAAC;QAC3D,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClB,OAAO,CAAC,KAAK,CACT,2GAA2G,CAC9G,CAAC;QACF,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAElB,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YACzB,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;YACzC,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,KAAK,gBAAgB,QAAQ,GAAG,CAAC,CAAC;QACvF,CAAC;QACD,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAElB,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;QAClE,OAAO,CAAC,KAAK,CAAC,sCAAsC,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;QACrE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAC9B,CAAC;AACL,CAAC","sourcesContent":["/**\n * Validate Modified Methods Executor\n *\n * Validates that modified methods don't exceed a maximum line count (default 80).\n * This encourages gradual cleanup of legacy long methods - when you touch a method,\n * you must bring it under the limit.\n *\n * Combined with validate-new-methods (30 line limit), this creates a gradual\n * transition to cleaner code:\n * - New methods: strict 30 line limit\n * - Modified methods: lenient 80 line limit (cleanup when touched)\n * - Untouched methods: no limit (legacy allowed)\n *\n * Usage:\n * nx affected --target=validate-modified-methods --base=origin/main\n *\n * Escape hatch: Add webpieces-disable max-lines-new-and-modified comment with justification\n */\n\nimport type { ExecutorContext } from '@nx/devkit';\nimport { execSync } from 'child_process';\nimport * as fs from 'fs';\nimport * as path from 'path';\nimport * as ts from 'typescript';\n\nexport interface ValidateModifiedMethodsOptions {\n    max?: number;\n}\n\nexport interface ExecutorResult {\n    success: boolean;\n}\n\ninterface MethodViolation {\n    file: string;\n    methodName: string;\n    line: number;\n    lines: number;\n}\n\nconst TMP_DIR = 'tmp/webpieces';\nconst TMP_MD_FILE = 'webpieces.methodsize.md';\n\nconst METHODSIZE_DOC_CONTENT = `# Instructions: Method Too Long\n\n## Requirement\n\n**~50% of the time**, you can stay under the \\`newMethodsMaxLines\\` limit from nx.json\nby extracting logical units into well-named methods.\n\n**~99% of the time**, you can stay under the \\`modifiedAndNewMethodsMaxLines\\` limit from nx.json.\nNearly all software can be written with methods under this size.\nTake the extra time to refactor - it's worth it for long-term maintainability.\n\n## The \"Table of Contents\" Principle\n\nGood code reads like a book's table of contents:\n- Chapter titles (method names) tell you WHAT happens\n- Reading chapter titles gives you the full story\n- You can dive into chapters (implementations) for details\n\n## Why Limit Method Sizes?\n\nMethods under reasonable limits are:\n- Easy to review in a single screen\n- Simple to understand without scrolling\n- Quick for AI to analyze and suggest improvements\n- More testable in isolation\n- Self-documenting through well-named extracted methods\n\n## Gradual Cleanup Strategy\n\nThis codebase uses a gradual cleanup approach:\n- **New methods**: Must be under \\`newMethodsMaxLines\\` from nx.json\n- **Modified methods**: Must be under \\`modifiedAndNewMethodsMaxLines\\` from nx.json\n- **Untouched methods**: No limit (legacy code is allowed until touched)\n\n## How to Refactor\n\nInstead of:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    // 100 lines of validation, transformation, saving, notifications...\n}\n\\`\\`\\`\n\nWrite:\n\\`\\`\\`typescript\nasync processOrder(order: Order): Promise<Result> {\n    const validated = this.validateOrder(order);\n    const transformed = this.applyBusinessRules(validated);\n    const saved = await this.saveToDatabase(transformed);\n    await this.notifyStakeholders(saved);\n    return this.buildResult(saved);\n}\n\\`\\`\\`\n\nNow the main method is a \"table of contents\" - each line tells part of the story!\n\n## Patterns for Extraction\n\n### Pattern 1: Extract Loop Bodies\n\\`\\`\\`typescript\n// BEFORE\nfor (const item of items) {\n    // 20 lines of processing\n}\n\n// AFTER\nfor (const item of items) {\n    this.processItem(item);\n}\n\\`\\`\\`\n\n### Pattern 2: Extract Conditional Blocks\n\\`\\`\\`typescript\n// BEFORE\nif (isAdmin(user)) {\n    // 15 lines of admin logic\n}\n\n// AFTER\nif (isAdmin(user)) {\n    this.handleAdminUser(user);\n}\n\\`\\`\\`\n\n### Pattern 3: Extract Data Transformations\n\\`\\`\\`typescript\n// BEFORE\nconst result = {\n    // 10+ lines of object construction\n};\n\n// AFTER\nconst result = this.buildResultObject(data);\n\\`\\`\\`\n\n## If Refactoring Is Not Feasible\n\nSometimes methods genuinely need to be longer (complex algorithms, state machines, etc.).\n\n**Escape hatch**: Add a webpieces-disable comment with justification:\n\n\\`\\`\\`typescript\n// webpieces-disable max-lines-new-and-modified -- Complex state machine, splitting reduces clarity\nasync complexStateMachine(): Promise<void> {\n    // ... longer method with justification\n}\n\\`\\`\\`\n\n## AI Agent Action Steps\n\n1. **READ** the method to understand its logical sections\n2. **IDENTIFY** logical units that can be extracted\n3. **EXTRACT** into well-named private methods\n4. **VERIFY** the main method now reads like a table of contents\n5. **IF NOT FEASIBLE**: Add webpieces-disable max-lines-new-and-modified comment with clear justification\n\n## Remember\n\n- Every method you write today will be read many times tomorrow\n- The best code explains itself through structure\n- When in doubt, extract and name it\n`;\n\n/**\n * Write the instructions documentation to tmp directory\n */\nfunction writeTmpInstructions(workspaceRoot: string): string {\n    const tmpDir = path.join(workspaceRoot, TMP_DIR);\n    const mdPath = path.join(tmpDir, TMP_MD_FILE);\n\n    fs.mkdirSync(tmpDir, { recursive: true });\n    fs.writeFileSync(mdPath, METHODSIZE_DOC_CONTENT);\n\n    return mdPath;\n}\n\n/**\n * Get changed TypeScript files between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getChangedTypeScriptFiles(workspaceRoot: string, base: string): string[] {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        const output = execSync(`git diff --name-only ${base} -- '*.ts' '*.tsx'`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n        return output\n            .trim()\n            .split('\\n')\n            .filter((f) => f && !f.includes('.spec.ts') && !f.includes('.test.ts'));\n    } catch {\n        return [];\n    }\n}\n\n/**\n * Get the diff content for a specific file between base and working tree.\n * Uses `git diff base` (no three-dots) to match what `nx affected` does -\n * this includes both committed and uncommitted changes in one diff.\n */\nfunction getFileDiff(workspaceRoot: string, file: string, base: string): string {\n    try {\n        // Use two-dot diff (base to working tree) - same as nx affected\n        return execSync(`git diff ${base} -- \"${file}\"`, {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n        });\n    } catch {\n        return '';\n    }\n}\n\n/**\n * Parse diff to find NEW method signatures.\n * Must handle: export function, async function, const/let arrow functions, class methods\n */\n// webpieces-disable max-lines-new-methods -- Regex patterns require inline documentation\nfunction findNewMethodSignaturesInDiff(diffContent: string): Set<string> {\n    const newMethods = new Set<string>();\n    const lines = diffContent.split('\\n');\n\n    // Patterns to match method definitions (same as validate-new-methods)\n    const patterns = [\n        // [export] [async] function methodName( - most explicit, check first\n        /^\\+\\s*(?:export\\s+)?(?:async\\s+)?function\\s+(\\w+)\\s*\\(/,\n        // [export] const/let methodName = [async] (\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s*)?\\(/,\n        // [export] const/let methodName = [async] function\n        /^\\+\\s*(?:export\\s+)?(?:const|let)\\s+(\\w+)\\s*=\\s*(?:async\\s+)?function/,\n        // class method: [async] methodName( - but NOT constructor, if, for, while, etc.\n        /^\\+\\s*(?:async\\s+)?(\\w+)\\s*\\(/,\n    ];\n\n    for (const line of lines) {\n        if (line.startsWith('+') && !line.startsWith('+++')) {\n            for (const pattern of patterns) {\n                const match = line.match(pattern);\n                if (match) {\n                    // Extract method name - now always in capture group 1\n                    const methodName = match[1];\n                    if (methodName && !['if', 'for', 'while', 'switch', 'catch', 'constructor'].includes(methodName)) {\n                        newMethods.add(methodName);\n                    }\n                    break;\n                }\n            }\n        }\n    }\n\n    return newMethods;\n}\n\n/**\n * Parse diff to find line numbers that have changes in the new file\n */\nfunction getChangedLineNumbers(diffContent: string): Set<number> {\n    const changedLines = new Set<number>();\n    const lines = diffContent.split('\\n');\n\n    let currentNewLine = 0;\n\n    for (const line of lines) {\n        // Parse hunk header: @@ -oldStart,oldCount +newStart,newCount @@\n        const hunkMatch = line.match(/^@@ -\\d+(?:,\\d+)? \\+(\\d+)(?:,\\d+)? @@/);\n        if (hunkMatch) {\n            currentNewLine = parseInt(hunkMatch[1], 10);\n            continue;\n        }\n\n        if (currentNewLine === 0) continue;\n\n        if (line.startsWith('+') && !line.startsWith('+++')) {\n            // Added line\n            changedLines.add(currentNewLine);\n            currentNewLine++;\n        } else if (line.startsWith('-') && !line.startsWith('---')) {\n            // Removed line - doesn't increment new line counter\n        } else if (!line.startsWith('\\\\')) {\n            // Context line (unchanged)\n            currentNewLine++;\n        }\n    }\n\n    return changedLines;\n}\n\n/**\n * Check what kind of webpieces-disable comment is present for a method.\n * Returns: 'full' | 'new-only' | 'none'\n * - 'full': max-lines-new-and-modified (ultimate escape, skips both validators)\n * - 'new-only': max-lines-new-methods (escaped 30-line check, still needs 80-line check)\n * - 'none': no escape hatch\n */\nfunction getDisableType(lines: string[], lineNumber: number): 'full' | 'new-only' | 'none' {\n    const startCheck = Math.max(0, lineNumber - 5);\n    for (let i = lineNumber - 2; i >= startCheck; i--) {\n        const line = lines[i]?.trim() ?? '';\n        if (line.startsWith('function ') || line.startsWith('class ') || line.endsWith('}')) {\n            break;\n        }\n        if (line.includes('webpieces-disable')) {\n            if (line.includes('max-lines-new-and-modified')) {\n                return 'full';\n            }\n            if (line.includes('max-lines-new-methods')) {\n                return 'new-only';\n            }\n        }\n    }\n    return 'none';\n}\n\n/**\n * Parse a TypeScript file and find methods with their line counts\n */\n// webpieces-disable max-lines-new-methods -- AST traversal requires inline visitor function\nfunction findMethodsInFile(\n    filePath: string,\n    workspaceRoot: string\n): Array<{ name: string; line: number; endLine: number; lines: number; disableType: 'full' | 'new-only' | 'none' }> {\n    const fullPath = path.join(workspaceRoot, filePath);\n    if (!fs.existsSync(fullPath)) return [];\n\n    const content = fs.readFileSync(fullPath, 'utf-8');\n    const fileLines = content.split('\\n');\n    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true);\n\n    const methods: Array<{ name: string; line: number; endLine: number; lines: number; disableType: 'full' | 'new-only' | 'none' }> =\n        [];\n\n    // webpieces-disable max-lines-new-methods -- AST visitor pattern requires handling multiple node types\n    function visit(node: ts.Node): void {\n        let methodName: string | undefined;\n        let startLine: number | undefined;\n        let endLine: number | undefined;\n\n        if (ts.isMethodDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isFunctionDeclaration(node) && node.name) {\n            methodName = node.name.getText(sourceFile);\n            const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n            const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n            startLine = start.line + 1;\n            endLine = end.line + 1;\n        } else if (ts.isArrowFunction(node)) {\n            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {\n                methodName = node.parent.name.getText(sourceFile);\n                const start = sourceFile.getLineAndCharacterOfPosition(node.getStart());\n                const end = sourceFile.getLineAndCharacterOfPosition(node.getEnd());\n                startLine = start.line + 1;\n                endLine = end.line + 1;\n            }\n        }\n\n        if (methodName && startLine !== undefined && endLine !== undefined) {\n            methods.push({\n                name: methodName,\n                line: startLine,\n                endLine: endLine,\n                lines: endLine - startLine + 1,\n                disableType: getDisableType(fileLines, startLine),\n            });\n        }\n\n        ts.forEachChild(node, visit);\n    }\n\n    visit(sourceFile);\n    return methods;\n}\n\n/**\n * Find methods that exceed the 80-line limit.\n *\n * This validator checks:\n * 1. NEW methods that have `max-lines-new-methods` escape (they passed 30-line check, now need 80-line check)\n * 2. MODIFIED methods (existing methods with changes)\n *\n * Skips:\n * - NEW methods without any escape (let validate-new-methods handle them first)\n * - Methods with `max-lines-new-and-modified` escape (ultimate escape hatch)\n */\n// webpieces-disable max-lines-new-methods -- Core validation logic with multiple file operations\nfunction findViolations(\n    workspaceRoot: string,\n    changedFiles: string[],\n    base: string,\n    maxLines: number\n): MethodViolation[] {\n    const violations: MethodViolation[] = [];\n\n    for (const file of changedFiles) {\n        const diff = getFileDiff(workspaceRoot, file, base);\n        if (!diff) continue;\n\n        // Find NEW methods from the diff\n        const newMethodNames = findNewMethodSignaturesInDiff(diff);\n\n        // Find which lines have changes\n        const changedLineNumbers = getChangedLineNumbers(diff);\n        if (changedLineNumbers.size === 0) continue;\n\n        // Parse the current file to get all methods\n        const methods = findMethodsInFile(file, workspaceRoot);\n\n        for (const method of methods) {\n            const isNewMethod = newMethodNames.has(method.name);\n\n            // Skip methods with full escape (max-lines-new-and-modified)\n            if (method.disableType === 'full') continue;\n\n            // Skip methods under the limit\n            if (method.lines <= maxLines) continue;\n\n            if (isNewMethod) {\n                // For NEW methods:\n                // - If has 'new-only' escape → check (they escaped 30-line, now need 80-line check)\n                // - If has 'none' → skip (let validate-new-methods handle first)\n                if (method.disableType !== 'new-only') continue;\n\n                // New method with max-lines-new-methods escape - check against 80-line limit\n                violations.push({\n                    file,\n                    methodName: method.name,\n                    line: method.line,\n                    lines: method.lines,\n                });\n            } else {\n                // For MODIFIED methods: check if any changed line falls within method's range\n                let hasChanges = false;\n                for (let line = method.line; line <= method.endLine; line++) {\n                    if (changedLineNumbers.has(line)) {\n                        hasChanges = true;\n                        break;\n                    }\n                }\n\n                if (hasChanges) {\n                    violations.push({\n                        file,\n                        methodName: method.name,\n                        line: method.line,\n                        lines: method.lines,\n                    });\n                }\n            }\n        }\n    }\n\n    return violations;\n}\n\n/**\n * Auto-detect the base branch by finding the merge-base with origin/main.\n */\nfunction detectBase(workspaceRoot: string): string | null {\n    try {\n        const mergeBase = execSync('git merge-base HEAD origin/main', {\n            cwd: workspaceRoot,\n            encoding: 'utf-8',\n            stdio: ['pipe', 'pipe', 'pipe'],\n        }).trim();\n\n        if (mergeBase) {\n            return mergeBase;\n        }\n    } catch {\n        try {\n            const mergeBase = execSync('git merge-base HEAD main', {\n                cwd: workspaceRoot,\n                encoding: 'utf-8',\n                stdio: ['pipe', 'pipe', 'pipe'],\n            }).trim();\n\n            if (mergeBase) {\n                return mergeBase;\n            }\n        } catch {\n            // Ignore\n        }\n    }\n    return null;\n}\n\nexport default async function runExecutor(\n    options: ValidateModifiedMethodsOptions,\n    context: ExecutorContext\n): Promise<ExecutorResult> {\n    const workspaceRoot = context.root;\n    const maxLines = options.max ?? 80;\n\n    let base = process.env['NX_BASE'];\n\n    if (!base) {\n        base = detectBase(workspaceRoot) ?? undefined;\n\n        if (!base) {\n            console.log('\\n⏭️  Skipping modified method validation (could not detect base branch)');\n            console.log('   To run explicitly: nx affected --target=validate-modified-methods --base=origin/main');\n            console.log('');\n            return { success: true };\n        }\n\n        console.log('\\n📏 Validating Modified Method Sizes (auto-detected base)\\n');\n    } else {\n        console.log('\\n📏 Validating Modified Method Sizes\\n');\n    }\n\n    console.log(`   Base: ${base}`);\n    console.log('   Comparing to: working tree (includes uncommitted changes)');\n    console.log(`   Max lines for modified methods: ${maxLines}`);\n    console.log('');\n\n    try {\n        const changedFiles = getChangedTypeScriptFiles(workspaceRoot, base);\n\n        if (changedFiles.length === 0) {\n            console.log('✅ No TypeScript files changed');\n            return { success: true };\n        }\n\n        console.log(`📂 Checking ${changedFiles.length} changed file(s)...`);\n\n        const violations = findViolations(workspaceRoot, changedFiles, base, maxLines);\n\n        if (violations.length === 0) {\n            console.log('✅ All modified methods are under ' + maxLines + ' lines');\n            return { success: true };\n        }\n\n        // Write instructions file\n        writeTmpInstructions(workspaceRoot);\n\n        // Report violations\n        console.error('');\n        console.error('❌ Modified methods exceed ' + maxLines + ' lines!');\n        console.error('');\n        console.error('📚 When you modify a method, you must bring it under ' + maxLines + ' lines.');\n        console.error('   This encourages gradual cleanup of legacy code.');\n        console.error('   You can refactor to stay under the limit 50% of the time.');\n        console.error('   If not feasible, use the escape hatch.');\n        console.error('');\n        console.error(\n            '⚠️  *** READ tmp/webpieces/webpieces.methodsize.md for detailed guidance on how to fix this easily *** ⚠️'\n        );\n        console.error('');\n\n        for (const v of violations) {\n            console.error(`  ❌ ${v.file}:${v.line}`);\n            console.error(`     Method: ${v.methodName} (${v.lines} lines, max: ${maxLines})`);\n        }\n        console.error('');\n\n        return { success: false };\n    } catch (err: unknown) {\n        const error = err instanceof Error ? err : new Error(String(err));\n        console.error('❌ Modified method validation failed:', error.message);\n        return { success: false };\n    }\n}\n"]}