@webex/plugin-meetings 3.0.0-bnr.4 → 3.0.0-stream-classes.1

package/test/unit/spec/reachability/index.ts

@@ -2,6 +2,7 @@ import {assert} from '@webex/test-helper-chai';
 import MockWebex from '@webex/test-helper-mock-webex';
 import sinon from 'sinon';
 import Reachability, {ICECandidateResult} from '@webex/plugin-meetings/src/reachability/';
+import { IP_VERSION } from '@webex/plugin-meetings/src/constants';
 
 describe('isAnyClusterReachable', () => {
   let webex;
@@ -98,6 +99,55 @@ describe('gatherReachability', () => {
     assert.equal(JSON.stringify(getClustersResult.joinCookie), storedResultForJoinCookie);
   });
 
+  it('does reachability only on udp', async () => {
+    const reachability = new Reachability(webex);
+
+    const getClustersResult = {
+      clusters: {clusterId: {
+        tcp: [
+          'stun:170.72.164.1:5004',
+          'stun:170.72.165.2:5004'
+        ],
+        udp: [
+            'stun:170.72.164.3:5004',
+            'stun:170.72.164.3:9000',
+        ],
+        xtls: [
+            'stun:external-media101.public.wjfkm-a-4.prod.infra.webex.com:443',
+            'stun:external-media94.public.wjfkm-a-8.prod.infra.webex.com:443'
+        ]
+      }},
+      joinCookie: {id: 'id'},
+    };
+
+    sinon.stub(reachability.reachabilityRequest, 'getClusters').returns(getClustersResult);
+
+    const createPeerConnectionStub = sinon.stub(reachability, 'createPeerConnection');
+
+    await reachability.gatherReachability();
+
+    // check that a peer connection was created with only the udp urls 
+    assert.calledOnceWithExactly(createPeerConnectionStub, {
+      key: 'clusterId',
+      config: {
+        iceServers: [
+          {
+            username: '',
+            credential: '',
+            urls: ['stun:170.72.164.3:5004'],
+          },
+          {
+            username: '',
+            credential: '',
+            urls: ['stun:170.72.164.3:9000'],
+          }
+        ],
+        iceCandidatePoolSize: '0',
+        iceTransportPolicy: 'all'
+      }
+    })
+  });
+
   describe('clientMediaIPs', () => {
     let testingClass: TestReachability;
 
@@ -135,9 +185,10 @@ describe('gatherReachability', () => {
       assert.deepEqual(res, {
         id1: {
           tcp: {
-            clientMediaIPs: ['1.1.1.1'],
-            latencyInMilliseconds: '12312',
-            reachable: 'true',
+            untested: 'true',
+          },
+          xtls: {
+            untested: 'true',
           },
           udp: {
             clientMediaIPs: ['1.1.1.1'],
@@ -146,9 +197,11 @@ describe('gatherReachability', () => {
           },
         },
         id2: {
+          xtls: {
+            untested: 'true',
+          },
           tcp: {
-            latencyInMilliseconds: '14123',
-            reachable: 'true',
+            untested: 'true',
           },
           udp: {
             latencyInMilliseconds: '14123',
@@ -198,4 +251,12 @@ describe('gatherReachability', () => {
       });
     });
   });
+
+  describe('getIpVersion', () => {
+    it('returns unknown', () => {
+      const reachability = new Reachability(webex);
+
+      assert.equal(reachability.getIpVersion(), IP_VERSION.unknown);
+    })
+  })
 });

package/test/unit/spec/reachability/request.js

@@ -3,6 +3,7 @@ import {assert} from '@webex/test-helper-chai';
 import MockWebex from '@webex/test-helper-mock-webex';
 import Meetings from '@webex/plugin-meetings';
 import ReachabilityRequest from '@webex/plugin-meetings/src/reachability/request';
+import {IP_VERSION} from '@webex/plugin-meetings/src/constants';
 
 
 describe('plugin-meetings/reachability', () => {
@@ -47,7 +48,7 @@ describe('plugin-meetings/reachability', () => {
         }
       }));
 
-      const res = await reachabilityRequest.getClusters();
+      const res = await reachabilityRequest.getClusters(IP_VERSION.only_ipv4);
 
       const requestParams = webex.request.getCall(0).args[0];
 
@@ -58,6 +59,7 @@ describe('plugin-meetings/reachability', () => {
 
       assert.deepEqual(requestParams.qs, {
         JCSupport: 1,
+        ipver: 4,
       });
       assert.deepEqual(res.clusters.clusterId, {udp: "testUDP", isVideoMesh: true})
       assert.deepEqual(res.joinCookie, {anycastEntryPoint: "aws-eu-west-1"})

package/test/unit/spec/reconnection-manager/index.js

@@ -3,7 +3,6 @@ import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';
 import ReconnectionManager from '@webex/plugin-meetings/src/reconnection-manager';
-import Metrics from '@webex/plugin-meetings/src/metrics';
 
 const {assert} = chai;
 
@@ -16,7 +15,6 @@ describe('plugin-meetings', () => {
     let fakeMeeting;
 
     beforeEach(() => {
-      Metrics.postEvent = sinon.stub();
       fakeMediaConnection = {
         initiateOffer: sinon.stub().resolves({}),
         reconnect: sinon.stub().resolves({}),
@@ -64,6 +62,11 @@ describe('plugin-meetings', () => {
             getMeetingByType: sinon.stub().returns(true),
             syncMeetings: sinon.stub().resolves({}),
           },
+          internal: {
+            newMetrics: {
+              submitClientEvent: sinon.stub()
+            }
+          }
         },
       };
     });
@@ -82,6 +85,23 @@ describe('plugin-meetings', () => {
           credential: 'fake_turn_password',
         },
       ]);
+
+      assert.calledWith(fakeMeeting.webex.internal.newMetrics.submitClientEvent, {
+        name: 'client.media.reconnecting',
+        options: {
+          meetingId: rm.meeting.id,
+        },
+      });
+
+      assert.calledWith(fakeMeeting.webex.internal.newMetrics.submitClientEvent, {
+        name: 'client.media.recovered',
+        payload: {
+          recoveredBy: 'new',
+        },
+        options: {
+          meetingId: rm.meeting.id,
+        },
+      });
     });
 
     it('does not clear previous requests and re-request media for non-multistream meetings', async () => {
@@ -107,6 +127,35 @@ describe('plugin-meetings', () => {
       assert.calledOnce(fakeMeeting.mediaRequestManagers.audio.commit);
       assert.calledOnce(fakeMeeting.mediaRequestManagers.video.commit);
     });
+
+
+    it('sends the correct client event when reconnection fails', async () => {
+      sinon.stub(ReconnectionManager.prototype, 'executeReconnection').rejects();
+      fakeMeeting.isMultistream = true;
+      const rm = new ReconnectionManager(fakeMeeting);
+
+      try {
+        await rm.reconnect();
+      } catch (err) {
+        assert.calledWith(fakeMeeting.webex.internal.newMetrics.submitClientEvent, {
+          name: 'client.call.aborted',
+          payload: {
+            errors: [
+              {
+                category: 'expected',
+                errorCode: 2008,
+                fatal: true,
+                name: 'media-engine',
+                shownToUser: false,
+              },
+            ],
+          },
+          options: {
+            meetingId: rm.meeting.id,
+          },
+        });
+      }
+    });
   });
 
   /**
@@ -114,7 +163,7 @@ describe('plugin-meetings', () => {
    * level causes testing errors in CI based around related files. Skipping this here until a solution
    * to this problem is generated.
    */
-  describe.skip('ReconnectionManager', () => {
+  describe('ReconnectionManager', () => {
     let reconnectionManager;
 
     beforeEach(() => {
@@ -207,10 +256,11 @@ describe('plugin-meetings', () => {
           assert.isTrue(reconnectionManager.iceState.disconnected);
         });
 
-        it('should return a promise that rejects after a duration', () => {
+        it('should return a promise that rejects after a duration', (done) => {
           reconnectionManager.iceState.timeoutDuration = 100;
 
-          return assert.isRejected(reconnectionManager.waitForIceReconnect());
+          assert.isRejected(reconnectionManager.waitForIceReconnect());
+          done();
         });
 
         it('should resolve return a resolved promise when triggered', () => {