@webex/plugin-meetings 3.0.0-bnr.4 → 3.0.0-stream-classes.1

package/test/unit/spec/members/index.js

@@ -14,6 +14,7 @@ import ParameterError from '@webex/plugin-meetings/src/common/errors/parameter';
 import Meetings from '@webex/plugin-meetings';
 import Members from '@webex/plugin-meetings/src/members';
 import MembersUtil from '@webex/plugin-meetings/src/members/util';
+import * as MembersRequestImport from '@webex/plugin-meetings/src/members/request';
 import Trigger from '@webex/plugin-meetings/src/common/events/trigger-proxy';
 import {EVENT_TRIGGERS} from '@webex/plugin-meetings/src/constants';
 
@@ -81,6 +82,8 @@ describe('plugin-meetings', () => {
   describe('members', () => {
     const sandbox = sinon.createSandbox();
     let createMembers;
+    let meeting;
+    let membersRequestSpy;
 
     beforeEach(() => {
       webex = new MockWebex({
@@ -106,13 +109,31 @@ describe('plugin-meetings', () => {
 
       url1 = `https://example.com/${uuid.v4()}`;
 
-      createMembers = (options) => new Members({locusUrl: options.url}, {parent: webex});
+      membersRequestSpy = sinon.spy(MembersRequestImport, 'default');
+
+      meeting = {
+        request: sinon.mock().returns(Promise.resolve()),
+        locusInfo: {
+          sequence: {}
+        }
+      }
+
+      createMembers = (options) => new Members({locusUrl: options.url, meeting}, {parent: webex});
     });
 
     afterEach(() => {
+      membersRequestSpy.restore();
       sandbox.restore();
     });
 
+    describe('constructor', () => {
+      it('passes the meeting to the MembersRequest', () => {
+        createMembers({});
+
+        assert.calledOnceWithExactly(membersRequestSpy, {meeting}, {parent: webex});
+      });
+    });
+
     describe('#addMembers', () => {
       it('should invoke isInvalidInvitee and generateAddMemberOptions from MembersUtil when addMember is called with valid params', async () => {
         sandbox.spy(MembersUtil, 'isInvalidInvitee');
@@ -211,7 +232,7 @@ describe('plugin-meetings', () => {
       it('should send clear event if clear members', () => {
         const members = createMembers({url: url1});
         members.membersCollection.setAll(fakeMembersCollection);
-        Trigger.trigger = sinon.stub();
+        sinon.stub(Trigger, 'trigger');
         members.clearMembers();
         assert.deepEqual(members.membersCollection.members, {});
         assert.calledWith(
@@ -229,7 +250,6 @@ describe('plugin-meetings', () => {
     describe('#locusParticipantsUpdate', () => {
       it('should send member update event with session info', () => {
         const members = createMembers({url: url1});
-        Trigger.trigger = sinon.stub();
         const fakePayload = {
           participants: {
             forEach: sinon.stub(),

package/test/unit/spec/members/request.js

@@ -8,6 +8,7 @@ import Meetings from '@webex/plugin-meetings';
 import MembersRequest from '@webex/plugin-meetings/src/members/request';
 import membersUtil from '@webex/plugin-meetings/src/members/util';
 import ParameterError from '@webex/plugin-meetings/src/common/errors/parameter';
+import { merge } from 'lodash';
 
 const {assert} = chai;
 
@@ -18,6 +19,10 @@ describe('plugin-meetings', () => {
   let membersRequest;
   let url1;
   let sandbox;
+  const sequence = {some: 'sequenceData'};
+  const requestResponse = {some: 'data'};
+  let locusDeltaRequestSpy;
+  const correlationId = '12345';
 
   beforeEach(() => {
     const webex = new MockWebex({
@@ -28,21 +33,43 @@ describe('plugin-meetings', () => {
 
     sandbox = sinon.createSandbox();
 
+    sinon.stub(uuid, 'v4').returns(correlationId);
+
     url1 = `https://example.com/${uuid.v4()}`;
 
+    const request = sinon.mock().returns(Promise.resolve(requestResponse));
+
     membersRequest = new MembersRequest(
-      {},
+      {
+        meeting: {
+          request,
+          locusInfo: {
+            sequence,
+          },
+        },
+      },
       {
         parent: webex,
       }
     );
-    membersRequest.request = sinon.mock().returns(Promise.resolve({}));
+    locusDeltaRequestSpy = sinon.spy(membersRequest, 'locusDeltaRequest');
+
+    membersRequest.request = request;
   });
 
   afterEach(() => {
     sandbox.restore();
+    uuid.v4.restore();
   });
 
+  const checkRequest = (expectedParams) => {
+    assert.calledOnceWithExactly(locusDeltaRequestSpy, expectedParams);
+    assert.calledOnceWithExactly(
+      membersRequest.request,
+      merge(expectedParams, {body: {sequence}})
+    );
+  };
+
   describe('members request library', () => {
     describe('#sendDialPadKey', () => {
       it('sends a POST to the sendDtmf locus endpoint', async () => {
@@ -57,12 +84,22 @@ describe('plugin-meetings', () => {
           memberId,
           locusUrl,
         });
-        const requestParams = membersRequest.request.getCall(0).args[0];
 
-        assert.equal(requestParams.method, 'POST');
-        assert.equal(requestParams.uri, `${locusUrl}/participant/${memberId}/sendDtmf`);
-        assert.equal(requestParams.body.dtmf.tones, tones);
-        assert.equal(requestParams.body.device.url, url);
+        checkRequest({
+          method: 'POST',
+          uri: `${locusUrl}/participant/${memberId}/sendDtmf`,
+          body: {
+            memberId,
+            dtmf: {
+              direction: 'transmit',
+              correlationId,
+              tones,
+            },
+            device: {
+              url,
+            }
+          }
+        });
       });
     });
 
@@ -76,11 +113,91 @@ describe('plugin-meetings', () => {
         };
 
         await membersRequest.addMembers(options);
-        const requestParams = membersRequest.request.getCall(0).args[0];
 
-        assert.equal(requestParams.method, 'PUT');
-        assert.equal(requestParams.uri, url1);
-        assert.equal(requestParams.body.invitees[0].address, '+18578675309');
+        checkRequest({
+          method: 'PUT',
+          uri: url1,
+          body: {
+            alertIfActive: undefined,
+            invitees: [{address: '+18578675309'}]
+          }
+        })
+      });
+    });
+
+    describe('#admitMember', () => {
+      it('sends a request to admit members', async () => {
+        const options = {
+          locusUrl: url1,
+          memberIds: ['1', '2'],
+        };
+  
+        await membersRequest.admitMember(options)
+
+        checkRequest({
+          method: 'PUT',
+          uri: 'https://example.com/12345/controls',
+          body: {
+            admit: {
+              participantIds: options.memberIds
+            }
+          }
+        });
+      });
+    });
+
+    describe('#removeMember', () => {
+      it('sends a request to remove a member', async () => {
+        const options = {
+          locusUrl: url1,
+          memberId: 'member1',
+        };
+
+        await membersRequest.removeMember(options);
+
+        checkRequest({
+          method: 'PUT',
+          uri: 'https://example.com/12345/participant/member1/leave',
+          body: {
+            reason: undefined
+          },
+        });
+      });
+    });
+
+    describe('#muteMember', () => {
+      it('sends a request to mute a member', async () => {
+        const options = {
+          locusUrl: url1,
+          memberId: 'member1',
+          muted: true,
+        };
+
+        await membersRequest.muteMember(options);
+
+        checkRequest({
+          method: 'PATCH',
+          uri: 'https://example.com/12345/participant/member1/controls',
+          body: {audio: {muted: true}},
+        });
+      });
+    });
+
+    describe('#transferHostToMember', () => {
+      it('sends a request to transfer host to a member', async () => {
+        const options = {
+          locusUrl: url1,
+          memberId: 'member1',
+          moderator: true,
+        };
+
+        await membersRequest.transferHostToMember(options);
+
+        checkRequest({
+          method: 'PATCH',
+          uri: 'https://example.com/12345/participant/member1/controls',
+          body: {role: {moderator: true}},
+        });
       });
     });
 
@@ -94,12 +211,15 @@ describe('plugin-meetings', () => {
         };
 
         await membersRequest.cancelPhoneInvite(options);
-        const requestParams = membersRequest.request.getCall(0).args[0];
 
-        assert.equal(requestParams.method, 'PUT');
-        assert.equal(requestParams.uri, url1);
-        assert.equal(requestParams.body.invitees[0].address, '+18578675309');
-        assert.equal(requestParams.body.actionType, 'REMOVE');
+        checkRequest({
+          method: 'PUT',
+          uri: url1,
+          body: {
+            invitees: [{address: '+18578675309'}],
+            actionType: 'REMOVE',
+          },
+        });
       });
     });
 
@@ -120,11 +240,16 @@ describe('plugin-meetings', () => {
         };
 
         await membersRequest.assignRolesMember(options);
-        const requestParams = membersRequest.request.getCall(0).args[0];
 
-        assert.equal(requestParams.method, 'PATCH');
-        assert.equal(requestParams.uri, `${locusUrl}/participant/${memberId}/controls`);
-        assert.deepEqual(requestParams.body.role.roles, roles);
+        checkRequest({
+          method: 'PATCH',
+          uri: `${locusUrl}/participant/${memberId}/controls`,
+          body: {
+            role: {
+              roles
+            }
+          }
+        });
       });
     });
 
@@ -140,11 +265,16 @@ describe('plugin-meetings', () => {
         };
 
         await membersRequest.raiseOrLowerHandMember(options);
-        const requestParams = membersRequest.request.getCall(0).args[0];
 
-        assert.equal(requestParams.method, 'PATCH');
-        assert.equal(requestParams.uri, `${locusUrl}/participant/${memberId}/controls`);
-        assert.equal(requestParams.body.hand.raised, true);
+        checkRequest({
+          method: 'PATCH',
+          uri: `${locusUrl}/participant/${memberId}/controls`,
+          body: {
+            hand: {
+              raised: true
+            }
+          }
+        });
       });
     });
 
@@ -183,10 +313,9 @@ describe('plugin-meetings', () => {
           locusUrl,
         };
 
-        assert.strictEqual(
-          membersRequest.lowerAllHandsMember(options),
-          membersRequest.request.getCall(0).returnValue
-        );
+        const result = await membersRequest.lowerAllHandsMember(options);
+
+        assert.strictEqual(result, requestResponse);
       });
 
       it('sends a PATCH to the locus endpoint', async () => {
@@ -207,9 +336,7 @@ describe('plugin-meetings', () => {
           locusUrl: url1,
         });
 
-        const requestParams = membersRequest.request.getCall(0).args[0];
-
-        assert.deepEqual(requestParams, {
+        checkRequest({
           method: 'PATCH',
           uri: `${locusUrl}/controls`,
           body: {
@@ -232,15 +359,20 @@ describe('plugin-meetings', () => {
         const options = {
           memberId,
           requestingParticipantId,
-          aliasValue,
+          alias: aliasValue,
           locusUrl,
         };
 
         await membersRequest.editDisplayNameMember(options);
-        const requestParams = membersRequest.request.getCall(0).args[0];
 
-        assert.equal(requestParams.method, 'POST');
-        assert.equal(requestParams.uri, `${locusUrl}/participant/${memberId}/alias`);
+        checkRequest({
+          method: 'POST',
+          uri: `${locusUrl}/participant/${memberId}/alias`,
+          body: {
+            aliasValue,
+            requestingParticipantId,
+          }
+        });
       });
     });
   });

package/test/unit/spec/metrics/index.js

@@ -17,14 +17,6 @@ import metrics from '@webex/plugin-meetings/src/metrics';
 browserOnly(describe)('Meeting metrics', () => {
   let webex, mockSubmitMetric, sandbox;
 
-  const geoHintInfo = {
-    clientAddress: '2001:0db8:0000:08d3:0000:0000:0070:0000',
-    clientRegion: 'US-WEST',
-    countryCode: 'US',
-    regionCode: 'US-WEST',
-    timezone: 'America/Los_Angeles',
-  };
-
   beforeEach(() => {
     sandbox = sinon.createSandbox();
     mockSubmitMetric = sandbox.stub();
@@ -34,56 +26,15 @@ browserOnly(describe)('Meeting metrics', () => {
       },
     });
 
-    webex.version = '1.2.3';
-    webex.credentials.getOrgId = sinon.fake.returns('7890');
-    webex.credentials.config = {
-      _values: {
-        clientId: 'mock-client-id',
-      },
-    };
     webex.config.metrics.type = ['behavioral'];
     webex.internal.metrics.submitClientMetrics = mockSubmitMetric;
-    metrics.initialSetup({}, webex);
+    metrics.initialSetup(webex);
   });
 
   afterEach(() => {
     sandbox.restore();
   });
 
-  describe('initPayload / initMediaPayload', () => {
-    it('should create payload with masked IPv4', () => {
-      geoHintInfo.clientAddress = '128.0.0.1';
-      webex.meetings = {
-        geoHintInfo,
-      };
-      metrics.initialSetup({}, webex);
-      const payload = metrics.initPayload('myMetric', {}, {clientType: 'TEAMS_CLIENT'});
-
-      assert(payload.origin.clientInfo.localNetworkPrefix === '128.0.0.0');
-      assert(payload.event.name === 'myMetric');
-
-      const payload2 = metrics.initMediaPayload('myMetric', {}, {clientType: 'TEAMS_CLIENT'});
-
-      assert(payload2.origin.clientInfo.localNetworkPrefix === '128.0.0.0');
-    });
-
-    it('should create payload with masked IPv6', () => {
-      geoHintInfo.clientAddress = '2001:0db8:0000:08d3:0000:0000:0070:0000';
-      webex.meetings = {
-        geoHintInfo,
-      };
-      metrics.initialSetup({}, webex);
-      const payload = metrics.initPayload('myIPv6Metric', {}, {clientType: 'TEAMS_CLIENT'});
-
-      assert(payload.origin.clientInfo.localNetworkPrefix === '2001:db8:0:8d3::');
-      assert(payload.event.name === 'myIPv6Metric');
-
-      const payload2 = metrics.initMediaPayload('myIPv6Metric', {}, {clientType: 'TEAMS_CLIENT'});
-
-      assert(payload2.origin.clientInfo.localNetworkPrefix === '2001:db8:0:8d3::');
-    });
-  });
-
   describe('#sendBehavioralMetric', () => {
     it('sends client metric via Metrics plugin', () => {
       metrics.sendBehavioralMetric('myMetric');