@webex/plugin-meetings 3.0.0-beta.1 → 3.0.0-beta.11

package/test/unit/spec/reconnection-manager/index.js

@@ -2,15 +2,81 @@ import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';
-
-import ReconnectionManager from '../../../../src/reconnection-manager';
+import ReconnectionManager from '@webex/plugin-meetings/src/reconnection-manager';
+import Metrics from '@webex/plugin-meetings/src/metrics';
 
 const {assert} = chai;
 
 chai.use(chaiAsPromised);
 sinon.assert.expose(chai.assert, {prefix: ''});
 
+
 describe('plugin-meetings', () => {
+  describe('ReconnectionManager.reconnect', () => {
+    it('uses correct TURN TLS information on the new connection', async () => {
+      Metrics.postEvent = sinon.stub();
+
+      const fakeMediaConnection = {
+        initiateOffer: sinon.stub().resolves({})
+      };
+      const fakeMeeting = {
+        closePeerConnections: sinon.stub().resolves({}),
+        createMediaConnection: sinon.stub().returns(fakeMediaConnection),
+        config: {
+          reconnection: {
+            enabled: true,
+            detection: true,
+            iceReconnectionTimeout: 10000,
+            retry: {
+              times: 2,
+              backOff: {
+                start: 1000,
+                rate: 2
+              }
+            }
+          }
+        },
+        mediaProperties: {
+          unsetPeerConnection: sinon.stub(),
+        },
+        roap: {
+          doTurnDiscovery: sinon.stub().resolves({
+            turnServerInfo: {
+              url: 'fake_turn_url',
+              username: 'fake_turn_username',
+              password: 'fake_turn_password',
+            },
+            turnDiscoverySkippedReason: undefined
+          })
+        },
+        statsAnalyzer: {
+          updateMediaConnection: sinon.stub(),
+        },
+        webex: {
+          meetings: {
+            getMeetingByType: sinon.stub().returns(true),
+            syncMeetings: sinon.stub().resolves({})
+          }
+        }
+      };
+
+      const rm = new ReconnectionManager(fakeMeeting);
+
+      await rm.reconnect();
+
+      assert.calledOnce(fakeMeeting.closePeerConnections);
+      assert.calledOnce(fakeMeeting.mediaProperties.unsetPeerConnection);
+      assert.calledOnce(fakeMeeting.roap.doTurnDiscovery);
+      assert.calledOnce(fakeMeeting.createMediaConnection);
+      assert.calledWith(fakeMeeting.createMediaConnection, {
+        url: 'fake_turn_url',
+        username: 'fake_turn_username',
+        password: 'fake_turn_password',
+      });
+      assert.calledOnce(fakeMediaConnection.initiateOffer);
+    });
+  });
+
   /**
    * Currently, testing dependent classes that aren't available at the top
    * level causes testing errors in CI based around related files. Skipping this here until a solution

package/test/unit/spec/roap/index.ts

@@ -1,10 +1,8 @@
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import TurnDiscovery from '@webex/plugin-meetings/src/roap/turnDiscovery';
-import {ROAP} from '@webex/plugin-meetings/src/constants';
 
 import RoapRequest from '@webex/plugin-meetings/src/roap/request';
-import RoapHandler from '@webex/plugin-meetings/src/roap/handler';
 import Roap from '@webex/plugin-meetings/src/roap/';
 
 describe('Roap', () => {
@@ -13,7 +11,9 @@ describe('Roap', () => {
       const RESULT = {something: 'some value'};
       const meeting = {id: 'some meeting id'};
 
-      const doTurnDiscoveryStub = sinon.stub(TurnDiscovery.prototype, 'doTurnDiscovery').resolves(RESULT);
+      const doTurnDiscoveryStub = sinon
+        .stub(TurnDiscovery.prototype, 'doTurnDiscovery')
+        .resolves(RESULT);
 
       const roap = new Roap({}, {parent: 'fake'});
 
@@ -37,22 +37,22 @@ describe('Roap', () => {
 
   describe('sendRoapMediaRequest', () => {
     let sendRoapStub;
-    let roapHandlerSubmitStub;
-
-    const meeting = {
-      id: 'some meeting id',
-      correlationId: 'correlation id',
-      selfUrl: 'self url',
-      mediaId: 'media id',
-      isAudioMuted: () => true,
-      isVideoMuted: () => false,
-      setRoapSeq: sinon.stub(),
-      config: {experimental: {enableTurnDiscovery: false}},
-    };
+    let meeting;
 
     beforeEach(() => {
+      meeting = {
+        id: 'some meeting id',
+        correlationId: 'correlation id',
+        selfUrl: 'self url',
+        mediaId: 'media id',
+        isMultistream: false,
+        isAudioMuted: () => true,
+        isVideoMuted: () => false,
+        setRoapSeq: sinon.stub(),
+        config: {experimental: {enableTurnDiscovery: false}},
+      };
+
       sendRoapStub = sinon.stub(RoapRequest.prototype, 'sendRoap').resolves({});
-      roapHandlerSubmitStub = sinon.stub(RoapHandler.prototype, 'submit');
       meeting.setRoapSeq.resetHistory();
     });
 
@@ -66,13 +66,21 @@ describe('Roap', () => {
       {reconnect: false, enableTurnDiscovery: true, expectEmptyMediaId: false},
       {reconnect: false, enableTurnDiscovery: false, expectEmptyMediaId: false},
     ].forEach(({reconnect, enableTurnDiscovery, expectEmptyMediaId}) =>
-      it(`sends roap OFFER with ${expectEmptyMediaId ? 'empty ' : ''}mediaId when ${reconnect ? '' : 'not '}reconnecting and TURN discovery is ${enableTurnDiscovery ? 'enabled' : 'disabled'}`, async () => {
+      it(`sends roap OFFER with ${expectEmptyMediaId ? 'empty ' : ''}mediaId when ${
+        reconnect ? '' : 'not '
+      }reconnecting and TURN discovery is ${
+        enableTurnDiscovery ? 'enabled' : 'disabled'
+      }`, async () => {
         meeting.config.experimental.enableTurnDiscovery = enableTurnDiscovery;
 
         const roap = new Roap({}, {parent: 'fake'});
 
         await roap.sendRoapMediaRequest({
-          meeting, sdp: 'sdp', reconnect, roapSeq: 1
+          meeting,
+          sdp: 'sdp',
+          reconnect,
+          seq: 2,
+          tieBreaker: 4294967294,
         });
 
         const expectedRoapMessage = {
@@ -80,7 +88,7 @@ describe('Roap', () => {
           sdps: ['sdp'],
           version: '2',
           seq: 2,
-          tieBreaker: 4294967294
+          tieBreaker: 4294967294,
         };
 
         assert.calledOnce(sendRoapStub);
@@ -91,23 +99,43 @@ describe('Roap', () => {
           mediaId: expectEmptyMediaId ? '' : meeting.mediaId,
           audioMuted: meeting.isAudioMuted(),
           videoMuted: meeting.isVideoMuted(),
-          meetingId: meeting.id
-        });
-
-        assert.calledTwice(roapHandlerSubmitStub);
-        assert.calledWith(roapHandlerSubmitStub, {
-          type: ROAP.SEND_ROAP_MSG,
-          msg: expectedRoapMessage,
-          correlationId: meeting.correlationId
-        });
-        assert.calledWith(roapHandlerSubmitStub, {
-          type: ROAP.SEND_ROAP_MSG_SUCCESS,
-          seq: 2,
-          correlationId: meeting.correlationId
+          meetingId: meeting.id,
+          preferTranscoding: true,
         });
+      })
+    );
+    it('sends roap request with preferTranscoding=false for multistream meetings', async () => {
+      const roap = new Roap({}, {parent: 'fake'});
 
-        assert.calledOnce(meeting.setRoapSeq);
-        assert.calledWith(meeting.setRoapSeq, 2);
-      }));
+      meeting.isMultistream = true;
+
+      await roap.sendRoapMediaRequest({
+        meeting,
+        sdp: 'sdp',
+        reconnect: false,
+        seq: 10,
+        tieBreaker: 1,
+      });
+
+      const expectedRoapMessage = {
+        messageType: 'OFFER',
+        sdps: ['sdp'],
+        version: '2',
+        seq: 10,
+        tieBreaker: 1,
+      };
+
+      assert.calledOnce(sendRoapStub);
+      assert.calledWith(sendRoapStub, {
+        roapMessage: expectedRoapMessage,
+        correlationId: meeting.correlationId,
+        locusSelfUrl: meeting.selfUrl,
+        mediaId: meeting.mediaId,
+        audioMuted: meeting.isAudioMuted(),
+        videoMuted: meeting.isVideoMuted(),
+        meetingId: meeting.id,
+        preferTranscoding: false,
+      });
+    });
   });
 });

package/test/unit/spec/stats-analyzer/index.js

@@ -2,6 +2,7 @@ import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';
+import {MediaConnection as MC} from '@webex/internal-media-core';
 
 import {StatsAnalyzer, EVENTS} from '../../../../src/statsAnalyzer';
 import NetworkQualityMonitor from '../../../../src/networkQualityMonitor';
@@ -130,30 +131,26 @@ describe('plugin-meetings', () => {
         };
 
         pc = {
-          audioTransceiver: {
-            sender: {
-              getStats: sinon.stub().resolves([fakeStats.audio.sender])
-            },
-            receiver: {
-              getStats: sinon.stub().resolves([fakeStats.audio.receiver])
-            },
-          },
-          videoTransceiver: {
-            sender: {
-              getStats: sinon.stub().resolves([fakeStats.video.sender])
-            },
-            receiver: {
-              getStats: sinon.stub().resolves([fakeStats.video.receiver])
+          getConnectionState: sinon.stub().returns(MC.ConnectionState.Connected),
+          getTransceiverStats: sinon.stub().resolves({
+            audio: {
+              sender: [fakeStats.audio.sender],
+              receiver: [fakeStats.audio.receiver],
+              currentDirection: 'sendrecv',
+              localTrackLabel: 'fake mic',
             },
-          },
-          shareTransceiver: {
-            sender: {
-              getStats: sinon.stub().resolves([])
+            video: {
+              sender: [fakeStats.video.sender],
+              receiver: [fakeStats.video.receiver],
+              currentDirection: 'sendrecv',
+              localTrackLabel: 'fake camera',
             },
-            receiver: {
-              getStats: sinon.stub().resolves([])
-            },
-          }
+            screenShareVideo: {
+              sender: [],
+              receiver: [],
+              currentDirection: 'sendrecv'
+            }
+          })
         };
 
         networkQualityMonitor = new NetworkQualityMonitor(initialConfig);