@webex/plugin-meetings 3.0.0-beta.1 → 3.0.0-beta.11

package/src/roap/turnDiscovery.ts

@@ -1,3 +1,4 @@
+// @ts-ignore - Types not available for @webex/common
 import {Defer} from '@webex/common';
 
 import Metrics from '../metrics';
@@ -6,9 +7,16 @@ import LoggerProxy from '../common/logs/logger-proxy';
 import {ROAP} from '../constants';
 
 import RoapRequest from './request';
+import Meeting from '../meeting';
 
 const TURN_DISCOVERY_TIMEOUT = 10; // in seconds
 
+// Roap spec says that seq should start from 1, but TURN discovery works fine with seq=0
+// and this is handy for us, because TURN discovery is always done before the first SDP exchange,
+// so we can do it with seq=0 or not do it at all and then we create the RoapMediaConnection
+// and do the SDP offer with seq=1
+const TURN_DISCOVERY_SEQ = 0;
+
 /**
  * Handles the process of finding out TURN server information from Linus.
  * This is achieved by sending a TURN_DISCOVERY_REQUEST.
@@ -48,7 +56,7 @@ export default class TurnDiscovery {
    * @private
    * @memberof Roap
    */
-  waitForTurnDiscoveryResponse() {
+  private waitForTurnDiscoveryResponse() {
     if (!this.defer) {
       LoggerProxy.logger.warn('Roap:turnDiscovery#waitForTurnDiscoveryResponse --> TURN discovery is not in progress');
 
@@ -76,7 +84,8 @@ export default class TurnDiscovery {
    * @public
    * @memberof Roap
    */
-  handleTurnDiscoveryResponse(roapMessage) {
+  public handleTurnDiscoveryResponse(roapMessage: object) {
+    // @ts-ignore - Fix missing type
     const {headers} = roapMessage;
 
     if (!this.defer) {
@@ -125,9 +134,7 @@ export default class TurnDiscovery {
    * @private
    * @memberof Roap
    */
-  sendRoapTurnDiscoveryRequest(meeting, isReconnecting) {
-    const seq = meeting.roapSeq + 1;
-
+  sendRoapTurnDiscoveryRequest(meeting: Meeting, isReconnecting: boolean) {
     if (this.defer) {
       LoggerProxy.logger.warn('Roap:turnDiscovery#sendRoapTurnDiscoveryRequest --> already in progress');
 
@@ -139,7 +146,7 @@ export default class TurnDiscovery {
     const roapMessage = {
       messageType: ROAP.ROAP_TYPES.TURN_DISCOVERY_REQUEST,
       version: ROAP.ROAP_VERSION,
-      seq,
+      seq: TURN_DISCOVERY_SEQ,
     };
 
     LoggerProxy.logger.info('Roap:turnDiscovery#sendRoapTurnDiscoveryRequest --> sending TURN_DISCOVERY_REQUEST');
@@ -148,15 +155,15 @@ export default class TurnDiscovery {
       .sendRoap({
         roapMessage,
         correlationId: meeting.correlationId,
+       // @ts-ignore - Fix missing type
         locusSelfUrl: meeting.selfUrl,
+        // @ts-ignore - Fix missing type
         mediaId: isReconnecting ? '' : meeting.mediaId,
         audioMuted: meeting.isAudioMuted(),
         videoMuted: meeting.isVideoMuted(),
         meetingId: meeting.id
       })
       .then(({mediaConnections}) => {
-        meeting.setRoapSeq(seq);
-
         if (mediaConnections) {
           meeting.updateMediaConnections(mediaConnections);
         }
@@ -170,16 +177,18 @@ export default class TurnDiscovery {
    * @param {Meeting} meeting
    * @returns {Promise}
    */
-  sendRoapOK(meeting) {
+  sendRoapOK(meeting: Meeting) {
     LoggerProxy.logger.info('Roap:turnDiscovery#sendRoapOK --> sending OK');
 
     return this.roapRequest.sendRoap({
       roapMessage: {
         messageType: ROAP.ROAP_TYPES.OK,
         version: ROAP.ROAP_VERSION,
-        seq: meeting.roapSeq
+        seq: TURN_DISCOVERY_SEQ,
       },
+      // @ts-ignore - fix type
       locusSelfUrl: meeting.selfUrl,
+      // @ts-ignore - fix type
       mediaId: meeting.mediaId,
       correlationId: meeting.correlationId,
       audioMuted: meeting.isAudioMuted(),
@@ -196,12 +205,17 @@ export default class TurnDiscovery {
    *  | <----TURN_DISCOVERY_RESPONSE----- |
    *  | --------------OK----------------> |
    *
+   * This TURN discovery roap exchange is always done with seq=0.
+   * The RoapMediaConnection SDP exchange always starts with seq=1,
+   * so it works fine no matter if TURN discovery is done or not.
+   *
    * @param {Meeting} meeting
    * @param {Boolean} isReconnecting should be set to true if this is a new
    *                                 media connection just after a reconnection
    * @returns {Promise}
    */
-  doTurnDiscovery(meeting, isReconnecting) {
+  doTurnDiscovery(meeting: Meeting, isReconnecting: boolean) {
+    // @ts-ignore - fix type
     const isAnyClusterReachable = meeting.webex.meetings.reachability.isAnyClusterReachable();
 
     if (isAnyClusterReachable) {
@@ -209,6 +223,7 @@ export default class TurnDiscovery {
       return Promise.resolve({turnServerInfo: undefined, turnDiscoverySkippedReason: 'reachability'});
     }
 
+    // @ts-ignore - fix type
     if (!meeting.config.experimental.enableTurnDiscovery) {
       LoggerProxy.logger.info('Roap:turnDiscovery#doTurnDiscovery --> TURN discovery disabled in config, skipping it');
 

package/src/statsAnalyzer/{global.js → global.ts}

@@ -2,6 +2,7 @@ const STATS_DEFAULT = {
   encryption: 'sha-256',
   audio: {
     send: {
+      trackLabel: '',
       maxPacketLossRatio: 0,
       availableBandwidth: 0,
       bytesSent: 0,
@@ -17,6 +18,7 @@ const STATS_DEFAULT = {
   },
   video: {
     send: {
+      trackLabel: '',
       maxPacketLossRatio: 0,
       availableBandwidth: 0,
       meanRemoteJitter: [],

package/src/statsAnalyzer/{index.js → index.ts}

@@ -1,7 +1,8 @@
 import {cloneDeep} from 'lodash';
+import {MediaConnection as MC} from '@webex/internal-media-core';
 
 import EventsScope from '../common/events/events-scope';
-import {DEFAULT_GET_STATS_FILTER, CONNECTION_STATE, STATS, MQA_INTEVAL, NETWORK_TYPE, MEDIA_DEVICES, _UNKNOWN_} from '../constants';
+import {DEFAULT_GET_STATS_FILTER, STATS, MQA_INTEVAL, NETWORK_TYPE, MEDIA_DEVICES, _UNKNOWN_} from '../constants';
 import mqaData from '../mediaQualityMetrics/config';
 import LoggerProxy from '../common/logs/logger-proxy';
 
@@ -29,6 +30,21 @@ export const EVENTS = {
  * @extends {EventsScope}
  */
 export class StatsAnalyzer extends EventsScope {
+  config: any;
+  correlationId: any;
+  lastEmittedStartStopEvent: any;
+  lastMqaDataSent: any;
+  lastStatsResults: any;
+  localMQEStats: any;
+  meetingMediaStatus: any;
+  mqaInterval: NodeJS.Timeout;
+  mqaSentCount: any;
+  networkQualityMonitor: any;
+  mediaConnection: any;
+  statsInterval: NodeJS.Timeout;
+  statsResults: any;
+  statsStarted: any;
+
   /**
    * Creates a new instance of StatsAnalyzer
    * @constructor
@@ -37,7 +53,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {Object} networkQualityMonitor class for assessing network characteristics (jitter, packetLoss, latency)
    * @param {Object} statsResults Default properties for stats
    */
-  constructor(config, networkQualityMonitor = {}, statsResults = defaultStats) {
+  constructor(config: any, networkQualityMonitor: object = {}, statsResults: object = defaultStats) {
     super();
     this.statsStarted = false;
     this.statsResults = statsResults;
@@ -170,18 +186,18 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  updateMediaStatus(status) {
+  public updateMediaStatus(status: object) {
     this.meetingMediaStatus = status;
   }
 
   /**
-   * captures MQA data from peerconnection
+   * captures MQA data from media connection
    *
    * @public
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  sendMqaData() {
+  public sendMqaData() {
     const audioReceiver = mqaData.intervals[0].audioReceive[0];
     const audioSender = mqaData.intervals[0].audioTransmit[0];
     const videoReceiver = mqaData.intervals[0].videoReceive[0];
@@ -232,10 +248,11 @@ export class StatsAnalyzer extends EventsScope {
     // Adding peripheral information
     mqaData.intervals[0].intervalMetadata.peripherals = [];
     mqaData.intervals[0].intervalMetadata.peripherals.push({information: _UNKNOWN_, name: MEDIA_DEVICES.SPEAKER});
-    mqaData.intervals[0].intervalMetadata.peripherals.push({information: this.peerConnection?.audioTransceiver?.sender?.track?.label || _UNKNOWN_, name: MEDIA_DEVICES.MICROPHONE});
-    mqaData.intervals[0].intervalMetadata.peripherals.push({information: this.peerConnection?.videoTransceiver?.sender?.track?.label || _UNKNOWN_, name: MEDIA_DEVICES.CAMERA});
+    mqaData.intervals[0].intervalMetadata.peripherals.push({information: this.statsResults[STATS.AUDIO_CORRELATE][STATS.SEND_DIRECTION].trackLabel || _UNKNOWN_, name: MEDIA_DEVICES.MICROPHONE});
+    mqaData.intervals[0].intervalMetadata.peripherals.push({information: this.statsResults[STATS.VIDEO_CORRELATE][STATS.SEND_DIRECTION].trackLabel || _UNKNOWN_, name: MEDIA_DEVICES.CAMERA});
 
 
+    // @ts-ignore
     mqaData.networkType = this.statsResults.connectionType.local.networkType;
 
     this.mqaSentCount += 1;
@@ -257,21 +274,22 @@ export class StatsAnalyzer extends EventsScope {
       EVENTS.MEDIA_QUALITY,
       {
         data: mqaData.intervals[0],
+        // @ts-ignore
         networkType: mqaData.networkType
       }
     );
   }
 
   /**
-   * updated the peerconnection when changed
+   * updated the media connection when changed
    *
    * @private
-   * @memberof updatePeerconnection
-   * @param {PeerConnection} peerConnection
+   * @memberof StatsAnalyzer
+   * @param {MC.RoapMediaConnection} mediaConnection
    * @returns {void}
    */
-  updatePeerconnection(peerConnection) {
-    this.peerConnection = peerConnection;
+  updateMediaConnection(mediaConnection: any) {
+    this.mediaConnection = mediaConnection;
   }
 
   /**
@@ -279,13 +297,13 @@ export class StatsAnalyzer extends EventsScope {
    *
    * @public
    * @memberof StatsAnalyzer
-   * @param {PeerConnection} peerConnection
+   * @param {MC.RoapMediaConnection} mediaConnection
    * @returns {Promise}
    */
-  startAnalyzer(peerConnection) {
+  public startAnalyzer(mediaConnection: any) {
     if (!this.statsStarted) {
       this.statsStarted = true;
-      this.peerConnection = peerConnection;
+      this.mediaConnection = mediaConnection;
 
       return this.getStatsAndParse()
         .then(() => {
@@ -310,7 +328,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  stopAnalyzer() {
+  public stopAnalyzer() {
     const sendOneLastMqa = this.mqaInterval && this.statsInterval;
 
     if (this.statsInterval) {
@@ -326,10 +344,10 @@ export class StatsAnalyzer extends EventsScope {
     if (sendOneLastMqa) {
       return this.getStatsAndParse().then(() => {
         this.sendMqaData();
-        this.peerConnection = null;
+        this.mediaConnection = null;
       });
     }
-    this.peerConnection = null;
+    this.mediaConnection = null;
 
     return Promise.resolve();
   }
@@ -344,7 +362,7 @@ export class StatsAnalyzer extends EventsScope {
    * @returns {void}
    * @memberof StatsAnalyzer
    */
-  parseGetStatsResult(getStatsResult, type, isSender) {
+  private parseGetStatsResult(getStatsResult: any, type: string, isSender: boolean) {
     if (!getStatsResult) {
       return;
     }
@@ -361,6 +379,7 @@ export class StatsAnalyzer extends EventsScope {
         break;
       case 'remote-inbound-rtp':
       case 'remote-outbound-rtp':
+        // @ts-ignore
         this.compareSentAndReceived(getStatsResult, type, isSender);
         break;
       case 'remotecandidate':
@@ -371,6 +390,7 @@ export class StatsAnalyzer extends EventsScope {
         this.parseCandidate(getStatsResult, type, isSender, false);
         break;
       case 'media-source':
+        // @ts-ignore
         this.parseAudioSource(getStatsResult, type);
         break;
       default:
@@ -386,7 +406,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {boolean} isSender
    * @returns {void}
    */
-  filterAndParseGetStatsResults(getStatsResults, type, isSender) {
+  private filterAndParseGetStatsResults(getStatsResults: Array<any>, type: string, isSender: boolean) {
     const {types} = DEFAULT_GET_STATS_FILTER;
 
     getStatsResults.forEach((result) => {
@@ -402,7 +422,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {boolean} type
    * @returns {void}
    */
-  parseAudioSource(result, type) {
+  parseAudioSource(result: any, type: any) {
     if (!result) {
       return;
     }
@@ -427,7 +447,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  emitStartStopEvents = (mediaType, previousValue, currentValue, isLocal) => {
+  emitStartStopEvents = (mediaType: string, previousValue: number, currentValue: number, isLocal: boolean) => {
     if (mediaType !== 'audio' && mediaType !== 'video' && mediaType !== 'share') {
       throw new Error(`Unsupported mediaType: ${mediaType}`);
     }
@@ -475,7 +495,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  compareLastStatsResult() {
+  private compareLastStatsResult() {
     if (this.lastStatsResults !== null && this.meetingMediaStatus) {
       // compare audio stats sent
       let mediaType = STATS.AUDIO_CORRELATE;
@@ -633,54 +653,39 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {Promise}
    */
-  getStatsAndParse() {
-    if (!this.peerConnection) {
+  private getStatsAndParse() {
+    if (!this.mediaConnection) {
       return Promise.resolve();
     }
 
-    if (this.peerConnection && this.peerConnection.connectionState === CONNECTION_STATE.FAILED) {
-      LoggerProxy.logger.trace('StatsAnalyzer:index#getStatsAndParse --> PeerConnection is in failed state');
+    if (this.mediaConnection && this.mediaConnection.getConnectionState() === MC.ConnectionState.Failed) {
+      LoggerProxy.logger.trace('StatsAnalyzer:index#getStatsAndParse --> media connection is in failed state');
 
       return Promise.resolve();
     }
 
     LoggerProxy.logger.trace('StatsAnalyzer:index#getStatsAndParse --> Collecting Stats');
 
-    return Promise.all([
-      this.peerConnection.videoTransceiver.sender.getStats().then((res) => {
-        this.filterAndParseGetStatsResults(res, STATS.VIDEO_CORRELATE, true);
-      }),
-
-      this.peerConnection.videoTransceiver.receiver.getStats().then((res) => {
-        this.filterAndParseGetStatsResults(res, STATS.VIDEO_CORRELATE, false);
-      }),
-
-      this.peerConnection.audioTransceiver.sender.getStats().then((res) => {
-        this.filterAndParseGetStatsResults(res, STATS.AUDIO_CORRELATE, true);
-      }),
-
-      this.peerConnection.audioTransceiver.receiver.getStats().then((res) => {
-        this.filterAndParseGetStatsResults(res, STATS.AUDIO_CORRELATE, false);
-      }),
-
-      // TODO: add checks for screen share
-      this.peerConnection.shareTransceiver.sender.getStats().then((res) => {
-        this.filterAndParseGetStatsResults(res, STATS.SHARE_CORRELATE, true);
-      }),
+    return this.mediaConnection.getTransceiverStats().then((transceiverStats) => {
+      this.filterAndParseGetStatsResults(transceiverStats.video.sender, STATS.VIDEO_CORRELATE, true);
+      this.filterAndParseGetStatsResults(transceiverStats.video.receiver, STATS.VIDEO_CORRELATE, false);
+      this.filterAndParseGetStatsResults(transceiverStats.audio.sender, STATS.AUDIO_CORRELATE, true);
+      this.filterAndParseGetStatsResults(transceiverStats.audio.receiver, STATS.AUDIO_CORRELATE, false);
+      this.filterAndParseGetStatsResults(transceiverStats.screenShareVideo.sender, STATS.SHARE_CORRELATE, true);
+      this.filterAndParseGetStatsResults(transceiverStats.screenShareVideo.receiver, STATS.SHARE_CORRELATE, false);
 
-      this.peerConnection.shareTransceiver.receiver.getStats().then((res) => {
-        this.filterAndParseGetStatsResults(res, STATS.SHARE_CORRELATE, false);
-      }),
+      // updates the current direction of media
+      this.statsResults[STATS.AUDIO_CORRELATE].direction = transceiverStats.audio.currentDirection;
+      this.statsResults[STATS.VIDEO_CORRELATE].direction = transceiverStats.video.currentDirection;
+      this.statsResults[STATS.SHARE_CORRELATE].direction = transceiverStats.screenShareVideo.currentDirection;
 
-    ]).then(() => {
-      this.statsResults[STATS.AUDIO_CORRELATE].direction = this.peerConnection.audioTransceiver.currentDirection;
-      this.statsResults[STATS.VIDEO_CORRELATE].direction = this.peerConnection.videoTransceiver.currentDirection;
-      this.statsResults[STATS.SHARE_CORRELATE].direction = this.peerConnection.shareTransceiver.currentDirection;
+      this.statsResults[STATS.AUDIO_CORRELATE][STATS.SEND_DIRECTION].trackLabel = transceiverStats.audio.localTrackLabel;
+      this.statsResults[STATS.VIDEO_CORRELATE][STATS.SEND_DIRECTION].trackLabel = transceiverStats.video.localTrackLabel;
 
-      // Process Stats results every 5 seconds
       this.compareLastStatsResult();
 
       // Save the last results to compare with the current
+      // DO Deep copy, for some reason it takes the reference all the time rather then old value set
       this.lastStatsResults = JSON.parse(JSON.stringify(this.statsResults));
 
       LoggerProxy.logger.trace('StatsAnalyzer:index#getStatsAndParse --> Finished Collecting Stats');
@@ -694,7 +699,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {*} type
    * @returns {void}
    */
-  processOutboundRTPResult(result, type) {
+  private processOutboundRTPResult(result: any, type: any) {
     const mediaType = type || STATS.AUDIO_CORRELATE;
     const sendrecvType = STATS.SEND_DIRECTION;
 
@@ -758,7 +763,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {*} type
    * @returns {void}
    */
-  processInboundRTPResult(result, type) {
+  private processInboundRTPResult(result: any, type: any) {
     const mediaType = type || STATS.AUDIO_CORRELATE;
     const sendrecvType = STATS.RECEIVE_DIRECTION;
 
@@ -860,7 +865,7 @@ export class StatsAnalyzer extends EventsScope {
    *
    * @returns {void}
    */
-  parseCandidate = (result, type, isSender, isRemote) => {
+  parseCandidate = (result: any, type: any, isSender: boolean, isRemote: boolean) => {
     if (!result || !result.id) {
       return;
     }
@@ -935,7 +940,7 @@ export class StatsAnalyzer extends EventsScope {
    * @returns {void}
    * @memberof StatsAnalyzer
    */
-  processTrackResult(result, mediaType) {
+  private processTrackResult(result: any, mediaType: any) {
     if (!result || result.type !== 'track') {
       return;
     }
@@ -979,7 +984,7 @@ export class StatsAnalyzer extends EventsScope {
    * @returns {void}
    * @memberof StatsAnalyzer
    */
-  compareSentAndReceived(result, type) {
+  private compareSentAndReceived(result: any, type: any) {
     if (!type) {
       return;
     }

package/src/statsAnalyzer/{mqaUtil.js → mqaUtil.ts}

@@ -1,4 +1,3 @@
-
 import {mean, max} from 'lodash';
 
 import {STATS} from '../constants';
@@ -17,6 +16,7 @@ export const getAudioReceiverMqa = ({audioReceiver, statsResults, lastMqaDataSen
   audioReceiver.common.mediaHopByHopLost = (statsResults[mediaType][sendrecvType].totalPacketsLost - lastMqaDataSent[mediaType][sendrecvType].totalPacketsLost) || 0;
   audioReceiver.common.rtpHopByHopLost = statsResults[mediaType][sendrecvType].totalPacketsLost - lastMqaDataSent[mediaType][sendrecvType].totalPacketsLost || 0;
 
+  // @ts-ignore
   audioReceiver.streams[0].common.maxRtpJitter = max(statsResults[mediaType][sendrecvType].meanRtpJitter) * 1000 || 0;
   audioReceiver.streams[0].common.meanRtpJitter = mean(statsResults[mediaType][sendrecvType].meanRtpJitter) * 1000 || 0;
   audioReceiver.streams[0].common.rtpJitter = audioReceiver.streams[0].common.maxRtpJitter;
@@ -43,6 +43,7 @@ export const getAudioSenderMqa = ({audioSender, statsResults, lastMqaDataSent})
   audioSender.common.common.direction = statsResults[mediaType].direction;
   audioSender.common.transportType = statsResults.connectionType.local.transport[0];
 
+  // @ts-ignore
   audioSender.common.maxRemoteJitter = max(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
   audioSender.common.meanRemoteJitter = mean(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
 
@@ -56,6 +57,7 @@ export const getAudioSenderMqa = ({audioSender, statsResults, lastMqaDataSent})
 
   audioSender.common.remoteLossRate = totalpacketsLostForaMin > 0 ? (totalpacketsLostForaMin * 100 / audioSender.common.rtpPackets) : 0; // This is the packets sent with in last min || 0;
 
+  // @ts-ignore
   audioSender.common.maxRoundTripTime = max(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   audioSender.common.meanRoundTripTime = mean(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   audioSender.common.roundTripTime = audioSender.common.maxRoundTripTime;
@@ -97,6 +99,7 @@ export const getVideoReceiverMqa = ({
 
   // calculate this values
 
+  // @ts-ignore
   videoReceiver.common.maxRemoteJitter = max(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
   videoReceiver.common.meanRemoteJitter = mean(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
 
@@ -134,6 +137,7 @@ export const getVideoSenderMqa = ({
   videoSender.common.common.direction = statsResults[mediaType].direction;
   videoSender.common.transportType = statsResults.connectionType.local.transport[0];
 
+  // @ts-ignore
   videoSender.common.maxRemoteJitter = max(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
   videoSender.common.meanRemoteJitter = mean(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
 
@@ -146,6 +150,7 @@ export const getVideoSenderMqa = ({
 
   videoSender.common.remoteLossRate = totalpacketsLostForaMin > 0 ? (totalpacketsLostForaMin) * 100 / (videoSender.common.rtpPackets + totalpacketsLostForaMin) : 0; // This is the packets sent with in last min || 0;
 
+  // @ts-ignore
   videoSender.common.maxRoundTripTime = max(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   videoSender.common.meanRoundTripTime = mean(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   videoSender.common.roundTripTime = videoSender.common.maxRoundTripTime;

package/src/transcription/{index.js → index.ts}

@@ -6,6 +6,12 @@ import {v4 as uuidv4} from 'uuid';
  * @class Transcription
  */
 export default class Transcription {
+  webSocketUrl: any;
+  sessionID: any;
+  members: any;
+  memberCSIs: any;
+  webSocket: any;
+
   /**
    * @param {string} webSocketUrl
    * @param {sessionID} sessionId
@@ -13,7 +19,7 @@ export default class Transcription {
    * @constructor
    * @memberof Transcription
    */
-  constructor(webSocketUrl, sessionId, members) {
+  constructor(webSocketUrl: string, sessionId: any, members: object) {
     this.webSocketUrl = webSocketUrl;
     this.sessionID = sessionId;
     this.members = members;
@@ -32,7 +38,7 @@ export default class Transcription {
    * @param {string} sessionID
    * @returns {void}
    */
-  connect(token) {
+  connect(token: string) {
     this.webSocket.onopen = () => {
       this.webSocket.send(JSON.stringify({
         id: uuidv4(),
@@ -46,10 +52,10 @@ export default class Transcription {
   /**
    * Sets callback to invoke when the web socket connection is closed.
    *
-   * @param {function} callback
+   * @param {Function} callback
    * @returns {void}
    */
-  onCloseSocket(callback) {
+  onCloseSocket(callback: Function) {
     if (callback) {
       this.webSocket.onclose = (event) => {
         callback(event);
@@ -61,10 +67,10 @@ export default class Transcription {
    * Sets callback to invoke when a web socket connection error occurs.
    * An event parameter will be send to the callback.
    *
-   * @param {function} callback
+   * @param {Function} callback
    * @returns {void}
    */
-  onErrorSocket(callback) {
+  onErrorSocket(callback: Function) {
     if (callback) {
       this.webSocket.onerror = (event) => {
         callback(event);
@@ -79,7 +85,7 @@ export default class Transcription {
    * @param {object} csis
    * @returns {object}
    */
-  getSpeaker(csis) {
+  private getSpeaker(csis: any) {
     for (const csi of csis) {
       const member = this.memberCSIs[csi];
 
@@ -89,7 +95,7 @@ export default class Transcription {
     }
 
     return Object.values(this.members.membersCollection.members)
-      .find((member) => {
+      .find((member: any) => {
         const memberCSIs = member.participant.status.csis;
         let selfIsSpeaking = false;
 
@@ -108,10 +114,10 @@ export default class Transcription {
   /**
    * Sends transcription data to given callback as it arrives.
    *
-   * @param {function} callback
+   * @param {Function} callback
    * @returns {void}
    */
-  subscribe(callback) {
+  subscribe(callback: Function) {
     let data, csis, speaker, transcription;
 
     this.webSocket.onmessage = (event) => {
@@ -144,4 +150,3 @@ export default class Transcription {
     this.webSocket.close();
   }
 }
-

package/test/integration/spec/journey.js

@@ -364,7 +364,7 @@ skipInNode(describe)('plugin-meetings', () => {
               stream: response[0]
             })
               .then(() => {
-                console.log('AUDIO ', alice.meeting.mediaProperties.peerConnection.audioTransceiver.sender.track);
+                console.log('AUDIO ', alice.meeting.mediaProperties.audioTrack);
                 assert.equal(alice.meeting.mediaProperties.audioTrack.id, response[0].getAudioTracks()[0].id);
                 assert.equal(alice.meeting.mediaProperties.videoTrack.id, oldVideoTrackId);
               })),

package/test/integration/spec/space-meeting.js

@@ -2,7 +2,6 @@
 import {assert} from '@webex/test-helper-chai';
 import {skipInNode, jenkinsOnly} from '@webex/test-helper-mocha';
 import {patterns} from '@webex/common';
-
 import MeetingInfoUtil from '@webex/plugin-meetings/src/meeting-info/utilv2';
 
 import CMR from '../../utils/cmr';
@@ -10,7 +9,7 @@ import testUtils from '../../utils/testUtils';
 
 require('dotenv').config();
 
-const webexTestUsers = require('../../utils/webex-test-users.js');
+const webexTestUsers = require('../../utils/webex-test-users');
 
 let userSet, alice, bob, chris, guest;
 

package/test/unit/spec/locus-info/infoUtils.js

@@ -1,6 +1,5 @@
 import {assert} from '@webex/test-helper-chai';
 import Sinon from 'sinon';
-
 import InfoUtils from '@webex/plugin-meetings/src/locus-info/infoUtils';
 
 
@@ -75,6 +74,23 @@ describe('plugin-meetings', () => {
           userDisplayHints: ['HINT_3', 'HINT_1', 'HINT_2', 'LOWER_SOMEONE_ELSES_HAND']
         });
       });
+
+      it('only adds datachannel url when present', () => {
+        assert.deepEqual(InfoUtils.parse({datachannelUrl: 'some url'}, []), {
+          coHost: {LOWER_SOMEONE_ELSES_HAND: true},
+          moderator: {LOWER_SOMEONE_ELSES_HAND: true},
+          datachannelUrl: 'some url',
+          policy: {},
+          userDisplayHints: []
+        });
+
+        assert.deepEqual(InfoUtils.parse({}, []), {
+          coHost: {LOWER_SOMEONE_ELSES_HAND: true},
+          moderator: {LOWER_SOMEONE_ELSES_HAND: true},
+          policy: {},
+          userDisplayHints: []
+        });
+      });
     });
 
     describe('parseDisplayHintsSection', () => {