@webex/plugin-meetings 2.60.1-next.9 → 2.60.2

package/src/meetings/index.ts

@@ -1,17 +1,13 @@
 /* eslint no-shadow: ["error", { "allow": ["eventType"] }] */
 
 import '@webex/internal-plugin-mercury';
-import '@webex/internal-plugin-conversation';
-import '@webex/internal-plugin-metrics';
 // @ts-ignore
 import {WebexPlugin} from '@webex/webex-core';
-import {setLogger} from '@webex/internal-media-core';
-
-import * as mediaHelpersModule from '@webex/media-helpers';
 
 import 'webrtc-adapter';
 
 import Metrics from '../metrics';
+import {trigger, eventType} from '../metrics/config';
 import LoggerConfig from '../common/logs/logger-config';
 import StaticConfig from '../common/config';
 import LoggerProxy from '../common/logs/logger-proxy';
@@ -42,14 +38,11 @@ import {
   MEETING_REMOVED_REASON,
   _CONVERSATION_URL_,
   CONVERSATION_URL,
-  MEETINGNUMBER,
-  _JOINED_,
-  _MOVED_,
 } from '../constants';
 import BEHAVIORAL_METRICS from '../metrics/constants';
 import MeetingInfo from '../meeting-info';
 import MeetingInfoV2 from '../meeting-info/meeting-info-v2';
-import Meeting, {CallStateForMetrics} from '../meeting';
+import Meeting from '../meeting';
 import PersonalMeetingRoom from '../personal-meeting-room';
 import Reachability from '../reachability';
 import Request from './request';
@@ -58,38 +51,7 @@ import CaptchaError from '../common/errors/captcha-error';
 
 import MeetingCollection from './collection';
 import MeetingsUtil from './util';
-import PermissionError from '../common/errors/permission';
-import {INoiseReductionEffect, IVirtualBackgroundEffect} from './meetings.types';
-import {SpaceIDDeprecatedError} from '../common/errors/webex-errors';
-import NoMeetingInfoError from '../common/errors/no-meeting-info';
-
-let mediaLogger;
-
-class MediaLogger {
-  info(...args) {
-    LoggerProxy.logger.info(...args);
-  }
-
-  log(...args) {
-    LoggerProxy.logger.log(...args);
-  }
-
-  error(...args) {
-    LoggerProxy.logger.error(...args);
-  }
-
-  warn(...args) {
-    LoggerProxy.logger.warn(...args);
-  }
 
-  trace(...args) {
-    LoggerProxy.logger.trace(...args);
-  }
-
-  debug(...args) {
-    LoggerProxy.logger.debug(...args);
-  }
-}
 /**
  * Meetings Ready Event
  * Emitted when the meetings instance on webex is ready
@@ -148,13 +110,12 @@ export default class Meetings extends WebexPlugin {
   meetingCollection: any;
   personalMeetingRoom: any;
   preferredWebexSite: any;
-  reachability: Reachability;
+  reachability: any;
   registered: any;
   request: any;
   geoHintInfo: any;
   meetingInfo: any;
-  mediaHelpers: any;
-  breakoutLocusForHandleLater: any;
+
   namespace = MEETINGS;
 
   /**
@@ -166,17 +127,6 @@ export default class Meetings extends WebexPlugin {
   constructor(...args) {
     super(...args);
 
-    /**
-     * The webrtc-core media helpers. This is a temporary solution required for the SDK sample app
-     * to be able to call media helper functions.
-     *
-     * @instance
-     * @type {Object}
-     * @private
-     * @memberof Meetings
-     */
-    this.mediaHelpers = mediaHelpersModule;
-
     /**
      * The Meetings request to interact with server
      * @instance
@@ -204,17 +154,15 @@ export default class Meetings extends WebexPlugin {
      * @memberof Meetings
      */
     this.personalMeetingRoom = null;
-
     /**
-     * The Reachability object to interact with server
+     * The Reachability object to interact with server, starts as null until {@link Meeting#setReachability} is called
      * starts as null
      * @instance
      * @type {Object}
      * @private
      * @memberof Meetings
      */
-    // @ts-ignore
-    this.reachability = new Reachability(this.webex);
+    this.reachability = null;
 
     /**
      * If the meetings plugin has been registered and listening via {@link Meetings#register}
@@ -244,137 +192,30 @@ export default class Meetings extends WebexPlugin {
      */
     this.media = {
       getUserMedia: Media.getUserMedia,
+      getSupportedDevice: Media.getSupportedDevice,
     };
 
     this.onReady();
   }
 
   /**
-   * check whether you need to handle this main session's locus data or not
-   * @param {Object} meeting current meeting data
-   * @param {Object} newLocus new locus data
-   * @returns {boolean}
-   * @private
-   * @memberof Meetings
-   */
-  private isNeedHandleMainLocus(meeting: any, newLocus: any) {
-    const breakoutUrl = newLocus.controls?.breakout?.url;
-    const breakoutLocus = this.meetingCollection.getActiveBreakoutLocus(breakoutUrl);
-
-    const isSelfJoined = newLocus?.self?.state === _JOINED_;
-    const isSelfMoved = newLocus?.self?.state === _LEFT_ && newLocus?.self?.reason === _MOVED_;
-    // @ts-ignore
-    const deviceFromNewLocus = MeetingsUtil.getThisDevice(newLocus, this.webex.internal.device.url);
-    const isResourceMovedOnThisDevice =
-      deviceFromNewLocus?.state === _LEFT_ && deviceFromNewLocus?.reason === _MOVED_;
-
-    const isNewLocusJoinThisDevice = MeetingsUtil.joinedOnThisDevice(
-      meeting,
-      newLocus,
-      // @ts-ignore
-      this.webex.internal.device.url
-    );
-    const isBreakoutLocusJoinThisDevice =
-      breakoutLocus?.joinedWith?.correlationId &&
-      breakoutLocus.joinedWith.correlationId === meeting?.correlationId;
-
-    if (isSelfJoined && isNewLocusJoinThisDevice) {
-      LoggerProxy.logger.log(
-        'Meetings:index#isNeedHandleMainLocus --> self this device shown as JOINED in the main session'
-      );
-      if (breakoutLocus?.joinedWith && deviceFromNewLocus) {
-        const breakoutReplaceAt =
-          breakoutLocus.joinedWith.replaces?.length > 0
-            ? breakoutLocus.joinedWith.replaces[0].replaceAt
-            : '';
-        const newLocusReplaceAt =
-          deviceFromNewLocus.replaces?.length > 0 ? deviceFromNewLocus.replaces[0].replaceAt : '';
-        if (breakoutReplaceAt && newLocusReplaceAt && breakoutReplaceAt > newLocusReplaceAt) {
-          LoggerProxy.logger.log(
-            `Meetings:index#isNeedHandleMainLocus --> this is expired main joined status locus_dto replacedAt ${newLocusReplaceAt} bo replacedAt ${breakoutReplaceAt}`
-          );
-
-          return false;
-        }
-      }
-
-      return true;
-    }
-    if (isBreakoutLocusJoinThisDevice) {
-      LoggerProxy.logger.log(
-        `Meetings:index#isNeedHandleMainLocus --> there is active breakout session and joined on this device, and don't need to handle main session: ${breakoutUrl}`
-      );
-
-      return false;
-    }
-    if (isSelfMoved && (newLocus?.self?.removed || isResourceMovedOnThisDevice)) {
-      LoggerProxy.logger.log(
-        'Meetings:index#isNeedHandleMainLocus --> self moved main locus with self removed status or with device resource moved, not need to handle'
-      );
-
-      return false;
-    }
-    if (isSelfJoined && isResourceMovedOnThisDevice) {
-      LoggerProxy.logger.log(
-        'Meetings:index#isNeedHandleMainLocus --> self device left&moved in main locus with self joined status, not need to handle'
-      );
-
-      return false;
-    }
-    LoggerProxy.logger.log(
-      'Meetings:index#isNeedHandleMainLocus --> this is a normal main session locusDTO update case'
-    );
-
-    return true;
-  }
-
-  /**
-   * check whether you need to handle this locus data or not
-   * @param {Object} meeting old locus data
-   * @param {Object} newLocus new locus data
-   * @returns {boolean}
-   * @private
-   * @memberof Meetings
-   */
-  private isNeedHandleLocusDTO(meeting: any, newLocus: any) {
-    if (newLocus) {
-      const isNewLocusAsBreakout = MeetingsUtil.isBreakoutLocusDTO(newLocus);
-      const isSelfMoved = newLocus?.self?.state === _LEFT_ && newLocus?.self?.reason === _MOVED_;
-      if (!meeting) {
-        if (isNewLocusAsBreakout) {
-          LoggerProxy.logger.log(
-            `Meetings:index#isNeedHandleLocusDTO --> the first breakout session locusDTO active status: ${newLocus.fullState?.active}`
-          );
-
-          return newLocus.self?.state === _JOINED_;
-        }
-
-        return this.isNeedHandleMainLocus(meeting, newLocus);
-      }
-      if (!isNewLocusAsBreakout) {
-        return this.isNeedHandleMainLocus(meeting, newLocus);
-      }
-
-      return !isSelfMoved;
-    }
-
-    return true;
-  }
-
-  /**
-   * get corresponding meeting object by locus data
+   * handle locus events and takes meeting actions with them as they come in
    * @param {Object} data a locus event
    * @param {String} data.locusUrl
    * @param {Object} data.locus
-   * @returns {Object}
+   * @param {Boolean} useRandomDelayForInfo whether a random delay should be added to fetching meeting info
+   * @param {String} data.eventType
+   * @returns {undefined}
    * @private
    * @memberof Meetings
    */
-  getCorrespondingMeetingByLocus(data) {
+  private handleLocusEvent(data: {locusUrl: string; locus: any}, useRandomDelayForInfo = false) {
+    let meeting = null;
+
     // getting meeting by correlationId. This will happen for the new event
     // Either the locus
     // TODO : Add check for the callBack Address
-    return (
+    meeting =
       this.meetingCollection.getByKey(LOCUS_URL, data.locusUrl) ||
       // @ts-ignore
       this.meetingCollection.getByKey(
@@ -390,24 +231,7 @@ export default class Meetings extends WebexPlugin {
       ) ||
       (data.locus.info?.isUnifiedSpaceMeeting
         ? undefined
-        : this.meetingCollection.getByKey(CONVERSATION_URL, data.locus.conversationUrl)) ||
-      this.meetingCollection.getByKey(MEETINGNUMBER, data.locus?.info?.webExMeetingId)
-    );
-  }
-
-  /**
-   * handle locus events and takes meeting actions with them as they come in
-   * @param {Object} data a locus event
-   * @param {String} data.locusUrl
-   * @param {Object} data.locus
-   * @param {Boolean} useRandomDelayForInfo whether a random delay should be added to fetching meeting info
-   * @param {String} data.eventType
-   * @returns {undefined}
-   * @private
-   * @memberof Meetings
-   */
-  private handleLocusEvent(data: {locusUrl: string; locus: any}, useRandomDelayForInfo = false) {
-    let meeting = this.getCorrespondingMeetingByLocus(data);
+        : this.meetingCollection.getByKey(CONVERSATION_URL, data.locus.conversationUrl));
 
     // Special case when locus has got replaced, This only happend once if a replace locus exists
     // https://sqbu-github.cisco.com/WebExSquared/locus/wiki/Locus-changing-mid-call
@@ -420,16 +244,6 @@ export default class Meetings extends WebexPlugin {
       );
     }
 
-    if (meeting && !MeetingsUtil.isBreakoutLocusDTO(data.locus)) {
-      meeting.locusInfo.updateMainSessionLocusCache(data.locus);
-    }
-    if (!this.isNeedHandleLocusDTO(meeting, data.locus)) {
-      LoggerProxy.logger.log(
-        `Meetings:index#handleLocusEvent --> doesn't need to process locus event`
-      );
-
-      return;
-    }
     if (!meeting) {
       // TODO: create meeting when we get a meeting object
       // const checkForEnded = (locus) => {
@@ -486,7 +300,6 @@ export default class Meetings extends WebexPlugin {
 
           // It's a new meeting so initialize the locus data
           meeting.locusInfo.initialSetup(data.locus);
-          this.checkHandleBreakoutLocus(data.locus);
         })
         .catch((e) => {
           LoggerProxy.logger.error(e);
@@ -496,15 +309,10 @@ export default class Meetings extends WebexPlugin {
           // because the other user left so before sending 'added' event make sure it exists in the collection
 
           if (this.getMeetingByType(_ID_, meeting.id)) {
-            // @ts-ignore
-            this.webex.internal.newMetrics.submitClientEvent({
-              name: 'client.call.remote-started',
-              payload: {
-                trigger: 'mercury-event',
-              },
-              options: {
-                meetingId: meeting.id,
-              },
+            Metrics.postEvent({
+              event: eventType.REMOTE_STARTED,
+              meeting,
+              data: {trigger: trigger.MERCURY_EVENT},
             });
             Trigger.trigger(
               this,
@@ -584,7 +392,7 @@ export default class Meetings extends WebexPlugin {
 
     // @ts-ignore
     this.webex.internal.mercury.on(ONLINE, () => {
-      this.syncMeetings({keepOnlyLocusMeetings: false});
+      this.syncMeetings();
     });
 
     // @ts-ignore
@@ -623,9 +431,6 @@ export default class Meetings extends WebexPlugin {
       // @ts-ignore
       LoggerProxy.set(this.webex.logger);
 
-      mediaLogger = new MediaLogger();
-      setLogger(mediaLogger);
-
       /**
        * The MeetingInfo object to interact with server
        * @instance
@@ -657,7 +462,7 @@ export default class Meetings extends WebexPlugin {
 
       MeetingsUtil.checkH264Support({disableNotifications: true});
       // @ts-ignore
-      Metrics.initialSetup(this.webex);
+      Metrics.initialSetup(this.meetingCollection, this.webex);
     });
   }
 
@@ -682,38 +487,35 @@ export default class Meetings extends WebexPlugin {
   }
 
   /**
-   * API to toggle starting adhoc meeting
-   * @param {Boolean} changeState
+   * API to enable or disable TURN discovery
+   * @param {Boolean} enable
    * @private
    * @memberof Meetings
    * @returns {undefined}
    */
-  private _toggleAdhocMeetings(changeState: boolean) {
-    if (typeof changeState !== 'boolean') {
+  private _toggleTurnDiscovery(enable: boolean) {
+    if (typeof enable !== 'boolean') {
       return;
     }
     // @ts-ignore
-    if (this.config?.experimental?.enableAdhocMeetings !== changeState) {
-      // @ts-ignore
-      this.config.experimental.enableAdhocMeetings = changeState;
-    }
+    this.config.experimental.enableTurnDiscovery = enable;
   }
 
   /**
-   * API to toggle TCP reachability, needs to be called before webex.meetings.register()
-   * @param {Boolean} newValue
+   * API to toggle starting adhoc meeting
+   * @param {Boolean} changeState
    * @private
    * @memberof Meetings
    * @returns {undefined}
    */
-  private _toggleTcpReachability(newValue: boolean) {
-    if (typeof newValue !== 'boolean') {
+  private _toggleAdhocMeetings(changeState: boolean) {
+    if (typeof changeState !== 'boolean') {
       return;
     }
     // @ts-ignore
-    if (this.config.experimental.enableTcpReachability !== newValue) {
+    if (this.config?.experimental?.enableAdhocMeetings !== changeState) {
       // @ts-ignore
-      this.config.experimental.enableTcpReachability = newValue;
+      this.config.experimental.enableAdhocMeetings = changeState;
     }
   }
 
@@ -829,36 +631,6 @@ export default class Meetings extends WebexPlugin {
     );
   }
 
-  /**
-   * Creates a noise reduction effect
-   *
-   * @param {INoiseReductionEffect} options optional custom effect options
-   * @returns {Promise<effect>} noise reduction effect.
-   * @public
-   * @memberof Meetings
-   */
-  createNoiseReductionEffect = async (options?: INoiseReductionEffect) => {
-    // @ts-ignore
-    const authToken = this.webex.credentials.supertoken.access_token;
-
-    return new mediaHelpersModule.NoiseReductionEffect({authToken, ...options});
-  };
-
-  /**
-   * Creates a virtual background effect
-   *
-   * @param {IVirtualBackgroundEffect} options optional custom effect options
-   * @returns {Promise<effect>} virtual background effect.
-   * @public
-   * @memberof Meetings
-   */
-  createVirtualBackgroundEffect = async (options?: IVirtualBackgroundEffect) => {
-    // @ts-ignore
-    const authToken = this.webex.credentials.supertoken.access_token;
-
-    return new mediaHelpersModule.VirtualBackgroundEffect({authToken, ...options});
-  };
-
   /**
    * Uploads logs to the webex services for tracking
    * @param {Object} [options={}]
@@ -873,10 +645,8 @@ export default class Meetings extends WebexPlugin {
    */
   uploadLogs(
     options: {
-      autoupload?: boolean;
       callStart?: string;
       feedbackId?: string;
-      locussessionid?: string;
       locusId?: string;
       correlationId?: string;
       meetingId?: string;
@@ -893,7 +663,6 @@ export default class Meetings extends WebexPlugin {
           'Meetings:index#uploadLogs --> Upload logs for meeting completed.',
           uploadResult
         );
-        Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.UPLOAD_LOGS_SUCCESS, options);
         Trigger.trigger(
           this,
           {
@@ -928,7 +697,8 @@ export default class Meetings extends WebexPlugin {
         );
 
         Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.UPLOAD_LOGS_FAILURE, {
-          ...options,
+          // @ts-ignore - seems like typo
+          meetingId: options.meetingsId,
           reason: uploadError.message,
           stack: uploadError.stack,
           code: uploadError.code,
@@ -936,6 +706,17 @@ export default class Meetings extends WebexPlugin {
       });
   }
 
+  /**
+   * initializes the reachability instance for Meetings
+   * @returns {undefined}
+   * @public
+   * @memberof Meetings
+   */
+  setReachability() {
+    // @ts-ignore
+    this.reachability = new Reachability(this.webex);
+  }
+
   /**
    * gets the reachability instance for Meetings
    * @returns {Reachability}
@@ -953,6 +734,10 @@ export default class Meetings extends WebexPlugin {
    * @memberof Meetings
    */
   startReachability() {
+    if (!this.reachability) {
+      this.setReachability();
+    }
+
     return this.getReachability().gatherReachability();
   }
 
@@ -976,30 +761,15 @@ export default class Meetings extends WebexPlugin {
    * @memberof Meetings
    */
   fetchUserPreferredWebexSite() {
-    return this.request.getMeetingPreferences().then((res) => {
-      if (res) {
-        this.preferredWebexSite = MeetingsUtil.parseDefaultSiteFromMeetingPreferences(res);
-      }
-
-      // fall back to getting the preferred site from the user information
-      if (!this.preferredWebexSite) {
-        // @ts-ignore
-        return this.webex.internal.user
-          .get()
-          .then((user) => {
-            const preferredWebexSite =
-              user?.userPreferences?.userPreferencesItems?.preferredWebExSite;
-            if (preferredWebexSite) {
-              this.preferredWebexSite = preferredWebexSite;
-            } else {
-              throw new Error('site not found');
-            }
-          })
-          .catch(() => {
-            LoggerProxy.logger.error(
-              'Failed to fetch preferred site from user - no site will be set'
-            );
-          });
+    // @ts-ignore
+    return this.webex.people._getMe().then((me) => {
+      const isGuestUser = me.type === 'appuser';
+      if (!isGuestUser) {
+        return this.request.getMeetingPreferences().then((res) => {
+          if (res) {
+            this.preferredWebexSite = MeetingsUtil.parseDefaultSiteFromMeetingPreferences(res);
+          }
+        });
       }
 
       return Promise.resolve();
@@ -1012,7 +782,6 @@ export default class Meetings extends WebexPlugin {
    * @public
    * @memberof Meetings
    */
-
   getPersonalMeetingRoom() {
     return this.personalMeetingRoom;
   }
@@ -1043,55 +812,29 @@ export default class Meetings extends WebexPlugin {
   }
 
   /**
-   * Create a meeting or return an existing meeting.
-   *
-   * When meeting info passed it should be complete, e.g.: fetched after password or captcha provided
-   *
-   * @param {string} destination - sipURL, phonenumber, or locus object}
+   * Create a meeting.
+   * @param {string} destination - sipURL, spaceId, phonenumber, or locus object}
    * @param {string} [type] - the optional specified type, such as locusId
    * @param {Boolean} useRandomDelayForInfo - whether a random delay should be added to fetching meeting info
-   * @param {Object} infoExtraParams extra parameters to be provided when fetching meeting info
-   * @param {string} correlationId - the optional specified correlationId (callStateForMetrics.correlationId can be provided instead)
-   * @param {Boolean} failOnMissingMeetingInfo - whether to throw an error if meeting info fails to fetch (for calls that are not 1:1 or content share)
-   * @param {CallStateForMetrics} callStateForMetrics - information about call state for metrics
-   * @param {Object} [meetingInfo] - Pre-fetched complete meeting info
-   * @param {String} [meetingLookupUrl] - meeting info prefetch url
    * @returns {Promise<Meeting>} A new Meeting.
    * @public
    * @memberof Meetings
    */
-  public create(
-    destination: string,
-    type: string = null,
-    useRandomDelayForInfo = false,
-    infoExtraParams = {},
-    correlationId: string = undefined,
-    failOnMissingMeetingInfo = false,
-    callStateForMetrics: CallStateForMetrics = undefined,
-    meetingInfo = undefined,
-    meetingLookupUrl = undefined
-  ) {
+  public create(destination: string, type: string = null, useRandomDelayForInfo = false) {
     // TODO: type should be from a dictionary
 
     // Validate meeting information based on the provided destination and
     // type. This must be performed prior to determining if the meeting is
     // found in the collection, as we mutate the destination for hydra person
     // id values.
-    if (correlationId) {
-      callStateForMetrics = {...(callStateForMetrics || {}), correlationId};
-    }
-
     return (
       this.meetingInfo
         .fetchInfoOptions(destination, type)
         // Catch a failure to fetch info options.
         .catch((error) => {
-          LoggerProxy.logger.error(
-            `Meetings:index#create --> ERROR, unable to determine info options: ${error.message}`
+          LoggerProxy.logger.info(
+            `Meetings:index#create --> INFO, unable to determine info options: ${error.message}`
           );
-          if (error instanceof SpaceIDDeprecatedError) {
-            throw new SpaceIDDeprecatedError();
-          }
         })
         .then((options: any = {}) => {
           // Normalize the destination.
@@ -1122,61 +865,49 @@ export default class Meetings extends WebexPlugin {
           // Validate if a meeting was found.
           if (!meeting) {
             // Create a meeting based on the normalized destination and type.
-            return this.createMeeting(
-              targetDest,
-              type,
-              useRandomDelayForInfo,
-              infoExtraParams,
-              callStateForMetrics,
-              failOnMissingMeetingInfo,
-              meetingInfo,
-              meetingLookupUrl
-            ).then((createdMeeting: any) => {
-              // If the meeting was successfully created.
-              if (createdMeeting && createdMeeting.on) {
-                // Create a destruction event for the meeting.
-                createdMeeting.on(EVENTS.DESTROY_MEETING, (payload) => {
-                  // @ts-ignore
-                  if (this.config.autoUploadLogs) {
-                    this.uploadLogs({
-                      callStart: createdMeeting.locusInfo?.fullState?.lastActive,
-                      locussessionid: createdMeeting.locusInfo?.fullState?.sessionId,
-                      correlationId: createdMeeting.correlationId,
-                      feedbackId: createdMeeting.correlationId,
-                      locusId: createdMeeting.locusId,
-                      meetingId: createdMeeting.locusInfo?.info?.webExMeetingId,
-                      autoupload: true,
-                    }).then(() => this.destroy(createdMeeting, payload.reason));
-                  } else {
-                    this.destroy(createdMeeting, payload.reason);
-                  }
-                });
-
-                createdMeeting.on(EVENTS.REQUEST_UPLOAD_LOGS, (meetingInstance) => {
-                  // @ts-ignore
-                  if (this.config.autoUploadLogs) {
-                    this.uploadLogs({
-                      callStart: meetingInstance?.locusInfo?.fullState?.lastActive,
-                      locussessionid: meetingInstance?.locusInfo?.fullState?.sessionId,
-                      correlationId: meetingInstance.correlationId,
-                      feedbackId: meetingInstance.correlationId,
-                      locusId: meetingInstance.locusId,
-                      meetingId: meetingInstance.locusInfo?.info?.webExMeetingId,
-                      autoupload: true,
-                    });
-                  }
-                });
-              } else {
-                LoggerProxy.logger.error(
-                  `Meetings:index#create --> ERROR, meeting does not have on method, will not be destroyed, meeting cleanup impossible for meeting: ${meeting}`
-                );
+            return this.createMeeting(targetDest, type, useRandomDelayForInfo).then(
+              (createdMeeting: any) => {
+                // If the meeting was successfully created.
+                if (createdMeeting && createdMeeting.on) {
+                  // Create a destruction event for the meeting.
+                  createdMeeting.on(EVENTS.DESTROY_MEETING, (payload) => {
+                    // @ts-ignore
+                    if (this.config.autoUploadLogs) {
+                      this.uploadLogs({
+                        callStart: createdMeeting.locusInfo?.fullState?.lastActive,
+                        correlationId: createdMeeting.correlationId,
+                        feedbackId: createdMeeting.correlationId,
+                        locusId: createdMeeting.locusId,
+                        meetingId: createdMeeting.locusInfo?.info?.webExMeetingId,
+                      }).then(() => this.destroy(createdMeeting, payload.reason));
+                    } else {
+                      this.destroy(createdMeeting, payload.reason);
+                    }
+                  });
+
+                  createdMeeting.on(EVENTS.REQUEST_UPLOAD_LOGS, (meetingInstance) => {
+                    // @ts-ignore
+                    if (this.config.autoUploadLogs) {
+                      this.uploadLogs({
+                        callStart: meetingInstance?.locusInfo?.fullState?.lastActive,
+                        correlationId: meetingInstance.correlationId,
+                        feedbackId: meetingInstance.correlationId,
+                        locusId: meetingInstance.locusId,
+                        meetingId: meetingInstance.locusInfo?.info?.webExMeetingId,
+                      });
+                    }
+                  });
+                } else {
+                  LoggerProxy.logger.error(
+                    `Meetings:index#create --> ERROR, meeting does not have on method, will not be destroyed, meeting cleanup impossible for meeting: ${meeting}`
+                  );
+                }
+
+                // Return the newly created meeting.
+                return Promise.resolve(createdMeeting);
               }
-
-              // Return the newly created meeting.
-              return Promise.resolve(createdMeeting);
-            });
+            );
           }
-          meeting.setCallStateForMetrics(callStateForMetrics);
 
           // Return the existing meeting.
           return Promise.resolve(meeting);
@@ -1185,18 +916,9 @@ export default class Meetings extends WebexPlugin {
   }
 
   /**
-   * Create meeting
-   *
-   * When meeting info passed it should be complete, e.g.: fetched after password or captcha provided
-   *
    * @param {String} destination see create()
    * @param {String} type see create()
    * @param {Boolean} useRandomDelayForInfo whether a random delay should be added to fetching meeting info
-   * @param {Object} infoExtraParams extra parameters to be provided when fetching meeting info
-   * @param {CallStateForMetrics} callStateForMetrics - information about call state for metrics
-   * @param {Boolean} failOnMissingMeetingInfo - whether to throw an error if meeting info fails to fetch (for calls that are not 1:1 or content share)
-   * @param {Object} [meetingInfo] - Pre-fetched complete meeting info
-   * @param {String} [meetingLookupUrl] - meeting info prefetch url
    * @returns {Promise} a new meeting instance complete with meeting info and destination
    * @private
    * @memberof Meetings
@@ -1204,12 +926,7 @@ export default class Meetings extends WebexPlugin {
   private async createMeeting(
     destination: any,
     type: string = null,
-    useRandomDelayForInfo = false,
-    infoExtraParams = {},
-    callStateForMetrics: CallStateForMetrics = undefined,
-    failOnMissingMeetingInfo = false,
-    meetingInfo = undefined,
-    meetingLookupUrl = undefined
+    useRandomDelayForInfo = false
   ) {
     const meeting = new Meeting(
       {
@@ -1219,11 +936,11 @@ export default class Meetings extends WebexPlugin {
         deviceUrl: this.webex.internal.device.url,
         // @ts-ignore
         orgId: this.webex.internal.device.orgId,
+        roapSeq: 0,
         locus: type === _LOCUS_ID_ ? destination : null, // pass the locus object if present
         meetingInfoProvider: this.meetingInfo,
         destination,
         destinationType: type,
-        callStateForMetrics,
       },
       {
         // @ts-ignore
@@ -1255,45 +972,22 @@ export default class Meetings extends WebexPlugin {
       const isMeetingActive = !!destination.fullState?.active;
       // @ts-ignore
       const {enableUnifiedMeetings} = this.config.experimental;
-      const meetingInfoOptions = {
-        extraParams: infoExtraParams,
-        sendCAevents: !!callStateForMetrics?.correlationId, // if client sends correlation id as argument of public create(), then it means that this meeting creation is part of a pre-join intent from user
-      };
-
-      if (meetingInfo) {
-        meeting.injectMeetingInfo(meetingInfo, meetingInfoOptions, meetingLookupUrl);
-      } else if (
-        enableUnifiedMeetings &&
-        !isMeetingActive &&
-        useRandomDelayForInfo &&
-        waitingTime > 0
-      ) {
+
+      if (enableUnifiedMeetings && !isMeetingActive && useRandomDelayForInfo && waitingTime > 0) {
         meeting.fetchMeetingInfoTimeoutId = setTimeout(
-          () => meeting.fetchMeetingInfo(meetingInfoOptions),
+          () => meeting.fetchMeetingInfo({}),
           waitingTime
         );
         meeting.parseMeetingInfo(undefined, destination);
       } else {
-        await meeting.fetchMeetingInfo(meetingInfoOptions);
+        await meeting.fetchMeetingInfo({});
       }
     } catch (err) {
-      if (
-        !(err instanceof CaptchaError) &&
-        !(err instanceof PasswordError) &&
-        !(err instanceof PermissionError)
-      ) {
+      if (!(err instanceof CaptchaError) && !(err instanceof PasswordError)) {
+        // if there is no meeting info we assume its a 1:1 call or wireless share
         LoggerProxy.logger.info(
           `Meetings:index#createMeeting --> Info Unable to fetch meeting info for ${destination}.`
         );
-        if (failOnMissingMeetingInfo) {
-          LoggerProxy.logger.info(
-            `Meetings:index#createMeeting --> Destroying meeting due to missing meeting info.`
-          );
-          // @ts-ignore
-          this.destroy(meeting, MEETING_REMOVED_REASON.MISSING_MEETING_INFO);
-          throw new NoMeetingInfoError();
-        }
-        // if there is no meeting info and no error should be thrown then we assume its a 1:1 call or wireless share
         LoggerProxy.logger.info(
           'Meetings:index#createMeeting --> Info assuming this destination is a 1:1 or wireless share'
         );
@@ -1346,7 +1040,7 @@ export default class Meetings extends WebexPlugin {
     //
     // Our job is to determine the appropriate one
     // and its corresponding service so that developers
-    // need only sipURL to get a meeting
+    // need only sipURL or spaceID to get a meeting
     // and its ID, but have the option to use createWithType()
     // and specify those types to get meetingInfo
   }
@@ -1385,116 +1079,38 @@ export default class Meetings extends WebexPlugin {
 
   /**
    * syncs all the meeting from server
-   * @param {boolean} keepOnlyLocusMeetings - whether the sync should keep only locus meetings or any other meeting in meetingCollection
-   * @returns {Promise<void>}
+   * @returns {undefined}
    * @public
    * @memberof Meetings
    */
-  public syncMeetings({keepOnlyLocusMeetings = true} = {}): Promise<void> {
-    return this.request
-      .getActiveMeetings()
-      .then((locusArray) => {
-        const activeLocusUrl = [];
-
-        if (locusArray?.loci && locusArray.loci.length > 0) {
-          const lociToUpdate = this.sortLocusArrayToUpdate(locusArray.loci);
-          lociToUpdate.forEach((locus) => {
-            activeLocusUrl.push(locus.url);
-            this.handleLocusEvent({
-              locus,
-              locusUrl: locus.url,
-            });
+  public syncMeetings() {
+    return this.request.getActiveMeetings().then((locusArray) => {
+      const activeLocusUrl = [];
+
+      if (locusArray?.loci && locusArray.loci.length > 0) {
+        locusArray.loci.forEach((locus) => {
+          activeLocusUrl.push(locus.url);
+          this.handleLocusEvent({
+            locus,
+            locusUrl: locus.url,
           });
-        }
-        const meetingsCollection = this.meetingCollection.getAll();
+        });
+      }
+      const meetingsCollection = this.meetingCollection.getAll();
 
-        if (Object.keys(meetingsCollection).length > 0) {
-          // Sometimes the mercury events are lost after mercury reconnect
-          // Remove any Locus meetings that are not returned by Locus
-          // (they had a locusUrl previously but are no longer active) in the sync
-          for (const meeting of Object.values(meetingsCollection)) {
+      if (Object.keys(meetingsCollection).length > 0) {
+        // Some time the mercury event is missed after mercury reconnect
+        // if sync returns no locus then clear all the meetings
+        for (const meeting of Object.values(meetingsCollection)) {
+          // @ts-ignore
+          if (!activeLocusUrl.includes(meeting.locusUrl)) {
+            // destroy function also uploads logs
             // @ts-ignore
-            const {locusUrl} = meeting;
-            if ((keepOnlyLocusMeetings || locusUrl) && !activeLocusUrl.includes(locusUrl)) {
-              // destroy function also uploads logs
-              // @ts-ignore
-              this.destroy(meeting, MEETING_REMOVED_REASON.NO_MEETINGS_TO_SYNC);
-            }
+            this.destroy(meeting, MEETING_REMOVED_REASON.NO_MEETINGS_TO_SYNC);
           }
         }
-      })
-      .catch((error) => {
-        LoggerProxy.logger.error(
-          `Meetings:index#syncMeetings --> failed to sync meetings, ${error}`
-        );
-        throw new Error(error);
-      });
-  }
-
-  /**
-   * sort out locus array for initial creating
-   * @param {Array} loci original locus array
-   * @returns {undefined}
-   * @public
-   * @memberof Meetings
-   */
-  sortLocusArrayToUpdate(loci: any[]) {
-    const mainLoci = loci.filter((locus) => !MeetingsUtil.isBreakoutLocusDTO(locus));
-    const breakoutLoci = loci.filter((locus) => MeetingsUtil.isValidBreakoutLocus(locus));
-    this.breakoutLocusForHandleLater = [];
-    const lociToUpdate = [...mainLoci];
-    breakoutLoci.forEach((breakoutLocus) => {
-      const associateMainLocus = mainLoci.find(
-        (mainLocus) => mainLocus.controls?.breakout?.url === breakoutLocus.controls?.breakout?.url
-      );
-      const existCorrespondingMeeting = this.getCorrespondingMeetingByLocus({
-        locus: breakoutLocus,
-        locusUrl: breakoutLocus.url,
-      });
-
-      if (associateMainLocus && !existCorrespondingMeeting) {
-        // if exists both main session and breakout session locus of the same non-exist meeting, handle main locus first,
-        // after meeting create with main locus, then handle the associate breakout locus.
-        // if only handle breakout locus, will miss some date
-        this.breakoutLocusForHandleLater.push(breakoutLocus);
-      } else {
-        lociToUpdate.push(breakoutLocus);
       }
     });
-
-    return lociToUpdate;
-  }
-
-  /**
-   * check breakout locus which waiting for main locus's meeting to be created, then handle the breakout locus
-   * @param {Object} newCreatedLocus the locus which just create meeting object of it
-   * @returns {undefined}
-   * @public
-   * @memberof Meetings
-   */
-  checkHandleBreakoutLocus(newCreatedLocus) {
-    if (
-      !newCreatedLocus ||
-      !this.breakoutLocusForHandleLater ||
-      !this.breakoutLocusForHandleLater.length
-    ) {
-      return;
-    }
-    if (MeetingsUtil.isBreakoutLocusDTO(newCreatedLocus)) {
-      return;
-    }
-    const existIndex = this.breakoutLocusForHandleLater.findIndex(
-      (breakoutLocus) =>
-        breakoutLocus.controls?.breakout?.url === newCreatedLocus.controls?.breakout?.url
-    );
-
-    if (existIndex < 0) {
-      return;
-    }
-
-    const associateBreakoutLocus = this.breakoutLocusForHandleLater[existIndex];
-    this.handleLocusEvent({locus: associateBreakoutLocus, locusUrl: associateBreakoutLocus.url});
-    this.breakoutLocusForHandleLater.splice(existIndex, 1);
   }
 
   /**
@@ -1516,15 +1132,4 @@ export default class Meetings extends WebexPlugin {
   getLogger() {
     return LoggerProxy.get();
   }
-
-  /**
-   * Returns the first meeting it finds that has the webrtc media connection created.
-   * Useful for debugging in the console.
-   *
-   * @private
-   * @returns {Meeting} Meeting object that has a webrtc media connection, else undefined
-   */
-  getActiveWebrtcMeeting() {
-    return this.meetingCollection.getActiveWebrtcMeeting();
-  }
 }