@webex/plugin-meetings 2.60.1-next.9 → 2.60.2

package/test/unit/spec/reconnection-manager/index.js

@@ -2,8 +2,9 @@ import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';
-import ReconnectionManager from '@webex/plugin-meetings/src/reconnection-manager';
-import { RECONNECTION } from '../../../../src/constants';
+import Media from '@webex/plugin-meetings/src/media/index';
+
+import ReconnectionManager from '../../../../src/reconnection-manager';
 
 const {assert} = chai;
 
@@ -11,18 +12,10 @@ chai.use(chaiAsPromised);
 sinon.assert.expose(chai.assert, {prefix: ''});
 
 describe('plugin-meetings', () => {
-  describe('ReconnectionManager.reconnect', () => {
-    let fakeMediaConnection;
-    let fakeMeeting;
-
-    beforeEach(() => {
-      fakeMediaConnection = {
-        initiateOffer: sinon.stub().resolves({}),
-        reconnect: sinon.stub().resolves({}),
-      };
-      fakeMeeting = {
-        closePeerConnections: sinon.stub().resolves({}),
-        createMediaConnection: sinon.stub().returns(fakeMediaConnection),
+  describe('ReconnectionManager.reconnectMedia', () => {
+    it('uses correct TURN TLS information on reInitiatePeerconnection', async () => {
+      const fakeMeeting = {
+        setRemoteStream: sinon.stub().resolves({}),
         config: {
           reconnection: {
             enabled: true,
@@ -39,11 +32,8 @@ describe('plugin-meetings', () => {
         },
         mediaProperties: {
           unsetPeerConnection: sinon.stub(),
-          webrtcMediaConnection: fakeMediaConnection,
-        },
-        mediaRequestManagers: {
-          audio: {commit: sinon.stub(), clearPreviousRequests: sinon.stub()},
-          video: {commit: sinon.stub(), clearPreviousRequests: sinon.stub()},
+          reInitiatePeerconnection: sinon.stub().resolves({}),
+          peerConnection: sinon.stub(),
         },
         roap: {
           doTurnDiscovery: sinon.stub().resolves({
@@ -54,135 +44,45 @@ describe('plugin-meetings', () => {
             },
             turnDiscoverySkippedReason: undefined,
           }),
+          sendRoapMediaRequest: sinon.stub().resolves({}),
         },
         statsAnalyzer: {
-          updateMediaConnection: sinon.stub(),
+          updatePeerconnection: sinon.stub().returns(Promise.resolve()),
         },
         webex: {
-          credentials: {
-            isUnverifiedGuest: false,
-          },
           meetings: {
             getMeetingByType: sinon.stub().returns(true),
             syncMeetings: sinon.stub().resolves({}),
           },
-          internal: {
-            newMetrics: {
-              submitClientEvent: sinon.stub()
-            }
-          }
         },
       };
-    });
 
-    it('syncs meetings if it is not an unverified guest', async () => {
+      Media.attachMedia = sinon.stub().resolves({});
       const rm = new ReconnectionManager(fakeMeeting);
 
-      await rm.reconnect();
-
-      assert.calledOnce(rm.webex.meetings.syncMeetings);
-      assert.calledWith(rm.webex.meetings.syncMeetings, {keepOnlyLocusMeetings: false});
-    });
-
-    it('does not sync meetings if it is an unverified guest', async () => {
-      const rm = new ReconnectionManager(fakeMeeting);
-
-      rm.webex.credentials.isUnverifiedGuest = true;
-
-      await rm.reconnect();
-
-      assert.notCalled(rm.webex.meetings.syncMeetings);
-    });
-
-    it('uses correct TURN TLS information on the reconnection', async () => {
-      const rm = new ReconnectionManager(fakeMeeting);
+      rm.iceState.disconnected = true;
 
-      await rm.reconnect();
+      await rm.reconnectMedia();
 
       assert.calledOnce(fakeMeeting.roap.doTurnDiscovery);
-      assert.calledWith(fakeMeeting.roap.doTurnDiscovery, fakeMeeting, true, true);
-      assert.calledOnce(fakeMediaConnection.reconnect);
-      assert.calledWith(fakeMediaConnection.reconnect, [
-        {
-          urls: 'fake_turn_url',
-          username: 'fake_turn_username',
-          credential: 'fake_turn_password',
-        },
-      ]);
-
-      assert.calledWith(fakeMeeting.webex.internal.newMetrics.submitClientEvent, {
-        name: 'client.media.reconnecting',
-        options: {
-          meetingId: rm.meeting.id,
-        },
+      assert.calledOnce(fakeMeeting.mediaProperties.reInitiatePeerconnection);
+      assert.calledWith(fakeMeeting.mediaProperties.reInitiatePeerconnection, {
+        url: 'fake_turn_url',
+        username: 'fake_turn_username',
+        password: 'fake_turn_password',
       });
     });
-
-    it('does not clear previous requests and re-request media for non-multistream meetings', async () => {
-      fakeMeeting.isMultistream = false;
-      const rm = new ReconnectionManager(fakeMeeting);
-
-      await rm.reconnect();
-
-      assert.notCalled(fakeMeeting.mediaRequestManagers.audio.clearPreviousRequests);
-      assert.notCalled(fakeMeeting.mediaRequestManagers.video.clearPreviousRequests);
-      assert.notCalled(fakeMeeting.mediaRequestManagers.audio.commit);
-      assert.notCalled(fakeMeeting.mediaRequestManagers.video.commit);
-    });
-
-    it('does clear previous requests and re-request media for multistream meetings', async () => {
-      fakeMeeting.isMultistream = true;
-      const rm = new ReconnectionManager(fakeMeeting);
-
-      await rm.reconnect();
-
-      assert.calledOnce(fakeMeeting.mediaRequestManagers.audio.clearPreviousRequests);
-      assert.calledOnce(fakeMeeting.mediaRequestManagers.video.clearPreviousRequests);
-      assert.calledOnce(fakeMeeting.mediaRequestManagers.audio.commit);
-      assert.calledOnce(fakeMeeting.mediaRequestManagers.video.commit);
-    });
-
-
-    it('sends the correct client event when reconnection fails', async () => {
-      sinon.stub(ReconnectionManager.prototype, 'executeReconnection').rejects();
-      fakeMeeting.isMultistream = true;
-      const rm = new ReconnectionManager(fakeMeeting);
-
-      try {
-        await rm.reconnect();
-      } catch (err) {
-        assert.calledWith(fakeMeeting.webex.internal.newMetrics.submitClientEvent, {
-          name: 'client.call.aborted',
-          payload: {
-            errors: [
-              {
-                category: 'expected',
-                errorCode: 2008,
-                fatal: true,
-                name: 'media-engine',
-                shownToUser: false,
-              },
-            ],
-          },
-          options: {
-            meetingId: rm.meeting.id,
-          },
-        });
-      }
-    });
   });
-
   /**
    * Currently, testing dependent classes that aren't available at the top
    * level causes testing errors in CI based around related files. Skipping this here until a solution
    * to this problem is generated.
    */
-  describe('ReconnectionManager', () => {
+  describe.skip('ReconnectionManager', () => {
     let reconnectionManager;
-    let fakeMeeting;
 
     beforeEach(() => {
-      fakeMeeting = {
+      reconnectionManager = new ReconnectionManager({
         config: {
           reconnection: {
             enabled: true,
@@ -197,9 +97,7 @@ describe('plugin-meetings', () => {
             },
           },
         },
-      };
-
-      reconnectionManager = new ReconnectionManager(fakeMeeting);
+      });
     });
 
     describe('iceReconnected()', () => {
@@ -273,11 +171,10 @@ describe('plugin-meetings', () => {
           assert.isTrue(reconnectionManager.iceState.disconnected);
         });
 
-        it('should return a promise that rejects after a duration', (done) => {
+        it('should return a promise that rejects after a duration', () => {
           reconnectionManager.iceState.timeoutDuration = 100;
 
-          assert.isRejected(reconnectionManager.waitForIceReconnect());
-          done();
+          return assert.isRejected(reconnectionManager.waitForIceReconnect());
         });
 
         it('should resolve return a resolved promise when triggered', () => {
@@ -305,41 +202,5 @@ describe('plugin-meetings', () => {
         });
       });
     });
-
-    describe('setStatus()', () => {
-      beforeEach(() => {
-        reconnectionManager.status = RECONNECTION.STATE.DEFAULT_STATUS;
-      });
-
-      it('should correctly change status to in progress', () => {
-        reconnectionManager.setStatus(RECONNECTION.STATE.IN_PROGRESS);
-
-        assert.equal(reconnectionManager.status, RECONNECTION.STATE.IN_PROGRESS);
-      });
-
-      it('should correctly change status to complete', () => {
-        reconnectionManager.setStatus(RECONNECTION.STATE.COMPLETE);
-
-        assert.equal(reconnectionManager.status, RECONNECTION.STATE.COMPLETE);
-      });
-
-      it('should correctly change status to failure', () => {
-        reconnectionManager.setStatus(RECONNECTION.STATE.FAILURE);
-
-        assert.equal(reconnectionManager.status, RECONNECTION.STATE.FAILURE);
-      });
-    });
-
-    describe('cleanUp()', () => {
-      it('should call reset and keep reference to meeting object', () => {
-        const resetSpy = sinon.spy(reconnectionManager, 'reset');
-        assert.equal(reconnectionManager.meeting, fakeMeeting);
-
-        reconnectionManager.cleanUp();
-
-        assert.equal(reconnectionManager.meeting, fakeMeeting);
-        assert.calledOnce(reconnectionManager.reset);
-      });
-    });
   });
 });