@vibescope/mcp-server 0.1.0 → 0.2.1

package/src/handlers/validation.test.ts

@@ -309,7 +309,7 @@ describe('validateTask', () => {
 
 		await expect(
 			validateTask({ task_id: VALID_UUID }, ctx)
-		).rejects.toThrow('approved is required');
+		).rejects.toThrow('Missing required field: approved');
 	});
 
 	it('should throw error when task not found', async () => {
@@ -494,4 +494,56 @@ describe('validateTask', () => {
 			validateTask({ task_id: VALID_UUID, approved: false }, ctx)
 		).rejects.toThrow('Failed to validate task');
 	});
+
+	describe('PR requirement', () => {
+		it('should return error when PR is required but not present', async () => {
+			mockApiClient.validateTask.mockResolvedValue({
+				ok: false,
+				error: 'pr_required',
+				data: {
+					message: 'This project uses git-flow workflow which requires a Pull Request before validation approval.',
+					workflow: 'git-flow',
+				},
+			});
+			const ctx = createMockContext();
+
+			const result = await validateTask(
+				{ task_id: VALID_UUID, approved: true },
+				ctx
+			);
+
+			expect(result.result).toMatchObject({
+				error: 'pr_required',
+				workflow: 'git-flow',
+				action_required: expect.stringContaining('add_task_reference'),
+			});
+		});
+
+		it('should pass skip_pr_check to API', async () => {
+			mockApiClient.validateTask.mockResolvedValue({
+				ok: true,
+				data: {
+					success: true,
+					validated_task_id: VALID_UUID,
+					self_validated: false,
+				},
+			});
+			const ctx = createMockContext({ sessionId: 'validator-session' });
+
+			await validateTask(
+				{
+					task_id: VALID_UUID,
+					approved: true,
+					skip_pr_check: true,
+				},
+				ctx
+			);
+
+			expect(mockApiClient.validateTask).toHaveBeenCalledWith(
+				VALID_UUID,
+				{ approved: true, skip_pr_check: true },
+				'validator-session'
+			);
+		});
+	});
 });

package/src/handlers/validation.ts

@@ -8,14 +8,27 @@
  */
 
 import type { Handler, HandlerRegistry } from './types.js';
-import { validateRequired, validateUUID } from '../validators.js';
+import { parseArgs, uuidValidator } from '../validators.js';
 import { getApiClient } from '../api-client.js';
 
-export const getTasksAwaitingValidation: Handler = async (args, ctx) => {
-	const { project_id } = args as { project_id: string };
+// Argument schemas for type-safe parsing
+const getTasksAwaitingValidationSchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+};
+
+const claimValidationSchema = {
+	task_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+};
+
+const validateTaskSchema = {
+	task_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	approved: { type: 'boolean' as const, required: true as const },
+	validation_notes: { type: 'string' as const },
+	skip_pr_check: { type: 'boolean' as const },
+};
 
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
+export const getTasksAwaitingValidation: Handler = async (args, _ctx) => {
+	const { project_id } = parseArgs(args, getTasksAwaitingValidationSchema);
 
 	const apiClient = getApiClient();
 	const response = await apiClient.getTasksAwaitingValidation(project_id);
@@ -28,10 +41,7 @@ export const getTasksAwaitingValidation: Handler = async (args, ctx) => {
 };
 
 export const claimValidation: Handler = async (args, ctx) => {
-	const { task_id } = args as { task_id: string };
-
-	validateRequired(task_id, 'task_id');
-	validateUUID(task_id, 'task_id');
+	const { task_id } = parseArgs(args, claimValidationSchema);
 
 	const { session } = ctx;
 	const currentSessionId = session.currentSessionId;
@@ -47,18 +57,7 @@ export const claimValidation: Handler = async (args, ctx) => {
 };
 
 export const validateTask: Handler = async (args, ctx) => {
-	const { task_id, validation_notes, approved } = args as {
-		task_id: string;
-		validation_notes?: string;
-		approved: boolean;
-	};
-
-	validateRequired(task_id, 'task_id');
-	validateUUID(task_id, 'task_id');
-
-	if (approved === undefined) {
-		throw new Error('approved is required');
-	}
+	const { task_id, approved, validation_notes, skip_pr_check } = parseArgs(args, validateTaskSchema);
 
 	const { session } = ctx;
 	const currentSessionId = session.currentSessionId;
@@ -67,9 +66,21 @@ export const validateTask: Handler = async (args, ctx) => {
 	const response = await apiClient.validateTask(task_id, {
 		approved,
 		validation_notes,
+		skip_pr_check,
 	}, currentSessionId || undefined);
 
 	if (!response.ok) {
+		// Handle PR required error specially
+		if (response.error === 'pr_required') {
+			return {
+				result: {
+					error: 'pr_required',
+					message: response.data?.message || 'A Pull Request is required before validation approval. Create a PR and add it via add_task_reference.',
+					workflow: response.data?.workflow,
+					action_required: 'Create a PR for this task and add it via add_task_reference(task_id, pr_url, label: "Pull Request")',
+				},
+			};
+		}
 		throw new Error(response.error || 'Failed to validate task');
 	}
 

package/src/index.ts

@@ -1052,8 +1052,8 @@ Returns session info, persona, and next task. Use mode:'full' for complete conte
 				},
 				task_type: {
 					type: 'string',
-					enum: ['frontend', 'backend', 'database', 'mcp', 'testing', 'docs', 'infra', 'other'],
-					description: 'Task category for visual grouping (frontend, backend, database, mcp, testing, docs, infra, other)',
+					enum: ['frontend', 'backend', 'database', 'feature', 'bugfix', 'design', 'mcp', 'testing', 'docs', 'infra', 'other'],
+					description: 'Task category (frontend, backend, database, feature, bugfix, design, mcp, testing, docs, infra, other)',
 				},
 			},
 			required: ['project_id', 'title'],
@@ -1101,8 +1101,8 @@ Returns session info, persona, and next task. Use mode:'full' for complete conte
 				},
 				task_type: {
 					type: 'string',
-					enum: ['frontend', 'backend', 'database', 'mcp', 'testing', 'docs', 'infra', 'other'],
-					description: 'Task category (frontend, backend, database, mcp, testing, docs, infra, other)',
+					enum: ['frontend', 'backend', 'database', 'feature', 'bugfix', 'design', 'mcp', 'testing', 'docs', 'infra', 'other'],
+					description: 'Task category (frontend, backend, database, feature, bugfix, design, mcp, testing, docs, infra, other)',
 				},
 			},
 			required: ['task_id'],
@@ -1817,6 +1817,10 @@ Returns subtasks with aggregate completion stats.`,
 					type: 'string',
 					description: 'Session ID from start_work_session (optional, uses current session if not provided)',
 				},
+				current_worktree_path: {
+					type: ['string', 'null'],
+					description: 'Report your current git worktree path (e.g., "../project-task-abc123"). Set to null to clear.',
+				},
 			},
 		},
 	},
@@ -1866,7 +1870,7 @@ Returns subtasks with aggregate completion stats.`,
 	},
 	{
 		name: 'validate_task',
-		description: 'Validate a completed task. Include test results in validation_notes.',
+		description: 'Validate a completed task. Include test results in validation_notes. For github-flow/git-flow projects, a PR must exist before approval (add via add_task_reference).',
 		inputSchema: {
 			type: 'object',
 			properties: {
@@ -1882,6 +1886,10 @@ Returns subtasks with aggregate completion stats.`,
 					type: 'boolean',
 					description: 'Whether the task passes validation (true = approved, false = needs more work)',
 				},
+				skip_pr_check: {
+					type: 'boolean',
+					description: 'Skip PR existence check (use only for tasks that legitimately do not need a PR)',
+				},
 			},
 			required: ['task_id', 'approved'],
 		},
@@ -2589,7 +2597,8 @@ Bodies of work allow organizing related tasks with optional auto-deployment on c
 	},
 	{
 		name: 'get_body_of_work',
-		description: `Get a body of work with all its tasks organized by phase.`,
+		description: `Get a body of work with all its tasks organized by phase.
+Use summary_only: true to get task counts and next task instead of full task arrays (saves tokens).`,
 		inputSchema: {
 			type: 'object',
 			properties: {
@@ -2597,6 +2606,10 @@ Bodies of work allow organizing related tasks with optional auto-deployment on c
 					type: 'string',
 					description: 'Body of work UUID',
 				},
+				summary_only: {
+					type: 'boolean',
+					description: 'Return task counts and next task instead of full task arrays (default: false)',
+				},
 			},
 			required: ['body_of_work_id'],
 		},
@@ -2872,7 +2885,8 @@ Sprints start in 'planning' status where tasks can be added with story points.`,
 	{
 		name: 'get_sprint',
 		description: `Get a sprint with all its tasks organized by phase (pre/core/post).
-Includes progress percentage, velocity points, and committed points.`,
+Includes progress percentage, velocity points, and committed points.
+Use summary_only: true to get task counts and next task instead of full task arrays (saves tokens).`,
 		inputSchema: {
 			type: 'object',
 			properties: {
@@ -2880,6 +2894,10 @@ Includes progress percentage, velocity points, and committed points.`,
 					type: 'string',
 					description: 'Sprint UUID',
 				},
+				summary_only: {
+					type: 'boolean',
+					description: 'Return task counts and next task instead of full task arrays (default: false)',
+				},
 			},
 			required: ['sprint_id'],
 		},