@vibescope/mcp-server 0.1.0 → 0.2.1

package/src/handlers/session.ts

@@ -10,23 +10,47 @@
  */
 
 import type { Handler, HandlerRegistry, TokenUsage } from './types.js';
-import { KNOWLEDGE_BASE } from '../knowledge.js';
+import { parseArgs, createEnumValidator } from '../validators.js';
 import { getApiClient } from '../api-client.js';
 
+const VALID_MODES = ['lite', 'full'] as const;
+const VALID_MODELS = ['opus', 'sonnet', 'haiku'] as const;
+const VALID_ROLES = ['developer', 'validator', 'deployer', 'reviewer', 'maintainer'] as const;
+
+type SessionMode = typeof VALID_MODES[number];
+type SessionModel = typeof VALID_MODELS[number];
+type SessionRole = typeof VALID_ROLES[number];
+
+// Argument schemas for type-safe parsing
+const startWorkSessionSchema = {
+	project_id: { type: 'string' as const },
+	git_url: { type: 'string' as const },
+	mode: { type: 'string' as const, default: 'lite', validate: createEnumValidator(VALID_MODES) },
+	model: { type: 'string' as const, validate: createEnumValidator(VALID_MODELS) },
+	role: { type: 'string' as const, default: 'developer', validate: createEnumValidator(VALID_ROLES) },
+};
+
+const heartbeatSchema = {
+	session_id: { type: 'string' as const },
+	current_worktree_path: { type: 'string' as const },
+};
+
+const endWorkSessionSchema = {
+	session_id: { type: 'string' as const },
+};
+
+const getHelpSchema = {
+	topic: { type: 'string' as const, required: true as const },
+};
+
 export const startWorkSession: Handler = async (args, ctx) => {
-	const { project_id, git_url, mode = 'lite', model, role = 'developer' } = args as {
-		project_id?: string;
-		git_url?: string;
-		mode?: 'lite' | 'full';
-		model?: 'opus' | 'sonnet' | 'haiku';
-		role?: 'developer' | 'validator' | 'deployer' | 'reviewer' | 'maintainer';
-	};
+	const { project_id, git_url, mode, model, role } = parseArgs(args, startWorkSessionSchema);
 
 	const { session, updateSession } = ctx;
 
 	// Reset token tracking for new session with model info
 	const normalizedModel = model ? model.toLowerCase().replace(/^claude[- ]*/i, '') : null;
-	const validModel = normalizedModel && ['opus', 'sonnet', 'haiku'].includes(normalizedModel)
+	const validModel = normalizedModel && VALID_MODELS.includes(normalizedModel as SessionModel)
 		? normalizedModel
 		: null;
 
@@ -53,9 +77,9 @@ export const startWorkSession: Handler = async (args, ctx) => {
 	const response = await apiClient.startSession({
 		project_id,
 		git_url,
-		mode,
-		model,
-		role
+		mode: mode as SessionMode,
+		model: model as SessionModel | undefined,
+		role: role as SessionRole
 	});
 
 	if (!response.ok) {
@@ -140,7 +164,7 @@ export const startWorkSession: Handler = async (args, ctx) => {
 };
 
 export const heartbeat: Handler = async (args, ctx) => {
-	const { session_id } = args as { session_id?: string };
+	const { session_id, current_worktree_path } = parseArgs(args, heartbeatSchema);
 	const { session } = ctx;
 	const targetSession = session_id || session.currentSessionId;
 
@@ -154,8 +178,10 @@ export const heartbeat: Handler = async (args, ctx) => {
 
 	const apiClient = getApiClient();
 
-	// Send heartbeat
-	const heartbeatResponse = await apiClient.heartbeat(targetSession);
+	// Send heartbeat with optional worktree path
+	const heartbeatResponse = await apiClient.heartbeat(targetSession, {
+		current_worktree_path,
+	});
 
 	if (!heartbeatResponse.ok) {
 		return {
@@ -182,7 +208,7 @@ export const heartbeat: Handler = async (args, ctx) => {
 };
 
 export const endWorkSession: Handler = async (args, ctx) => {
-	const { session_id } = args as { session_id?: string };
+	const { session_id } = parseArgs(args, endWorkSessionSchema);
 	const { session, updateSession } = ctx;
 	const targetSession = session_id || session.currentSessionId;
 
@@ -247,19 +273,36 @@ export const endWorkSession: Handler = async (args, ctx) => {
 };
 
 export const getHelp: Handler = async (args, _ctx) => {
-	const { topic } = args as { topic: string };
+	const { topic } = parseArgs(args, getHelpSchema);
+
+	const apiClient = getApiClient();
+	const response = await apiClient.getHelpTopic(topic);
+
+	if (!response.ok) {
+		// If database fetch fails, return error
+		return {
+			result: {
+				error: response.error || `Failed to fetch help topic: ${topic}`,
+			},
+		};
+	}
+
+	if (!response.data) {
+		// Topic not found - fetch available topics
+		const topicsResponse = await apiClient.getHelpTopics();
+		const available = topicsResponse.ok && topicsResponse.data
+			? topicsResponse.data.map(t => t.slug)
+			: ['getting_started', 'tasks', 'validation', 'deployment', 'git', 'blockers', 'milestones', 'fallback', 'session', 'tokens', 'sprints', 'topics'];
 
-	const content = KNOWLEDGE_BASE[topic];
-	if (!content) {
 		return {
 			result: {
 				error: `Unknown topic: ${topic}`,
-				available: Object.keys(KNOWLEDGE_BASE),
+				available,
 			},
 		};
 	}
 
-	return { result: { topic, content } };
+	return { result: { topic, content: response.data.content } };
 };
 
 // Model pricing rates (USD per 1M tokens)

package/src/handlers/sprints.ts

@@ -16,18 +16,92 @@
  */
 
 import type { Handler, HandlerRegistry } from './types.js';
-import { validateRequired, validateUUID, validateEnum } from '../validators.js';
+import { parseArgs, uuidValidator, createEnumValidator } from '../validators.js';
 import { getApiClient } from '../api-client.js';
 
-type SprintStatus = 'planning' | 'active' | 'in_review' | 'retrospective' | 'completed' | 'cancelled';
-type TaskPhase = 'pre' | 'core' | 'post';
-type DeployEnvironment = 'development' | 'staging' | 'production';
-type VersionBump = 'patch' | 'minor' | 'major';
+const SPRINT_STATUSES = ['planning', 'active', 'in_review', 'retrospective', 'completed', 'cancelled'] as const;
+const TASK_PHASES = ['pre', 'core', 'post'] as const;
+const DEPLOY_ENVIRONMENTS = ['development', 'staging', 'production'] as const;
+const VERSION_BUMPS = ['patch', 'minor', 'major'] as const;
+
+type SprintStatus = typeof SPRINT_STATUSES[number];
+type TaskPhase = typeof TASK_PHASES[number];
+type DeployEnvironment = typeof DEPLOY_ENVIRONMENTS[number];
+type VersionBump = typeof VERSION_BUMPS[number];
+
+// ============================================================================
+// Argument Schemas
+// ============================================================================
+
+const createSprintSchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	title: { type: 'string' as const, required: true as const },
+	goal: { type: 'string' as const },
+	start_date: { type: 'string' as const, required: true as const },
+	end_date: { type: 'string' as const, required: true as const },
+	auto_deploy_on_completion: { type: 'boolean' as const },
+	deploy_environment: { type: 'string' as const, validate: createEnumValidator(DEPLOY_ENVIRONMENTS) },
+	deploy_version_bump: { type: 'string' as const, validate: createEnumValidator(VERSION_BUMPS) },
+};
+
+const updateSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	title: { type: 'string' as const },
+	goal: { type: 'string' as const },
+	start_date: { type: 'string' as const },
+	end_date: { type: 'string' as const },
+	auto_deploy_on_completion: { type: 'boolean' as const },
+	deploy_environment: { type: 'string' as const, validate: createEnumValidator(DEPLOY_ENVIRONMENTS) },
+	deploy_version_bump: { type: 'string' as const, validate: createEnumValidator(VERSION_BUMPS) },
+};
+
+const getSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	summary_only: { type: 'boolean' as const, default: false },
+};
+
+const getSprintsSchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	status: { type: 'string' as const, validate: createEnumValidator(SPRINT_STATUSES) },
+	limit: { type: 'number' as const, default: 20 },
+	offset: { type: 'number' as const, default: 0 },
+};
+
+const deleteSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+};
+
+const startSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+};
+
+const completeSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	retrospective_notes: { type: 'string' as const },
+	skip_retrospective: { type: 'boolean' as const },
+};
+
+const addTaskToSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	task_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	story_points: { type: 'number' as const },
+	phase: { type: 'string' as const, validate: createEnumValidator(TASK_PHASES) },
+};
+
+const removeTaskFromSprintSchema = {
+	sprint_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	task_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+};
+
+const getSprintBacklogSchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	sprint_id: { type: 'string' as const, validate: uuidValidator },
+};
 
-const SPRINT_STATUSES: SprintStatus[] = ['planning', 'active', 'in_review', 'retrospective', 'completed', 'cancelled'];
-const TASK_PHASES: TaskPhase[] = ['pre', 'core', 'post'];
-const DEPLOY_ENVIRONMENTS: DeployEnvironment[] = ['development', 'staging', 'production'];
-const VERSION_BUMPS: VersionBump[] = ['patch', 'minor', 'major'];
+const getSprintVelocitySchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	limit: { type: 'number' as const, default: 10 },
+};
 
 export const createSprint: Handler = async (args, ctx) => {
 	const {
@@ -39,29 +113,7 @@ export const createSprint: Handler = async (args, ctx) => {
 		auto_deploy_on_completion,
 		deploy_environment,
 		deploy_version_bump,
-	} = args as {
-		project_id: string;
-		title: string;
-		goal?: string;
-		start_date: string;
-		end_date: string;
-		auto_deploy_on_completion?: boolean;
-		deploy_environment?: DeployEnvironment;
-		deploy_version_bump?: VersionBump;
-	};
-
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
-	validateRequired(title, 'title');
-	validateRequired(start_date, 'start_date');
-	validateRequired(end_date, 'end_date');
-
-	if (deploy_environment) {
-		validateEnum(deploy_environment, DEPLOY_ENVIRONMENTS, 'deploy_environment');
-	}
-	if (deploy_version_bump) {
-		validateEnum(deploy_version_bump, VERSION_BUMPS, 'deploy_version_bump');
-	}
+	} = parseArgs(args, createSprintSchema);
 
 	// Validate date format and order
 	const startDateObj = new Date(start_date);
@@ -126,26 +178,7 @@ export const updateSprint: Handler = async (args, ctx) => {
 		auto_deploy_on_completion,
 		deploy_environment,
 		deploy_version_bump,
-	} = args as {
-		sprint_id: string;
-		title?: string;
-		goal?: string;
-		start_date?: string;
-		end_date?: string;
-		auto_deploy_on_completion?: boolean;
-		deploy_environment?: DeployEnvironment;
-		deploy_version_bump?: VersionBump;
-	};
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
-
-	if (deploy_environment) {
-		validateEnum(deploy_environment, DEPLOY_ENVIRONMENTS, 'deploy_environment');
-	}
-	if (deploy_version_bump) {
-		validateEnum(deploy_version_bump, VERSION_BUMPS, 'deploy_version_bump');
-	}
+	} = parseArgs(args, updateSprintSchema);
 
 	// Validate dates if provided
 	if (start_date) {
@@ -182,13 +215,11 @@ export const updateSprint: Handler = async (args, ctx) => {
 };
 
 export const getSprint: Handler = async (args, ctx) => {
-	const { sprint_id } = args as { sprint_id: string };
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
+	const { sprint_id, summary_only } = parseArgs(args, getSprintSchema);
 
 	const apiClient = getApiClient();
 
+	// Response type varies based on summary_only
 	const response = await apiClient.proxy<{
 		id: string;
 		title: string;
@@ -200,11 +231,23 @@ export const getSprint: Handler = async (args, ctx) => {
 		progress_percentage: number;
 		velocity_points: number;
 		committed_points: number;
-		pre_tasks: unknown[];
-		core_tasks: unknown[];
-		post_tasks: unknown[];
-		total_tasks: number;
-	}>('get_sprint', { sprint_id });
+		// Full response includes task arrays
+		pre_tasks?: unknown[];
+		core_tasks?: unknown[];
+		post_tasks?: unknown[];
+		total_tasks?: number;
+		// Summary response includes counts and next task
+		task_counts?: {
+			pre: { total: number; completed: number };
+			core: { total: number; completed: number };
+			post: { total: number; completed: number };
+			total: number;
+			completed: number;
+			in_progress: number;
+		};
+		current_task?: { id: string; title: string } | null;
+		next_task?: { id: string; title: string; priority: number } | null;
+	}>('get_sprint', { sprint_id, summary_only });
 
 	if (!response.ok) {
 		throw new Error(`Failed to get sprint: ${response.error}`);
@@ -214,19 +257,7 @@ export const getSprint: Handler = async (args, ctx) => {
 };
 
 export const getSprints: Handler = async (args, ctx) => {
-	const { project_id, status, limit = 20, offset = 0 } = args as {
-		project_id: string;
-		status?: SprintStatus;
-		limit?: number;
-		offset?: number;
-	};
-
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
-
-	if (status) {
-		validateEnum(status, SPRINT_STATUSES, 'status');
-	}
+	const { project_id, status, limit, offset } = parseArgs(args, getSprintsSchema);
 
 	const apiClient = getApiClient();
 
@@ -248,7 +279,7 @@ export const getSprints: Handler = async (args, ctx) => {
 	}>('get_sprints', {
 		project_id,
 		status,
-		limit: Math.min(limit, 100),
+		limit: Math.min(limit ?? 20, 100),
 		offset,
 	});
 
@@ -260,10 +291,7 @@ export const getSprints: Handler = async (args, ctx) => {
 };
 
 export const deleteSprint: Handler = async (args, ctx) => {
-	const { sprint_id } = args as { sprint_id: string };
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
+	const { sprint_id } = parseArgs(args, deleteSprintSchema);
 
 	const apiClient = getApiClient();
 
@@ -279,10 +307,7 @@ export const deleteSprint: Handler = async (args, ctx) => {
 };
 
 export const startSprint: Handler = async (args, ctx) => {
-	const { sprint_id } = args as { sprint_id: string };
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
+	const { sprint_id } = parseArgs(args, startSprintSchema);
 
 	const apiClient = getApiClient();
 
@@ -302,14 +327,7 @@ export const startSprint: Handler = async (args, ctx) => {
 };
 
 export const completeSprint: Handler = async (args, ctx) => {
-	const { sprint_id, retrospective_notes, skip_retrospective } = args as {
-		sprint_id: string;
-		retrospective_notes?: string;
-		skip_retrospective?: boolean;
-	};
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
+	const { sprint_id, retrospective_notes, skip_retrospective } = parseArgs(args, completeSprintSchema);
 
 	const apiClient = getApiClient();
 
@@ -335,21 +353,7 @@ export const completeSprint: Handler = async (args, ctx) => {
 };
 
 export const addTaskToSprint: Handler = async (args, ctx) => {
-	const { sprint_id, task_id, story_points, phase } = args as {
-		sprint_id: string;
-		task_id: string;
-		story_points?: number;
-		phase?: TaskPhase;
-	};
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
-	validateRequired(task_id, 'task_id');
-	validateUUID(task_id, 'task_id');
-
-	if (phase) {
-		validateEnum(phase, TASK_PHASES, 'phase');
-	}
+	const { sprint_id, task_id, story_points, phase } = parseArgs(args, addTaskToSprintSchema);
 
 	if (story_points !== undefined && (story_points < 0 || !Number.isInteger(story_points))) {
 		throw new Error('story_points must be a non-negative integer');
@@ -379,15 +383,7 @@ export const addTaskToSprint: Handler = async (args, ctx) => {
 };
 
 export const removeTaskFromSprint: Handler = async (args, ctx) => {
-	const { sprint_id, task_id } = args as {
-		sprint_id: string;
-		task_id: string;
-	};
-
-	validateRequired(sprint_id, 'sprint_id');
-	validateUUID(sprint_id, 'sprint_id');
-	validateRequired(task_id, 'task_id');
-	validateUUID(task_id, 'task_id');
+	const { sprint_id, task_id } = parseArgs(args, removeTaskFromSprintSchema);
 
 	const apiClient = getApiClient();
 
@@ -410,17 +406,7 @@ export const removeTaskFromSprint: Handler = async (args, ctx) => {
 };
 
 export const getSprintBacklog: Handler = async (args, ctx) => {
-	const { project_id, sprint_id } = args as {
-		project_id: string;
-		sprint_id?: string;
-	};
-
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
-
-	if (sprint_id) {
-		validateUUID(sprint_id, 'sprint_id');
-	}
+	const { project_id, sprint_id } = parseArgs(args, getSprintBacklogSchema);
 
 	const apiClient = getApiClient();
 
@@ -447,13 +433,7 @@ export const getSprintBacklog: Handler = async (args, ctx) => {
 };
 
 export const getSprintVelocity: Handler = async (args, ctx) => {
-	const { project_id, limit = 10 } = args as {
-		project_id: string;
-		limit?: number;
-	};
-
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
+	const { project_id, limit } = parseArgs(args, getSprintVelocitySchema);
 
 	const apiClient = getApiClient();
 
@@ -469,7 +449,7 @@ export const getSprintVelocity: Handler = async (args, ctx) => {
 		total_sprints: number;
 	}>('get_sprint_velocity', {
 		project_id,
-		limit: Math.min(limit, 50),
+		limit: Math.min(limit ?? 10, 50),
 	});
 
 	if (!response.ok) {

package/src/handlers/tasks.test.ts

@@ -352,6 +352,67 @@ describe('updateTask', () => {
 			error: 'task_claimed',
 		});
 	});
+
+	it('should warn when setting in_progress without git_branch', async () => {
+		mockApiClient.updateTask.mockResolvedValue({
+			ok: true,
+			data: { success: true },
+		});
+
+		const ctx = createMockContext();
+		const result = await updateTask(
+			{
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				status: 'in_progress',
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			success: true,
+			warning: expect.stringContaining('git_branch not set'),
+			hint: expect.stringContaining('update_task again'),
+		});
+	});
+
+	it('should not warn when setting in_progress with git_branch', async () => {
+		mockApiClient.updateTask.mockResolvedValue({
+			ok: true,
+			data: { success: true },
+		});
+
+		const ctx = createMockContext();
+		const result = await updateTask(
+			{
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				status: 'in_progress',
+				git_branch: 'feature/my-task',
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({ success: true });
+		expect(result.result).not.toHaveProperty('warning');
+	});
+
+	it('should not warn when updating status other than in_progress', async () => {
+		mockApiClient.updateTask.mockResolvedValue({
+			ok: true,
+			data: { success: true },
+		});
+
+		const ctx = createMockContext();
+		const result = await updateTask(
+			{
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				status: 'completed',
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({ success: true });
+		expect(result.result).not.toHaveProperty('warning');
+	});
 });
 
 // ============================================================================