@vibescope/mcp-server 0.0.1

package/src/handlers/validation.ts

@@ -0,0 +1,223 @@
+/**
+ * Validation Handlers
+ *
+ * Handles cross-agent task validation:
+ * - get_tasks_awaiting_validation
+ * - claim_validation
+ * - validate_task
+ */
+
+import type { Handler, HandlerRegistry } from './types.js';
+import { validateRequired, validateUUID } from '../validators.js';
+import { getProjectGitConfig, getValidationApprovedGitInstructions } from './tasks.js';
+
+export const getTasksAwaitingValidation: Handler = async (args, ctx) => {
+	const { project_id } = args as { project_id: string };
+
+	validateRequired(project_id, 'project_id');
+	validateUUID(project_id, 'project_id');
+
+	const { supabase } = ctx;
+
+	const { data: tasks, error } = await supabase
+		.from('tasks')
+		.select('id, title, completed_at, completed_by_session_id, reviewing_by_session_id, reviewing_started_at')
+		.eq('project_id', project_id)
+		.eq('status', 'completed')
+		.is('validated_at', null)
+		.order('completed_at', { ascending: true });
+
+	if (error) throw new Error(`Failed to fetch tasks: ${error.message}`);
+
+	// Add review status info
+	const now = new Date();
+	const tasksWithStatus = (tasks || []).map((t) => ({
+		...t,
+		being_reviewed: !!t.reviewing_by_session_id,
+		review_minutes: t.reviewing_started_at
+			? Math.floor((now.getTime() - new Date(t.reviewing_started_at).getTime()) / 60000)
+			: null,
+	}));
+
+	return {
+		result: {
+			tasks: tasksWithStatus,
+			hint: tasksWithStatus.length > 0
+				? 'Call claim_validation(task_id) before reviewing to show "being reviewed" on dashboard.'
+				: undefined,
+		},
+	};
+};
+
+export const claimValidation: Handler = async (args, ctx) => {
+	const { task_id } = args as { task_id: string };
+
+	validateRequired(task_id, 'task_id');
+	validateUUID(task_id, 'task_id');
+
+	const { supabase, session } = ctx;
+	const currentSessionId = session.currentSessionId;
+
+	// Get the task first
+	const { data: task, error: fetchError } = await supabase
+		.from('tasks')
+		.select('id, title, status, validated_at, completed_by_session_id, reviewing_by_session_id')
+		.eq('id', task_id)
+		.single();
+
+	if (fetchError || !task) throw new Error('Task not found');
+
+	if (task.status !== 'completed') {
+		throw new Error('Can only claim completed tasks for review');
+	}
+
+	if (task.validated_at) {
+		throw new Error('Task has already been validated');
+	}
+
+	if (task.reviewing_by_session_id && task.reviewing_by_session_id !== currentSessionId) {
+		throw new Error('Task is already being reviewed by another agent');
+	}
+
+	// Claim the task for review
+	const { error } = await supabase
+		.from('tasks')
+		.update({
+			reviewing_by_session_id: currentSessionId,
+			reviewing_started_at: new Date().toISOString(),
+		})
+		.eq('id', task_id);
+
+	if (error) throw new Error(`Failed to claim task: ${error.message}`);
+
+	return {
+		result: {
+			success: true,
+			task_id,
+			title: task.title,
+			message: 'Task claimed for review. Dashboard now shows "being reviewed".',
+			next_step: `Review the implementation, then call validate_task(task_id: "${task_id}", approved: true/false, validation_notes: "...")`,
+		},
+	};
+};
+
+export const validateTask: Handler = async (args, ctx) => {
+	const { task_id, validation_notes, approved } = args as {
+		task_id: string;
+		validation_notes?: string;
+		approved: boolean;
+	};
+
+	validateRequired(task_id, 'task_id');
+	validateUUID(task_id, 'task_id');
+
+	const { supabase, session } = ctx;
+	const currentSessionId = session.currentSessionId;
+
+	// Get the task to validate (including git_branch for workflow instructions)
+	const { data: task, error: fetchError } = await supabase
+		.from('tasks')
+		.select('id, title, status, validated_at, completed_by_session_id, project_id, git_branch')
+		.eq('id', task_id)
+		.single();
+
+	if (fetchError || !task) throw new Error('Task not found');
+
+	if (task.status !== 'completed') {
+		throw new Error('Can only validate completed tasks');
+	}
+
+	if (task.validated_at) {
+		throw new Error('Task has already been validated');
+	}
+
+	// Check if this is self-validation
+	const isSelfValidation = currentSessionId && task.completed_by_session_id === currentSessionId;
+
+	if (approved) {
+		// Mark as validated and clear reviewing status
+		const { error } = await supabase
+			.from('tasks')
+			.update({
+				validated_at: new Date().toISOString(),
+				validated_by_session_id: currentSessionId,
+				reviewing_by_session_id: null,
+				reviewing_started_at: null,
+			})
+			.eq('id', task_id);
+
+		if (error) throw new Error(`Failed to validate task: ${error.message}`);
+
+		// Log the validation
+		await supabase.from('progress_logs').insert({
+			project_id: task.project_id,
+			task_id,
+			summary: `Validated: ${task.title}${isSelfValidation ? ' (self)' : ''}`,
+			details: validation_notes || null,
+			created_by: 'agent',
+			created_by_session_id: currentSessionId,
+		});
+
+		// Build result with optional git merge instructions
+		const result: Record<string, unknown> = {
+			success: true,
+			validated_task_id: task_id,
+			self_validated: isSelfValidation,
+		};
+
+		// Include git workflow instructions for merging
+		const gitConfig = await getProjectGitConfig(supabase, task.project_id);
+		if (gitConfig && gitConfig.git_workflow !== 'none') {
+			const gitInstructions = getValidationApprovedGitInstructions(gitConfig, task.git_branch);
+			if (gitInstructions) {
+				result.git_workflow = {
+					workflow: gitConfig.git_workflow,
+					action: 'merge',
+					...gitInstructions,
+				};
+			}
+		}
+
+		return { result };
+	} else {
+		// Validation failed - reopen the task and clear reviewing status
+		const { error } = await supabase
+			.from('tasks')
+			.update({
+				status: 'in_progress',
+				completed_at: null,
+				progress_percentage: 80,
+				reviewing_by_session_id: null,
+				reviewing_started_at: null,
+			})
+			.eq('id', task_id);
+
+		if (error) throw new Error(`Failed to reopen task: ${error.message}`);
+
+		// Log the rejection
+		await supabase.from('progress_logs').insert({
+			project_id: task.project_id,
+			task_id,
+			summary: `Validation failed: ${task.title}`,
+			details: validation_notes || 'Needs more work',
+			created_by: 'agent',
+			created_by_session_id: currentSessionId,
+		});
+
+		return {
+			result: {
+				success: true,
+				reopened_task_id: task_id,
+			},
+		};
+	}
+};
+
+/**
+ * Validation handlers registry
+ */
+export const validationHandlers: HandlerRegistry = {
+	get_tasks_awaiting_validation: getTasksAwaitingValidation,
+	claim_validation: claimValidation,
+	validate_task: validateTask,
+};