@vibescope/mcp-server 0.0.1

package/src/handlers/milestones.test.ts

@@ -0,0 +1,584 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import type { SupabaseClient } from '@supabase/supabase-js';
+import type { HandlerContext, TokenUsage } from './types.js';
+import {
+	addMilestone,
+	updateMilestone,
+	completeMilestone,
+	deleteMilestone,
+	getMilestones,
+} from './milestones.js';
+import { ValidationError } from '../validators.js';
+
+// ============================================================================
+// Test Utilities
+// ============================================================================
+
+function createMockSupabase(overrides: {
+	selectResult?: { data: unknown; error: unknown };
+	insertResult?: { data: unknown; error: unknown };
+	updateResult?: { data: unknown; error: unknown };
+	deleteResult?: { data: unknown; error: unknown };
+} = {}) {
+	const defaultResult = { data: null, error: null };
+	let currentOperation = 'select';
+	let insertThenSelect = false;
+
+	const mock = {
+		from: vi.fn().mockReturnThis(),
+		select: vi.fn(() => {
+			if (currentOperation === 'insert' || currentOperation === 'update') {
+				insertThenSelect = true;
+			} else {
+				currentOperation = 'select';
+				insertThenSelect = false;
+			}
+			return mock;
+		}),
+		insert: vi.fn(() => {
+			currentOperation = 'insert';
+			insertThenSelect = false;
+			return mock;
+		}),
+		update: vi.fn(() => {
+			currentOperation = 'update';
+			insertThenSelect = false;
+			return mock;
+		}),
+		delete: vi.fn(() => {
+			currentOperation = 'delete';
+			insertThenSelect = false;
+			return mock;
+		}),
+		eq: vi.fn().mockReturnThis(),
+		neq: vi.fn().mockReturnThis(),
+		in: vi.fn().mockReturnThis(),
+		is: vi.fn().mockReturnThis(),
+		not: vi.fn().mockReturnThis(),
+		or: vi.fn().mockReturnThis(),
+		gt: vi.fn().mockReturnThis(),
+		gte: vi.fn().mockReturnThis(),
+		lte: vi.fn().mockReturnThis(),
+		lt: vi.fn().mockReturnThis(),
+		order: vi.fn().mockReturnThis(),
+		limit: vi.fn().mockReturnThis(),
+		single: vi.fn(() => {
+			if (currentOperation === 'insert' || insertThenSelect) {
+				return Promise.resolve(overrides.insertResult ?? defaultResult);
+			}
+			if (currentOperation === 'select') {
+				return Promise.resolve(overrides.selectResult ?? defaultResult);
+			}
+			if (currentOperation === 'update') {
+				return Promise.resolve(overrides.updateResult ?? defaultResult);
+			}
+			return Promise.resolve(defaultResult);
+		}),
+		maybeSingle: vi.fn(() => {
+			return Promise.resolve(overrides.selectResult ?? defaultResult);
+		}),
+		then: vi.fn((resolve: (value: unknown) => void) => {
+			if (currentOperation === 'insert' || insertThenSelect) {
+				return Promise.resolve(overrides.insertResult ?? defaultResult).then(resolve);
+			}
+			if (currentOperation === 'select') {
+				return Promise.resolve(overrides.selectResult ?? defaultResult).then(resolve);
+			}
+			if (currentOperation === 'update') {
+				return Promise.resolve(overrides.updateResult ?? defaultResult).then(resolve);
+			}
+			if (currentOperation === 'delete') {
+				return Promise.resolve(overrides.deleteResult ?? defaultResult).then(resolve);
+			}
+			return Promise.resolve(defaultResult).then(resolve);
+		}),
+	};
+
+	return mock as unknown as SupabaseClient;
+}
+
+function createMockContext(
+	supabase: SupabaseClient,
+	options: { sessionId?: string | null } = {}
+): HandlerContext {
+	const defaultTokenUsage: TokenUsage = {
+		callCount: 5,
+		totalTokens: 2500,
+		byTool: {},
+	};
+
+	const sessionId = 'sessionId' in options ? options.sessionId : 'session-123';
+
+	return {
+		supabase,
+		auth: { userId: 'user-123', apiKeyId: 'api-key-123' },
+		session: {
+			instanceId: 'instance-abc',
+			currentSessionId: sessionId,
+			currentPersona: 'Wave',
+			tokenUsage: defaultTokenUsage,
+		},
+		updateSession: vi.fn(),
+	};
+}
+
+// ============================================================================
+// addMilestone Tests
+// ============================================================================
+
+describe('addMilestone', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should throw error for missing task_id', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			addMilestone({ title: 'Milestone 1' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error for invalid task_id UUID', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			addMilestone({ task_id: 'invalid', title: 'Milestone 1' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error for missing title', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			addMilestone({ task_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error when task not found', async () => {
+		const supabase = createMockSupabase({
+			selectResult: { data: null, error: { message: 'Not found' } },
+		});
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			addMilestone({
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				title: 'Milestone 1',
+			}, ctx)
+		).rejects.toThrow('Task not found');
+	});
+
+	it('should add milestone successfully', async () => {
+		const mockMilestone = {
+			id: 'milestone-1',
+			task_id: '123e4567-e89b-12d3-a456-426614174000',
+			title: 'First Milestone',
+			order_index: 0,
+			status: 'pending',
+		};
+
+		const supabase = createMockSupabase({
+			selectResult: { data: { id: 'task-1', project_id: 'proj-1' }, error: null },
+			insertResult: { data: mockMilestone, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await addMilestone(
+			{
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				title: 'First Milestone',
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			success: true,
+			milestone: mockMilestone,
+		});
+	});
+
+	it('should use provided order_index', async () => {
+		const supabase = createMockSupabase({
+			selectResult: { data: { id: 'task-1', project_id: 'proj-1' }, error: null },
+			insertResult: { data: { id: 'milestone-1', order_index: 5 }, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		await addMilestone(
+			{
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				title: 'Test Milestone',
+				order_index: 5,
+			},
+			ctx
+		);
+
+		expect(supabase.insert).toHaveBeenCalledWith(
+			expect.objectContaining({
+				order_index: 5,
+			})
+		);
+	});
+
+	it('should include session_id in insert', async () => {
+		const supabase = createMockSupabase({
+			selectResult: { data: { id: 'task-1', project_id: 'proj-1' }, error: null },
+			insertResult: { data: { id: 'milestone-1' }, error: null },
+		});
+		const ctx = createMockContext(supabase, { sessionId: 'my-session' });
+
+		await addMilestone(
+			{
+				task_id: '123e4567-e89b-12d3-a456-426614174000',
+				title: 'Test',
+			},
+			ctx
+		);
+
+		expect(supabase.insert).toHaveBeenCalledWith(
+			expect.objectContaining({
+				created_by: 'agent',
+				created_by_session_id: 'my-session',
+			})
+		);
+	});
+});
+
+// ============================================================================
+// updateMilestone Tests
+// ============================================================================
+
+describe('updateMilestone', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should throw error for missing milestone_id', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(updateMilestone({}, ctx)).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error for invalid milestone_id UUID', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			updateMilestone({ milestone_id: 'invalid', title: 'New Title' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error when no fields to update', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			updateMilestone({ milestone_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
+		).rejects.toThrow('At least one field to update is required');
+	});
+
+	it('should throw error for invalid status', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			updateMilestone({
+				milestone_id: '123e4567-e89b-12d3-a456-426614174000',
+				status: 'invalid_status',
+			}, ctx)
+		).rejects.toThrow('status must be pending, in_progress, or completed');
+	});
+
+	it('should update title successfully', async () => {
+		const supabase = createMockSupabase({
+			updateResult: { data: { id: 'milestone-1', title: 'Updated Title' }, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await updateMilestone(
+			{
+				milestone_id: '123e4567-e89b-12d3-a456-426614174000',
+				title: 'Updated Title',
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			success: true,
+		});
+	});
+
+	it('should set completed_at when status is completed', async () => {
+		const supabase = createMockSupabase({
+			updateResult: { data: { id: 'milestone-1', status: 'completed' }, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		await updateMilestone(
+			{
+				milestone_id: '123e4567-e89b-12d3-a456-426614174000',
+				status: 'completed',
+			},
+			ctx
+		);
+
+		expect(supabase.update).toHaveBeenCalledWith(
+			expect.objectContaining({
+				status: 'completed',
+				completed_at: expect.any(String),
+			})
+		);
+	});
+
+	it('should clear completed_at when status is not completed', async () => {
+		const supabase = createMockSupabase({
+			updateResult: { data: { id: 'milestone-1', status: 'in_progress' }, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		await updateMilestone(
+			{
+				milestone_id: '123e4567-e89b-12d3-a456-426614174000',
+				status: 'in_progress',
+			},
+			ctx
+		);
+
+		expect(supabase.update).toHaveBeenCalledWith(
+			expect.objectContaining({
+				status: 'in_progress',
+				completed_at: null,
+			})
+		);
+	});
+});
+
+// ============================================================================
+// completeMilestone Tests
+// ============================================================================
+
+describe('completeMilestone', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should throw error for missing milestone_id', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(completeMilestone({}, ctx)).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error for invalid milestone_id UUID', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			completeMilestone({ milestone_id: 'invalid' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should complete milestone successfully', async () => {
+		const supabase = createMockSupabase({
+			updateResult: {
+				data: { id: 'milestone-1', status: 'completed', completed_at: '2025-01-14T12:00:00Z' },
+				error: null,
+			},
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await completeMilestone(
+			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			success: true,
+		});
+	});
+
+	it('should set status to completed with timestamp', async () => {
+		const supabase = createMockSupabase({
+			updateResult: { data: { id: 'milestone-1' }, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		await completeMilestone(
+			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(supabase.update).toHaveBeenCalledWith(
+			expect.objectContaining({
+				status: 'completed',
+				completed_at: expect.any(String),
+			})
+		);
+	});
+});
+
+// ============================================================================
+// deleteMilestone Tests
+// ============================================================================
+
+describe('deleteMilestone', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should throw error for missing milestone_id', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(deleteMilestone({}, ctx)).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error for invalid milestone_id UUID', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			deleteMilestone({ milestone_id: 'invalid' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should delete milestone successfully', async () => {
+		const supabase = createMockSupabase({
+			deleteResult: { data: null, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await deleteMilestone(
+			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			success: true,
+			message: 'Milestone deleted',
+		});
+	});
+
+	it('should call delete on task_milestones table', async () => {
+		const supabase = createMockSupabase({
+			deleteResult: { data: null, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		await deleteMilestone(
+			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(supabase.from).toHaveBeenCalledWith('task_milestones');
+		expect(supabase.delete).toHaveBeenCalled();
+	});
+});
+
+// ============================================================================
+// getMilestones Tests
+// ============================================================================
+
+describe('getMilestones', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should throw error for missing task_id', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(getMilestones({}, ctx)).rejects.toThrow(ValidationError);
+	});
+
+	it('should throw error for invalid task_id UUID', async () => {
+		const supabase = createMockSupabase();
+		const ctx = createMockContext(supabase);
+
+		await expect(
+			getMilestones({ task_id: 'invalid' }, ctx)
+		).rejects.toThrow(ValidationError);
+	});
+
+	it('should return empty list with zero stats', async () => {
+		const supabase = createMockSupabase({
+			selectResult: { data: [], error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await getMilestones(
+			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			milestones: [],
+			stats: {
+				total: 0,
+				completed: 0,
+				in_progress: 0,
+				pending: 0,
+				progress_percentage: 0,
+			},
+		});
+	});
+
+	it('should return milestones with stats', async () => {
+		const mockMilestones = [
+			{ id: 'm1', title: 'Step 1', status: 'completed', order_index: 0 },
+			{ id: 'm2', title: 'Step 2', status: 'in_progress', order_index: 1 },
+			{ id: 'm3', title: 'Step 3', status: 'pending', order_index: 2 },
+			{ id: 'm4', title: 'Step 4', status: 'pending', order_index: 3 },
+		];
+
+		const supabase = createMockSupabase({
+			selectResult: { data: mockMilestones, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await getMilestones(
+			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			milestones: mockMilestones,
+			stats: {
+				total: 4,
+				completed: 1,
+				in_progress: 1,
+				pending: 2,
+				progress_percentage: 25, // 1/4 = 25%
+			},
+		});
+	});
+
+	it('should calculate 100% when all completed', async () => {
+		const mockMilestones = [
+			{ id: 'm1', status: 'completed' },
+			{ id: 'm2', status: 'completed' },
+		];
+
+		const supabase = createMockSupabase({
+			selectResult: { data: mockMilestones, error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		const result = await getMilestones(
+			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect((result.result as { stats: { progress_percentage: number } }).stats.progress_percentage).toBe(100);
+	});
+
+	it('should query task_milestones table ordered by order_index', async () => {
+		const supabase = createMockSupabase({
+			selectResult: { data: [], error: null },
+		});
+		const ctx = createMockContext(supabase);
+
+		await getMilestones(
+			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(supabase.from).toHaveBeenCalledWith('task_milestones');
+		expect(supabase.order).toHaveBeenCalledWith('order_index', { ascending: true });
+	});
+});