@vibe-forge/workspace-assets 0.9.1-alpha.0 → 0.9.2-alpha.0

package/__tests__/prompt-selection.spec.ts

@@ -4,19 +4,129 @@ import { describe, expect, it } from 'vitest'
 
 import { resolvePromptAssetSelection, resolveWorkspaceAssetBundle } from '#~/index.js'
 
-import { createWorkspace, writeDocument } from './test-helpers'
+import { createWorkspace, installPluginPackage, writeDocument } from './test-helpers'
 
 describe('resolvePromptAssetSelection', () => {
-  it('prefers project prompt assets over plugin assets with the same identifier', async () => {
+  it('embeds only alwaysApply rules and keeps optional rules as summaries', async () => {
     const workspace = await createWorkspace()
 
+    await writeDocument(
+      join(workspace, '.ai/rules/base.md'),
+      [
+        '---',
+        'alwaysApply: true',
+        'description: 基础约束',
+        '---',
+        '始终检查公共边界。'
+      ].join('\n')
+    )
+    await writeDocument(
+      join(workspace, '.ai/rules/optional.md'),
+      [
+        '---',
+        'alwaysApply: false',
+        'description: 按需参考规则',
+        '---',
+        '只有在特定场景才需要展开。'
+      ].join('\n')
+    )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [, options] = await resolvePromptAssetSelection({
+      bundle,
+      type: undefined
+    })
+
+    expect(options.systemPrompt).toContain('# base')
+    expect(options.systemPrompt).toContain('> 始终检查公共边界。')
+    expect(options.systemPrompt).toContain('# optional')
+    expect(options.systemPrompt).toContain('> Use when: 按需参考规则')
+    expect(options.systemPrompt).toContain('> Rule file path: .ai/rules/optional.md')
+    expect(options.systemPrompt).toContain('> Only read this rule file when the task matches the scenario above.')
+    expect(options.systemPrompt).not.toContain('> 只有在特定场景才需要展开。')
+  })
+
+  it('selects local assets by short name and scoped plugin assets explicitly', async () => {
+    const workspace = await createWorkspace()
+
+    await installPluginPackage(workspace, '@vibe-forge/plugin-demo', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-demo',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'specs/release/index.md': '---\ndescription: 插件发布流程\n---\n执行插件发布'
+    })
     await writeDocument(
       join(workspace, '.ai/specs/release.md'),
       '---\ndescription: 项目发布流程\n---\n执行项目发布'
     )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      configs: [{
+        plugins: [
+          { id: 'demo', scope: 'demo' }
+        ]
+      }, undefined],
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [localData, localOptions] = await resolvePromptAssetSelection({
+      bundle,
+      type: 'spec',
+      name: 'release'
+    })
+    const [pluginData, pluginOptions] = await resolvePromptAssetSelection({
+      bundle,
+      type: 'spec',
+      name: 'demo/release'
+    })
+    const localSpecId = bundle.specs.find(asset => asset.origin === 'workspace' && asset.name === 'release')?.id
+    const pluginSpecId = bundle.specs.find(asset => asset.origin === 'plugin' && asset.displayName === 'demo/release')
+      ?.id
+
+    expect(localData.targetBody).toContain('执行项目发布')
+    expect(localData.targetBody).not.toContain('执行插件发布')
+    expect(localOptions.systemPrompt).toContain('项目发布流程')
+    expect(localOptions.systemPrompt).toContain('demo/release')
+    expect(localOptions.promptAssetIds).toEqual(expect.arrayContaining([localSpecId]))
+
+    expect(pluginData.targetBody).toContain('执行插件发布')
+    expect(pluginOptions.systemPrompt).toContain('插件发布流程')
+    expect(pluginOptions.promptAssetIds).toEqual(expect.arrayContaining([pluginSpecId]))
+  })
+
+  it('formats rules as markdown headings and blockquotes', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/rules/required.md'),
+      [
+        '---',
+        'description: 必须执行的规则',
+        'alwaysApply: true',
+        '---',
+        '# 标题',
+        '',
+        '正文第一行',
+        '正文第二行'
+      ].join('\n')
+    )
     await writeDocument(
-      join(workspace, '.ai/plugins/demo/specs/release/index.md'),
-      '---\ndescription: 插件发布流程\n---\n执行插件发布'
+      join(workspace, '.ai/rules/summary-only.md'),
+      [
+        '---',
+        'description: 只展示摘要',
+        'alwaysApply: false',
+        '---',
+        '不应该出现在引用正文里'
+      ].join('\n')
     )
 
     const bundle = await resolveWorkspaceAssetBundle({
@@ -24,21 +134,259 @@ describe('resolvePromptAssetSelection', () => {
       configs: [undefined, undefined],
       useDefaultVibeForgeMcpServer: false
     })
-    const [data, resolvedOptions] = await resolvePromptAssetSelection({
+    const [, resolvedOptions] = await resolvePromptAssetSelection({
+      bundle,
+      type: undefined
+    })
+
+    expect(resolvedOptions.systemPrompt).toContain('# required')
+    expect(resolvedOptions.systemPrompt).toContain('> # 标题')
+    expect(resolvedOptions.systemPrompt).toContain('> 正文第一行')
+    expect(resolvedOptions.systemPrompt).toContain('> 正文第二行')
+    expect(resolvedOptions.systemPrompt).toContain('# summary-only')
+    expect(resolvedOptions.systemPrompt).toContain('> Use when: 只展示摘要')
+    expect(resolvedOptions.systemPrompt).toContain('> Rule file path: .ai/rules/summary-only.md')
+    expect(resolvedOptions.systemPrompt).not.toContain('> 不应该出现在引用正文里')
+    expect(resolvedOptions.systemPrompt).not.toContain('--------------------')
+  })
+
+  it('keeps skills as route-only guidance unless the target spec references them', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/skills/research/SKILL.md'),
+      [
+        '---',
+        'description: 检索项目信息',
+        '---',
+        '先读 README.md'
+      ].join('\n')
+    )
+    await writeDocument(
+      join(workspace, '.ai/skills/review/SKILL.md'),
+      [
+        '---',
+        'description: 评审代码改动',
+        '---',
+        '检查回归风险'
+      ].join('\n')
+    )
+    await writeDocument(
+      join(workspace, '.ai/specs/release/index.md'),
+      [
+        '---',
+        'description: 发布流程',
+        'skills:',
+        '  - research',
+        '---',
+        '执行发布'
+      ].join('\n')
+    )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [data, options] = await resolvePromptAssetSelection({
+      bundle,
+      type: 'spec',
+      name: 'release'
+    })
+
+    expect(data.targetSkills.map(skill => skill.resolvedName ?? skill.attributes.name)).toEqual(['research'])
+    expect(options.systemPrompt).toContain('The following skill modules are loaded for the project')
+    expect(options.systemPrompt).toContain('# research')
+    expect(options.systemPrompt).toContain('> Skill file path: .ai/skills/research/SKILL.md')
+    expect(options.systemPrompt).toContain('<skill-content>')
+    expect(options.systemPrompt).toContain('先读 README.md')
+    expect(options.systemPrompt).toContain('# review')
+    expect(options.systemPrompt).toContain('> Skill file path: .ai/skills/review/SKILL.md')
+    expect(options.systemPrompt).toContain(
+      '> Do not preload the body by default; read the corresponding skill file only when the task clearly requires it.'
+    )
+    expect(options.systemPrompt).not.toContain('<skill-content>\n检查回归风险\n</skill-content>')
+  })
+
+  it('keeps skills as route-only guidance in normal mode', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/skills/research/SKILL.md'),
+      [
+        '---',
+        'description: 检索项目信息',
+        '---',
+        '先读 README.md'
+      ].join('\n')
+    )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [data, options] = await resolvePromptAssetSelection({
+      bundle,
+      type: undefined
+    })
+
+    expect(data.targetSkills).toEqual([])
+    expect(options.systemPrompt).not.toContain('The following skill modules are loaded for the project')
+    expect(options.systemPrompt).toContain('<skills>')
+    expect(options.systemPrompt).toContain('# research')
+    expect(options.systemPrompt).toContain('> Skill file path: .ai/skills/research/SKILL.md')
+    expect(options.systemPrompt).toContain(
+      '> Do not preload the body by default; read the corresponding skill file only when the task clearly requires it.'
+    )
+    expect(options.systemPrompt).not.toContain('<skill-content>')
+    expect(options.systemPrompt).not.toContain('先读 README.md')
+  })
+
+  it('keeps spec route guidance without default identity in normal mode', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/specs/release/index.md'),
+      [
+        '---',
+        'description: 发布流程',
+        '---',
+        '执行发布'
+      ].join('\n')
+    )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [, options] = await resolvePromptAssetSelection({
+      bundle,
+      type: undefined
+    })
+
+    expect(options.systemPrompt).toContain('The project includes the following workflows')
+    expect(options.systemPrompt).toContain('Workflow name: release')
+    expect(options.systemPrompt).not.toContain('professional project execution manager')
+  })
+
+  it('injects spec identity guidance when a spec is actively selected', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/specs/release/index.md'),
+      [
+        '---',
+        'description: 发布流程',
+        '---',
+        '执行发布'
+      ].join('\n')
+    )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [, options] = await resolvePromptAssetSelection({
       bundle,
       type: 'spec',
       name: 'release'
     })
 
-    expect(data.targetBody).toContain('执行项目发布')
-    expect(data.targetBody).not.toContain('执行插件发布')
-    expect(data.specs).toHaveLength(1)
-    expect(resolvedOptions.systemPrompt).toContain('项目发布流程')
-    expect(resolvedOptions.systemPrompt).not.toContain('插件发布流程')
-    expect(resolvedOptions.promptAssetIds).toEqual(
-      expect.arrayContaining([
-        'spec:.ai/specs/release.md'
-      ])
+    expect(options.systemPrompt).toContain('professional project execution manager')
+    expect(options.systemPrompt).toContain('Never complete code development work alone')
+    expect(options.systemPrompt).toContain('Workflow name: release')
+  })
+
+  it('embeds referenced skills for entity mode and removes them from route guidance', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/skills/research/SKILL.md'),
+      [
+        '---',
+        'description: 检索项目信息',
+        '---',
+        '先读 README.md'
+      ].join('\n')
+    )
+    await writeDocument(
+      join(workspace, '.ai/skills/review/SKILL.md'),
+      [
+        '---',
+        'description: 评审代码改动',
+        '---',
+        '检查回归风险'
+      ].join('\n')
+    )
+    await writeDocument(
+      join(workspace, '.ai/entities/reviewer/README.md'),
+      [
+        '---',
+        'description: 代码评审实体',
+        'skills:',
+        '  - review',
+        '---',
+        '负责代码评审'
+      ].join('\n')
     )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [data, options] = await resolvePromptAssetSelection({
+      bundle,
+      type: 'entity',
+      name: 'reviewer'
+    })
+
+    expect(data.targetSkills.map(skill => skill.resolvedName ?? skill.attributes.name)).toEqual(['review'])
+    expect(options.systemPrompt).toContain('The following skill modules are loaded for the project')
+    expect(options.systemPrompt).toContain('# review')
+    expect(options.systemPrompt).toContain('<skill-content>')
+    expect(options.systemPrompt).toContain('检查回归风险')
+    expect(options.systemPrompt).not.toContain('<skills>\n# review')
+    expect(options.systemPrompt).toContain('<skills>')
+    expect(options.systemPrompt).toContain('# research')
+    expect(options.systemPrompt).toContain('> Skill file path: .ai/skills/research/SKILL.md')
+    expect(options.systemPrompt).not.toContain('<skill-content>\n先读 README.md\n</skill-content>')
+  })
+
+  it('does not preload all skills when the target entity omits skill references', async () => {
+    const workspace = await createWorkspace()
+
+    await writeDocument(
+      join(workspace, '.ai/skills/research/SKILL.md'),
+      [
+        '---',
+        'description: 检索项目信息',
+        '---',
+        '先读 README.md'
+      ].join('\n')
+    )
+    await writeDocument(
+      join(workspace, '.ai/entities/reviewer/README.md'),
+      [
+        '---',
+        'description: 代码评审实体',
+        '---',
+        '负责代码评审'
+      ].join('\n')
+    )
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      useDefaultVibeForgeMcpServer: false
+    })
+    const [data, options] = await resolvePromptAssetSelection({
+      bundle,
+      type: 'entity',
+      name: 'reviewer'
+    })
+
+    expect(data.targetSkills).toEqual([])
+    expect(options.systemPrompt).not.toContain('The following skill modules are loaded for the project')
+    expect(options.systemPrompt).toContain('# research')
+    expect(options.systemPrompt).toContain('> Skill file path: .ai/skills/research/SKILL.md')
+    expect(options.systemPrompt).not.toContain('先读 README.md')
   })
 })

package/__tests__/selection-internal.spec.ts

@@ -0,0 +1,42 @@
+import { describe, expect, it } from 'vitest'
+
+import type { WorkspaceAssetBundle } from '@vibe-forge/types'
+
+import { resolveSelectedMcpNames } from '#~/selection-internal.js'
+
+const createBundle = (): WorkspaceAssetBundle => ({
+  cwd: '/tmp/workspace',
+  pluginConfigs: [],
+  pluginInstances: [],
+  assets: [],
+  rules: [],
+  specs: [],
+  entities: [],
+  skills: [],
+  hookPlugins: [],
+  opencodeOverlayAssets: [],
+  defaultIncludeMcpServers: [],
+  defaultExcludeMcpServers: ['TypeScriptLanguageService'],
+  mcpServers: {
+    TypeScriptLanguageService: {
+      kind: 'mcpServer',
+      id: 'mcp:TypeScriptLanguageService',
+      scope: 'workspace',
+      name: 'TypeScriptLanguageService',
+      displayName: 'TypeScriptLanguageService',
+      source: '/tmp/workspace/.ai.config.json',
+      command: 'node',
+      args: ['tslspmcp']
+    }
+  }
+})
+
+describe('resolveSelectedMcpNames', () => {
+  it('lets an explicit include override default excludes', () => {
+    const selected = resolveSelectedMcpNames(createBundle(), {
+      include: ['TypeScriptLanguageService']
+    })
+
+    expect(selected).toEqual(['TypeScriptLanguageService'])
+  })
+})