@vibe-forge/workspace-assets 0.9.1-alpha.0 → 0.9.2-alpha.0

package/__tests__/adapter-asset-plan.spec.ts

@@ -4,43 +4,50 @@ import { describe, expect, it } from 'vitest'
 
 import { buildAdapterAssetPlan, resolvePromptAssetSelection, resolveWorkspaceAssetBundle } from '#~/index.js'
 
-import { createWorkspace, writeDocument } from './test-helpers'
+import { createWorkspace, installPluginPackage, writeDocument } from './test-helpers'
 
 describe('buildAdapterAssetPlan', () => {
-  it('builds codex diagnostics for prompt, mcp, native hooks, and unsupported claude native plugins', async () => {
+  it('builds codex diagnostics for prompt, mcp, hook plugins, and unsupported opencode assets', async () => {
     const workspace = await createWorkspace()
 
-    await writeDocument(
-      join(workspace, '.ai.config.json'),
-      JSON.stringify({
-        plugins: {
-          logger: {}
+    await installPluginPackage(workspace, '@vibe-forge/plugin-logger', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-logger',
+          version: '1.0.0'
         },
-        enabledPlugins: {
-          logger: true
+        null,
+        2
+      ),
+      'hooks.js': 'module.exports = {}\n'
+    })
+    await installPluginPackage(workspace, '@vibe-forge/plugin-demo', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-demo',
+          version: '1.0.0'
         },
-        mcpServers: {
-          docs: {
-            command: 'npx',
-            args: ['docs-server']
-          }
-        }
-      })
-    )
+        null,
+        2
+      ),
+      'opencode/commands/review.md': '# review\n'
+    })
     await writeDocument(
       join(workspace, '.ai/skills/research/SKILL.md'),
       '---\ndescription: 检索资料\n---\n阅读 README.md'
     )
+    await writeDocument(
+      join(workspace, '.ai/skills/review/SKILL.md'),
+      '---\ndescription: 代码评审\n---\n检查风险'
+    )
 
     const bundle = await resolveWorkspaceAssetBundle({
       cwd: workspace,
       configs: [{
-        plugins: {
-          logger: {}
-        },
-        enabledPlugins: {
-          logger: true
-        },
+        plugins: [
+          { id: 'logger' },
+          { id: 'demo', scope: 'demo' }
+        ],
         mcpServers: {
           docs: {
             command: 'npx',
@@ -50,6 +57,17 @@ describe('buildAdapterAssetPlan', () => {
       }, undefined],
       useDefaultVibeForgeMcpServer: false
     })
+    const researchSkillId = bundle.skills.find(asset => asset.name === 'research')?.id
+    const reviewSkillId = bundle.skills.find(asset => asset.name === 'review')?.id
+    const loggerHookPluginId = bundle.hookPlugins.find(asset => asset.packageId === '@vibe-forge/plugin-logger')?.id
+    const demoCommandId = bundle.opencodeOverlayAssets.find(asset => asset.kind === 'command')?.id
+    const docsMcpId = bundle.mcpServers.docs?.id
+    expect(researchSkillId).toBeDefined()
+    expect(reviewSkillId).toBeDefined()
+    expect(loggerHookPluginId).toBeDefined()
+    expect(demoCommandId).toBeDefined()
+    expect(docsMcpId).toBeDefined()
+
     const [, resolvedOptions] = await resolvePromptAssetSelection({
       bundle,
       type: undefined,
@@ -73,32 +91,33 @@ describe('buildAdapterAssetPlan', () => {
     })
 
     expect(plan.mcpServers).toHaveProperty('docs')
-    expect(plan.native.codexHooks?.supportedEvents).toEqual([
-      'SessionStart',
-      'UserPromptSubmit',
-      'PreToolUse',
-      'PostToolUse',
-      'Stop'
-    ])
     expect(plan.diagnostics).toEqual(expect.arrayContaining([
       expect.objectContaining({
+        assetId: researchSkillId,
         adapter: 'codex',
         status: 'prompt'
       }),
       expect.objectContaining({
         adapter: 'codex',
         status: 'native',
-        assetId: 'hookPlugin:project:logger'
+        assetId: loggerHookPluginId
       }),
       expect.objectContaining({
         adapter: 'codex',
         status: 'translated',
-        assetId: 'mcpServer:project:docs'
+        assetId: docsMcpId
       }),
       expect.objectContaining({
         adapter: 'codex',
         status: 'skipped',
-        assetId: 'nativePlugin:claude-code:logger'
+        assetId: demoCommandId
+      })
+    ]))
+    expect(plan.diagnostics).not.toEqual(expect.arrayContaining([
+      expect.objectContaining({
+        assetId: reviewSkillId,
+        adapter: 'codex',
+        status: 'prompt'
       })
     ]))
   })
@@ -106,18 +125,29 @@ describe('buildAdapterAssetPlan', () => {
   it('builds opencode overlays for skills and native commands', async () => {
     const workspace = await createWorkspace()
 
+    await installPluginPackage(workspace, '@vibe-forge/plugin-demo', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-demo',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'opencode/commands/review.md': '# review\n'
+    })
     await writeDocument(
       join(workspace, '.ai/skills/research/SKILL.md'),
       '---\ndescription: 检索资料\n---\n阅读 README.md'
     )
-    await writeDocument(
-      join(workspace, '.ai/plugins/demo/opencode/commands/review.md'),
-      '# review'
-    )
 
     const bundle = await resolveWorkspaceAssetBundle({
       cwd: workspace,
-      configs: [undefined, undefined],
+      configs: [{
+        plugins: [
+          { id: 'demo', scope: 'demo' }
+        ]
+      }, undefined],
       useDefaultVibeForgeMcpServer: false
     })
     const plan = buildAdapterAssetPlan({
@@ -129,6 +159,7 @@ describe('buildAdapterAssetPlan', () => {
         }
       }
     })
+    const commandAsset = bundle.opencodeOverlayAssets.find(asset => asset.kind === 'command')
 
     expect(plan.overlays).toEqual(expect.arrayContaining([
       expect.objectContaining({
@@ -140,5 +171,12 @@ describe('buildAdapterAssetPlan', () => {
         targetPath: 'commands/review.md'
       })
     ]))
+    expect(plan.diagnostics).toEqual(expect.arrayContaining([
+      expect.objectContaining({
+        assetId: commandAsset?.id,
+        adapter: 'opencode',
+        status: 'native'
+      })
+    ]))
   })
 })

package/__tests__/bundle.spec.ts

@@ -1,65 +1,70 @@
-import { join } from 'node:path'
 import process from 'node:process'
 
 import { describe, expect, it } from 'vitest'
 
 import { resolveWorkspaceAssetBundle } from '#~/index.js'
 
-import { createWorkspace, writeDocument } from './test-helpers'
+import { createWorkspace, installPluginPackage } from './test-helpers'
 
 describe('resolveWorkspaceAssetBundle', () => {
-  it('treats enabledPlugins as a global asset switch', async () => {
+  it('loads npm plugin assets via the package-id fallback and exposes OpenCode overlays', async () => {
     const workspace = await createWorkspace()
 
-    await writeDocument(
-      join(workspace, '.ai.config.json'),
-      JSON.stringify({
-        plugins: {
-          logger: {}
+    await installPluginPackage(workspace, '@vibe-forge/plugin-demo', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-demo',
+          version: '1.0.0'
         },
-        enabledPlugins: {
-          logger: false,
-          demo: false
-        }
-      })
-    )
-    await writeDocument(
-      join(workspace, '.ai/plugins/demo/skills/research/SKILL.md'),
-      '---\ndescription: 检索资料\n---\n阅读 README.md'
-    )
-    await writeDocument(
-      join(workspace, '.ai/plugins/demo/rules/review.md'),
-      '---\ndescription: 评审规则\n---\n必须检查风险'
-    )
-    await writeDocument(
-      join(workspace, '.ai/plugins/demo/mcp/browser.json'),
-      JSON.stringify({ command: 'npx', args: ['browser-server'] })
-    )
-    await writeDocument(
-      join(workspace, '.ai/plugins/demo/opencode/commands/review.md'),
-      '# review'
-    )
+        null,
+        2
+      ),
+      'skills/research/SKILL.md': '---\ndescription: 检索资料\n---\n阅读 README.md',
+      'rules/review.md': '---\ndescription: 评审规则\n---\n必须检查风险',
+      'mcp/browser.json': JSON.stringify({ command: 'npx', args: ['browser-server'] }, null, 2),
+      'opencode/commands/review.md': '# review\n'
+    })
+    await installPluginPackage(workspace, '@vibe-forge/plugin-logger', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-logger',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'hooks.js': 'module.exports = {}\n'
+    })
 
     const bundle = await resolveWorkspaceAssetBundle({
       cwd: workspace,
       configs: [{
-        plugins: {
-          logger: {}
-        },
-        enabledPlugins: {
-          logger: false,
-          demo: false
-        }
+        plugins: [
+          { id: 'demo', scope: 'demo' },
+          { id: 'logger' }
+        ]
       }, undefined],
       useDefaultVibeForgeMcpServer: false
     })
 
-    expect(bundle.skills).toHaveLength(0)
-    expect(bundle.rules).toHaveLength(0)
-    expect(Object.keys(bundle.mcpServers)).toHaveLength(0)
-    expect(bundle.hookPlugins).toHaveLength(0)
-    expect(bundle.assets.some((asset: (typeof bundle.assets)[number]) => asset.pluginId === 'demo' && asset.enabled))
-      .toBe(false)
+    expect(bundle.skills.map(asset => asset.displayName)).toEqual(['demo/research'])
+    expect(bundle.rules.map(asset => asset.displayName)).toEqual(['demo/review'])
+    expect(Object.keys(bundle.mcpServers)).toEqual(['demo/browser'])
+    expect(bundle.hookPlugins).toEqual(expect.arrayContaining([
+      expect.objectContaining({
+        packageId: '@vibe-forge/plugin-logger'
+      })
+    ]))
+    expect(bundle.hookPlugins).toHaveLength(1)
+    expect(bundle.opencodeOverlayAssets).toEqual(expect.arrayContaining([
+      expect.objectContaining({
+        kind: 'command',
+        sourcePath: expect.stringContaining('/node_modules/@vibe-forge/plugin-demo/opencode/commands/review.md'),
+        payload: expect.objectContaining({
+          targetSubpath: 'commands/review.md'
+        })
+      })
+    ]))
   })
 
   it('adds the built-in Vibe Forge MCP server when enabled and omits it when disabled', async () => {
@@ -85,4 +90,151 @@ describe('resolveWorkspaceAssetBundle', () => {
 
     expect(disabledBundle.mcpServers).not.toHaveProperty('vibe-forge')
   })
+
+  it('skips disabled plugin instances and lets disabled child overrides suppress default child activation', async () => {
+    const workspace = await createWorkspace()
+
+    await installPluginPackage(workspace, '@vibe-forge/plugin-demo', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-demo',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'skills/research/SKILL.md': '---\ndescription: 检索资料\n---\n阅读 README.md'
+    })
+    await installPluginPackage(workspace, '@vibe-forge/plugin-bundle', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-bundle',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'index.js': [
+        'module.exports = {',
+        '  __vibeForgePluginManifest: true,',
+        '  children: {',
+        '    review: {',
+        '      source: { type: "package", id: "@vibe-forge/plugin-review" },',
+        '      activation: "default"',
+        '    }',
+        '  }',
+        '}',
+        ''
+      ].join('\n')
+    })
+    await installPluginPackage(workspace, '@vibe-forge/plugin-review', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-review',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'skills/audit/SKILL.md': '---\ndescription: 代码审计\n---\n检查 child plugin 是否启用'
+    })
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      configs: [{
+        plugins: [
+          { id: 'demo', scope: 'demo', enabled: false },
+          {
+            id: 'bundle',
+            scope: 'bundle',
+            children: [
+              { id: 'review', enabled: false }
+            ]
+          }
+        ]
+      }, undefined],
+      useDefaultVibeForgeMcpServer: false
+    })
+
+    expect(bundle.skills).toEqual([])
+    expect(bundle.pluginInstances.map(instance => instance.packageId)).toEqual(['@vibe-forge/plugin-bundle'])
+  })
+
+  it('lets later config layers disable matching plugin instances by id and scope', async () => {
+    const workspace = await createWorkspace()
+
+    await installPluginPackage(workspace, '@vibe-forge/plugin-logger', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-logger',
+          version: '1.0.0'
+        },
+        null,
+        2
+      ),
+      'hooks.js': 'module.exports = {}\n'
+    })
+
+    const bundle = await resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      configs: [
+        {
+          plugins: [
+            { id: 'logger' }
+          ]
+        },
+        {
+          plugins: [
+            { id: 'logger', enabled: false }
+          ]
+        }
+      ],
+      useDefaultVibeForgeMcpServer: false
+    })
+
+    expect(bundle.pluginConfigs).toEqual([
+      { id: 'logger', enabled: false }
+    ])
+    expect(bundle.pluginInstances).toEqual([])
+    expect(bundle.hookPlugins).toEqual([])
+  })
+
+  it('surfaces invalid plugin manifests instead of silently falling back to directory scanning', async () => {
+    const workspace = await createWorkspace()
+
+    await installPluginPackage(workspace, '@vibe-forge/plugin-bad-manifest', {
+      'package.json': JSON.stringify(
+        {
+          name: '@vibe-forge/plugin-bad-manifest',
+          version: '1.0.0',
+          exports: {
+            '.': './index.js'
+          }
+        },
+        null,
+        2
+      ),
+      'index.js': [
+        'module.exports = {',
+        '  __vibeForgePluginManifest: true,',
+        '  scope: "bad",',
+        '  assets: {',
+        '    skills: "./custom-skills"',
+        '  }',
+        '}',
+        ''
+      ].join('\n'),
+      'custom-skills/research/SKILL.md': '---\ndescription: 检索资料\n---\n阅读 README.md'
+    })
+
+    await expect(resolveWorkspaceAssetBundle({
+      cwd: workspace,
+      configs: [{
+        plugins: [
+          { id: '@vibe-forge/plugin-bad-manifest' }
+        ]
+      }, undefined],
+      useDefaultVibeForgeMcpServer: false
+    })).rejects.toThrow('Failed to load plugin manifest for @vibe-forge/plugin-bad-manifest')
+  })
 })

package/__tests__/prompt-builders.spec.ts

@@ -0,0 +1,206 @@
+import { join } from 'node:path'
+
+import { describe, expect, it } from 'vitest'
+
+import {
+  generateEntitiesRoutePrompt,
+  generateRulesPrompt,
+  generateSkillsPrompt,
+  generateSkillsRoutePrompt,
+  generateSpecRoutePrompt
+} from '#~/prompt-builders.js'
+
+describe('workspace asset prompt builders', () => {
+  it('builds skill prompts with stable names, descriptions, and relative paths', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateSkillsPrompt(cwd, [
+      {
+        path: join(cwd, '.ai/skills/research/SKILL.md'),
+        body: '阅读 README.md\n',
+        attributes: {
+          description: '检索项目信息'
+        }
+      }
+    ])
+
+    expect(prompt).toContain('The following skill modules are loaded for the project')
+    expect(prompt).toContain('# research')
+    expect(prompt).toContain('> Skill description: 检索项目信息')
+    expect(prompt).toContain('> Skill file path: .ai/skills/research/SKILL.md')
+    expect(prompt).toContain('<skill-content>')
+    expect(prompt).not.toContain('/tmp/project/.ai/skills/research/SKILL.md')
+  })
+
+  it('builds rules prompts with embedded always rules and summary-only optional rules', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateRulesPrompt(cwd, [
+      {
+        path: join(cwd, '.ai/rules/base.md'),
+        body: '始终检查公共边界。',
+        attributes: {
+          alwaysApply: true
+        }
+      },
+      {
+        path: join(cwd, '.ai/rules/optional.md'),
+        body: '仅在需要时展开。',
+        attributes: {
+          description: '按需规则',
+          alwaysApply: false
+        }
+      }
+    ])
+
+    expect(prompt).toContain('# base')
+    expect(prompt).toContain('> 始终检查公共边界。')
+    expect(prompt).toContain('> Use when: 按需规则')
+    expect(prompt).toContain('> Rule file path: .ai/rules/optional.md')
+    expect(prompt).not.toContain('> 仅在需要时展开。')
+  })
+
+  it('builds rule prompts with markdown headings and blockquotes', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateRulesPrompt(cwd, [
+      {
+        path: join(cwd, '.ai/rules/required.md'),
+        body: '# 标题\n\n正文',
+        attributes: {
+          alwaysApply: true
+        }
+      },
+      {
+        path: join(cwd, '.ai/rules/summary-only.md'),
+        body: '不应该内联',
+        attributes: {
+          description: '只展示摘要',
+          alwaysApply: false
+        }
+      }
+    ])
+
+    expect(prompt).toContain('# required')
+    expect(prompt).toContain('> # 标题')
+    expect(prompt).toContain('> 正文')
+    expect(prompt).toContain('# summary-only')
+    expect(prompt).toContain('> Use when: 只展示摘要')
+    expect(prompt).toContain('> Rule file path: .ai/rules/summary-only.md')
+    expect(prompt).not.toContain('> 不应该内联')
+    expect(prompt).not.toContain('--------------------')
+  })
+
+  it('builds spec route prompts with logical identifiers and active identity guidance', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateSpecRoutePrompt([
+      {
+        path: join(cwd, '.ai/specs/release/index.md'),
+        body: '发布流程',
+        attributes: {
+          params: [
+            {
+              name: 'version',
+              description: '版本号'
+            }
+          ]
+        }
+      }
+    ], { active: true })
+
+    expect(prompt).toContain('professional project execution manager')
+    expect(prompt).toContain('Workflow name: release')
+    expect(prompt).toContain('Identifier: release')
+    expect(prompt).toContain('    - version: 版本号')
+    expect(prompt).toContain('use the workflow identifier to locate and load the corresponding definition')
+    expect(prompt).not.toContain('load-spec')
+  })
+
+  it('builds spec route prompts without exposing file paths', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateSpecRoutePrompt([
+      {
+        path: join(cwd, '.ai/specs/release/index.md'),
+        body: '发布流程\n执行发布任务',
+        attributes: {
+          params: [
+            {
+              name: 'version',
+              description: '版本号'
+            }
+          ]
+        }
+      },
+      {
+        path: join(cwd, '.ai/specs/internal.md'),
+        body: '内部流程',
+        attributes: {
+          always: false
+        }
+      }
+    ])
+
+    expect(prompt).toContain('Workflow name: release')
+    expect(prompt).toContain('Description: 发布流程')
+    expect(prompt).toContain('Identifier: release')
+    expect(prompt).toContain('    - version: 版本号')
+    expect(prompt).toContain('use the workflow identifier to locate and load the corresponding definition')
+    expect(prompt).not.toContain('load-spec')
+    expect(prompt).not.toContain('professional project execution manager')
+    expect(prompt).not.toContain('.ai/specs/release/index.md')
+    expect(prompt).not.toContain('internal')
+  })
+
+  it('builds entity routes from summaries instead of full bodies', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateEntitiesRoutePrompt([
+      {
+        path: join(cwd, '.ai/entities/reviewer/README.md'),
+        body: '负责代码审查\n需要关注变更风险',
+        attributes: {}
+      },
+      {
+        path: join(cwd, '.ai/entities/hidden.md'),
+        body: '不应暴露',
+        attributes: {
+          name: 'hidden',
+          always: false
+        }
+      }
+    ])
+
+    expect(prompt).toContain('reviewer: 负责代码审查')
+    expect(prompt).toContain('`vibe-forge.StartTasks`')
+    expect(prompt).toContain('`GetTaskInfo`')
+    expect(prompt).toContain('`wait`')
+    expect(prompt).not.toContain('run-tasks')
+    expect(prompt).not.toContain('需要关注变更风险')
+    expect(prompt).not.toContain('hidden')
+  })
+
+  it('builds skill route prompts without preloading content', () => {
+    const cwd = '/tmp/project'
+
+    const prompt = generateSkillsRoutePrompt(cwd, [
+      {
+        path: join(cwd, '.ai/skills/research/SKILL.md'),
+        body: '阅读 README.md\n',
+        attributes: {
+          description: '检索项目信息'
+        }
+      }
+    ])
+
+    expect(prompt).toContain('# research')
+    expect(prompt).toContain('> Skill description: 检索项目信息')
+    expect(prompt).toContain('> Skill file path: .ai/skills/research/SKILL.md')
+    expect(prompt).toContain(
+      '> Do not preload the body by default; read the corresponding skill file only when the task clearly requires it.'
+    )
+    expect(prompt).not.toContain('<skill-content>')
+    expect(prompt).not.toContain('阅读 README.md')
+  })
+})