@vertesia/ui 1.5.0-dev.20260807.073259Z → 1.5.0-dev.20260901.005903Z

package/src/features/agent/chat/ModernAgentOutput/AllMessagesMixed.test.tsx

@@ -52,24 +52,41 @@ function renderSummary(
     props: Partial<React.ComponentProps<typeof AllMessagesMixed>> = {},
 ) {
     const bottomRef = React.createRef<HTMLDivElement>() as React.RefObject<HTMLDivElement>;
-
-    return render(
+    const renderConversation = (
+        currentMessages: AgentMessage[],
+        currentIsCompleted: boolean,
+        currentStreamingMessages: Map<string, StreamingData>,
+        currentProps: Partial<React.ComponentProps<typeof AllMessagesMixed>>,
+    ) => (
         <I18nProvider lng="en">
             <ReactRouterContext.Provider value={makeRouterContext()}>
                 <AgentResourceResolverProvider value={testResourceResolver}>
                     <AllMessagesMixed
-                        messages={messages}
+                        messages={currentMessages}
                         bottomRef={bottomRef}
                         viewMode="sliding"
-                        isCompleted={isCompleted}
+                        isCompleted={currentIsCompleted}
                         artifactRunId="run-1"
-                        streamingMessages={streamingMessages}
-                        {...props}
+                        streamingMessages={currentStreamingMessages}
+                        {...currentProps}
                     />
                 </AgentResourceResolverProvider>
             </ReactRouterContext.Provider>
-        </I18nProvider>,
+        </I18nProvider>
     );
+
+    const result = render(renderConversation(messages, isCompleted, streamingMessages, props));
+    return {
+        ...result,
+        rerenderSummary(
+            nextMessages: AgentMessage[],
+            nextIsCompleted = false,
+            nextStreamingMessages = new Map<string, StreamingData>(),
+            nextProps: Partial<React.ComponentProps<typeof AllMessagesMixed>> = {},
+        ) {
+            result.rerender(renderConversation(nextMessages, nextIsCompleted, nextStreamingMessages, nextProps));
+        },
+    };
 }
 
 function renderStacked(
@@ -766,6 +783,72 @@ describe('AllMessagesMixed summary view', () => {
         expect(screen.getByText('Main agent response.')).not.toBeNull();
     });
 
+    it('keeps streamed and persisted child output in the owning workstream throughout its lifecycle', () => {
+        const question = makeMessage({
+            timestamp: 1_000,
+            type: AgentMessageType.QUESTION,
+            message: 'Research the launch plan.',
+        });
+        const launch = makeMessage({
+            timestamp: 2_000,
+            type: AgentMessageType.UPDATE,
+            message: 'Research workstream launched',
+            workstream_id: 'research',
+            details: {
+                event_class: 'activity',
+                workstream_event: 'launched',
+                launch_id: 'launch-research',
+                workstream_id: 'research',
+                child_workflow_id: 'workstream:research',
+                child_workflow_run_id: 'run-research',
+            },
+        });
+        const sourceMessages = [question, launch];
+        const streamingMessages = new Map<string, StreamingData>([
+            [
+                'research-stream',
+                {
+                    text: 'Research is still streaming.',
+                    startTimestamp: 3_000,
+                    workstreamId: 'research',
+                },
+            ],
+        ]);
+        const { rerenderSummary } = renderSummary(sourceMessages, false, streamingMessages, {
+            workstreamSourceMessages: sourceMessages,
+            activeWorkstream: 'all',
+        });
+
+        expect(screen.queryByText('Research is still streaming.')).toBeNull();
+
+        rerenderSummary(sourceMessages, false, streamingMessages, {
+            workstreamSourceMessages: sourceMessages,
+            activeWorkstream: 'research',
+        });
+        expect(screen.getByText('Research is still streaming.')).not.toBeNull();
+
+        const persistedChildAnswer = makeMessage({
+            timestamp: 4_000,
+            type: AgentMessageType.ANSWER,
+            message: 'Research is complete.',
+            workstream_id: 'research',
+            details: { streamed: true },
+        });
+        const completedMessages = [...sourceMessages, persistedChildAnswer];
+
+        rerenderSummary(completedMessages, true, new Map(), {
+            workstreamSourceMessages: completedMessages,
+            activeWorkstream: 'research',
+        });
+        expect(screen.getByText('Research is complete.')).not.toBeNull();
+
+        rerenderSummary(completedMessages, true, new Map(), {
+            workstreamSourceMessages: completedMessages,
+            activeWorkstream: 'all',
+        });
+        expect(screen.queryByText('Research is complete.')).toBeNull();
+    });
+
     it('renders first child workflow activity as a workstream row when the launch event is missing', () => {
         renderSummary(
             [

package/src/features/agent/chat/ModernAgentOutput/AllMessagesMixed.tsx

@@ -93,6 +93,7 @@ import {
     getWorkstreamId,
     groupMessagesWithStreaming,
     isInProgress,
+    isStreamingDataVisibleInWorkstream,
     isToolActivityMessage,
     isToolPreambleMessage,
     isUserStoppedMessage,
@@ -2867,11 +2868,7 @@ function AllMessagesMixedComponent({
         const complete = new Map<string, StreamingData>();
         const incomplete: Array<{ id: string; data: StreamingData }> = [];
         streamingMessages.forEach((data, id) => {
-            // Filter by workstream if specified
-            if (activeWorkstream && activeWorkstream !== 'all') {
-                const streamWorkstream = data.workstreamId || 'main';
-                if (activeWorkstream !== streamWorkstream) return;
-            }
+            if (!isStreamingDataVisibleInWorkstream(data, activeWorkstream)) return;
 
             // If a newer persisted message exists, this stream is stale and should be
             // treated as complete for ordering purposes.
@@ -3353,9 +3350,10 @@ function AllMessagesMixedComponent({
             )}
 
             {displayMessages.length === 0 &&
+            incompleteStreaming.length === 0 &&
             !hasRenderableInitialRequest &&
             !(isSummaryView && showActivityFallback) ? (
-                activeWorkstream === 'all' && isAgentWorking && incompleteStreaming.length === 0 ? (
+                activeWorkstream === 'all' && isAgentWorking ? (
                     <div className="flex-1 px-2 py-6 sm:px-4">
                         <InitialRequestWaitingCard
                             label={t('agent.preparing')}

package/src/features/agent/chat/ModernAgentOutput/AttachmentPreview.test.ts

@@ -1,6 +1,6 @@
 import { type AgentMessage, AgentMessageType } from '@vertesia/common';
 import { describe, expect, it } from 'vitest';
-import { collectDeliveredArtifactRefs } from './AttachmentPreview';
+import { collectDeliveredArtifactRefs, parseUserMessageAttachments } from './AttachmentPreview';
 
 function question(message: string, details?: AgentMessage['details']): AgentMessage {
     return {
@@ -13,7 +13,109 @@ function question(message: string, details?: AgentMessage['details']): AgentMess
     };
 }
 
+describe('parseUserMessageAttachments', () => {
+    // Filenames with parentheses (browser download suffixes like "report (6).json") flow
+    // verbatim into artifact hrefs. A first-closing-paren href capture made these lines fail
+    // to parse: the file rendered as raw text and its chip outlived delivery because the
+    // reference never reached collectDeliveredArtifactRefs.
+    it('parses hrefs containing parentheses', () => {
+        const parsed = parseUserMessageAttachments(
+            'Look at this.\n\nUploaded artifacts:\n[report (6).json](artifact:files/report (6).json)',
+        );
+
+        expect(parsed.body).toBe('Look at this.');
+        expect(parsed.attachments).toHaveLength(1);
+        expect(parsed.attachments[0].name).toBe('report (6).json');
+        expect(parsed.attachments[0].href).toBe('artifact:files/report (6).json');
+        expect(parsed.attachments[0].artifactPath).toBe('files/report (6).json');
+    });
+
+    it('splits href from trailing note even when both contain parentheses', () => {
+        const parsed = parseUserMessageAttachments(
+            [
+                'Attachments:',
+                '- [scan (2).png](artifact:files/scan (2).png) (image - use view_image tool with path "files/scan (2).png" to see it)',
+                '- [notes (v2).pdf](artifact:files/notes (v2).pdf) (text extracted to files/notes (v2).pdf.md)',
+            ].join('\n'),
+        );
+
+        expect(parsed.attachments).toHaveLength(2);
+        expect(parsed.attachments[0].href).toBe('artifact:files/scan (2).png');
+        // The note still drives the image content-type heuristic.
+        expect(parsed.attachments[0].contentType).toBe('image/*');
+        expect(parsed.attachments[1].href).toBe('artifact:files/notes (v2).pdf');
+        expect(parsed.attachments[1].contentType).toBeUndefined();
+    });
+
+    // Only the two note shapes the server formatter emits may split a line. Without that
+    // check, a note-less filename carrying its own parens is cut at the last ") (", yielding
+    // a truncated href whose reference never matches — the chip then outlives delivery.
+    it('does not split a note-less filename that contains ") ("', () => {
+        const parsed = parseUserMessageAttachments(
+            'Uploaded artifacts:\n[a (b) (c).pdf](artifact:files/a (b) (c).pdf)',
+        );
+
+        expect(parsed.attachments).toHaveLength(1);
+        expect(parsed.attachments[0].name).toBe('a (b) (c).pdf');
+        expect(parsed.attachments[0].href).toBe('artifact:files/a (b) (c).pdf');
+        expect(parsed.attachments[0].artifactPath).toBe('files/a (b) (c).pdf');
+    });
+
+    // The previous regex pair backtracked polynomially on lines packed with ") (" sequences
+    // (CodeQL js/polynomial-redos). The scanner must stay linear and still pick the rightmost
+    // note split — the same split the greedy regex produced.
+    it('handles pathological paren-dense lines in linear time with the rightmost note split', () => {
+        const hostile = `[a](${') ('.repeat(20_000)}x) (image - hostile)`;
+        const started = performance.now();
+        const parsed = parseUserMessageAttachments(`Uploaded artifacts:\n${hostile}`);
+        expect(performance.now() - started).toBeLessThan(200);
+
+        expect(parsed.attachments).toHaveLength(1);
+        expect(parsed.attachments[0].href).toBe(`${') ('.repeat(20_000)}x`);
+        expect(parsed.attachments[0].contentType).toBe('image/*');
+    });
+
+    // Every ") (" above is a candidate the scanner must reject (unknown note prefix) before
+    // falling through to the whole-body href. That rejection path is the one a quadratic
+    // implementation would blow up on, so it gets its own budget.
+    it('stays linear when every note candidate is rejected', () => {
+        const hostile = `[a](${') ('.repeat(20_000)}x)`;
+        const started = performance.now();
+        const parsed = parseUserMessageAttachments(`Uploaded artifacts:\n${hostile}`);
+        expect(performance.now() - started).toBeLessThan(200);
+
+        expect(parsed.attachments).toHaveLength(1);
+        expect(parsed.attachments[0].href).toBe(`${') ('.repeat(20_000)}x`);
+    });
+
+    it('keeps parsing plain links and note-suffixed links without parentheses', () => {
+        const parsed = parseUserMessageAttachments(
+            [
+                'Uploaded artifacts:',
+                '[report.pdf](artifact:files/report.pdf)',
+                '- [photo.png](artifact:files/photo.png) (image - use view_image tool with path "files/photo.png" to see it)',
+            ].join('\n'),
+        );
+
+        expect(parsed.attachments.map((a) => a.href)).toEqual([
+            'artifact:files/report.pdf',
+            'artifact:files/photo.png',
+        ]);
+        expect(parsed.attachments[1].contentType).toBe('image/*');
+    });
+});
+
 describe('collectDeliveredArtifactRefs', () => {
+    it('collects references for filenames containing parentheses', () => {
+        const refs = collectDeliveredArtifactRefs([
+            question(
+                '[Files Ready] All 1 file(s)...\n\nUploaded artifacts:\n[filaments-bundle (6).json](artifact:files/filaments-bundle (6).json)',
+            ),
+        ]);
+
+        expect(refs).toEqual(new Set(['artifact:files/filaments-bundle (6).json', 'files/filaments-bundle (6).json']));
+    });
+
     it('collects attachment references from persisted user messages', () => {
         const refs = collectDeliveredArtifactRefs([
             question('Review this.\n\nUploaded artifacts:\n[report.pdf](artifact:files/report.pdf)'),

package/src/features/agent/chat/ModernAgentOutput/AttachmentPreview.tsx

@@ -428,7 +428,53 @@ export function AttachmentPreviewList({
 }
 
 const ATTACHMENT_SECTION_RE = /^\s*(?:\*\*)?(attachments|uploaded artifacts):(?:\*\*)?\s*$/i;
-const ATTACHMENT_LINK_RE = /^\s*(?:[-*]\s*)?\[([^\]]+)]\(([^)]+)\)(?:\s+\((.*)\))?\s*$/;
+
+const SINGLE_WHITESPACE_RE = /\s/;
+
+/** The only note shapes the server-side formatter emits (see processUserMessages). */
+const ATTACHMENT_NOTE_PREFIXES = ['image -', 'text extracted to '];
+
+interface AttachmentLineParts {
+    name: string;
+    href: string;
+    note?: string;
+}
+
+/**
+ * Parse one attachment line of the form `- [label](href)` or `- [label](href) (note)`.
+ *
+ * Hrefs mirror user filenames, so they can contain parentheses and spaces
+ * ("artifact:files/report (6).json"), and workflow-composed lines append a parenthesized note
+ * ("(image - ...)", "(text extracted to ...)") that can itself contain parentheses. A regex for
+ * that shape needs overlapping greedy captures, which backtrack polynomially on message content
+ * (CodeQL js/polynomial-redos) — so the line is split with a linear scan instead: the label runs
+ * to the first "]", and the note starts at the rightmost "(" that is preceded by whitespace and
+ * a ")" AND opens one of the known note shapes. Requiring a known prefix is what keeps a
+ * note-less filename such as "a (b) (c).pdf" from being split at its own parentheses.
+ */
+function parseAttachmentLine(trimmed: string): AttachmentLineParts | null {
+    let text = trimmed;
+    if (text.startsWith('-') || text.startsWith('*')) {
+        text = text.slice(1).trimStart();
+    }
+    if (!text.startsWith('[') || !text.endsWith(')')) return null;
+    const labelEnd = text.indexOf(']');
+    if (labelEnd < 2 || text[labelEnd + 1] !== '(') return null;
+    const name = text.slice(1, labelEnd);
+    // Everything between "](" and the final ")": either the whole href, or "href) (note".
+    const body = text.slice(labelEnd + 2, -1);
+    for (let open = body.lastIndexOf('('); open > 0; open = body.lastIndexOf('(', open - 1)) {
+        let wsStart = open;
+        while (wsStart > 0 && SINGLE_WHITESPACE_RE.test(body[wsStart - 1])) {
+            wsStart--;
+        }
+        if (wsStart === open || wsStart < 2 || body[wsStart - 1] !== ')') continue;
+        const note = body.slice(open + 1);
+        if (!ATTACHMENT_NOTE_PREFIXES.some((prefix) => note.startsWith(prefix))) continue;
+        return { name, href: body.slice(0, wsStart - 1), note };
+    }
+    return body ? { name, href: body } : null;
+}
 
 export function parseUserMessageAttachments(content: string): ParsedUserAttachments {
     const lines = content.split(/\r?\n/);
@@ -453,14 +499,14 @@ export function parseUserMessageAttachments(content: string): ParsedUserAttachme
             continue;
         }
 
-        const match = ATTACHMENT_LINK_RE.exec(trimmed);
-        if (!match) {
+        const parsed = parseAttachmentLine(trimmed);
+        if (!parsed) {
             inAttachmentSection = false;
             bodyLines.push(line);
             continue;
         }
 
-        const [, name, href, note] = match;
+        const { name, href, note } = parsed;
         const artifactPath = href.startsWith('artifact:') ? href.slice('artifact:'.length) : undefined;
         attachments.push({
             id: `${href}-${attachments.length}`,

package/src/features/agent/chat/ModernAgentOutput/BatchProgressPanel.tsx

@@ -1,9 +1,9 @@
 import type { AgentMessage, BatchItemStatus, BatchProgressDetails } from '@vertesia/common';
 import { Button, cn, onActivateKey, useToast } from '@vertesia/ui/core';
 import { useUITranslation } from '@vertesia/ui/i18n';
-import dayjs from 'dayjs';
 import { AlertCircle, CheckCircle, ChevronDown, ChevronRight, CopyIcon, Layers, Loader2 } from 'lucide-react';
 import { memo, useState } from 'react';
+import dayjs from '../../../../core/utils/dayjs.js';
 import { PulsatingCircle } from '../AnimatedThinkingDots';
 
 export interface BatchProgressPanelProps {

package/src/features/agent/chat/ModernAgentOutput/Header.tsx

@@ -12,6 +12,7 @@ import {
     ExternalLink,
     GitFork,
     InfoIcon,
+    MessageCirclePlus,
     MessageSquareText,
     MoreVertical,
     Rows3,
@@ -194,6 +195,22 @@ export default function Header({
                 </Button>
             )}
 
+            {resetWorkflow && (
+                <Button
+                    type="button"
+                    size={variant === 'compact' ? 'icon' : 'sm'}
+                    variant="ghost"
+                    onClick={resetWorkflow}
+                    title={t('agent.startNewConversation')}
+                    className={cn(
+                        'transition-all duration-200 rounded-md',
+                        variant === 'compact' && 'size-8 rounded-lg',
+                    )}
+                >
+                    <MessageCirclePlus className={cn('size-4', variant === 'full' && 'me-1.5')} />
+                </Button>
+            )}
+
             {/* More actions */}
             <MoreDropdown
                 compact={isCompact}
@@ -237,7 +254,7 @@ export default function Header({
         <PayloadBuilderProvider>
             <div
                 className={cn(
-                    'flex flex-wrap items-end justify-between py-1.5 px-2 border-b shadow-sm flex-shrink-0',
+                    'flex flex-wrap items-center justify-between py-1.5 px-2 border-b shadow-sm flex-shrink-0',
                     className,
                 )}
             >

package/src/features/agent/chat/ModernAgentOutput/MessageItem.tsx

@@ -9,7 +9,6 @@ import { useUITranslation } from '@vertesia/ui/i18n';
 import { useRouterContext } from '@vertesia/ui/router';
 import { useUserSession } from '@vertesia/ui/session';
 import { MarkdownRenderer } from '@vertesia/ui/widgets';
-import dayjs from 'dayjs';
 import {
     AlertCircle,
     Bot,
@@ -26,6 +25,7 @@ import {
 } from 'lucide-react';
 import type React from 'react';
 import { memo, useEffect, useMemo, useRef, useState } from 'react';
+import dayjs from '../../../../core/utils/dayjs.js';
 import { useDownloadFile } from '../../../store/objects/components/useDownloadFile.js';
 import { PulsatingCircle } from '../AnimatedThinkingDots';
 import { AskUserWidget } from '../AskUserWidget';

package/src/features/agent/chat/ModernAgentOutput/StreamingMessage.tsx

@@ -1,9 +1,9 @@
 import { Button, cn, useToast } from '@vertesia/ui/core';
 import { useUITranslation } from '@vertesia/ui/i18n';
 import { MarkdownRenderer } from '@vertesia/ui/widgets';
-import dayjs from 'dayjs';
 import { Bot, CopyIcon } from 'lucide-react';
 import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
+import dayjs from '../../../../core/utils/dayjs.js';
 
 // PERFORMANCE: Unicode cursor character - rendered inline with text
 // This avoids expensive DOM manipulation with TreeWalker on every update

package/src/features/agent/chat/ModernAgentOutput/ToolCallGroup.tsx

@@ -8,9 +8,9 @@ import { Button, cn, onActivateKey, useToast } from '@vertesia/ui/core';
 import { useUITranslation } from '@vertesia/ui/i18n';
 import { useUserSession } from '@vertesia/ui/session';
 import { MarkdownRenderer } from '@vertesia/ui/widgets';
-import dayjs from 'dayjs';
 import { AlertCircle, AlertTriangle, Bot, CheckCircle, ChevronDown, ChevronRight, CopyIcon } from 'lucide-react';
 import { memo, useEffect, useMemo, useRef, useState } from 'react';
+import dayjs from '../../../../core/utils/dayjs.js';
 import { PulsatingCircle } from '../AnimatedThinkingDots';
 import { useImageLightbox } from '../ImageLightbox';
 import { getArtifactCacheKey, useArtifactUrlCache } from '../useArtifactUrlCache.js';