@vertesia/ui 1.5.0-dev.20260807.073259Z → 1.5.0-dev.20260826.064249Z

package/src/features/facets/WorkflowExecutionsFacetsNav.tsx

@@ -1,4 +1,4 @@
-import type { FacetBucket } from '@vertesia/common';
+import type { FacetBucket, ListWorkflowRunsPayload } from '@vertesia/common';
 import {
     type Filter as BaseFilter,
     FilterBar,
@@ -8,7 +8,12 @@ import {
     FilterProvider,
 } from '@vertesia/ui/core';
 import { useState } from 'react';
-import { filterValueToQueryValue, type SearchInterface, setSearchQueryValue } from './utils/SearchInterface';
+import {
+    createSearchQueryKeyGuard,
+    filterValueToQueryValue,
+    type SearchInterface,
+    setSearchQueryValue,
+} from './utils/SearchInterface';
 import { VStringFacet } from './utils/VStringFacet';
 import { VUserFacet } from './utils/VUserFacet';
 
@@ -17,16 +22,30 @@ interface WorkflowExecutionsFacetsNavProps {
         status?: FacetBucket[];
         initiated_by?: FacetBucket[];
     };
-    search: SearchInterface;
+    search: WorkflowRunsSearchInterface;
 }
 
+const workflowExecutionFilterNames = [
+    'search_term',
+    'status',
+    'initiated_by',
+    'start',
+    'end',
+    'has_reported_errors',
+] as const satisfies readonly (keyof ListWorkflowRunsPayload)[];
+
+type WorkflowExecutionFilterName = (typeof workflowExecutionFilterNames)[number];
+type WorkflowExecutionFilterGroup = Omit<FilterGroup, 'name'> & { name: WorkflowExecutionFilterName };
+type WorkflowRunsSearchInterface = SearchInterface<ListWorkflowRunsPayload>;
+const isWorkflowExecutionFilterName = createSearchQueryKeyGuard<ListWorkflowRunsPayload>(workflowExecutionFilterNames);
+
 // Hook to create filter groups for workflow executions
 export function useWorkflowExecutionsFilterGroups(facets: WorkflowExecutionsFacetsNavProps['facets']): FilterGroup[] {
-    const customFilterGroups: FilterGroup[] = [];
+    const customFilterGroups: WorkflowExecutionFilterGroup[] = [];
 
     customFilterGroups.push({
         placeholder: 'Workflow Name or Workflow Run ID',
-        name: 'name',
+        name: 'search_term',
         type: 'text',
         options: [],
     });
@@ -37,7 +56,7 @@ export function useWorkflowExecutionsFilterGroups(facets: WorkflowExecutionsFace
             name: 'status',
             placeholder: 'Status',
         });
-        customFilterGroups.push(statusFilterGroup);
+        customFilterGroups.push({ ...statusFilterGroup, name: 'status' });
     }
 
     if (facets.initiated_by) {
@@ -46,7 +65,7 @@ export function useWorkflowExecutionsFilterGroups(facets: WorkflowExecutionsFace
             name: 'initiated_by',
             placeholder: 'Initiated By',
         });
-        customFilterGroups.push(initiatedByFilterGroup);
+        customFilterGroups.push({ ...initiatedByFilterGroup, name: 'initiated_by' });
     }
 
     const dateAfterFilterGroup = {
@@ -54,7 +73,7 @@ export function useWorkflowExecutionsFilterGroups(facets: WorkflowExecutionsFace
         placeholder: 'Date After',
         type: 'date' as const,
         multiple: false,
-    };
+    } satisfies WorkflowExecutionFilterGroup;
     customFilterGroups.push(dateAfterFilterGroup);
 
     const dateBeforeFilterGroup = {
@@ -62,7 +81,7 @@ export function useWorkflowExecutionsFilterGroups(facets: WorkflowExecutionsFace
         placeholder: 'Date Before',
         type: 'date' as const,
         multiple: false,
-    };
+    } satisfies WorkflowExecutionFilterGroup;
     customFilterGroups.push(dateBeforeFilterGroup);
 
     const hasReportedErrorsFilterGroup = {
@@ -74,14 +93,14 @@ export function useWorkflowExecutionsFilterGroups(facets: WorkflowExecutionsFace
             { label: 'Yes', value: 'true' },
             { label: 'No', value: 'false' },
         ],
-    };
+    } satisfies WorkflowExecutionFilterGroup;
     customFilterGroups.push(hasReportedErrorsFilterGroup);
 
     return customFilterGroups;
 }
 
 // Hook to create filter change handler for workflow executions
-export function useWorkflowExecutionsFilterHandler(search: SearchInterface) {
+export function useWorkflowExecutionsFilterHandler(search: WorkflowRunsSearchInterface) {
     return (newFilters: BaseFilter[]) => {
         if (newFilters.length === 0) {
             search.clearFilters();
@@ -92,20 +111,21 @@ export function useWorkflowExecutionsFilterHandler(search: SearchInterface) {
 
         newFilters.forEach((filter) => {
             if (filter.value && filter.value.length > 0) {
+                if (!isWorkflowExecutionFilterName(filter.name)) {
+                    return;
+                }
+
                 const filterName = filter.name;
                 const filterValue = filterValueToQueryValue(filter);
 
-                if (filterName === 'name') {
-                    setSearchQueryValue(search, 'search_term', filterValue);
-                    setSearchQueryValue(search, 'name', filterValue);
-                } else if (filterName === 'has_reported_errors') {
+                if (filterName === 'has_reported_errors') {
                     // Convert string "true"/"false" to boolean
                     const stringValue = Array.isArray(filterValue) ? filterValue[0] : filterValue;
                     // Only set the filter if we have a valid value
                     if (stringValue === 'true' || stringValue === 'false') {
                         setSearchQueryValue(search, filterName, stringValue === 'true');
                     }
-                } else {
+                } else if (typeof filterValue === 'string') {
                     setSearchQueryValue(search, filterName, filterValue);
                 }
             }

package/src/features/facets/index.ts

@@ -1,5 +1,6 @@
 export {
     AgentRunnerFacetsNav,
+    type AgentRunnerFilterQuery,
     createAgentRunnerFilterHandler,
     useAgentRunnerFilterGroups,
 } from './AgentRunnerFacetsNav';

package/src/features/facets/utils/SearchInterface.tsx

@@ -3,7 +3,7 @@ import type { Filter as BaseFilter } from '@vertesia/ui/core';
 interface defaultKeys {
     [key: string]: string;
 }
-export interface SearchInterface {
+export interface SearchInterface<Query extends object = object> {
     getFilterValue(name: string): unknown;
     setFilterValue(name: string, value: unknown): void;
     clearFilters(autoSearch?: boolean, applyDefaults?: boolean): void;
@@ -12,7 +12,7 @@ export interface SearchInterface {
     readonly isRunning: boolean;
     readonly initialized?: boolean;
     readonly totalCount?: number;
-    query: object;
+    query: Query;
 }
 
 interface FilterOptionValue {
@@ -38,6 +38,15 @@ export function filterValueToQueryValue(filter: BaseFilter): unknown {
     return firstValue === undefined ? undefined : unwrapFilterOptionValue(firstValue);
 }
 
-export function setSearchQueryValue(search: SearchInterface, name: string, value: unknown): void {
+export function setSearchQueryValue<Query extends object, Name extends Extract<keyof Query, string>>(
+    search: SearchInterface<Query>,
+    name: Name,
+    value: unknown,
+): void {
     (search.query as Record<string, unknown>)[name] = value;
 }
+
+export function createSearchQueryKeyGuard<Query extends object>(names: readonly (keyof Query)[]) {
+    const nameSet = new Set<PropertyKey>(names);
+    return (name: string): name is Extract<keyof Query, string> => nameSet.has(name);
+}

package/src/features/layout/GenericPageNavHeader.tsx

@@ -14,6 +14,13 @@ interface GenericPageNavHeaderProps {
     children?: ReactNode;
     className?: string;
     useDynamicBreadcrumbs?: boolean;
+    /**
+     * Parent page linked from the breadcrumbs when there is no history chain to walk (the user
+     * landed on this URL directly). Give it as an absolute app path, including the module mount.
+     */
+    parentPath?: string;
+    /** Label for {@link parentPath}; defaults to its last segment, title-cased. */
+    parentLabel?: string;
 }
 
 interface BreadcrumbElementProps {
@@ -43,6 +50,8 @@ export function GenericPageNavHeader({
     actions,
     breadcrumbs,
     useDynamicBreadcrumbs = true,
+    parentPath,
+    parentLabel,
 }: GenericPageNavHeaderProps) {
     const navigate = useNavigate();
 
@@ -91,6 +100,13 @@ export function GenericPageNavHeader({
                         onClick: () => navigate(entry.href, { stepsBack: stepsBack }),
                     });
                 });
+            } else if (parentPath) {
+                // Caller knows where this page belongs; skip the URL inference below.
+                items.push({
+                    label: parentLabel ?? buildBreadcrumbLabel({ href: parentPath }),
+                    href: parentPath,
+                    onClick: () => navigate(parentPath, { isBasePathNested: false, replace: true }),
+                });
             } else {
                 // Infer parents from URL when navigating directly to a detail page
                 const segments = window.location.pathname.split('/').filter((s) => s.length > 0);

package/src/features/magic-pdf/DownloadPopover.tsx

@@ -1,4 +1,3 @@
-import type { ContentObject } from '@vertesia/common';
 import { Button } from '@vertesia/ui/core';
 import { useUITranslation } from '@vertesia/ui/i18n';
 import { useUserSession } from '@vertesia/ui/session';
@@ -6,7 +5,7 @@ import { Download } from 'lucide-react';
 import { getResourceUrl } from './MagicPdfProvider';
 
 interface DownloadPopoverProps {
-    object: ContentObject;
+    object: { id: string };
 }
 export function DownloadPopover({ object }: DownloadPopoverProps) {
     const { t } = useUITranslation();

package/src/features/magic-pdf/GroundedExtractionView.test.tsx

@@ -60,6 +60,12 @@ describe('GroundedExtractionPanel', () => {
 
         fireEvent.click(screen.getByText('DFVS25'));
         expect(screen.getByText('E38:J38')).not.toBeNull();
-        expect(screen.getByRole('button', { name: 'part_number' }).getAttribute('title')).toContain('E38:J38');
+
+        // The citation box repeats the range in its tooltip. It is a VTooltip, not a
+        // native `title`: a raw title on a <button> also picks up the global
+        // button[title] pseudo-element in custom-tooltips.css, so both render at once.
+        fireEvent.focus(screen.getByRole('button', { name: 'part_number' }));
+        const tooltip = await screen.findByRole('tooltip');
+        expect(tooltip.textContent).toContain('E38:J38');
     });
 });