@vellumai/assistant 0.8.4 → 0.8.6

package/src/__tests__/credential-vault-unit.test.ts

@@ -27,8 +27,8 @@ mock.module("../util/logger.js", () => ({
 // Use encrypted backend with a temp store path
 // ---------------------------------------------------------------------------
 
-import { _setStorePath } from "../security/encrypted-store.js";
 import { _resetBackend } from "../security/secure-keys.js";
+import { setStorePathForTesting } from "./encrypted-store-test-helpers.js";
 
 const TEST_DIR = join(
   tmpdir(),
@@ -280,7 +280,7 @@ describe("CredentialBroker transient credentials", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
     broker = new CredentialBroker();
@@ -288,7 +288,7 @@ describe("CredentialBroker transient credentials", () => {
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -504,14 +504,14 @@ describe("credential_store tool — unknown action", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
   });
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -534,14 +534,14 @@ describe("credential_store tool — prompt action", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
   });
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -845,14 +845,14 @@ describe("credential_store tool — slack_channel store routing", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
   });
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -956,14 +956,14 @@ describe("credential_store tool — store validation edge cases", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
   });
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -1124,14 +1124,14 @@ describe("credential_store tool — slack_channel delete routing", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
   });
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -1267,7 +1267,7 @@ describe("credential_store tool — tool definition", () => {
   });
 
   test("getDefinition returns valid schema with required action", () => {
-    const def = credentialStoreTool.getDefinition();
+    const def = credentialStoreTool;
     expect(def.name).toBe("credential_store");
     const schema = def.input_schema as Record<string, unknown>;
     expect(schema.type).toBe("object");
@@ -1277,7 +1277,7 @@ describe("credential_store tool — tool definition", () => {
   });
 
   test("getDefinition includes injection_templates schema", () => {
-    const def = credentialStoreTool.getDefinition();
+    const def = credentialStoreTool;
     const schemaProps = (def.input_schema as Record<string, unknown>)
       .properties as Record<string, Record<string, unknown>>;
     const templates = schemaProps.injection_templates as Record<
@@ -1304,7 +1304,7 @@ describe("CredentialBroker — serverUseById edge cases", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
     broker = new CredentialBroker();
@@ -1312,7 +1312,7 @@ describe("CredentialBroker — serverUseById edge cases", () => {
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -1376,7 +1376,7 @@ describe("CredentialBroker — revokeAll", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
     broker = new CredentialBroker();
@@ -1384,7 +1384,7 @@ describe("CredentialBroker — revokeAll", () => {
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 
@@ -1432,7 +1432,7 @@ describe("CredentialBroker — canonical capability key", () => {
   beforeEach(() => {
     if (existsSync(TEST_DIR)) rmSync(TEST_DIR, { recursive: true });
     mkdirSync(TEST_DIR, { recursive: true });
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _resetBackend();
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
     broker = new CredentialBroker();
@@ -1440,7 +1440,7 @@ describe("CredentialBroker — canonical capability key", () => {
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
   });
 

package/src/__tests__/credential-vault.test.ts

@@ -28,8 +28,8 @@ mock.module("../util/logger.js", () => ({
 // Use encrypted backend with a temp store path
 // ---------------------------------------------------------------------------
 
-import { _setStorePath } from "../security/encrypted-store.js";
 import { _resetBackend } from "../security/secure-keys.js";
+import { setStorePathForTesting } from "./encrypted-store-test-helpers.js";
 
 const TEST_DIR = join(
   tmpdir(),
@@ -282,7 +282,7 @@ describe("credential_store tool", () => {
     for (const entry of readdirSync(TEST_DIR)) {
       rmSync(join(TEST_DIR, entry), { recursive: true, force: true });
     }
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
     mockDisconnectOAuthProvider.mockClear();
     mockConnections.clear();
@@ -290,7 +290,7 @@ describe("credential_store tool", () => {
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
     mockConnections.clear();
   });
@@ -1282,7 +1282,7 @@ describe("withValidToken refresh deduplication", () => {
     for (const entry of readdirSync(TEST_DIR)) {
       rmSync(join(TEST_DIR, entry), { recursive: true, force: true });
     }
-    _setStorePath(STORE_PATH);
+    setStorePathForTesting(STORE_PATH);
     _setMetadataPath(join(TEST_DIR, "metadata.json"));
     _resetRefreshBreakers();
     _resetInflightRefreshes();
@@ -1295,7 +1295,7 @@ describe("withValidToken refresh deduplication", () => {
 
   afterEach(() => {
     _setMetadataPath(null);
-    _setStorePath(null);
+    setStorePathForTesting(null);
     _resetBackend();
     _resetRefreshBreakers();
     _resetInflightRefreshes();

package/src/__tests__/cross-provider-web-search.test.ts

@@ -1,6 +1,10 @@
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type { ContentBlock, Message } from "../providers/types.js";
+import type {
+  ContentBlock,
+  Message,
+  ToolDefinition,
+} from "../providers/types.js";
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -85,6 +89,22 @@ function webSearchResultOnlyMessage(): Message[] {
   ];
 }
 
+const sampleTools: ToolDefinition[] = [
+  {
+    name: "file_read",
+    description: "Read a file",
+    input_schema: { type: "object", properties: { path: { type: "string" } } },
+  },
+  {
+    name: "web_search",
+    description: "Search the web",
+    input_schema: {
+      type: "object",
+      properties: { query: { type: "string" } },
+    },
+  },
+];
+
 // ---------------------------------------------------------------------------
 // Mock OpenAI SDK
 // ---------------------------------------------------------------------------
@@ -128,7 +148,7 @@ mock.module("openai", () => {
         },
       };
       responses = {
-        stream: (params: Record<string, unknown>) => {
+        create: async (params: Record<string, unknown>) => {
           lastOpenAIResponsesParams = JSON.parse(JSON.stringify(params));
           return (async function* () {
             yield {
@@ -194,6 +214,7 @@ mock.module("@google/genai", () => {
 });
 
 // Import providers after mocking
+import { FireworksProvider } from "../providers/fireworks/client.js";
 import { GeminiProvider } from "../providers/gemini/client.js";
 import {
   OpenAIChatCompletionsProvider,
@@ -458,6 +479,39 @@ describe("Cross-Provider Web Search — OpenAI Chat Completions (compatibility)"
   });
 });
 
+// ---------------------------------------------------------------------------
+// Fireworks provider tests
+// ---------------------------------------------------------------------------
+
+describe("Cross-Provider Web Search — Fireworks", () => {
+  beforeEach(() => {
+    lastOpenAIChatParams = null;
+  });
+
+  test("keeps web_search as an app-executed function tool for managed Brave fallback", async () => {
+    const provider = new FireworksProvider(
+      "fw-test",
+      "accounts/fireworks/models/kimi-k2p6",
+    );
+
+    await provider.sendMessage([userMsg("Search for something")], sampleTools);
+
+    const tools = lastOpenAIChatParams!.tools as Array<{
+      type: string;
+      function: { name: string; description?: string };
+    }>;
+
+    expect(tools).toHaveLength(2);
+    expect(tools[1]).toMatchObject({
+      type: "function",
+      function: {
+        name: "web_search",
+        description: "Search the web",
+      },
+    });
+  });
+});
+
 // ---------------------------------------------------------------------------
 // Gemini provider tests
 // ---------------------------------------------------------------------------

package/src/__tests__/db-connection-isolation.test.ts

@@ -9,7 +9,8 @@ import { homedir, tmpdir } from "node:os";
 import { join } from "node:path";
 import { afterEach, expect, test } from "bun:test";
 
-import { getDb, resetDb } from "../memory/db-connection.js";
+import { getDb } from "../memory/db-connection.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 const originalWorkspaceDir = process.env.VELLUM_WORKSPACE_DIR;
 const originalAllowRealWorkspace =
@@ -18,7 +19,7 @@ const originalTestRealWorkspace = process.env.VELLUM_TEST_REAL_WORKSPACE_DIR;
 const originalHome = process.env.HOME;
 
 afterEach(() => {
-  resetDb();
+  resetDbForTesting();
   if (originalWorkspaceDir === undefined) {
     delete process.env.VELLUM_WORKSPACE_DIR;
   } else {
@@ -46,7 +47,7 @@ afterEach(() => {
 });
 
 test("getDb refuses test runs without an isolated workspace", () => {
-  resetDb();
+  resetDbForTesting();
   delete process.env.VELLUM_WORKSPACE_DIR;
   delete process.env.VELLUM_ALLOW_REAL_WORKSPACE_IN_TESTS;
 
@@ -56,7 +57,7 @@ test("getDb refuses test runs without an isolated workspace", () => {
 });
 
 test("getDb refuses the real workspace during tests even when explicitly set", () => {
-  resetDb();
+  resetDbForTesting();
   process.env.VELLUM_WORKSPACE_DIR = join(homedir(), ".vellum", "workspace");
   delete process.env.VELLUM_ALLOW_REAL_WORKSPACE_IN_TESTS;
 
@@ -66,7 +67,7 @@ test("getDb refuses the real workspace during tests even when explicitly set", (
 });
 
 test("getDb refuses symlink aliases to the real workspace during tests", () => {
-  resetDb();
+  resetDbForTesting();
   const testRoot = realpathSync(
     mkdtempSync(join(tmpdir(), "vellum-db-isolation-")),
   );
@@ -95,7 +96,7 @@ test("getDb refuses symlink aliases to the real workspace during tests", () => {
 });
 
 test("getDb refuses missing children under symlink aliases to the real workspace", () => {
-  resetDb();
+  resetDbForTesting();
   const testRoot = realpathSync(
     mkdtempSync(join(tmpdir(), "vellum-db-isolation-")),
   );

package/src/__tests__/db-conversation-fork-lineage-migration.test.ts

@@ -1,8 +1,9 @@
-import { rmSync } from "node:fs";
 import { Database } from "bun:sqlite";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
 import { drizzle } from "drizzle-orm/bun-sqlite";
+
+import { removeTestDbFiles } from "./assert-not-live-db.js";
 const originalBunTest = process.env.BUN_TEST;
 
 mock.module("../util/logger.js", () => ({
@@ -12,12 +13,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
-import { resetDb } from "../memory/db-connection.js";
 import { getSqliteFrom } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { migrateConversationForkLineage } from "../memory/migrations/183-add-conversation-fork-lineage.js";
 import * as schema from "../memory/schema.js";
 import { getDbPath } from "../util/platform.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 function createTestDb() {
   const sqlite = new Database(":memory:");
@@ -65,23 +66,20 @@ function bootstrapPreLineageConversations(raw: Database): void {
   `);
 }
 
-function removeTestDbFiles(): void {
-  resetDb();
-  const dbPath = getDbPath();
-  rmSync(dbPath, { force: true });
-  rmSync(`${dbPath}-shm`, { force: true });
-  rmSync(`${dbPath}-wal`, { force: true });
+function resetMigrationTestDb(): void {
+  resetDbForTesting();
+  removeTestDbFiles(getDbPath());
 }
 
 describe("conversation fork lineage migration", () => {
   beforeEach(() => {
     process.env.BUN_TEST = "0";
-    removeTestDbFiles();
+    resetMigrationTestDb();
   });
 
   afterAll(() => {
     process.env.BUN_TEST = originalBunTest;
-    removeTestDbFiles();
+    resetMigrationTestDb();
   });
 
   test("fresh DB initialization includes nullable lineage columns and parent lookup index", () => {

package/src/__tests__/db-conversation-inference-profile-migration.test.ts

@@ -1,9 +1,9 @@
-import { rmSync } from "node:fs";
 import { Database } from "bun:sqlite";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
 import { drizzle } from "drizzle-orm/bun-sqlite";
 
+import { removeTestDbFiles } from "./assert-not-live-db.js";
 import { makeMockLogger } from "./helpers/mock-logger.js";
 
 const originalBunTest = process.env.BUN_TEST;
@@ -14,13 +14,13 @@ mock.module("../util/logger.js", () => ({
 
 import { _resetDisplayOrderMigrationForTests } from "../memory/conversation-display-order-migration.js";
 import { _resetGroupMigrationForTests } from "../memory/conversation-group-migration.js";
-import { resetDb } from "../memory/db-connection.js";
 import { getSqliteFrom } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { migrateAddConversationInferenceProfile } from "../memory/migrations/227-add-conversation-inference-profile.js";
 import { migrateRenameInferenceProfileSnakeCase } from "../memory/migrations/228-rename-inference-profile-snake-case.js";
 import * as schema from "../memory/schema.js";
 import { getDbPath } from "../util/platform.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 function createTestDb() {
   const sqlite = new Database(":memory:");
@@ -66,28 +66,25 @@ function bootstrapPreInferenceProfileConversations(raw: Database): void {
   `);
 }
 
-function removeTestDbFiles(): void {
-  resetDb();
+function resetMigrationTestDb(): void {
+  resetDbForTesting();
   // Reset the in-process guards for the lazy `group_id` / `display_order` /
   // `is_pinned` migrations so the freshly recreated DB gets those columns
   // again. Otherwise downstream tests hit `no such column: group_id`.
   _resetGroupMigrationForTests();
   _resetDisplayOrderMigrationForTests();
-  const dbPath = getDbPath();
-  rmSync(dbPath, { force: true });
-  rmSync(`${dbPath}-shm`, { force: true });
-  rmSync(`${dbPath}-wal`, { force: true });
+  removeTestDbFiles(getDbPath());
 }
 
 describe("conversation inference profile migration", () => {
   beforeEach(() => {
     process.env.BUN_TEST = "0";
-    removeTestDbFiles();
+    resetMigrationTestDb();
   });
 
   afterAll(() => {
     process.env.BUN_TEST = originalBunTest;
-    removeTestDbFiles();
+    resetMigrationTestDb();
   });
 
   test("fresh DB initialization includes nullable inference_profile column", () => {

package/src/__tests__/db-llm-request-log-provider-migration.test.ts

@@ -1,4 +1,3 @@
-import { rmSync } from "node:fs";
 import { Database } from "bun:sqlite";
 import {
   afterAll,
@@ -11,6 +10,8 @@ import {
 } from "bun:test";
 
 import { drizzle } from "drizzle-orm/bun-sqlite";
+
+import { removeTestDbFiles } from "./assert-not-live-db.js";
 const originalBunTest = process.env.BUN_TEST;
 
 mock.module("../util/logger.js", () => ({
@@ -20,12 +21,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
-import { resetDb } from "../memory/db-connection.js";
 import { getSqliteFrom } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { migrateLlmRequestLogProvider } from "../memory/migrations/184-llm-request-log-provider.js";
 import * as schema from "../memory/schema.js";
 import { getDbPath } from "../util/platform.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 function createTestDb() {
   const sqlite = new Database(":memory:");
@@ -56,23 +57,16 @@ function bootstrapPreProviderLlmRequestLogs(raw: Database): void {
   `);
 }
 
-function removeTestDbFiles(): void {
-  const dbPath = getDbPath();
-  rmSync(dbPath, { force: true });
-  rmSync(`${dbPath}-shm`, { force: true });
-  rmSync(`${dbPath}-wal`, { force: true });
-}
-
 describe("llm_request_logs provider migration", () => {
   beforeEach(() => {
     process.env.BUN_TEST = "0";
-    resetDb();
-    removeTestDbFiles();
+    resetDbForTesting();
+    removeTestDbFiles(getDbPath());
   });
 
   afterEach(() => {
-    resetDb();
-    removeTestDbFiles();
+    resetDbForTesting();
+    removeTestDbFiles(getDbPath());
   });
 
   afterAll(() => {
@@ -81,8 +75,8 @@ describe("llm_request_logs provider migration", () => {
     } else {
       process.env.BUN_TEST = originalBunTest;
     }
-    resetDb();
-    removeTestDbFiles();
+    resetDbForTesting();
+    removeTestDbFiles(getDbPath());
   });
 
   test("fresh DB initialization includes llm_request_logs.provider", () => {

package/src/__tests__/db-test-helpers.ts

@@ -0,0 +1,58 @@
+/**
+ * Test-only utilities for resetting the assistant DB singleton.
+ *
+ * Replaces the removed `resetDb` export from `db-connection.ts`. Lives
+ * here (not in the source module) because production modules should not
+ * expose test backdoors.
+ *
+ * No source-module imports
+ * ------------------------
+ * This file has ZERO imports from `src/`. It accesses the DB singleton's
+ * state via the shared `globalThis.vellumAssistant.dbSingleton` slot
+ * that `src/memory/db-singleton.ts` also reads/writes. The slot shape
+ * is duplicated here on purpose: keeping this file off the production
+ * import graph is what protects the test preload from a broken
+ * `node_modules` symlink (DB ghost #3). The two declarations MUST stay
+ * in sync — if you change one, change the other.
+ *
+ * Production code that needs to close + reopen the DB (post-migration,
+ * post-restore, post-vbundle-import, on shutdown) should use `resetDb()`
+ * from `src/memory/db-connection.ts` instead.
+ */
+
+// Mirrors `src/memory/db-singleton.ts`. Duplicated by design — see the
+// "No source-module imports" section above.
+type DbSlot = {
+  db: unknown;
+  closer: (() => void) | null;
+};
+
+type VellumAssistantNamespace = {
+  dbSingleton?: DbSlot;
+};
+
+function dbSlot(): DbSlot {
+  const g = globalThis as { vellumAssistant?: VellumAssistantNamespace };
+  const ns = (g.vellumAssistant ??= {});
+  return (ns.dbSingleton ??= { db: null, closer: null });
+}
+
+/**
+ * Close the active DB connection (if any) and drop the singleton.
+ *
+ * Used by tests that nuke or replace the DB file mid-run — without this
+ * reset, subsequent `getDb()` calls return a handle to the now-gone file.
+ * Idempotent: safe to call when no connection has been opened.
+ */
+export function resetDbForTesting(): void {
+  const s = dbSlot();
+  if (s.closer) {
+    try {
+      s.closer();
+    } catch {
+      /* best-effort close */
+    }
+  }
+  s.db = null;
+  s.closer = null;
+}