@vellumai/assistant 0.8.4 → 0.8.6

package/src/__tests__/{conversation-load-cleaned-at.test.ts → conversation-load-history-stripped.test.ts}

@@ -84,9 +84,10 @@ mock.module("../memory/conversation-crud.js", () => ({
   getConversation: () => mockConversation,
   createConversation: () => ({ id: "conv-1" }),
   addMessage: async () => ({ id: "persisted" }),
-  setConversationCleanedAt: () => {},
+  setConversationHistoryStrippedAt: () => {},
   setConversationOriginChannelIfUnset: () => {},
   setConversationOriginInterfaceIfUnset: () => {},
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 mock.module("../memory/conversation-queries.js", () => ({
@@ -123,19 +124,19 @@ function textBlocks(content: ReadonlyArray<{ type: string; text?: string }>) {
     .map((b) => b.text);
 }
 
-describe("loadFromDb with cleanedAt", () => {
+describe("loadFromDb with historyStrippedAt", () => {
   beforeEach(() => {
     mockDbMessages = [];
     mockConversation = null;
   });
 
-  test("strips injection prefixes from pre-clean user content", async () => {
-    const cleanedAt = 1000;
+  test("strips injection prefixes from pre-strip user content", async () => {
+    const historyStrippedAt = 1000;
     mockConversation = {
       id: "conv-1",
       contextSummary: null,
       contextCompactedMessageCount: 0,
-      cleanedAt,
+      historyStrippedAt,
       totalInputTokens: 0,
       totalOutputTokens: 0,
       totalEstimatedCost: 0,
@@ -186,13 +187,13 @@ describe("loadFromDb with cleanedAt", () => {
     ]);
   });
 
-  test("skips metadata rehydration for pre-clean messages", async () => {
-    const cleanedAt = 1000;
+  test("skips metadata rehydration for pre-strip messages", async () => {
+    const historyStrippedAt = 1000;
     mockConversation = {
       id: "conv-1",
       contextSummary: null,
       contextCompactedMessageCount: 0,
-      cleanedAt,
+      historyStrippedAt,
       totalInputTokens: 0,
       totalOutputTokens: 0,
       totalEstimatedCost: 0,
@@ -201,7 +202,7 @@ describe("loadFromDb with cleanedAt", () => {
       {
         id: "m1",
         role: "user",
-        content: JSON.stringify([{ type: "text", text: "Pre-clean turn" }]),
+        content: JSON.stringify([{ type: "text", text: "Pre-strip turn" }]),
         createdAt: 500,
         metadata: JSON.stringify({
           pkbContextBlock: "<knowledge_base>stale</knowledge_base>",
@@ -217,7 +218,7 @@ describe("loadFromDb with cleanedAt", () => {
         id: "m3",
         role: "user",
         content: JSON.stringify([
-          { type: "text", text: "Mid post-clean turn" },
+          { type: "text", text: "Mid post-strip turn" },
         ]),
         createdAt: 1500,
         metadata: JSON.stringify({
@@ -236,18 +237,18 @@ describe("loadFromDb with cleanedAt", () => {
     await conversation.loadFromDb();
     const messages = conversation.getMessages();
 
-    expect(textBlocks(messages[0].content)).toEqual(["Pre-clean turn"]);
+    expect(textBlocks(messages[0].content)).toEqual(["Pre-strip turn"]);
     expect(textBlocks(messages[2].content).join("\n")).toContain(
       "<knowledge_base>kept</knowledge_base>",
     );
   });
 
-  test("leaves messages untouched when cleanedAt is null", async () => {
+  test("leaves messages untouched when historyStrippedAt is null", async () => {
     mockConversation = {
       id: "conv-1",
       contextSummary: null,
       contextCompactedMessageCount: 0,
-      cleanedAt: null,
+      historyStrippedAt: null,
       totalInputTokens: 0,
       totalOutputTokens: 0,
       totalEstimatedCost: 0,

package/src/__tests__/conversation-pairing.test.ts

@@ -67,6 +67,7 @@ mock.module("../memory/conversation-crud.js", () => ({
   createConversation: createConversationMock,
   addMessage: addMessageMock,
   getConversation: getConversationMock,
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 /** Simulated bindings for external-conversation-store mock. */
@@ -122,6 +123,11 @@ function makeSignal(
       isAsyncBackground: true,
       visibleInSourceNow: false,
     },
+    // Most existing pairing tests pre-date the passive-by-default gate and
+    // exercise the conversation-creation path. Default to the opt-in flag so
+    // they continue to assert creation semantics; the dedicated passive-gate
+    // test below explicitly omits it to cover the new default.
+    requiresConversation: true,
     ...overrides,
   };
 }
@@ -815,6 +821,53 @@ describe("pairDeliveryWithConversation", () => {
     expect(getBindingByChannelChatMock).not.toHaveBeenCalled();
   });
 
+  // ── Passive default: vellum no-creates without opt-in ─────────────
+
+  test("passive vellum signal does not create a conversation or message", async () => {
+    const signal = makeSignal({ requiresConversation: undefined });
+    const copy = makeCopy();
+
+    const result = await pairDeliveryWithConversation(
+      signal,
+      "vellum" as NotificationChannel,
+      copy,
+    );
+
+    expect(result.conversationId).toBeNull();
+    expect(result.messageId).toBeNull();
+    expect(result.strategy).toBe("start_new_conversation");
+    expect(result.createdNewConversation).toBe(false);
+    expect(result.conversationFallbackUsed).toBe(false);
+    expect(createConversationMock).not.toHaveBeenCalled();
+    expect(addMessageMock).not.toHaveBeenCalled();
+  });
+
+  test("passive vellum signal still honors explicit reuse_existing action", async () => {
+    mockExistingConversations["conv-explicit-passive"] = {
+      id: "conv-explicit-passive",
+      source: "notification",
+      title: "Existing",
+    };
+    const signal = makeSignal({ requiresConversation: undefined });
+    const copy = makeCopy();
+    const conversationAction: ConversationAction = {
+      action: "reuse_existing",
+      conversationId: "conv-explicit-passive",
+    };
+
+    const result = await pairDeliveryWithConversation(
+      signal,
+      "vellum" as NotificationChannel,
+      copy,
+      { conversationAction },
+    );
+
+    expect(result.conversationId).toBe("conv-explicit-passive");
+    expect(result.createdNewConversation).toBe(false);
+    expect(createConversationMock).not.toHaveBeenCalled();
+    expect(addMessageMock).toHaveBeenCalledTimes(1);
+  });
+
   // ── conversationMetadata.conversationType override ─────────────────
 
   test("uses conversationMetadata.conversationType when set, overriding channel strategy", async () => {

package/src/__tests__/conversation-process-app-control-preactivation.test.ts

@@ -33,7 +33,10 @@ mock.module("../util/logger.js", () => ({
  * a connected macOS client for cross-client drain-path coverage. Reset in
  * afterEach so tests don't bleed state.
  */
-let mockCapabilityClients: Array<{ clientId: string; actorPrincipalId?: string }> = [];
+let mockCapabilityClients: Array<{
+  clientId: string;
+  actorPrincipalId?: string;
+}> = [];
 
 mock.module("../runtime/assistant-event-hub.js", () => ({
   assistantEventHub: {
@@ -50,6 +53,7 @@ mock.module("../memory/conversation-crud.js", () => ({
     trustContext: undefined,
   }),
   addMessage: () => ({ id: "msg-mock" }),
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 mock.module("../memory/canonical-guardian-store.js", () => ({
@@ -77,7 +81,10 @@ mock.module("../agent/attachments.ts", () => ({
 // SQLite paths after the preactivation block has already run. The drain
 // chain doesn't recurse here because our stubbed `runAgentLoop` is a no-op.
 mock.module("../daemon/conversation-messaging.js", () => ({
-  persistQueuedMessageBody: async () => "user-msg-id",
+  persistQueuedMessageBody: async () => ({
+    id: "user-msg-id",
+    deduplicated: false,
+  }),
 }));
 
 // ---------------------------------------------------------------------------
@@ -135,7 +142,7 @@ function makeFakeContext(opts: {
     },
     async ensureActorScopedHistory() {},
     async persistUserMessage() {
-      return "user-msg-id";
+      return { id: "user-msg-id", deduplicated: false };
     },
     async runAgentLoop() {
       // No-op: the drain path's finally block would normally call drainQueue
@@ -312,7 +319,10 @@ describe("drainQueue preactivation re-add for host-proxy interfaces", () => {
       assistantMessageInterface: "web",
     };
     queue.push(
-      makeQueuedMessage({ requestId: "req-web-1", turnInterfaceContext: ifCtx }),
+      makeQueuedMessage({
+        requestId: "req-web-1",
+        turnInterfaceContext: ifCtx,
+      }),
     );
     const ctx = makeFakeContext({ queue, turnInterfaceContext: ifCtx });
 
@@ -334,7 +344,10 @@ describe("drainQueue preactivation re-add for host-proxy interfaces", () => {
       assistantMessageInterface: "web",
     };
     queue.push(
-      makeQueuedMessage({ requestId: "req-web-2", turnInterfaceContext: ifCtx }),
+      makeQueuedMessage({
+        requestId: "req-web-2",
+        turnInterfaceContext: ifCtx,
+      }),
     );
     const ctx = makeFakeContext({ queue, turnInterfaceContext: ifCtx });
 
@@ -354,7 +367,10 @@ describe("drainQueue preactivation re-add for host-proxy interfaces", () => {
       assistantMessageInterface: "web",
     };
     queue.push(
-      makeQueuedMessage({ requestId: "req-web-3", turnInterfaceContext: ifCtx }),
+      makeQueuedMessage({
+        requestId: "req-web-3",
+        turnInterfaceContext: ifCtx,
+      }),
     );
     const ctx = makeFakeContext({ queue, turnInterfaceContext: ifCtx });
 
@@ -371,7 +387,10 @@ describe("drainQueue preactivation re-add for host-proxy interfaces", () => {
       assistantMessageInterface: "web",
     };
     queue.push(
-      makeQueuedMessage({ requestId: "req-web-4", turnInterfaceContext: ifCtx }),
+      makeQueuedMessage({
+        requestId: "req-web-4",
+        turnInterfaceContext: ifCtx,
+      }),
     );
     const ctx = makeFakeContext({ queue, turnInterfaceContext: ifCtx });
 

package/src/__tests__/conversation-process-callsite.test.ts

@@ -183,6 +183,7 @@ mock.module("../memory/conversation-crud.js", () => ({
   updateConversationTitle: () => {},
   getMessageById: () => null,
   getLastUserTimestampBefore: () => 0,
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 mock.module("../memory/conversation-queries.js", () => ({

package/src/__tests__/conversation-provider-retry-repair.test.ts

@@ -179,11 +179,14 @@ mock.module("../memory/conversation-crud.js", () => ({
   updateConversationUsage: () => {},
   updateConversationTitle: () => {},
   updateConversationContextWindow: () => {},
+  setConversationHistoryStrippedAt: () => {},
   getConversationOriginChannel: () => null,
   getConversationOriginInterface: () => null,
   provenanceFromTrustContext: () => ({}),
   getMessageById: () => null,
   getLastUserTimestampBefore: () => 0,
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
+  updateMessageContent: mock(() => {}),
 }));
 
 mock.module("../memory/conversation-queries.js", () => ({
@@ -276,6 +279,9 @@ mock.module("../agent/loop.js", () => ({
       onEvent: (event: AgentEvent) => void,
       _signal?: AbortSignal,
     ): Promise<Message[]> {
+      // Prime the assistant row anchor — production code emits this from
+      // `AgentLoop.run` just before `provider.sendMessage`.
+      await onEvent({ type: "llm_call_started" });
       agentLoopRunCount++;
 
       if (