@vellumai/assistant 0.8.3 → 0.8.5

package/src/__tests__/compaction-strip-metadata-clear.test.ts

@@ -1,206 +0,0 @@
-import { beforeEach, describe, expect, mock, test } from "bun:test";
-
-mock.module("../util/logger.js", () => ({
-  getLogger: () =>
-    new Proxy({} as Record<string, unknown>, {
-      get: () => () => {},
-    }),
-}));
-
-mock.module("../config/loader.js", () => ({
-  getConfig: () => ({
-    ui: {},
-    model: "test",
-    provider: "test",
-    memory: { enabled: false },
-    rateLimit: { maxRequestsPerMinute: 0 },
-    secretDetection: { enabled: false },
-  }),
-}));
-
-import {
-  addMessage,
-  clearStrippedInjectionMetadataForConversation,
-  createConversation,
-  getMessages,
-} from "../memory/conversation-crud.js";
-import { getDb } from "../memory/db-connection.js";
-import { initializeDb } from "../memory/db-init.js";
-initializeDb();
-
-function resetTables(): void {
-  const db = getDb();
-  db.run("DELETE FROM message_attachments");
-  db.run("DELETE FROM attachments");
-  db.run("DELETE FROM messages");
-  db.run("DELETE FROM conversations");
-}
-
-describe("clearStrippedInjectionMetadataForConversation", () => {
-  beforeEach(() => {
-    resetTables();
-  });
-
-  test("removes all stripped-block fields and preserves the rest", async () => {
-    const conv = createConversation("Strip metadata test");
-    await addMessage(
-      conv.id,
-      "user",
-      "turn 1",
-      {
-        memoryInjectedBlock: "mem payload",
-        turnContextBlock: "<turn_context>\nctx\n</turn_context>",
-        workspaceBlock: "<workspace>\nws\n</workspace>",
-        nowScratchpadBlock:
-          "<NOW.md Always keep this up to date>\nnow body\n</NOW.md>",
-        pkbContextBlock: "<knowledge_base>\npkb body\n</knowledge_base>",
-        pkbSystemReminderBlock:
-          "<system_reminder>\nreminder body\n</system_reminder>",
-        memoryV2StaticBlock:
-          "<memory>\n## Essentials\n\nstatic body\n</memory>",
-      },
-      { skipIndexing: true },
-    );
-
-    clearStrippedInjectionMetadataForConversation(conv.id);
-
-    const [row] = getMessages(conv.id);
-    const meta = JSON.parse(row.metadata ?? "{}");
-
-    expect(meta.pkbSystemReminderBlock).toBeUndefined();
-    expect(meta.nowScratchpadBlock).toBeUndefined();
-    expect(meta.pkbContextBlock).toBeUndefined();
-    expect(meta.memoryV2StaticBlock).toBeUndefined();
-
-    // Non-stripped fields must survive — these back blocks that
-    // `stripInjectionsForCompaction` intentionally leaves in-memory.
-    expect(meta.memoryInjectedBlock).toBe("mem payload");
-    expect(meta.turnContextBlock).toBe("<turn_context>\nctx\n</turn_context>");
-    expect(meta.workspaceBlock).toBe("<workspace>\nws\n</workspace>");
-  });
-
-  test("clears memoryV2StaticBlock alone when it is the only stripped field present", async () => {
-    const conv = createConversation("Strip v2 static only");
-    await addMessage(
-      conv.id,
-      "user",
-      "turn 1",
-      {
-        memoryInjectedBlock: "keep me",
-        memoryV2StaticBlock:
-          "<memory>\n## Essentials\n\nstatic body\n</memory>",
-      },
-      { skipIndexing: true },
-    );
-
-    clearStrippedInjectionMetadataForConversation(conv.id);
-
-    const [row] = getMessages(conv.id);
-    const meta = JSON.parse(row.metadata ?? "{}");
-    expect(meta.memoryV2StaticBlock).toBeUndefined();
-    expect(meta.memoryInjectedBlock).toBe("keep me");
-  });
-
-  test("is idempotent — re-running is a no-op on already-cleared rows", async () => {
-    const conv = createConversation("Idempotent clear");
-    await addMessage(
-      conv.id,
-      "user",
-      "turn 1",
-      {
-        memoryInjectedBlock: "keep me",
-        nowScratchpadBlock: "<NOW.md …>body</NOW.md>",
-      },
-      { skipIndexing: true },
-    );
-
-    clearStrippedInjectionMetadataForConversation(conv.id);
-    clearStrippedInjectionMetadataForConversation(conv.id);
-
-    const [row] = getMessages(conv.id);
-    const meta = JSON.parse(row.metadata ?? "{}");
-    expect(meta.nowScratchpadBlock).toBeUndefined();
-    expect(meta.memoryInjectedBlock).toBe("keep me");
-  });
-
-  test("only targets user rows — assistant metadata is untouched", async () => {
-    const conv = createConversation("Role scoping");
-    await addMessage(
-      conv.id,
-      "user",
-      "turn 1",
-      { nowScratchpadBlock: "<NOW.md …>body</NOW.md>" },
-      { skipIndexing: true },
-    );
-    await addMessage(
-      conv.id,
-      "assistant",
-      "reply",
-      // Assistant rows don't carry these blocks in practice, but guard the
-      // role filter anyway so an accidental drop of the WHERE clause is
-      // surfaced immediately.
-      { nowScratchpadBlock: "should-not-be-cleared" },
-      { skipIndexing: true },
-    );
-
-    clearStrippedInjectionMetadataForConversation(conv.id);
-
-    const rows = getMessages(conv.id);
-    const userMeta = JSON.parse(rows[0].metadata ?? "{}");
-    const assistantMeta = JSON.parse(rows[1].metadata ?? "{}");
-    expect(userMeta.nowScratchpadBlock).toBeUndefined();
-    expect(assistantMeta.nowScratchpadBlock).toBe("should-not-be-cleared");
-  });
-
-  test("post-clear, rehydration does not re-inject NOW.md / knowledge_base", async () => {
-    // Reproduces the divergence described in the Codex P1 feedback:
-    // stripInjectionsForCompaction removes <NOW.md …> and <knowledge_base>
-    // from the in-memory history during compaction. Without this clear,
-    // a subsequent loadFromDb would rehydrate those blocks from stale
-    // metadata — re-injecting exactly what compaction removed.
-    const conv = createConversation("Rehydrate after strip");
-    await addMessage(
-      conv.id,
-      "user",
-      "historical turn",
-      {
-        memoryInjectedBlock: "mem",
-        turnContextBlock: "<turn_context>\nctx\n</turn_context>",
-        workspaceBlock: "<workspace>\nws\n</workspace>",
-        nowScratchpadBlock:
-          "<NOW.md Always keep this up to date>\nnow\n</NOW.md>",
-        pkbContextBlock: "<knowledge_base>\npkb\n</knowledge_base>",
-        pkbSystemReminderBlock: "<system_reminder>\nsr\n</system_reminder>",
-      },
-      { skipIndexing: true },
-    );
-    await addMessage(conv.id, "assistant", "reply", undefined, {
-      skipIndexing: true,
-    });
-    await addMessage(conv.id, "user", "tail turn", undefined, {
-      skipIndexing: true,
-    });
-
-    // Simulate the compaction-strip lifecycle point.
-    clearStrippedInjectionMetadataForConversation(conv.id);
-
-    const rows = getMessages(conv.id);
-    const historicalMeta = JSON.parse(rows[0].metadata ?? "{}");
-
-    // Loading this back with loadFromDb prepends fields only when they
-    // are present on the row. Confirm the stripped fields are gone so
-    // rehydration cannot resurrect them.
-    expect(historicalMeta.nowScratchpadBlock).toBeUndefined();
-    expect(historicalMeta.pkbContextBlock).toBeUndefined();
-    expect(historicalMeta.pkbSystemReminderBlock).toBeUndefined();
-
-    // And the fields that back blocks `stripInjectionsForCompaction`
-    // intentionally preserves (<turn_context>, <workspace>, <memory __injected>)
-    // must still be present so the cache prefix remains stable.
-    expect(historicalMeta.turnContextBlock).toBe(
-      "<turn_context>\nctx\n</turn_context>",
-    );
-    expect(historicalMeta.workspaceBlock).toBe("<workspace>\nws\n</workspace>");
-    expect(historicalMeta.memoryInjectedBlock).toBe("mem");
-  });
-});

package/src/__tests__/message-complete-display-id.test.ts

@@ -1,175 +0,0 @@
-import { beforeEach, describe, expect, mock, test } from "bun:test";
-
-mock.module("../util/logger.js", () => ({
-  getLogger: () =>
-    new Proxy({} as Record<string, unknown>, {
-      get: () => () => {},
-    }),
-}));
-
-mock.module("../config/loader.js", () => ({
-  getConfig: () => ({
-    skills: {
-      entries: {},
-      load: { extraDirs: [], watch: true, watchDebounceMs: 250 },
-      install: { nodeManager: "npm" },
-      allowBundled: null,
-      remoteProviders: {
-        skillssh: { enabled: true },
-        clawhub: { enabled: true },
-      },
-      remotePolicy: {
-        blockSuspicious: true,
-        blockMalware: true,
-        maxSkillsShRisk: "medium",
-      },
-    },
-  }),
-  loadConfig: () => ({}),
-}));
-
-interface AddMessageCall {
-  conversationId: string;
-  role: string;
-  content: string;
-  metadata?: Record<string, unknown>;
-}
-
-const addMessageCalls: AddMessageCall[] = [];
-
-mock.module("../memory/conversation-crud.js", () => ({
-  addMessage: (
-    conversationId: string,
-    role: string,
-    content: string,
-    metadata?: Record<string, unknown>,
-  ) => {
-    addMessageCalls.push({ conversationId, role, content, metadata });
-    return { id: `mock-msg-${addMessageCalls.length}` };
-  },
-  getConversation: () => null,
-  getMessageById: () => null,
-  provenanceFromTrustContext: () => ({}),
-  updateMessageContent: () => {},
-}));
-
-mock.module("../memory/llm-request-log-store.js", () => ({
-  backfillMessageIdOnLogs: () => {},
-  recordRequestLog: () => {},
-}));
-
-mock.module("../memory/memory-recall-log-store.js", () => ({
-  backfillMemoryRecallLogMessageId: () => {},
-}));
-
-mock.module("../memory/memory-v2-activation-log-store.js", () => ({
-  backfillMemoryV2ActivationMessageId: () => {},
-}));
-
-mock.module("../memory/conversation-disk-view.js", () => ({
-  syncMessageToDisk: () => {},
-}));
-
-import type { AgentEvent } from "../agent/loop.js";
-import type {
-  EventHandlerDeps,
-  EventHandlerState,
-} from "../daemon/conversation-agent-loop-handlers.js";
-import {
-  createEventHandlerState,
-  getClientDisplayMessageId,
-  handleMessageComplete,
-} from "../daemon/conversation-agent-loop-handlers.js";
-
-const CONVERSATION_ID = "conv-display-id";
-
-function makeDeps(): EventHandlerDeps {
-  return {
-    ctx: {
-      conversationId: CONVERSATION_ID,
-      currentTurnSurfaces: [],
-      provider: { name: "anthropic" },
-      traceEmitter: { emit: () => {} },
-      trustContext: {
-        sourceChannel: "vellum",
-        trustClass: "guardian",
-      },
-    } as unknown as EventHandlerDeps["ctx"],
-    onEvent: () => {},
-    reqId: "req-display-id",
-    isFirstMessage: false,
-    shouldGenerateTitle: false,
-    rlog: new Proxy({} as Record<string, unknown>, {
-      get: () => () => {},
-    }) as unknown as EventHandlerDeps["rlog"],
-    turnChannelContext: {
-      userMessageChannel: "vellum",
-      assistantMessageChannel: "vellum",
-    } as EventHandlerDeps["turnChannelContext"],
-    turnInterfaceContext: {
-      userMessageInterface: "web",
-      assistantMessageInterface: "web",
-    } as EventHandlerDeps["turnInterfaceContext"],
-  };
-}
-
-function makeMessageCompleteEvent(
-  content: Extract<
-    AgentEvent,
-    { type: "message_complete" }
-  >["message"]["content"],
-): Extract<AgentEvent, { type: "message_complete" }> {
-  return {
-    type: "message_complete",
-    message: { role: "assistant", content },
-  };
-}
-
-describe("message_complete display identity", () => {
-  let state: EventHandlerState;
-
-  beforeEach(() => {
-    addMessageCalls.length = 0;
-    state = createEventHandlerState();
-    state.turnStartedAt = 1_700_000_000_000;
-  });
-
-  test("tracks the merged display id separately from the final row id", async () => {
-    await handleMessageComplete(
-      state,
-      makeDeps(),
-      makeMessageCompleteEvent([
-        {
-          type: "tool_use",
-          id: "toolu_1",
-          name: "bash",
-          input: { command: "true" },
-        },
-      ]),
-    );
-
-    expect(state.firstAssistantMessageId).toBe("mock-msg-1");
-    expect(state.lastAssistantMessageId).toBe("mock-msg-1");
-    expect(getClientDisplayMessageId(state)).toBe("mock-msg-1");
-
-    state.pendingToolResults.set("toolu_1", {
-      content: "ok",
-      isError: false,
-    });
-
-    await handleMessageComplete(
-      state,
-      makeDeps(),
-      makeMessageCompleteEvent([{ type: "text", text: "done" }]),
-    );
-
-    expect(addMessageCalls.map((call) => call.role)).toEqual([
-      "assistant",
-      "user",
-      "assistant",
-    ]);
-    expect(state.firstAssistantMessageId).toBe("mock-msg-1");
-    expect(state.lastAssistantMessageId).toBe("mock-msg-3");
-    expect(getClientDisplayMessageId(state)).toBe("mock-msg-1");
-  });
-});

package/src/config/bundled-skills/document/SKILL.md

@@ -1,54 +0,0 @@
----
-name: document
-description: Write, draft, or compose long-form text (blog posts, articles, essays, reports, guides)
-compatibility: "Designed for Vellum personal assistants"
-metadata:
-  emoji: "📄"
-  vellum:
-    display-name: "Document"
-    activation-hints:
-      - "User asks to write, draft, or collaborate on long-form content — use the document editor for a better editing experience"
-      - "When content will be iterated on, reviewed, or exported, prefer the document editor over inline markdown"
-      - "When a file attachment contains a draft or document the user wants to iterate on, open it in the editor"
----
-
-Create and edit long-form documents using the built-in rich text editor. Documents open in workspace mode with chat docked to the side.
-
-## Tools
-
-- **document_create** - Opens a new document editor with an optional title and initial Markdown content. Returns a `surface_id` for subsequent updates.
-- **document_update** - Updates content in an open document editor by `surface_id`. Supports `replace` (overwrite) and `append` (add to end) modes.
-- **document_read** - Reads the current content of a document by `surface_id` when it belongs to the current conversation, or when the current actor is the guardian/local user. Use to verify content before editing.
-- **document_list** - Lists documents. Without `query`, lists the current conversation's documents. With `query`, searches by title; guardian/local users can search across conversations, while other actors are scoped to the current conversation.
-- **document_delete** - Deletes a document by `surface_id`. Use to clean up unwanted documents.
-
-## Retrieving existing documents
-
-When the user asks to see, open, or pull up a document:
-
-1. Check the `<active_documents>` block in your context — it lists all documents in this conversation with their `surface_id` and title. If the document is there, call `document_read` with its `surface_id`. Done in one call.
-2. If the document is NOT in `<active_documents>`, call `document_list` with a `query` matching the document title. For guardian/local users, this searches across previous conversations and sessions.
-3. Once you have the `surface_id`, call `document_read` to retrieve the content.
-
-**Never** search the filesystem, conversation history, or archives to find a document. Always use `document_list` with a `query`.
-
-## Creating a new document
-
-1. **Create the document**: Call `document_create` with a title (inferred from the request). Call the tool immediately, not after conversational preamble.
-2. **Write content in Markdown**: Use proper structure (`#` for titles, `##` for sections), **bold**, _italic_, code blocks, tables, lists, blockquotes as appropriate.
-3. **CRITICAL - Stream content in chunks**: Call `document_update` MULTIPLE times, not just once. Break content into logical chunks (paragraphs, sections, or every 200-300 words). Call `document_update` with `mode: "append"` for EACH chunk separately. The user experiences real-time content appearing as you write.
-
-## Editing an existing document
-
-When the user requests changes to a document:
-
-1. Find the `surface_id` from the `<active_documents>` context block.
-2. Use `document_update` with the existing `surface_id` — do NOT call `document_create` again.
-3. Use `mode: "replace"` for full rewrites or `mode: "append"` for additions.
-
-## Usage Notes
-
-- The `mode` parameter on `document_update` defaults to `append`.
-- Documents are automatically saved and accessible via the Generated panel.
-- Users can manually edit documents at any time.
-- Write in clear, engaging prose. Use active voice, vary sentence structure, and break content into logical sections with descriptive headings.

package/src/config/bundled-skills/document/TOOLS.json

@@ -1,106 +0,0 @@
-{
-  "version": 1,
-  "tools": [
-    {
-      "name": "document_create",
-      "description": "Create a new long-form document with a rich text editor. Use this when the user asks to write a blog post, article, or any long-form content. The editor opens in workspace mode with chat docked to the side.",
-      "category": "document",
-      "risk": "low",
-      "input_schema": {
-        "type": "object",
-        "properties": {
-          "title": {
-            "type": "string",
-            "description": "Initial title for the document (optional, can be updated later)"
-          },
-          "initial_content": {
-            "type": "string",
-            "description": "Initial Markdown content to populate the editor (optional)"
-          }
-        }
-      },
-      "executor": "tools/document-create.ts",
-      "execution_target": "host"
-    },
-    {
-      "name": "document_update",
-      "description": "Update content in an open document editor. Use this to stream generated content or apply edits.",
-      "category": "document",
-      "risk": "low",
-      "input_schema": {
-        "type": "object",
-        "properties": {
-          "surface_id": {
-            "type": "string",
-            "description": "The ID of the document surface to update"
-          },
-          "content": {
-            "type": "string",
-            "description": "Markdown content to set or append"
-          },
-          "mode": {
-            "type": "string",
-            "enum": ["replace", "append"],
-            "description": "Whether to replace all content or append to the end. Defaults to append."
-          }
-        },
-        "required": ["surface_id", "content"]
-      },
-      "executor": "tools/document-update.ts",
-      "execution_target": "host"
-    },
-    {
-      "name": "document_read",
-      "description": "Read the current content of a document by its surface_id when it belongs to the current conversation, or when the current actor is the guardian/local user. Use this to verify document state before making edits.",
-      "category": "document",
-      "risk": "low",
-      "input_schema": {
-        "type": "object",
-        "properties": {
-          "surface_id": {
-            "type": "string",
-            "description": "The ID of the document to read"
-          }
-        },
-        "required": ["surface_id"]
-      },
-      "executor": "tools/document-read.ts",
-      "execution_target": "host"
-    },
-    {
-      "name": "document_list",
-      "description": "List documents. Without a query, lists documents in the current conversation. With a query, searches documents by title; guardian/local users can search across conversations, while other actors are scoped to the current conversation.",
-      "category": "document",
-      "risk": "low",
-      "input_schema": {
-        "type": "object",
-        "properties": {
-          "query": {
-            "type": "string",
-            "description": "Search documents by title. Omit to list only the current conversation's documents."
-          }
-        }
-      },
-      "executor": "tools/document-list.ts",
-      "execution_target": "host"
-    },
-    {
-      "name": "document_delete",
-      "description": "Delete a document by its surface_id.",
-      "category": "document",
-      "risk": "low",
-      "input_schema": {
-        "type": "object",
-        "properties": {
-          "surface_id": {
-            "type": "string",
-            "description": "The ID of the document to delete"
-          }
-        },
-        "required": ["surface_id"]
-      },
-      "executor": "tools/document-delete.ts",
-      "execution_target": "host"
-    }
-  ]
-}

package/src/daemon/seed-files.ts

@@ -1,18 +0,0 @@
-import { existsSync, mkdirSync } from "node:fs";
-
-import { getLogger } from "../util/logger.js";
-import { getInterfacesDir } from "../util/platform.js";
-
-const log = getLogger("seed-files");
-
-/**
- * Ensures interface directories exist so the runtime can serve files
- * immediately. Called during daemon startup.
- */
-export function seedInterfaceFiles(): void {
-  const tuiDir = getInterfacesDir();
-  if (!existsSync(tuiDir)) {
-    mkdirSync(tuiDir, { recursive: true });
-    log.info("Created interfaces directory");
-  }
-}

package/src/prompts/cache-boundary.ts

@@ -1,8 +0,0 @@
-/**
- * The SYSTEM_PROMPT_CACHE_BOUNDARY marker is a lightweight constant kept in its
- * own file so that providers (openai, gemini) can import it without pulling in
- * the full system-prompt module and its heavy transitive dependencies, which
- * would otherwise create a circular import cycle.
- */
-export const SYSTEM_PROMPT_CACHE_BOUNDARY =
-  "\n<!-- SYSTEM_PROMPT_CACHE_BOUNDARY -->\n";

package/src/runtime/routes/interface-routes.ts

@@ -1,43 +0,0 @@
-/**
- * GET /v1/interfaces/:path*
- *
- * Serves interface definition files from the workspace's `interfaces/`
- * directory. Returns the raw file content as `text/plain`.
- */
-
-import { existsSync, readFileSync } from "node:fs";
-import { resolve } from "node:path";
-
-import { getInterfacesDir } from "../../util/platform.js";
-import { NotFoundError } from "./errors.js";
-import type { RouteDefinition } from "./types.js";
-
-export const ROUTES: RouteDefinition[] = [
-  {
-    operationId: "getInterface",
-    endpoint: "interfaces/:path*",
-    method: "GET",
-    policyKey: "interfaces",
-    summary: "Serve an interface definition file",
-    tags: ["interfaces"],
-    responseHeaders: { "Content-Type": "text/plain; charset=utf-8" },
-    handler: ({ pathParams }) => {
-      const interfacePath = pathParams?.path;
-      if (!interfacePath) {
-        throw new NotFoundError("Interface not found");
-      }
-
-      const interfacesDir = getInterfacesDir();
-      const fullPath = resolve(interfacesDir, interfacePath);
-      if (
-        (fullPath !== interfacesDir &&
-          !fullPath.startsWith(interfacesDir + "/")) ||
-        !existsSync(fullPath)
-      ) {
-        throw new NotFoundError("Interface not found");
-      }
-
-      return readFileSync(fullPath, "utf-8");
-    },
-  },
-];