@vellumai/assistant 0.8.3 → 0.8.5

package/src/runtime/routes/slack-channel-routes.ts

@@ -0,0 +1,188 @@
+import { z } from "zod";
+
+import {
+  conversationMetadataSyncTag,
+  SYNC_TAGS,
+} from "../../daemon/message-types/sync.js";
+import {
+  getBindingByConversation,
+  updateExternalChatName,
+} from "../../memory/external-conversation-store.js";
+import {
+  getSlackConversationInfo,
+  SlackApiError,
+} from "../../messaging/providers/slack/api.js";
+import { publishSyncInvalidation } from "../sync/sync-publisher.js";
+import { NotFoundError } from "./errors.js";
+import type { RouteDefinition, RouteHandlerArgs } from "./types.js";
+
+type ResolveReason =
+  | "auth"
+  | "dm"
+  | "no_name"
+  | "not_found"
+  | "permission"
+  | "rate_limit"
+  | "slack_error";
+
+interface SlackChannelResolveResponse {
+  channelId: string;
+  channelName?: string;
+  cached: boolean;
+  resolved: boolean;
+  reason?: ResolveReason;
+}
+
+const SlackChannelResolveResponseSchema = z.object({
+  channelId: z.string(),
+  channelName: z.string().optional(),
+  cached: z.boolean(),
+  resolved: z.boolean(),
+  reason: z
+    .enum([
+      "auth",
+      "dm",
+      "no_name",
+      "not_found",
+      "permission",
+      "rate_limit",
+      "slack_error",
+    ])
+    .optional(),
+});
+
+function friendlyCachedName(
+  externalChatId: string,
+  externalChatName?: string | null,
+): string | undefined {
+  const trimmed = externalChatName?.trim();
+  if (!trimmed || trimmed === externalChatId) return undefined;
+  return trimmed;
+}
+
+function usableResolvedName(
+  externalChatId: string,
+  name?: string,
+  nameNormalized?: string,
+): string | undefined {
+  for (const candidate of [name, nameNormalized]) {
+    const trimmed = candidate?.trim();
+    if (trimmed && trimmed !== externalChatId) return trimmed;
+  }
+  return undefined;
+}
+
+function reasonForSlackError(err: unknown): ResolveReason {
+  if (err instanceof SlackApiError) {
+    switch (err.category) {
+      case "auth":
+        return "auth";
+      case "channel_not_found":
+      case "not_found":
+        return "not_found";
+      case "permission":
+        return "permission";
+      case "rate_limit":
+        return "rate_limit";
+      default:
+        return "slack_error";
+    }
+  }
+  return "slack_error";
+}
+
+async function handleSlackChannelNameResolve({
+  pathParams = {},
+  headers,
+}: RouteHandlerArgs): Promise<SlackChannelResolveResponse> {
+  const conversationId = pathParams.conversationId?.trim();
+  if (!conversationId) {
+    throw new NotFoundError("Conversation not found");
+  }
+
+  const binding = getBindingByConversation(conversationId);
+
+  if (!binding || binding.sourceChannel !== "slack") {
+    throw new NotFoundError("Conversation not found");
+  }
+
+  const channelId = binding.externalChatId;
+  const cachedName = friendlyCachedName(channelId, binding.externalChatName);
+  if (cachedName) {
+    return {
+      channelId,
+      channelName: cachedName,
+      cached: true,
+      resolved: true,
+    };
+  }
+
+  if (channelId.startsWith("D")) {
+    return {
+      channelId,
+      cached: false,
+      resolved: false,
+      reason: "dm",
+    };
+  }
+
+  let info;
+  try {
+    info = await getSlackConversationInfo(channelId);
+  } catch (err) {
+    return {
+      channelId,
+      cached: false,
+      resolved: false,
+      reason: reasonForSlackError(err),
+    };
+  }
+
+  const channelName = usableResolvedName(
+    channelId,
+    info?.name,
+    info?.nameNormalized,
+  );
+  if (!channelName) {
+    return {
+      channelId,
+      cached: false,
+      resolved: false,
+      reason: "no_name",
+    };
+  }
+
+  updateExternalChatName(conversationId, channelName);
+  await publishSyncInvalidation(
+    [SYNC_TAGS.conversationsList, conversationMetadataSyncTag(conversationId)],
+    headers?.["x-vellum-client-id"]?.trim() || undefined,
+  );
+
+  return {
+    channelId,
+    channelName,
+    cached: false,
+    resolved: true,
+  };
+}
+
+export const ROUTES: RouteDefinition[] = [
+  {
+    operationId: "slack_channel_name_resolve",
+    endpoint: "conversations/:conversationId/slack-channel/resolve",
+    method: "POST",
+    handler: handleSlackChannelNameResolve,
+    summary: "Resolve Slack channel name",
+    description:
+      "Resolve and persist a friendly Slack channel name for an external conversation binding.",
+    tags: ["conversations", "slack"],
+    pathParams: [
+      {
+        name: "conversationId",
+        type: "string",
+        description: "Conversation ID whose Slack channel name should resolve.",
+      },
+    ],
+    responseBody: SlackChannelResolveResponseSchema,
+  },
+];

package/src/runtime/routes/workspace-routes.ts

@@ -59,9 +59,12 @@ function isSoundsWorkspacePath(path: string): boolean {
   );
 }
 
-function publishSoundsConfigUpdatedForPaths(paths: string[]): void {
+function publishSoundsConfigUpdatedForPaths(
+  paths: string[],
+  originClientId?: string,
+): void {
   if (paths.some(isSoundsWorkspacePath)) {
-    publishSoundsConfigUpdated();
+    publishSoundsConfigUpdated(originClientId);
   }
 }
 
@@ -263,7 +266,7 @@ function handleWorkspaceFileContent({
 // POST /v1/workspace/write — create or overwrite a file
 // ---------------------------------------------------------------------------
 
-function handleWorkspaceWrite({ body }: RouteHandlerArgs) {
+function handleWorkspaceWrite({ body, headers }: RouteHandlerArgs) {
   const path = body?.path as string | undefined;
   const content = body?.content as string | undefined;
   const encoding = body?.encoding as string | undefined;
@@ -292,7 +295,10 @@ function handleWorkspaceWrite({ body }: RouteHandlerArgs) {
 
   mkdirSync(dirname(resolved), { recursive: true });
   writeFileSync(resolved, buffer);
-  publishSoundsConfigUpdatedForPaths([path]);
+  publishSoundsConfigUpdatedForPaths(
+    [path],
+    headers?.["x-vellum-client-id"]?.trim() || undefined,
+  );
 
   return { path, size: buffer.byteLength };
 }
@@ -301,7 +307,7 @@ function handleWorkspaceWrite({ body }: RouteHandlerArgs) {
 // POST /v1/workspace/mkdir — create directories
 // ---------------------------------------------------------------------------
 
-function handleWorkspaceMkdir({ body }: RouteHandlerArgs) {
+function handleWorkspaceMkdir({ body, headers }: RouteHandlerArgs) {
   const path = body?.path as string | undefined;
   if (!path) {
     throw new BadRequestError("path is required");
@@ -320,7 +326,10 @@ function handleWorkspaceMkdir({ body }: RouteHandlerArgs) {
   }
 
   mkdirSync(resolved, { recursive: true });
-  publishSoundsConfigUpdatedForPaths([path]);
+  publishSoundsConfigUpdatedForPaths(
+    [path],
+    headers?.["x-vellum-client-id"]?.trim() || undefined,
+  );
   return { path };
 }
 
@@ -328,7 +337,7 @@ function handleWorkspaceMkdir({ body }: RouteHandlerArgs) {
 // POST /v1/workspace/rename — rename/move files and directories
 // ---------------------------------------------------------------------------
 
-function handleWorkspaceRename({ body }: RouteHandlerArgs) {
+function handleWorkspaceRename({ body, headers }: RouteHandlerArgs) {
   const oldPath = body?.oldPath as string | undefined;
   const newPath = body?.newPath as string | undefined;
   if (!oldPath || !newPath) {
@@ -360,7 +369,10 @@ function handleWorkspaceRename({ body }: RouteHandlerArgs) {
 
   mkdirSync(dirname(resolvedNew), { recursive: true });
   renameSync(resolvedOld, resolvedNew);
-  publishSoundsConfigUpdatedForPaths([oldPath, newPath]);
+  publishSoundsConfigUpdatedForPaths(
+    [oldPath, newPath],
+    headers?.["x-vellum-client-id"]?.trim() || undefined,
+  );
   return { oldPath, newPath };
 }
 
@@ -368,7 +380,7 @@ function handleWorkspaceRename({ body }: RouteHandlerArgs) {
 // POST /v1/workspace/delete — delete files and directories
 // ---------------------------------------------------------------------------
 
-function handleWorkspaceDelete({ body }: RouteHandlerArgs) {
+function handleWorkspaceDelete({ body, headers }: RouteHandlerArgs) {
   const path = body?.path as string | undefined;
   if (!path) {
     throw new BadRequestError("path is required");
@@ -388,7 +400,10 @@ function handleWorkspaceDelete({ body }: RouteHandlerArgs) {
   }
 
   rmSync(resolved, { recursive: true, force: true });
-  publishSoundsConfigUpdatedForPaths([path]);
+  publishSoundsConfigUpdatedForPaths(
+    [path],
+    headers?.["x-vellum-client-id"]?.trim() || undefined,
+  );
   return { success: true };
 }
 

package/src/runtime/services/conversation-serializer.ts

@@ -23,7 +23,10 @@ import {
 } from "../../memory/conversation-crud.js";
 import type { ExternalConversationBinding } from "../../memory/external-conversation-store.js";
 import { getBindingsForConversations } from "../../memory/external-conversation-store.js";
-import { buildSlackMessageDeepLinks } from "../../messaging/providers/slack/deep-link.js";
+import {
+  buildSlackMessageDeepLinks,
+  buildSlackWebChannelUrl,
+} from "../../messaging/providers/slack/deep-link.js";
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -91,10 +94,11 @@ function buildForkParent(
 }
 
 function buildChannelBinding(binding: ExternalConversationBinding) {
+  const externalChatName =
+    binding.externalChatName?.trim() ||
+    (binding.sourceChannel === "slack" ? binding.externalChatId : undefined);
   const slackConfig =
-    binding.sourceChannel === "slack" && binding.externalThreadId
-      ? getConfig().slack
-      : undefined;
+    binding.sourceChannel === "slack" ? getConfig().slack : undefined;
   const slackThreadLink =
     slackConfig && binding.externalThreadId
       ? buildSlackMessageDeepLinks({
@@ -112,10 +116,31 @@ function buildChannelBinding(binding: ExternalConversationBinding) {
           ...(slackThreadLink ? { link: slackThreadLink } : {}),
         }
       : undefined;
+  const slackChannelWebUrl = slackConfig
+    ? buildSlackWebChannelUrl({
+        teamUrl: slackConfig.teamUrl,
+        channelId: binding.externalChatId,
+      })
+    : undefined;
+  const slackChannel =
+    binding.sourceChannel === "slack"
+      ? {
+          channelId: binding.externalChatId,
+          name: externalChatName,
+          ...(slackChannelWebUrl
+            ? {
+                link: {
+                  webUrl: slackChannelWebUrl,
+                },
+              }
+            : {}),
+        }
+      : undefined;
 
   return {
     sourceChannel: binding.sourceChannel,
     externalChatId: binding.externalChatId,
+    ...(externalChatName ? { externalChatName } : {}),
     ...(binding.externalThreadId
       ? { externalThreadId: binding.externalThreadId }
       : {}),
@@ -123,6 +148,7 @@ function buildChannelBinding(binding: ExternalConversationBinding) {
     displayName: binding.displayName,
     username: binding.username,
     ...(slackThread ? { slackThread } : {}),
+    ...(slackChannel ? { slackChannel } : {}),
   };
 }
 

package/src/runtime/sync/resource-sync-events.ts

@@ -9,15 +9,18 @@ import { getAvatarImagePath } from "../../util/platform.js";
 import { broadcastMessage } from "../assistant-event-hub.js";
 import { publishSyncInvalidation } from "./sync-publisher.js";
 
-export function publishAvatarChanged(): void {
+export function publishAvatarChanged(originClientId?: string): void {
   broadcastMessage({
     type: "avatar_updated",
     avatarPath: getAvatarImagePath(),
   });
-  void publishSyncInvalidation([SYNC_TAGS.assistantAvatar]);
+  void publishSyncInvalidation([SYNC_TAGS.assistantAvatar], originClientId);
 }
 
-export function publishIdentityChanged(fields: IdentityFields): void {
+export function publishIdentityChanged(
+  fields: IdentityFields,
+  originClientId?: string,
+): void {
   broadcastMessage({
     type: "identity_changed",
     name: fields.name,
@@ -26,59 +29,112 @@ export function publishIdentityChanged(fields: IdentityFields): void {
     emoji: fields.emoji,
     home: fields.home,
   });
-  void publishSyncInvalidation([SYNC_TAGS.assistantIdentity]);
+  void publishSyncInvalidation([SYNC_TAGS.assistantIdentity], originClientId);
 }
 
-export function publishConfigChanged(): void {
+export function publishConfigChanged(originClientId?: string): void {
   broadcastMessage({ type: "config_changed" });
-  void publishSyncInvalidation([SYNC_TAGS.assistantConfig]);
+  void publishSyncInvalidation([SYNC_TAGS.assistantConfig], originClientId);
 }
 
-export function publishSoundsConfigUpdated(): void {
+export function publishSoundsConfigUpdated(originClientId?: string): void {
   broadcastMessage({ type: "sounds_config_updated" });
-  void publishSyncInvalidation([SYNC_TAGS.assistantSounds]);
+  void publishSyncInvalidation([SYNC_TAGS.assistantSounds], originClientId);
 }
 
-export function publishSchedulesChanged(): void {
-  void publishSyncInvalidation([SYNC_TAGS.assistantSchedules]);
+export function publishSchedulesChanged(originClientId?: string): void {
+  void publishSyncInvalidation([SYNC_TAGS.assistantSchedules], originClientId);
+}
+
+/**
+ * Reasons that change the *shape* of the conversation list — a row is
+ * added, removed, or its position changes. These require web clients to
+ * refetch the paginated list because the row patch path (`refreshConversationRow`)
+ * only handles a single known id. Reasons not in this set are *content-only*
+ * changes to an existing row (e.g. `seen_changed`, `renamed`) and are
+ * delivered exclusively via the per-conversation `sync_changed` tag, which
+ * web consumes by GET-and-patching the single row.
+ */
+const SHAPE_CHANGING_REASONS: ReadonlySet<ConversationListInvalidatedReason> =
+  new Set(["created", "deleted", "reordered"]);
+
+/**
+ * Publish the legacy `conversation_list_invalidated` broadcast to macOS
+ * subscribers only.
+ *
+ * Web consumes `sync_changed` (`conversationsList` for shape changes,
+ * `conversation:<id>:metadata` for content changes) directly and patches
+ * the cached list in place — see `useAssistantSyncStream` for the consumer
+ * side. macOS (`ConversationRestorer.swift`) still listens for the typed
+ * broadcast.
+ *
+ * TODO(electron-cutover): remove this helper and all callers once macOS
+ * migrates to the Electron client and consumes `sync_changed` directly.
+ * At that point the `conversation_list_invalidated` message type can be
+ * retired entirely.
+ */
+function broadcastConversationListInvalidatedToMacos(
+  reason: ConversationListInvalidatedReason,
+): void {
+  broadcastMessage(
+    {
+      type: "conversation_list_invalidated",
+      reason,
+    },
+    undefined,
+    { targetInterfaceId: "macos" },
+  );
 }
 
 export function publishConversationListChanged(
   reason: ConversationListInvalidatedReason,
+  originClientId?: string,
 ): void {
-  broadcastMessage({
-    type: "conversation_list_invalidated",
-    reason,
-  });
-  void publishSyncInvalidation([SYNC_TAGS.conversationsList]);
+  broadcastConversationListInvalidatedToMacos(reason);
+  void publishSyncInvalidation([SYNC_TAGS.conversationsList], originClientId);
 }
 
 export function publishConversationMessagesChanged(
   conversationId: string,
+  originClientId?: string,
 ): void {
-  void publishSyncInvalidation([conversationMessagesSyncTag(conversationId)]);
+  void publishSyncInvalidation(
+    [conversationMessagesSyncTag(conversationId)],
+    originClientId,
+  );
 }
 
 export function publishConversationListAndMetadataChanged(
   reason: ConversationListInvalidatedReason,
   conversationIds: string | string[],
+  originClientId?: string,
 ): void {
   const ids = Array.isArray(conversationIds)
     ? conversationIds
     : [conversationIds];
-  broadcastMessage({
-    type: "conversation_list_invalidated",
-    reason,
-  });
-  void publishSyncInvalidation([
-    SYNC_TAGS.conversationsList,
-    ...ids.map((conversationId) => conversationMetadataSyncTag(conversationId)),
-  ]);
+  broadcastConversationListInvalidatedToMacos(reason);
+
+  // Shape-changing reasons (`created`, `deleted`, `reordered`) add or
+  // remove rows or change the order of the paginated window — web must
+  // refetch the list, so include the `conversationsList` umbrella tag.
+  // Content-only reasons (`renamed`, `seen_changed`) modify an existing
+  // row; web consumes the per-conversation metadata tag and GET-and-
+  // patches the single row, avoiding the full paginated list drain
+  // (`limit=50&offset=0..N` × foreground + background — ~14 requests
+  // per write at a few hundred conversations).
+  const tags: string[] = ids.map((conversationId) =>
+    conversationMetadataSyncTag(conversationId),
+  );
+  if (SHAPE_CHANGING_REASONS.has(reason)) {
+    tags.unshift(SYNC_TAGS.conversationsList);
+  }
+  void publishSyncInvalidation(tags, originClientId);
 }
 
 export function publishConversationTitleChanged(
   conversationId: string,
   title: string,
+  originClientId?: string,
 ): void {
   broadcastMessage(
     {
@@ -88,18 +144,27 @@ export function publishConversationTitleChanged(
     },
     conversationId,
   );
-  void publishSyncInvalidation([
-    SYNC_TAGS.conversationsList,
-    conversationMetadataSyncTag(conversationId),
-  ]);
+  // Renames are content-only — the paired typed `conversation_title_updated`
+  // event already carries the new title and patches the row in place on
+  // web; macOS receives the per-interface `conversation_list_invalidated`
+  // emitted from `broadcastMessage` (see `assistant-event-hub.ts`). The
+  // `sync_changed` metadata tag is included as a belt-and-suspenders signal
+  // for any sibling-tab consumer that missed the typed event.
+  void publishSyncInvalidation(
+    [conversationMetadataSyncTag(conversationId)],
+    originClientId,
+  );
 }
 
-export function publishConversationInferenceProfileChanged(params: {
-  conversationId: string;
-  profile: string | null;
-  sessionId?: string | null;
-  expiresAt?: number | null;
-}): void {
+export function publishConversationInferenceProfileChanged(
+  params: {
+    conversationId: string;
+    profile: string | null;
+    sessionId?: string | null;
+    expiresAt?: number | null;
+  },
+  originClientId?: string,
+): void {
   broadcastMessage(
     {
       type: "conversation_inference_profile_updated",
@@ -110,8 +175,11 @@ export function publishConversationInferenceProfileChanged(params: {
     },
     params.conversationId,
   );
-  void publishSyncInvalidation([
-    SYNC_TAGS.conversationsList,
-    conversationMetadataSyncTag(params.conversationId),
-  ]);
+  void publishSyncInvalidation(
+    [
+      SYNC_TAGS.conversationsList,
+      conversationMetadataSyncTag(params.conversationId),
+    ],
+    originClientId,
+  );
 }

package/src/runtime/sync/sync-publisher.test.ts

@@ -102,4 +102,53 @@ describe("sync publisher", () => {
       subscription.dispose();
     }
   });
+
+  test("forwards originClientId when provided", async () => {
+    const received: AssistantEvent[] = [];
+    const subscription = assistantEventHub.subscribe({
+      type: "process",
+      callback: (event) => {
+        received.push(event);
+      },
+    });
+
+    try {
+      const message = await publishSyncInvalidation(
+        [SYNC_TAGS.assistantAvatar],
+        "client-abc",
+      );
+
+      await waitFor(() => received.length === 1);
+
+      expect(message).toEqual({
+        type: "sync_changed",
+        tags: [SYNC_TAGS.assistantAvatar],
+        originClientId: "client-abc",
+      });
+      expect(received[0].message).toEqual(message);
+    } finally {
+      subscription.dispose();
+    }
+  });
+
+  test("omits originClientId when not provided", async () => {
+    const received: AssistantEvent[] = [];
+    const subscription = assistantEventHub.subscribe({
+      type: "process",
+      callback: (event) => {
+        received.push(event);
+      },
+    });
+
+    try {
+      const message = await publishSyncInvalidation([SYNC_TAGS.assistantAvatar]);
+
+      await waitFor(() => received.length === 1);
+
+      expect("originClientId" in message).toBe(false);
+      expect(received[0].message).toEqual(message);
+    } finally {
+      subscription.dispose();
+    }
+  });
 });

package/src/runtime/sync/sync-publisher.ts

@@ -10,8 +10,9 @@ const log = getLogger("sync-publisher");
 
 export async function publishSyncInvalidation(
   tags: SyncInvalidationTag[],
+  originClientId?: string,
 ): Promise<SyncChangedMessage> {
-  const message = buildSyncChangedMessage(tags);
+  const message = buildSyncChangedMessage(tags, originClientId);
   try {
     broadcastMessage(message);
   } catch (err) {