@vellumai/assistant 0.6.6 → 0.7.1

package/src/memory/context-search/types.ts

@@ -0,0 +1,49 @@
+import type { AssistantConfig } from "../../config/schema.js";
+
+export type RecallSource = "memory" | "pkb" | "conversations" | "workspace";
+
+export type RecallDepth = "fast" | "standard" | "deep";
+
+export interface RecallInput {
+  query: string;
+  sources?: RecallSource[];
+  max_results?: number;
+  depth?: RecallDepth;
+}
+
+export interface RecallEvidence {
+  id: string;
+  source: RecallSource;
+  title: string;
+  locator: string;
+  excerpt: string;
+  timestampMs?: number;
+  score?: number;
+  metadata?: Record<string, unknown>;
+}
+
+export interface RecallSearchContext {
+  workingDir: string;
+  memoryScopeId: string;
+  conversationId: string;
+  config: AssistantConfig;
+  signal?: AbortSignal;
+}
+
+export interface RecallSearchResult {
+  evidence: RecallEvidence[];
+}
+
+export interface RecallAnswer {
+  answer: string;
+  evidence: RecallEvidence[];
+}
+
+export interface RecallSourceAdapter {
+  source: RecallSource;
+  search(
+    query: string,
+    context: RecallSearchContext,
+    limit: number,
+  ): Promise<RecallSearchResult>;
+}

package/src/memory/conversation-analyze-job.ts

@@ -2,9 +2,8 @@
 // Auto-analyze — conversation_analyze job handler
 //
 // Bridges the jobs worker to the shared analyzeConversation() service. The
-// deps bundle is stashed on a module singleton during daemon startup; if it
-// isn't set yet the handler throws BackendUnavailableError so the worker
-// defers with exponential backoff until deps become available.
+// service imports its dependencies (getOrCreateConversation, assistantEventHub)
+// directly — no DI singleton required.
 //
 // The service itself distinguishes manual vs. auto triggers: this handler
 // always invokes with `trigger: "auto"`, so the rolling analysis conversation
@@ -13,8 +12,6 @@
 
 import type { AssistantConfig } from "../config/types.js";
 import { analyzeConversation } from "../runtime/services/analyze-conversation.js";
-import { getAnalysisDeps } from "../runtime/services/analyze-deps-singleton.js";
-import { BackendUnavailableError } from "../util/errors.js";
 import { getLogger } from "../util/logger.js";
 import { enqueueAutoAnalysisIfEnabled } from "./auto-analysis-enqueue.js";
 import type { MemoryJob } from "./jobs-store.js";
@@ -31,25 +28,7 @@ export async function conversationAnalyzeJob(
     return;
   }
 
-  const deps = getAnalysisDeps();
-  if (!deps) {
-    // Daemon hasn't finished startup. Throw BackendUnavailableError so the
-    // worker defers the job with exponential backoff instead of completing
-    // it. Returning success here would permanently drop the job via
-    // completeMemoryJob — conversations with a pre-existing queued job
-    // during startup and no subsequent activity would never be analyzed.
-    // The deferral budget (50 × up to 5min backoff) is generous enough to
-    // outlast any realistic startup delay.
-    log.warn(
-      { jobId: job.id, conversationId },
-      "Deferring job: analysis deps not yet initialized",
-    );
-    throw new BackendUnavailableError(
-      "Analysis deps not yet initialized during daemon startup",
-    );
-  }
-
-  const result = await analyzeConversation(conversationId, deps, {
+  const result = await analyzeConversation(conversationId, {
     trigger: "auto",
   });
   if ("error" in result) {

package/src/memory/conversation-attention-store.ts

@@ -10,7 +10,7 @@ import { and, desc, eq, inArray, isNull, lt, or, sql } from "drizzle-orm";
 import { v4 as uuid } from "uuid";
 
 import { UserError } from "../util/errors.js";
-import { getDb } from "./db.js";
+import { getDb } from "./db-connection.js";
 import {
   conversationAssistantAttentionState,
   conversationAttentionEvents,

package/src/memory/conversation-bootstrap.ts

@@ -6,7 +6,7 @@ import {
 } from "./conversation-title-service.js";
 
 export interface BootstrapConversationOptions {
-  conversationType?: "standard" | "private" | "background" | "scheduled";
+  conversationType?: "standard" | "background" | "scheduled";
   source?: string;
   origin: TitleOrigin;
   systemHint: string;

package/src/memory/conversation-crud.ts

@@ -20,9 +20,9 @@ import { z } from "zod";
 
 import type { ChannelId, InterfaceId } from "../channels/types.js";
 import { parseChannelId, parseInterfaceId } from "../channels/types.js";
-import { CHANNEL_IDS, INTERFACE_IDS, isChannelId } from "../channels/types.js";
+import { CHANNEL_IDS, isChannelId } from "../channels/types.js";
 import { getConfig } from "../config/loader.js";
-import type { TrustContext } from "../daemon/conversation-runtime-assembly.js";
+import type { TrustContext } from "../daemon/trust-context.js";
 import { UserError } from "../util/errors.js";
 import { safeParseRecord } from "../util/json.js";
 import { getLogger } from "../util/logger.js";
@@ -45,12 +45,12 @@ import {
 } from "./conversation-disk-view.js";
 import { ensureDisplayOrderMigration } from "./conversation-display-order-migration.js";
 import { ensureGroupMigration } from "./conversation-group-migration.js";
-import { getDb, rawExec, rawGet, rawRun } from "./db.js";
+import { getDb } from "./db-connection.js";
 import { indexMessageNow } from "./indexer.js";
+import { rawExec, rawGet, rawRun } from "./raw-query.js";
 import {
   channelInboundEvents,
   conversations,
-  conversationStarters,
   llmRequestLogs,
   memoryEmbeddings,
   memorySegments,
@@ -68,7 +68,12 @@ const log = getLogger("conversation-store");
 // extra keys are allowed via passthrough so callers can attach ad-hoc data.
 
 const channelIdSchema = z.enum(CHANNEL_IDS);
-const interfaceIdSchema = z.enum(INTERFACE_IDS);
+// Accept both canonical INTERFACE_IDS and the legacy "vellum" alias,
+// normalizing to "web" on read so downstream code only handles canonical IDs.
+const interfaceIdSchema = z
+  .string()
+  .transform((v) => parseInterfaceId(v))
+  .refine((v): v is InterfaceId => v !== null);
 
 const subagentNotificationSchema = z.object({
   subagentId: z.string(),
@@ -78,9 +83,6 @@ const subagentNotificationSchema = z.object({
   conversationId: z.string().optional(),
 });
 
-export const PRIVATE_CONVERSATION_FORK_ERROR =
-  "Private conversations cannot be forked";
-
 export const messageMetadataSchema = z
   .object({
     userMessageChannel: channelIdSchema.optional(),
@@ -172,6 +174,8 @@ export interface ConversationRow {
   contextSummary: string | null;
   contextCompactedMessageCount: number;
   contextCompactedAt: number | null;
+  slackContextCompactionWatermarkTs: string | null;
+  slackContextCompactionWatermarkAt: number | null;
   conversationType: string;
   source: string;
   memoryScopeId: string;
@@ -179,11 +183,11 @@ export interface ConversationRow {
   originInterface: string | null;
   forkParentConversationId: string | null;
   forkParentMessageId: string | null;
-  hostAccess: number;
   isAutoTitle: number;
   scheduleJobId: string | null;
   lastMessageAt: number | null;
   archivedAt: number | null;
+  inferenceProfile: string | null;
 }
 
 export const parseConversation = createRowMapper<
@@ -200,6 +204,8 @@ export const parseConversation = createRowMapper<
   contextSummary: "contextSummary",
   contextCompactedMessageCount: "contextCompactedMessageCount",
   contextCompactedAt: "contextCompactedAt",
+  slackContextCompactionWatermarkTs: "slackContextCompactionWatermarkTs",
+  slackContextCompactionWatermarkAt: "slackContextCompactionWatermarkAt",
   conversationType: "conversationType",
   source: "source",
   memoryScopeId: "memoryScopeId",
@@ -207,11 +213,11 @@ export const parseConversation = createRowMapper<
   originInterface: "originInterface",
   forkParentConversationId: "forkParentConversationId",
   forkParentMessageId: "forkParentMessageId",
-  hostAccess: "hostAccess",
   isAutoTitle: "isAutoTitle",
   scheduleJobId: "scheduleJobId",
   lastMessageAt: "lastMessageAt",
   archivedAt: "archivedAt",
+  inferenceProfile: "inferenceProfile",
 });
 
 export interface MessageRow {
@@ -223,10 +229,7 @@ export interface MessageRow {
   metadata: string | null;
 }
 
-export const parseMessage = createRowMapper<
-  typeof messages.$inferSelect,
-  MessageRow
->({
+const parseMessage = createRowMapper<typeof messages.$inferSelect, MessageRow>({
   id: "id",
   conversationId: "conversationId",
   role: "role",
@@ -235,6 +238,8 @@ export const parseMessage = createRowMapper<
   metadata: "metadata",
 });
 
+export type ConversationCreateType = "standard" | "background" | "scheduled";
+
 /**
  * Monotonic timestamp source for message ordering. Two messages saved within
  * the same millisecond (e.g., tool_results user message + assistant message in
@@ -254,11 +259,10 @@ export function createConversation(
     | string
     | {
         title?: string;
-        conversationType?: "standard" | "private" | "background" | "scheduled";
+        conversationType?: ConversationCreateType;
         source?: string;
         scheduleJobId?: string;
         groupId?: string;
-        hostAccess?: boolean;
         forkParentConversationId?: string;
       },
 ) {
@@ -268,12 +272,13 @@ export function createConversation(
     typeof titleOrOpts === "string"
       ? { title: titleOrOpts }
       : (titleOrOpts ?? {});
-  const conversationType = opts.conversationType ?? "standard";
+  const requestedConversationType = opts.conversationType;
+  const conversationType: ConversationCreateType =
+    requestedConversationType ?? "standard";
   const source = opts.source ?? "user";
   const groupId = opts.groupId;
   const id = uuid();
-  const memoryScopeId =
-    conversationType === "private" ? `private:${id}` : "default";
+  const memoryScopeId = "default";
 
   // Ensure group_id column exists for deterministic schema readiness,
   // even when this conversation has no groupId (a subsequent query or
@@ -291,7 +296,8 @@ export function createConversation(
     contextSummary: null as string | null,
     contextCompactedMessageCount: 0,
     contextCompactedAt: null as number | null,
-    hostAccess: opts.hostAccess ? 1 : 0,
+    slackContextCompactionWatermarkTs: null as string | null,
+    slackContextCompactionWatermarkAt: null as number | null,
     conversationType,
     source,
     memoryScopeId,
@@ -438,30 +444,17 @@ export function getConversationSource(conversationId: string): string | null {
   return row?.source ?? null;
 }
 
-export function getConversationType(
-  conversationId: string,
-): "standard" | "private" {
-  const conv = getConversation(conversationId);
-  const raw = conv?.conversationType;
-  return raw === "private" ? "private" : "standard";
-}
-
 export function getConversationMemoryScopeId(conversationId: string): string {
   const conv = getConversation(conversationId);
   return conv?.memoryScopeId ?? "default";
 }
 
-export function getConversationHostAccess(conversationId: string): boolean {
-  const conv = getConversation(conversationId);
-  return conv?.hostAccess === 1;
-}
-
 /**
  * Fetch group_id for a conversation via raw SQL. group_id is NOT in the
  * Drizzle schema (raw-query-only pattern), so ConversationRow doesn't
  * include it. This helper is used by forkConversation to inherit group_id.
  */
-export function getConversationGroupId(conversationId: string): string | null {
+function getConversationGroupId(conversationId: string): string | null {
   ensureGroupMigration();
   const row = rawGet<{ group_id: string | null }>(
     "SELECT group_id FROM conversations WHERE id = ?",
@@ -481,10 +474,6 @@ export function forkConversation(params: {
   if (!sourceConversation) {
     throw new UserError(`Conversation ${conversationId} not found`);
   }
-  if (sourceConversation.conversationType === "private") {
-    throw new UserError(PRIVATE_CONVERSATION_FORK_ERROR);
-  }
-
   const sourceMessages = getMessages(conversationId);
 
   if (sourceMessages.length === 0) {
@@ -556,6 +545,13 @@ export function forkConversation(params: {
         contextCompactedAt: preserveSourceCompactionState
           ? sourceConversation.contextCompactedAt
           : null,
+        slackContextCompactionWatermarkTs: preserveSourceCompactionState
+          ? sourceConversation.slackContextCompactionWatermarkTs
+          : null,
+        slackContextCompactionWatermarkAt: preserveSourceCompactionState
+          ? sourceConversation.slackContextCompactionWatermarkAt
+          : null,
+        inferenceProfile: sourceConversation.inferenceProfile,
       })
       .where(eq(conversations.id, fc.id))
       .run();
@@ -707,8 +703,6 @@ export function deleteConversation(id: string): DeletedMemoryIds {
   // resolve the conversation's disk-view directory path after deletion.
   const convBeforeDelete = getConversation(id);
   const createdAtForDiskCleanup = convBeforeDelete?.createdAt;
-  const memoryScopeId = convBeforeDelete?.memoryScopeId;
-  const isPrivateScope = memoryScopeId?.startsWith("private:") ?? false;
 
   db.transaction((tx) => {
     // Collect all message IDs for this conversation.
@@ -759,36 +753,6 @@ export function deleteConversation(id: string): DeletedMemoryIds {
         .run();
     }
 
-    if (isPrivateScope && memoryScopeId) {
-      // Sweep memory summaries with this private scopeId.
-      const scopeSummaries = tx
-        .select({ id: memorySummaries.id })
-        .from(memorySummaries)
-        .where(eq(memorySummaries.scopeId, memoryScopeId))
-        .all();
-      const scopeSummaryIds = scopeSummaries.map((r) => r.id);
-
-      if (scopeSummaryIds.length > 0) {
-        tx.delete(memoryEmbeddings)
-          .where(
-            and(
-              eq(memoryEmbeddings.targetType, "summary"),
-              inArray(memoryEmbeddings.targetId, scopeSummaryIds),
-            ),
-          )
-          .run();
-        tx.delete(memorySummaries)
-          .where(inArray(memorySummaries.id, scopeSummaryIds))
-          .run();
-        result.deletedSummaryIds.push(...scopeSummaryIds);
-      }
-
-      // Sweep conversation starters with this private scopeId.
-      tx.delete(conversationStarters)
-        .where(eq(conversationStarters.scopeId, memoryScopeId))
-        .run();
-    }
-
     tx.delete(conversations).where(eq(conversations.id, id)).run();
   });
 
@@ -858,50 +822,6 @@ export function wipeConversation(id: string): WipeConversationResult {
   };
 }
 
-/**
- * Delete all private (temporary) conversations and their associated data.
- * Called at daemon startup to clean up ephemeral conversations from previous sessions.
- * Returns the count and aggregated deleted memory IDs for Qdrant cleanup.
- */
-export function purgePrivateConversations(): {
-  count: number;
-  deletedMemory: DeletedMemoryIds;
-} {
-  const db = getDb();
-  const privateConvs = db
-    .select({ id: conversations.id })
-    .from(conversations)
-    .where(eq(conversations.conversationType, "private"))
-    .all();
-
-  if (privateConvs.length === 0) {
-    return {
-      count: 0,
-      deletedMemory: {
-        segmentIds: [],
-        deletedSummaryIds: [],
-      },
-    };
-  }
-
-  const allSegmentIds: string[] = [];
-  const allDeletedSummaryIds: string[] = [];
-
-  for (const conv of privateConvs) {
-    const deleted = deleteConversation(conv.id);
-    allSegmentIds.push(...deleted.segmentIds);
-    allDeletedSummaryIds.push(...deleted.deletedSummaryIds);
-  }
-
-  return {
-    count: privateConvs.length,
-    deletedMemory: {
-      segmentIds: allSegmentIds,
-      deletedSummaryIds: allDeletedSummaryIds,
-    },
-  };
-}
-
 export async function addMessage(
   conversationId: string,
   role: string,
@@ -1269,14 +1189,16 @@ export function updateConversationContextWindow(
     .run();
 }
 
-export function updateConversationHostAccess(
+export function updateConversationSlackContextWatermark(
   id: string,
-  hostAccess: boolean,
+  watermarkTs: string,
+  compactedAt: number = Date.now(),
 ): void {
   const db = getDb();
   db.update(conversations)
     .set({
-      hostAccess: hostAccess ? 1 : 0,
+      slackContextCompactionWatermarkTs: watermarkTs,
+      slackContextCompactionWatermarkAt: compactedAt,
       updatedAt: Date.now(),
     })
     .where(eq(conversations.id, id))
@@ -1308,6 +1230,51 @@ export function unarchiveConversation(id: string): boolean {
   return true;
 }
 
+/**
+ * Set or clear the inference profile override for a conversation.
+ * Pass `null` to clear the override and fall back to the workspace
+ * `llm.activeProfile` resolution.
+ */
+export function setConversationInferenceProfile(
+  conversationId: string,
+  profile: string | null,
+): void {
+  const db = getDb();
+  db.update(conversations)
+    .set({ inferenceProfile: profile, updatedAt: Date.now() })
+    .where(eq(conversations.id, conversationId))
+    .run();
+}
+
+/**
+ * Resolve the per-turn inference-profile override from an already-loaded
+ * conversation row. Returns the row's `inferenceProfile` for non-background
+ * conversations, `undefined` otherwise — background turns (subagent fan-out,
+ * scheduled tasks, update bulletins) run on the workspace defaults rather
+ * than inheriting an interactive override.
+ *
+ * Prefer this row-based form when the caller already needs to read the
+ * conversation row for other reasons (e.g. the agent loop's title check).
+ */
+export function getConversationOverrideProfileFromRow(
+  conv: ConversationRow | null,
+): string | undefined {
+  if (conv?.conversationType === "background") return undefined;
+  return conv?.inferenceProfile ?? undefined;
+}
+
+/**
+ * Resolve the per-turn inference-profile override by conversation id.
+ * Convenience wrapper around `getConversationOverrideProfileFromRow` for
+ * standalone callers (e.g. subagent spawn, opportunity-wake) that don't
+ * already have the row in hand.
+ */
+export function getConversationOverrideProfile(
+  conversationId: string,
+): string | undefined {
+  return getConversationOverrideProfileFromRow(getConversation(conversationId));
+}
+
 /**
  * Delete all conversations, messages, and related data (tool invocations,
  * memory segments, etc.) from the daemon database.
@@ -1761,8 +1728,8 @@ export function getConversationOriginInterface(
  * in the given conversation, or `undefined` if none is found.
  *
  * Used by the pointer message trust resolver to detect conversations
- * whose audience is a guardian or trusted_contact (even if the
- * conversation itself isn't a desktop-origin private conversation).
+ * whose audience is a guardian or trusted_contact outside desktop-origin
+ * conversations.
  */
 export function getConversationRecentProvenanceTrustClass(
   conversationId: string,

package/src/memory/conversation-directories.ts

@@ -7,10 +7,7 @@ function getConversationDirTimestamp(createdAtMs: number): string {
   return new Date(createdAtMs).toISOString().replace(/:/g, "-");
 }
 
-export function getLegacyConversationDirName(
-  id: string,
-  createdAtMs: number,
-): string {
+function getLegacyConversationDirName(id: string, createdAtMs: number): string {
   return `${id}_${getConversationDirTimestamp(createdAtMs)}`;
 }
 
@@ -146,13 +143,6 @@ export function getResolvedConversationDirPath(
   return resolveConversationDirectoryPaths(id, createdAtMs).resolvedDirPath;
 }
 
-export function getResolvedConversationDirName(
-  id: string,
-  createdAtMs: number,
-): string {
-  return resolveConversationDirectoryPaths(id, createdAtMs).resolvedDirName;
-}
-
 export function getConversationAttachmentsDirPath(
   conversationId: string,
   createdAtMs: number,

package/src/memory/conversation-disk-view.ts

@@ -43,11 +43,7 @@ const log = getLogger("conversation-disk-view");
 // Directory helpers
 // ---------------------------------------------------------------------------
 
-export {
-  getConversationDirName,
-  getConversationDirPath,
-  getResolvedConversationDirPath,
-};
+export { getConversationDirName, getConversationDirPath };
 
 function ensureConversationDirPath(id: string, createdAtMs: number): string {
   const dirPath = getResolvedConversationDirPath(id, createdAtMs);

package/src/memory/conversation-display-order-migration.ts

@@ -6,8 +6,7 @@
  */
 
 import { getLogger } from "../util/logger.js";
-import { rawRun } from "./db.js";
-
+import { rawRun } from "./raw-query.js";
 const log = getLogger("conversation-store");
 
 function isDuplicateColumnError(err: unknown): boolean {
@@ -41,3 +40,13 @@ export function ensureDisplayOrderMigration(): void {
     displayOrderColumnsEnsured = true;
   }
 }
+
+/**
+ * Reset the in-memory `displayOrderColumnsEnsured` guard so the next
+ * `ensureDisplayOrderMigration()` call re-runs. Intended ONLY for tests that
+ * recreate the SQLite database mid-process (e.g. `removeTestDbFiles()` in
+ * `db-conversation-inference-profile-migration.test.ts`).
+ */
+export function _resetDisplayOrderMigrationForTests(): void {
+  displayOrderColumnsEnsured = false;
+}

package/src/memory/conversation-group-migration.ts

@@ -10,8 +10,7 @@
 
 import { getLogger } from "../util/logger.js";
 import { ensureDisplayOrderMigration } from "./conversation-display-order-migration.js";
-import { rawExec, rawGet, rawRun } from "./db.js";
-
+import { rawExec, rawGet, rawRun } from "./raw-query.js";
 const log = getLogger("conversation-store");
 
 function isDuplicateColumnError(err: unknown): boolean {
@@ -20,6 +19,18 @@ function isDuplicateColumnError(err: unknown): boolean {
 
 let migrated = false;
 
+/**
+ * Reset the in-memory `migrated` guard so the next `ensureGroupMigration()`
+ * call re-runs the full migration. Intended ONLY for tests that recreate
+ * the SQLite database mid-process (e.g. `removeTestDbFiles()` in
+ * `db-conversation-inference-profile-migration.test.ts`) — without this,
+ * subsequent tests in the same `bun test` run hit
+ * `no such column: group_id` because the guard short-circuits the recreate.
+ */
+export function _resetGroupMigrationForTests(): void {
+  migrated = false;
+}
+
 /**
  * Uses raw BEGIN/COMMIT for the one-time backfill. Must NOT be called
  * for the first time inside a Drizzle db.transaction() block — SQLite
@@ -235,7 +246,10 @@ export function ensureGroupMigration(): void {
       rawExec("COMMIT");
     } catch (err) {
       rawExec("ROLLBACK");
-      log.error({ err }, "reflections-to-background migration failed, rolled back");
+      log.error(
+        { err },
+        "reflections-to-background migration failed, rolled back",
+      );
       throw err;
     }
   }
@@ -262,7 +276,9 @@ export function ensureGroupMigration(): void {
         WHERE group_id = 'system:reflections'
       `);
 
-      rawExec(`DELETE FROM conversation_groups WHERE id = 'system:reflections'`);
+      rawExec(
+        `DELETE FROM conversation_groups WHERE id = 'system:reflections'`,
+      );
 
       rawExec(`
         INSERT OR IGNORE INTO conversation_groups (id, name, sort_position, is_system_group)

package/src/memory/conversation-key-store.ts

@@ -16,7 +16,7 @@ import { getLogger } from "../util/logger.js";
 import { getWorkspacePromptPath } from "../util/platform.js";
 import { initConversationDir } from "./conversation-disk-view.js";
 import { GENERATING_TITLE } from "./conversation-title-service.js";
-import { getDb } from "./db.js";
+import { getDb } from "./db-connection.js";
 import { conversationKeys, conversations } from "./schema.js";
 
 const log = getLogger("conversation-key-store");
@@ -140,7 +140,7 @@ export function resolveConversationId(idOrKey: string): string | null {
  */
 export function getOrCreateConversation(
   conversationKey: string,
-  opts?: { conversationType?: "standard" | "private" },
+  opts?: { conversationType?: "standard" },
 ): {
   conversationId: string;
   conversationType: string;
@@ -219,8 +219,7 @@ export function getOrCreateConversation(
     const now = Date.now();
     const conversationId = uuid();
     const title = GENERATING_TITLE;
-    const memoryScopeId =
-      conversationType === "private" ? `private:${conversationId}` : "default";
+    const memoryScopeId = "default";
 
     tx.insert(conversations)
       .values({