@vellumai/assistant 0.6.4 → 0.6.5

package/src/home/feed-types.ts

@@ -25,7 +25,7 @@ import { z } from "zod";
 export type FeedItemType = "nudge" | "digest" | "action" | "thread";
 
 /** User-facing lifecycle of a feed item. */
-export type FeedItemStatus = "new" | "seen" | "acted_on";
+export type FeedItemStatus = "new" | "seen" | "acted_on" | "dismissed";
 
 /**
  * Origin of the underlying event.
@@ -46,6 +46,9 @@ export type FeedItemSource = "gmail" | "slack" | "calendar" | "assistant";
  */
 export type FeedItemAuthor = "assistant" | "platform";
 
+/** Visual urgency treatment — controls badge color independently of sort priority. */
+export type FeedItemUrgency = "low" | "medium" | "high" | "critical";
+
 /**
  * A single action button attached to a feed item.
  *
@@ -89,12 +92,24 @@ export interface FeedItem {
   /** Minimum seconds the user must be away before the item is shown. */
   minTimeAway?: number;
   actions?: FeedAction[];
+  /** Visual urgency treatment — controls badge color independently of sort priority. */
+  urgency?: FeedItemUrgency;
   /** Internal: who authored this item. */
   author: FeedItemAuthor;
   /** Internal: ISO-8601 writer-record time, used for ordering + TTL. */
   createdAt: string;
 }
 
+/**
+ * Summary of low-priority items that were collapsed out of the main
+ * feed list. The client renders this as a single "N low priority
+ * updates" line instead of showing each item individually.
+ */
+export interface LowPriorityCollapsed {
+  count: number;
+  itemIds: string[];
+}
+
 /**
  * On-disk file format for `~/.vellum/workspace/data/home-feed.json`.
  *
@@ -108,13 +123,34 @@ export interface HomeFeedFile {
   updatedAt: string;
 }
 
+/**
+ * Origin of a suggested prompt — whether it was deterministically derived
+ * (e.g. from a missing OAuth connection) or generated by the assistant.
+ */
+export type SuggestedPromptSource = "deterministic" | "assistant";
+
+/**
+ * A prompt suggestion shown at the top of the Home page.
+ *
+ * Deterministic prompts are derived from workspace state (e.g. missing
+ * OAuth connections). Assistant-generated prompts are contextual
+ * conversation starters produced by the LLM.
+ */
+export interface SuggestedPrompt {
+  id: string;
+  label: string;
+  icon?: string;
+  prompt: string;
+  source: SuggestedPromptSource;
+}
+
 // ---------------------------------------------------------------------------
 // Zod schemas
 // ---------------------------------------------------------------------------
 
 const feedItemTypeSchema = z.enum(["nudge", "digest", "action", "thread"]);
 
-const feedItemStatusSchema = z.enum(["new", "seen", "acted_on"]);
+const feedItemStatusSchema = z.enum(["new", "seen", "acted_on", "dismissed"]);
 
 const feedItemSourceSchema = z.enum([
   "gmail",
@@ -125,6 +161,8 @@ const feedItemSourceSchema = z.enum([
 
 const feedItemAuthorSchema = z.enum(["assistant", "platform"]);
 
+const feedItemUrgencySchema = z.enum(["low", "medium", "high", "critical"]);
+
 const feedActionSchema = z.object({
   id: z.string(),
   label: z.string(),
@@ -157,10 +195,26 @@ export const feedItemSchema = z.object({
   expiresAt: z.string().optional(),
   minTimeAway: z.number().int().min(0).optional(),
   actions: z.array(feedActionSchema).optional(),
+  urgency: feedItemUrgencySchema.optional(),
   author: feedItemAuthorSchema,
   createdAt: z.string(),
 });
 
+const suggestedPromptSourceSchema = z.enum(["deterministic", "assistant"]);
+
+export const suggestedPromptSchema = z.object({
+  id: z.string(),
+  label: z.string(),
+  icon: z.string().optional(),
+  prompt: z.string(),
+  source: suggestedPromptSourceSchema,
+});
+
+export const lowPriorityCollapsedSchema = z.object({
+  count: z.number().int().min(0),
+  itemIds: z.array(z.string()),
+});
+
 /** Schema for the on-disk `home-feed.json` file. */
 export const homeFeedFileSchema = z.object({
   version: z.literal(1),

package/src/home/relationship-state-writer.ts

@@ -161,7 +161,7 @@ export async function computeRelationshipState(): Promise<RelationshipState> {
   //   1. The guardian contact's per-user file (`users/<slug>.md`), resolved
   //      via `resolveGuardianPersonaPath()` — this is the canonical location
   //      after workspace migration 031 and handles slugged userFiles like
-  //      `users/sidd.md` that were invisible to a hardcoded `default.md`
+  //      `users/alice.md` that were invisible to a hardcoded `default.md`
   //      lookup.
   //   2. Legacy workspace-root `USER.md` as a last-ditch fallback for very
   //      old workspaces that never ran migration 031.
@@ -361,7 +361,7 @@ export async function backfillRelationshipStateIfMissing(): Promise<void> {
  * user content:
  *
  *   1. `resolveGuardianPersonaPath()` via contact-store — the canonical
- *      per-guardian slugged file (e.g. `users/sidd.md`).
+ *      per-guardian slugged file (e.g. `users/alice.md`).
  *   2. `users/default.md` — the default-guardian persona file that the
  *      workspace migration leaves in place. Catches the window where
  *      the resolver throws or returns null but the file-backed content

package/src/home/rollup-producer.ts

@@ -144,10 +144,16 @@ export interface RollupResult {
    * `no_actions` means there was nothing to roll up — a quiet but
    * normal outcome that does not advance the cooldown gate (no point
    * re-running until new actions land).
+   *
+   * `in_flight` means another caller is already running the producer.
+   * The second call short-circuits without entering the body so we
+   * never fire two concurrent LLM requests — this guards against the
+   * scheduler tick and an on-visit refresh trigger racing each other.
    */
   skippedReason:
     | "no_provider"
     | "no_actions"
+    | "in_flight"
     | "empty_items"
     | "provider_error"
     | "malformed_output"
@@ -169,6 +175,16 @@ export interface RollupProducerDeps {
   resolveProvider?: () => Provider | null;
 }
 
+/**
+ * Module-level in-flight guard. Prevents two callers (e.g. the
+ * scheduler tick and an on-visit refresh trigger) from launching two
+ * concurrent LLM requests. A second caller short-circuits with
+ * `skippedReason: "in_flight"` without entering the body. The lock
+ * is released in the `finally` so a thrown exception can't strand
+ * it in the `true` state.
+ */
+let producerInFlight = false;
+
 /**
  * Run one roll-up pass. Loads recent action items from the feed plus
  * relationship state, builds a user prompt around them, asks the
@@ -178,6 +194,21 @@ export interface RollupProducerDeps {
 export async function runRollupProducer(
   now: Date = new Date(),
   deps: RollupProducerDeps = {},
+): Promise<RollupResult> {
+  if (producerInFlight) {
+    return { wroteCount: 0, skippedReason: "in_flight" };
+  }
+  producerInFlight = true;
+  try {
+    return await runRollupProducerInner(now, deps);
+  } finally {
+    producerInFlight = false;
+  }
+}
+
+async function runRollupProducerInner(
+  now: Date,
+  deps: RollupProducerDeps,
 ): Promise<RollupResult> {
   const writeItem = deps.writeItem ?? writeAssistantFeedItem;
   const loadRelationshipState =
@@ -261,10 +292,10 @@ export async function runRollupProducer(
 
 function resolveDefaultProvider(): ReturnType<typeof getProvider> | null {
   const config = loadConfig();
-  if (!listProviders().includes(config.services.inference.provider)) {
+  if (!listProviders().includes(config.llm.default.provider)) {
     return null;
   }
-  return getProvider(config.services.inference.provider);
+  return getProvider(config.llm.default.provider);
 }
 
 /**
@@ -337,9 +368,7 @@ function buildUserPrompt(
  * the `type` narrowing to digest/thread (actions and nudges are
  * rejected here even if the model ignores the tool schema).
  */
-function coerceRollupItem(
-  raw: unknown,
-): WriteAssistantFeedItemParams | null {
+function coerceRollupItem(raw: unknown): WriteAssistantFeedItemParams | null {
   if (!raw || typeof raw !== "object") return null;
   const obj = raw as Record<string, unknown>;
 

package/src/home/suggested-prompts.ts

@@ -0,0 +1,101 @@
+/**
+ * Suggested prompt producer for the Home feed.
+ *
+ * Returns an array of `SuggestedPrompt` items shown at the top of the
+ * Home page as conversation starters (e.g. "Connect Gmail", "Add Slack").
+ *
+ * Two sources of prompts:
+ *   - **Deterministic** — derived from missing OAuth connections.
+ *   - **Assistant-generated** — contextual suggestions from the LLM
+ *     (placeholder; not yet implemented).
+ */
+
+import { isProviderConnected, listProviders } from "../oauth/oauth-store.js";
+import { getLogger } from "../util/logger.js";
+import type { SuggestedPrompt } from "./feed-types.js";
+
+const log = getLogger("suggested-prompts");
+
+/**
+ * Map of provider keys to their suggested-prompt metadata. Only providers
+ * listed here produce deterministic "Connect X" prompts when disconnected.
+ * The icon values are VIcon case names rendered by the macOS client.
+ */
+const CONNECT_PROMPT_META: Record<
+  string,
+  { label: string; prompt: string; icon: string }
+> = {
+  google: {
+    label: "Connect Gmail",
+    prompt: "Help me connect my Gmail account",
+    icon: "mail",
+  },
+  slack: {
+    label: "Connect Slack",
+    prompt: "Help me connect my Slack workspace",
+    icon: "hash",
+  },
+  notion: {
+    label: "Connect Notion",
+    prompt: "Help me connect my Notion workspace",
+    icon: "fileText",
+  },
+  linear: {
+    label: "Connect Linear",
+    prompt: "Help me connect my Linear workspace",
+    icon: "clipboardList",
+  },
+  github: {
+    label: "Connect GitHub",
+    prompt: "Help me connect my GitHub account",
+    icon: "terminal",
+  },
+};
+
+/**
+ * Produce deterministic suggested prompts based on missing OAuth
+ * connections and (in the future) assistant-generated conversation
+ * starters.
+ */
+export async function getSuggestedPrompts(): Promise<SuggestedPrompt[]> {
+  const prompts: SuggestedPrompt[] = [];
+
+  try {
+    const deterministicPrompts = await getDeterministicPrompts();
+    prompts.push(...deterministicPrompts);
+  } catch (err) {
+    log.warn({ err }, "Failed to compute deterministic suggested prompts");
+  }
+
+  // Placeholder: assistant-generated prompts will be added here once
+  // the LLM producer is implemented.
+
+  return prompts;
+}
+
+/**
+ * Check which well-known OAuth providers are not connected and return
+ * a "Connect X" prompt for each.
+ */
+async function getDeterministicPrompts(): Promise<SuggestedPrompt[]> {
+  const providers = listProviders();
+  const prompts: SuggestedPrompt[] = [];
+
+  for (const provider of providers) {
+    const meta = CONNECT_PROMPT_META[provider.provider];
+    if (!meta) continue;
+
+    const connected = await isProviderConnected(provider.provider);
+    if (connected) continue;
+
+    prompts.push({
+      id: `connect-${provider.provider}`,
+      label: meta.label,
+      icon: meta.icon,
+      prompt: meta.prompt,
+      source: "deterministic",
+    });
+  }
+
+  return prompts;
+}

package/src/ipc/__tests__/attachment-ipc.test.ts

@@ -0,0 +1,213 @@
+/**
+ * Integration tests for the attachment IPC routes.
+ *
+ * Exercises the full IPC round-trip: CliIpcServer + cliIpcCall over
+ * the Unix domain socket, with the real SQLite attachment store backing
+ * the route handlers.
+ */
+
+import { unlinkSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+
+import { initializeDb } from "../../memory/db.js";
+import { cliIpcCall } from "../cli-client.js";
+import { CliIpcServer } from "../cli-server.js";
+
+// ---------------------------------------------------------------------------
+// DB setup (attachment store needs SQLite)
+// ---------------------------------------------------------------------------
+
+initializeDb();
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+let server: CliIpcServer | null = null;
+const tempFiles: string[] = [];
+
+function createTempFile(content: string, filename?: string): string {
+  const name = filename ?? `test-attachment-${Date.now()}.txt`;
+  const filePath = join(tmpdir(), name);
+  writeFileSync(filePath, content);
+  tempFiles.push(filePath);
+  return filePath;
+}
+
+beforeEach(async () => {
+  server = new CliIpcServer();
+  server.start();
+  // Allow the server socket to bind.
+  await new Promise((resolve) => setTimeout(resolve, 50));
+});
+
+afterEach(() => {
+  server?.stop();
+  server = null;
+
+  // Clean up temp files.
+  for (const filePath of tempFiles) {
+    try {
+      unlinkSync(filePath);
+    } catch {
+      /* file may already be gone */
+    }
+  }
+  tempFiles.length = 0;
+});
+
+// ---------------------------------------------------------------------------
+// Types
+// ---------------------------------------------------------------------------
+
+interface StoredAttachmentResult {
+  id: string;
+  originalFilename: string;
+  mimeType: string;
+  sizeBytes: number;
+  kind: string;
+  createdAt: number;
+}
+
+// ---------------------------------------------------------------------------
+// Tests
+// ---------------------------------------------------------------------------
+
+describe("attachment IPC routes", () => {
+  // -- attachment/register success ----------------------------------------
+
+  test("attachment/register returns stored attachment for valid file", async () => {
+    const filePath = createTempFile("hello world");
+
+    const result = await cliIpcCall<StoredAttachmentResult>(
+      "attachment/register",
+      {
+        path: filePath,
+        mimeType: "text/plain",
+      },
+    );
+
+    expect(result.ok).toBe(true);
+    expect(result.result).toBeDefined();
+    expect(typeof result.result!.id).toBe("string");
+    expect(result.result!.id.length).toBeGreaterThan(0);
+    expect(result.result!.originalFilename).toContain("test-attachment-");
+    expect(result.result!.mimeType).toBe("text/plain");
+    expect(result.result!.sizeBytes).toBe(11); // "hello world".length
+    expect(result.result!.kind).toBe("document");
+    expect(typeof result.result!.createdAt).toBe("number");
+  });
+
+  test("attachment/register uses custom filename when provided", async () => {
+    const filePath = createTempFile("custom name test");
+
+    const result = await cliIpcCall<StoredAttachmentResult>(
+      "attachment/register",
+      {
+        path: filePath,
+        mimeType: "image/png",
+        filename: "screenshot.png",
+      },
+    );
+
+    expect(result.ok).toBe(true);
+    expect(result.result!.originalFilename).toBe("screenshot.png");
+    expect(result.result!.mimeType).toBe("image/png");
+    expect(result.result!.kind).toBe("image");
+  });
+
+  // -- attachment/register errors -----------------------------------------
+
+  test("attachment/register errors when file does not exist", async () => {
+    const result = await cliIpcCall("attachment/register", {
+      path: "/tmp/nonexistent-file-that-should-not-exist-12345.txt",
+      mimeType: "text/plain",
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toContain("File not found");
+  });
+
+  test("attachment/register rejects missing path", async () => {
+    const result = await cliIpcCall("attachment/register", {
+      mimeType: "text/plain",
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toBeDefined();
+  });
+
+  test("attachment/register rejects missing mimeType", async () => {
+    const filePath = createTempFile("missing mime type");
+
+    const result = await cliIpcCall("attachment/register", {
+      path: filePath,
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toBeDefined();
+  });
+
+  // -- attachment/lookup errors -------------------------------------------
+
+  test("attachment/lookup errors when no attachment matches", async () => {
+    const result = await cliIpcCall("attachment/lookup", {
+      sourcePath: "/nonexistent/path/to/file.txt",
+      conversationId: "nonexistent-conversation-id",
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toContain("No attachment found");
+  });
+
+  test("attachment/lookup rejects missing sourcePath", async () => {
+    const result = await cliIpcCall("attachment/lookup", {
+      conversationId: "some-conversation-id",
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toBeDefined();
+  });
+
+  test("attachment/lookup rejects missing conversationId", async () => {
+    const result = await cliIpcCall("attachment/lookup", {
+      sourcePath: "/some/path",
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toBeDefined();
+  });
+
+  // -- Underscore aliases -------------------------------------------------
+
+  test("attachment_register alias works identically to attachment/register", async () => {
+    const filePath = createTempFile("alias test content");
+
+    const result = await cliIpcCall<StoredAttachmentResult>(
+      "attachment_register",
+      {
+        path: filePath,
+        mimeType: "text/plain",
+        filename: "alias-test.txt",
+      },
+    );
+
+    expect(result.ok).toBe(true);
+    expect(result.result).toBeDefined();
+    expect(result.result!.originalFilename).toBe("alias-test.txt");
+    expect(result.result!.mimeType).toBe("text/plain");
+    expect(typeof result.result!.id).toBe("string");
+  });
+
+  test("attachment_lookup alias works identically to attachment/lookup", async () => {
+    const result = await cliIpcCall("attachment_lookup", {
+      sourcePath: "/nonexistent/path/to/file.txt",
+      conversationId: "nonexistent-conversation-id",
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.error).toContain("No attachment found");
+  });
+});