@vellumai/assistant 0.5.13 → 0.5.14

package/src/__tests__/config-watcher.test.ts

@@ -1,8 +1,5 @@
-import { mkdirSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
+import { mkdirSync } from "node:fs";
 import {
-  afterAll,
   afterEach,
   beforeAll,
   beforeEach,
@@ -16,40 +13,12 @@ import {
 // Temp directory scaffold
 // ---------------------------------------------------------------------------
 
-const TEST_DIR = join(tmpdir(), `config-watcher-test-${crypto.randomUUID()}`);
-const WORKSPACE_DIR = join(TEST_DIR, "workspace");
-const PROTECTED_DIR = join(TEST_DIR, "protected");
-const SKILLS_DIR = join(WORKSPACE_DIR, "skills");
+const WORKSPACE_DIR = process.env.VELLUM_WORKSPACE_DIR!;
 
 // ---------------------------------------------------------------------------
 // Mock platform paths
 // ---------------------------------------------------------------------------
 
-mock.module("../util/platform.js", () => ({
-  getRootDir: () => TEST_DIR,
-  getWorkspaceDir: () => WORKSPACE_DIR,
-  getWorkspaceSkillsDir: () => SKILLS_DIR,
-  getWorkspaceConfigPath: () => join(WORKSPACE_DIR, "config.json"),
-  getWorkspacePromptPath: (file: string) => join(WORKSPACE_DIR, file),
-  ensureDataDir: () => {},
-  getDataDir: () => join(WORKSPACE_DIR, "data"),
-  getPidPath: () => join(TEST_DIR, "vellum.pid"),
-  getDbPath: () => join(WORKSPACE_DIR, "data", "assistant.db"),
-  getLogPath: () => join(WORKSPACE_DIR, "data", "logs", "vellum.log"),
-  getHistoryPath: () => join(WORKSPACE_DIR, "data", "history"),
-  getHooksDir: () => join(WORKSPACE_DIR, "hooks"),
-  getSignalsDir: () => join(TEST_DIR, "signals"),
-
-  getSandboxRootDir: () => join(WORKSPACE_DIR, "data", "sandbox"),
-  getSandboxWorkingDir: () => WORKSPACE_DIR,
-  getInterfacesDir: () => join(WORKSPACE_DIR, "data", "interfaces"),
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPlatformName: () => process.platform,
-  getClipboardCommand: () => null,
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -110,11 +79,8 @@ mock.module("../memory/embedding-backend.js", () => ({
   clearEmbeddingBackendCache: () => {},
 }));
 
-let trustClearCacheCallCount = 0;
 mock.module("../permissions/trust-store.js", () => ({
-  clearCache: () => {
-    trustClearCacheCallCount++;
-  },
+  clearCache: () => {},
 }));
 
 mock.module("../providers/registry.js", () => ({
@@ -125,26 +91,10 @@ mock.module("../signals/mcp-reload.js", () => ({
   handleMcpReloadSignal: () => {},
 }));
 
-mock.module("../signals/confirm.js", () => ({
-  handleConfirmationSignal: () => {},
-}));
-
-mock.module("../signals/trust-rule.js", () => ({
-  handleTrustRuleSignal: () => {},
-}));
-
 mock.module("../signals/conversation-undo.js", () => ({
   handleConversationUndoSignal: () => {},
 }));
 
-let resetAllowlistCallCount = 0;
-mock.module("../security/secret-allowlist.js", () => ({
-  resetAllowlist: () => {
-    resetAllowlistCallCount++;
-  },
-  validateAllowlistFile: () => [],
-}));
-
 // Import after mocks are set up
 const { ConfigWatcher } = await import("../daemon/config-watcher.js");
 
@@ -170,11 +120,6 @@ function simulateFileChange(dir: string, filename: string): void {
 
 beforeAll(() => {
   mkdirSync(WORKSPACE_DIR, { recursive: true });
-  mkdirSync(PROTECTED_DIR, { recursive: true });
-});
-
-afterAll(() => {
-  rmSync(TEST_DIR, { recursive: true, force: true });
 });
 
 let watcher: InstanceType<typeof ConfigWatcher>;
@@ -186,8 +131,6 @@ const onConversationEvict = () => {
 beforeEach(() => {
   capturedWatchers.length = 0;
   evictCallCount = 0;
-  trustClearCacheCallCount = 0;
-  resetAllowlistCallCount = 0;
   watcher = new ConfigWatcher();
 });
 
@@ -290,41 +233,11 @@ describe("ConfigWatcher workspace file handlers", () => {
   });
 });
 
-describe("ConfigWatcher protected directory handlers", () => {
-  test("trust.json change calls clearTrustCache", async () => {
-    watcher.start(onConversationEvict);
-    const protectedWatcher = findWatcher(PROTECTED_DIR);
-    expect(protectedWatcher).toBeDefined();
-    protectedWatcher!.callback("change", "trust.json");
-
-    await new Promise((r) => setTimeout(r, 300));
-    // trust.json should NOT trigger conversation eviction
-    expect(evictCallCount).toBe(0);
-    // but clearCache should have been called
-    expect(trustClearCacheCallCount).toBe(1);
-  });
-
-  test("secret-allowlist.json change calls resetAllowlist", async () => {
-    watcher.start(onConversationEvict);
-    const protectedWatcher = findWatcher(PROTECTED_DIR);
-    expect(protectedWatcher).toBeDefined();
-    protectedWatcher!.callback("change", "secret-allowlist.json");
-
-    await new Promise((r) => setTimeout(r, 300));
-    // secret-allowlist.json should NOT trigger conversation eviction
-    expect(evictCallCount).toBe(0);
-    // but resetAllowlist should have been called
-    expect(resetAllowlistCallCount).toBe(1);
-  });
-});
-
 describe("ConfigWatcher watcher lifecycle", () => {
-  test("start registers watchers for workspace and protected dirs", () => {
+  test("start registers workspace and signals watchers", () => {
     watcher.start(onConversationEvict);
     const wsWatcher = findWatcher(WORKSPACE_DIR);
-    const protWatcher = findWatcher(PROTECTED_DIR);
     expect(wsWatcher).toBeDefined();
-    expect(protWatcher).toBeDefined();
   });
 
   test("stop cancels all debounce timers and clears watchers", () => {

package/src/__tests__/confirmation-request-guardian-bridge.test.ts

@@ -8,24 +8,8 @@
  * 4. Missing guardian binding causes a skip
  */
 
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
-const testDir = mkdtempSync(join(tmpdir(), "confirmation-bridge-test-"));
-
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -105,11 +89,6 @@ function resetTables(): void {
 
 afterAll(() => {
   resetDb();
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
 });
 
 // ---------------------------------------------------------------------------

package/src/__tests__/contacts-tools.test.ts

@@ -1,6 +1,3 @@
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import {
   afterAll,
   beforeAll,
@@ -11,22 +8,9 @@ import {
   test,
 } from "bun:test";
 
-const testDir = mkdtempSync(join(tmpdir(), "contacts-tools-test-"));
-
 // Track the gateway URL; updated once the test server starts.
 let testGatewayUrl = "http://127.0.0.1:0";
 
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -102,11 +86,6 @@ beforeAll(() => {
 afterAll(() => {
   testServer?.stop(true);
   resetDb();
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
 });
 
 function getRawDb(): Database {

package/src/__tests__/context-memory-e2e.test.ts

@@ -1,6 +1,3 @@
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import {
   afterAll,
   beforeAll,
@@ -26,19 +23,6 @@ import {
 } from "../memory/schema.js";
 import type { Message, Provider } from "../providers/types.js";
 
-const testDir = mkdtempSync(join(tmpdir(), "context-memory-e2e-"));
-
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -178,11 +162,6 @@ describe("Context + Memory E2E regression", () => {
 
   afterAll(() => {
     resetDb();
-    try {
-      rmSync(testDir, { recursive: true });
-    } catch {
-      // best effort cleanup
-    }
   });
 
   test("one-turn flow compacts context, enforces dynamic budget, and recalls relation-linked memory", async () => {

package/src/__tests__/context-window-manager.test.ts

@@ -245,9 +245,10 @@ describe("ContextWindowManager", () => {
   test("serializes file blocks for summary chunks", async () => {
     const prompts: string[] = [];
     const provider = createProvider((messages) => {
-      const textBlock = messages[0]?.content[0];
-      if (textBlock?.type === "text") {
-        prompts.push(textBlock.text);
+      for (const block of messages[0]?.content ?? []) {
+        if (block.type === "text") {
+          prompts.push(block.text);
+        }
       }
       return {
         content: [{ type: "text", text: "## Goals\n- file summarized" }],
@@ -297,6 +298,132 @@ describe("ContextWindowManager", () => {
     expect(combinedPrompts).not.toContain("unknown_block");
   });
 
+  test("passes image blocks to summarizer instead of text metadata", async () => {
+    const receivedBlocks: { type: string; mediaType?: string }[] = [];
+    const provider = createProvider((messages) => {
+      for (const block of messages[0]?.content ?? []) {
+        if (block.type === "image") {
+          receivedBlocks.push({
+            type: "image",
+            mediaType: (block as { source: { media_type: string } }).source
+              .media_type,
+          });
+        } else if (block.type === "text") {
+          receivedBlocks.push({ type: "text" });
+        }
+      }
+      return {
+        content: [
+          {
+            type: "text",
+            text: "## Goals\n- described image: a photo of a cat",
+          },
+        ],
+        model: "mock-model",
+        usage: { inputTokens: 100, outputTokens: 20 },
+        stopReason: "end_turn",
+      };
+    });
+    // Use a large enough maxInputTokens so the image fits in the summarizer
+    // budget after accounting for overhead (system prompt, scaffolding, output).
+    const manager = new ContextWindowManager({
+      provider,
+      systemPrompt: "sys",
+      config: makeConfig({
+        maxInputTokens: 5000,
+        compactThreshold: 0.3,
+        targetBudgetRatio: 0.2,
+      }),
+    });
+    const long = "x".repeat(4000);
+    const history: Message[] = [
+      {
+        role: "user",
+        content: [
+          { type: "text", text: "look at this" },
+          {
+            type: "image",
+            source: {
+              type: "base64",
+              media_type: "image/png",
+              data: "iVBORw0KGgo=",
+            },
+          },
+        ],
+      },
+      message("assistant", `a1 ${long}`),
+      message("user", `u2 ${long}`),
+    ];
+
+    const result = await manager.maybeCompact(history);
+    expect(result.compacted).toBe(true);
+
+    // The summarizer should have received actual image blocks, not text stubs.
+    const imageBlocks = receivedBlocks.filter((b) => b.type === "image");
+    expect(imageBlocks.length).toBe(1);
+    expect(imageBlocks[0].mediaType).toBe("image/png");
+  });
+
+  test("passes tool_result images to summarizer", async () => {
+    const receivedImageCount = { count: 0 };
+    const provider = createProvider((messages) => {
+      for (const block of messages[0]?.content ?? []) {
+        if (block.type === "image") {
+          receivedImageCount.count++;
+        }
+      }
+      return {
+        content: [
+          { type: "text", text: "## Goals\n- summarized tool output images" },
+        ],
+        model: "mock-model",
+        usage: { inputTokens: 100, outputTokens: 20 },
+        stopReason: "end_turn",
+      };
+    });
+    const manager = new ContextWindowManager({
+      provider,
+      systemPrompt: "sys",
+      config: makeConfig({
+        maxInputTokens: 5000,
+        compactThreshold: 0.3,
+        targetBudgetRatio: 0.2,
+      }),
+    });
+    const long = "x".repeat(2000);
+    const history: Message[] = [
+      message("assistant", "let me read that file"),
+      {
+        role: "user",
+        content: [
+          {
+            type: "tool_result",
+            tool_use_id: "tool_1",
+            content: "file contents",
+            contentBlocks: [
+              {
+                type: "image",
+                source: {
+                  type: "base64",
+                  media_type: "image/jpeg",
+                  data: "iVBORw0KGgo=",
+                },
+              },
+            ],
+            is_error: false,
+          } as import("../providers/types.js").ToolResultContent,
+        ],
+      },
+      message("user", `followup ${long}`),
+      message("assistant", `response ${long}`),
+      message("user", `final ${long}`),
+    ];
+
+    const result = await manager.maybeCompact(history);
+    expect(result.compacted).toBe(true);
+    expect(receivedImageCount.count).toBe(1);
+  });
+
   test("counts compacted persisted messages including tool-result user turns", async () => {
     const provider = createProvider(() => ({
       content: [{ type: "text", text: "## Goals\n- compacted summary" }],

package/src/__tests__/conversation-abort-tool-results.test.ts

@@ -12,10 +12,6 @@ mock.module("../util/logger.js", () => ({
     new Proxy({} as Record<string, unknown>, { get: () => () => {} }),
 }));
 
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => "/tmp",
-}));
-
 mock.module("../memory/guardian-action-store.js", () => ({
   getGuardianActionRequest: () => null,
   resolveGuardianActionRequest: () => {},

package/src/__tests__/conversation-agent-loop-overflow.test.ts

@@ -27,10 +27,6 @@ mock.module("../util/logger.js", () => ({
     new Proxy({} as Record<string, unknown>, { get: () => () => {} }),
 }));
 
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => "/tmp",
-}));
-
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     provider: "mock-provider",

package/src/__tests__/conversation-agent-loop.test.ts

@@ -15,10 +15,6 @@ mock.module("../util/logger.js", () => ({
     new Proxy({} as Record<string, unknown>, { get: () => () => {} }),
 }));
 
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => "/tmp",
-}));
-
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     provider: "mock-provider",

package/src/__tests__/conversation-attachments.test.ts

@@ -1,24 +1,6 @@
-import { existsSync, mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
+import { existsSync } from "node:fs";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
-const testDir = mkdtempSync(join(tmpdir(), "session-attach-test-"));
-const workspaceDir = join(testDir, "workspace");
-
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => join(workspaceDir, "data"),
-  getWorkspaceDir: () => workspaceDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-  getRootDir: () => testDir,
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -72,11 +54,6 @@ initializeDb();
 
 afterAll(() => {
   resetDb();
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
 });
 
 function resetTables() {

package/src/__tests__/conversation-attention-store.test.ts

@@ -1,21 +1,5 @@
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
-const testDir = mkdtempSync(join(tmpdir(), "conv-attn-store-test-"));
-
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -84,11 +68,6 @@ function insertAssistantMessage(
 
 afterAll(() => {
   resetDb();
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
 });
 
 describe("conversation-attention-store", () => {

package/src/__tests__/conversation-attention-telegram.test.ts

@@ -1,6 +1,3 @@
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
@@ -9,20 +6,6 @@ mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
 // Test isolation: in-memory SQLite via temp directory
 // ---------------------------------------------------------------------------
 
-const testDir = mkdtempSync(join(tmpdir(), "conv-attn-telegram-test-"));
-
-mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -51,11 +34,6 @@ initializeDb();
 
 afterAll(() => {
   resetDb();
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
 });
 
 // ---------------------------------------------------------------------------

package/src/__tests__/conversation-clear-safety.test.ts

@@ -9,25 +9,8 @@
  * - lifecycle_events contains `conversations_clear_all` audit entry after clear
  */
 
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import { afterAll, describe, expect, mock, test } from "bun:test";
 
-const testDir = mkdtempSync(join(tmpdir(), "conv-clear-safety-test-"));
-
-mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -57,11 +40,6 @@ initializeDb();
 
 afterAll(() => {
   resetDb();
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
 });
 
 /** Build a synthetic AuthContext for testing. */

package/src/__tests__/conversation-confirmation-signals.test.ts

@@ -9,10 +9,7 @@
  * - sendToClient receives state signals (confirmation_state_changed, assistant_activity_state)
  * - "deny" decisions produce 'denied' state, "allow" produces 'approved'
  */
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { afterAll, describe, expect, mock, test } from "bun:test";
+import { describe, expect, mock, test } from "bun:test";
 
 import type {
   AgentEvent,
@@ -22,10 +19,6 @@ import type {
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { Message, ProviderResponse } from "../providers/types.js";
 
-const testDir = mkdtempSync(
-  join(tmpdir(), "session-confirmation-signals-test-"),
-);
-
 // ---------------------------------------------------------------------------
 // Mocks — must precede Conversation import
 // ---------------------------------------------------------------------------
@@ -51,10 +44,6 @@ mock.module("../util/logger.js", () => ({
   getLogger: () => makeLoggerStub(),
 }));
 
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-}));
-
 mock.module("../memory/guardian-action-store.js", () => ({
   getGuardianActionRequest: () => null,
   resolveGuardianActionRequest: () => {},
@@ -253,7 +242,7 @@ function makeConversation(
     "system prompt",
     4096,
     sendToClient ?? (() => {}),
-    testDir,
+    process.env.VELLUM_WORKSPACE_DIR!,
   );
 }
 
@@ -283,14 +272,6 @@ function seedPendingConfirmation(
   });
 }
 
-afterAll(() => {
-  try {
-    rmSync(testDir, { recursive: true, force: true });
-  } catch {
-    /* best effort */
-  }
-});
-
 // ---------------------------------------------------------------------------
 // Tests
 // ---------------------------------------------------------------------------