@vellumai/assistant 0.5.13 → 0.5.14

package/src/__tests__/messaging-send-tool.test.ts

@@ -41,11 +41,70 @@ mock.module("../config/bundled-skills/messaging/tools/shared.js", () => ({
   extractEmail: (a: string) => a.toLowerCase(),
 }));
 
+// ── Cross-post dependency mocks ──
+
+const addMessageMock = mock(
+  async (
+    conversationId: string,
+    role: string,
+    content: string,
+    _metadata?: Record<string, unknown>,
+    _opts?: { skipIndexing?: boolean },
+  ) => ({
+    id: "xpost-msg-1",
+    conversationId,
+    role,
+    content,
+    createdAt: Date.now(),
+  }),
+);
+
+const getConversationMock = mock(
+  (_id: string) => null as { id: string; createdAt: number } | null,
+);
+
+const syncMessageToDiskMock = mock(
+  (
+    _conversationId: string,
+    _messageId: string,
+    _createdAtMs: number,
+  ) => {},
+);
+
+const getBindingByChannelChatMock = mock(
+  (_sourceChannel: string, _externalChatId: string) =>
+    null as { conversationId: string; sourceChannel: string; externalChatId: string } | null,
+);
+
+mock.module("../memory/conversation-crud.js", () => ({
+  addMessage: addMessageMock,
+  getConversation: getConversationMock,
+}));
+
+mock.module("../memory/conversation-disk-view.js", () => ({
+  syncMessageToDisk: syncMessageToDiskMock,
+}));
+
+mock.module("../memory/external-conversation-store.js", () => ({
+  getBindingByChannelChat: getBindingByChannelChatMock,
+}));
+
+mock.module("../util/logger.js", () => ({
+  getLogger: () =>
+    new Proxy({} as Record<string, unknown>, {
+      get: () => () => {},
+    }),
+}));
+
 import { run } from "../config/bundled-skills/messaging/tools/messaging-send.js";
 
 describe("messaging-send tool", () => {
   beforeEach(() => {
     sendMessageMock.mockClear();
+    addMessageMock.mockClear();
+    getConversationMock.mockClear();
+    syncMessageToDiskMock.mockClear();
+    getBindingByChannelChatMock.mockClear();
   });
 
   test("passes assistantId from tool context to provider send options", async () => {
@@ -106,4 +165,146 @@ describe("messaging-send tool", () => {
       },
     );
   });
+
+  test("cross-posts outbound message to bound conversation", async () => {
+    getBindingByChannelChatMock.mockImplementation(() => ({
+      conversationId: "bound-conv-99",
+      sourceChannel: "phone",
+      externalChatId: "+15550004444",
+    }));
+    getConversationMock.mockImplementation(() => ({
+      id: "bound-conv-99",
+      createdAt: 1700000000000,
+    }));
+
+    const result = await run(
+      {
+        platform: "phone",
+        conversation_id: "+15550004444",
+        text: "hello from A",
+      },
+      {
+        workingDir: "/tmp",
+        conversationId: "conv-A",
+        assistantId: "ast-1",
+        trustClass: "guardian" as const,
+      },
+    );
+
+    expect(result.isError).toBe(false);
+    expect(addMessageMock).toHaveBeenCalledWith(
+      "bound-conv-99",
+      "assistant",
+      JSON.stringify([{ type: "text", text: "hello from A" }]),
+      { automated: true, crossPostedFrom: "conv-A" },
+      { skipIndexing: true },
+    );
+    expect(syncMessageToDiskMock).toHaveBeenCalledWith(
+      "bound-conv-99",
+      "xpost-msg-1",
+      1700000000000,
+    );
+  });
+
+  test("does not cross-post when bound conversation is the sender", async () => {
+    getBindingByChannelChatMock.mockImplementation(() => ({
+      conversationId: "conv-A",
+      sourceChannel: "phone",
+      externalChatId: "+15550004444",
+    }));
+
+    await run(
+      {
+        platform: "phone",
+        conversation_id: "+15550004444",
+        text: "hello",
+      },
+      {
+        workingDir: "/tmp",
+        conversationId: "conv-A",
+        assistantId: "ast-1",
+        trustClass: "guardian" as const,
+      },
+    );
+
+    expect(addMessageMock).not.toHaveBeenCalled();
+  });
+
+  test("does not cross-post when no binding exists", async () => {
+    getBindingByChannelChatMock.mockImplementation(() => null);
+
+    await run(
+      {
+        platform: "phone",
+        conversation_id: "+15550004444",
+        text: "hello",
+      },
+      {
+        workingDir: "/tmp",
+        conversationId: "conv-A",
+        assistantId: "ast-1",
+        trustClass: "guardian" as const,
+      },
+    );
+
+    expect(addMessageMock).not.toHaveBeenCalled();
+  });
+
+  test("cross-post failure does not fail the send", async () => {
+    getBindingByChannelChatMock.mockImplementation(() => ({
+      conversationId: "bound-conv-99",
+      sourceChannel: "phone",
+      externalChatId: "+15550004444",
+    }));
+    getConversationMock.mockImplementation(() => ({
+      id: "bound-conv-99",
+      createdAt: 1700000000000,
+    }));
+    addMessageMock.mockImplementation(async () => {
+      throw new Error("DB write failed");
+    });
+
+    const result = await run(
+      {
+        platform: "phone",
+        conversation_id: "+15550004444",
+        text: "hello",
+      },
+      {
+        workingDir: "/tmp",
+        conversationId: "conv-A",
+        assistantId: "ast-1",
+        trustClass: "guardian" as const,
+      },
+    );
+
+    expect(result.isError).toBe(false);
+    expect(result.content).toContain("Message sent");
+  });
+
+  test("does not cross-post when bound conversation no longer exists", async () => {
+    getBindingByChannelChatMock.mockImplementation(() => ({
+      conversationId: "deleted-conv",
+      sourceChannel: "phone",
+      externalChatId: "+15550004444",
+    }));
+    getConversationMock.mockImplementation(() => null);
+
+    await run(
+      {
+        platform: "phone",
+        conversation_id: "+15550004444",
+        text: "hello",
+      },
+      {
+        workingDir: "/tmp",
+        conversationId: "conv-A",
+        assistantId: "ast-1",
+        trustClass: "guardian" as const,
+      },
+    );
+
+    expect(getBindingByChannelChatMock).toHaveBeenCalled();
+    expect(addMessageMock).not.toHaveBeenCalled();
+  });
 });

package/src/__tests__/migration-cross-version-compatibility.test.ts

@@ -58,7 +58,7 @@ const testDbPath = join(testDbDir, "assistant.db");
 const testConfigPath = join(testDir, "config.json");
 
 mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
+  getProtectedDir: () => join(testDir, "protected"),
   getDataDir: () => join(testDir, "data"),
   getWorkspaceDir: () => testDir,
   getWorkspaceConfigPath: () => testConfigPath,
@@ -78,6 +78,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
+mock.module("../permissions/trust-store.js", () => ({
+  getAllRules: () => [],
+  isStarterBundleAccepted: () => false,
+  clearCache: () => {},
+}));
+
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},
@@ -445,7 +451,7 @@ describe("schema version compatibility", () => {
       { schema_version: "3.0" },
     );
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -463,7 +469,7 @@ describe("schema version compatibility", () => {
       schema_version: "5.0-beta",
     });
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const validationResult = validateVBundle(vbundle);
     expect(validationResult.manifest).toBeDefined();
 
@@ -830,7 +836,7 @@ describe("round-trip: export -> validate -> preflight -> import", () => {
     );
 
     // Step 3: Analyze (preflight)
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const report = analyzeImport({
       manifest: validationResult.manifest!,
       pathResolver: resolver,
@@ -899,7 +905,7 @@ describe("partial failure scenarios", () => {
       "I am a file, not a directory",
     );
 
-    const resolver = new DefaultPathResolver(undefined, blockerWorkspace);
+    const resolver = new DefaultPathResolver(blockerWorkspace);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -917,7 +923,7 @@ describe("partial failure scenarios", () => {
   });
 
   test("commitImport with invalid archive returns validation_failed", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: new Uint8Array([0xba, 0xad, 0xf0, 0x0d]),
       pathResolver: resolver,
@@ -1005,7 +1011,7 @@ describe("partial failure scenarios", () => {
     ]);
     const corruptVBundle = gzipSync(tar);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: corruptVBundle,
       pathResolver: resolver,
@@ -1037,7 +1043,7 @@ describe("edge cases", () => {
     expect(result.manifest?.files[0].size).toBe(0);
 
     // Import should also succeed
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const importResult = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -1427,7 +1433,7 @@ describe("diagnostic quality", () => {
   });
 
   test("import commit validation_failed response includes error codes and messages", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: new Uint8Array([0x00]),
       pathResolver: resolver,
@@ -1636,7 +1642,7 @@ describe("builder -> validator consistency", () => {
 
 describe("import analyzer edge cases", () => {
   test("all-unchanged files produce correct summary", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const existingConfig = new Uint8Array(readFileSync(testConfigPath));
 
     const report = analyzeImport({
@@ -1669,7 +1675,6 @@ describe("import analyzer edge cases", () => {
 
   test("all-create scenario (fresh install) produces correct summary", () => {
     const resolver = new DefaultPathResolver(
-      undefined,
       join(testDir, "nonexistent-workspace"),
     );
 
@@ -1701,7 +1706,7 @@ describe("import analyzer edge cases", () => {
   });
 
   test("mixed create/overwrite/unchanged produces accurate counts", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
 
     // db: different from disk -> overwrite
     // config: same as disk -> unchanged
@@ -1734,7 +1739,7 @@ describe("import analyzer edge cases", () => {
   });
 
   test("unknown archive path produces UNKNOWN_ARCHIVE_PATH conflict", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
 
     const report = analyzeImport({
       manifest: {

package/src/__tests__/migration-export-http.test.ts

@@ -32,7 +32,7 @@ const testDbPath = join(testDbDir, "assistant.db");
 const testConfigPath = join(testDir, "config.json");
 
 mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
+  getProtectedDir: () => join(testDir, "protected"),
   getDataDir: () => join(testDir, "data"),
   getWorkspaceDir: () => testDir,
   getWorkspaceConfigPath: () => testConfigPath,
@@ -52,6 +52,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
+mock.module("../permissions/trust-store.js", () => ({
+  getAllRules: () => [],
+  isStarterBundleAccepted: () => false,
+  clearCache: () => {},
+}));
+
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},

package/src/__tests__/migration-import-commit-http.test.ts

@@ -53,7 +53,7 @@ const testDbPath = join(testDbDir, "assistant.db");
 const testConfigPath = join(testDir, "config.json");
 
 mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
+  getProtectedDir: () => join(testDir, "protected"),
   getDataDir: () => join(testDir, "data"),
   getWorkspaceDir: () => testDir,
   getWorkspaceConfigPath: () => testConfigPath,
@@ -73,6 +73,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
+mock.module("../permissions/trust-store.js", () => ({
+  getAllRules: () => [],
+  isStarterBundleAccepted: () => false,
+  clearCache: () => {},
+}));
+
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},
@@ -639,7 +645,7 @@ describe("commitImport", () => {
       { path: "data/db/assistant.db", data: newDbData },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -653,7 +659,7 @@ describe("commitImport", () => {
   });
 
   test("returns validation_failed for invalid bundles", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: new Uint8Array([0xba, 0xad]),
       pathResolver: resolver,
@@ -683,7 +689,7 @@ describe("commitImport", () => {
       { path: "data/db/assistant.db", data: dbData },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, nonexistentWorkspace);
+    const resolver = new DefaultPathResolver(nonexistentWorkspace);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -707,7 +713,7 @@ describe("commitImport", () => {
       { path: "data/db/assistant.db", data: newDbData },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -737,7 +743,7 @@ describe("commitImport", () => {
       { path: "config/settings.json", data: newConfigData },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -785,7 +791,7 @@ describe("commitImport — workspace clearing", () => {
       { path: "workspace/skills/new-skill/SKILL.md", data: skillData },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -814,7 +820,7 @@ describe("commitImport — workspace clearing", () => {
       { path: "skills/new-skill/SKILL.md", data: skillData },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -841,11 +847,7 @@ describe("commitImport — workspace clearing", () => {
       { path: "hooks/new-hook/hook.sh", data: hookData },
     ]);
 
-    const resolver = new DefaultPathResolver(
-      undefined,
-      testDir,
-      externalHooksDir,
-    );
+    const resolver = new DefaultPathResolver(testDir, externalHooksDir);
     const result = commitImport({
       archiveData: vbundle,
       pathResolver: resolver,
@@ -881,7 +883,7 @@ describe("commitImport — workspace clearing", () => {
       },
     ]);
 
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     // No workspaceDir — no clearing
     const result = commitImport({
       archiveData: vbundle,

package/src/__tests__/migration-import-preflight-http.test.ts

@@ -39,7 +39,7 @@ const testDbPath = join(testDbDir, "assistant.db");
 const testConfigPath = join(testDir, "config.json");
 
 mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
+  getProtectedDir: () => join(testDir, "protected"),
   getDataDir: () => join(testDir, "data"),
   getWorkspaceDir: () => testDir,
   getWorkspaceConfigPath: () => testConfigPath,
@@ -59,6 +59,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
+mock.module("../permissions/trust-store.js", () => ({
+  getAllRules: () => [],
+  isStarterBundleAccepted: () => false,
+  clearCache: () => {},
+}));
+
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},
@@ -525,7 +531,6 @@ describe("handleMigrationImportPreflight — validation failures", () => {
 describe("analyzeImport", () => {
   test("detects create when file does not exist on disk", () => {
     const resolver = new DefaultPathResolver(
-      undefined,
       join(testDir, "nonexistent-workspace"),
     );
 
@@ -553,7 +558,7 @@ describe("analyzeImport", () => {
   });
 
   test("detects unchanged when file on disk matches bundle", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
 
     const report = analyzeImport({
       manifest: {
@@ -577,7 +582,7 @@ describe("analyzeImport", () => {
   });
 
   test("detects overwrite when file on disk differs from bundle", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
 
     const report = analyzeImport({
       manifest: {
@@ -602,7 +607,7 @@ describe("analyzeImport", () => {
   });
 
   test("flags unknown archive paths as conflicts with skip action", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
 
     const report = analyzeImport({
       manifest: {
@@ -640,7 +645,7 @@ describe("analyzeImport", () => {
   });
 
   test("includes manifest in report", () => {
-    const resolver = new DefaultPathResolver(undefined, testDir);
+    const resolver = new DefaultPathResolver(testDir);
     const manifest = {
       schema_version: "1.0",
       created_at: "2024-01-01T00:00:00.000Z",
@@ -667,82 +672,60 @@ describe("analyzeImport", () => {
 // DefaultPathResolver unit tests
 // ---------------------------------------------------------------------------
 
+const WORKSPACE_DIR = "/home/user/.vellum/workspace";
+
 describe("DefaultPathResolver", () => {
   test("resolves data/db/assistant.db to workspace db path (backward compat)", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("data/db/assistant.db")).toBe(
-      "/home/user/.vellum/workspace/data/db/assistant.db",
+      `${WORKSPACE_DIR}/data/db/assistant.db`,
     );
   });
 
   test("resolves config/settings.json to workspace config path (backward compat)", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("config/settings.json")).toBe(
-      "/home/user/.vellum/workspace/config.json",
+      `${WORKSPACE_DIR}/config.json`,
     );
   });
 
   test("returns null for unknown paths", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("unknown/path.txt")).toBeNull();
   });
 
   test("resolves valid skills path via backward compat", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("skills/my-skill/SKILL.md")).toBe(
-      "/home/user/.vellum/workspace/skills/my-skill/SKILL.md",
+      `${WORKSPACE_DIR}/skills/my-skill/SKILL.md`,
     );
   });
 
   test("resolves workspace/ prefix paths", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("workspace/data/db/assistant.db")).toBe(
-      "/home/user/.vellum/workspace/data/db/assistant.db",
+      `${WORKSPACE_DIR}/data/db/assistant.db`,
     );
     expect(resolver.resolve("workspace/config.json")).toBe(
-      "/home/user/.vellum/workspace/config.json",
+      `${WORKSPACE_DIR}/config.json`,
     );
     expect(resolver.resolve("workspace/skills/my-skill/SKILL.md")).toBe(
-      "/home/user/.vellum/workspace/skills/my-skill/SKILL.md",
+      `${WORKSPACE_DIR}/skills/my-skill/SKILL.md`,
     );
   });
 
   test("returns null for workspace/ path traversal attempt", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("workspace/../../etc/passwd")).toBeNull();
   });
 
   test("returns null for skills path traversal attempt (../../etc/passwd)", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("skills/../../etc/passwd")).toBeNull();
   });
 
   test("returns null for skills path traversal attempt (../../../.ssh/authorized_keys)", () => {
-    const resolver = new DefaultPathResolver(
-      undefined,
-      "/home/user/.vellum/workspace",
-    );
+    const resolver = new DefaultPathResolver(WORKSPACE_DIR);
     expect(resolver.resolve("skills/../../../.ssh/authorized_keys")).toBeNull();
   });
 

package/src/__tests__/migration-validate-http.test.ts

@@ -9,11 +9,8 @@
  * - Integration: existing routes are unaffected by the new endpoint
  */
 import { createHash } from "node:crypto";
-import { mkdtempSync, realpathSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import { gzipSync } from "node:zlib";
-import { afterAll, describe, expect, mock, test } from "bun:test";
+import { describe, expect, mock, test } from "bun:test";
 
 /** Convert a Uint8Array to an ArrayBuffer for BodyInit compatibility. */
 function toArrayBuffer(data: Uint8Array): ArrayBuffer {
@@ -24,22 +21,6 @@ function toArrayBuffer(data: Uint8Array): ArrayBuffer {
   ) as ArrayBuffer;
 }
 
-const testDir = realpathSync(
-  mkdtempSync(join(tmpdir(), "migration-validate-http-test-")),
-);
-
-mock.module("../util/platform.js", () => ({
-  getRootDir: () => testDir,
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -73,14 +54,6 @@ mock.module("../config/env.js", () => ({
 import { validateVBundle } from "../runtime/migrations/vbundle-validator.js";
 import { handleMigrationValidate } from "../runtime/routes/migration-routes.js";
 
-afterAll(() => {
-  try {
-    rmSync(testDir, { recursive: true });
-  } catch {
-    /* best effort */
-  }
-});
-
 // ---------------------------------------------------------------------------
 // Tar archive builder helpers
 // ---------------------------------------------------------------------------