@vellumai/assistant 0.5.1 → 0.5.3

package/src/daemon/tool-side-effects.ts

@@ -7,11 +7,9 @@
  * registry entry instead of another if/else branch.
  */
 
-import { join } from "node:path";
-
 import { compileApp } from "../bundler/app-compiler.js";
 import { generateAppIcon } from "../media/app-icon-generator.js";
-import { getApp, getAppsDir, isMultifileApp } from "../memory/app-store.js";
+import { getApp, getAppDirPath, isMultifileApp } from "../memory/app-store.js";
 import { deliverVerificationSlack } from "../runtime/verification-outbound-actions.js";
 import { updatePublishedAppDeployment } from "../services/published-app-updater.js";
 import type { ToolExecutionResult } from "../tools/types.js";
@@ -51,7 +49,7 @@ function handleAppChange(
   // Multifile apps need a recompile before refreshing surfaces so the
   // WebView picks up the latest compiled output.
   if (app && isMultifileApp(app)) {
-    const appDir = join(getAppsDir(), appId);
+    const appDir = getAppDirPath(appId);
     void compileApp(appDir)
       .then((result) => {
         if (!result.ok) {
@@ -147,25 +145,25 @@ registerHook(
   },
 );
 
-// Auto-refresh workspace surfaces when a persisted app is updated.
+// Broadcast app_files_changed when an app is deleted so clients remove it
+// from their cached app lists.
 registerHook(
-  "app_update",
-  (_name, input, _result, { ctx, broadcastToAllClients }) => {
+  "app_delete",
+  (_name, input, _result, { broadcastToAllClients }) => {
     const appId = input.app_id as string | undefined;
     if (appId) {
-      handleAppChange(ctx, appId, broadcastToAllClients);
+      broadcastToAllClients?.({ type: "app_files_changed", appId });
     }
   },
 );
 
-// Broadcast app_files_changed when an app is deleted so clients remove it
-// from their cached app lists.
+// Trigger compilation + surface refresh + broadcast when an app is refreshed.
 registerHook(
-  "app_delete",
-  (_name, input, _result, { broadcastToAllClients }) => {
+  "app_refresh",
+  (_name, input, _result, { ctx, broadcastToAllClients }) => {
     const appId = input.app_id as string | undefined;
     if (appId) {
-      broadcastToAllClients?.({ type: "app_files_changed", appId });
+      handleAppChange(ctx, appId, broadcastToAllClients, { fileChange: true });
     }
   },
 );
@@ -179,21 +177,6 @@ registerHook(
   },
 );
 
-// Auto-refresh workspace surfaces when app files are edited.
-registerHook(
-  ["app_file_edit", "app_file_write"],
-  (_name, input, _result, { ctx, broadcastToAllClients }) => {
-    const appId = input.app_id as string | undefined;
-    const status = input.status as string | undefined;
-    if (appId) {
-      handleAppChange(ctx, appId, broadcastToAllClients, {
-        fileChange: true,
-        status,
-      });
-    }
-  },
-);
-
 // Broadcast voice config changes to all connected clients so every window
 // picks up the updated UserDefaults value immediately.
 registerHook(

package/src/events/tool-permission-telemetry-listener.ts

@@ -30,9 +30,7 @@ export function registerToolPermissionTelemetryListener(
           const key = requestId ? `${requestId}:${toolName}` : undefined;
           if (key && promptedToolCalls.has(key)) {
             promptedToolCalls.delete(key);
-            recordLifecycleEvent(
-              `permission_decided:${toolName}:${decision}`,
-            );
+            recordLifecycleEvent(`permission_decided:${toolName}:${decision}`);
           }
           return;
         }

package/src/followups/followup-store.ts

@@ -1,4 +1,4 @@
-import { and, eq, lte, or } from "drizzle-orm";
+import { and, desc, eq, lte, or } from "drizzle-orm";
 import { v4 as uuid } from "uuid";
 
 import { getDb } from "../memory/db.js";
@@ -176,3 +176,49 @@ export function markNudged(id: string): FollowUp {
 
   return getFollowUp(id)!;
 }
+
+// ── Brief Helpers ──────────────────────────────────────────────────────
+
+/**
+ * Lightweight projection of a follow-up used by the brief compiler.
+ */
+export interface BriefFollowUp {
+  id: string;
+  channel: string;
+  conversationId: string;
+  contactId: string | null;
+  expectedResponseBy: number | null;
+  status: FollowUpStatus;
+  updatedAt: number;
+}
+
+/**
+ * Return pending and overdue follow-ups for the brief compiler.
+ * Ordered by expectedResponseBy ascending (most urgent first).
+ */
+export function getPendingAndOverdueFollowUps(): BriefFollowUp[] {
+  const db = getDb();
+
+  const rows = db
+    .select({
+      id: followups.id,
+      channel: followups.channel,
+      conversationId: followups.conversationId,
+      contactId: followups.contactId,
+      expectedResponseBy: followups.expectedResponseBy,
+      status: followups.status,
+      updatedAt: followups.updatedAt,
+    })
+    .from(followups)
+    .where(
+      or(
+        eq(followups.status, "pending"),
+        eq(followups.status, "overdue"),
+        eq(followups.status, "nudged"),
+      ),
+    )
+    .orderBy(desc(followups.expectedResponseBy))
+    .all();
+
+  return rows as BriefFollowUp[];
+}

package/src/instrument.ts

@@ -121,7 +121,6 @@ export function setSentryOrganizationId(
 const CONVERSATION_TAG_KEYS = [
   "assistant_id",
   "conversation_id",
-  "session_id",
   "message_count",
   "user_identifier",
 ] as const;
@@ -148,9 +147,6 @@ export function setSentryConversationContext(
 ): void {
   Sentry.setTag("assistant_id", ctx.assistantId);
   Sentry.setTag("conversation_id", ctx.conversationId);
-  // session_id mirrors conversation_id — downstream Sentry dashboards and
-  // alerts may still filter by the legacy tag name.
-  Sentry.setTag("session_id", ctx.conversationId);
   Sentry.setTag("message_count", String(ctx.messageCount));
   if (ctx.userIdentifier) {
     Sentry.setTag("user_identifier", ctx.userIdentifier);

package/src/media/app-icon-generator.ts

@@ -10,7 +10,7 @@ import { existsSync, mkdirSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 
 import { getConfig } from "../config/loader.js";
-import { getAppsDir } from "../memory/app-store.js";
+import { getAppDirPath } from "../memory/app-store.js";
 import {
   buildManagedBaseUrl,
   resolveManagedProxyContext,
@@ -68,7 +68,7 @@ export async function generateAppIcon(
     return;
   }
 
-  const appDir = join(getAppsDir(), appId);
+  const appDir = getAppDirPath(appId);
   const iconPath = join(appDir, "icon.png");
 
   // Don't regenerate if icon already exists

package/src/memory/app-git-service.ts

@@ -3,13 +3,18 @@
  *
  * Initializes a git repository in the apps directory (~/.vellum/apps/) and
  * commits after every app mutation (create, update, delete, file write/edit).
- * Commits are fire-and-forget — they never block the caller.
+ * Commits are fire-and-forget -- they never block the caller.
  *
  * Also exposes query methods (history, diff, file-at-version, restore) for
  * browsing and reverting app version history.
  *
  * Reuses WorkspaceGitService for all git operations (mutex, circuit breaker,
  * lazy init, etc.).
+ *
+ * NOTE: After the 010-app-dir-rename migration, git pathspecs use dirName
+ * (slug) instead of appId (UUID). History queries will only return commits
+ * made after the migration rename. Commits before the migration used UUID-
+ * based paths and are not visible through the current slug-based pathspecs.
  */
 
 import { existsSync, readFileSync, writeFileSync } from "node:fs";
@@ -17,7 +22,7 @@ import { join } from "node:path";
 
 import { getLogger } from "../util/logger.js";
 import { getWorkspaceGitService } from "../workspace/git-service.js";
-import { getAppsDir } from "./app-store.js";
+import { getAppsDir, resolveAppDir } from "./app-store.js";
 
 const log = getLogger("app-git");
 
@@ -38,8 +43,8 @@ export interface AppVersion {
 
 /**
  * Patterns excluded from app version tracking.
- * - *.preview — large base64 preview images
- * - records directories — user data (form submissions), not app code
+ * - *.preview -- large base64 preview images
+ * - records directories -- user data (form submissions), not app code
  */
 const APP_GITIGNORE_RULES = ["*.preview", "*/records/"];
 
@@ -116,7 +121,7 @@ function validateRelativePath(path: string): void {
  * mutation's files get absorbed into WorkspaceGitService's bootstrap
  * commit and the "Create app: ..." commit ends up empty.
  *
- * Safe to call multiple times — ensureInitialized() is idempotent.
+ * Safe to call multiple times -- ensureInitialized() is idempotent.
  * Fire-and-forget: errors are logged but never thrown.
  */
 export async function initAppGit(): Promise<void> {
@@ -189,14 +194,18 @@ export async function commitAppTurnChanges(
 /**
  * Get the commit history for a specific app.
  *
- * Scopes `git log` to files belonging to this app:
- *   {appId}.json, {appId}/index.html, {appId}/pages/*, etc.
+ * Scopes `git log` to files belonging to this app using dirName-based
+ * pathspecs: {dirName}.json, {dirName}/.
+ *
+ * Note: After the 010 migration, only commits made after the rename are
+ * visible. Pre-migration commits used UUID-based paths.
  */
 export async function getAppHistory(
   appId: string,
   limit = 50,
 ): Promise<AppVersion[]> {
   validateAppId(appId);
+  const { dirName } = resolveAppDir(appId);
   const safeLimit = Math.max(1, Math.min(Math.floor(limit) || 50, 500));
   const appsDir = getAppsDir();
   const gitService = getWorkspaceGitService(appsDir);
@@ -207,8 +216,8 @@ export async function getAppHistory(
     `--max-count=${safeLimit}`,
     "--format=%H\t%at\t%s",
     "--",
-    `${appId}.json`,
-    `${appId}/`,
+    `${dirName}.json`,
+    `${dirName}/`,
   ]);
 
   if (!stdout.trim()) return [];
@@ -239,6 +248,7 @@ export async function getAppDiff(
   validateCommitHash(fromCommit);
   if (toCommit) validateCommitHash(toCommit);
 
+  const { dirName } = resolveAppDir(appId);
   const appsDir = getAppsDir();
   const gitService = getWorkspaceGitService(appsDir);
 
@@ -247,8 +257,8 @@ export async function getAppDiff(
     "diff",
     range,
     "--",
-    `${appId}.json`,
-    `${appId}/`,
+    `${dirName}.json`,
+    `${dirName}/`,
   ]);
 
   return stdout;
@@ -266,12 +276,13 @@ export async function getAppFileAtVersion(
   validateRelativePath(path);
   validateCommitHash(commitHash);
 
+  const { dirName } = resolveAppDir(appId);
   const appsDir = getAppsDir();
   const gitService = getWorkspaceGitService(appsDir);
 
   const { stdout } = await gitService.runReadOnlyGit([
     "show",
-    `${commitHash}:${appId}/${path}`,
+    `${commitHash}:${dirName}/${path}`,
   ]);
 
   return stdout;
@@ -294,6 +305,7 @@ export async function restoreAppVersion(
   validateAppId(appId);
   validateCommitHash(commitHash);
 
+  const { dirName } = resolveAppDir(appId);
   const appsDir = getAppsDir();
   const gitService = getWorkspaceGitService(appsDir);
 
@@ -305,14 +317,14 @@ export async function restoreAppVersion(
       commitHash,
       "--no-overlay",
       "--",
-      `${appId}.json`,
-      `${appId}/`,
+      `${dirName}.json`,
+      `${dirName}/`,
     ]);
 
     // Read the app name and refresh updatedAt so the restored app
     // doesn't appear stale in recency ordering.
     let appName = appId;
-    const jsonPath = join(appsDir, `${appId}.json`);
+    const jsonPath = join(appsDir, `${dirName}.json`);
     if (existsSync(jsonPath)) {
       try {
         const raw = readFileSync(jsonPath, "utf-8");
@@ -328,7 +340,7 @@ export async function restoreAppVersion(
     const shortHash = commitHash.substring(0, 7);
 
     // Stage only this app's files and commit atomically within the same mutex lock
-    await exec(["add", "--", `${appId}.json`, `${appId}/`]);
+    await exec(["add", "--", `${dirName}.json`, `${dirName}/`]);
     await exec([
       "commit",
       "-m",