@vellumai/assistant 0.5.1 → 0.5.3

package/src/__tests__/app-executors.test.ts

@@ -11,14 +11,7 @@ mock.module("../bundler/app-compiler.js", () => ({
 
 import type { AppDefinition } from "../memory/app-store.js";
 import type { AppStore } from "../tools/apps/executors.js";
-import {
-  executeAppCreate,
-  executeAppFileEdit,
-  executeAppFileList,
-  executeAppFileRead,
-  executeAppFileWrite,
-  resolveAppFilePath,
-} from "../tools/apps/executors.js";
+import { executeAppCreate } from "../tools/apps/executors.js";
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -60,298 +53,15 @@ function mockStore(
   return {
     getApp: (id: string) => (id === app.id ? app : null),
     listApps: () => [app],
-    queryAppRecords: () => [],
-    listAppFiles: () => Object.keys(files).sort(),
-    readAppFile: (_appId: string, path: string) => {
-      if (!(path in files)) throw new Error(`File not found: ${path}`);
-      return files[path];
-    },
     createApp: () => app,
     updateApp: () => app,
     deleteApp: () => {},
     writeAppFile: (_appId: string, path: string, content: string) => {
       files[path] = content;
     },
-    editAppFile: (
-      _appId: string,
-      path: string,
-      oldStr: string,
-      newStr: string,
-      _replaceAll?: boolean,
-    ) => {
-      if (!(path in files)) throw new Error(`File not found: ${path}`);
-      const content = files[path];
-      if (!content.includes(oldStr)) {
-        return { ok: false as const, reason: "not_found" as const };
-      }
-      const updated = content.replace(oldStr, newStr);
-      files[path] = updated;
-      return {
-        ok: true as const,
-        updatedContent: updated,
-        matchCount: 1,
-        matchMethod: "exact" as const,
-        similarity: 1,
-        actualOld: oldStr,
-        actualNew: newStr,
-      };
-    },
   };
 }
 
-// ---------------------------------------------------------------------------
-// resolveAppFilePath
-// ---------------------------------------------------------------------------
-
-describe("resolveAppFilePath", () => {
-  test("prepends src/ for multifile app with plain path", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "main.tsx")).toBe("src/main.tsx");
-  });
-
-  test("prepends src/ for nested path in multifile app", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "components/Header.tsx")).toBe(
-      "src/components/Header.tsx",
-    );
-  });
-
-  test("passes through src/ prefix unchanged for multifile app", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "src/main.tsx")).toBe("src/main.tsx");
-  });
-
-  test("passes through dist/ prefix unchanged for multifile app", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "dist/bundle.js")).toBe("dist/bundle.js");
-  });
-
-  test("passes through records/ prefix unchanged for multifile app", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "records/data.json")).toBe(
-      "records/data.json",
-    );
-  });
-
-  test("does not modify path for legacy app", () => {
-    const app = makeLegacyApp();
-    expect(resolveAppFilePath(app, "main.tsx")).toBe("main.tsx");
-  });
-
-  test("does not modify path for legacy app (formatVersion undefined)", () => {
-    const app = makeLegacyApp({ formatVersion: undefined });
-    expect(resolveAppFilePath(app, "styles.css")).toBe("styles.css");
-  });
-
-  test("does not modify path for legacy app (formatVersion 1)", () => {
-    const app = makeLegacyApp({ formatVersion: 1 });
-    expect(resolveAppFilePath(app, "index.html")).toBe("index.html");
-  });
-
-  test("strips ./ prefix and prepends src/ for multifile app", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "./main.tsx")).toBe("src/main.tsx");
-  });
-
-  test("strips ./ prefix for known top-level dir in multifile app", () => {
-    const app = makeMultifileApp();
-    expect(resolveAppFilePath(app, "./src/main.tsx")).toBe("src/main.tsx");
-    expect(resolveAppFilePath(app, "./dist/bundle.js")).toBe("dist/bundle.js");
-    expect(resolveAppFilePath(app, "./records/data.json")).toBe(
-      "records/data.json",
-    );
-  });
-});
-
-// ---------------------------------------------------------------------------
-// executeAppFileWrite
-// ---------------------------------------------------------------------------
-
-describe("executeAppFileWrite", () => {
-  test("resolves plain path to src/ for multifile app", () => {
-    const files: Record<string, string> = {};
-    const app = makeMultifileApp();
-    const store = mockStore(app, files);
-
-    const result = executeAppFileWrite(
-      { app_id: app.id, path: "main.tsx", content: "export default 1;" },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(JSON.parse(result.content).path).toBe("src/main.tsx");
-    expect(files["src/main.tsx"]).toBe("export default 1;");
-  });
-
-  test("passes through src/ path unchanged for multifile app", () => {
-    const files: Record<string, string> = {};
-    const app = makeMultifileApp();
-    const store = mockStore(app, files);
-
-    const result = executeAppFileWrite(
-      { app_id: app.id, path: "src/main.tsx", content: "export default 2;" },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(JSON.parse(result.content).path).toBe("src/main.tsx");
-    expect(files["src/main.tsx"]).toBe("export default 2;");
-  });
-
-  test("does not modify path for legacy app", () => {
-    const files: Record<string, string> = {};
-    const app = makeLegacyApp();
-    const store = mockStore(app, files);
-
-    const result = executeAppFileWrite(
-      { app_id: app.id, path: "index.html", content: "<html></html>" },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(JSON.parse(result.content).path).toBe("index.html");
-    expect(files["index.html"]).toBe("<html></html>");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// executeAppFileRead
-// ---------------------------------------------------------------------------
-
-describe("executeAppFileRead", () => {
-  test("resolves plain path to src/ for multifile app", () => {
-    const app = makeMultifileApp();
-    const store = mockStore(app, { "src/main.tsx": "line1\nline2" });
-
-    const result = executeAppFileRead(
-      { app_id: app.id, path: "main.tsx" },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(result.content).toContain("line1");
-  });
-
-  test("can read dist/ files explicitly for multifile app", () => {
-    const app = makeMultifileApp();
-    const store = mockStore(app, { "dist/bundle.js": "bundled code" });
-
-    const result = executeAppFileRead(
-      { app_id: app.id, path: "dist/bundle.js" },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(result.content).toContain("bundled code");
-  });
-
-  test("does not modify path for legacy app", () => {
-    const app = makeLegacyApp();
-    const store = mockStore(app, { "index.html": "<html>hello</html>" });
-
-    const result = executeAppFileRead(
-      { app_id: app.id, path: "index.html" },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(result.content).toContain("<html>hello</html>");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// executeAppFileEdit
-// ---------------------------------------------------------------------------
-
-describe("executeAppFileEdit", () => {
-  test("resolves plain path to src/ for multifile app", () => {
-    const files = { "src/main.tsx": "const x = 1;" };
-    const app = makeMultifileApp();
-    const store = mockStore(app, files);
-
-    const result = executeAppFileEdit(
-      {
-        app_id: app.id,
-        path: "main.tsx",
-        old_string: "const x = 1;",
-        new_string: "const x = 2;",
-      },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(files["src/main.tsx"]).toBe("const x = 2;");
-  });
-
-  test("does not modify path for legacy app", () => {
-    const files = { "index.html": "<p>old</p>" };
-    const app = makeLegacyApp();
-    const store = mockStore(app, files);
-
-    const result = executeAppFileEdit(
-      {
-        app_id: app.id,
-        path: "index.html",
-        old_string: "<p>old</p>",
-        new_string: "<p>new</p>",
-      },
-      store,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(files["index.html"]).toBe("<p>new</p>");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// executeAppFileList
-// ---------------------------------------------------------------------------
-
-describe("executeAppFileList", () => {
-  test("returns clean file paths and separate buildOutput for multifile app", () => {
-    const app = makeMultifileApp();
-    const store = mockStore(app, {
-      "src/main.tsx": "",
-      "src/components/Header.tsx": "",
-      "dist/index.html": "",
-    });
-
-    const result = executeAppFileList({ app_id: app.id }, store);
-    const parsed = JSON.parse(result.content) as {
-      files: string[];
-      buildOutput: string[];
-    };
-
-    // File paths must be clean — no annotations appended
-    expect(parsed.files).toContain("src/main.tsx");
-    expect(parsed.files).toContain("src/components/Header.tsx");
-    expect(parsed.files).toContain("dist/index.html");
-    expect(
-      parsed.files.every((f: string) => !f.includes("[build output]")),
-    ).toBe(true);
-
-    // Build output files listed separately
-    expect(parsed.buildOutput).toEqual(["dist/index.html"]);
-  });
-
-  test("does not annotate files for legacy app", () => {
-    const app = makeLegacyApp();
-    const store = mockStore(app, {
-      "index.html": "",
-      "styles.css": "",
-    });
-
-    const result = executeAppFileList({ app_id: app.id }, store);
-    const parsed = JSON.parse(result.content) as string[];
-
-    expect(parsed).toContain("index.html");
-    expect(parsed).toContain("styles.css");
-    expect(parsed.every((f: string) => !f.includes("[build output]"))).toBe(
-      true,
-    );
-  });
-});
-
 // ---------------------------------------------------------------------------
 // executeAppCreate
 // ---------------------------------------------------------------------------

package/src/__tests__/app-git-history.test.ts

@@ -14,7 +14,7 @@ mock.module("../util/platform.js", () => ({
 }));
 
 // Re-import after mocking so modules use our temp dir
-const { createApp, updateApp, getAppsDir } =
+const { createApp, updateApp, getAppDirPath } =
   await import("../memory/app-store.js");
 const {
   getAppHistory,
@@ -147,7 +147,7 @@ describe("App Git History", () => {
 
     // Current file should show new content
     const currentContent = readFileSync(
-      join(getAppsDir(), app.id, "index.html"),
+      join(getAppDirPath(app.id), "index.html"),
       "utf-8",
     );
     expect(currentContent).toContain("version two");
@@ -169,7 +169,7 @@ describe("App Git History", () => {
 
     // Verify current content is "new content"
     let current = readFileSync(
-      join(getAppsDir(), app.id, "index.html"),
+      join(getAppDirPath(app.id), "index.html"),
       "utf-8",
     );
     expect(current).toContain("new content");
@@ -178,7 +178,7 @@ describe("App Git History", () => {
     await restoreAppVersion(app.id, originalHash);
 
     // Verify content is restored
-    current = readFileSync(join(getAppsDir(), app.id, "index.html"), "utf-8");
+    current = readFileSync(join(getAppDirPath(app.id), "index.html"), "utf-8");
     expect(current).toContain("original content");
 
     // Verify a restore commit was created

package/src/__tests__/app-routes-csp.test.ts

@@ -37,6 +37,7 @@ const apps = new Map<string, typeof legacyApp | typeof multifileApp>([
 mock.module("../memory/app-store.js", () => ({
   getApp: (id: string) => apps.get(id) ?? null,
   getAppsDir: () => "/fake/apps",
+  getAppDirPath: (appId: string) => `/fake/apps/${appId}`,
   isMultifileApp: (app: Record<string, unknown>) => app.formatVersion === 2,
 }));