@vellumai/assistant 0.4.49 → 0.4.51

package/src/__tests__/entity-search.test.ts

@@ -1,1117 +0,0 @@
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import {
-  afterAll,
-  beforeAll,
-  beforeEach,
-  describe,
-  expect,
-  mock,
-  test,
-} from "bun:test";
-
-const testDir = mkdtempSync(join(tmpdir(), "entity-search-test-"));
-
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
-}));
-
-mock.module("../util/logger.js", () => ({
-  getLogger: () =>
-    new Proxy({} as Record<string, unknown>, {
-      get: () => () => {},
-    }),
-}));
-
-import { Database } from "bun:sqlite";
-
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
-import {
-  upsertEntity,
-  upsertEntityRelation,
-} from "../memory/entity-extractor.js";
-import { memoryItemEntities, memoryItems } from "../memory/schema.js";
-import {
-  collectTypedNeighbors,
-  findMatchedEntities,
-  findNeighborEntities,
-  getEntityLinkedItemCandidates,
-  intersectReachable,
-} from "../memory/search/entity.js";
-
-function getRawDb(): Database {
-  return (getDb() as unknown as { $client: Database }).$client;
-}
-
-function insertMemoryItem(
-  id: string,
-  opts?: { scopeId?: string; status?: string; invalidAt?: number | null },
-) {
-  const db = getDb();
-  const now = Date.now();
-  db.insert(memoryItems)
-    .values({
-      id,
-      kind: "fact",
-      subject: `Subject ${id}`,
-      statement: `Statement for ${id}`,
-      confidence: 0.9,
-      importance: 0.5,
-      status: opts?.status ?? "active",
-      invalidAt: opts?.invalidAt ?? null,
-      scopeId: opts?.scopeId ?? "default",
-      fingerprint: `fp-${id}`,
-      firstSeenAt: now,
-      lastSeenAt: now,
-      accessCount: 0,
-      lastUsedAt: null,
-      verificationState: "assistant_inferred",
-    })
-    .run();
-}
-
-function linkItemToEntity(memoryItemId: string, entityId: string) {
-  const db = getDb();
-  db.insert(memoryItemEntities).values({ memoryItemId, entityId }).run();
-}
-
-function insertMemoryItemSource(memoryItemId: string, messageId: string) {
-  // Bypass foreign key checks since we don't need actual message rows for these tests
-  const raw = getRawDb();
-  raw.run("PRAGMA foreign_keys = OFF");
-  raw.run(
-    `INSERT INTO memory_item_sources (memory_item_id, message_id, evidence, created_at)
-     VALUES (?, ?, NULL, ?)`,
-    [memoryItemId, messageId, Date.now()],
-  );
-  raw.run("PRAGMA foreign_keys = ON");
-}
-
-describe("entity search", () => {
-  beforeAll(() => {
-    initializeDb();
-  });
-
-  beforeEach(() => {
-    const db = getDb();
-    db.run("DELETE FROM memory_item_sources");
-    db.run("DELETE FROM memory_item_entities");
-    db.run("DELETE FROM memory_entity_relations");
-    db.run("DELETE FROM memory_entities");
-    db.run("DELETE FROM memory_items");
-    db.run("DELETE FROM memory_checkpoints");
-  });
-
-  afterAll(() => {
-    resetDb();
-    try {
-      rmSync(testDir, { recursive: true, force: true });
-    } catch {
-      // best effort cleanup
-    }
-  });
-
-  // ── findNeighborEntities ───────────────────────────────────────────
-
-  describe("findNeighborEntities", () => {
-    test("returns empty for empty seed list", () => {
-      const result = findNeighborEntities([], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 3,
-      });
-      expect(result.neighborEntityIds).toEqual([]);
-      expect(result.traversedEdgeCount).toBe(0);
-    });
-
-    test("returns empty when no edges exist", () => {
-      const entityId = upsertEntity({
-        name: "Lonely",
-        type: "concept",
-        aliases: [],
-      });
-      const result = findNeighborEntities([entityId], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 3,
-      });
-      expect(result.neighborEntityIds).toEqual([]);
-      expect(result.traversedEdgeCount).toBe(0);
-    });
-
-    test("single-hop: seed A has edge to B returns [B]", () => {
-      const a = upsertEntity({ name: "Alpha", type: "project", aliases: [] });
-      const b = upsertEntity({ name: "Beta", type: "tool", aliases: [] });
-
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: b,
-        relation: "uses",
-        evidence: "Alpha uses Beta",
-      });
-
-      const result = findNeighborEntities([a], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 3,
-      });
-      expect(result.neighborEntityIds).toContain(b);
-      expect(result.neighborEntityIds).toHaveLength(1);
-      expect(result.traversedEdgeCount).toBeGreaterThan(0);
-    });
-
-    test("multi-hop: A->B->C with maxDepth=2 returns [B, C]", () => {
-      const a = upsertEntity({ name: "NodeA", type: "concept", aliases: [] });
-      const b = upsertEntity({ name: "NodeB", type: "concept", aliases: [] });
-      const c = upsertEntity({ name: "NodeC", type: "concept", aliases: [] });
-
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: b,
-        relation: "related_to",
-        evidence: null,
-      });
-      upsertEntityRelation({
-        sourceEntityId: b,
-        targetEntityId: c,
-        relation: "related_to",
-        evidence: null,
-      });
-
-      const result = findNeighborEntities([a], {
-        maxEdges: 20,
-        maxNeighborEntities: 10,
-        maxDepth: 2,
-      });
-      expect(result.neighborEntityIds).toContain(b);
-      expect(result.neighborEntityIds).toContain(c);
-      expect(result.neighborEntityIds).toHaveLength(2);
-    });
-
-    test("cycle detection: A->B->A returns [B], does not loop", () => {
-      const a = upsertEntity({ name: "CycleA", type: "person", aliases: [] });
-      const b = upsertEntity({ name: "CycleB", type: "person", aliases: [] });
-
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: b,
-        relation: "collaborates_with",
-        evidence: null,
-      });
-      upsertEntityRelation({
-        sourceEntityId: b,
-        targetEntityId: a,
-        relation: "collaborates_with",
-        evidence: null,
-      });
-
-      const result = findNeighborEntities([a], {
-        maxEdges: 20,
-        maxNeighborEntities: 10,
-        maxDepth: 5,
-      });
-      expect(result.neighborEntityIds).toEqual([b]);
-    });
-
-    test("maxDepth=1 stops after first hop", () => {
-      const a = upsertEntity({ name: "DepthA", type: "concept", aliases: [] });
-      const b = upsertEntity({ name: "DepthB", type: "concept", aliases: [] });
-      const c = upsertEntity({ name: "DepthC", type: "concept", aliases: [] });
-
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: b,
-        relation: "depends_on",
-        evidence: null,
-      });
-      upsertEntityRelation({
-        sourceEntityId: b,
-        targetEntityId: c,
-        relation: "depends_on",
-        evidence: null,
-      });
-
-      const result = findNeighborEntities([a], {
-        maxEdges: 20,
-        maxNeighborEntities: 10,
-        maxDepth: 1,
-      });
-      expect(result.neighborEntityIds).toContain(b);
-      expect(result.neighborEntityIds).not.toContain(c);
-      expect(result.neighborEntityIds).toHaveLength(1);
-    });
-
-    test("maxEdges budget exhaustion stops traversal", () => {
-      const a = upsertEntity({ name: "BudgetA", type: "concept", aliases: [] });
-      const b = upsertEntity({ name: "BudgetB", type: "concept", aliases: [] });
-      const c = upsertEntity({ name: "BudgetC", type: "concept", aliases: [] });
-      const d = upsertEntity({ name: "BudgetD", type: "concept", aliases: [] });
-
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: b,
-        relation: "related_to",
-        evidence: null,
-      });
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: c,
-        relation: "related_to",
-        evidence: null,
-      });
-      upsertEntityRelation({
-        sourceEntityId: b,
-        targetEntityId: d,
-        relation: "related_to",
-        evidence: null,
-      });
-
-      // Allow only 1 edge total, so BFS can't explore much
-      const result = findNeighborEntities([a], {
-        maxEdges: 1,
-        maxNeighborEntities: 10,
-        maxDepth: 3,
-      });
-      expect(result.traversedEdgeCount).toBeLessThanOrEqual(1);
-    });
-
-    test("maxNeighborEntities cap limits result size", () => {
-      const seed = upsertEntity({
-        name: "HubNode",
-        type: "concept",
-        aliases: [],
-      });
-      const neighbors: string[] = [];
-      for (let i = 0; i < 5; i++) {
-        const n = upsertEntity({
-          name: `Spoke${i}`,
-          type: "concept",
-          aliases: [],
-        });
-        neighbors.push(n);
-        upsertEntityRelation({
-          sourceEntityId: seed,
-          targetEntityId: n,
-          relation: "related_to",
-          evidence: null,
-        });
-      }
-
-      const result = findNeighborEntities([seed], {
-        maxEdges: 20,
-        maxNeighborEntities: 2,
-        maxDepth: 3,
-      });
-      expect(result.neighborEntityIds).toHaveLength(2);
-    });
-
-    test("bidirectional: edge from X->A discovers X from seed [A]", () => {
-      const a = upsertEntity({ name: "TargetNode", type: "tool", aliases: [] });
-      const x = upsertEntity({ name: "SourceNode", type: "tool", aliases: [] });
-
-      upsertEntityRelation({
-        sourceEntityId: x,
-        targetEntityId: a,
-        relation: "uses",
-        evidence: null,
-      });
-
-      const result = findNeighborEntities([a], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 3,
-      });
-      expect(result.neighborEntityIds).toContain(x);
-    });
-
-    test("multiple seeds: [A, B] discovers neighbors of both", () => {
-      const a = upsertEntity({ name: "SeedA", type: "project", aliases: [] });
-      const b = upsertEntity({ name: "SeedB", type: "project", aliases: [] });
-      const na = upsertEntity({
-        name: "NeighborOfA",
-        type: "tool",
-        aliases: [],
-      });
-      const nb = upsertEntity({
-        name: "NeighborOfB",
-        type: "tool",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: a,
-        targetEntityId: na,
-        relation: "uses",
-        evidence: null,
-      });
-      upsertEntityRelation({
-        sourceEntityId: b,
-        targetEntityId: nb,
-        relation: "uses",
-        evidence: null,
-      });
-
-      const result = findNeighborEntities([a, b], {
-        maxEdges: 20,
-        maxNeighborEntities: 10,
-        maxDepth: 3,
-      });
-      expect(result.neighborEntityIds).toContain(na);
-      expect(result.neighborEntityIds).toContain(nb);
-    });
-
-    test("relationTypes filter: only follows specified edge types", () => {
-      const idA = upsertEntity({
-        name: "PersonAlpha",
-        type: "person",
-        aliases: [],
-      });
-      const idB = upsertEntity({ name: "ToolBeta", type: "tool", aliases: [] });
-      const idC = upsertEntity({
-        name: "ProjectGamma",
-        type: "project",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: idA,
-        targetEntityId: idB,
-        relation: "uses",
-      });
-      upsertEntityRelation({
-        sourceEntityId: idA,
-        targetEntityId: idC,
-        relation: "works_on",
-      });
-
-      const result = findNeighborEntities([idA], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 1,
-        relationTypes: ["uses"],
-      });
-
-      expect(result.neighborEntityIds).toContain(idB);
-      expect(result.neighborEntityIds).not.toContain(idC);
-    });
-
-    test("relationTypes filter: omitting filter follows all edge types", () => {
-      const idA = upsertEntity({
-        name: "PersonDelta",
-        type: "person",
-        aliases: [],
-      });
-      const idB = upsertEntity({
-        name: "ToolEpsilon",
-        type: "tool",
-        aliases: [],
-      });
-      const idC = upsertEntity({
-        name: "ProjectZeta",
-        type: "project",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: idA,
-        targetEntityId: idB,
-        relation: "uses",
-      });
-      upsertEntityRelation({
-        sourceEntityId: idA,
-        targetEntityId: idC,
-        relation: "works_on",
-      });
-
-      const result = findNeighborEntities([idA], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 1,
-      });
-
-      expect(result.neighborEntityIds).toContain(idB);
-      expect(result.neighborEntityIds).toContain(idC);
-    });
-
-    test("entityTypes filter: only returns entities of specified types", () => {
-      const idPerson = upsertEntity({
-        name: "PersonEta",
-        type: "person",
-        aliases: [],
-      });
-      const idProject = upsertEntity({
-        name: "ProjectTheta",
-        type: "project",
-        aliases: [],
-      });
-      const idTool = upsertEntity({
-        name: "ToolIota",
-        type: "tool",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: idPerson,
-        targetEntityId: idProject,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: idPerson,
-        targetEntityId: idTool,
-        relation: "uses",
-      });
-
-      const result = findNeighborEntities([idPerson], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 1,
-        entityTypes: ["project"],
-      });
-
-      expect(result.neighborEntityIds).toContain(idProject);
-      expect(result.neighborEntityIds).not.toContain(idTool);
-    });
-
-    test("entityTypes filter: omitting filter returns all entity types", () => {
-      const idPerson = upsertEntity({
-        name: "PersonKappa",
-        type: "person",
-        aliases: [],
-      });
-      const idProject = upsertEntity({
-        name: "ProjectLambda",
-        type: "project",
-        aliases: [],
-      });
-      const idTool = upsertEntity({
-        name: "ToolMu",
-        type: "tool",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: idPerson,
-        targetEntityId: idProject,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: idPerson,
-        targetEntityId: idTool,
-        relation: "uses",
-      });
-
-      const result = findNeighborEntities([idPerson], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 1,
-      });
-
-      expect(result.neighborEntityIds).toContain(idProject);
-      expect(result.neighborEntityIds).toContain(idTool);
-    });
-
-    test("neighborDepths tracks BFS depth for each neighbor", () => {
-      // A -> B -> C (chain)
-      const idA = upsertEntity({
-        name: "DepthAlpha",
-        type: "person",
-        aliases: [],
-      });
-      const idB = upsertEntity({
-        name: "DepthBeta",
-        type: "tool",
-        aliases: [],
-      });
-      const idC = upsertEntity({
-        name: "DepthGamma",
-        type: "project",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: idA,
-        targetEntityId: idB,
-        relation: "uses",
-      });
-      upsertEntityRelation({
-        sourceEntityId: idB,
-        targetEntityId: idC,
-        relation: "depends_on",
-      });
-
-      const result = findNeighborEntities([idA], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 2,
-      });
-
-      expect(result.neighborEntityIds).toContain(idB);
-      expect(result.neighborEntityIds).toContain(idC);
-      expect(result.neighborDepths.get(idB)).toBe(1);
-      expect(result.neighborDepths.get(idC)).toBe(2);
-    });
-
-    test("neighborDepths is empty when no neighbors found", () => {
-      const idA = upsertEntity({
-        name: "DepthDelta",
-        type: "person",
-        aliases: [],
-      });
-      const result = findNeighborEntities([idA], {
-        maxEdges: 10,
-        maxNeighborEntities: 10,
-        maxDepth: 1,
-      });
-      expect(result.neighborDepths.size).toBe(0);
-    });
-
-    test("deep chain: maxDepth caps traversal on a long linear chain", () => {
-      // Build a linear chain of 20 entities: N0 -> N1 -> ... -> N19
-      const chain: string[] = [];
-      for (let i = 0; i < 20; i++) {
-        chain.push(
-          upsertEntity({ name: `DeepChain${i}`, type: "concept", aliases: [] }),
-        );
-      }
-      for (let i = 0; i < chain.length - 1; i++) {
-        upsertEntityRelation({
-          sourceEntityId: chain[i],
-          targetEntityId: chain[i + 1],
-          relation: "related_to",
-          evidence: null,
-        });
-      }
-
-      const maxDepth = 3;
-      const result = findNeighborEntities([chain[0]], {
-        maxEdges: 200,
-        maxNeighborEntities: 200,
-        maxDepth,
-      });
-
-      // Should find exactly nodes at depth 1..3 (chain[1], chain[2], chain[3])
-      expect(result.neighborEntityIds).toHaveLength(maxDepth);
-      for (let d = 1; d <= maxDepth; d++) {
-        expect(result.neighborEntityIds).toContain(chain[d]);
-        expect(result.neighborDepths.get(chain[d])).toBe(d);
-      }
-      // Nodes beyond maxDepth should not be reached
-      for (let i = maxDepth + 1; i < chain.length; i++) {
-        expect(result.neighborEntityIds).not.toContain(chain[i]);
-      }
-    });
-
-    test("large cycle: traversal terminates on a fully-connected ring", () => {
-      // Build a ring: N0 -> N1 -> ... -> N9 -> N0
-      const ringSize = 10;
-      const ring: string[] = [];
-      for (let i = 0; i < ringSize; i++) {
-        ring.push(
-          upsertEntity({ name: `Ring${i}`, type: "concept", aliases: [] }),
-        );
-      }
-      for (let i = 0; i < ringSize; i++) {
-        upsertEntityRelation({
-          sourceEntityId: ring[i],
-          targetEntityId: ring[(i + 1) % ringSize],
-          relation: "related_to",
-          evidence: null,
-        });
-      }
-
-      // With maxDepth high enough to go around the ring multiple times if
-      // cycle detection were broken, the visited set must prevent revisiting.
-      const result = findNeighborEntities([ring[0]], {
-        maxEdges: 500,
-        maxNeighborEntities: 500,
-        maxDepth: 20,
-      });
-
-      // Should discover exactly ringSize - 1 neighbors (all except the seed)
-      expect(result.neighborEntityIds).toHaveLength(ringSize - 1);
-      for (let i = 1; i < ringSize; i++) {
-        expect(result.neighborEntityIds).toContain(ring[i]);
-      }
-    });
-
-    test("dense cyclic graph: traversal terminates with multiple cycles and back-edges", () => {
-      // Build a graph where every node connects to multiple others with back-edges
-      const nodes: string[] = [];
-      for (let i = 0; i < 8; i++) {
-        nodes.push(
-          upsertEntity({ name: `Dense${i}`, type: "concept", aliases: [] }),
-        );
-      }
-      // Create a mesh: each node connects to the next 2 nodes (wrapping)
-      for (let i = 0; i < nodes.length; i++) {
-        for (let offset = 1; offset <= 2; offset++) {
-          upsertEntityRelation({
-            sourceEntityId: nodes[i],
-            targetEntityId: nodes[(i + offset) % nodes.length],
-            relation: "related_to",
-            evidence: null,
-          });
-        }
-      }
-
-      const result = findNeighborEntities([nodes[0]], {
-        maxEdges: 500,
-        maxNeighborEntities: 500,
-        maxDepth: 10,
-      });
-
-      // All non-seed nodes should be reachable, and traversal must terminate
-      expect(result.neighborEntityIds).toHaveLength(nodes.length - 1);
-      // No duplicate IDs in the result
-      expect(new Set(result.neighborEntityIds).size).toBe(
-        result.neighborEntityIds.length,
-      );
-    });
-  });
-
-  // ── findMatchedEntities ────────────────────────────────────────────
-
-  describe("findMatchedEntities", () => {
-    test("exact canonical name match", () => {
-      const entityId = upsertEntity({
-        name: "Qdrant",
-        type: "tool",
-        aliases: [],
-      });
-      const results = findMatchedEntities("Qdrant", 10);
-      expect(results.length).toBeGreaterThanOrEqual(1);
-      expect(results.some((r) => r.id === entityId)).toBe(true);
-    });
-
-    test("alias match", () => {
-      const entityId = upsertEntity({
-        name: "Visual Studio Code",
-        type: "tool",
-        aliases: ["vscode", "VS Code"],
-      });
-      const results = findMatchedEntities("vscode", 10);
-      expect(results.length).toBeGreaterThanOrEqual(1);
-      expect(results.some((r) => r.id === entityId)).toBe(true);
-    });
-
-    test("multi-word entity name match (full query)", () => {
-      const entityId = upsertEntity({
-        name: "Visual Studio Code",
-        type: "tool",
-        aliases: [],
-      });
-      const results = findMatchedEntities("Visual Studio Code", 10);
-      expect(results.length).toBeGreaterThanOrEqual(1);
-      expect(results.some((r) => r.id === entityId)).toBe(true);
-    });
-
-    test("tokens < 3 chars are ignored but full query still matches", () => {
-      // "VS" has only 2 chars, so it is filtered as a token.
-      // But the full query "VS" is still matched against entity names and aliases.
-      const entityId = upsertEntity({ name: "VS", type: "tool", aliases: [] });
-      const results = findMatchedEntities("VS", 10);
-      expect(results.length).toBeGreaterThanOrEqual(1);
-      expect(results.some((r) => r.id === entityId)).toBe(true);
-    });
-
-    test("returns empty for no matches", () => {
-      upsertEntity({ name: "Existing", type: "concept", aliases: [] });
-      const results = findMatchedEntities("NonExistentEntity", 10);
-      expect(results).toEqual([]);
-    });
-
-    test("respects maxMatches limit", () => {
-      // Insert entities directly via raw DB to avoid upsertEntity dedup logic.
-      // All share the alias "gadget" so they all match the same query.
-      const raw = getRawDb();
-      const now = Date.now();
-      for (let i = 0; i < 5; i++) {
-        const id = crypto.randomUUID();
-        raw.run(
-          `INSERT INTO memory_entities (id, name, type, aliases, description, first_seen_at, last_seen_at, mention_count)
-           VALUES (?, ?, 'concept', '["gadget"]', NULL, ?, ?, 1)`,
-          [id, `Gadget${i}`, now, now],
-        );
-      }
-
-      const results = findMatchedEntities("gadget", 2);
-      expect(results.length).toBeLessThanOrEqual(2);
-    });
-  });
-
-  // ── getEntityLinkedItemCandidates ──────────────────────────────────
-
-  describe("getEntityLinkedItemCandidates", () => {
-    test("returns items linked to given entity IDs", () => {
-      const entityId = upsertEntity({
-        name: "LinkedEntity",
-        type: "project",
-        aliases: [],
-      });
-      insertMemoryItem("item-linked-1");
-      linkItemToEntity("item-linked-1", entityId);
-
-      const candidates = getEntityLinkedItemCandidates([entityId], {
-        source: "entity_direct",
-      });
-
-      expect(candidates.length).toBe(1);
-      expect(candidates[0].id).toBe("item-linked-1");
-      expect(candidates[0].source).toBe("entity_direct");
-      expect(candidates[0].type).toBe("item");
-    });
-
-    test("excludes items from excluded message IDs", () => {
-      const entityId = upsertEntity({
-        name: "ExcludeEntity",
-        type: "tool",
-        aliases: [],
-      });
-
-      insertMemoryItem("item-excl-1");
-      linkItemToEntity("item-excl-1", entityId);
-      // Source the item from a message we will exclude
-      insertMemoryItemSource("item-excl-1", "msg-to-exclude");
-
-      insertMemoryItem("item-excl-2");
-      linkItemToEntity("item-excl-2", entityId);
-      // Source from a non-excluded message
-      insertMemoryItemSource("item-excl-2", "msg-ok");
-
-      const candidates = getEntityLinkedItemCandidates([entityId], {
-        source: "entity_direct",
-        excludedMessageIds: ["msg-to-exclude"],
-      });
-
-      expect(candidates.some((c) => c.id === "item-excl-1")).toBe(false);
-      expect(candidates.some((c) => c.id === "item-excl-2")).toBe(true);
-    });
-
-    test("returns empty for entity IDs with no linked items", () => {
-      const entityId = upsertEntity({
-        name: "NoItems",
-        type: "concept",
-        aliases: [],
-      });
-
-      const candidates = getEntityLinkedItemCandidates([entityId], {
-        source: "entity_direct",
-      });
-
-      expect(candidates).toEqual([]);
-    });
-  });
-
-  // ── collectTypedNeighbors ────────────────────────────────────────────
-
-  describe("collectTypedNeighbors", () => {
-    test("multi-step: person -> projects -> tools", () => {
-      const person = upsertEntity({
-        name: "StepPerson1",
-        type: "person",
-        aliases: [],
-      });
-      const project1 = upsertEntity({
-        name: "StepProject1",
-        type: "project",
-        aliases: [],
-      });
-      const project2 = upsertEntity({
-        name: "StepProject2",
-        type: "project",
-        aliases: [],
-      });
-      const tool1 = upsertEntity({
-        name: "StepTool1",
-        type: "tool",
-        aliases: [],
-      });
-      const tool2 = upsertEntity({
-        name: "StepTool2",
-        type: "tool",
-        aliases: [],
-      });
-      const tool3 = upsertEntity({
-        name: "StepTool3",
-        type: "tool",
-        aliases: [],
-      });
-
-      // person works_on project1 and project2
-      upsertEntityRelation({
-        sourceEntityId: person,
-        targetEntityId: project1,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: person,
-        targetEntityId: project2,
-        relation: "works_on",
-      });
-      // project1 uses tool1 and tool2
-      upsertEntityRelation({
-        sourceEntityId: project1,
-        targetEntityId: tool1,
-        relation: "uses",
-      });
-      upsertEntityRelation({
-        sourceEntityId: project1,
-        targetEntityId: tool2,
-        relation: "uses",
-      });
-      // project2 uses tool2 and tool3
-      upsertEntityRelation({
-        sourceEntityId: project2,
-        targetEntityId: tool2,
-        relation: "uses",
-      });
-      upsertEntityRelation({
-        sourceEntityId: project2,
-        targetEntityId: tool3,
-        relation: "uses",
-      });
-
-      const result = collectTypedNeighbors(
-        [person],
-        [
-          { relationTypes: ["works_on"], entityTypes: ["project"] },
-          { relationTypes: ["uses"], entityTypes: ["tool"] },
-        ],
-      );
-
-      expect(result).toContain(tool1);
-      expect(result).toContain(tool2);
-      expect(result).toContain(tool3);
-      // Should NOT include person or projects in final result
-      expect(result).not.toContain(person);
-      expect(result).not.toContain(project1);
-      expect(result).not.toContain(project2);
-    });
-
-    test("returns empty for empty seeds", () => {
-      const result = collectTypedNeighbors([], [{ relationTypes: ["uses"] }]);
-      expect(result).toEqual([]);
-    });
-
-    test("returns empty for empty steps", () => {
-      const person = upsertEntity({
-        name: "StepPerson2",
-        type: "person",
-        aliases: [],
-      });
-      const result = collectTypedNeighbors([person], []);
-      expect(result).toEqual([]);
-    });
-
-    test("single step equivalent to filtered BFS", () => {
-      const person = upsertEntity({
-        name: "StepPerson3",
-        type: "person",
-        aliases: [],
-      });
-      const tool = upsertEntity({
-        name: "StepTool4",
-        type: "tool",
-        aliases: [],
-      });
-      const project = upsertEntity({
-        name: "StepProject3",
-        type: "project",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: person,
-        targetEntityId: tool,
-        relation: "uses",
-      });
-      upsertEntityRelation({
-        sourceEntityId: person,
-        targetEntityId: project,
-        relation: "works_on",
-      });
-
-      const result = collectTypedNeighbors(
-        [person],
-        [{ relationTypes: ["uses"], entityTypes: ["tool"] }],
-      );
-
-      expect(result).toContain(tool);
-      expect(result).not.toContain(project);
-    });
-
-    test("chain breaks when intermediate step finds no matches", () => {
-      const person = upsertEntity({
-        name: "StepPerson4",
-        type: "person",
-        aliases: [],
-      });
-      // person has no edges
-      const result = collectTypedNeighbors(
-        [person],
-        [
-          { relationTypes: ["works_on"], entityTypes: ["project"] },
-          { relationTypes: ["uses"], entityTypes: ["tool"] },
-        ],
-      );
-
-      expect(result).toEqual([]);
-    });
-  });
-
-  // ── intersectReachable ───────────────────────────────────────────────
-
-  describe("intersectReachable", () => {
-    test("finds shared projects between two people", () => {
-      const alice = upsertEntity({
-        name: "IntersectAlice",
-        type: "person",
-        aliases: [],
-      });
-      const bob = upsertEntity({
-        name: "IntersectBob",
-        type: "person",
-        aliases: [],
-      });
-      const sharedProject = upsertEntity({
-        name: "IntersectSharedProj",
-        type: "project",
-        aliases: [],
-      });
-      const aliceOnly = upsertEntity({
-        name: "IntersectAliceProj",
-        type: "project",
-        aliases: [],
-      });
-      const bobOnly = upsertEntity({
-        name: "IntersectBobProj",
-        type: "project",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: alice,
-        targetEntityId: sharedProject,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: alice,
-        targetEntityId: aliceOnly,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: bob,
-        targetEntityId: sharedProject,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: bob,
-        targetEntityId: bobOnly,
-        relation: "works_on",
-      });
-
-      const result = intersectReachable([
-        {
-          seedEntityIds: [alice],
-          steps: [{ relationTypes: ["works_on"], entityTypes: ["project"] }],
-        },
-        {
-          seedEntityIds: [bob],
-          steps: [{ relationTypes: ["works_on"], entityTypes: ["project"] }],
-        },
-      ]);
-
-      expect(result).toContain(sharedProject);
-      expect(result).not.toContain(aliceOnly);
-      expect(result).not.toContain(bobOnly);
-    });
-
-    test("returns empty when no overlap", () => {
-      const alice = upsertEntity({
-        name: "IntersectAlice2",
-        type: "person",
-        aliases: [],
-      });
-      const bob = upsertEntity({
-        name: "IntersectBob2",
-        type: "person",
-        aliases: [],
-      });
-      const projA = upsertEntity({
-        name: "IntersectProjA",
-        type: "project",
-        aliases: [],
-      });
-      const projB = upsertEntity({
-        name: "IntersectProjB",
-        type: "project",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: alice,
-        targetEntityId: projA,
-        relation: "works_on",
-      });
-      upsertEntityRelation({
-        sourceEntityId: bob,
-        targetEntityId: projB,
-        relation: "works_on",
-      });
-
-      const result = intersectReachable([
-        {
-          seedEntityIds: [alice],
-          steps: [{ relationTypes: ["works_on"], entityTypes: ["project"] }],
-        },
-        {
-          seedEntityIds: [bob],
-          steps: [{ relationTypes: ["works_on"], entityTypes: ["project"] }],
-        },
-      ]);
-
-      expect(result).toEqual([]);
-    });
-
-    test("single query is equivalent to collectTypedNeighbors", () => {
-      const person = upsertEntity({
-        name: "IntersectSingle",
-        type: "person",
-        aliases: [],
-      });
-      const tool = upsertEntity({
-        name: "IntersectTool",
-        type: "tool",
-        aliases: [],
-      });
-
-      upsertEntityRelation({
-        sourceEntityId: person,
-        targetEntityId: tool,
-        relation: "uses",
-      });
-
-      const result = intersectReachable([
-        {
-          seedEntityIds: [person],
-          steps: [{ relationTypes: ["uses"], entityTypes: ["tool"] }],
-        },
-      ]);
-
-      expect(result).toContain(tool);
-    });
-
-    test("returns empty for empty queries array", () => {
-      const result = intersectReachable([]);
-      expect(result).toEqual([]);
-    });
-  });
-});