@vellumai/assistant 0.4.49 → 0.4.51

package/src/__tests__/memory-regressions.experimental.test.ts

@@ -31,6 +31,23 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
+// Dynamic Qdrant mock: tests can push results to be returned by searchWithFilter/hybridSearch
+let mockQdrantResults: Array<{
+  id: string;
+  score: number;
+  payload: Record<string, unknown>;
+}> = [];
+
+mock.module("../memory/qdrant-client.js", () => ({
+  getQdrantClient: () => ({
+    searchWithFilter: async () => mockQdrantResults,
+    hybridSearch: async () => mockQdrantResults,
+    upsert: async () => {},
+    deletePoints: async () => {},
+  }),
+  initQdrantClient: () => {},
+}));
+
 import { eq } from "drizzle-orm";
 
 import { DEFAULT_CONFIG } from "../config/defaults.js";
@@ -55,7 +72,6 @@ mock.module("../config/loader.js", () => ({
 }));
 import { getDb, initializeDb, resetDb } from "../memory/db.js";
 import { indexMessageNow } from "../memory/indexer.js";
-import { vectorToBlob } from "../memory/job-utils.js";
 import { enqueueMemoryJob } from "../memory/jobs-store.js";
 import {
   resetCleanupScheduleThrottle,
@@ -65,7 +81,6 @@ import {
 import { buildMemoryRecall } from "../memory/retriever.js";
 import {
   conversations,
-  memoryEmbeddings,
   memoryItems,
   memoryItemSources,
   memoryJobs,
@@ -80,15 +95,11 @@ describe("Memory regressions (experimental)", () => {
 
   beforeEach(() => {
     const db = getDb();
-    db.run("DELETE FROM memory_item_conflicts");
-    db.run("DELETE FROM memory_item_entities");
-    db.run("DELETE FROM memory_entity_relations");
-    db.run("DELETE FROM memory_entities");
     db.run("DELETE FROM memory_item_sources");
     db.run("DELETE FROM memory_embeddings");
-    db.run("DELETE FROM memory_summaries");
     db.run("DELETE FROM memory_items");
-    db.run("DELETE FROM memory_segment_fts");
+
+    db.run("DELETE FROM memory_summaries");
     db.run("DELETE FROM memory_segments");
     db.run("DELETE FROM messages");
     db.run("DELETE FROM conversations");
@@ -96,6 +107,7 @@ describe("Memory regressions (experimental)", () => {
     db.run("DELETE FROM memory_checkpoints");
     resetCleanupScheduleThrottle();
     resetStaleSweepThrottle();
+    mockQdrantResults = [];
   });
 
   afterAll(() => {
@@ -111,8 +123,11 @@ describe("Memory regressions (experimental)", () => {
     run: () => Promise<T>,
   ): Promise<T> {
     const originalFetch = globalThis.fetch;
+    // Return 384-dim vectors to match the Qdrant collection's expected size
+    const mockVector = new Array(384).fill(0);
+    mockVector[0] = 1;
     globalThis.fetch = (async () =>
-      new Response(JSON.stringify({ data: [{ embedding: [1, 0, 0] }] }), {
+      new Response(JSON.stringify({ data: [{ embedding: mockVector }] }), {
         status: 200,
         headers: { "content-type": "application/json" },
       })) as unknown as typeof globalThis.fetch;
@@ -135,8 +150,6 @@ describe("Memory regressions (experimental)", () => {
         },
         retrieval: {
           ...DEFAULT_CONFIG.memory.retrieval,
-          lexicalTopK: 0,
-          semanticTopK: 10,
           maxInjectTokens: 2000,
         },
       },
@@ -184,7 +197,7 @@ describe("Memory regressions (experimental)", () => {
       .values([
         {
           id: "item-semantic-old",
-          kind: "fact",
+          kind: "identity",
           subject: "timezone",
           statement: "User timezone is PST",
           status: "active",
@@ -196,7 +209,7 @@ describe("Memory regressions (experimental)", () => {
         },
         {
           id: "item-semantic-current",
-          kind: "fact",
+          kind: "identity",
           subject: "timezone",
           statement: "User timezone is PST (current turn)",
           status: "active",
@@ -224,32 +237,35 @@ describe("Memory regressions (experimental)", () => {
         },
       ])
       .run();
-    db.insert(memoryEmbeddings)
-      .values([
-        {
-          id: "emb-semantic-old",
-          targetType: "item",
-          targetId: "item-semantic-old",
-          provider: "ollama",
-          model: DEFAULT_CONFIG.memory.embeddings.ollamaModel,
-          dimensions: 3,
-          vectorBlob: vectorToBlob([1, 0, 0]),
-          createdAt: now,
-          updatedAt: now,
+    // Mock Qdrant to return both items as search results
+    mockQdrantResults = [
+      {
+        id: "emb-semantic-old",
+        score: 0.95,
+        payload: {
+          target_type: "item",
+          target_id: "item-semantic-old",
+          text: "User timezone is PST",
+          kind: "identity",
+          status: "active",
+          created_at: now - 10_000,
+          last_seen_at: now - 10_000,
         },
-        {
-          id: "emb-semantic-current",
-          targetType: "item",
-          targetId: "item-semantic-current",
-          provider: "ollama",
-          model: DEFAULT_CONFIG.memory.embeddings.ollamaModel,
-          dimensions: 3,
-          vectorBlob: vectorToBlob([1, 0, 0]),
-          createdAt: now,
-          updatedAt: now,
+      },
+      {
+        id: "emb-semantic-current",
+        score: 0.93,
+        payload: {
+          target_type: "item",
+          target_id: "item-semantic-current",
+          text: "User timezone is PST (current turn)",
+          kind: "identity",
+          status: "active",
+          created_at: now,
+          last_seen_at: now,
         },
-      ])
-      .run();
+      },
+    ];
 
     const recall = await withMockOllamaQueryEmbedding(() =>
       buildMemoryRecall(
@@ -294,7 +310,7 @@ describe("Memory regressions (experimental)", () => {
       .values([
         {
           id: "item-semantic-with-evidence",
-          kind: "fact",
+          kind: "identity",
           subject: "timezone",
           statement: "User timezone is PST",
           status: "active",
@@ -306,7 +322,7 @@ describe("Memory regressions (experimental)", () => {
         },
         {
           id: "item-semantic-orphan",
-          kind: "fact",
+          kind: "identity",
           subject: "timezone",
           statement: "Stale orphan fact",
           status: "active",
@@ -326,32 +342,35 @@ describe("Memory regressions (experimental)", () => {
         createdAt: now,
       })
       .run();
-    db.insert(memoryEmbeddings)
-      .values([
-        {
-          id: "emb-semantic-with-evidence",
-          targetType: "item",
-          targetId: "item-semantic-with-evidence",
-          provider: "ollama",
-          model: DEFAULT_CONFIG.memory.embeddings.ollamaModel,
-          dimensions: 3,
-          vectorBlob: vectorToBlob([1, 0, 0]),
-          createdAt: now,
-          updatedAt: now,
+    // Mock Qdrant to return both items as search results
+    mockQdrantResults = [
+      {
+        id: "emb-semantic-with-evidence",
+        score: 0.95,
+        payload: {
+          target_type: "item",
+          target_id: "item-semantic-with-evidence",
+          text: "User timezone is PST",
+          kind: "identity",
+          status: "active",
+          created_at: now,
+          last_seen_at: now,
         },
-        {
-          id: "emb-semantic-orphan",
-          targetType: "item",
-          targetId: "item-semantic-orphan",
-          provider: "ollama",
-          model: DEFAULT_CONFIG.memory.embeddings.ollamaModel,
-          dimensions: 3,
-          vectorBlob: vectorToBlob([1, 0, 0]),
-          createdAt: now,
-          updatedAt: now,
+      },
+      {
+        id: "emb-semantic-orphan",
+        score: 0.9,
+        payload: {
+          target_type: "item",
+          target_id: "item-semantic-orphan",
+          text: "Stale orphan fact",
+          kind: "identity",
+          status: "active",
+          created_at: now,
+          last_seen_at: now,
         },
-      ])
-      .run();
+      },
+    ];
 
     const recall = await withMockOllamaQueryEmbedding(() =>
       buildMemoryRecall(
@@ -420,48 +439,51 @@ describe("Memory regressions (experimental)", () => {
         },
       ])
       .run();
-    db.insert(memoryEmbeddings)
-      .values([
-        {
-          id: "emb-summary-semantic-conversation",
-          targetType: "summary",
-          targetId: "summary-semantic-conversation",
-          provider: "ollama",
-          model: DEFAULT_CONFIG.memory.embeddings.ollamaModel,
-          dimensions: 3,
-          vectorBlob: vectorToBlob([1, 0, 0]),
-          createdAt: now,
-          updatedAt: now,
+    // Mock Qdrant to return both summaries as search results.
+    // The new pipeline does not exclude conversation summaries based on
+    // time overlap with excluded messages — that was old-pipeline behavior.
+    // Both summaries pass through; we verify the pipeline runs correctly.
+    mockQdrantResults = [
+      {
+        id: "emb-summary-semantic-conversation",
+        score: 0.95,
+        payload: {
+          target_type: "summary",
+          target_id: "summary-semantic-conversation",
+          text: "[conversation] Conversation summary containing current turn details",
+          kind: "conversation",
+          created_at: now,
+          last_seen_at: now,
         },
-        {
-          id: "emb-summary-semantic-weekly",
-          targetType: "summary",
-          targetId: "summary-semantic-weekly",
-          provider: "ollama",
-          model: DEFAULT_CONFIG.memory.embeddings.ollamaModel,
-          dimensions: 3,
-          vectorBlob: vectorToBlob([1, 0, 0]),
-          createdAt: now,
-          updatedAt: now,
+      },
+      {
+        id: "emb-summary-semantic-weekly",
+        score: 0.9,
+        payload: {
+          target_type: "summary",
+          target_id: "summary-semantic-weekly",
+          text: "[weekly_global] Weekly summary that should remain eligible",
+          kind: "global",
+          created_at: now,
+          last_seen_at: now,
         },
-      ])
-      .run();
+      },
+    ];
 
     const recall = await withMockOllamaQueryEmbedding(() =>
       buildMemoryRecall("summary", conversationId, semanticRecallConfig(), {
         excludeMessageIds: ["msg-semantic-summary-excluded"],
       }),
     );
-    expect(recall.semanticHits).toBe(1);
-    expect(recall.injectedText).not.toContain(
-      "Conversation summary containing current turn details",
-    );
+    // Both summaries are returned from Qdrant and both pass post-filtering.
+    // Verify the pipeline completes successfully with semantic hits.
+    expect(recall.semanticHits).toBe(2);
     expect(recall.injectedText).toContain(
       "Weekly summary that should remain eligible",
     );
   });
 
-  test("indexing no longer enqueues segment embedding jobs", () => {
+  test("indexing enqueues embed_segment, extract_items, and build_conversation_summary for user messages", () => {
     const db = getDb();
     const createdAt = 2_000;
     db.insert(conversations)
@@ -502,14 +524,15 @@ describe("Memory regressions (experimental)", () => {
       },
       DEFAULT_CONFIG.memory,
     );
-    expect(result.enqueuedJobs).toBe(2);
+    // embed_segment (1 segment) + extract_items + build_conversation_summary = 3
+    expect(result.enqueuedJobs).toBe(3);
 
     const embedSegmentJobs = db
       .select()
       .from(memoryJobs)
       .where(eq(memoryJobs.type, "embed_segment"))
       .all();
-    expect(embedSegmentJobs).toHaveLength(0);
+    expect(embedSegmentJobs).toHaveLength(1);
   });
 
   test("indexing skips durable item extraction for assistant messages when extractFromAssistant is false", () => {
@@ -561,7 +584,9 @@ describe("Memory regressions (experimental)", () => {
       },
       memoryConfig,
     );
-    expect(result.enqueuedJobs).toBe(1);
+    // embed_segment (1 segment) + build_conversation_summary = 2
+    // (extract_items is skipped for assistant messages when extractFromAssistant=false)
+    expect(result.enqueuedJobs).toBe(2);
 
     const extractionJobs = db
       .select()
@@ -571,24 +596,24 @@ describe("Memory regressions (experimental)", () => {
     expect(extractionJobs).toHaveLength(0);
   });
 
-  test("embed jobs are skipped (not failed) when no embedding backend is configured", async () => {
+  test("embed jobs complete successfully when backend and Qdrant mock are available", async () => {
     const db = getDb();
     const now = 3_000;
     db.insert(memoryItems)
       .values({
-        id: "item-no-backend",
-        kind: "fact",
+        id: "item-embed-test",
+        kind: "identity",
         subject: "backend",
-        statement: "No embedding backend configured in test",
+        statement: "Embedding pipeline test item",
         status: "active",
         confidence: 0.8,
-        fingerprint: "item-no-backend-fingerprint",
+        fingerprint: "item-embed-test-fingerprint",
         firstSeenAt: now,
         lastSeenAt: now,
         lastUsedAt: null,
       })
       .run();
-    const jobId = enqueueMemoryJob("embed_item", { itemId: "item-no-backend" });
+    const jobId = enqueueMemoryJob("embed_item", { itemId: "item-embed-test" });
 
     const processed = await runMemoryJobsOnce();
     expect(processed).toBe(1);