@vellumai/assistant 0.4.41 → 0.4.43

package/src/__tests__/{guardian-verification-intent-routing.test.ts → verification-session-intent-routing.test.ts}

@@ -1,6 +1,6 @@
 import { describe, expect, test } from "bun:test";
 
-import { resolveGuardianVerificationIntent } from "../daemon/guardian-verification-intent.js";
+import { resolveVerificationSessionIntent } from "../daemon/verification-session-intent.js";
 
 // =====================================================================
 // 1. Direct guardian setup phrases => forced skill flow
@@ -30,7 +30,7 @@ describe("direct guardian setup phrases trigger forced routing", () => {
 
   for (const phrase of directSetupPhrases) {
     test(`"${phrase}" => direct_setup`, () => {
-      const result = resolveGuardianVerificationIntent(phrase);
+      const result = resolveVerificationSessionIntent(phrase);
       expect(result.kind).toBe("direct_setup");
       if (result.kind === "direct_setup") {
         expect(result.rewrittenContent).toContain("guardian-verify-setup");
@@ -62,7 +62,7 @@ describe("conceptual questions do NOT trigger forced routing", () => {
 
   for (const phrase of conceptualPhrases) {
     test(`"${phrase}" => none`, () => {
-      const result = resolveGuardianVerificationIntent(phrase);
+      const result = resolveVerificationSessionIntent(phrase);
       expect(result.kind).toBe("none");
     });
   }
@@ -88,7 +88,7 @@ describe("non-guardian messages are not intercepted", () => {
 
   for (const phrase of unrelatedPhrases) {
     test(`"${phrase}" => none`, () => {
-      const result = resolveGuardianVerificationIntent(phrase);
+      const result = resolveVerificationSessionIntent(phrase);
       expect(result.kind).toBe("none");
     });
   }
@@ -108,7 +108,7 @@ describe("ambiguous verify phrases without guardian context do NOT trigger force
 
   for (const phrase of ambiguousPhrases) {
     test(`"${phrase}" => none`, () => {
-      const result = resolveGuardianVerificationIntent(phrase);
+      const result = resolveVerificationSessionIntent(phrase);
       expect(result.kind).toBe("none");
     });
   }
@@ -128,7 +128,7 @@ describe("slash commands are never intercepted", () => {
 
   for (const cmd of slashCommands) {
     test(`"${cmd}" => none`, () => {
-      const result = resolveGuardianVerificationIntent(cmd);
+      const result = resolveVerificationSessionIntent(cmd);
       expect(result.kind).toBe("none");
     });
   }
@@ -139,31 +139,31 @@ describe("slash commands are never intercepted", () => {
 // =====================================================================
 
 describe("channel hint extraction", () => {
-  test("SMS phrases still trigger setup but without SMS channel hint", () => {
-    const result = resolveGuardianVerificationIntent(
-      "set me as guardian for SMS",
+  test("unsupported channel keyword triggers setup but yields no channel hint", () => {
+    const result = resolveVerificationSessionIntent(
+      "set me as guardian for text",
     );
     expect(result.kind).toBe("direct_setup");
     if (result.kind === "direct_setup") {
-      // SMS is no longer a supported channel; the intent still matches on
-      // the guardian setup pattern but no channel hint is extracted.
+      // "text" matches the guardian setup pattern but is not a supported
+      // channel, so no channel hint is extracted.
       expect(result.channelHint).toBeUndefined();
     }
   });
 
   test("detects voice channel hint", () => {
-    const result = resolveGuardianVerificationIntent(
+    const result = resolveVerificationSessionIntent(
       "set me as guardian for voice",
     );
     expect(result.kind).toBe("direct_setup");
     if (result.kind === "direct_setup") {
-      expect(result.channelHint).toBe("voice");
-      expect(result.rewrittenContent).toContain("voice channel");
+      expect(result.channelHint).toBe("phone");
+      expect(result.rewrittenContent).toContain("phone channel");
     }
   });
 
   test("detects Telegram channel hint", () => {
-    const result = resolveGuardianVerificationIntent(
+    const result = resolveVerificationSessionIntent(
       "set me as guardian for telegram",
     );
     expect(result.kind).toBe("direct_setup");
@@ -174,7 +174,7 @@ describe("channel hint extraction", () => {
   });
 
   test("no channel hint when unspecified", () => {
-    const result = resolveGuardianVerificationIntent("verify me as guardian");
+    const result = resolveVerificationSessionIntent("verify me as guardian");
     expect(result.kind).toBe("direct_setup");
     if (result.kind === "direct_setup") {
       expect(result.channelHint).toBeUndefined();

package/src/__tests__/view-image-tool.test.ts

@@ -22,8 +22,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({

package/src/__tests__/voice-ingress-preflight.test.ts

@@ -0,0 +1,36 @@
+import { beforeEach, describe, expect, mock, test } from "bun:test";
+
+let mockLoadConfig: () => unknown;
+let mockShouldUsePlatformCallbacks: () => boolean;
+
+mock.module("../config/loader.js", () => ({
+  loadConfig: () => mockLoadConfig(),
+}));
+
+mock.module("../inbound/platform-callback-registration.js", () => ({
+  shouldUsePlatformCallbacks: () => mockShouldUsePlatformCallbacks(),
+}));
+
+import { preflightVoiceIngress } from "../calls/voice-ingress-preflight.js";
+
+describe("voice ingress preflight", () => {
+  beforeEach(() => {
+    mockLoadConfig = () => ({
+      ingress: { enabled: true, publicBaseUrl: "https://example.com" },
+    });
+    mockShouldUsePlatformCallbacks = () => false;
+  });
+
+  test("returns success immediately for platform-callback deployments", async () => {
+    mockShouldUsePlatformCallbacks = () => true;
+    mockLoadConfig = () => ({ ingress: { enabled: false } });
+
+    const result = await preflightVoiceIngress();
+
+    expect(result.ok).toBe(true);
+    if (result.ok) {
+      expect(result.publicBaseUrl).toBe("");
+      expect(result.ingressConfig.ingress?.enabled).toBe(false);
+    }
+  });
+});

package/src/__tests__/voice-invite-redemption.test.ts

@@ -148,7 +148,7 @@ describe("redeemVoiceInviteCode", () => {
     const codeHash = hashVoiceCode(code);
 
     const { invite } = createInvite({
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       maxUses: opts.maxUses ?? 1,
       expiresInMs: opts.expiresInMs,
       expectedExternalUserId: opts.callerPhone ?? "+15551234567",
@@ -165,7 +165,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
@@ -184,14 +184,14 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
     expect(result.ok).toBe(true);
 
     const channelResult = findContactChannel({
-      channelType: "voice",
+      channelType: "phone",
       externalUserId: phone,
     });
 
@@ -206,7 +206,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: "+19999999999",
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
@@ -218,7 +218,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: "+15551234567",
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code: "000000",
     });
 
@@ -231,7 +231,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
@@ -245,7 +245,7 @@ describe("redeemVoiceInviteCode", () => {
     // First redemption succeeds
     const first = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
     expect(first.ok).toBe(true);
@@ -253,7 +253,7 @@ describe("redeemVoiceInviteCode", () => {
     // Second redemption fails — max uses exhausted
     const second = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
     expect(second).toEqual({ ok: false, reason: "invalid_or_expired" });
@@ -267,7 +267,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
@@ -277,7 +277,7 @@ describe("redeemVoiceInviteCode", () => {
   test("voice-only invite cannot be redeemed if sourceChannel on invite is not voice", () => {
     // Create a non-voice invite with voice code metadata to simulate a
     // hypothetical misconfiguration. The redemption service filters by
-    // sourceChannel='voice', so non-voice invites are invisible.
+    // sourceChannel='phone', so non-phone invites are invisible.
     const code = generateVoiceCode(6);
     const codeHash = hashVoiceCode(code);
 
@@ -291,11 +291,11 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: "+15551234567",
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
-    // findActiveVoiceInvites filters by sourceChannel='voice', so the
+    // findActiveVoiceInvites filters by sourceChannel='phone', so the
     // telegram invite won't be found.
     expect(result).toEqual({ ok: false, reason: "invalid_or_expired" });
   });
@@ -306,7 +306,7 @@ describe("redeemVoiceInviteCode", () => {
 
     // Pre-create an active member for this phone on voice channel
     upsertContactChannel({
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       externalUserId: phone,
       status: "active",
       policy: "allow",
@@ -314,7 +314,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
@@ -331,7 +331,7 @@ describe("redeemVoiceInviteCode", () => {
     const { code } = createVoiceInvite({ callerPhone: phone });
 
     upsertContactChannel({
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       externalUserId: phone,
       status: "blocked",
       policy: "deny",
@@ -339,7 +339,7 @@ describe("redeemVoiceInviteCode", () => {
 
     const result = redeemVoiceInviteCode({
       callerExternalUserId: phone,
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code,
     });
 
@@ -349,7 +349,7 @@ describe("redeemVoiceInviteCode", () => {
   test("empty callerExternalUserId fails", () => {
     const result = redeemVoiceInviteCode({
       callerExternalUserId: "",
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       code: "123456",
     });
 

package/src/__tests__/voice-scoped-grant-consumer.test.ts

@@ -109,7 +109,7 @@ import {
   setVoiceBridgeDeps,
   startVoiceTurn,
 } from "../calls/voice-session-bridge.js";
-import type { ServerMessage } from "../daemon/ipc-protocol.js";
+import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { TrustContext } from "../daemon/session-runtime-assembly.js";
 import { getDb, initializeDb, resetDb } from "../memory/db.js";
 import { scopedApprovalGrants } from "../memory/schema.js";
@@ -257,9 +257,9 @@ function grantParams(
     scopeMode: "tool_signature",
     toolName: TOOL_NAME,
     inputDigest: computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT),
-    requestChannel: "voice",
+    requestChannel: "phone",
     decisionChannel: "telegram",
-    executionChannel: "voice",
+    executionChannel: "phone",
     conversationId: CONVERSATION_ID,
     callSessionId: CALL_SESSION_ID,
     expiresAt: futureExpiry,
@@ -285,7 +285,7 @@ describe("voice bridge confirmation handling (grant consumption via primitive)",
     setupBridgeDeps(() => mockData.session);
 
     const trustContext: TrustContext = {
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       trustClass: "trusted_contact",
       requesterExternalUserId: "caller-123",
     };
@@ -329,7 +329,7 @@ describe("voice bridge confirmation handling (grant consumption via primitive)",
     setupBridgeDeps(() => mockData.session);
 
     const trustContext: TrustContext = {
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       trustClass: "trusted_contact",
       requesterExternalUserId: "caller-123",
     };
@@ -367,7 +367,7 @@ describe("voice bridge confirmation handling (grant consumption via primitive)",
     setupBridgeDeps(() => mockData.session);
 
     const trustContext: TrustContext = {
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       trustClass: "trusted_contact",
     };
 
@@ -397,7 +397,7 @@ describe("voice bridge confirmation handling (grant consumption via primitive)",
     setupBridgeDeps(() => mockData.session);
 
     const trustContext: TrustContext = {
-      sourceChannel: "voice",
+      sourceChannel: "phone",
       trustClass: "guardian",
     };
 

package/src/__tests__/voice-session-bridge.test.ts

@@ -3,7 +3,7 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type { ServerMessage } from "../daemon/ipc-protocol.js";
+import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { Session } from "../daemon/session.js";
 
 const testDir = mkdtempSync(join(tmpdir(), "voice-bridge-test-"));
@@ -48,7 +48,7 @@ import {
   setVoiceBridgeDeps,
   startVoiceTurn,
 } from "../calls/voice-session-bridge.js";
-import { createConversation } from "../memory/conversation-store.js";
+import { createConversation } from "../memory/conversation-crud.js";
 import { getDb, initializeDb, resetDb } from "../memory/db.js";
 
 initializeDb();
@@ -323,8 +323,8 @@ describe("voice-session-bridge", () => {
     await new Promise((r) => setTimeout(r, 50));
 
     expect(capturedTurnChannelContext).toEqual({
-      userMessageChannel: "voice",
-      assistantMessageChannel: "voice",
+      userMessageChannel: "phone",
+      assistantMessageChannel: "phone",
     });
   });
 
@@ -358,7 +358,7 @@ describe("voice-session-bridge", () => {
       content: "Hello",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "trusted_contact",
         guardianExternalUserId: "+15550009999",
         guardianChatId: "+15550009999",
@@ -404,9 +404,8 @@ describe("voice-session-bridge", () => {
       content: "Hello",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "unknown",
-        denialReason: "no_binding",
       },
       onTextDelta: () => {},
       onComplete: () => {},
@@ -448,7 +447,7 @@ describe("voice-session-bridge", () => {
       content: "Hello",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "guardian",
         guardianExternalUserId: "+15550001111",
         guardianChatId: "+15550001111",
@@ -483,7 +482,7 @@ describe("voice-session-bridge", () => {
     injectDeps(() => session);
 
     const trustCtx = {
-      sourceChannel: "voice" as const,
+      sourceChannel: "phone" as const,
       trustClass: "guardian" as const,
       guardianExternalUserId: "+15550001111",
       guardianChatId: "+15550001111",
@@ -528,7 +527,7 @@ describe("voice-session-bridge", () => {
       content: "Hello there",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "trusted_contact",
       },
       onTextDelta: () => {},
@@ -588,7 +587,7 @@ describe("voice-session-bridge", () => {
       content: "Hi",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "trusted_contact",
       },
       onTextDelta: () => {},
@@ -676,7 +675,7 @@ describe("voice-session-bridge", () => {
       content: "Delete everything",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "trusted_contact",
         guardianExternalUserId: "+15550009999",
         guardianChatId: "+15550009999",
@@ -749,9 +748,8 @@ describe("voice-session-bridge", () => {
       content: "Make a request",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "unknown",
-        denialReason: "no_binding",
       },
       onTextDelta: () => {},
       onComplete: () => {},
@@ -882,7 +880,7 @@ describe("voice-session-bridge", () => {
       content: "List files",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "guardian",
         guardianExternalUserId: "+15550001111",
         guardianChatId: "+15550001111",
@@ -955,7 +953,7 @@ describe("voice-session-bridge", () => {
       content: "check github status",
       isInbound: true,
       trustContext: {
-        sourceChannel: "voice",
+        sourceChannel: "phone",
         trustClass: "guardian",
         guardianExternalUserId: "+15550001111",
         guardianChatId: "+15550001111",

package/src/__tests__/workspace-policy.test.ts

@@ -258,7 +258,7 @@ describe("isWorkspaceScopedInvocation", () => {
     const safeTools = [
       "skill_load",
       "view_image",
-      "memory_search",
+      "memory_recall",
       "ui_update",
       "ui_dismiss",
     ];

package/src/approvals/AGENTS.md

@@ -2,17 +2,17 @@
 
 ## Approval Flow Resilience
 
-- **Rich delivery failures must degrade gracefully.** If delivering a rich approval prompt (e.g., Telegram inline buttons) fails, fall back to plain text with parser-compatible instructions (e.g., `Reply "yes" to approve`) — never auto-deny.
-- **Non-rich channels** (SMS, http-api) receive plain-text approval prompts without approval metadata payloads.
+- **Rich delivery failures must degrade gracefully.** If delivering a rich approval prompt (e.g., Telegram inline buttons) fails, fall back to plain text with instructions (e.g., `Reply "yes" to approve`) — never auto-deny.
+- **Non-rich channels** (SMS, http-api) receive plain-text approval prompts. The conversational approval engine handles free-text responses.
 - **Race conditions:** Always check whether a decision has already been resolved before delivering the engine's optimistic reply. If `handleChannelDecision` returns `applied: false`, deliver an "already resolved" notice and return `stale_ignored`.
 - **Requester self-cancel:** A requester with a pending guardian approval must be able to cancel their own request (but not self-approve).
-- **Unified guardian decision primitive:** All guardian decision paths (callback buttons, conversational engine, legacy text parser, requester self-cancel) must route through `applyGuardianDecision()` in `assistant/src/approvals/guardian-decision-primitive.ts`. Do not inline decision logic (approve_always downgrade, approval record updates, grant minting) at individual callsites.
+- **Unified guardian decision primitive:** All guardian decision paths (callback buttons, conversational engine, requester self-cancel) must route through `applyGuardianDecision()` in `assistant/src/approvals/guardian-decision-primitive.ts`. Do not inline decision logic (approve_always downgrade, approval record updates, grant minting) at individual callsites.
 
 ## Guardian Verification Invariant
 
 Guardian verification consumption must be identity-bound to the expected recipient identity. Every outbound verification session stores the expected identity (phone E.164, Telegram user/chat ID), and the consume path rejects attempts where the responding actor's identity does not match.
 
-Conversational guardian verification control-plane invocation is guardian-only. Non-guardian and unverified-channel actors cannot invoke guardian verification endpoints (`/v1/integrations/guardian/*`) conversationally via tools. Enforcement is a deterministic gate in the tool execution layer (`assistant/src/tools/executor.ts`) using actor-role context — only `guardian` and `undefined` (desktop/trusted) actor roles pass. The policy module is at `assistant/src/tools/guardian-control-plane-policy.ts`.
+Conversational guardian verification control-plane invocation is guardian-only. Non-guardian and unverified-channel actors cannot invoke channel verification endpoints (`/v1/channel-verification-sessions/*`) conversationally via tools. Enforcement is a deterministic gate in the tool execution layer (`assistant/src/tools/executor.ts`) using actor-role context — only `guardian` and `undefined` (desktop/trusted) actor roles pass. The policy module is at `assistant/src/tools/verification-control-plane-policy.ts`.
 
 ## Memory Provenance Invariant
 

package/src/approvals/approval-primitive.ts

@@ -306,7 +306,7 @@ const GRANT_RETRY_MAX_WAIT_MS = 10_000;
  * polling to handle the voice pipeline race condition where the grant
  * may still be in-flight: `answerCall()` triggers the voice turn as
  * fire-and-forget, and the voice LLM can attempt tool execution before
- * `tryMintGuardianActionGrant`'s LLM fallback finishes minting the
+ * `tryMintGuardianActionGrant`'s classifier finishes minting the
  * grant.  Polling bridges this timing gap without changing the
  * fire-and-forget architecture.
  */
@@ -315,7 +315,7 @@ export async function consumeGrantForInvocation(
   options?: { maxWaitMs?: number; intervalMs?: number; signal?: AbortSignal },
 ): Promise<ConsumeGrantResult> {
   // Fast path: try once synchronously — covers the common case where the
-  // grant already exists (deterministic classifier, or prior turns).
+  // grant already exists.
   const first = consumeGrantSync(params);
   if (first.ok) {
     return first;

package/src/approvals/guardian-decision-primitive.ts

@@ -35,7 +35,7 @@ import {
 import {
   type GuardianApprovalRequest,
   updateApprovalDecision,
-} from "../memory/channel-guardian-store.js";
+} from "../memory/guardian-approvals.js";
 import type {
   ApprovalAction,
   ApprovalDecisionResult,

package/src/approvals/guardian-request-resolvers.ts

@@ -27,7 +27,7 @@ import { addRule } from "../permissions/trust-store.js";
 import { DAEMON_INTERNAL_ASSISTANT_ID } from "../runtime/assistant-scope.js";
 import { mintDaemonDeliveryToken } from "../runtime/auth/token-service.js";
 import type { ApprovalAction } from "../runtime/channel-approval-types.js";
-import { createOutboundSession } from "../runtime/channel-guardian-service.js";
+import { createOutboundSession } from "../runtime/channel-verification-service.js";
 import { deliverChannelReply } from "../runtime/gateway-client.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 import { getTool } from "../tools/registry.js";
@@ -110,7 +110,6 @@ export type ResolverResult =
 function resolveDeliverCallbackUrlForChannel(channel: string): string | null {
   switch (channel) {
     case "telegram":
-    case "sms":
     case "whatsapp":
     case "slack":
       return `${getGatewayInternalBaseUrl()}/deliver/${channel}`;
@@ -457,10 +456,10 @@ const accessRequestResolver: GuardianRequestResolver = {
     // Voice approvals: directly activate the trusted contact without minting
     // a verification session. The caller is already on the line and the
     // relay server's in-call wait loop will detect the approved status.
-    if (channel === "voice") {
+    if (channel === "phone") {
       try {
         upsertContactChannel({
-          sourceChannel: "voice",
+          sourceChannel: "phone",
           externalUserId: requesterExternalUserId,
           externalChatId: requesterChatId,
           status: "active",