@vellumai/assistant 0.4.41 → 0.4.43

package/src/__tests__/ride-shotgun-handler.test.ts

@@ -1,7 +1,6 @@
-import type * as net from "node:net";
 import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type { HandlerContext } from "../daemon/handlers.js";
+import type { HandlerContext } from "../daemon/handlers/shared.js";
 
 // ── Mocks ──────────────────────────────────────────────────────────
 
@@ -101,14 +100,10 @@ const { watchSessions } = await import("../tools/watch/watch-state.js");
 
 // ── Helpers ────────────────────────────────────────────────────────
 
-function makeMockSocket(): net.Socket {
-  return { destroyed: false } as unknown as net.Socket;
-}
-
 function makeMockCtx() {
   const sent: unknown[] = [];
   return {
-    send: (_socket: net.Socket, msg: unknown) => sent.push(msg),
+    send: (msg: unknown) => sent.push(msg),
     sent,
   } as unknown as HandlerContext & { sent: unknown[] };
 }
@@ -157,7 +152,6 @@ describe("ride-shotgun-handler", () => {
   });
 
   test("learn mode calls ensureChromeWithCdp before starting recorder", async () => {
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -169,7 +163,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -188,7 +181,6 @@ describe("ride-shotgun-handler", () => {
       userDataDir: "/tmp/cdp-custom",
     };
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -200,7 +192,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -212,7 +203,6 @@ describe("ride-shotgun-handler", () => {
   test("learn mode does not start recorder when ensureChromeWithCdp fails", async () => {
     mockEnsureChromeShouldThrow = true;
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -224,7 +214,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -241,7 +230,6 @@ describe("ride-shotgun-handler", () => {
       userDataDir: "/tmp/cdp-test",
     };
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -253,7 +241,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -263,7 +250,6 @@ describe("ride-shotgun-handler", () => {
     const watchId = [...watchSessions.keys()][0]!;
     await handleRideShotgunStop(
       { type: "ride_shotgun_stop", watchId },
-      socket,
       ctx,
     );
 
@@ -278,7 +264,6 @@ describe("ride-shotgun-handler", () => {
       userDataDir: "/tmp/cdp-test",
     };
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -290,7 +275,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -300,7 +284,6 @@ describe("ride-shotgun-handler", () => {
     const watchId = [...watchSessions.keys()][0]!;
     await handleRideShotgunStop(
       { type: "ride_shotgun_stop", watchId },
-      socket,
       ctx,
     );
 
@@ -308,7 +291,6 @@ describe("ride-shotgun-handler", () => {
   });
 
   test("observe mode does not call ensureChromeWithCdp", async () => {
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -318,7 +300,6 @@ describe("ride-shotgun-handler", () => {
         intervalSeconds: 5,
         mode: "observe",
       },
-      socket,
       ctx,
     );
 
@@ -332,13 +313,11 @@ describe("ride-shotgun-handler", () => {
     const watchId = [...watchSessions.keys()][0]!;
     await handleRideShotgunStop(
       { type: "ride_shotgun_stop", watchId },
-      socket,
       ctx,
     );
   });
 
   test("sends watch_started message with session IDs", async () => {
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -350,7 +329,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -366,7 +344,6 @@ describe("ride-shotgun-handler", () => {
     const watchId = startMsg.watchId;
     await handleRideShotgunStop(
       { type: "ride_shotgun_stop", watchId },
-      socket,
       ctx,
     );
   });
@@ -374,7 +351,6 @@ describe("ride-shotgun-handler", () => {
   test("sends ride_shotgun_error when ensureChromeWithCdp fails", async () => {
     mockEnsureChromeShouldThrow = true;
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -386,7 +362,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -405,7 +380,6 @@ describe("ride-shotgun-handler", () => {
   test("cleans up session when ensureChromeWithCdp fails", async () => {
     mockEnsureChromeShouldThrow = true;
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -417,7 +391,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -432,7 +405,6 @@ describe("ride-shotgun-handler", () => {
   test("reports failure summary when no recorder ever started", async () => {
     mockEnsureChromeShouldThrow = true;
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -444,7 +416,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 
@@ -465,7 +436,6 @@ describe("ride-shotgun-handler", () => {
     mockRecorderStartShouldThrow = true;
     mockRecorderStartThrowCount = 10;
 
-    const socket = makeMockSocket();
     const ctx = makeMockCtx();
 
     await handleRideShotgunStart(
@@ -477,7 +447,6 @@ describe("ride-shotgun-handler", () => {
         targetDomain: "example.com",
         autoNavigate: false,
       },
-      socket,
       ctx,
     );
 

package/src/__tests__/runtime-attachment-metadata.test.ts

@@ -58,10 +58,10 @@ import {
   linkAttachmentToMessage,
   uploadAttachment,
 } from "../memory/attachments-store.js";
-import * as channelDeliveryStore from "../memory/channel-delivery-store.js";
+import * as conversationStore from "../memory/conversation-crud.js";
 import { getOrCreateConversation } from "../memory/conversation-key-store.js";
-import * as conversationStore from "../memory/conversation-store.js";
 import { getDb, initializeDb, resetDb, resetTestTables } from "../memory/db.js";
+import * as deliveryChannels from "../memory/delivery-channels.js";
 import { RuntimeHttpServer } from "../runtime/http-server.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 
@@ -252,7 +252,7 @@ describe("WhatsApp channel ingress attachment resolution", () => {
       "contact_channels",
       "contacts",
     );
-    channelDeliveryStore.resetAllRunDeliveryClaims();
+    deliveryChannels.resetAllRunDeliveryClaims();
     pendingInteractions.clear();
   }
 

package/src/__tests__/runtime-events-sse-parity.test.ts

@@ -57,7 +57,7 @@ mock.module("../config/loader.js", () => ({
   }),
 }));
 
-import type { ServerMessage } from "../daemon/ipc-protocol.js";
+import type { ServerMessage } from "../daemon/message-protocol.js";
 import { getOrCreateConversation } from "../memory/conversation-key-store.js";
 import { getDb, initializeDb, resetDb } from "../memory/db.js";
 import type { AssistantEvent } from "../runtime/assistant-event.js";

package/src/__tests__/scaffold-managed-skill-tool.test.ts

@@ -147,7 +147,7 @@ describe("scaffold_managed_skill tool", () => {
     // Each frontmatter line must start with a known key -- no injected keys
     for (const line of fmLines) {
       expect(line).toMatch(
-        /^(name|description|emoji|user-invocable|disable-model-invocation):\s/,
+        /^(name|description|emoji|user-invocable|disable-model-invocation|metadata):\s/,
       );
     }
   });
@@ -167,7 +167,7 @@ describe("scaffold_managed_skill tool", () => {
     expect(result.isError).toBe(false);
     const skillFile = join(TEST_DIR, "skills", "parent-skill", "SKILL.md");
     const content = readFileSync(skillFile, "utf-8");
-    expect(content).toContain('includes: ["child-a","child-b"]');
+    expect(content).toContain('"includes":["child-a","child-b"]');
   });
 
   test("normalizes includes — trims and deduplicates", async () => {
@@ -185,7 +185,7 @@ describe("scaffold_managed_skill tool", () => {
     expect(result.isError).toBe(false);
     const skillFile = join(TEST_DIR, "skills", "norm-skill", "SKILL.md");
     const content = readFileSync(skillFile, "utf-8");
-    expect(content).toContain('includes: ["child-a","child-b"]');
+    expect(content).toContain('"includes":["child-a","child-b"]');
   });
 
   test("rejects includes with non-string elements", async () => {
@@ -295,7 +295,7 @@ describe("scaffold_managed_skill tool", () => {
     const parentSkillFile = join(TEST_DIR, "skills", "e2e-parent", "SKILL.md");
     expect(existsSync(parentSkillFile)).toBe(true);
     const parentContent = readFileSync(parentSkillFile, "utf-8");
-    expect(parentContent).toContain('includes: ["e2e-child"]');
+    expect(parentContent).toContain('"includes":["e2e-child"]');
 
     const indexContent = readFileSync(
       join(TEST_DIR, "skills", "SKILLS.md"),

package/src/__tests__/schedule-store.test.ts

@@ -16,8 +16,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -54,9 +52,9 @@ afterAll(() => {
   }
 });
 
-// ── Cron backward compatibility ─────────────────────────────────────
+// ── Cron schedules ──────────────────────────────────────────────────
 
-describe("createSchedule (cron, legacy API)", () => {
+describe("createSchedule (cron)", () => {
   beforeEach(() => {
     const db = getDb();
     db.run("DELETE FROM cron_runs");
@@ -68,6 +66,7 @@ describe("createSchedule (cron, legacy API)", () => {
       name: "Morning ping",
       cronExpression: "0 9 * * *",
       message: "good morning",
+      syntax: "cron",
     });
 
     expect(job.syntax).toBe("cron");
@@ -82,6 +81,7 @@ describe("createSchedule (cron, legacy API)", () => {
       name: "Hourly",
       cronExpression: "0 * * * *",
       message: "hourly check",
+      syntax: "cron",
     });
 
     const retrieved = getSchedule(job.id);
@@ -96,6 +96,7 @@ describe("createSchedule (cron, legacy API)", () => {
       name: "Syntax check",
       cronExpression: "*/5 * * * *",
       message: "test",
+      syntax: "cron",
     });
 
     const raw = getRawDb()
@@ -111,6 +112,7 @@ describe("createSchedule (cron, legacy API)", () => {
         name: "Bad cron",
         cronExpression: "not-a-cron",
         message: "fail",
+        syntax: "cron",
       }),
     ).toThrow();
   });
@@ -341,6 +343,7 @@ describe("updateSchedule", () => {
       name: "Update test",
       cronExpression: "0 9 * * *",
       message: "update me",
+      syntax: "cron",
     });
 
     const updated = updateSchedule(job.id, { cronExpression: "0 10 * * *" });
@@ -357,6 +360,7 @@ describe("updateSchedule", () => {
       name: "Switch to RRULE",
       cronExpression: "0 9 * * *",
       message: "switching",
+      syntax: "cron",
     });
 
     const rrule = "DTSTART:20260101T090000Z\nRRULE:FREQ=DAILY;INTERVAL=2";
@@ -383,6 +387,7 @@ describe("updateSchedule", () => {
       name: "Update to set",
       cronExpression: "0 9 * * *",
       message: "update to set",
+      syntax: "cron",
     });
 
     const setExpr = [
@@ -408,6 +413,7 @@ describe("updateSchedule", () => {
       name: "Reject bad update",
       cronExpression: "0 9 * * *",
       message: "nope",
+      syntax: "cron",
     });
 
     expect(() =>
@@ -433,6 +439,7 @@ describe("claimDueSchedules", () => {
       name: "Claim cron",
       cronExpression: "* * * * *",
       message: "cron claim test",
+      syntax: "cron",
     });
 
     // Force the schedule to be due
@@ -488,6 +495,7 @@ describe("claimDueSchedules", () => {
       name: "Not due yet",
       cronExpression: "0 9 * * *",
       message: "future schedule",
+      syntax: "cron",
     });
 
     const claimed = claimDueSchedules(0); // timestamp 0 means nothing is due
@@ -545,6 +553,7 @@ describe("claimDueSchedules", () => {
       name: "Double claim",
       cronExpression: "* * * * *",
       message: "no double",
+      syntax: "cron",
     });
 
     getRawDb().run("UPDATE cron_jobs SET next_run_at = ? WHERE id = ?", [

package/src/__tests__/schedule-tools.test.ts

@@ -15,8 +15,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({

package/src/__tests__/scheduler-recurrence.test.ts

@@ -15,8 +15,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -272,6 +270,7 @@ describe("scheduler RRULE execution", () => {
       name: "Cron Schedule",
       cronExpression: "* * * * *",
       message: "Cron message",
+      syntax: "cron",
     });
 
     // Verify it defaults to cron syntax
@@ -555,7 +554,7 @@ describe("scheduler RRULE execution", () => {
       routingIntent: "multi_channel",
       routingHints: {
         requestedByUser: true,
-        channelMentions: ["telegram", "sms"],
+        channelMentions: ["telegram", "slack"],
       },
     });
 
@@ -592,7 +591,7 @@ describe("scheduler RRULE execution", () => {
       routingIntent: "multi_channel",
       routingHints: {
         requestedByUser: true,
-        channelMentions: ["telegram", "sms"],
+        channelMentions: ["telegram", "slack"],
       },
     });
     expect(getReminder(reminder.id)?.status).toBe("fired");

package/src/__tests__/scoped-approval-grants.test.ts

@@ -15,8 +15,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -246,7 +244,7 @@ describe("scoped-approval-grants / tool_signature scope", () => {
       toolName: "bash",
       inputDigest: digest,
       consumingRequestId: "c1",
-      executionChannel: "sms",
+      executionChannel: "phone",
     });
     expect(wrong.ok).toBe(false);
 
@@ -275,7 +273,7 @@ describe("scoped-approval-grants / tool_signature scope", () => {
       toolName: "bash",
       inputDigest: digest,
       consumingRequestId: "c1",
-      executionChannel: "sms",
+      executionChannel: "phone",
     });
     expect(result.ok).toBe(true);
   });
@@ -367,7 +365,7 @@ describe("scoped-approval-grants / tool_signature scope", () => {
       toolName: "bash",
       inputDigest: digest,
       consumingRequestId: "c2",
-      executionChannel: "sms",
+      executionChannel: "phone",
     });
     expect(second.ok).toBe(true);
     expect(second.grant!.id).toBe(wildcardGrant.id);

package/src/__tests__/scoped-grant-security-matrix.test.ts

@@ -40,8 +40,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -345,7 +343,7 @@ describe("security matrix: cross-scope invariants", () => {
       grantParams({
         toolName: "bash",
         inputDigest: digest,
-        executionChannel: "voice",
+        executionChannel: "phone",
         conversationId: "conv-123",
         callSessionId: "call-456",
         requesterExternalUserId: "user-alice",
@@ -360,7 +358,7 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-chan",
-        executionChannel: "sms",
+        executionChannel: "telegram",
         conversationId: "conv-123",
         callSessionId: "call-456",
         requesterExternalUserId: "user-alice",
@@ -373,7 +371,7 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-conv",
-        executionChannel: "voice",
+        executionChannel: "phone",
         conversationId: "conv-999",
         callSessionId: "call-456",
         requesterExternalUserId: "user-alice",
@@ -386,7 +384,7 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-call",
-        executionChannel: "voice",
+        executionChannel: "phone",
         conversationId: "conv-123",
         callSessionId: "call-999",
         requesterExternalUserId: "user-alice",
@@ -399,7 +397,7 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-user",
-        executionChannel: "voice",
+        executionChannel: "phone",
         conversationId: "conv-123",
         callSessionId: "call-456",
         requesterExternalUserId: "user-bob",
@@ -412,7 +410,7 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-all",
-        executionChannel: "voice",
+        executionChannel: "phone",
         conversationId: "conv-123",
         callSessionId: "call-456",
         requesterExternalUserId: "user-alice",

package/src/__tests__/secret-prompt-log-hygiene.test.ts

@@ -1,6 +1,6 @@
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type { SecretRequest, ServerMessage } from "../daemon/ipc-contract.js";
+import type { SecretRequest, ServerMessage } from "../daemon/message-protocol.js";
 
 // Capture all logger calls so we can verify secret values never appear
 const logCalls: Array<{ level: string; args: unknown[] }> = [];

package/src/__tests__/secret-response-routing.test.ts

@@ -1,6 +1,6 @@
 import { beforeEach, describe, expect, test } from "bun:test";
 
-import type { SecretRequest, ServerMessage } from "../daemon/ipc-contract.js";
+import type { SecretRequest, ServerMessage } from "../daemon/message-protocol.js";
 import type { SecretPromptResult } from "../permissions/secret-prompter.js";
 import { SecretPrompter } from "../permissions/secret-prompter.js";
 

package/src/__tests__/send-endpoint-busy.test.ts

@@ -14,7 +14,7 @@ import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
 
 import { createGuardianBinding } from "../contacts/contacts-write.js";
-import type { ServerMessage } from "../daemon/ipc-protocol.js";
+import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { Session } from "../daemon/session.js";
 import { createCanonicalGuardianRequest } from "../memory/canonical-guardian-store.js";
 import { getOrCreateConversation } from "../memory/conversation-key-store.js";

package/src/__tests__/sequence-store.test.ts

@@ -16,8 +16,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  migrateToDataLayout: () => {},
-  migrateToWorkspaceLayout: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({