@vellumai/assistant 0.4.33 → 0.4.35

package/src/__tests__/relay-server.test.ts

@@ -282,12 +282,8 @@ function resetTables() {
   ensuredConvIds = new Set();
 }
 
-function addTrustedVoiceContact(
-  phoneNumber: string,
-  assistantId: string = "self",
-): void {
+function addTrustedVoiceContact(phoneNumber: string): void {
   upsertMember({
-    assistantId,
     sourceChannel: "voice",
     externalUserId: phoneNumber,
     externalChatId: phoneNumber,
@@ -297,12 +293,10 @@ function addTrustedVoiceContact(
 }
 
 function createVoiceVerificationSession(
-  assistantId: string,
   expectedPhoneE164: string,
   sessionId?: string,
 ): string {
   const { secret } = createOutboundSession({
-    assistantId,
     channel: "voice",
     expectedExternalUserId: expectedPhoneE164,
     expectedChatId: expectedPhoneE164,
@@ -313,12 +307,10 @@ function createVoiceVerificationSession(
 }
 
 function createPendingVoiceGuardianChallenge(
-  assistantId: string,
   secret: string = "123456",
 ): string {
   createChallenge({
     id: randomUUID(),
-    assistantId,
     channel: "voice",
     challengeHash: createHash("sha256").update(secret).digest("hex"),
     expiresAt: Date.now() + 10 * 60 * 1000,
@@ -1333,12 +1325,11 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559999999",
       toNumber: "+15551111111",
-      assistantId: "self",
       // no task — inbound call
     });
 
     // Create a pending voice guardian challenge
-    const secret = createPendingVoiceGuardianChallenge("self");
+    const secret = createPendingVoiceGuardianChallenge();
 
     mockSendMessage.mockImplementation(
       createMockProviderResponse(["Hello, how can I help you?"]),
@@ -1413,10 +1404,9 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559999999",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
-    const secret = createPendingVoiceGuardianChallenge("self");
+    const secret = createPendingVoiceGuardianChallenge();
 
     mockSendMessage.mockImplementation(
       createMockProviderResponse(["Hello, verified caller!"]),
@@ -1474,11 +1464,9 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15550001111",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     createGuardianBinding({
-      assistantId: "self",
       channel: "voice",
       guardianExternalUserId: "+15550001111",
       guardianDeliveryChatId: "+15550001111",
@@ -1524,18 +1512,16 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15550002222",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     createGuardianBinding({
-      assistantId: "self",
       channel: "voice",
       guardianExternalUserId: "+15550009999",
       guardianDeliveryChatId: "+15550009999",
       guardianPrincipalId: "+15550009999",
       verifiedVia: "test",
     });
-    addTrustedVoiceContact("+15550002222", "self");
+    addTrustedVoiceContact("+15550002222");
 
     mockSendMessage.mockImplementation(
       createMockProviderResponse(["Hello there."]),
@@ -1578,12 +1564,10 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15551111111",
       toNumber: "+15550001111",
-      assistantId: "self",
       initiatedFromConversationId: "conv-guardian-outbound-voice-origin",
     });
 
     createGuardianBinding({
-      assistantId: "self",
       channel: "voice",
       guardianExternalUserId: "+15550001111",
       guardianDeliveryChatId: "+15550001111",
@@ -1630,12 +1614,10 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15551111111",
       toNumber: "+15550001111",
-      assistantId: "self",
       initiatedFromConversationId: "conv-guardian-outbound-strict-origin",
     });
 
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "tg-guardian-user",
       guardianDeliveryChatId: "tg-guardian-chat",
@@ -1682,10 +1664,9 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15550003333",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
-    const secret = createPendingVoiceGuardianChallenge("self");
+    const secret = createPendingVoiceGuardianChallenge();
     const spokenCode = secret.split("").join(" ");
 
     const { relay } = createMockWs(session.id);
@@ -1740,10 +1721,9 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559999999",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
-    createPendingVoiceGuardianChallenge("self");
+    createPendingVoiceGuardianChallenge();
 
     const { ws, relay } = createMockWs(session.id);
 
@@ -1785,10 +1765,9 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559999999",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
-    createPendingVoiceGuardianChallenge("self");
+    createPendingVoiceGuardianChallenge();
 
     const { ws, relay } = createMockWs(session.id);
 
@@ -1851,7 +1830,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559999999",
       toNumber: "+15551111111",
-      assistantId: "self",
       // no task — inbound call
     });
 
@@ -1860,7 +1838,7 @@ describe("relay-server", () => {
     mockSendMessage.mockImplementation(
       createMockProviderResponse(["Welcome to the line."]),
     );
-    addTrustedVoiceContact("+15559999999", "self");
+    addTrustedVoiceContact("+15559999999");
 
     const { ws, relay } = createMockWs(session.id);
 
@@ -1897,10 +1875,9 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559999999",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
-    createPendingVoiceGuardianChallenge("self");
+    createPendingVoiceGuardianChallenge();
 
     const { ws, relay } = createMockWs(session.id);
 
@@ -1952,14 +1929,12 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15551111111",
       toNumber: "+15559999999",
-      assistantId: "self",
       callMode: "guardian_verification",
       guardianVerificationSessionId: "gv-session-ptr-success",
       initiatedFromConversationId: "conv-gv-pointer-success-origin",
     });
 
     const secret = createVoiceVerificationSession(
-      "self",
       "+15559999999",
       "gv-session-ptr-success",
     );
@@ -2009,17 +1984,12 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15551111111",
       toNumber: "+15559999999",
-      assistantId: "self",
       callMode: "guardian_verification",
       guardianVerificationSessionId: "gv-session-ptr-fail",
       initiatedFromConversationId: "conv-gv-pointer-fail-origin",
     });
 
-    createVoiceVerificationSession(
-      "self",
-      "+15559999999",
-      "gv-session-ptr-fail",
-    );
+    createVoiceVerificationSession("+15559999999", "gv-session-ptr-fail");
 
     const { relay } = createMockWs(session.id);
 
@@ -2071,14 +2041,12 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558887777",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Create a voice invite with friend/guardian names
     const code = generateVoiceCode(6);
     const codeHash = hashVoiceCode(code);
     createInvite({
-      assistantId: "self",
       sourceChannel: "voice",
       maxUses: 1,
       expectedExternalUserId: "+15558887777",
@@ -2146,14 +2114,12 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558886666",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Create a voice invite with friend/guardian names
     const code = generateVoiceCode(6);
     const codeHash = hashVoiceCode(code);
     createInvite({
-      assistantId: "self",
       sourceChannel: "voice",
       maxUses: 1,
       expectedExternalUserId: "+15558886666",
@@ -2228,7 +2194,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558885555",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // No voice invite created for this caller
@@ -2282,7 +2247,6 @@ describe("relay-server", () => {
         provider: "twilio",
         fromNumber: "+15558885556",
         toNumber: "+15551111111",
-        assistantId: "self",
       });
 
       const { ws, relay } = createMockWs(session.id);
@@ -2323,7 +2287,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558884444",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -2388,7 +2351,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558883333",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -2422,7 +2384,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558882222",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -2480,12 +2441,10 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15558881111",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Create a blocked member
     upsertMember({
-      assistantId: "self",
       sourceChannel: "voice",
       externalUserId: "+15558881111",
       externalChatId: "+15558881111",
@@ -2531,7 +2490,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770001",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -2579,7 +2537,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770002",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Track provider calls to verify no LLM turn is triggered on approval
@@ -2670,7 +2627,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770003",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -2754,7 +2710,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770004",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -2831,7 +2786,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770005",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -2877,7 +2831,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770010",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -2935,7 +2888,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770011",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     mockSendMessage.mockImplementation(
@@ -3001,7 +2953,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770012",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -3037,7 +2988,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770013",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -3108,7 +3058,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770014",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -3194,7 +3143,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770015",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -3252,7 +3200,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770016",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -3301,7 +3248,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770017",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -3365,7 +3311,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770020",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -3468,7 +3413,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770021",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -3526,7 +3470,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770022",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -3595,7 +3538,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770023",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -3673,7 +3615,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770024",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { relay } = createMockWs(session.id);
@@ -3764,7 +3705,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557770025",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Do NOT add caller as trusted contact
@@ -3851,7 +3791,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15551111111",
       toNumber: "+15559876543",
-      assistantId: "self",
       initiatedFromConversationId: "conv-relay-ptr-complete-origin",
     });
     updateCallSession(session.id, {
@@ -3890,7 +3829,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15551111111",
       toNumber: "+15559876543",
-      assistantId: "self",
       initiatedFromConversationId: "conv-relay-ptr-fail-origin",
     });
     updateCallSession(session.id, { status: "in_progress" });
@@ -3927,7 +3865,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15553334444",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Create a trusted-contact verification challenge with status 'pending'
@@ -3937,7 +3874,6 @@ describe("relay-server", () => {
     const tcSecret = "654321";
     createVerificationSession({
       id: randomUUID(),
-      assistantId: "self",
       channel: "voice",
       challengeHash: createHash("sha256").update(tcSecret).digest("hex"),
       expiresAt: Date.now() + 10 * 60 * 1000,
@@ -4011,11 +3947,10 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15552223333",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     // Create a guardian challenge (default verificationPurpose = 'guardian')
-    const secret = createPendingVoiceGuardianChallenge("self");
+    const secret = createPendingVoiceGuardianChallenge();
 
     mockSendMessage.mockImplementation(
       createMockProviderResponse(["Hello, how can I help you?"]),
@@ -4067,13 +4002,11 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15557776666",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const code = generateVoiceCode(6);
     const codeHash = hashVoiceCode(code);
     createInvite({
-      assistantId: "self",
       sourceChannel: "voice",
       maxUses: 1,
       expectedExternalUserId: "+15557776666",
@@ -4148,7 +4081,6 @@ describe("relay-server", () => {
 
     // Create a guardian binding with a different displayName
     createGuardianBinding({
-      assistantId: "self",
       channel: "voice",
       guardianExternalUserId: "+15559990001",
       guardianDeliveryChatId: "+15559990001",
@@ -4163,7 +4095,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559990099",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -4195,7 +4126,6 @@ describe("relay-server", () => {
 
     // Create a guardian binding with a displayName
     createGuardianBinding({
-      assistantId: "self",
       channel: "voice",
       guardianExternalUserId: "+15559990002",
       guardianDeliveryChatId: "+15559990002",
@@ -4210,7 +4140,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559990098",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);
@@ -4247,7 +4176,6 @@ describe("relay-server", () => {
       provider: "twilio",
       fromNumber: "+15559990097",
       toNumber: "+15551111111",
-      assistantId: "self",
     });
 
     const { ws, relay } = createMockWs(session.id);

package/src/__tests__/scoped-approval-grants.test.ts

@@ -72,7 +72,6 @@ function grantParams(
 ): CreateScopedApprovalGrantParams {
   const futureExpiry = new Date(Date.now() + 60_000).toISOString();
   return {
-    assistantId: "self",
     scopeMode: "request_id",
     requestChannel: "telegram",
     decisionChannel: "telegram",
@@ -95,11 +94,7 @@ describe("scoped-approval-grants / request_id scope", () => {
     expect(grant.status).toBe("active");
     expect(grant.requestId).toBe("req-1");
 
-    const result = consumeScopedApprovalGrantByRequestId(
-      "req-1",
-      "consumer-1",
-      "self",
-    );
+    const result = consumeScopedApprovalGrantByRequestId("req-1", "consumer-1");
     expect(result.ok).toBe(true);
     expect(result.grant).not.toBeNull();
     expect(result.grant!.status).toBe("consumed");
@@ -111,18 +106,10 @@ describe("scoped-approval-grants / request_id scope", () => {
       grantParams({ scopeMode: "request_id", requestId: "req-2" }),
     );
 
-    const first = consumeScopedApprovalGrantByRequestId(
-      "req-2",
-      "consumer-a",
-      "self",
-    );
+    const first = consumeScopedApprovalGrantByRequestId("req-2", "consumer-a");
     expect(first.ok).toBe(true);
 
-    const second = consumeScopedApprovalGrantByRequestId(
-      "req-2",
-      "consumer-b",
-      "self",
-    );
+    const second = consumeScopedApprovalGrantByRequestId("req-2", "consumer-b");
     expect(second.ok).toBe(false);
     expect(second.grant).toBeNull();
   });
@@ -131,7 +118,6 @@ describe("scoped-approval-grants / request_id scope", () => {
     const result = consumeScopedApprovalGrantByRequestId(
       "nonexistent",
       "consumer-x",
-      "self",
     );
     expect(result.ok).toBe(false);
   });
@@ -149,7 +135,6 @@ describe("scoped-approval-grants / request_id scope", () => {
     const result = consumeScopedApprovalGrantByRequestId(
       "req-expired",
       "consumer-1",
-      "self",
     );
     expect(result.ok).toBe(false);
   });
@@ -421,11 +406,7 @@ describe("scoped-approval-grants / expiry", () => {
     expect(count).toBe(2);
 
     // Verify the alive grant is still active
-    const alive = consumeScopedApprovalGrantByRequestId(
-      "req-alive",
-      "c1",
-      "self",
-    );
+    const alive = consumeScopedApprovalGrantByRequestId("req-alive", "c1");
     expect(alive.ok).toBe(true);
   });
 
@@ -438,7 +419,7 @@ describe("scoped-approval-grants / expiry", () => {
         expiresAt: new Date(Date.now() + 60_000).toISOString(),
       }),
     );
-    consumeScopedApprovalGrantByRequestId("req-consumed", "c1", "self");
+    consumeScopedApprovalGrantByRequestId("req-consumed", "c1");
 
     // Force the expiry time to the past for the consumed grant (simulating time passing)
     // The sweep should not touch consumed grants
@@ -483,15 +464,11 @@ describe("scoped-approval-grants / revoke", () => {
     expect(count).toBe(2);
 
     // Revoked grant cannot be consumed
-    const revoked = consumeScopedApprovalGrantByRequestId(
-      "req-r1",
-      "c1",
-      "self",
-    );
+    const revoked = consumeScopedApprovalGrantByRequestId("req-r1", "c1");
     expect(revoked.ok).toBe(false);
 
     // Unaffected grant is still consumable
-    const alive = consumeScopedApprovalGrantByRequestId("req-r3", "c1", "self");
+    const alive = consumeScopedApprovalGrantByRequestId("req-r3", "c1");
     expect(alive.ok).toBe(true);
   });
 
@@ -506,11 +483,7 @@ describe("scoped-approval-grants / revoke", () => {
 
     revokeScopedApprovalGrantsForContext({ conversationId: "conv-1" });
 
-    const result = consumeScopedApprovalGrantByRequestId(
-      "req-revoke",
-      "c1",
-      "self",
-    );
+    const result = consumeScopedApprovalGrantByRequestId("req-revoke", "c1");
     expect(result.ok).toBe(false);
   });
 
@@ -530,11 +503,7 @@ describe("scoped-approval-grants / revoke", () => {
     );
 
     // The grant should still be active (not revoked)
-    const result = consumeScopedApprovalGrantByRequestId(
-      "req-guard",
-      "c1",
-      "self",
-    );
+    const result = consumeScopedApprovalGrantByRequestId("req-guard", "c1");
     expect(result.ok).toBe(true);
   });
 });