@vellumai/assistant 0.4.33 → 0.4.35

package/src/memory/migrations/039-actor-refresh-token-records.ts

@@ -1,4 +1,5 @@
 import type { DrizzleDb } from "../db-connection.js";
+import { tableHasColumn } from "./schema-introspection.js";
 
 /**
  * Create the actor_refresh_token_records table for hash-only refresh token persistence.
@@ -34,10 +35,18 @@ export function createActorRefreshTokenRecordsTable(database: DrizzleDb): void {
   // Unique active refresh token per device binding.
   // DROP first so that databases that already created the older non-unique
   // index with the same name get upgraded to UNIQUE.
-  database.run(/*sql*/ `DROP INDEX IF EXISTS idx_refresh_tokens_active_device`);
-  database.run(/*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_refresh_tokens_active_device
+  if (tableHasColumn(database, "actor_refresh_token_records", "assistant_id")) {
+    database.run(
+      /*sql*/ `DROP INDEX IF EXISTS idx_refresh_tokens_active_device`,
+    );
+    database.run(/*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_refresh_tokens_active_device
       ON actor_refresh_token_records(assistant_id, guardian_principal_id, hashed_device_id)
       WHERE status = 'active'`);
+  } else {
+    database.run(/*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_refresh_tokens_active_device
+      ON actor_refresh_token_records(guardian_principal_id, hashed_device_id)
+      WHERE status = 'active'`);
+  }
 
   // Family lookup for replay detection (revoke entire family)
   database.run(/*sql*/ `CREATE INDEX IF NOT EXISTS idx_refresh_tokens_family

package/src/memory/migrations/110-channel-guardian.ts

@@ -1,4 +1,5 @@
 import type { DrizzleDb } from "../db-connection.js";
+import { tableHasColumn } from "./schema-introspection.js";
 
 /**
  * Channel guardian tables: bindings, verification challenges, approval requests,
@@ -43,9 +44,21 @@ export function createChannelGuardianTables(database: DrizzleDb): void {
     )
   `);
 
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_channel_guardian_challenges_lookup ON channel_guardian_verification_challenges(assistant_id, channel, challenge_hash, status)`,
-  );
+  if (
+    tableHasColumn(
+      database,
+      "channel_guardian_verification_challenges",
+      "assistant_id",
+    )
+  ) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_channel_guardian_challenges_lookup ON channel_guardian_verification_challenges(assistant_id, channel, challenge_hash, status)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_channel_guardian_challenges_lookup ON channel_guardian_verification_challenges(channel, challenge_hash, status)`,
+    );
+  }
 
   database.run(/*sql*/ `
     CREATE TABLE IF NOT EXISTS channel_guardian_approval_requests (
@@ -139,7 +152,15 @@ export function createChannelGuardianTables(database: DrizzleDb): void {
     /* already exists */
   }
 
-  database.run(
-    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_channel_guardian_rate_limits_actor ON channel_guardian_rate_limits(assistant_id, channel, actor_external_user_id, actor_chat_id)`,
-  );
+  if (
+    tableHasColumn(database, "channel_guardian_rate_limits", "assistant_id")
+  ) {
+    database.run(
+      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_channel_guardian_rate_limits_actor ON channel_guardian_rate_limits(assistant_id, channel, actor_external_user_id, actor_chat_id)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_channel_guardian_rate_limits_actor ON channel_guardian_rate_limits(channel, actor_external_user_id, actor_chat_id)`,
+    );
+  }
 }

package/src/memory/migrations/112-assistant-inbox.ts

@@ -1,5 +1,6 @@
 import type { DrizzleDb } from "../db-connection.js";
 import { migrateBackfillInboxThreadStateFromBindings } from "./014-backfill-inbox-thread-state.js";
+import { tableHasColumn } from "./schema-introspection.js";
 
 /**
  * Assistant inbox tables: ingress invites, ingress members, inbox thread state.
@@ -28,12 +29,21 @@ export function createAssistantInboxTables(database: DrizzleDb): void {
   database.run(
     /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_ingress_invites_token_hash ON assistant_ingress_invites(token_hash)`,
   );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_status ON assistant_ingress_invites(assistant_id, source_channel, status, expires_at)`,
-  );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_created ON assistant_ingress_invites(assistant_id, source_channel, created_at)`,
-  );
+  if (tableHasColumn(database, "assistant_ingress_invites", "assistant_id")) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_status ON assistant_ingress_invites(assistant_id, source_channel, status, expires_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_created ON assistant_ingress_invites(assistant_id, source_channel, created_at)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_status ON assistant_ingress_invites(source_channel, status, expires_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_created ON assistant_ingress_invites(source_channel, created_at)`,
+    );
+  }
 
   database.run(/*sql*/ `
     CREATE TABLE IF NOT EXISTS assistant_ingress_members (
@@ -90,15 +100,29 @@ export function createAssistantInboxTables(database: DrizzleDb): void {
     )
   `);
 
-  database.run(
-    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_inbox_thread_state_channel ON assistant_inbox_thread_state(assistant_id, source_channel, external_chat_id)`,
-  );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_last_msg ON assistant_inbox_thread_state(assistant_id, last_message_at)`,
-  );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_escalation ON assistant_inbox_thread_state(assistant_id, has_pending_escalation, last_message_at)`,
-  );
+  if (
+    tableHasColumn(database, "assistant_inbox_thread_state", "assistant_id")
+  ) {
+    database.run(
+      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_inbox_thread_state_channel ON assistant_inbox_thread_state(assistant_id, source_channel, external_chat_id)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_last_msg ON assistant_inbox_thread_state(assistant_id, last_message_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_escalation ON assistant_inbox_thread_state(assistant_id, has_pending_escalation, last_message_at)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_inbox_thread_state_channel ON assistant_inbox_thread_state(source_channel, external_chat_id)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_last_msg ON assistant_inbox_thread_state(last_message_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_escalation ON assistant_inbox_thread_state(has_pending_escalation, last_message_at)`,
+    );
+  }
 
   migrateBackfillInboxThreadStateFromBindings(database);
 }

package/src/memory/migrations/114-notifications.ts

@@ -2,6 +2,7 @@ import type { DrizzleDb } from "../db-connection.js";
 import { migrateNotificationTablesSchema } from "./019-notification-tables-schema-migration.js";
 import { migrateNotificationDeliveryPairingColumns } from "./027-notification-delivery-pairing-columns.js";
 import { migrateNotificationDeliveryClientAck } from "./028-notification-delivery-client-ack.js";
+import { tableHasColumn } from "./schema-introspection.js";
 
 /**
  * Notification system tables: preferences, events, decisions, and deliveries.
@@ -24,12 +25,18 @@ export function createNotificationTables(database: DrizzleDb): void {
     )
   `);
 
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_assistant_id ON notification_preferences(assistant_id)`,
-  );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_assistant_priority ON notification_preferences(assistant_id, priority DESC)`,
-  );
+  if (tableHasColumn(database, "notification_preferences", "assistant_id")) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_assistant_id ON notification_preferences(assistant_id)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_assistant_priority ON notification_preferences(assistant_id, priority DESC)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_priority ON notification_preferences(priority DESC)`,
+    );
+  }
 
   database.run(/*sql*/ `
     CREATE TABLE IF NOT EXISTS notification_events (
@@ -46,12 +53,21 @@ export function createNotificationTables(database: DrizzleDb): void {
     )
   `);
 
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_events_assistant_event_created ON notification_events(assistant_id, source_event_name, created_at)`,
-  );
-  database.run(
-    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_notification_events_dedupe ON notification_events(assistant_id, dedupe_key) WHERE dedupe_key IS NOT NULL`,
-  );
+  if (tableHasColumn(database, "notification_events", "assistant_id")) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_events_assistant_event_created ON notification_events(assistant_id, source_event_name, created_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_notification_events_dedupe ON notification_events(assistant_id, dedupe_key) WHERE dedupe_key IS NOT NULL`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_events_event_created ON notification_events(source_event_name, created_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_notification_events_dedupe ON notification_events(dedupe_key) WHERE dedupe_key IS NOT NULL`,
+    );
+  }
 
   database.run(/*sql*/ `
     CREATE TABLE IF NOT EXISTS notification_decisions (
@@ -97,9 +113,15 @@ export function createNotificationTables(database: DrizzleDb): void {
   database.run(
     /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_deliveries_decision_id ON notification_deliveries(notification_decision_id)`,
   );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_deliveries_assistant_status ON notification_deliveries(assistant_id, status)`,
-  );
+  if (tableHasColumn(database, "notification_deliveries", "assistant_id")) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_deliveries_assistant_status ON notification_deliveries(assistant_id, status)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_deliveries_status ON notification_deliveries(status)`,
+    );
+  }
 
   // Add conversation pairing audit columns (idempotent ALTER TABLE)
   migrateNotificationDeliveryPairingColumns(database);

package/src/memory/migrations/117-conversation-attention.ts

@@ -1,4 +1,5 @@
 import type { DrizzleDb } from "../db-connection.js";
+import { tableHasColumn } from "./schema-introspection.js";
 
 /**
  * Conversation attention tables: append-only evidence log and single-row
@@ -24,9 +25,17 @@ export function createConversationAttentionTables(database: DrizzleDb): void {
   database.run(
     /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_conv_observed ON conversation_attention_events(conversation_id, observed_at DESC)`,
   );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_assistant_observed ON conversation_attention_events(assistant_id, observed_at DESC)`,
-  );
+  if (
+    tableHasColumn(database, "conversation_attention_events", "assistant_id")
+  ) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_assistant_observed ON conversation_attention_events(assistant_id, observed_at DESC)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_observed ON conversation_attention_events(observed_at)`,
+    );
+  }
   database.run(
     /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_channel_observed ON conversation_attention_events(source_channel, observed_at DESC)`,
   );
@@ -50,10 +59,25 @@ export function createConversationAttentionTables(database: DrizzleDb): void {
     )
   `);
 
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_assistant_latest_msg ON conversation_assistant_attention_state(assistant_id, latest_assistant_message_at DESC)`,
-  );
-  database.run(
-    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_assistant_last_seen ON conversation_assistant_attention_state(assistant_id, last_seen_assistant_message_at DESC)`,
-  );
+  if (
+    tableHasColumn(
+      database,
+      "conversation_assistant_attention_state",
+      "assistant_id",
+    )
+  ) {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_assistant_latest_msg ON conversation_assistant_attention_state(assistant_id, latest_assistant_message_at DESC)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_assistant_last_seen ON conversation_assistant_attention_state(assistant_id, last_seen_assistant_message_at DESC)`,
+    );
+  } else {
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_latest_msg ON conversation_assistant_attention_state(latest_assistant_message_at)`,
+    );
+    database.run(
+      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_last_seen ON conversation_assistant_attention_state(last_seen_assistant_message_at)`,
+    );
+  }
 }

package/src/memory/migrations/134-contacts-notes-column.ts

@@ -1,68 +1,87 @@
 import { getLogger } from "../../util/logger.js";
 import { type DrizzleDb, getSqliteFrom } from "../db-connection.js";
+import { withCrashRecovery } from "./validate-migration-state.js";
 
 const log = getLogger("migration-134");
 
 export function migrateContactsNotesColumn(database: DrizzleDb): void {
-  const raw = getSqliteFrom(database);
+  withCrashRecovery(database, "migration_contacts_notes_column_v1", () => {
+    const raw = getSqliteFrom(database);
 
-  try {
-    raw.exec(/*sql*/ `ALTER TABLE contacts ADD COLUMN notes TEXT`);
-  } catch {
-    /* already exists */
-  }
+    try {
+      raw.exec(/*sql*/ `ALTER TABLE contacts ADD COLUMN notes TEXT`);
+    } catch {
+      /* already exists */
+    }
+
+    // Check which legacy columns still exist — handles partial completion
+    // if a previous run crashed after dropping some columns but not all.
+    const cols = new Set(
+      (
+        raw.query(`PRAGMA table_info(contacts)`).all() as Array<{
+          name: string;
+        }>
+      ).map((c) => c.name),
+    );
 
-  // Check if legacy columns still exist before attempting backfill + drop
-  const cols = new Set(
-    (
-      raw.query(`PRAGMA table_info(contacts)`).all() as Array<{ name: string }>
-    ).map((c) => c.name),
-  );
+    const legacyCols = [
+      "relationship",
+      "importance",
+      "response_expectation",
+      "preferred_tone",
+    ] as const;
+    const remaining = legacyCols.filter((c) => cols.has(c));
 
-  if (cols.has("relationship")) {
-    const rows = raw
-      .query(
-        `SELECT id, relationship, importance, response_expectation, preferred_tone
+    // Backfill notes from legacy columns if any are still present and notes
+    // haven't been populated yet (only run once, before any columns are dropped).
+    if (remaining.length === legacyCols.length) {
+      const rows = raw
+        .query(
+          `SELECT id, relationship, importance, response_expectation, preferred_tone
        FROM contacts
        WHERE relationship IS NOT NULL
           OR importance != 0.5
           OR response_expectation IS NOT NULL
           OR preferred_tone IS NOT NULL`,
-      )
-      .all() as Array<{
-      id: string;
-      relationship: string | null;
-      importance: number;
-      response_expectation: string | null;
-      preferred_tone: string | null;
-    }>;
+        )
+        .all() as Array<{
+        id: string;
+        relationship: string | null;
+        importance: number;
+        response_expectation: string | null;
+        preferred_tone: string | null;
+      }>;
 
-    const update = raw.prepare(`UPDATE contacts SET notes = ? WHERE id = ?`);
+      const update = raw.prepare(`UPDATE contacts SET notes = ? WHERE id = ?`);
 
-    for (const row of rows) {
-      const parts: string[] = [];
-      if (row.relationship) parts.push(`Relationship: ${row.relationship}`);
-      if (row.importance !== 0.5) parts.push(`Importance: ${row.importance}`);
-      if (row.response_expectation)
-        parts.push(`Response expectation: ${row.response_expectation}`);
-      if (row.preferred_tone)
-        parts.push(`Preferred tone: ${row.preferred_tone}`);
-      if (parts.length > 0) {
-        update.run(parts.join("\n"), row.id);
+      for (const row of rows) {
+        const parts: string[] = [];
+        if (row.relationship) parts.push(`Relationship: ${row.relationship}`);
+        if (row.importance !== 0.5) parts.push(`Importance: ${row.importance}`);
+        if (row.response_expectation)
+          parts.push(`Response expectation: ${row.response_expectation}`);
+        if (row.preferred_tone)
+          parts.push(`Preferred tone: ${row.preferred_tone}`);
+        if (parts.length > 0) {
+          update.run(parts.join("\n"), row.id);
+        }
       }
-    }
 
-    const migrated = rows.length;
-    if (migrated > 0) {
-      log.info({ migrated }, "Migrated contact metadata to notes field");
+      const migrated = rows.length;
+      if (migrated > 0) {
+        log.info({ migrated }, "Migrated contact metadata to notes field");
+      }
     }
 
-    // Drop indexes that reference columns we're about to remove
+    // Drop indexes that reference columns we're about to remove.
+    // Must happen before the column drops — SQLite rejects dropping a column
+    // that is still referenced by an index.
     raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_contacts_importance`);
 
-    raw.exec(/*sql*/ `ALTER TABLE contacts DROP COLUMN relationship`);
-    raw.exec(/*sql*/ `ALTER TABLE contacts DROP COLUMN importance`);
-    raw.exec(/*sql*/ `ALTER TABLE contacts DROP COLUMN response_expectation`);
-    raw.exec(/*sql*/ `ALTER TABLE contacts DROP COLUMN preferred_tone`);
-  }
+    // Drop each legacy column individually so partial completion is safe:
+    // on crash recovery the loop picks up only the columns that remain.
+    for (const col of remaining) {
+      raw.exec(/*sql*/ `ALTER TABLE contacts DROP COLUMN ${col}`);
+    }
+  });
 }