@vellumai/assistant 0.4.32 → 0.4.34

package/src/__tests__/scoped-approval-grants.test.ts

@@ -72,7 +72,6 @@ function grantParams(
 ): CreateScopedApprovalGrantParams {
   const futureExpiry = new Date(Date.now() + 60_000).toISOString();
   return {
-    assistantId: "self",
     scopeMode: "request_id",
     requestChannel: "telegram",
     decisionChannel: "telegram",
@@ -95,11 +94,7 @@ describe("scoped-approval-grants / request_id scope", () => {
     expect(grant.status).toBe("active");
     expect(grant.requestId).toBe("req-1");
 
-    const result = consumeScopedApprovalGrantByRequestId(
-      "req-1",
-      "consumer-1",
-      "self",
-    );
+    const result = consumeScopedApprovalGrantByRequestId("req-1", "consumer-1");
     expect(result.ok).toBe(true);
     expect(result.grant).not.toBeNull();
     expect(result.grant!.status).toBe("consumed");
@@ -111,18 +106,10 @@ describe("scoped-approval-grants / request_id scope", () => {
       grantParams({ scopeMode: "request_id", requestId: "req-2" }),
     );
 
-    const first = consumeScopedApprovalGrantByRequestId(
-      "req-2",
-      "consumer-a",
-      "self",
-    );
+    const first = consumeScopedApprovalGrantByRequestId("req-2", "consumer-a");
     expect(first.ok).toBe(true);
 
-    const second = consumeScopedApprovalGrantByRequestId(
-      "req-2",
-      "consumer-b",
-      "self",
-    );
+    const second = consumeScopedApprovalGrantByRequestId("req-2", "consumer-b");
     expect(second.ok).toBe(false);
     expect(second.grant).toBeNull();
   });
@@ -131,7 +118,6 @@ describe("scoped-approval-grants / request_id scope", () => {
     const result = consumeScopedApprovalGrantByRequestId(
       "nonexistent",
       "consumer-x",
-      "self",
     );
     expect(result.ok).toBe(false);
   });
@@ -149,7 +135,6 @@ describe("scoped-approval-grants / request_id scope", () => {
     const result = consumeScopedApprovalGrantByRequestId(
       "req-expired",
       "consumer-1",
-      "self",
     );
     expect(result.ok).toBe(false);
   });
@@ -421,11 +406,7 @@ describe("scoped-approval-grants / expiry", () => {
     expect(count).toBe(2);
 
     // Verify the alive grant is still active
-    const alive = consumeScopedApprovalGrantByRequestId(
-      "req-alive",
-      "c1",
-      "self",
-    );
+    const alive = consumeScopedApprovalGrantByRequestId("req-alive", "c1");
     expect(alive.ok).toBe(true);
   });
 
@@ -438,7 +419,7 @@ describe("scoped-approval-grants / expiry", () => {
         expiresAt: new Date(Date.now() + 60_000).toISOString(),
       }),
     );
-    consumeScopedApprovalGrantByRequestId("req-consumed", "c1", "self");
+    consumeScopedApprovalGrantByRequestId("req-consumed", "c1");
 
     // Force the expiry time to the past for the consumed grant (simulating time passing)
     // The sweep should not touch consumed grants
@@ -483,15 +464,11 @@ describe("scoped-approval-grants / revoke", () => {
     expect(count).toBe(2);
 
     // Revoked grant cannot be consumed
-    const revoked = consumeScopedApprovalGrantByRequestId(
-      "req-r1",
-      "c1",
-      "self",
-    );
+    const revoked = consumeScopedApprovalGrantByRequestId("req-r1", "c1");
     expect(revoked.ok).toBe(false);
 
     // Unaffected grant is still consumable
-    const alive = consumeScopedApprovalGrantByRequestId("req-r3", "c1", "self");
+    const alive = consumeScopedApprovalGrantByRequestId("req-r3", "c1");
     expect(alive.ok).toBe(true);
   });
 
@@ -506,11 +483,7 @@ describe("scoped-approval-grants / revoke", () => {
 
     revokeScopedApprovalGrantsForContext({ conversationId: "conv-1" });
 
-    const result = consumeScopedApprovalGrantByRequestId(
-      "req-revoke",
-      "c1",
-      "self",
-    );
+    const result = consumeScopedApprovalGrantByRequestId("req-revoke", "c1");
     expect(result.ok).toBe(false);
   });
 
@@ -530,11 +503,7 @@ describe("scoped-approval-grants / revoke", () => {
     );
 
     // The grant should still be active (not revoked)
-    const result = consumeScopedApprovalGrantByRequestId(
-      "req-guard",
-      "c1",
-      "self",
-    );
+    const result = consumeScopedApprovalGrantByRequestId("req-guard", "c1");
     expect(result.ok).toBe(true);
   });
 });

package/src/__tests__/scoped-grant-security-matrix.test.ts

@@ -89,7 +89,6 @@ function grantParams(
 ): CreateScopedApprovalGrantParams {
   const futureExpiry = new Date(Date.now() + 60_000).toISOString();
   return {
-    assistantId: "self",
     scopeMode: "tool_signature",
     toolName: "bash",
     inputDigest: computeToolApprovalDigest("bash", { cmd: "ls" }),
@@ -338,35 +337,6 @@ describe("security matrix: persistence and fail-closed behavior", () => {
 describe("security matrix: cross-scope invariants", () => {
   beforeEach(() => clearTables());
 
-  test("grant for one assistant cannot be consumed by another assistant", () => {
-    const digest = computeToolApprovalDigest("bash", { cmd: "ls" });
-    createScopedApprovalGrant(
-      grantParams({
-        toolName: "bash",
-        inputDigest: digest,
-        assistantId: "assistant-alpha",
-      }),
-    );
-
-    // Attempt consumption from a different assistant
-    const wrongAssistant = consumeScopedApprovalGrantByToolSignature({
-      toolName: "bash",
-      inputDigest: digest,
-      consumingRequestId: "c1",
-      assistantId: "assistant-beta",
-    });
-    expect(wrongAssistant.ok).toBe(false);
-
-    // Correct assistant succeeds
-    const correctAssistant = consumeScopedApprovalGrantByToolSignature({
-      toolName: "bash",
-      inputDigest: digest,
-      consumingRequestId: "c2",
-      assistantId: "assistant-alpha",
-    });
-    expect(correctAssistant.ok).toBe(true);
-  });
-
   test("all scope fields must match simultaneously for consumption", () => {
     const digest = computeToolApprovalDigest("bash", { cmd: "ls" });
 
@@ -375,7 +345,6 @@ describe("security matrix: cross-scope invariants", () => {
       grantParams({
         toolName: "bash",
         inputDigest: digest,
-        assistantId: "self",
         executionChannel: "voice",
         conversationId: "conv-123",
         callSessionId: "call-456",
@@ -391,7 +360,6 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-chan",
-        assistantId: "self",
         executionChannel: "sms",
         conversationId: "conv-123",
         callSessionId: "call-456",
@@ -405,7 +373,6 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-conv",
-        assistantId: "self",
         executionChannel: "voice",
         conversationId: "conv-999",
         callSessionId: "call-456",
@@ -419,7 +386,6 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-call",
-        assistantId: "self",
         executionChannel: "voice",
         conversationId: "conv-123",
         callSessionId: "call-999",
@@ -433,7 +399,6 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-user",
-        assistantId: "self",
         executionChannel: "voice",
         conversationId: "conv-123",
         callSessionId: "call-456",
@@ -447,7 +412,6 @@ describe("security matrix: cross-scope invariants", () => {
         toolName: "bash",
         inputDigest: digest,
         consumingRequestId: "c-all",
-        assistantId: "self",
         executionChannel: "voice",
         conversationId: "conv-123",
         callSessionId: "call-456",

package/src/__tests__/send-endpoint-busy.test.ts

@@ -295,7 +295,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     pendingInteractions.clear();
 
     createGuardianBinding({
-      assistantId: "self",
       channel: "vellum",
       guardianExternalUserId: "dev-bypass",
       guardianDeliveryChatId: "vellum",

package/src/__tests__/send-notification-tool.test.ts

@@ -44,7 +44,6 @@ describe("send-notification tool", () => {
       sourceEventName: "user.send_notification",
       sourceChannel: "assistant_tool",
       sourceSessionId: "conv-override",
-      assistantId: "ast-alpha",
       attentionHints: {
         requiresAction: true,
         urgency: "high",

package/src/__tests__/session-init.benchmark.test.ts

@@ -107,13 +107,11 @@ mock.module("../util/platform.js", () => ({
   isWindows: () => process.platform === "win32",
   getPlatformName: () => process.platform,
   getClipboardCommand: () => null,
-  getHttpTokenPath: () => join(testDir, "http-token"),
   getPlatformTokenPath: () => join(testDir, "platform-token"),
   getTCPHost: () => "127.0.0.1",
   getTCPPort: () => 8765,
   isIOSPairingEnabled: () => false,
   isTCPEnabled: () => false,
-  readHttpToken: () => null,
   readLockfile: () => null,
   readPlatformToken: () => null,
   readSessionToken: () => null,

package/src/__tests__/slack-channel-config.test.ts

@@ -28,7 +28,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  readHttpToken: () => undefined,
 }));
 
 mock.module("../util/logger.js", () => ({

package/src/__tests__/slack-inbound-verification.test.ts

@@ -30,7 +30,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  readHttpToken: () => "test-bearer-token",
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -177,7 +176,7 @@ describe("Slack inbound trusted contact verification", () => {
     await handleChannelInbound(req, undefined, TEST_BEARER_TOKEN);
 
     // An active outbound session should exist for the slack channel
-    const session = findActiveSession("self", "slack");
+    const session = findActiveSession("slack");
     expect(session).not.toBeNull();
     expect(session!.expectedExternalUserId).toBe("U0123UNKNOWN");
     expect(session!.expectedChatId).toBe("U0123UNKNOWN");
@@ -188,7 +187,6 @@ describe("Slack inbound trusted contact verification", () => {
   test("guardian is notified of the access attempt alongside verification", async () => {
     // Set up a guardian binding so the notification can target it
     createGuardianBinding({
-      assistantId: "self",
       channel: "slack",
       guardianExternalUserId: "U_GUARDIAN",
       guardianDeliveryChatId: "D_GUARDIAN_DM",
@@ -286,7 +284,7 @@ describe("Slack inbound trusted contact verification", () => {
     const req = buildSlackInboundRequest();
     await handleChannelInbound(req, undefined, TEST_BEARER_TOKEN);
 
-    const session = findActiveSession("self", "slack");
+    const session = findActiveSession("slack");
     expect(session).not.toBeNull();
 
     // The challenge hash is stored in the session — extract the secret
@@ -318,7 +316,6 @@ describe("Slack inbound trusted contact verification", () => {
       await import("../runtime/channel-guardian-service.js");
 
     const outboundSession = createOutboundSession({
-      assistantId: "self",
       channel: "slack",
       expectedExternalUserId: "U0123UNKNOWN",
       expectedChatId: "U0123UNKNOWN",

package/src/__tests__/sms-messaging-provider.test.ts

@@ -33,10 +33,6 @@ mock.module("../security/secure-keys.js", () => ({
   getSecureKey: (key: string) => secureKeys[key],
 }));
 
-mock.module("../util/platform.js", () => ({
-  readHttpToken: () => "runtime-token",
-}));
-
 mock.module("../runtime/auth/token-service.js", () => ({
   mintDaemonDeliveryToken: () => "runtime-token",
 }));

package/src/__tests__/terminal-tools.test.ts

@@ -711,10 +711,13 @@ describe("formatShellOutput", () => {
     expect(result.isError).toBe(false);
   });
 
-  test("failed command with no output shows exit code tag", () => {
+  test("failed command with no output shows exit code tag and descriptive message", () => {
     const result = formatShellOutput("", "", 1, false, 120);
-    expect(result.content).toBe('<command_exit code="1" />');
+    expect(result.content).toContain('<command_exit code="1" />');
+    expect(result.content).toContain("Command failed with exit code 1");
+    expect(result.content).toContain("No stdout or stderr output was produced");
     expect(result.isError).toBe(true);
+    expect(result.status).toContain('<command_exit code="1" />');
   });
 
   test("failed command with output includes exit code in status", () => {

package/src/__tests__/thread-seed-composer.test.ts

@@ -25,7 +25,6 @@ function makeSignal(
 ): NotificationSignal {
   return {
     signalId: "sig-seed-001",
-    assistantId: "self",
     createdAt: Date.now(),
     sourceChannel: "scheduler",
     sourceSessionId: "sess-1",

package/src/__tests__/tool-approval-handler.test.ts

@@ -90,7 +90,6 @@ afterAll(() => {
 function mintParams(overrides: Partial<MintGrantParams> = {}): MintGrantParams {
   const futureExpiry = new Date(Date.now() + 60_000).toISOString();
   return {
-    assistantId: "self",
     scopeMode: "tool_signature",
     requestChannel: "telegram",
     decisionChannel: "telegram",

package/src/__tests__/tool-grant-request-escalation.test.ts

@@ -684,7 +684,6 @@ describe("inline wait-and-resume", () => {
         toolName: "bash",
         inputDigest: "sha256:waitgrant",
         consumingRequestId: "consume-1",
-        assistantId: "self",
         conversationId: "conv-1",
         requesterExternalUserId: "requester-1",
         executionChannel: "telegram",
@@ -727,7 +726,6 @@ describe("inline wait-and-resume", () => {
         toolName: "bash",
         inputDigest: "sha256:denywait",
         consumingRequestId: "consume-1",
-        assistantId: "self",
       },
       { maxWaitMs: 2_000, intervalMs: 20 },
     );
@@ -759,7 +757,6 @@ describe("inline wait-and-resume", () => {
         toolName: "bash",
         inputDigest: "sha256:timeoutwait",
         consumingRequestId: "consume-1",
-        assistantId: "self",
       },
       { maxWaitMs: 100, intervalMs: 20 },
     );
@@ -797,7 +794,6 @@ describe("inline wait-and-resume", () => {
         toolName: "bash",
         inputDigest: "sha256:abortwait",
         consumingRequestId: "consume-1",
-        assistantId: "self",
       },
       { maxWaitMs: 5_000, intervalMs: 20, signal: controller.signal },
     );