@vellumai/assistant 0.4.32 → 0.4.34

package/src/__tests__/channel-approval-routes.test.ts

@@ -208,7 +208,6 @@ const noopProcessMessage = mock(async () => ({ messageId: "msg-1" }));
 function ensureTestContact(): void {
   upsertContact({
     displayName: "Test User",
-    assistantId: "self",
     channels: [
       {
         type: "telegram",
@@ -268,7 +267,6 @@ describe("stale callback handling without matching pending approval", () => {
 describe("inbound callback metadata triggers decision handling", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -362,7 +360,6 @@ describe("inbound callback metadata triggers decision handling", () => {
 describe("inbound text matching approval phrases triggers decision handling", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -444,7 +441,6 @@ describe("inbound text matching approval phrases triggers decision handling", ()
 describe("non-decision messages during pending approval (legacy fallback)", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -526,7 +522,6 @@ describe("messages without pending approval proceed normally", () => {
 describe("empty content with callbackData bypasses validation", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -639,7 +634,6 @@ describe("empty content with callbackData bypasses validation", () => {
 describe("callback requestId validation", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -767,7 +761,6 @@ describe("callback requestId validation", () => {
 describe("no immediate reply after approval decision", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -900,7 +893,6 @@ describe("stale callback handling", () => {
 describe("SMS channel approval decisions", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "sms",
       guardianExternalUserId: "sms-user-default",
       guardianDeliveryChatId: "sms-chat-123",
@@ -1056,7 +1048,7 @@ describe("SMS guardian verify intercept", () => {
   test("verification code reply works with sourceChannel sms", async () => {
     const { createVerificationChallenge } =
       await import("../runtime/channel-guardian-service.js");
-    const { secret } = createVerificationChallenge("self", "sms");
+    const { secret } = createVerificationChallenge("sms");
 
     const deliverSpy = spyOn(
       gatewayClient,
@@ -1100,7 +1092,7 @@ describe("SMS guardian verify intercept", () => {
     const { createVerificationChallenge } =
       await import("../runtime/channel-guardian-service.js");
     // Ensure there is a pending challenge so bare-code verification is intercepted.
-    createVerificationChallenge("self", "sms");
+    createVerificationChallenge("sms");
 
     const deliverSpy = spyOn(
       gatewayClient,
@@ -1148,7 +1140,6 @@ describe("SMS guardian verify intercept", () => {
     const challengeHash = createHash("sha256").update(secret).digest("hex");
     createChallenge({
       id: `challenge-hex-${Date.now()}`,
-      assistantId: "self",
       channel: "sms",
       challengeHash,
       expiresAt: Date.now() + 600_000,
@@ -1192,7 +1183,6 @@ describe("SMS guardian verify intercept", () => {
 describe("guardian decision scoping — multiple pending approvals", () => {
   test("callback for older request resolves to the correct approval request", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-scope-user",
       guardianDeliveryChatId: "guardian-scope-chat",
@@ -1277,7 +1267,6 @@ describe("guardian decision scoping — multiple pending approvals", () => {
 describe("ambiguous plain-text decision with multiple pending requests", () => {
   test("does not apply plain-text decision to wrong request when multiple pending", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-ambig-user",
       guardianDeliveryChatId: "guardian-ambig-chat",
@@ -1510,7 +1499,7 @@ describe("assistant-scoped guardian verification via handleChannelInbound", () =
   test("verification code uses the threaded assistantId (default: self)", async () => {
     const { createVerificationChallenge } =
       await import("../runtime/channel-guardian-service.js");
-    const { secret } = createVerificationChallenge("self", "telegram");
+    const { secret } = createVerificationChallenge("telegram");
 
     const deliverSpy = spyOn(
       gatewayClient,
@@ -1538,7 +1527,7 @@ describe("assistant-scoped guardian verification via handleChannelInbound", () =
       await import("../runtime/channel-guardian-service.js");
 
     // All assistant IDs canonicalize to 'self' in the single-tenant daemon
-    const { secret } = createVerificationChallenge("self", "telegram");
+    const { secret } = createVerificationChallenge("telegram");
 
     const deliverSpy = spyOn(
       gatewayClient,
@@ -1572,7 +1561,7 @@ describe("assistant-scoped guardian verification via handleChannelInbound", () =
       await import("../runtime/channel-guardian-service.js");
 
     // Both IDs canonicalize to 'self', so the challenge is found
-    const { secret } = createVerificationChallenge("self", "telegram");
+    const { secret } = createVerificationChallenge("telegram");
 
     const deliverSpy = spyOn(
       gatewayClient,
@@ -1600,7 +1589,6 @@ describe("assistant-scoped guardian verification via handleChannelInbound", () =
   test("inbound with explicit assistantId does not mutate existing external bindings", async () => {
     upsertContact({
       displayName: "Incoming User",
-      assistantId: "self",
       channels: [
         {
           type: "telegram",
@@ -1665,7 +1653,6 @@ describe("assistant-scoped guardian verification via handleChannelInbound", () =
 describe("conversational approval engine — standard path", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -1886,7 +1873,6 @@ describe("conversational approval engine — standard path", () => {
 describe("guardian conversational approval via conversation engine", () => {
   test("guardian follow-up clarification: engine returns keep_pending", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-conv-user",
       guardianDeliveryChatId: "guardian-conv-chat",
@@ -1959,7 +1945,6 @@ describe("guardian conversational approval via conversation engine", () => {
     const pending = getAllPendingApprovalsByGuardianChat(
       "telegram",
       "guardian-conv-chat",
-      "self",
     );
     expect(pending).toHaveLength(1);
 
@@ -1968,7 +1953,6 @@ describe("guardian conversational approval via conversation engine", () => {
 
   test("guardian natural-language approval: engine returns approve_once", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-nlp-user",
       guardianDeliveryChatId: "guardian-nlp-chat",
@@ -2031,7 +2015,6 @@ describe("guardian conversational approval via conversation engine", () => {
     const pending = getAllPendingApprovalsByGuardianChat(
       "telegram",
       "guardian-nlp-chat",
-      "self",
     );
     expect(pending).toHaveLength(0);
 
@@ -2048,7 +2031,6 @@ describe("guardian conversational approval via conversation engine", () => {
 
   test("guardian callback button approve_always is downgraded to approve_once", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-dg-user",
       guardianDeliveryChatId: "guardian-dg-chat",
@@ -2103,7 +2085,6 @@ describe("guardian conversational approval via conversation engine", () => {
 
   test("multi-pending guardian disambiguation: engine requests clarification", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-multi-user",
       guardianDeliveryChatId: "guardian-multi-chat",
@@ -2206,7 +2187,6 @@ describe("guardian conversational approval via conversation engine", () => {
 describe("keep_pending remains conversational — standard path", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -2267,7 +2247,6 @@ describe("keep_pending remains conversational — standard path", () => {
 describe("keep_pending remains conversational — guardian path", () => {
   test('guardian explicit "yes" with keep_pending returns assistant_turn without applying a decision', async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-user-fb",
       guardianDeliveryChatId: "guardian-chat-fb",
@@ -2291,7 +2270,6 @@ describe("keep_pending remains conversational — guardian path", () => {
       runId: "run-gfb-1",
       requestId: "req-gfb-1",
       conversationId: convId,
-      assistantId: "self",
       channel: "telegram",
       requesterExternalUserId: "requester-user-fb",
       requesterChatId: "requester-chat-fb",
@@ -2342,7 +2320,6 @@ describe("keep_pending remains conversational — guardian path", () => {
 describe("requester cancel of guardian-gated pending request", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-cancel",
       guardianDeliveryChatId: "guardian-cancel-chat",
@@ -2350,7 +2327,6 @@ describe("requester cancel of guardian-gated pending request", () => {
     });
     upsertContact({
       displayName: "Requester Cancel User",
-      assistantId: "self",
       channels: [
         {
           type: "telegram",
@@ -2394,7 +2370,6 @@ describe("requester cancel of guardian-gated pending request", () => {
       runId: "run-cancel-1",
       requestId: "req-cancel-1",
       conversationId: conversationId!,
-      assistantId: "self",
       channel: "telegram",
       requesterExternalUserId: "requester-cancel-user",
       requesterChatId: "requester-cancel-chat",
@@ -2476,7 +2451,6 @@ describe("requester cancel of guardian-gated pending request", () => {
       runId: "run-cancel-2",
       requestId: "req-cancel-2",
       conversationId: conversationId!,
-      assistantId: "self",
       channel: "telegram",
       requesterExternalUserId: "requester-cancel-user",
       requesterChatId: "requester-cancel-chat",
@@ -2552,7 +2526,6 @@ describe("requester cancel of guardian-gated pending request", () => {
       runId: "run-cancel-3",
       requestId: "req-cancel-3",
       conversationId: conversationId!,
-      assistantId: "self",
       channel: "telegram",
       requesterExternalUserId: "requester-cancel-user",
       requesterChatId: "requester-cancel-chat",
@@ -2621,7 +2594,6 @@ describe("requester cancel of guardian-gated pending request", () => {
       runId: "run-cancel-4",
       requestId: "req-cancel-4",
       conversationId: conversationId!,
-      assistantId: "self",
       channel: "telegram",
       requesterExternalUserId: "requester-cancel-user",
       requesterChatId: "requester-cancel-chat",
@@ -2657,7 +2629,6 @@ describe("requester cancel of guardian-gated pending request", () => {
 describe("engine decision race condition — standard path", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -2727,7 +2698,6 @@ describe("engine decision race condition — standard path", () => {
 describe("engine decision race condition — guardian path", () => {
   test("returns stale_ignored when guardian engine approves but interaction was already resolved", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-race-user",
       guardianDeliveryChatId: "guardian-race-chat",
@@ -2747,7 +2717,6 @@ describe("engine decision race condition — guardian path", () => {
       runId: "run-grc-1",
       requestId: "req-grc-1",
       conversationId: convId,
-      assistantId: "self",
       channel: "telegram",
       requesterExternalUserId: "requester-race-user",
       requesterChatId: "requester-race-chat",
@@ -2809,14 +2778,12 @@ describe("engine decision race condition — guardian path", () => {
 describe("non-decision status reply for different channels", () => {
   beforeEach(() => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
       guardianPrincipalId: "telegram-user-default",
     });
     createGuardianBinding({
-      assistantId: "self",
       channel: "sms",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -2927,7 +2894,6 @@ describe("background channel processing approval prompts", () => {
   test("marks guardian channel turns interactive and delivers approval prompt when confirmation is pending", async () => {
     // Set up a guardian binding so the sender is recognized as a guardian
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",
@@ -2991,7 +2957,6 @@ describe("background channel processing approval prompts", () => {
     // Guardian binding includes extra whitespace; trust resolution canonicalizes
     // identity and prompt delivery should still treat this sender as the guardian.
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "  telegram-user-default  ",
       guardianDeliveryChatId: "chat-123",
@@ -3056,7 +3021,6 @@ describe("background channel processing approval prompts", () => {
     // trusted contact (not the guardian). The guardian route is resolvable
     // because the binding exists — approval notifications can be delivered.
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-user-other",
       guardianDeliveryChatId: "guardian-chat-other",
@@ -3178,7 +3142,6 @@ describe("NL approval routing via destination-scoped canonical requests", () =>
 
     // Create guardian binding for Telegram
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: guardianUserId,
       guardianDeliveryChatId: guardianChatId,
@@ -3236,7 +3199,6 @@ describe("NL approval routing via destination-scoped canonical requests", () =>
 
     // Create guardian binding for the guardian user on the different chat
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: guardianUserId,
       guardianDeliveryChatId: differentChatId,
@@ -3293,7 +3255,6 @@ describe("trusted-contact self-approval blocked before guardian approval row exi
   beforeEach(() => {
     // Create a guardian binding so the requester resolves as trusted_contact
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-tc-selfapproval",
       guardianDeliveryChatId: "guardian-tc-selfapproval-chat",
@@ -3301,7 +3262,6 @@ describe("trusted-contact self-approval blocked before guardian approval row exi
     });
     upsertContact({
       displayName: "TC Self-Approval User",
-      assistantId: "self",
       channels: [
         {
           type: "telegram",