@vellumai/assistant 0.4.2 → 0.4.4

package/src/__tests__/channel-approval-routes.test.ts

@@ -1319,11 +1319,12 @@ describe('assistant-scoped guardian verification via handleChannelInbound', () =
     deliverSpy.mockRestore();
   });
 
-  test('verification code with explicit assistantId resolves against that assistant', async () => {
+  test('verification code with explicit assistantId resolves against canonical scope', async () => {
     const { createVerificationChallenge } = await import('../runtime/channel-guardian-service.js');
     const { getGuardianBinding } = await import('../runtime/channel-guardian-service.js');
 
-    const { secret } = createVerificationChallenge('asst-route-X', 'telegram');
+    // All assistant IDs canonicalize to 'self' in the single-tenant daemon
+    const { secret } = createVerificationChallenge('self', 'telegram');
 
     const deliverSpy = spyOn(gatewayClient, 'deliverChannelReply').mockResolvedValue(undefined);
 
@@ -1338,17 +1339,18 @@ describe('assistant-scoped guardian verification via handleChannelInbound', () =
     expect(body.accepted).toBe(true);
     expect(body.guardianVerification).toBe('verified');
 
-    const bindingX = getGuardianBinding('asst-route-X', 'telegram');
+    const bindingX = getGuardianBinding('self', 'telegram');
     expect(bindingX).not.toBeNull();
     expect(bindingX!.guardianExternalUserId).toBe('user-for-asst-x');
 
     deliverSpy.mockRestore();
   });
 
-  test('cross-assistant challenge code does not verify against a different assistant scope', async () => {
+  test('all assistant IDs share canonical scope for verification', async () => {
     const { createVerificationChallenge } = await import('../runtime/channel-guardian-service.js');
 
-    const { secret } = createVerificationChallenge('asst-A-cross', 'telegram');
+    // Both IDs canonicalize to 'self', so the challenge is found
+    const { secret } = createVerificationChallenge('self', 'telegram');
 
     const deliverSpy = spyOn(gatewayClient, 'deliverChannelReply').mockResolvedValue(undefined);
 
@@ -1361,19 +1363,19 @@ describe('assistant-scoped guardian verification via handleChannelInbound', () =
     const body = await res.json() as Record<string, unknown>;
 
     expect(body.accepted).toBe(true);
-    expect(body.guardianVerification).toBeUndefined();
+    expect(body.guardianVerification).toBe('verified');
 
     deliverSpy.mockRestore();
   });
 
-  test('non-self assistant inbound does not mutate assistant-agnostic external bindings', async () => {
+  test('inbound with explicit assistantId does not mutate existing external bindings', async () => {
     const db = getDb();
     const now = Date.now();
     ensureConversation('conv-existing-binding');
     db.insert(externalConversationBindings).values({
       conversationId: 'conv-existing-binding',
       sourceChannel: 'telegram',
-      externalChatId: 'chat-123',
+      externalChatId: 'chat-existing-999',
       externalUserId: 'existing-user',
       createdAt: now,
       updatedAt: now,
@@ -1385,7 +1387,7 @@ describe('assistant-scoped guardian verification via handleChannelInbound', () =
       senderExternalUserId: 'incoming-user',
     });
 
-    const res = await handleChannelInbound(req, undefined, 'token', 'asst-non-self');
+    const res = await handleChannelInbound(req, noopProcessMessage, 'token', 'asst-non-self');
     expect(res.status).toBe(200);
 
     const binding = db
@@ -2665,8 +2667,10 @@ describe('background channel processing approval prompts', () => {
     deliverPromptSpy.mockRestore();
   });
 
-  test('non-guardian channel turns are not interactive to prevent self-approval', async () => {
-    // Set up a guardian binding for a DIFFERENT user so the sender is non-guardian
+  test('trusted-contact channel turns with resolvable guardian route are interactive', async () => {
+    // Set up a guardian binding for a DIFFERENT user so the sender is a
+    // trusted contact (not the guardian). The guardian route is resolvable
+    // because the binding exists — approval notifications can be delivered.
     createBinding({
       assistantId: 'self',
       channel: 'telegram',
@@ -2701,7 +2705,9 @@ describe('background channel processing approval prompts', () => {
     await new Promise((resolve) => setTimeout(resolve, 300));
 
     expect(processCalls.length).toBeGreaterThan(0);
-    expect(processCalls[0].options?.isInteractive).toBe(false);
+    // Trusted contacts with a resolvable guardian route should be interactive
+    // so approval prompts can be routed to the guardian for decision.
+    expect(processCalls[0].options?.isInteractive).toBe(true);
   });
 
   test('unverified channel turns never broadcast approval prompts', async () => {
@@ -2869,3 +2875,118 @@ describe('NL approval routing via destination-scoped canonical requests', () =>
     expect(unchanged!.status).toBe('pending');
   });
 });
+
+// ═══════════════════════════════════════════════════════════════════════════
+// Trusted-contact self-approval guard (pre-row)
+// ═══════════════════════════════════════════════════════════════════════════
+
+describe('trusted-contact self-approval blocked before guardian approval row exists', () => {
+  beforeEach(() => {
+    // Create a guardian binding so the requester resolves as trusted_contact
+    createBinding({
+      assistantId: 'self',
+      channel: 'telegram',
+      guardianExternalUserId: 'guardian-tc-selfapproval',
+      guardianDeliveryChatId: 'guardian-tc-selfapproval-chat',
+    });
+  });
+
+  test('trusted contact cannot self-approve via conversational engine when no guardian approval row exists', async () => {
+    const deliverSpy = spyOn(gatewayClient, 'deliverChannelReply').mockResolvedValue(undefined);
+
+    // Create the requester conversation (different user than guardian)
+    const initReq = makeInboundRequest({
+      content: 'init',
+      externalChatId: 'tc-selfapproval-chat',
+      senderExternalUserId: 'tc-selfapproval-user',
+    });
+    await handleChannelInbound(initReq, noopProcessMessage, 'token');
+
+    const db = getDb();
+    const events = db.$client.prepare('SELECT conversation_id FROM channel_inbound_events').all() as Array<{ conversation_id: string }>;
+    const conversationId = events[0]?.conversation_id;
+    ensureConversation(conversationId!);
+
+    // Register a pending interaction — but do NOT create a guardian approval
+    // row in channelGuardianApprovalRequests. This simulates the window
+    // between the pending confirmation being created (isInteractive=true)
+    // and the guardian approval prompt being delivered.
+    const sessionMock = registerPendingInteraction('req-tc-selfapproval-1', conversationId!, 'shell');
+
+    deliverSpy.mockClear();
+
+    // The conversational engine would normally classify "yes" as approve_once,
+    // but the guard should intercept before the engine runs.
+    const mockConversationGenerator = mock(async (_ctx: unknown) => ({
+      disposition: 'approve_once' as const,
+      replyText: 'Approved!',
+    }));
+
+    // Trusted contact sends "yes" to try to self-approve
+    const req = makeInboundRequest({
+      content: 'yes',
+      externalChatId: 'tc-selfapproval-chat',
+      senderExternalUserId: 'tc-selfapproval-user',
+    });
+    const res = await handleChannelInbound(
+      req, noopProcessMessage, 'token', 'self', undefined,
+      undefined, mockConversationGenerator,
+    );
+    const body = await res.json() as Record<string, unknown>;
+
+    expect(body.accepted).toBe(true);
+    // Should be blocked with assistant_turn (pending guardian notice),
+    // NOT decision_applied
+    expect(body.approval).toBe('assistant_turn');
+    // The session should NOT have been resolved
+    expect(sessionMock).not.toHaveBeenCalled();
+
+    // The pending interaction should still be registered (not consumed)
+    const stillPending = pendingInteractions.get('req-tc-selfapproval-1');
+    expect(stillPending).toBeDefined();
+
+    deliverSpy.mockRestore();
+  });
+
+  test('trusted contact cannot self-approve via legacy parser when no guardian approval row exists', async () => {
+    const deliverSpy = spyOn(gatewayClient, 'deliverChannelReply').mockResolvedValue(undefined);
+
+    const initReq = makeInboundRequest({
+      content: 'init',
+      externalChatId: 'tc-selfapproval-chat',
+      senderExternalUserId: 'tc-selfapproval-user',
+    });
+    await handleChannelInbound(initReq, noopProcessMessage, 'token');
+
+    const db = getDb();
+    const events = db.$client.prepare('SELECT conversation_id FROM channel_inbound_events').all() as Array<{ conversation_id: string }>;
+    const conversationId = events[0]?.conversation_id;
+    ensureConversation(conversationId!);
+
+    // Register pending interaction without guardian approval row
+    const sessionMock = registerPendingInteraction('req-tc-selfapproval-2', conversationId!, 'shell');
+
+    deliverSpy.mockClear();
+
+    // No conversational engine — falls through to legacy parser path.
+    // "approve" would normally be parsed as an approval decision.
+    const req = makeInboundRequest({
+      content: 'approve',
+      externalChatId: 'tc-selfapproval-chat',
+      senderExternalUserId: 'tc-selfapproval-user',
+    });
+    const res = await handleChannelInbound(req, noopProcessMessage, 'token');
+    const body = await res.json() as Record<string, unknown>;
+
+    expect(body.accepted).toBe(true);
+    // Should be blocked, not decision_applied
+    expect(body.approval).toBe('assistant_turn');
+    expect(sessionMock).not.toHaveBeenCalled();
+
+    // Pending interaction should still exist
+    const stillPending = pendingInteractions.get('req-tc-selfapproval-2');
+    expect(stillPending).toBeDefined();
+
+    deliverSpy.mockRestore();
+  });
+});

package/src/__tests__/channel-guardian.test.ts

@@ -22,7 +22,6 @@ mock.module('../util/platform.js', () => ({
   getDbPath: () => join(testDir, 'test.db'),
   getLogPath: () => join(testDir, 'test.log'),
   ensureDataDir: () => {},
-  normalizeAssistantId: (id: string) => id === 'self' ? 'self' : id,
   readHttpToken: () => 'test-bearer-token',
 }));
 
@@ -1339,7 +1338,6 @@ describe('IPC handler channel-aware guardian status', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'telegram',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1359,7 +1357,6 @@ describe('IPC handler channel-aware guardian status', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'sms',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1385,7 +1382,6 @@ describe('IPC handler channel-aware guardian status', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'telegram',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1414,7 +1410,6 @@ describe('IPC handler channel-aware guardian status', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'telegram',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1458,34 +1453,6 @@ describe('IPC handler channel-aware guardian status', () => {
     expect(resp!.channel).toBe('sms');
   });
 
-  test('status action with custom assistantId returns correct value', () => {
-    createBinding({
-      assistantId: 'asst-custom',
-      channel: 'telegram',
-      guardianExternalUserId: 'user-77',
-      guardianDeliveryChatId: 'chat-77',
-    });
-
-    const { ctx, lastResponse } = createMockCtx();
-    const msg: GuardianVerificationRequest = {
-      type: 'guardian_verification',
-      action: 'status',
-      channel: 'telegram',
-      assistantId: 'asst-custom',
-    };
-
-    handleGuardianVerification(msg, mockSocket, ctx);
-
-    const resp = lastResponse();
-    expect(resp).not.toBeNull();
-    expect(resp!.success).toBe(true);
-    expect(resp!.bound).toBe(true);
-    expect(resp!.assistantId).toBe('asst-custom');
-    expect(resp!.channel).toBe('telegram');
-    expect(resp!.guardianExternalUserId).toBe('user-77');
-    expect(resp!.guardianDeliveryChatId).toBe('chat-77');
-  });
-
   test('status action for unbound sms does not return guardianDeliveryChatId', () => {
     const { ctx, lastResponse } = createMockCtx();
     const msg: GuardianVerificationRequest = {
@@ -1511,7 +1478,6 @@ describe('IPC handler channel-aware guardian status', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1528,7 +1494,6 @@ describe('IPC handler channel-aware guardian status', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1943,7 +1908,6 @@ describe('IPC handler voice guardian verification', () => {
       type: 'guardian_verification',
       action: 'create_challenge',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1964,7 +1928,6 @@ describe('IPC handler voice guardian verification', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -1990,7 +1953,6 @@ describe('IPC handler voice guardian verification', () => {
       type: 'guardian_verification',
       action: 'status',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -2017,7 +1979,6 @@ describe('IPC handler voice guardian verification', () => {
       type: 'guardian_verification',
       action: 'revoke',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -2050,7 +2011,6 @@ describe('IPC handler voice guardian verification', () => {
       type: 'guardian_verification',
       action: 'revoke',
       channel: 'voice',
-      assistantId: 'self',
     };
 
     handleGuardianVerification(msg, mockSocket, ctx);
@@ -2515,7 +2475,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     };
 
@@ -2552,7 +2511,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15559876543',
       rebind: false,
     };
@@ -2579,7 +2537,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15559876543',
       rebind: true,
     };
@@ -2599,7 +2556,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -2609,7 +2565,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'sms',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -2625,7 +2580,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -2643,7 +2597,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'sms',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -2660,7 +2613,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -2680,7 +2632,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'sms',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -2696,7 +2647,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -2710,7 +2660,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'cancel_outbound',
       channel: 'sms',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -2802,7 +2751,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'slack',
-      assistantId: 'self',
       destination: '@some_user',
     }, mockSocket, ctx);
 
@@ -2818,7 +2766,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       // no destination
     }, mockSocket, ctx);
 
@@ -2834,7 +2781,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: 'not-a-phone',
     }, mockSocket, ctx);
 
@@ -2850,7 +2796,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '(555) 123-4567',
     }, mockSocket, ctx);
 
@@ -2891,7 +2836,6 @@ describe('outbound SMS verification', () => {
       type: 'guardian_verification',
       action: 'cancel_outbound',
       channel: 'sms',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -2916,7 +2860,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '@someuser',
     }, mockSocket, ctx);
 
@@ -2946,7 +2889,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: 'someuser',
     }, mockSocket, ctx);
 
@@ -2963,7 +2905,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '123456789',
     }, mockSocket, ctx);
 
@@ -3001,7 +2942,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '@someuser',
     }, mockSocket, ctx);
 
@@ -3024,7 +2964,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '@newuser',
       rebind: false,
     }, mockSocket, ctx);
@@ -3195,7 +3134,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '123456789',
     }, mockSocket, startCtx);
 
@@ -3209,7 +3147,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'telegram',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3230,7 +3167,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '@someuser',
     }, mockSocket, startCtx);
 
@@ -3239,7 +3175,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'telegram',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3255,7 +3190,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '123456789',
     }, mockSocket, startCtx);
 
@@ -3267,7 +3201,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'cancel_outbound',
       channel: 'telegram',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3313,7 +3246,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3329,7 +3261,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '123456789',
     }, mockSocket, startCtx);
 
@@ -3349,7 +3280,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'telegram',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3365,7 +3295,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '123456789',
     }, mockSocket, startCtx);
 
@@ -3375,7 +3304,6 @@ describe('outbound Telegram verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'telegram',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3400,7 +3328,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, ctx);
 
@@ -3439,7 +3366,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: 'not-a-phone',
     }, mockSocket, ctx);
 
@@ -3455,7 +3381,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: '555-123-4567',
     }, mockSocket, ctx);
 
@@ -3495,7 +3420,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: '+15559876543',
       rebind: false,
     }, mockSocket, ctx);
@@ -3513,7 +3437,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -3523,7 +3446,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'voice',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3539,7 +3461,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -3549,7 +3470,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'cancel_outbound',
       channel: 'voice',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3587,7 +3507,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, ctx);
 
@@ -3603,7 +3522,6 @@ describe('outbound voice verification', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'voice',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3636,7 +3554,6 @@ describe('M1–M4 hardening coverage', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, ctx);
 
@@ -3657,7 +3574,6 @@ describe('M1–M4 hardening coverage', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'sms',
-      assistantId: 'self',
       destination: '+15551234567',
     }, mockSocket, startCtx);
 
@@ -3672,7 +3588,6 @@ describe('M1–M4 hardening coverage', () => {
       type: 'guardian_verification',
       action: 'resend_outbound',
       channel: 'sms',
-      assistantId: 'self',
     }, mockSocket, ctx);
 
     const resp = lastResponse();
@@ -3691,7 +3606,6 @@ describe('M1–M4 hardening coverage', () => {
       type: 'guardian_verification',
       action: 'start_outbound',
       channel: 'telegram',
-      assistantId: 'self',
       destination: '@someuser',
     }, mockSocket, ctx);