@vellumai/assistant 0.4.2 → 0.4.4

package/src/__tests__/notification-decision-strategy.test.ts

@@ -55,21 +55,67 @@ describe('notification decision strategy', () => {
       expect(copy.vellum!.body).toContain('What is the gate code?');
     });
 
-    test('guardian.question template includes request-code instructions when present', () => {
+    test('guardian.question template includes free-text answer instructions when requestCode is present', () => {
       const signal = makeSignal({
         sourceEventName: 'guardian.question',
         contextPayload: {
+          requestId: 'req-pending-1',
           questionText: 'What is the gate code?',
           requestCode: 'A1B2C3',
+          requestKind: 'pending_question',
+          callSessionId: 'call-1',
+          activeGuardianRequestCount: 1,
         },
       });
 
       const copy = composeFallbackCopy(signal, channels);
       expect(copy.vellum).toBeDefined();
       expect(copy.vellum!.body).toContain('A1B2C3');
+      expect(copy.vellum!.body).toContain('<your answer>');
+      expect(copy.vellum!.body).not.toContain('approve');
+      expect(copy.vellum!.body).not.toContain('reject');
+      expect(copy.telegram!.deliveryText).toContain('A1B2C3');
+    });
+
+    test('guardian.question template uses approve/reject instructions for approval-kind request', () => {
+      const signal = makeSignal({
+        sourceEventName: 'guardian.question',
+        contextPayload: {
+          requestId: 'req-grant-1',
+          questionText: 'Allow running host_bash?',
+          requestCode: 'D4E5F6',
+          requestKind: 'tool_grant_request',
+          toolName: 'host_bash',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      expect(copy.vellum!.body).toContain('D4E5F6');
       expect(copy.vellum!.body).toContain('approve');
       expect(copy.vellum!.body).toContain('reject');
-      expect(copy.telegram!.deliveryText).toContain('A1B2C3');
+    });
+
+    test('guardian.question template uses approve/reject for tool-backed pending_question payloads', () => {
+      const signal = makeSignal({
+        sourceEventName: 'guardian.question',
+        contextPayload: {
+          requestId: 'req-voice-tool-1',
+          questionText: 'Allow send_email to bob@example.com?',
+          requestCode: 'A1B2C3',
+          requestKind: 'pending_question',
+          callSessionId: 'call-1',
+          activeGuardianRequestCount: 1,
+          toolName: 'send_email',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      expect(copy.vellum!.body).toContain('A1B2C3');
+      expect(copy.vellum!.body).toContain('approve');
+      expect(copy.vellum!.body).toContain('reject');
+      expect(copy.vellum!.body).not.toContain('<your answer>');
     });
 
     test('reminder.fired template uses message from payload', () => {
@@ -196,6 +242,64 @@ describe('notification decision strategy', () => {
       expect(copy.vellum!.body).toContain('open invite flow');
     });
 
+    test('ingress.access_request template includes revoked-member context when provided', () => {
+      const signal = makeSignal({
+        sourceEventName: 'ingress.access_request',
+        contextPayload: {
+          senderIdentifier: 'Charlie',
+          previousMemberStatus: 'revoked',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      expect(copy.vellum!.body).toContain('previously revoked');
+    });
+
+    test('ingress.access_request template includes caller name for voice-originated requests', () => {
+      // In production, senderIdentifier resolves to senderName for voice
+      // calls (senderName || senderUsername || senderExternalUserId), so
+      // both values are the caller's name. The phone number arrives via
+      // senderExternalUserId and should appear in the parenthetical.
+      const signal = makeSignal({
+        sourceEventName: 'ingress.access_request',
+        contextPayload: {
+          senderIdentifier: 'Alice Smith',
+          senderName: 'Alice Smith',
+          senderExternalUserId: '+15559998888',
+          sourceChannel: 'voice',
+          requestCode: 'V1C2E3',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      expect(copy.vellum!.title).toBe('Access Request');
+      // Voice-originated requests should include the caller name and phone number in parentheses
+      expect(copy.vellum!.body).toContain('Alice Smith');
+      expect(copy.vellum!.body).toContain('(+15559998888)');
+      expect(copy.vellum!.body).toContain('calling');
+    });
+
+    test('ingress.access_request template falls back to non-voice copy when sourceChannel is not voice', () => {
+      const signal = makeSignal({
+        sourceEventName: 'ingress.access_request',
+        contextPayload: {
+          senderIdentifier: 'user-123',
+          senderName: 'Bob Jones',
+          sourceChannel: 'telegram',
+          requestCode: 'T1G2M3',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      // Non-voice should use the standard "requesting access" text, not "calling"
+      expect(copy.vellum!.body).toContain('user-123');
+      expect(copy.vellum!.body).toContain('requesting access');
+      expect(copy.vellum!.body).not.toContain('calling');
+    });
+
     test('ingress.access_request Telegram deliveryText is concise', () => {
       const signal = makeSignal({
         sourceEventName: 'ingress.access_request',

package/src/__tests__/notification-guardian-path.test.ts

@@ -181,6 +181,9 @@ describe('ASK_GUARDIAN canonical notification path', () => {
     const payload = signalParams.contextPayload as Record<string, unknown>;
     expect(payload.questionText).toBe('What is the gate code?');
     expect(payload.callSessionId).toBe(session.id);
+    expect(payload.requestKind).toBe('pending_question');
+    expect(payload.toolName).toBeUndefined();
+    expect(payload.pendingQuestionId).toBeUndefined();
     expect(payload.requestId).toBeDefined();
     expect(payload.requestCode).toBeDefined();
   });

package/src/__tests__/recording-intent-handler.test.ts

@@ -391,6 +391,7 @@ function createCtx(overrides?: Partial<HandlerContext>): {
     setChannelCapabilities: noop,
     setGuardianContext: noop,
     setCommandIntent: noop,
+    updateClient: noop,
     processMessage: async () => {},
     getQueueDepth: () => 0,
     setPreactivatedSkillIds: noop,