@vellumai/assistant 0.3.4 → 0.3.6

package/src/__tests__/channel-approval.test.ts

@@ -195,6 +195,43 @@ describe('parseApprovalDecision', () => {
   ])('returns null for non-matching text: "%s"', (input) => {
     expect(parseApprovalDecision(input)).toBeNull();
   });
+
+  // ── Run-reference tag extraction ────────────────────────────────
+
+  test('extracts runId from [ref:...] tag with approve decision', () => {
+    const result = parseApprovalDecision('yes [ref:run-abc-123]');
+    expect(result).not.toBeNull();
+    expect(result!.action).toBe('approve_once');
+    expect(result!.source).toBe('plain_text');
+    expect(result!.runId).toBe('run-abc-123');
+  });
+
+  test('extracts runId from [ref:...] tag with reject decision', () => {
+    const result = parseApprovalDecision('no [ref:run-xyz-456]');
+    expect(result).not.toBeNull();
+    expect(result!.action).toBe('reject');
+    expect(result!.runId).toBe('run-xyz-456');
+  });
+
+  test('extracts runId from [ref:...] tag with always decision', () => {
+    const result = parseApprovalDecision('always [ref:run-789]');
+    expect(result).not.toBeNull();
+    expect(result!.action).toBe('approve_always');
+    expect(result!.runId).toBe('run-789');
+  });
+
+  test('handles ref tag on separate line', () => {
+    const result = parseApprovalDecision('yes\n[ref:run-abc-123]');
+    expect(result).not.toBeNull();
+    expect(result!.action).toBe('approve_once');
+    expect(result!.runId).toBe('run-abc-123');
+  });
+
+  test('decision without ref tag has no runId', () => {
+    const result = parseApprovalDecision('yes');
+    expect(result).not.toBeNull();
+    expect(result!.runId).toBeUndefined();
+  });
 });
 
 // ═══════════════════════════════════════════════════════════════════════════

package/src/__tests__/channel-approvals.test.ts

@@ -40,7 +40,7 @@ import {
   getChannelApprovalPrompt,
   buildApprovalUIMetadata,
   handleChannelDecision,
-  buildReminderPrompt,
+  buildGuardianApprovalPrompt,
   channelSupportsRichApprovalUI,
 } from '../runtime/channel-approvals.js';
 import type { ApprovalDecisionResult, ChannelApprovalPrompt } from '../runtime/channel-approval-types.js';
@@ -487,62 +487,48 @@ describe('handleChannelDecision', () => {
 });
 
 // ═══════════════════════════════════════════════════════════════════════════
-// 4. buildReminderPrompt
+// 4. buildGuardianApprovalPrompt
 // ═══════════════════════════════════════════════════════════════════════════
 
-describe('buildReminderPrompt', () => {
-  test('prefixes promptText with a reminder', () => {
-    const original: ChannelApprovalPrompt = {
-      promptText: 'Allow shell?',
-      actions: [
-        { id: 'approve_once', label: 'Approve once' },
-        { id: 'reject', label: 'Reject' },
-      ],
-      plainTextFallback: 'Reply yes or no.',
-    };
-
-    const reminder = buildReminderPrompt(original);
-    expect(reminder.promptText).toContain("I'm still waiting");
-    expect(reminder.promptText).toContain('Allow shell?');
-  });
-
-  test('preserves the original actions', () => {
-    const original: ChannelApprovalPrompt = {
-      promptText: 'Approve file_edit?',
-      actions: [
-        { id: 'approve_once', label: 'Approve once' },
-        { id: 'approve_always', label: 'Approve always' },
-        { id: 'reject', label: 'Reject' },
-      ],
-      plainTextFallback: 'Reply yes, always, or no.',
+describe('buildGuardianApprovalPrompt', () => {
+  test('prompt includes requester identifier and tool name', () => {
+    const runInfo: PendingRunInfo = {
+      runId: 'run-g1',
+      requestId: 'req-g1',
+      toolName: 'deploy',
+      input: {},
+      riskLevel: 'high',
     };
-
-    const reminder = buildReminderPrompt(original);
-    expect(reminder.actions).toEqual(original.actions);
+    const prompt = buildGuardianApprovalPrompt(runInfo, 'alice');
+    expect(prompt.promptText).toContain('alice');
+    expect(prompt.promptText).toContain('deploy');
   });
 
-  test('prefixes plainTextFallback with a reminder', () => {
-    const original: ChannelApprovalPrompt = {
-      promptText: 'Allow bash?',
-      actions: [],
-      plainTextFallback: 'Reply yes or no.',
+  test('excludes approve_always action', () => {
+    const runInfo: PendingRunInfo = {
+      runId: 'run-g2',
+      requestId: 'req-g2',
+      toolName: 'shell',
+      input: {},
+      riskLevel: 'medium',
     };
-
-    const reminder = buildReminderPrompt(original);
-    expect(reminder.plainTextFallback).toContain("I'm still waiting");
-    expect(reminder.plainTextFallback).toContain('Reply yes or no.');
+    const prompt = buildGuardianApprovalPrompt(runInfo, 'bob');
+    expect(prompt.actions.map((a) => a.id)).not.toContain('approve_always');
+    expect(prompt.actions.map((a) => a.id)).toContain('approve_once');
+    expect(prompt.actions.map((a) => a.id)).toContain('reject');
   });
 
-  test('does not mutate the original prompt', () => {
-    const original: ChannelApprovalPrompt = {
-      promptText: 'Allow grep?',
-      actions: [{ id: 'approve_once', label: 'Approve once' }],
-      plainTextFallback: 'Reply yes.',
+  test('plainTextFallback contains parser-compatible keywords', () => {
+    const runInfo: PendingRunInfo = {
+      runId: 'run-g3',
+      requestId: 'req-g3',
+      toolName: 'write_file',
+      input: {},
+      riskLevel: 'high',
     };
-
-    const originalText = original.promptText;
-    buildReminderPrompt(original);
-    expect(original.promptText).toBe(originalText);
+    const prompt = buildGuardianApprovalPrompt(runInfo, 'charlie');
+    expect(prompt.plainTextFallback).toContain('yes');
+    expect(prompt.plainTextFallback).toContain('no');
   });
 });
 
@@ -555,8 +541,8 @@ describe('channelSupportsRichApprovalUI', () => {
     expect(channelSupportsRichApprovalUI('telegram')).toBe(true);
   });
 
-  test('returns false for http-api', () => {
-    expect(channelSupportsRichApprovalUI('http-api')).toBe(false);
+  test('returns false for macos', () => {
+    expect(channelSupportsRichApprovalUI('macos')).toBe(false);
   });
 
   test('returns false for sms', () => {