@vellumai/assistant 0.3.4 → 0.3.6

package/src/__tests__/run-orchestrator-assistant-events.test.ts

@@ -68,6 +68,9 @@ function makeSessionEmittingViaClient(...messages: ServerMessage[]): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: (handler: (msg: ServerMessage) => void) => {
       clientHandler = handler;
     },
@@ -90,6 +93,9 @@ function makeSessionEmittingViaAgentLoop(...messages: ServerMessage[]): Session
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async (_content: string, _messageId: string, onEvent: (msg: ServerMessage) => void) => {
       for (const msg of messages) {

package/src/__tests__/run-orchestrator.test.ts

@@ -26,6 +26,12 @@ mock.module('../util/logger.js', () => ({
   }),
 }));
 
+mock.module('../config/loader.js', () => ({
+  getConfig: () => ({
+    secretDetection: { enabled: false },
+  }),
+}));
+
 import { initializeDb, getDb, resetDb } from '../memory/db.js';
 import { createConversation } from '../memory/conversation-store.js';
 import { createRun, getRun, setRunConfirmation } from '../memory/runs-store.js';
@@ -43,6 +49,10 @@ function makeSessionWithConfirmation(message: ServerMessage): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
     updateClient: (handler: (msg: ServerMessage) => void) => {
       clientHandler = handler;
     },
@@ -64,6 +74,10 @@ function makeSessionWithEvent(message: ServerMessage): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
     updateClient: () => {},
     runAgentLoop: async (_content: string, _messageId: string, onEvent: (msg: ServerMessage) => void) => {
       onEvent(message);
@@ -228,6 +242,10 @@ describe('startRun channel capability resolution', () => {
       setChannelCapabilities: (caps: ChannelCapabilities | null) => {
         if (caps) capturedCapabilities = caps;
       },
+      setAssistantId: () => {},
+      setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
       updateClient: () => {},
       runAgentLoop: async () => {},
       handleConfirmationResponse: () => {},
@@ -251,7 +269,7 @@ describe('startRun channel capability resolution', () => {
     expect(capturedCapabilities!.dashboardCapable).toBe(false);
   });
 
-  test('defaults to http-api when no sourceChannel is provided', async () => {
+  test('defaults to macos (from http-api fallback) when no sourceChannel is provided', async () => {
     const conversation = createConversation('http-api default test');
     let capturedCapabilities: ChannelCapabilities | null = null;
 
@@ -262,6 +280,10 @@ describe('startRun channel capability resolution', () => {
       setChannelCapabilities: (caps: ChannelCapabilities | null) => {
         if (caps) capturedCapabilities = caps;
       },
+      setAssistantId: () => {},
+      setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
       updateClient: () => {},
       runAgentLoop: async () => {},
       handleConfirmationResponse: () => {},
@@ -278,10 +300,10 @@ describe('startRun channel capability resolution', () => {
     await new Promise((r) => setTimeout(r, 50));
 
     expect(capturedCapabilities).not.toBeNull();
-    expect(capturedCapabilities!.channel).toBe('http-api');
+    expect(capturedCapabilities!.channel).toBe('macos');
   });
 
-  test('defaults to http-api when options are provided without sourceChannel', async () => {
+  test('defaults to macos (from http-api fallback) when options are provided without sourceChannel', async () => {
     const conversation = createConversation('options no channel test');
     let capturedCapabilities: ChannelCapabilities | null = null;
 
@@ -292,6 +314,10 @@ describe('startRun channel capability resolution', () => {
       setChannelCapabilities: (caps: ChannelCapabilities | null) => {
         if (caps) capturedCapabilities = caps;
       },
+      setAssistantId: () => {},
+      setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
       updateClient: () => {},
       runAgentLoop: async () => {},
       handleConfirmationResponse: () => {},
@@ -310,7 +336,7 @@ describe('startRun channel capability resolution', () => {
     await new Promise((r) => setTimeout(r, 50));
 
     expect(capturedCapabilities).not.toBeNull();
-    expect(capturedCapabilities!.channel).toBe('http-api');
+    expect(capturedCapabilities!.channel).toBe('macos');
   });
 });
 
@@ -335,6 +361,10 @@ describe('strictSideEffects re-derivation across runs', () => {
       persistUserMessage: () => undefined as unknown as string,
       memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
       setChannelCapabilities: () => {},
+      setAssistantId: () => {},
+      setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
       updateClient: () => {},
       runAgentLoop: async () => {},
       handleConfirmationResponse: () => {},
@@ -369,6 +399,10 @@ describe('strictSideEffects re-derivation across runs', () => {
       persistUserMessage: () => undefined as unknown as string,
       memoryPolicy: { scopeId: 'private-scope', includeDefaultFallback: true, strictSideEffects: true },
       setChannelCapabilities: () => {},
+      setAssistantId: () => {},
+      setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
       updateClient: () => {},
       runAgentLoop: async () => {},
       handleConfirmationResponse: () => {},
@@ -404,6 +438,10 @@ describe('strictSideEffects re-derivation across runs', () => {
       persistUserMessage: () => undefined as unknown as string,
       memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: true },
       setChannelCapabilities: () => {},
+      setAssistantId: () => {},
+      setGuardianContext: () => {},
+    setCommandIntent: () => {},
+    setTurnChannelContext: () => {},
       updateClient: () => {},
       runAgentLoop: async () => {},
       handleConfirmationResponse: () => {},

package/src/__tests__/runtime-runs-http.test.ts

@@ -60,6 +60,9 @@ function makeCompletingSession(): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -67,6 +70,7 @@ function makeCompletingSession(): Session {
       processing = false;
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -76,11 +80,15 @@ function makeFailingSession(errorMsg: string): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async (_content: string, _messageId: string, onEvent: (msg: ServerMessage) => void) => {
       onEvent({ type: 'error', message: errorMsg });
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -91,6 +99,9 @@ function makeConfirmationSession(toolName: string): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: (handler: (msg: ServerMessage) => void) => {
       clientHandler = handler;
     },
@@ -108,6 +119,7 @@ function makeConfirmationSession(toolName: string): Session {
       await new Promise<void>(() => {});
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -118,12 +130,16 @@ function makeHangingSession(): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
       await new Promise<void>(() => {});
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -207,7 +223,7 @@ describe('runtime runs — HTTP layer', () => {
 
     const body = await res.json() as { status: string; disk: { path: string; totalMb: number; usedMb: number; freeMb: number } | null };
     expect(body.status).toBe('healthy');
-    if (body.disk !== null) {
+    if (body.disk != null) {
       expect(typeof body.disk.path).toBe('string');
       expect(body.disk.totalMb).toBeGreaterThan(0);
       expect(body.disk.usedMb).toBeGreaterThanOrEqual(0);

package/src/__tests__/runtime-runs.test.ts

@@ -50,6 +50,9 @@ function makeCompletingSession(): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -58,6 +61,7 @@ function makeCompletingSession(): Session {
       processing = false;
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -69,6 +73,9 @@ function makeHangingSession(): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async () => {
       processing = true;
@@ -76,6 +83,7 @@ function makeHangingSession(): Session {
       await new Promise<void>(() => {});
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -86,11 +94,15 @@ function makeFailingSession(errorMsg: string): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: () => {},
     runAgentLoop: async (_content: string, _messageId: string, onEvent: (msg: ServerMessage) => void) => {
       onEvent({ type: 'error', message: errorMsg });
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 
@@ -102,6 +114,9 @@ function makeConfirmationSession(toolName: string): Session {
     persistUserMessage: () => undefined as unknown as string,
     memoryPolicy: { scopeId: 'default', includeDefaultFallback: false, strictSideEffects: false },
     setChannelCapabilities: () => {},
+    setAssistantId: () => {},
+    setGuardianContext: () => {},
+    setCommandIntent: () => {},
     updateClient: (handler: (msg: ServerMessage) => void) => {
       clientHandler = handler;
     },
@@ -119,6 +134,7 @@ function makeConfirmationSession(toolName: string): Session {
       await new Promise<void>(() => {});
     },
     handleConfirmationResponse: () => {},
+    handleSecretResponse: () => {},
   } as unknown as Session;
 }
 

package/src/__tests__/schedule-store.test.ts

@@ -24,6 +24,8 @@ mock.module('../util/logger.js', () => ({
   getLogger: () => new Proxy({} as Record<string, unknown>, {
     get: () => () => {},
   }),
+  isDebug: () => false,
+  truncateForLog: (value: string) => value,
 }));
 
 import { initializeDb, getDb, resetDb } from '../memory/db.js';
@@ -259,10 +261,18 @@ describe('claimDueSchedules (RRULE set)', () => {
   });
 
   test('claims RRULE set schedule and correctly advances nextRunAt past exclusions', () => {
+    // Use a recent DTSTART (1 hour ago) so rrule doesn't iterate through hundreds of
+    // thousands of occurrences when computing the next run.
+    const pastDate = new Date(Date.now() - 3_600_000);
+    const pad = (n: number) => String(n).padStart(2, '0');
+    const ds = `${pastDate.getUTCFullYear()}${pad(pastDate.getUTCMonth() + 1)}${pad(pastDate.getUTCDate())}T${pad(pastDate.getUTCHours())}${pad(pastDate.getUTCMinutes())}${pad(pastDate.getUTCSeconds())}Z`;
+    // Exclude the 2nd minute after DTSTART (safely in the past, won't block the next run)
+    const exMinute = new Date(pastDate.getTime() + 60_000);
+    const exDs = `${exMinute.getUTCFullYear()}${pad(exMinute.getUTCMonth() + 1)}${pad(exMinute.getUTCDate())}T${pad(exMinute.getUTCHours())}${pad(exMinute.getUTCMinutes())}${pad(pastDate.getUTCSeconds())}Z`;
     const expression = [
-      'DTSTART:20250101T000000Z',
+      `DTSTART:${ds}`,
       'RRULE:FREQ=MINUTELY;INTERVAL=1',
-      'EXDATE:20250101T000100Z',
+      `EXDATE:${exDs}`,
     ].join('\n');
 
     const job = createSchedule({
@@ -400,8 +410,12 @@ describe('claimDueSchedules', () => {
   });
 
   test('claims due RRULE schedules and advances nextRunAt', () => {
-    // Use an RRULE that fires every minute (roughly), with a DTSTART in the past
-    const rrule = 'DTSTART:20250101T000000Z\nRRULE:FREQ=MINUTELY;INTERVAL=1';
+    // Use a recent DTSTART (1 hour ago) so rrule doesn't iterate through
+    // hundreds of thousands of occurrences when computing the next run.
+    const pastDate = new Date(Date.now() - 3_600_000);
+    const pad = (n: number) => String(n).padStart(2, '0');
+    const ds = `${pastDate.getUTCFullYear()}${pad(pastDate.getUTCMonth() + 1)}${pad(pastDate.getUTCDate())}T${pad(pastDate.getUTCHours())}${pad(pastDate.getUTCMinutes())}${pad(pastDate.getUTCSeconds())}Z`;
+    const rrule = `DTSTART:${ds}\nRRULE:FREQ=MINUTELY;INTERVAL=1`;
     const job = createSchedule({
       name: 'Claim RRULE',
       cronExpression: rrule,

package/src/__tests__/scheduler-recurrence.test.ts

@@ -23,6 +23,8 @@ mock.module('../util/logger.js', () => ({
   getLogger: () => new Proxy({} as Record<string, unknown>, {
     get: () => () => {},
   }),
+  isDebug: () => false,
+  truncateForLog: (value: string) => value,
 }));
 
 import { initializeDb, getDb, resetDb } from '../memory/db.js';
@@ -252,8 +254,8 @@ describe('scheduler RRULE execution', () => {
     const currentMinuteDate = new Date(now);
     currentMinuteDate.setUTCSeconds(0);
     currentMinuteDate.setUTCMilliseconds(0);
-    // Round to the previous minute boundary relative to dtstart
-    const exDate = `${currentMinuteDate.getUTCFullYear()}${pad(currentMinuteDate.getUTCMonth() + 1)}${pad(currentMinuteDate.getUTCDate())}T${pad(currentMinuteDate.getUTCHours())}${pad(currentMinuteDate.getUTCMinutes())}00Z`;
+    // Seconds must match DTSTART so the EXDATE aligns with a recurrence instance
+    const exDate = `${currentMinuteDate.getUTCFullYear()}${pad(currentMinuteDate.getUTCMonth() + 1)}${pad(currentMinuteDate.getUTCDate())}T${pad(currentMinuteDate.getUTCHours())}${pad(currentMinuteDate.getUTCMinutes())}${pad(pastDate.getUTCSeconds())}Z`;
 
     const expression = `DTSTART:${ds}\nRRULE:FREQ=MINUTELY;INTERVAL=1\nEXDATE:${exDate}`;
 
@@ -286,10 +288,17 @@ describe('scheduler RRULE execution', () => {
   });
 
   test('RRULE set schedule fires and creates cron_runs entry', async () => {
+    // Use a recent DTSTART (1 hour ago) so rrule doesn't iterate through hundreds of
+    // thousands of occurrences when computing the next run.
+    const pastDate = new Date(Date.now() - 3_600_000);
+    const pad = (n: number) => String(n).padStart(2, '0');
+    const ds = `${pastDate.getUTCFullYear()}${pad(pastDate.getUTCMonth() + 1)}${pad(pastDate.getUTCDate())}T${pad(pastDate.getUTCHours())}${pad(pastDate.getUTCMinutes())}${pad(pastDate.getUTCSeconds())}Z`;
+    const exMinute = new Date(pastDate.getTime() + 60_000);
+    const exDs = `${exMinute.getUTCFullYear()}${pad(exMinute.getUTCMonth() + 1)}${pad(exMinute.getUTCDate())}T${pad(exMinute.getUTCHours())}${pad(exMinute.getUTCMinutes())}${pad(exMinute.getUTCSeconds())}Z`;
     const expression = [
-      'DTSTART:20250101T000000Z',
+      `DTSTART:${ds}`,
       'RRULE:FREQ=MINUTELY;INTERVAL=1',
-      'EXDATE:20250101T000100Z',
+      `EXDATE:${exDs}`,
     ].join('\n');
 
     const schedule = createSchedule({

package/src/__tests__/session-abort-tool-results.test.ts

@@ -11,6 +11,12 @@ mock.module('../util/platform.js', () => ({
   getDataDir: () => '/tmp',
 }));
 
+mock.module('../memory/guardian-action-store.js', () => ({
+  getPendingDeliveryByConversation: () => null,
+  getGuardianActionRequest: () => null,
+  resolveGuardianActionRequest: () => {},
+}));
+
 mock.module('../providers/registry.js', () => ({
   getProvider: () => ({ name: 'mock-provider' }),
   initializeProviders: () => {},