@vellumai/assistant 0.11.4 → 0.11.5-dev.202608220019.a778cf0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (457) hide show
  1. package/AGENTS.md +6 -2
  2. package/ARCHITECTURE.md +29 -4
  3. package/README.md +1 -1
  4. package/docs/architecture/memory.md +17 -5
  5. package/docs/architecture/security.md +96 -152
  6. package/docs/guardian-request-flow.md +13 -2
  7. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/package.json +1 -0
  8. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/__tests__/ingress.test.ts +118 -0
  9. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/__tests__/url-normalization.test.ts +135 -0
  10. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  11. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/ingress.ts +103 -0
  12. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/url-normalization.ts +107 -0
  13. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/package.json +1 -0
  14. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/__tests__/ingress.test.ts +118 -0
  15. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/__tests__/url-normalization.test.ts +135 -0
  16. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  17. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/ingress.ts +103 -0
  18. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/url-normalization.ts +107 -0
  19. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +166 -1
  20. package/node_modules/@vellumai/gateway-client/src/http-delivery.ts +7 -14
  21. package/node_modules/@vellumai/gateway-client/src/index.ts +2 -0
  22. package/node_modules/@vellumai/gateway-client/src/outbound-contract.ts +30 -32
  23. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  24. package/node_modules/@vellumai/service-contracts/src/__tests__/ingress.test.ts +118 -0
  25. package/node_modules/@vellumai/service-contracts/src/__tests__/url-normalization.test.ts +135 -0
  26. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  27. package/node_modules/@vellumai/service-contracts/src/ingress.ts +103 -0
  28. package/node_modules/@vellumai/service-contracts/src/url-normalization.ts +107 -0
  29. package/openapi.yaml +487 -11
  30. package/package.json +1 -1
  31. package/scripts/sync-web-search-catalog.ts +6 -0
  32. package/src/__tests__/anthropic-provider.test.ts +10 -3
  33. package/src/__tests__/approval-interception-trust-gates.test.ts +40 -0
  34. package/src/__tests__/background-workers-disk-pressure.test.ts +1 -1
  35. package/src/__tests__/channel-approval-routes.test.ts +4 -0
  36. package/src/__tests__/channel-inbound-disk-pressure.test.ts +5 -6
  37. package/src/__tests__/channel-readiness-service.test.ts +126 -0
  38. package/src/__tests__/channel-reply-delivery.test.ts +30 -17
  39. package/src/__tests__/checker.test.ts +20 -314
  40. package/src/__tests__/cli-memory-v2-reembed-skills.test.ts +6 -2
  41. package/src/__tests__/client-os-metadata-persistence.test.ts +16 -0
  42. package/src/__tests__/compactor-retained-image-validation.test.ts +142 -0
  43. package/src/__tests__/config-loader-backfill.test.ts +19 -10
  44. package/src/__tests__/container-cpu-sampler.test.ts +153 -0
  45. package/src/__tests__/context-search-memory-v2-source.test.ts +0 -1
  46. package/src/__tests__/conversation-attachments.test.ts +0 -1
  47. package/src/__tests__/conversation-delete-watch-timeline.test.ts +231 -0
  48. package/src/__tests__/conversation-error.test.ts +17 -0
  49. package/src/__tests__/conversation-lifecycle.test.ts +20 -26
  50. package/src/__tests__/conversation-pairing.test.ts +186 -0
  51. package/src/__tests__/conversation-runtime-assembly.test.ts +21 -2
  52. package/src/__tests__/credential-broker-server-use.test.ts +24 -5
  53. package/src/__tests__/credential-routes.test.ts +22 -3
  54. package/src/__tests__/credential-security-invariants.test.ts +2 -1
  55. package/src/__tests__/daemon-credential-client.test.ts +88 -0
  56. package/src/__tests__/default-plugin-names-guard.test.ts +12 -1
  57. package/src/__tests__/dm-backfill.test.ts +63 -0
  58. package/src/__tests__/dynamic-skill-background-guard.test.ts +0 -2
  59. package/src/__tests__/edit-propagation.test.ts +107 -4
  60. package/src/__tests__/events-client-registration.test.ts +28 -0
  61. package/src/__tests__/file-write-tool.test.ts +4 -2
  62. package/src/__tests__/guardian-prompt-notice-privacy.test.ts +133 -0
  63. package/src/__tests__/guardian-verify-setup-skill-regression.test.ts +143 -97
  64. package/src/__tests__/helpers/gateway-classify-mock.ts +27 -6
  65. package/src/__tests__/host-proxy-interface.test.ts +11 -1
  66. package/src/__tests__/host-shell-tool.test.ts +23 -4
  67. package/src/__tests__/image-conversion.test.ts +143 -1
  68. package/src/__tests__/inline-skill-load-permissions.test.ts +47 -36
  69. package/src/__tests__/input-repairs.test.ts +207 -0
  70. package/src/__tests__/live-workspace-guard.test.ts +75 -0
  71. package/src/__tests__/managed-profile-guard.test.ts +4 -2
  72. package/src/__tests__/mcp-abort-signal.test.ts +1 -1
  73. package/src/__tests__/mcp-client-auth.test.ts +1 -1
  74. package/src/__tests__/mcp-tool-annotations-risk.test.ts +1 -1
  75. package/src/__tests__/media-resolve-image-validation.test.ts +310 -0
  76. package/src/__tests__/mtime-cache.test.ts +2 -0
  77. package/src/__tests__/notification-vellum-adapter.test.ts +124 -1
  78. package/src/__tests__/openai-provider.test.ts +40 -0
  79. package/src/__tests__/openai-responses-provider.test.ts +18 -0
  80. package/src/__tests__/personal-memory-auth-bypass.test.ts +22 -6
  81. package/src/__tests__/platform-bash-auto-approve.test.ts +0 -4
  82. package/src/__tests__/platform.test.ts +16 -1
  83. package/src/__tests__/plugin-api-resolve-credential.test.ts +22 -13
  84. package/src/__tests__/plugin-api-shim.test.ts +5 -0
  85. package/src/__tests__/plugin-api-store-credential.test.ts +268 -0
  86. package/src/__tests__/plugin-config-data-migration.test.ts +8 -1
  87. package/src/__tests__/plugin-disabled-state.test.ts +2 -0
  88. package/src/__tests__/plugin-effective-enabled-set.test.ts +55 -3
  89. package/src/__tests__/plugin-execution-context.test.ts +73 -0
  90. package/src/__tests__/plugin-import-boundary-guard.test.ts +0 -1
  91. package/src/__tests__/plugin-import-boundary-reverse-guard.test.ts +0 -1
  92. package/src/__tests__/reaction-persistence.test.ts +200 -7
  93. package/src/__tests__/require-fresh-approval.test.ts +0 -4
  94. package/src/__tests__/resource-pressure-guard.test.ts +428 -0
  95. package/src/__tests__/resource-pressure-routes.test.ts +113 -0
  96. package/src/__tests__/risk-classification-boundary-guard.test.ts +115 -0
  97. package/src/__tests__/run-conversation-turn-persistence.test.ts +27 -1
  98. package/src/__tests__/sanitize-config-for-transfer.test.ts +28 -0
  99. package/src/__tests__/secret-routes-platform-proxy.test.ts +7 -0
  100. package/src/__tests__/settings-routes.test.ts +85 -3
  101. package/src/__tests__/skill-tool-factory.test.ts +161 -0
  102. package/src/__tests__/tool-execution-pipeline.benchmark.test.ts +1 -1
  103. package/src/__tests__/tool-executor-lifecycle-events.test.ts +132 -5
  104. package/src/__tests__/tool-executor.test.ts +63 -38
  105. package/src/__tests__/tool-policy.test.ts +97 -1
  106. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +7 -4
  107. package/src/__tests__/user-plugin-loader.test.ts +2 -0
  108. package/src/__tests__/validate-input.test.ts +243 -7
  109. package/src/__tests__/verification-control-plane-policy.test.ts +0 -2
  110. package/src/__tests__/voice-scoped-grant-consumer.test.ts +2 -0
  111. package/src/__tests__/voice-session-bridge.test.ts +42 -0
  112. package/src/__tests__/web-search-catalog-parity.test.ts +8 -0
  113. package/src/acp/__tests__/acp-claude-oauth.test.ts +97 -29
  114. package/src/acp/__tests__/prepare-agent-env.test.ts +376 -153
  115. package/src/acp/acp-claude-oauth.ts +38 -21
  116. package/src/acp/prepare-agent-env.ts +146 -55
  117. package/src/agent/loop-tool-dedup.test.ts +161 -0
  118. package/src/agent/loop.ts +68 -22
  119. package/src/api/constants/app-tools.ts +34 -0
  120. package/src/api/constants/profile-config-validation.ts +60 -0
  121. package/src/api/events/resource-pressure-status-changed.ts +53 -0
  122. package/src/api/events/tool-result.ts +6 -1
  123. package/src/api/events/watch-retro-completed.ts +52 -0
  124. package/src/api/index.ts +30 -0
  125. package/src/api/responses/resource-pressure-status.ts +25 -0
  126. package/src/approvals/guardian-channel-delivery.ts +70 -6
  127. package/src/approvals/guardian-request-resolvers.ts +32 -66
  128. package/src/calls/__tests__/voice-session-bridge.test.ts +114 -0
  129. package/src/calls/voice-session-bridge.ts +60 -6
  130. package/src/channels/__tests__/message-audience.test.ts +49 -0
  131. package/src/channels/__tests__/types.test.ts +17 -3
  132. package/src/channels/message-audience.ts +40 -0
  133. package/src/channels/types.ts +16 -12
  134. package/src/cli/__tests__/catalog-search-help.test.ts +50 -0
  135. package/src/cli/commands/__tests__/channel-verification-sessions.test.ts +31 -0
  136. package/src/cli/commands/__tests__/conversations-search.test.ts +289 -0
  137. package/src/cli/commands/__tests__/conversations-slack.test.ts +2 -1
  138. package/src/cli/commands/__tests__/inference-profiles.test.ts +16 -4
  139. package/src/cli/commands/__tests__/inference-providers.test.ts +135 -2
  140. package/src/cli/commands/__tests__/keys.test.ts +89 -8
  141. package/src/cli/commands/__tests__/plugins.test.ts +57 -1
  142. package/src/cli/commands/channel-verification-sessions.help.ts +11 -9
  143. package/src/cli/commands/channel-verification-sessions.ts +11 -21
  144. package/src/cli/commands/conversations.help.ts +34 -0
  145. package/src/cli/commands/conversations.ts +125 -0
  146. package/src/cli/commands/inference-profiles.ts +56 -3
  147. package/src/cli/commands/inference-providers.ts +37 -6
  148. package/src/cli/commands/inference.help.ts +9 -4
  149. package/src/cli/commands/keys.help.ts +13 -1
  150. package/src/cli/commands/keys.ts +26 -15
  151. package/src/cli/commands/memory/__tests__/memory-v2.test.ts +57 -7
  152. package/src/cli/commands/memory/index.help.ts +41 -27
  153. package/src/cli/commands/memory/index.ts +2 -0
  154. package/src/cli/commands/memory/memory-v2.ts +58 -54
  155. package/src/cli/commands/memory/memory-validate.ts +18 -0
  156. package/src/cli/commands/monitoring.ts +1 -0
  157. package/src/cli/commands/oauth/request.test.ts +93 -0
  158. package/src/cli/commands/oauth/request.ts +23 -9
  159. package/src/cli/commands/plugins.help.ts +28 -31
  160. package/src/cli/commands/plugins.ts +10 -0
  161. package/src/cli/commands/skills.help.ts +13 -16
  162. package/src/cli/commands/trust.ts +3 -14
  163. package/src/cli/lib/__tests__/install-from-github.test.ts +38 -0
  164. package/src/cli/lib/__tests__/merge-plugin-tree.test.ts +34 -0
  165. package/src/cli/lib/__tests__/plugin-surfaces.test.ts +32 -1
  166. package/src/cli/lib/__tests__/toggle-plugin.test.ts +2 -1
  167. package/src/cli/lib/__tests__/upgrade-plugin.test.ts +64 -0
  168. package/src/cli/lib/bundled-marketplace.json +26 -0
  169. package/src/cli/lib/daemon-credential-client.ts +25 -3
  170. package/src/cli/lib/install-from-github.ts +35 -24
  171. package/src/cli/lib/merge-plugin-tree.ts +22 -4
  172. package/src/cli/lib/open-browser.test.ts +67 -0
  173. package/src/cli/lib/open-browser.ts +24 -5
  174. package/src/cli/lib/plugin-surfaces.ts +27 -0
  175. package/src/config/__tests__/balanced-model-experiment.test.ts +7 -7
  176. package/src/config/__tests__/default-profile-catalog.test.ts +3 -3
  177. package/src/config/__tests__/profile-materialization.test.ts +26 -0
  178. package/src/config/default-profile-catalog.ts +5 -6
  179. package/src/config/feature-flag-registry.json +36 -28
  180. package/src/config/profile-materialization.ts +29 -0
  181. package/src/config/sanitize-for-transfer.ts +16 -0
  182. package/src/config/schemas/llm.ts +7 -0
  183. package/src/config/schemas/services.ts +6 -0
  184. package/src/config/webhook-routing.ts +8 -0
  185. package/src/context/compactor.ts +31 -2
  186. package/src/context/outbound-sanitize.ts +6 -0
  187. package/src/daemon/__tests__/lifecycle-watch-timeline-sweep.test.ts +98 -0
  188. package/src/daemon/__tests__/provider-rejection-log-fields.test.ts +272 -0
  189. package/src/daemon/conversation-agent-loop-handlers.ts +4 -1
  190. package/src/daemon/conversation-error.ts +19 -2
  191. package/src/daemon/conversation-messaging.ts +22 -2
  192. package/src/daemon/conversation-process.ts +11 -0
  193. package/src/daemon/conversation-store.ts +10 -0
  194. package/src/daemon/conversation-surfaces.ts +21 -8
  195. package/src/daemon/conversation.ts +12 -10
  196. package/src/daemon/daemon-control.ts +1 -0
  197. package/src/daemon/handlers/__tests__/config-ingress-tunnel-records.test.ts +208 -0
  198. package/src/daemon/handlers/config-ingress.ts +115 -5
  199. package/src/daemon/lifecycle.ts +30 -2
  200. package/src/daemon/message-types/conversations.ts +5 -7
  201. package/src/daemon/message-types/web-activity.ts +3 -2
  202. package/src/daemon/provider-rejection-log-fields.ts +124 -0
  203. package/src/daemon/resource-pressure-guard-lifecycle.ts +66 -0
  204. package/src/daemon/resource-pressure-guard.ts +387 -0
  205. package/src/daemon/shutdown-handlers.ts +2 -0
  206. package/src/daemon/startup-error.ts +16 -0
  207. package/src/daemon/trust-context.ts +14 -10
  208. package/src/daemon/unsendable-image-notice.ts +76 -0
  209. package/src/hooks/registry.ts +65 -51
  210. package/src/inbound/__tests__/tunnel-probe.test.ts +448 -0
  211. package/src/inbound/tunnel-probe.ts +261 -0
  212. package/src/ipc/__tests__/socket-path.test.ts +15 -7
  213. package/src/ipc/gateway-client.test.ts +1 -1
  214. package/src/ipc/gateway-client.ts +14 -21
  215. package/src/ipc/socket-cleanup.ts +2 -11
  216. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -1
  217. package/src/messaging/provider-message-metadata.ts +128 -0
  218. package/src/messaging/providers/__tests__/transport-dispatch.test.ts +138 -73
  219. package/src/messaging/providers/channel-transport.ts +100 -16
  220. package/src/messaging/providers/discord/send.ts +16 -0
  221. package/src/messaging/providers/discord/transport.ts +23 -1
  222. package/src/messaging/providers/index.ts +84 -16
  223. package/src/messaging/providers/slack/message-metadata.ts +45 -0
  224. package/src/messaging/providers/slack/render-transcript.ts +1 -4
  225. package/src/messaging/providers/slack/send.test.ts +88 -34
  226. package/src/messaging/providers/slack/send.ts +99 -50
  227. package/src/messaging/providers/slack/transport.ts +35 -37
  228. package/src/messaging/providers/telegram-bot/send.test.ts +88 -18
  229. package/src/messaging/providers/telegram-bot/send.ts +36 -0
  230. package/src/messaging/providers/telegram-bot/transport.ts +22 -8
  231. package/src/messaging/read-provider-metadata.test.ts +157 -0
  232. package/src/messaging/read-provider-metadata.ts +51 -0
  233. package/src/notifications/__tests__/assistant-reply-producer.test.ts +94 -0
  234. package/src/notifications/__tests__/edit-notification.test.ts +174 -2
  235. package/src/notifications/__tests__/home-feed-side-effect.test.ts +536 -4
  236. package/src/notifications/adapters/macos.ts +55 -0
  237. package/src/notifications/adapters/slack.ts +10 -5
  238. package/src/notifications/assistant-reply-producer.ts +37 -4
  239. package/src/notifications/conversation-pairing.ts +111 -21
  240. package/src/notifications/edit-notification.ts +38 -8
  241. package/src/notifications/emit-signal.ts +12 -14
  242. package/src/notifications/home-feed-side-effect.ts +218 -15
  243. package/src/notifications/types.ts +5 -0
  244. package/src/permissions/AGENTS.md +16 -0
  245. package/src/permissions/checker.test.ts +75 -122
  246. package/src/permissions/checker.ts +44 -560
  247. package/src/permissions/confirmation-guardian-request.test.ts +28 -3
  248. package/src/permissions/confirmation-guardian-request.ts +5 -1
  249. package/src/persistence/conversation-crud.ts +69 -20
  250. package/src/persistence/conversation-queries.ts +14 -1
  251. package/src/persistence/conversation-types.ts +22 -0
  252. package/src/persistence/db-async-query.ts +2 -1
  253. package/src/persistence/db-maintenance.ts +15 -0
  254. package/src/persistence/delivery-crud.ts +122 -15
  255. package/src/persistence/embeddings/qdrant-manager.ts +1 -0
  256. package/src/persistence/migrations/367-create-watch-timeline-entries.ts +46 -0
  257. package/src/persistence/migrations/368-watch-timeline-screenshot-blob.ts +33 -0
  258. package/src/persistence/migrations/__tests__/367-create-watch-timeline-entries.test.ts +98 -0
  259. package/src/persistence/migrations/__tests__/368-watch-timeline-screenshot-blob.test.ts +98 -0
  260. package/src/persistence/schema/index.ts +1 -0
  261. package/src/persistence/schema/watch.ts +29 -0
  262. package/src/persistence/steps.ts +4 -0
  263. package/src/plugin-api/__tests__/import-graph-partial-mock.test.ts +67 -0
  264. package/src/plugin-api/conversation-turn.ts +27 -0
  265. package/src/plugin-api/credential-scope.test.ts +15 -0
  266. package/src/plugin-api/credential-scope.ts +14 -0
  267. package/src/plugin-api/index.ts +19 -1
  268. package/src/plugin-api/resolve-credential.ts +15 -10
  269. package/src/plugin-api/store-credential.ts +148 -0
  270. package/src/plugin-api/system-card.ts +36 -0
  271. package/src/plugin-api/vision-support.test.ts +82 -0
  272. package/src/plugin-api/vision-support.ts +14 -2
  273. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +361 -110
  274. package/src/plugins/defaults/image-fallback/__tests__/vision-recovery.test.ts +4 -0
  275. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +58 -0
  276. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +64 -23
  277. package/src/plugins/defaults/image-recovery/detect.ts +24 -1
  278. package/src/plugins/defaults/main.ts +15 -0
  279. package/src/plugins/defaults/memory/AGENTS.md +11 -3
  280. package/src/plugins/defaults/memory/__tests__/memory-tier-boundary-guard.test.ts +0 -1
  281. package/src/plugins/defaults/memory/graph-topology/pending-buffer.ts +9 -12
  282. package/src/plugins/defaults/memory/memory-retrospective-prompt.ts +1 -1
  283. package/src/plugins/defaults/memory/src/memory-v2-routes.ts +12 -10
  284. package/src/plugins/defaults/memory/substrate/__tests__/consolidation-job.test.ts +114 -0
  285. package/src/plugins/defaults/memory/substrate/__tests__/consolidation-prompt-flag-gating-guard.test.ts +8 -0
  286. package/src/plugins/defaults/memory/substrate/__tests__/edge-index.test.ts +0 -30
  287. package/src/plugins/defaults/memory/substrate/__tests__/ingest.test.ts +73 -1
  288. package/src/plugins/defaults/memory/substrate/__tests__/page-index.test.ts +37 -0
  289. package/src/plugins/defaults/memory/substrate/__tests__/page-links.test.ts +208 -0
  290. package/src/plugins/defaults/memory/substrate/__tests__/prompts-consolidation.test.ts +158 -1
  291. package/src/plugins/defaults/memory/substrate/__tests__/static-context.test.ts +1 -61
  292. package/src/plugins/defaults/memory/substrate/consolidation-job.ts +68 -6
  293. package/src/plugins/defaults/memory/substrate/edge-index.ts +0 -31
  294. package/src/plugins/defaults/memory/substrate/ingest.ts +59 -0
  295. package/src/plugins/defaults/memory/substrate/page-index.ts +35 -8
  296. package/src/plugins/defaults/memory/substrate/page-links.ts +133 -0
  297. package/src/plugins/defaults/memory/substrate/page-store.ts +10 -0
  298. package/src/plugins/defaults/memory/substrate/prompts/consolidation.ts +124 -34
  299. package/src/plugins/defaults/memory/substrate/static-context.ts +0 -29
  300. package/src/plugins/defaults/memory/v3/__tests__/shadow-plugin.test.ts +3 -1
  301. package/src/plugins/defaults/memory/v3/card.ts +9 -9
  302. package/src/plugins/defaults/memory/v3/core-set.test.ts +7 -0
  303. package/src/plugins/defaults/memory/v3/core-set.ts +5 -1
  304. package/src/plugins/defaults/memory/v3/edge.ts +13 -57
  305. package/src/plugins/mtime-cache.ts +1 -1
  306. package/src/plugins/pipeline.ts +14 -7
  307. package/src/plugins/plugin-execution-context.ts +35 -11
  308. package/src/plugins/plugin-tree-walk.ts +63 -4
  309. package/src/providers/__tests__/retry-network-error.test.ts +84 -0
  310. package/src/providers/anthropic/__tests__/pause-turn-continuation.test.ts +170 -0
  311. package/src/providers/anthropic/client.ts +332 -241
  312. package/src/providers/connection-resolution.ts +25 -2
  313. package/src/providers/content-blocks.ts +22 -0
  314. package/src/providers/fetch-provider-catalog.ts +19 -0
  315. package/src/providers/gemini/client.ts +5 -2
  316. package/src/providers/inference/__tests__/adapter-factory-litellm.test.ts +47 -1
  317. package/src/providers/inference/__tests__/adapter-factory-ollama.test.ts +83 -0
  318. package/src/providers/inference/__tests__/adapter-factory-openai-compatible.test.ts +98 -1
  319. package/src/providers/inference/__tests__/base-url-route-validation.test.ts +38 -0
  320. package/src/providers/inference/__tests__/base-url-security.test.ts +10 -0
  321. package/src/providers/inference/__tests__/connections-ollama.test.ts +90 -0
  322. package/src/providers/inference/__tests__/endpoint-probe.test.ts +92 -0
  323. package/src/providers/inference/__tests__/missing-credential-guard.test.ts +117 -0
  324. package/src/providers/inference/__tests__/profile-config-validation.test.ts +39 -0
  325. package/src/providers/inference/__tests__/profile-probe-classify.test.ts +66 -0
  326. package/src/providers/inference/adapter-factory.ts +33 -2
  327. package/src/providers/inference/auth.ts +13 -2
  328. package/src/providers/inference/credential-usage.ts +37 -0
  329. package/src/providers/inference/endpoint-probe.ts +115 -0
  330. package/src/providers/inference/missing-credential-guard.ts +110 -0
  331. package/src/providers/inference/profile-probe.ts +256 -0
  332. package/src/providers/inference/resolve-auth.ts +7 -7
  333. package/src/providers/media-resolve.ts +176 -15
  334. package/src/providers/model-catalog.ts +10 -0
  335. package/src/providers/openai/__tests__/api-error-normalization.test.ts +17 -1
  336. package/src/providers/openai/__tests__/chat-completions-provider-reasoning.test.ts +576 -46
  337. package/src/providers/openai/__tests__/connection-error-wrap.test.ts +44 -0
  338. package/src/providers/openai/__tests__/tool-choice-mapping.test.ts +125 -2
  339. package/src/providers/openai/api-error-normalization.ts +16 -2
  340. package/src/providers/openai/chat-completions-provider.ts +326 -44
  341. package/src/providers/openai/responses-provider.ts +5 -2
  342. package/src/providers/provider-send-message.ts +11 -0
  343. package/src/providers/retry.ts +6 -0
  344. package/src/providers/search-provider-catalog.ts +20 -0
  345. package/src/routes/route-host-protocol.ts +7 -0
  346. package/src/routes/worker.ts +31 -10
  347. package/src/runtime/AGENTS.md +36 -0
  348. package/src/runtime/__tests__/host-observe.test.ts +302 -0
  349. package/src/runtime/__tests__/runtime-http-port-collision.test.ts +131 -0
  350. package/src/runtime/__tests__/web-presence.test.ts +234 -0
  351. package/src/runtime/assistant-event-hub.ts +38 -0
  352. package/src/runtime/channel-readiness-service.ts +39 -13
  353. package/src/runtime/channel-readiness-types.ts +49 -2
  354. package/src/runtime/channel-reply-delivery.ts +55 -32
  355. package/src/runtime/channel-retry-sweep.ts +6 -4
  356. package/src/runtime/effective-capabilities.test.ts +19 -0
  357. package/src/runtime/effective-capabilities.ts +25 -0
  358. package/src/runtime/guardian-reply-router.ts +6 -2
  359. package/src/runtime/host-observe.ts +246 -0
  360. package/src/runtime/http-errors.ts +1 -0
  361. package/src/runtime/http-server.ts +185 -6
  362. package/src/runtime/routes/__tests__/client-routes.test.ts +150 -0
  363. package/src/runtime/routes/__tests__/conversation-list-routes.test.ts +133 -0
  364. package/src/runtime/routes/__tests__/conversation-query-routes.test.ts +80 -0
  365. package/src/runtime/routes/__tests__/credential-delete-in-use.test.ts +155 -0
  366. package/src/runtime/routes/__tests__/inference-profiles-routes.test.ts +118 -0
  367. package/src/runtime/routes/__tests__/inference-provider-connection-routes.test.ts +72 -1
  368. package/src/runtime/routes/__tests__/ingress-status-routes.test.ts +508 -0
  369. package/src/runtime/routes/__tests__/monitoring-routes.test.ts +1 -0
  370. package/src/runtime/routes/__tests__/pending-interactions-route.test.ts +175 -0
  371. package/src/runtime/routes/__tests__/plugins-routes.test.ts +103 -71
  372. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +55 -6
  373. package/src/runtime/routes/__tests__/system-card-turn-termination.test.ts +107 -0
  374. package/src/runtime/routes/__tests__/user-route-dispatcher-host.test.ts +52 -1
  375. package/src/runtime/routes/__tests__/user-route-dispatcher.test.ts +75 -4
  376. package/src/runtime/routes/__tests__/watch-routes-guardian-cache.test.ts +139 -0
  377. package/src/runtime/routes/__tests__/watch-routes.test.ts +598 -0
  378. package/src/runtime/routes/approval-routes.ts +37 -4
  379. package/src/runtime/routes/approval-strategies/guardian-text-engine-strategy.ts +16 -22
  380. package/src/runtime/routes/canned-message-complete.ts +68 -29
  381. package/src/runtime/routes/channel-readiness-routes.ts +14 -2
  382. package/src/runtime/routes/client-routes.ts +113 -0
  383. package/src/runtime/routes/conversation-list-routes.ts +22 -7
  384. package/src/runtime/routes/conversation-management-routes.ts +15 -9
  385. package/src/runtime/routes/conversation-query-routes.ts +10 -0
  386. package/src/runtime/routes/conversation-routes.ts +36 -22
  387. package/src/runtime/routes/credential-in-use.ts +85 -0
  388. package/src/runtime/routes/credential-routes.ts +55 -85
  389. package/src/runtime/routes/guardian-approval-interception.ts +44 -53
  390. package/src/runtime/routes/guardian-approval-reply-helpers.ts +14 -12
  391. package/src/runtime/routes/host-cu-routes.ts +18 -0
  392. package/src/runtime/routes/identity-routes.ts +5 -121
  393. package/src/runtime/routes/inbound-message-handler.ts +74 -30
  394. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +16 -17
  395. package/src/runtime/routes/inbound-stages/background-dispatch.test.ts +182 -297
  396. package/src/runtime/routes/inbound-stages/background-dispatch.ts +173 -386
  397. package/src/runtime/routes/inbound-stages/edit-intercept.ts +101 -77
  398. package/src/runtime/routes/inbound-stages/guardian-reply-intercept.ts +17 -8
  399. package/src/runtime/routes/inbound-stages/reaction-intercept.test.ts +91 -7
  400. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +72 -70
  401. package/src/runtime/routes/index.ts +4 -0
  402. package/src/runtime/routes/inference-profiles-routes.ts +232 -31
  403. package/src/runtime/routes/inference-provider-connection-routes.ts +33 -11
  404. package/src/runtime/routes/ingress-status-routes.ts +180 -0
  405. package/src/runtime/routes/monitoring-routes.ts +9 -1
  406. package/src/runtime/routes/oauth-commands-routes.ts +1 -1
  407. package/src/runtime/routes/plugins-routes.ts +28 -32
  408. package/src/runtime/routes/resource-pressure-routes.ts +22 -0
  409. package/src/runtime/routes/secret-routes.ts +39 -8
  410. package/src/runtime/routes/settings-routes.ts +15 -12
  411. package/src/runtime/routes/surface-action-routes.ts +20 -19
  412. package/src/runtime/routes/user-route-dispatcher.ts +31 -2
  413. package/src/runtime/routes/user-route-resolution.ts +18 -1
  414. package/src/runtime/routes/watch-routes.ts +807 -0
  415. package/src/runtime/slack-reply-session.test.ts +23 -13
  416. package/src/runtime/slack-reply-session.ts +38 -55
  417. package/src/runtime/web-presence.ts +90 -0
  418. package/src/security/__tests__/untrusted-content.test.ts +42 -0
  419. package/src/security/untrusted-content.ts +28 -9
  420. package/src/skills/validate-input.ts +177 -40
  421. package/src/subagent/__tests__/consult-context-gating.test.ts +6 -10
  422. package/src/subagent/consult-context.ts +7 -23
  423. package/src/tools/credentials/broker.ts +24 -79
  424. package/src/tools/credentials/ref-parse.ts +35 -0
  425. package/src/tools/credentials/resolve.ts +4 -10
  426. package/src/tools/credentials/store.ts +168 -0
  427. package/src/tools/credentials/tool-policy.ts +67 -0
  428. package/src/tools/executor.ts +53 -15
  429. package/src/tools/network/__tests__/firecrawl-compat.test.ts +77 -0
  430. package/src/tools/network/__tests__/web-fetch-fastcrw.test.ts +169 -0
  431. package/src/tools/network/__tests__/web-search.test.ts +138 -3
  432. package/src/tools/network/firecrawl-compat.ts +90 -0
  433. package/src/tools/network/url-safety.ts +9 -16
  434. package/src/tools/network/web-fetch.ts +142 -62
  435. package/src/tools/network/web-search.ts +162 -58
  436. package/src/tools/permission-checker.ts +43 -52
  437. package/src/tools/schema-transforms.ts +40 -5
  438. package/src/tools/shared/input-repairs.ts +160 -0
  439. package/src/tools/skills/skill-tool-factory.ts +18 -4
  440. package/src/tools/subagent/spawn.ts +0 -1
  441. package/src/tools/tool-approval-handler.ts +16 -10
  442. package/src/tools/tool-types.ts +26 -13
  443. package/src/tools/types.ts +6 -6
  444. package/src/util/__tests__/cgroup-memory.test.ts +3 -0
  445. package/src/util/cgroup-memory.ts +3 -0
  446. package/src/util/container-cpu-sampler.ts +250 -0
  447. package/src/util/image-conversion.ts +178 -14
  448. package/src/util/platform.ts +93 -10
  449. package/src/util/worker-process.ts +1 -0
  450. package/src/watch/__tests__/watch-retro.test.ts +665 -0
  451. package/src/watch/__tests__/watch-session-manager.test.ts +566 -0
  452. package/src/watch/__tests__/watch-timeline.test.ts +670 -0
  453. package/src/watch/watch-retro.ts +480 -0
  454. package/src/watch/watch-session-manager.ts +575 -0
  455. package/src/watch/watch-timeline.ts +848 -0
  456. package/src/permissions/ipc-risk-types.ts +0 -143
  457. package/src/permissions/risk-types.ts +0 -76
@@ -88,6 +88,39 @@ mock.module("../../gateway-client.js", () => ({
88
88
  },
89
89
  }));
90
90
 
91
+ const sentStreamOps: Array<Record<string, unknown>> = [];
92
+ let sendChannelStreamOpImpl: (
93
+ op: Record<string, unknown>,
94
+ ) => Promise<{ ok: boolean; ts?: string }> = async () => ({ ok: true });
95
+ const sentActivity: Array<Record<string, unknown>> = [];
96
+ let setChannelActivityImpl: (
97
+ target: Record<string, unknown>,
98
+ ) => { ok: boolean } | Promise<{ ok: boolean }> = () => ({ ok: true });
99
+ // Undefined stands for a channel whose indicator holds until it is changed, so
100
+ // the controller reports each phase once and the assertions read as the turn's
101
+ // lifecycle rather than as timer ticks. A test that needs the self-expiring
102
+ // shape sets a cadence.
103
+ let activityRefreshMsImpl: () => number | undefined = () => undefined;
104
+ mock.module("../../../messaging/providers/index.js", () => ({
105
+ supportsChannelActivity: () => true,
106
+ channelActivityRefreshMs: () => activityRefreshMsImpl(),
107
+ setChannelActivity: async (
108
+ _callbackUrl: string,
109
+ target: Record<string, unknown>,
110
+ ) => {
111
+ sentActivity.push(target);
112
+ return setChannelActivityImpl(target);
113
+ },
114
+ sendChannelStreamOp: async (
115
+ _callbackUrl: string,
116
+ _chatId: string,
117
+ op: Record<string, unknown>,
118
+ ) => {
119
+ sentStreamOps.push(op);
120
+ return sendChannelStreamOpImpl(op);
121
+ },
122
+ }));
123
+
91
124
  mock.module("../../channel-reply-delivery.js", () => ({
92
125
  deliverReplyViaCallback: async (...args: unknown[]) => {
93
126
  const options = args[4] as
@@ -118,8 +151,8 @@ import type { MessageProcessor } from "../../http-types.js";
118
151
  import {
119
152
  isBoundGuardianActor,
120
153
  processChannelMessageInBackground,
121
- shouldStartSlackThinkingStatusForText,
122
- shouldStartSlackThinkingStatusImmediately,
154
+ shouldShowActivityForText,
155
+ shouldShowActivityImmediately,
123
156
  } from "./background-dispatch.js";
124
157
  import { __resetChannelTurnAdmissionForTests } from "./channel-turn-admission.js";
125
158
 
@@ -127,6 +160,11 @@ beforeEach(() => {
127
160
  __resetChannelTurnAdmissionForTests();
128
161
  clearConversations();
129
162
  deliveredChannelReplies.length = 0;
163
+ sentStreamOps.length = 0;
164
+ sendChannelStreamOpImpl = async () => ({ ok: true });
165
+ sentActivity.length = 0;
166
+ setChannelActivityImpl = () => ({ ok: true });
167
+ activityRefreshMsImpl = () => undefined;
130
168
  markedProcessedEvents.length = 0;
131
169
  processingFailureEvents.length = 0;
132
170
  retryableFailureEvents.length = 0;
@@ -144,10 +182,7 @@ beforeEach(() => {
144
182
  deliverReplyViaCallbackImpl = async () => {};
145
183
  });
146
184
 
147
- const slackStreamOps = (): Array<Record<string, unknown>> =>
148
- deliveredChannelReplies
149
- .map((entry) => entry.payload.slackStream as Record<string, unknown>)
150
- .filter(Boolean);
185
+ const slackStreamOps = (): Array<Record<string, unknown>> => sentStreamOps;
151
186
 
152
187
  describe("isBoundGuardianActor", () => {
153
188
  test("returns true only when requester matches bound guardian", () => {
@@ -492,7 +527,7 @@ describe("processChannelMessageInBackground — reply delivery", () => {
492
527
  const channelId = "D-STREAMED";
493
528
  const threadTs = "1700000000.000044";
494
529
  const streamTs = "1700000000.000033";
495
- deliverChannelReplyImpl = async () => ({ ok: true, ts: streamTs });
530
+ sendChannelStreamOpImpl = async () => ({ ok: true, ts: streamTs });
496
531
 
497
532
  const processMessage: MessageProcessor = async (
498
533
  _conversationId,
@@ -671,7 +706,7 @@ describe("processChannelMessageInBackground — reply delivery", () => {
671
706
  const channelId = "D-STREAM-PROCESSING-FAILURE";
672
707
  const threadTs = "1700000000.000066";
673
708
  const streamTs = "1700000000.000077";
674
- deliverChannelReplyImpl = async () => ({ ok: true, ts: streamTs });
709
+ sendChannelStreamOpImpl = async () => ({ ok: true, ts: streamTs });
675
710
 
676
711
  const processMessage: MessageProcessor = async (
677
712
  _conversationId,
@@ -856,13 +891,7 @@ describe("processChannelMessageInBackground — admission (queue if busy)", () =
856
891
  });
857
892
  });
858
893
 
859
- describe("Slack thinking status timing", () => {
860
- const slackStatusLabels = [
861
- "is on it",
862
- "is working hard",
863
- "is touching grass",
864
- ];
865
-
894
+ describe("channel activity timing", () => {
866
895
  const trustCtx: TrustContext = {
867
896
  trustClass: "guardian",
868
897
  guardianExternalUserId: "guardian-1",
@@ -872,72 +901,74 @@ describe("Slack thinking status timing", () => {
872
901
  const flush = (): Promise<void> =>
873
902
  new Promise((resolve) => setTimeout(resolve, 10));
874
903
 
904
+ const phases = (): unknown[] =>
905
+ sentActivity.map((entry) => (entry as { phase?: unknown }).phase);
906
+
875
907
  beforeEach(() => {
876
908
  deliveredChannelReplies.length = 0;
877
909
  });
878
910
 
879
- test("recognizes only deliverable text as a Slack thinking-status trigger", () => {
880
- expect(shouldStartSlackThinkingStatusForText("")).toBe(false);
881
- expect(shouldStartSlackThinkingStatusForText(" ")).toBe(false);
882
- expect(shouldStartSlackThinkingStatusForText("<")).toBe(false);
883
- expect(shouldStartSlackThinkingStatusForText("<no_response")).toBe(false);
884
- expect(shouldStartSlackThinkingStatusForText("<no_response/>")).toBe(false);
885
- expect(shouldStartSlackThinkingStatusForText(" <no_response /> ")).toBe(
911
+ test("recognizes only deliverable text as a reason to show activity", () => {
912
+ expect(shouldShowActivityForText("")).toBe(false);
913
+ expect(shouldShowActivityForText(" ")).toBe(false);
914
+ expect(shouldShowActivityForText("<")).toBe(false);
915
+ expect(shouldShowActivityForText("<no_response")).toBe(false);
916
+ expect(shouldShowActivityForText("<no_response/>")).toBe(false);
917
+ expect(shouldShowActivityForText(" <no_response /> ")).toBe(false);
918
+ expect(shouldShowActivityForText("Real response.")).toBe(true);
919
+ expect(shouldShowActivityForText("<no_response/>\nReal response.")).toBe(
920
+ true,
921
+ );
922
+ });
923
+
924
+ test("recognizes a direct conversation in every channel's word for one", () => {
925
+ // One idea, three spellings, because `chatType` arrives as whatever the
926
+ // channel called it. Slack `im`, Discord `dm`, Telegram `private`. Missing
927
+ // one does not fail loudly: that channel silently reads as an ambient room
928
+ // and stops showing an indicator it used to show.
929
+ expect(shouldShowActivityImmediately({ chatType: "im" })).toBe(true);
930
+ expect(shouldShowActivityImmediately({ chatType: "dm" })).toBe(true);
931
+ expect(shouldShowActivityImmediately({ chatType: "private" })).toBe(true);
932
+ });
933
+
934
+ test("treats a room with other readers as ambient, including a group DM", () => {
935
+ // Slack's `mpim` has other readers, so it is a room: the assistant may
936
+ // process the traffic and decide to stay quiet, and an indicator there
937
+ // announces it was reading.
938
+ expect(shouldShowActivityImmediately({ chatType: "mpim" })).toBe(false);
939
+ expect(shouldShowActivityImmediately({ chatType: "channel" })).toBe(false);
940
+ expect(shouldShowActivityImmediately({ chatType: "supergroup" })).toBe(
886
941
  false,
887
942
  );
888
- expect(shouldStartSlackThinkingStatusForText("Real response.")).toBe(true);
889
- expect(
890
- shouldStartSlackThinkingStatusForText("<no_response/>\nReal response."),
891
- ).toBe(true);
943
+ expect(shouldShowActivityImmediately({})).toBe(false);
892
944
  });
893
945
 
894
- test("starts Slack thinking status immediately for DMs and direct mentions", () => {
895
- expect(
896
- shouldStartSlackThinkingStatusImmediately({
897
- sourceChannel: "slack",
898
- chatType: "im",
899
- }),
900
- ).toBe(true);
946
+ test("shows activity immediately when the assistant is mentioned", () => {
947
+ expect(shouldShowActivityImmediately({ botMentioned: true })).toBe(true);
901
948
  expect(
902
- shouldStartSlackThinkingStatusImmediately({
903
- sourceChannel: "slack",
904
- slackBotMentioned: true,
905
- }),
906
- ).toBe(true);
907
- expect(
908
- shouldStartSlackThinkingStatusImmediately({
909
- sourceChannel: "slack",
949
+ shouldShowActivityImmediately({
910
950
  chatType: "channel",
951
+ botMentioned: true,
911
952
  }),
912
- ).toBe(false);
913
- expect(
914
- shouldStartSlackThinkingStatusImmediately({
915
- sourceChannel: "telegram",
916
- chatType: "im",
917
- slackBotMentioned: true,
918
- }),
919
- ).toBe(false);
953
+ ).toBe(true);
920
954
  });
921
955
 
922
- test("sets Slack thinking indicator immediately for a DM", async () => {
923
- const conversationId = "conv-dm-immediate-status";
956
+ test("shows activity immediately in a DM and settles it when the turn ends", async () => {
957
+ const conversationId = "conv-dm-immediate-activity";
924
958
  const channelId = "D-DM-IMMEDIATE";
925
959
  const messageTs = "1700000000.000010";
926
960
 
927
961
  const processMessage: MessageProcessor = async () => {
928
- expect(deliveredChannelReplies).toHaveLength(1);
929
- expect(deliveredChannelReplies[0]!.payload.reaction).toEqual({
930
- action: "add",
931
- name: "eyes",
932
- messageTs,
933
- });
962
+ // Already showing before the turn does any work: a DM is addressed to
963
+ // the assistant, so nothing needs to be observed first.
964
+ expect(phases()).toEqual(["thinking"]);
934
965
  return { messageId: "user-msg-dm-immediate" };
935
966
  };
936
967
 
937
968
  processChannelMessageInBackground({
938
969
  processMessage,
939
970
  conversationId,
940
- eventId: "evt-dm-immediate-status",
971
+ eventId: "evt-dm-immediate-activity",
941
972
  content: "dm message",
942
973
  sourceChannel: "slack",
943
974
  sourceInterface: "slack",
@@ -950,40 +981,27 @@ describe("Slack thinking status timing", () => {
950
981
 
951
982
  await flush();
952
983
 
953
- const reactions = deliveredChannelReplies.map(
954
- (entry) => entry.payload.reaction,
955
- );
956
- expect(reactions).toEqual([
957
- { action: "add", name: "eyes", messageTs },
958
- { action: "remove", name: "eyes", messageTs },
959
- ]);
984
+ // `idle` is owed explicitly. A channel that holds its indicator keeps it
985
+ // up until told otherwise, so a missing terminal phase is a stuck spinner
986
+ // rather than a cosmetic slip.
987
+ expect(phases()).toEqual(["thinking", "idle"]);
988
+ expect(sentActivity[0]).toEqual({ chatId: channelId, phase: "thinking" });
960
989
  });
961
990
 
962
- test("sets Slack thinking status immediately for an app mention", async () => {
963
- const conversationId = "conv-mention-immediate-status";
991
+ test("shows activity immediately for an app mention and settles it", async () => {
992
+ const conversationId = "conv-mention-immediate-activity";
964
993
  const channelId = "C-MENTION-IMMEDIATE";
965
994
  const threadTs = "1700000000.000011";
966
995
 
967
996
  const processMessage: MessageProcessor = async () => {
968
- expect(deliveredChannelReplies).toHaveLength(1);
969
- expect(deliveredChannelReplies[0]!.payload.assistantThreadStatus).toEqual(
970
- {
971
- channel: channelId,
972
- threadTs,
973
- status: expect.any(String),
974
- loadingMessages: ["Thinking\u2026"],
975
- },
976
- );
977
- const threadStatus = deliveredChannelReplies[0]!.payload
978
- .assistantThreadStatus as { status: string };
979
- expect(slackStatusLabels).toContain(threadStatus.status);
997
+ expect(phases()).toEqual(["thinking"]);
980
998
  return { messageId: "user-msg-mention-immediate" };
981
999
  };
982
1000
 
983
1001
  processChannelMessageInBackground({
984
1002
  processMessage,
985
1003
  conversationId,
986
- eventId: "evt-mention-immediate-status",
1004
+ eventId: "evt-mention-immediate-activity",
987
1005
  content: "@assistant please respond",
988
1006
  sourceChannel: "slack",
989
1007
  sourceInterface: "slack",
@@ -996,212 +1014,123 @@ describe("Slack thinking status timing", () => {
996
1014
 
997
1015
  await flush();
998
1016
 
999
- const statuses = deliveredChannelReplies.map((entry) => {
1000
- const status = entry.payload.assistantThreadStatus as
1001
- | { status?: string }
1002
- | undefined;
1003
- return status?.status;
1004
- });
1005
- expect(slackStatusLabels).toContain(statuses[0]!);
1006
- expect(statuses[1]).toBe("");
1017
+ expect(phases()).toEqual(["thinking", "idle"]);
1007
1018
  });
1008
1019
 
1009
- test("does not set Slack thinking status for no_response text deltas", async () => {
1010
- const conversationId = "conv-no-response-status";
1011
- const channelId = "C-NO-RESPONSE";
1012
- const threadTs = "1700000000.000003";
1013
-
1014
- const processMessage: MessageProcessor = async (
1015
- _conversationId,
1016
- _content,
1017
- options,
1018
- ) => {
1019
- options?.onEvent?.({
1020
- type: "assistant_text_delta",
1021
- text: "<no_response/>",
1022
- conversationId,
1023
- });
1024
- return { messageId: "user-msg-no-response" };
1020
+ test("retries a terminal transition the channel failed to accept", async () => {
1021
+ const conversationId = "conv-idle-retry";
1022
+ const channelId = "D-IDLE-RETRY";
1023
+ let idleAttempts = 0;
1024
+ setChannelActivityImpl = (target) => {
1025
+ if (target.phase === "idle") {
1026
+ idleAttempts += 1;
1027
+ return { ok: idleAttempts > 1 };
1028
+ }
1029
+ return { ok: true };
1025
1030
  };
1026
1031
 
1027
1032
  processChannelMessageInBackground({
1028
- processMessage,
1033
+ processMessage: async () => ({ messageId: "user-msg-idle-retry" }),
1029
1034
  conversationId,
1030
- eventId: "evt-no-response-status",
1031
- content: "ambient channel chatter",
1035
+ eventId: "evt-idle-retry",
1036
+ content: "dm message",
1032
1037
  sourceChannel: "slack",
1033
1038
  sourceInterface: "slack",
1034
1039
  externalChatId: channelId,
1035
1040
  trustCtx,
1036
1041
  metadataHints: [],
1037
- replyCallbackUrl: `https://example.test/deliver/slack?channel=${channelId}&threadTs=${threadTs}`,
1042
+ chatType: "im",
1043
+ replyCallbackUrl: `https://example.test/deliver/slack?channel=${channelId}&messageTs=1700000000.000020`,
1038
1044
  });
1039
1045
 
1040
1046
  await flush();
1041
1047
 
1042
- expect(deliveredChannelReplies).toEqual([]);
1048
+ // A dropped `idle` is not cosmetic on a channel that holds its indicator:
1049
+ // Slack keeps showing the assistant as working for an hour, so the
1050
+ // terminal transition is the one worth attempting twice.
1051
+ expect(idleAttempts).toBe(2);
1043
1052
  });
1044
1053
 
1045
- test("sets and clears Slack thinking status after real assistant text starts", async () => {
1046
- const conversationId = "conv-real-response-status";
1047
- const channelId = "C-REAL-RESPONSE";
1048
- const threadTs = "1700000000.000004";
1049
-
1050
- const processMessage: MessageProcessor = async (
1051
- _conversationId,
1052
- _content,
1053
- options,
1054
- ) => {
1055
- options?.onEvent?.({
1056
- type: "assistant_text_delta",
1057
- text: "<",
1058
- conversationId,
1059
- });
1060
- expect(deliveredChannelReplies).toEqual([]);
1061
-
1062
- options?.onEvent?.({
1063
- type: "assistant_text_delta",
1064
- text: "b>Working on it.",
1065
- conversationId,
1066
- });
1067
- return { messageId: "user-msg-real-response" };
1054
+ test("runs idle next when the turn stops during a slow request, with no stale busy phase between", async () => {
1055
+ const conversationId = "conv-slow-refresh";
1056
+ const channelId = "D-SLOW-REFRESH";
1057
+
1058
+ // A self-expiring channel re-asserts on a timer, which is the only shape
1059
+ // where a refresh backlog can form at all.
1060
+ activityRefreshMsImpl = () => 5;
1061
+
1062
+ let release: (() => void) | undefined;
1063
+ let calls = 0;
1064
+ setChannelActivityImpl = (target) => {
1065
+ calls += 1;
1066
+ if (calls === 1 && target.phase !== "idle") {
1067
+ // Hold the first busy call open across many refresh intervals.
1068
+ return new Promise<{ ok: boolean }>((resolve) => {
1069
+ release = () => resolve({ ok: true });
1070
+ });
1071
+ }
1072
+ return { ok: true };
1068
1073
  };
1069
1074
 
1070
- processChannelMessageInBackground({
1071
- processMessage,
1072
- conversationId,
1073
- eventId: "evt-real-response-status",
1074
- content: "please respond",
1075
- sourceChannel: "slack",
1076
- sourceInterface: "slack",
1077
- externalChatId: channelId,
1078
- trustCtx,
1079
- metadataHints: [],
1080
- replyCallbackUrl: `https://example.test/deliver/slack?channel=${channelId}&threadTs=${threadTs}`,
1081
- });
1082
-
1083
- await flush();
1084
-
1085
- const statuses = deliveredChannelReplies.map((entry) => {
1086
- const status = entry.payload.assistantThreadStatus as
1087
- | { status?: string }
1088
- | undefined;
1089
- return status?.status;
1090
- });
1091
- expect(slackStatusLabels).toContain(statuses[0]!);
1092
- expect(statuses[1]).toBe("");
1093
- });
1094
-
1095
- test("buffers task_progress for ambiguous Slack turns until deliverable text appears", async () => {
1096
- const conversationId = "conv-progress-buffered";
1097
- const channelId = "C-PROGRESS-BUFFERED";
1098
- const threadTs = "1700000000.000012";
1099
-
1100
- const processMessage: MessageProcessor = async (
1101
- _conversationId,
1102
- _content,
1103
- options,
1104
- ) => {
1105
- options?.onEvent?.({
1106
- type: "ui_surface_show",
1107
- conversationId,
1108
- surfaceId: "surface-progress",
1109
- surfaceType: "card",
1110
- data: {
1111
- title: "Task progress",
1112
- body: "Working",
1113
- template: "task_progress",
1114
- templateData: {
1115
- steps: [
1116
- { label: "Search docs", status: "in_progress" },
1117
- { label: "Summarize", status: "pending" },
1118
- ],
1119
- },
1120
- },
1121
- });
1122
- expect(deliveredChannelReplies).toEqual([]);
1123
-
1124
- options?.onEvent?.({
1125
- type: "assistant_text_delta",
1126
- text: "I found the answer.",
1127
- conversationId,
1128
- });
1129
- return { messageId: "user-msg-progress-buffered" };
1075
+ const processMessage: MessageProcessor = async () => {
1076
+ // Long enough for several ticks to fire while the first call is unresolved.
1077
+ await new Promise((resolve) => setTimeout(resolve, 40));
1078
+ return { messageId: "user-msg-slow-refresh" };
1130
1079
  };
1131
1080
 
1132
1081
  processChannelMessageInBackground({
1133
1082
  processMessage,
1134
1083
  conversationId,
1135
- eventId: "evt-progress-buffered",
1136
- content: "ambient request",
1084
+ eventId: "evt-slow-refresh",
1085
+ content: "dm message",
1137
1086
  sourceChannel: "slack",
1138
1087
  sourceInterface: "slack",
1139
1088
  externalChatId: channelId,
1140
1089
  trustCtx,
1141
1090
  metadataHints: [],
1142
- replyCallbackUrl: `https://example.test/deliver/slack?channel=${channelId}&threadTs=${threadTs}`,
1091
+ chatType: "im",
1092
+ replyCallbackUrl: `https://example.test/deliver/slack?channel=${channelId}&messageTs=1700000000.000030`,
1143
1093
  });
1144
1094
 
1095
+ await new Promise((resolve) => setTimeout(resolve, 60));
1096
+ release?.();
1145
1097
  await flush();
1146
1098
 
1147
- const statuses = deliveredChannelReplies.map(
1148
- (entry) => entry.payload.assistantThreadStatus,
1149
- );
1150
- expect(statuses).toEqual([
1151
- {
1152
- channel: channelId,
1153
- threadTs,
1154
- status: expect.any(String),
1155
- loadingMessages: ["In progress (1/2): Search docs"],
1156
- },
1157
- {
1158
- channel: channelId,
1159
- threadTs,
1160
- status: "",
1161
- },
1162
- ]);
1163
- expect(slackStatusLabels).toContain(
1164
- (statuses[0] as { status: string }).status,
1165
- );
1099
+ const seen = phases();
1100
+ // The terminal phase is last and nothing busy follows it. A busy phase
1101
+ // executing after `idle` is the visible bug: the indicator comes back on a
1102
+ // turn that has already replied, which teaches people to distrust it.
1103
+ expect(seen.at(-1)).toBe("idle");
1104
+ expect(seen.slice(seen.indexOf("idle") + 1)).toEqual([]);
1105
+ // Ticks did not accumulate behind the outstanding call. Counting rather
1106
+ // than checking the last entry is what catches a backlog that happens to
1107
+ // drain in a harmless order.
1108
+ expect(seen.filter((phase) => phase === "thinking")).toHaveLength(1);
1166
1109
  });
1167
1110
 
1168
- test("keeps ambiguous Slack no_response turns quiet even with task_progress", async () => {
1169
- const conversationId = "conv-progress-no-response";
1170
- const channelId = "C-PROGRESS-NO-RESPONSE";
1171
- const threadTs = "1700000000.000013";
1111
+ test("stays silent for a turn that decides not to answer", async () => {
1112
+ const conversationId = "conv-no-response-activity";
1113
+ const channelId = "C-NO-RESPONSE";
1114
+ const threadTs = "1700000000.000003";
1172
1115
 
1173
1116
  const processMessage: MessageProcessor = async (
1174
1117
  _conversationId,
1175
1118
  _content,
1176
1119
  options,
1177
1120
  ) => {
1178
- options?.onEvent?.({
1179
- type: "ui_surface_show",
1180
- conversationId,
1181
- surfaceId: "surface-progress-no-response",
1182
- surfaceType: "card",
1183
- data: {
1184
- title: "Task progress",
1185
- body: "Working",
1186
- template: "task_progress",
1187
- templateData: {
1188
- steps: [{ label: "Inspect", status: "in_progress" }],
1189
- },
1190
- },
1191
- });
1192
1121
  options?.onEvent?.({
1193
1122
  type: "assistant_text_delta",
1194
1123
  text: "<no_response/>",
1195
1124
  conversationId,
1196
1125
  });
1197
- return { messageId: "user-msg-progress-no-response" };
1126
+ return { messageId: "user-msg-no-response" };
1198
1127
  };
1199
1128
 
1200
1129
  processChannelMessageInBackground({
1201
1130
  processMessage,
1202
1131
  conversationId,
1203
- eventId: "evt-progress-no-response",
1204
- content: "ambient chatter",
1132
+ eventId: "evt-no-response-activity",
1133
+ content: "ambient channel chatter",
1205
1134
  sourceChannel: "slack",
1206
1135
  sourceInterface: "slack",
1207
1136
  externalChatId: channelId,
@@ -1212,61 +1141,44 @@ describe("Slack thinking status timing", () => {
1212
1141
 
1213
1142
  await flush();
1214
1143
 
1144
+ // Not merely "no spinner": nothing at all was said to the channel. An
1145
+ // `idle` here would still be a message about a turn nobody asked to see,
1146
+ // and in a shared room it announces that the assistant read the traffic.
1147
+ expect(sentActivity).toEqual([]);
1215
1148
  expect(deliveredChannelReplies).toEqual([]);
1216
1149
  });
1217
1150
 
1218
- test("updates Slack loading message when task_progress changes", async () => {
1219
- const conversationId = "conv-progress-update";
1220
- const channelId = "C-PROGRESS-UPDATE";
1221
- const threadTs = "1700000000.000014";
1151
+ test("waits for real text in a room it was not addressed in, then settles", async () => {
1152
+ const conversationId = "conv-real-response-activity";
1153
+ const channelId = "C-REAL-RESPONSE";
1154
+ const threadTs = "1700000000.000004";
1222
1155
 
1223
1156
  const processMessage: MessageProcessor = async (
1224
1157
  _conversationId,
1225
1158
  _content,
1226
1159
  options,
1227
1160
  ) => {
1228
- options?.onEvent?.({
1229
- type: "ui_surface_show",
1230
- conversationId,
1231
- surfaceId: "surface-progress-update",
1232
- surfaceType: "card",
1233
- data: {
1234
- title: "Task progress",
1235
- body: "Working",
1236
- template: "task_progress",
1237
- templateData: {
1238
- steps: [
1239
- { label: "Read request", status: "in_progress" },
1240
- { label: "Write answer", status: "pending" },
1241
- ],
1242
- },
1243
- },
1244
- });
1245
1161
  options?.onEvent?.({
1246
1162
  type: "assistant_text_delta",
1247
- text: "On it.",
1163
+ text: "<",
1248
1164
  conversationId,
1249
1165
  });
1166
+ // A partial `<` could still become `<no_response/>`, so nothing shows.
1167
+ expect(sentActivity).toEqual([]);
1168
+
1250
1169
  options?.onEvent?.({
1251
- type: "ui_surface_update",
1170
+ type: "assistant_text_delta",
1171
+ text: "b>Working on it.",
1252
1172
  conversationId,
1253
- surfaceId: "surface-progress-update",
1254
- data: {
1255
- templateData: {
1256
- steps: [
1257
- { label: "Read request", status: "completed" },
1258
- { label: "Write answer", status: "in_progress" },
1259
- ],
1260
- },
1261
- },
1262
1173
  });
1263
- return { messageId: "user-msg-progress-update" };
1174
+ expect(phases()).toEqual(["thinking"]);
1175
+ return { messageId: "user-msg-real-response" };
1264
1176
  };
1265
1177
 
1266
1178
  processChannelMessageInBackground({
1267
1179
  processMessage,
1268
1180
  conversationId,
1269
- eventId: "evt-progress-update",
1181
+ eventId: "evt-real-response-activity",
1270
1182
  content: "please respond",
1271
1183
  sourceChannel: "slack",
1272
1184
  sourceInterface: "slack",
@@ -1278,33 +1190,6 @@ describe("Slack thinking status timing", () => {
1278
1190
 
1279
1191
  await flush();
1280
1192
 
1281
- const statuses = deliveredChannelReplies.map(
1282
- (entry) => entry.payload.assistantThreadStatus,
1283
- );
1284
- expect(statuses).toEqual([
1285
- {
1286
- channel: channelId,
1287
- threadTs,
1288
- status: expect.any(String),
1289
- loadingMessages: ["In progress (1/2): Read request"],
1290
- },
1291
- {
1292
- channel: channelId,
1293
- threadTs,
1294
- status: expect.any(String),
1295
- loadingMessages: ["In progress (2/2): Write answer"],
1296
- },
1297
- {
1298
- channel: channelId,
1299
- threadTs,
1300
- status: "",
1301
- },
1302
- ]);
1303
- expect(slackStatusLabels).toContain(
1304
- (statuses[0] as { status: string }).status,
1305
- );
1306
- expect(slackStatusLabels).toContain(
1307
- (statuses[1] as { status: string }).status,
1308
- );
1193
+ expect(phases()).toEqual(["thinking", "idle"]);
1309
1194
  });
1310
1195
  });