@vellumai/assistant 0.11.4 → 0.11.5-dev.202608220019.a778cf0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (457) hide show
  1. package/AGENTS.md +6 -2
  2. package/ARCHITECTURE.md +29 -4
  3. package/README.md +1 -1
  4. package/docs/architecture/memory.md +17 -5
  5. package/docs/architecture/security.md +96 -152
  6. package/docs/guardian-request-flow.md +13 -2
  7. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/package.json +1 -0
  8. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/__tests__/ingress.test.ts +118 -0
  9. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/__tests__/url-normalization.test.ts +135 -0
  10. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  11. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/ingress.ts +103 -0
  12. package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/url-normalization.ts +107 -0
  13. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/package.json +1 -0
  14. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/__tests__/ingress.test.ts +118 -0
  15. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/__tests__/url-normalization.test.ts +135 -0
  16. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  17. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/ingress.ts +103 -0
  18. package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/url-normalization.ts +107 -0
  19. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +166 -1
  20. package/node_modules/@vellumai/gateway-client/src/http-delivery.ts +7 -14
  21. package/node_modules/@vellumai/gateway-client/src/index.ts +2 -0
  22. package/node_modules/@vellumai/gateway-client/src/outbound-contract.ts +30 -32
  23. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  24. package/node_modules/@vellumai/service-contracts/src/__tests__/ingress.test.ts +118 -0
  25. package/node_modules/@vellumai/service-contracts/src/__tests__/url-normalization.test.ts +135 -0
  26. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  27. package/node_modules/@vellumai/service-contracts/src/ingress.ts +103 -0
  28. package/node_modules/@vellumai/service-contracts/src/url-normalization.ts +107 -0
  29. package/openapi.yaml +487 -11
  30. package/package.json +1 -1
  31. package/scripts/sync-web-search-catalog.ts +6 -0
  32. package/src/__tests__/anthropic-provider.test.ts +10 -3
  33. package/src/__tests__/approval-interception-trust-gates.test.ts +40 -0
  34. package/src/__tests__/background-workers-disk-pressure.test.ts +1 -1
  35. package/src/__tests__/channel-approval-routes.test.ts +4 -0
  36. package/src/__tests__/channel-inbound-disk-pressure.test.ts +5 -6
  37. package/src/__tests__/channel-readiness-service.test.ts +126 -0
  38. package/src/__tests__/channel-reply-delivery.test.ts +30 -17
  39. package/src/__tests__/checker.test.ts +20 -314
  40. package/src/__tests__/cli-memory-v2-reembed-skills.test.ts +6 -2
  41. package/src/__tests__/client-os-metadata-persistence.test.ts +16 -0
  42. package/src/__tests__/compactor-retained-image-validation.test.ts +142 -0
  43. package/src/__tests__/config-loader-backfill.test.ts +19 -10
  44. package/src/__tests__/container-cpu-sampler.test.ts +153 -0
  45. package/src/__tests__/context-search-memory-v2-source.test.ts +0 -1
  46. package/src/__tests__/conversation-attachments.test.ts +0 -1
  47. package/src/__tests__/conversation-delete-watch-timeline.test.ts +231 -0
  48. package/src/__tests__/conversation-error.test.ts +17 -0
  49. package/src/__tests__/conversation-lifecycle.test.ts +20 -26
  50. package/src/__tests__/conversation-pairing.test.ts +186 -0
  51. package/src/__tests__/conversation-runtime-assembly.test.ts +21 -2
  52. package/src/__tests__/credential-broker-server-use.test.ts +24 -5
  53. package/src/__tests__/credential-routes.test.ts +22 -3
  54. package/src/__tests__/credential-security-invariants.test.ts +2 -1
  55. package/src/__tests__/daemon-credential-client.test.ts +88 -0
  56. package/src/__tests__/default-plugin-names-guard.test.ts +12 -1
  57. package/src/__tests__/dm-backfill.test.ts +63 -0
  58. package/src/__tests__/dynamic-skill-background-guard.test.ts +0 -2
  59. package/src/__tests__/edit-propagation.test.ts +107 -4
  60. package/src/__tests__/events-client-registration.test.ts +28 -0
  61. package/src/__tests__/file-write-tool.test.ts +4 -2
  62. package/src/__tests__/guardian-prompt-notice-privacy.test.ts +133 -0
  63. package/src/__tests__/guardian-verify-setup-skill-regression.test.ts +143 -97
  64. package/src/__tests__/helpers/gateway-classify-mock.ts +27 -6
  65. package/src/__tests__/host-proxy-interface.test.ts +11 -1
  66. package/src/__tests__/host-shell-tool.test.ts +23 -4
  67. package/src/__tests__/image-conversion.test.ts +143 -1
  68. package/src/__tests__/inline-skill-load-permissions.test.ts +47 -36
  69. package/src/__tests__/input-repairs.test.ts +207 -0
  70. package/src/__tests__/live-workspace-guard.test.ts +75 -0
  71. package/src/__tests__/managed-profile-guard.test.ts +4 -2
  72. package/src/__tests__/mcp-abort-signal.test.ts +1 -1
  73. package/src/__tests__/mcp-client-auth.test.ts +1 -1
  74. package/src/__tests__/mcp-tool-annotations-risk.test.ts +1 -1
  75. package/src/__tests__/media-resolve-image-validation.test.ts +310 -0
  76. package/src/__tests__/mtime-cache.test.ts +2 -0
  77. package/src/__tests__/notification-vellum-adapter.test.ts +124 -1
  78. package/src/__tests__/openai-provider.test.ts +40 -0
  79. package/src/__tests__/openai-responses-provider.test.ts +18 -0
  80. package/src/__tests__/personal-memory-auth-bypass.test.ts +22 -6
  81. package/src/__tests__/platform-bash-auto-approve.test.ts +0 -4
  82. package/src/__tests__/platform.test.ts +16 -1
  83. package/src/__tests__/plugin-api-resolve-credential.test.ts +22 -13
  84. package/src/__tests__/plugin-api-shim.test.ts +5 -0
  85. package/src/__tests__/plugin-api-store-credential.test.ts +268 -0
  86. package/src/__tests__/plugin-config-data-migration.test.ts +8 -1
  87. package/src/__tests__/plugin-disabled-state.test.ts +2 -0
  88. package/src/__tests__/plugin-effective-enabled-set.test.ts +55 -3
  89. package/src/__tests__/plugin-execution-context.test.ts +73 -0
  90. package/src/__tests__/plugin-import-boundary-guard.test.ts +0 -1
  91. package/src/__tests__/plugin-import-boundary-reverse-guard.test.ts +0 -1
  92. package/src/__tests__/reaction-persistence.test.ts +200 -7
  93. package/src/__tests__/require-fresh-approval.test.ts +0 -4
  94. package/src/__tests__/resource-pressure-guard.test.ts +428 -0
  95. package/src/__tests__/resource-pressure-routes.test.ts +113 -0
  96. package/src/__tests__/risk-classification-boundary-guard.test.ts +115 -0
  97. package/src/__tests__/run-conversation-turn-persistence.test.ts +27 -1
  98. package/src/__tests__/sanitize-config-for-transfer.test.ts +28 -0
  99. package/src/__tests__/secret-routes-platform-proxy.test.ts +7 -0
  100. package/src/__tests__/settings-routes.test.ts +85 -3
  101. package/src/__tests__/skill-tool-factory.test.ts +161 -0
  102. package/src/__tests__/tool-execution-pipeline.benchmark.test.ts +1 -1
  103. package/src/__tests__/tool-executor-lifecycle-events.test.ts +132 -5
  104. package/src/__tests__/tool-executor.test.ts +63 -38
  105. package/src/__tests__/tool-policy.test.ts +97 -1
  106. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +7 -4
  107. package/src/__tests__/user-plugin-loader.test.ts +2 -0
  108. package/src/__tests__/validate-input.test.ts +243 -7
  109. package/src/__tests__/verification-control-plane-policy.test.ts +0 -2
  110. package/src/__tests__/voice-scoped-grant-consumer.test.ts +2 -0
  111. package/src/__tests__/voice-session-bridge.test.ts +42 -0
  112. package/src/__tests__/web-search-catalog-parity.test.ts +8 -0
  113. package/src/acp/__tests__/acp-claude-oauth.test.ts +97 -29
  114. package/src/acp/__tests__/prepare-agent-env.test.ts +376 -153
  115. package/src/acp/acp-claude-oauth.ts +38 -21
  116. package/src/acp/prepare-agent-env.ts +146 -55
  117. package/src/agent/loop-tool-dedup.test.ts +161 -0
  118. package/src/agent/loop.ts +68 -22
  119. package/src/api/constants/app-tools.ts +34 -0
  120. package/src/api/constants/profile-config-validation.ts +60 -0
  121. package/src/api/events/resource-pressure-status-changed.ts +53 -0
  122. package/src/api/events/tool-result.ts +6 -1
  123. package/src/api/events/watch-retro-completed.ts +52 -0
  124. package/src/api/index.ts +30 -0
  125. package/src/api/responses/resource-pressure-status.ts +25 -0
  126. package/src/approvals/guardian-channel-delivery.ts +70 -6
  127. package/src/approvals/guardian-request-resolvers.ts +32 -66
  128. package/src/calls/__tests__/voice-session-bridge.test.ts +114 -0
  129. package/src/calls/voice-session-bridge.ts +60 -6
  130. package/src/channels/__tests__/message-audience.test.ts +49 -0
  131. package/src/channels/__tests__/types.test.ts +17 -3
  132. package/src/channels/message-audience.ts +40 -0
  133. package/src/channels/types.ts +16 -12
  134. package/src/cli/__tests__/catalog-search-help.test.ts +50 -0
  135. package/src/cli/commands/__tests__/channel-verification-sessions.test.ts +31 -0
  136. package/src/cli/commands/__tests__/conversations-search.test.ts +289 -0
  137. package/src/cli/commands/__tests__/conversations-slack.test.ts +2 -1
  138. package/src/cli/commands/__tests__/inference-profiles.test.ts +16 -4
  139. package/src/cli/commands/__tests__/inference-providers.test.ts +135 -2
  140. package/src/cli/commands/__tests__/keys.test.ts +89 -8
  141. package/src/cli/commands/__tests__/plugins.test.ts +57 -1
  142. package/src/cli/commands/channel-verification-sessions.help.ts +11 -9
  143. package/src/cli/commands/channel-verification-sessions.ts +11 -21
  144. package/src/cli/commands/conversations.help.ts +34 -0
  145. package/src/cli/commands/conversations.ts +125 -0
  146. package/src/cli/commands/inference-profiles.ts +56 -3
  147. package/src/cli/commands/inference-providers.ts +37 -6
  148. package/src/cli/commands/inference.help.ts +9 -4
  149. package/src/cli/commands/keys.help.ts +13 -1
  150. package/src/cli/commands/keys.ts +26 -15
  151. package/src/cli/commands/memory/__tests__/memory-v2.test.ts +57 -7
  152. package/src/cli/commands/memory/index.help.ts +41 -27
  153. package/src/cli/commands/memory/index.ts +2 -0
  154. package/src/cli/commands/memory/memory-v2.ts +58 -54
  155. package/src/cli/commands/memory/memory-validate.ts +18 -0
  156. package/src/cli/commands/monitoring.ts +1 -0
  157. package/src/cli/commands/oauth/request.test.ts +93 -0
  158. package/src/cli/commands/oauth/request.ts +23 -9
  159. package/src/cli/commands/plugins.help.ts +28 -31
  160. package/src/cli/commands/plugins.ts +10 -0
  161. package/src/cli/commands/skills.help.ts +13 -16
  162. package/src/cli/commands/trust.ts +3 -14
  163. package/src/cli/lib/__tests__/install-from-github.test.ts +38 -0
  164. package/src/cli/lib/__tests__/merge-plugin-tree.test.ts +34 -0
  165. package/src/cli/lib/__tests__/plugin-surfaces.test.ts +32 -1
  166. package/src/cli/lib/__tests__/toggle-plugin.test.ts +2 -1
  167. package/src/cli/lib/__tests__/upgrade-plugin.test.ts +64 -0
  168. package/src/cli/lib/bundled-marketplace.json +26 -0
  169. package/src/cli/lib/daemon-credential-client.ts +25 -3
  170. package/src/cli/lib/install-from-github.ts +35 -24
  171. package/src/cli/lib/merge-plugin-tree.ts +22 -4
  172. package/src/cli/lib/open-browser.test.ts +67 -0
  173. package/src/cli/lib/open-browser.ts +24 -5
  174. package/src/cli/lib/plugin-surfaces.ts +27 -0
  175. package/src/config/__tests__/balanced-model-experiment.test.ts +7 -7
  176. package/src/config/__tests__/default-profile-catalog.test.ts +3 -3
  177. package/src/config/__tests__/profile-materialization.test.ts +26 -0
  178. package/src/config/default-profile-catalog.ts +5 -6
  179. package/src/config/feature-flag-registry.json +36 -28
  180. package/src/config/profile-materialization.ts +29 -0
  181. package/src/config/sanitize-for-transfer.ts +16 -0
  182. package/src/config/schemas/llm.ts +7 -0
  183. package/src/config/schemas/services.ts +6 -0
  184. package/src/config/webhook-routing.ts +8 -0
  185. package/src/context/compactor.ts +31 -2
  186. package/src/context/outbound-sanitize.ts +6 -0
  187. package/src/daemon/__tests__/lifecycle-watch-timeline-sweep.test.ts +98 -0
  188. package/src/daemon/__tests__/provider-rejection-log-fields.test.ts +272 -0
  189. package/src/daemon/conversation-agent-loop-handlers.ts +4 -1
  190. package/src/daemon/conversation-error.ts +19 -2
  191. package/src/daemon/conversation-messaging.ts +22 -2
  192. package/src/daemon/conversation-process.ts +11 -0
  193. package/src/daemon/conversation-store.ts +10 -0
  194. package/src/daemon/conversation-surfaces.ts +21 -8
  195. package/src/daemon/conversation.ts +12 -10
  196. package/src/daemon/daemon-control.ts +1 -0
  197. package/src/daemon/handlers/__tests__/config-ingress-tunnel-records.test.ts +208 -0
  198. package/src/daemon/handlers/config-ingress.ts +115 -5
  199. package/src/daemon/lifecycle.ts +30 -2
  200. package/src/daemon/message-types/conversations.ts +5 -7
  201. package/src/daemon/message-types/web-activity.ts +3 -2
  202. package/src/daemon/provider-rejection-log-fields.ts +124 -0
  203. package/src/daemon/resource-pressure-guard-lifecycle.ts +66 -0
  204. package/src/daemon/resource-pressure-guard.ts +387 -0
  205. package/src/daemon/shutdown-handlers.ts +2 -0
  206. package/src/daemon/startup-error.ts +16 -0
  207. package/src/daemon/trust-context.ts +14 -10
  208. package/src/daemon/unsendable-image-notice.ts +76 -0
  209. package/src/hooks/registry.ts +65 -51
  210. package/src/inbound/__tests__/tunnel-probe.test.ts +448 -0
  211. package/src/inbound/tunnel-probe.ts +261 -0
  212. package/src/ipc/__tests__/socket-path.test.ts +15 -7
  213. package/src/ipc/gateway-client.test.ts +1 -1
  214. package/src/ipc/gateway-client.ts +14 -21
  215. package/src/ipc/socket-cleanup.ts +2 -11
  216. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -1
  217. package/src/messaging/provider-message-metadata.ts +128 -0
  218. package/src/messaging/providers/__tests__/transport-dispatch.test.ts +138 -73
  219. package/src/messaging/providers/channel-transport.ts +100 -16
  220. package/src/messaging/providers/discord/send.ts +16 -0
  221. package/src/messaging/providers/discord/transport.ts +23 -1
  222. package/src/messaging/providers/index.ts +84 -16
  223. package/src/messaging/providers/slack/message-metadata.ts +45 -0
  224. package/src/messaging/providers/slack/render-transcript.ts +1 -4
  225. package/src/messaging/providers/slack/send.test.ts +88 -34
  226. package/src/messaging/providers/slack/send.ts +99 -50
  227. package/src/messaging/providers/slack/transport.ts +35 -37
  228. package/src/messaging/providers/telegram-bot/send.test.ts +88 -18
  229. package/src/messaging/providers/telegram-bot/send.ts +36 -0
  230. package/src/messaging/providers/telegram-bot/transport.ts +22 -8
  231. package/src/messaging/read-provider-metadata.test.ts +157 -0
  232. package/src/messaging/read-provider-metadata.ts +51 -0
  233. package/src/notifications/__tests__/assistant-reply-producer.test.ts +94 -0
  234. package/src/notifications/__tests__/edit-notification.test.ts +174 -2
  235. package/src/notifications/__tests__/home-feed-side-effect.test.ts +536 -4
  236. package/src/notifications/adapters/macos.ts +55 -0
  237. package/src/notifications/adapters/slack.ts +10 -5
  238. package/src/notifications/assistant-reply-producer.ts +37 -4
  239. package/src/notifications/conversation-pairing.ts +111 -21
  240. package/src/notifications/edit-notification.ts +38 -8
  241. package/src/notifications/emit-signal.ts +12 -14
  242. package/src/notifications/home-feed-side-effect.ts +218 -15
  243. package/src/notifications/types.ts +5 -0
  244. package/src/permissions/AGENTS.md +16 -0
  245. package/src/permissions/checker.test.ts +75 -122
  246. package/src/permissions/checker.ts +44 -560
  247. package/src/permissions/confirmation-guardian-request.test.ts +28 -3
  248. package/src/permissions/confirmation-guardian-request.ts +5 -1
  249. package/src/persistence/conversation-crud.ts +69 -20
  250. package/src/persistence/conversation-queries.ts +14 -1
  251. package/src/persistence/conversation-types.ts +22 -0
  252. package/src/persistence/db-async-query.ts +2 -1
  253. package/src/persistence/db-maintenance.ts +15 -0
  254. package/src/persistence/delivery-crud.ts +122 -15
  255. package/src/persistence/embeddings/qdrant-manager.ts +1 -0
  256. package/src/persistence/migrations/367-create-watch-timeline-entries.ts +46 -0
  257. package/src/persistence/migrations/368-watch-timeline-screenshot-blob.ts +33 -0
  258. package/src/persistence/migrations/__tests__/367-create-watch-timeline-entries.test.ts +98 -0
  259. package/src/persistence/migrations/__tests__/368-watch-timeline-screenshot-blob.test.ts +98 -0
  260. package/src/persistence/schema/index.ts +1 -0
  261. package/src/persistence/schema/watch.ts +29 -0
  262. package/src/persistence/steps.ts +4 -0
  263. package/src/plugin-api/__tests__/import-graph-partial-mock.test.ts +67 -0
  264. package/src/plugin-api/conversation-turn.ts +27 -0
  265. package/src/plugin-api/credential-scope.test.ts +15 -0
  266. package/src/plugin-api/credential-scope.ts +14 -0
  267. package/src/plugin-api/index.ts +19 -1
  268. package/src/plugin-api/resolve-credential.ts +15 -10
  269. package/src/plugin-api/store-credential.ts +148 -0
  270. package/src/plugin-api/system-card.ts +36 -0
  271. package/src/plugin-api/vision-support.test.ts +82 -0
  272. package/src/plugin-api/vision-support.ts +14 -2
  273. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +361 -110
  274. package/src/plugins/defaults/image-fallback/__tests__/vision-recovery.test.ts +4 -0
  275. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +58 -0
  276. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +64 -23
  277. package/src/plugins/defaults/image-recovery/detect.ts +24 -1
  278. package/src/plugins/defaults/main.ts +15 -0
  279. package/src/plugins/defaults/memory/AGENTS.md +11 -3
  280. package/src/plugins/defaults/memory/__tests__/memory-tier-boundary-guard.test.ts +0 -1
  281. package/src/plugins/defaults/memory/graph-topology/pending-buffer.ts +9 -12
  282. package/src/plugins/defaults/memory/memory-retrospective-prompt.ts +1 -1
  283. package/src/plugins/defaults/memory/src/memory-v2-routes.ts +12 -10
  284. package/src/plugins/defaults/memory/substrate/__tests__/consolidation-job.test.ts +114 -0
  285. package/src/plugins/defaults/memory/substrate/__tests__/consolidation-prompt-flag-gating-guard.test.ts +8 -0
  286. package/src/plugins/defaults/memory/substrate/__tests__/edge-index.test.ts +0 -30
  287. package/src/plugins/defaults/memory/substrate/__tests__/ingest.test.ts +73 -1
  288. package/src/plugins/defaults/memory/substrate/__tests__/page-index.test.ts +37 -0
  289. package/src/plugins/defaults/memory/substrate/__tests__/page-links.test.ts +208 -0
  290. package/src/plugins/defaults/memory/substrate/__tests__/prompts-consolidation.test.ts +158 -1
  291. package/src/plugins/defaults/memory/substrate/__tests__/static-context.test.ts +1 -61
  292. package/src/plugins/defaults/memory/substrate/consolidation-job.ts +68 -6
  293. package/src/plugins/defaults/memory/substrate/edge-index.ts +0 -31
  294. package/src/plugins/defaults/memory/substrate/ingest.ts +59 -0
  295. package/src/plugins/defaults/memory/substrate/page-index.ts +35 -8
  296. package/src/plugins/defaults/memory/substrate/page-links.ts +133 -0
  297. package/src/plugins/defaults/memory/substrate/page-store.ts +10 -0
  298. package/src/plugins/defaults/memory/substrate/prompts/consolidation.ts +124 -34
  299. package/src/plugins/defaults/memory/substrate/static-context.ts +0 -29
  300. package/src/plugins/defaults/memory/v3/__tests__/shadow-plugin.test.ts +3 -1
  301. package/src/plugins/defaults/memory/v3/card.ts +9 -9
  302. package/src/plugins/defaults/memory/v3/core-set.test.ts +7 -0
  303. package/src/plugins/defaults/memory/v3/core-set.ts +5 -1
  304. package/src/plugins/defaults/memory/v3/edge.ts +13 -57
  305. package/src/plugins/mtime-cache.ts +1 -1
  306. package/src/plugins/pipeline.ts +14 -7
  307. package/src/plugins/plugin-execution-context.ts +35 -11
  308. package/src/plugins/plugin-tree-walk.ts +63 -4
  309. package/src/providers/__tests__/retry-network-error.test.ts +84 -0
  310. package/src/providers/anthropic/__tests__/pause-turn-continuation.test.ts +170 -0
  311. package/src/providers/anthropic/client.ts +332 -241
  312. package/src/providers/connection-resolution.ts +25 -2
  313. package/src/providers/content-blocks.ts +22 -0
  314. package/src/providers/fetch-provider-catalog.ts +19 -0
  315. package/src/providers/gemini/client.ts +5 -2
  316. package/src/providers/inference/__tests__/adapter-factory-litellm.test.ts +47 -1
  317. package/src/providers/inference/__tests__/adapter-factory-ollama.test.ts +83 -0
  318. package/src/providers/inference/__tests__/adapter-factory-openai-compatible.test.ts +98 -1
  319. package/src/providers/inference/__tests__/base-url-route-validation.test.ts +38 -0
  320. package/src/providers/inference/__tests__/base-url-security.test.ts +10 -0
  321. package/src/providers/inference/__tests__/connections-ollama.test.ts +90 -0
  322. package/src/providers/inference/__tests__/endpoint-probe.test.ts +92 -0
  323. package/src/providers/inference/__tests__/missing-credential-guard.test.ts +117 -0
  324. package/src/providers/inference/__tests__/profile-config-validation.test.ts +39 -0
  325. package/src/providers/inference/__tests__/profile-probe-classify.test.ts +66 -0
  326. package/src/providers/inference/adapter-factory.ts +33 -2
  327. package/src/providers/inference/auth.ts +13 -2
  328. package/src/providers/inference/credential-usage.ts +37 -0
  329. package/src/providers/inference/endpoint-probe.ts +115 -0
  330. package/src/providers/inference/missing-credential-guard.ts +110 -0
  331. package/src/providers/inference/profile-probe.ts +256 -0
  332. package/src/providers/inference/resolve-auth.ts +7 -7
  333. package/src/providers/media-resolve.ts +176 -15
  334. package/src/providers/model-catalog.ts +10 -0
  335. package/src/providers/openai/__tests__/api-error-normalization.test.ts +17 -1
  336. package/src/providers/openai/__tests__/chat-completions-provider-reasoning.test.ts +576 -46
  337. package/src/providers/openai/__tests__/connection-error-wrap.test.ts +44 -0
  338. package/src/providers/openai/__tests__/tool-choice-mapping.test.ts +125 -2
  339. package/src/providers/openai/api-error-normalization.ts +16 -2
  340. package/src/providers/openai/chat-completions-provider.ts +326 -44
  341. package/src/providers/openai/responses-provider.ts +5 -2
  342. package/src/providers/provider-send-message.ts +11 -0
  343. package/src/providers/retry.ts +6 -0
  344. package/src/providers/search-provider-catalog.ts +20 -0
  345. package/src/routes/route-host-protocol.ts +7 -0
  346. package/src/routes/worker.ts +31 -10
  347. package/src/runtime/AGENTS.md +36 -0
  348. package/src/runtime/__tests__/host-observe.test.ts +302 -0
  349. package/src/runtime/__tests__/runtime-http-port-collision.test.ts +131 -0
  350. package/src/runtime/__tests__/web-presence.test.ts +234 -0
  351. package/src/runtime/assistant-event-hub.ts +38 -0
  352. package/src/runtime/channel-readiness-service.ts +39 -13
  353. package/src/runtime/channel-readiness-types.ts +49 -2
  354. package/src/runtime/channel-reply-delivery.ts +55 -32
  355. package/src/runtime/channel-retry-sweep.ts +6 -4
  356. package/src/runtime/effective-capabilities.test.ts +19 -0
  357. package/src/runtime/effective-capabilities.ts +25 -0
  358. package/src/runtime/guardian-reply-router.ts +6 -2
  359. package/src/runtime/host-observe.ts +246 -0
  360. package/src/runtime/http-errors.ts +1 -0
  361. package/src/runtime/http-server.ts +185 -6
  362. package/src/runtime/routes/__tests__/client-routes.test.ts +150 -0
  363. package/src/runtime/routes/__tests__/conversation-list-routes.test.ts +133 -0
  364. package/src/runtime/routes/__tests__/conversation-query-routes.test.ts +80 -0
  365. package/src/runtime/routes/__tests__/credential-delete-in-use.test.ts +155 -0
  366. package/src/runtime/routes/__tests__/inference-profiles-routes.test.ts +118 -0
  367. package/src/runtime/routes/__tests__/inference-provider-connection-routes.test.ts +72 -1
  368. package/src/runtime/routes/__tests__/ingress-status-routes.test.ts +508 -0
  369. package/src/runtime/routes/__tests__/monitoring-routes.test.ts +1 -0
  370. package/src/runtime/routes/__tests__/pending-interactions-route.test.ts +175 -0
  371. package/src/runtime/routes/__tests__/plugins-routes.test.ts +103 -71
  372. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +55 -6
  373. package/src/runtime/routes/__tests__/system-card-turn-termination.test.ts +107 -0
  374. package/src/runtime/routes/__tests__/user-route-dispatcher-host.test.ts +52 -1
  375. package/src/runtime/routes/__tests__/user-route-dispatcher.test.ts +75 -4
  376. package/src/runtime/routes/__tests__/watch-routes-guardian-cache.test.ts +139 -0
  377. package/src/runtime/routes/__tests__/watch-routes.test.ts +598 -0
  378. package/src/runtime/routes/approval-routes.ts +37 -4
  379. package/src/runtime/routes/approval-strategies/guardian-text-engine-strategy.ts +16 -22
  380. package/src/runtime/routes/canned-message-complete.ts +68 -29
  381. package/src/runtime/routes/channel-readiness-routes.ts +14 -2
  382. package/src/runtime/routes/client-routes.ts +113 -0
  383. package/src/runtime/routes/conversation-list-routes.ts +22 -7
  384. package/src/runtime/routes/conversation-management-routes.ts +15 -9
  385. package/src/runtime/routes/conversation-query-routes.ts +10 -0
  386. package/src/runtime/routes/conversation-routes.ts +36 -22
  387. package/src/runtime/routes/credential-in-use.ts +85 -0
  388. package/src/runtime/routes/credential-routes.ts +55 -85
  389. package/src/runtime/routes/guardian-approval-interception.ts +44 -53
  390. package/src/runtime/routes/guardian-approval-reply-helpers.ts +14 -12
  391. package/src/runtime/routes/host-cu-routes.ts +18 -0
  392. package/src/runtime/routes/identity-routes.ts +5 -121
  393. package/src/runtime/routes/inbound-message-handler.ts +74 -30
  394. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +16 -17
  395. package/src/runtime/routes/inbound-stages/background-dispatch.test.ts +182 -297
  396. package/src/runtime/routes/inbound-stages/background-dispatch.ts +173 -386
  397. package/src/runtime/routes/inbound-stages/edit-intercept.ts +101 -77
  398. package/src/runtime/routes/inbound-stages/guardian-reply-intercept.ts +17 -8
  399. package/src/runtime/routes/inbound-stages/reaction-intercept.test.ts +91 -7
  400. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +72 -70
  401. package/src/runtime/routes/index.ts +4 -0
  402. package/src/runtime/routes/inference-profiles-routes.ts +232 -31
  403. package/src/runtime/routes/inference-provider-connection-routes.ts +33 -11
  404. package/src/runtime/routes/ingress-status-routes.ts +180 -0
  405. package/src/runtime/routes/monitoring-routes.ts +9 -1
  406. package/src/runtime/routes/oauth-commands-routes.ts +1 -1
  407. package/src/runtime/routes/plugins-routes.ts +28 -32
  408. package/src/runtime/routes/resource-pressure-routes.ts +22 -0
  409. package/src/runtime/routes/secret-routes.ts +39 -8
  410. package/src/runtime/routes/settings-routes.ts +15 -12
  411. package/src/runtime/routes/surface-action-routes.ts +20 -19
  412. package/src/runtime/routes/user-route-dispatcher.ts +31 -2
  413. package/src/runtime/routes/user-route-resolution.ts +18 -1
  414. package/src/runtime/routes/watch-routes.ts +807 -0
  415. package/src/runtime/slack-reply-session.test.ts +23 -13
  416. package/src/runtime/slack-reply-session.ts +38 -55
  417. package/src/runtime/web-presence.ts +90 -0
  418. package/src/security/__tests__/untrusted-content.test.ts +42 -0
  419. package/src/security/untrusted-content.ts +28 -9
  420. package/src/skills/validate-input.ts +177 -40
  421. package/src/subagent/__tests__/consult-context-gating.test.ts +6 -10
  422. package/src/subagent/consult-context.ts +7 -23
  423. package/src/tools/credentials/broker.ts +24 -79
  424. package/src/tools/credentials/ref-parse.ts +35 -0
  425. package/src/tools/credentials/resolve.ts +4 -10
  426. package/src/tools/credentials/store.ts +168 -0
  427. package/src/tools/credentials/tool-policy.ts +67 -0
  428. package/src/tools/executor.ts +53 -15
  429. package/src/tools/network/__tests__/firecrawl-compat.test.ts +77 -0
  430. package/src/tools/network/__tests__/web-fetch-fastcrw.test.ts +169 -0
  431. package/src/tools/network/__tests__/web-search.test.ts +138 -3
  432. package/src/tools/network/firecrawl-compat.ts +90 -0
  433. package/src/tools/network/url-safety.ts +9 -16
  434. package/src/tools/network/web-fetch.ts +142 -62
  435. package/src/tools/network/web-search.ts +162 -58
  436. package/src/tools/permission-checker.ts +43 -52
  437. package/src/tools/schema-transforms.ts +40 -5
  438. package/src/tools/shared/input-repairs.ts +160 -0
  439. package/src/tools/skills/skill-tool-factory.ts +18 -4
  440. package/src/tools/subagent/spawn.ts +0 -1
  441. package/src/tools/tool-approval-handler.ts +16 -10
  442. package/src/tools/tool-types.ts +26 -13
  443. package/src/tools/types.ts +6 -6
  444. package/src/util/__tests__/cgroup-memory.test.ts +3 -0
  445. package/src/util/cgroup-memory.ts +3 -0
  446. package/src/util/container-cpu-sampler.ts +250 -0
  447. package/src/util/image-conversion.ts +178 -14
  448. package/src/util/platform.ts +93 -10
  449. package/src/util/worker-process.ts +1 -0
  450. package/src/watch/__tests__/watch-retro.test.ts +665 -0
  451. package/src/watch/__tests__/watch-session-manager.test.ts +566 -0
  452. package/src/watch/__tests__/watch-timeline.test.ts +670 -0
  453. package/src/watch/watch-retro.ts +480 -0
  454. package/src/watch/watch-session-manager.ts +575 -0
  455. package/src/watch/watch-timeline.ts +848 -0
  456. package/src/permissions/ipc-risk-types.ts +0 -143
  457. package/src/permissions/risk-types.ts +0 -76
@@ -0,0 +1,598 @@
1
+ import { afterEach, describe, expect, test } from "bun:test";
2
+
3
+ import { initializeDb } from "../../../persistence/db-init.js";
4
+ import type {
5
+ StreamingTranscriber,
6
+ SttStreamServerEvent,
7
+ } from "../../../stt/types.js";
8
+ import type { WatchSessionSummary } from "../../../watch/watch-session-manager.js";
9
+ import { WatchSessionManager } from "../../../watch/watch-session-manager.js";
10
+ import { renderWatchTimeline } from "../../../watch/watch-timeline.js";
11
+ import type { HostObservation } from "../../host-observe.js";
12
+ import {
13
+ closeWatchIngress,
14
+ drainWatchRetros,
15
+ reopenWatchIngressForTest,
16
+ type WatchStreamServerFrame,
17
+ WatchStreamSession,
18
+ type WatchStreamSocket,
19
+ } from "../watch-routes.js";
20
+
21
+ await initializeDb();
22
+
23
+ const PRINCIPAL_ID = "principal-watch-stream-test";
24
+
25
+ /** A socket that keeps every frame the session sent it. */
26
+ class FakeSocket implements WatchStreamSocket {
27
+ readonly frames: WatchStreamServerFrame[] = [];
28
+ closeCode: number | null = null;
29
+ closeReason: string | null = null;
30
+
31
+ send(data: string): void {
32
+ this.frames.push(JSON.parse(data) as WatchStreamServerFrame);
33
+ }
34
+
35
+ close(code?: number, reason?: string): void {
36
+ this.closeCode = code ?? null;
37
+ this.closeReason = reason ?? null;
38
+ }
39
+
40
+ types(): string[] {
41
+ return this.frames.map((frame) => frame.type);
42
+ }
43
+
44
+ /**
45
+ * The same sequence with the capture acknowledgements taken out.
46
+ *
47
+ * Every session reads the screen as it opens and again around narration, so
48
+ * `observation` frames land in the middle of every sequence here, at moments
49
+ * the manager's cadence decides rather than the test. Cases whose subject is
50
+ * the lifecycle read this; cases whose subject is the capture signal read
51
+ * `types()` and say exactly where the frames fall.
52
+ */
53
+ lifecycle(): string[] {
54
+ return this.types().filter((type) => type !== "observation");
55
+ }
56
+
57
+ firstOfType<T extends WatchStreamServerFrame["type"]>(
58
+ type: T,
59
+ ): Extract<WatchStreamServerFrame, { type: T }> | undefined {
60
+ return this.frames.find((frame) => frame.type === type) as
61
+ | Extract<WatchStreamServerFrame, { type: T }>
62
+ | undefined;
63
+ }
64
+ }
65
+
66
+ /** A transcriber the test drives by hand. */
67
+ class FakeTranscriber implements StreamingTranscriber {
68
+ readonly providerId = "deepgram" as const;
69
+ readonly boundaryId = "daemon-streaming" as const;
70
+ readonly audio: { bytes: Buffer; mimeType: string }[] = [];
71
+ stopCount = 0;
72
+ private onEvent: ((event: SttStreamServerEvent) => void) | null = null;
73
+
74
+ async start(onEvent: (event: SttStreamServerEvent) => void): Promise<void> {
75
+ this.onEvent = onEvent;
76
+ }
77
+
78
+ sendAudio(audio: Buffer, mimeType: string): void {
79
+ this.audio.push({ bytes: audio, mimeType });
80
+ }
81
+
82
+ stop(): void {
83
+ this.stopCount += 1;
84
+ }
85
+
86
+ emit(event: SttStreamServerEvent): void {
87
+ this.onEvent?.(event);
88
+ }
89
+ }
90
+
91
+ function observation(): HostObservation {
92
+ return {
93
+ ok: true,
94
+ axTree: "Window: Editor\n[1] Button Save",
95
+ };
96
+ }
97
+
98
+ /**
99
+ * A manager wired to a scripted screen reader, so a session's cadence is a
100
+ * function of what the test says the host answered rather than of a real
101
+ * desktop client.
102
+ */
103
+ function newManager() {
104
+ const observeCalls: (string | undefined)[] = [];
105
+ const manager = new WatchSessionManager({
106
+ observe: async (options) => {
107
+ observeCalls.push(options.sourceActorPrincipalId);
108
+ return observation();
109
+ },
110
+ });
111
+ return { manager, observeCalls };
112
+ }
113
+
114
+ interface HarnessOverrides {
115
+ manager?: WatchSessionManager;
116
+ transcriber?: FakeTranscriber | null;
117
+ principalId?: string | undefined;
118
+ idleTimeoutMs?: number;
119
+ /** How long the stand-in retrospective takes before it settles. */
120
+ retroDelayMs?: number;
121
+ }
122
+
123
+ function newSession(overrides: HarnessOverrides = {}) {
124
+ const ws = new FakeSocket();
125
+ const transcriber =
126
+ overrides.transcriber === undefined
127
+ ? new FakeTranscriber()
128
+ : overrides.transcriber;
129
+ const manager = overrides.manager ?? newManager().manager;
130
+ // The retrospective is a full agent turn, so every session in this file gets
131
+ // a stand-in for it and the tests read what it was handed. `finished` flips
132
+ // once the stand-in returns, which is what a drain has to wait for.
133
+ const retros: WatchSessionSummary[] = [];
134
+ const finished: WatchSessionSummary[] = [];
135
+ const session = new WatchStreamSession(ws, {
136
+ mimeType: "audio/webm",
137
+ manager,
138
+ resolveTranscriber: async () => transcriber,
139
+ resolveActorPrincipalId: async () =>
140
+ "principalId" in overrides ? overrides.principalId : PRINCIPAL_ID,
141
+ runRetro: async (summary) => {
142
+ retros.push(summary);
143
+ if (overrides.retroDelayMs !== undefined) {
144
+ await Bun.sleep(overrides.retroDelayMs);
145
+ }
146
+ finished.push(summary);
147
+ },
148
+ ...(overrides.idleTimeoutMs !== undefined
149
+ ? { idleTimeoutMs: overrides.idleTimeoutMs }
150
+ : {}),
151
+ });
152
+ return { ws, transcriber, manager, session, retros, finished };
153
+ }
154
+
155
+ describe("watch stream session", () => {
156
+ // The ingress latch is module state shared by every test in this file.
157
+ afterEach(() => {
158
+ reopenWatchIngressForTest();
159
+ });
160
+
161
+ test("observes on speech onset and acknowledges nothing", async () => {
162
+ // A controllable clock, so the test can step past the observation floor
163
+ // without waiting it out in real time.
164
+ let nowMs = 0;
165
+ const observeCalls: (string | undefined)[] = [];
166
+ const manager = new WatchSessionManager({
167
+ now: () => nowMs,
168
+ observe: async (options) => {
169
+ observeCalls.push(options.sourceActorPrincipalId);
170
+ return observation();
171
+ },
172
+ });
173
+ const { ws, transcriber, session } = newSession({ manager });
174
+ await session.start();
175
+ await Bun.sleep(5);
176
+
177
+ // The session's opening observation. Step past the floor it just spent so
178
+ // the onset below is free to read the screen rather than being collapsed
179
+ // into it.
180
+ expect(observeCalls).toHaveLength(1);
181
+ nowMs += 6_000;
182
+
183
+ transcriber!.emit({ type: "turn-start" });
184
+ await Bun.sleep(5);
185
+
186
+ expect(observeCalls).toHaveLength(2);
187
+ // No `entry`: onset carries no text, and the final that follows is what
188
+ // files the narration. Acknowledging here would report an entry the
189
+ // timeline does not have. The two reads themselves are acknowledged, which
190
+ // is the case below.
191
+ expect(ws.lifecycle()).toEqual(["ready"]);
192
+
193
+ session.handleMessage(JSON.stringify({ type: "stop" }));
194
+ transcriber!.emit({ type: "closed" });
195
+ });
196
+
197
+ test("starts, records narration, and stops", async () => {
198
+ const { manager, observeCalls } = newManager();
199
+ const { ws, transcriber, session } = newSession({ manager });
200
+ await session.start();
201
+
202
+ const ready = ws.firstOfType("ready");
203
+ expect(ready).toBeDefined();
204
+ expect(manager.isActive(ready!.conversationId)).toBe(true);
205
+
206
+ transcriber!.emit({ type: "final", text: " opening the invoice " });
207
+ // The narration lands synchronously; the screen read it triggers does not.
208
+ await Bun.sleep(5);
209
+
210
+ expect(ws.lifecycle()).toEqual(["ready", "entry"]);
211
+ expect(observeCalls).toEqual([PRINCIPAL_ID]);
212
+
213
+ const rendered = renderWatchTimeline(ready!.sessionId);
214
+ expect(rendered.totalEntries).toBe(2);
215
+ expect(rendered.text).toContain("opening the invoice");
216
+
217
+ session.handleMessage(JSON.stringify({ type: "stop" }));
218
+ expect(transcriber!.stopCount).toBe(1);
219
+ // The provider flushes and then reports its own close.
220
+ transcriber!.emit({ type: "closed" });
221
+
222
+ expect(ws.lifecycle()).toEqual(["ready", "entry", "closed"]);
223
+ expect(manager.isActive()).toBe(false);
224
+ expect(session.isClosed).toBe(true);
225
+ });
226
+
227
+ /**
228
+ * The capture signal, which is the only word a client ever gets that its
229
+ * screen was read. Every case here is about it being true: a frame per read
230
+ * that landed, and no frame at all for a read that did not.
231
+ */
232
+ describe("capture acknowledgements", () => {
233
+ test("sends one frame per screen read that landed", async () => {
234
+ let nowMs = 0;
235
+ const manager = new WatchSessionManager({
236
+ now: () => nowMs,
237
+ observe: async () => observation(),
238
+ });
239
+ const { ws, transcriber, session } = newSession({ manager });
240
+ await session.start();
241
+ await Bun.sleep(5);
242
+
243
+ // The session's own opening read, acknowledged after `ready`: the
244
+ // manager is claimed before that frame goes out and the read behind it
245
+ // settles later.
246
+ expect(ws.types()).toEqual(["ready", "observation"]);
247
+
248
+ // Past the floor, so the onset below reads the screen rather than being
249
+ // collapsed into the read above.
250
+ nowMs += 6_000;
251
+ transcriber!.emit({ type: "turn-start" });
252
+ await Bun.sleep(5);
253
+
254
+ expect(ws.types()).toEqual(["ready", "observation", "observation"]);
255
+
256
+ session.destroy();
257
+ });
258
+
259
+ test("stays silent for a read the host could not serve", async () => {
260
+ // The shape every failure resolves to, timeouts included:
261
+ // `observeHostScreen` answers `{ ok: false }` rather than throwing, and a
262
+ // read that outran its budget is that answer with `timedOut` set.
263
+ const manager = new WatchSessionManager({
264
+ observe: async () => ({
265
+ ok: false as const,
266
+ reason: "No connected client supports screen observation",
267
+ timedOut: true,
268
+ }),
269
+ });
270
+ const { ws, transcriber, session } = newSession({ manager });
271
+ await session.start();
272
+ await Bun.sleep(5);
273
+
274
+ transcriber!.emit({ type: "final", text: "still narrating" });
275
+ await Bun.sleep(5);
276
+
277
+ // The narration is filed and acknowledged; the screen behind it was
278
+ // never read, and nothing here says it was.
279
+ expect(ws.types()).toEqual(["ready", "entry"]);
280
+
281
+ session.destroy();
282
+ });
283
+
284
+ test("stays silent for a read the session ended underneath", async () => {
285
+ const releases: ((observed: HostObservation) => void)[] = [];
286
+ const manager = new WatchSessionManager({
287
+ observe: () =>
288
+ new Promise<HostObservation>((resolve) => {
289
+ releases.push(resolve);
290
+ }),
291
+ });
292
+ const { ws, session } = newSession({ manager });
293
+ await session.start();
294
+ await Bun.sleep(5);
295
+ expect(releases).toHaveLength(1);
296
+
297
+ // The session ends while its opening read is still out. What comes back
298
+ // describes a screen belonging to a session that is over, and the
299
+ // acknowledgement would land after `closed`.
300
+ session.destroy();
301
+ releases[0]!(observation());
302
+ await Bun.sleep(5);
303
+
304
+ expect(ws.types()).toEqual(["ready", "closed"]);
305
+ });
306
+ });
307
+
308
+ test("forwards binary and base64 audio frames to the transcriber", async () => {
309
+ const { ws, transcriber, session } = newSession();
310
+ await session.start();
311
+
312
+ session.handleBinaryAudio(Buffer.from([1, 2, 3]));
313
+ session.handleMessage(
314
+ JSON.stringify({
315
+ type: "audio",
316
+ audio: Buffer.from([4, 5]).toString("base64"),
317
+ mimeType: "audio/pcm",
318
+ }),
319
+ );
320
+
321
+ expect(transcriber!.audio).toHaveLength(2);
322
+ expect([...transcriber!.audio[0]!.bytes]).toEqual([1, 2, 3]);
323
+ expect(transcriber!.audio[0]!.mimeType).toBe("audio/webm");
324
+ expect([...transcriber!.audio[1]!.bytes]).toEqual([4, 5]);
325
+ expect(transcriber!.audio[1]!.mimeType).toBe("audio/pcm");
326
+ expect(ws.lifecycle()).toEqual(["ready"]);
327
+
328
+ session.destroy();
329
+ });
330
+
331
+ test("draws no transcript: partials produce no frames", async () => {
332
+ const { ws, transcriber, session } = newSession();
333
+ await session.start();
334
+
335
+ transcriber!.emit({ type: "partial", text: "half a sen" });
336
+ transcriber!.emit({ type: "turn-end", text: "half a sentence" });
337
+ transcriber!.emit({ type: "final", text: " " });
338
+
339
+ expect(ws.lifecycle()).toEqual(["ready"]);
340
+
341
+ session.destroy();
342
+ });
343
+
344
+ test("an unresolvable actor principal fails without opening a session", async () => {
345
+ const { manager } = newManager();
346
+ const { ws, transcriber, session } = newSession({
347
+ manager,
348
+ principalId: undefined,
349
+ });
350
+ await session.start();
351
+
352
+ expect(ws.types()).toEqual(["error", "closed"]);
353
+ expect(ws.firstOfType("error")!.category).toBe("session-error");
354
+ expect(ws.closeCode).toBe(1008);
355
+ expect(manager.isActive()).toBe(false);
356
+ // The provider stream is never opened for a session that could observe
357
+ // nothing, so there is nothing to stop.
358
+ expect(transcriber!.stopCount).toBe(0);
359
+ expect(session.isClosed).toBe(true);
360
+ });
361
+
362
+ test("provider resolution failure yields a clean error then closed", async () => {
363
+ const { manager } = newManager();
364
+ const { ws, session } = newSession({ manager, transcriber: null });
365
+ await session.start();
366
+
367
+ expect(ws.types()).toEqual(["error", "closed"]);
368
+ expect(ws.firstOfType("error")!.category).toBe("provider-error");
369
+ expect(manager.isActive()).toBe(false);
370
+ expect(session.isClosed).toBe(true);
371
+ });
372
+
373
+ test("a second socket is turned away without disturbing the running session", async () => {
374
+ const { manager } = newManager();
375
+ const first = newSession({ manager });
376
+ await first.session.start();
377
+ const runningConversationId = first.ws.firstOfType("ready")!.conversationId;
378
+
379
+ const second = newSession({ manager });
380
+ await second.session.start();
381
+
382
+ expect(second.ws.types()).toEqual(["error", "closed"]);
383
+ expect(second.ws.firstOfType("error")!.message).toContain(
384
+ "already running",
385
+ );
386
+ // The loser's teardown must not release the winner's slot.
387
+ expect(manager.isActive(runningConversationId)).toBe(true);
388
+ expect(second.transcriber!.stopCount).toBe(1);
389
+
390
+ first.session.destroy();
391
+ expect(manager.isActive()).toBe(false);
392
+ });
393
+
394
+ test("an abandoned socket is torn down by the idle timeout", async () => {
395
+ const { manager } = newManager();
396
+ const { ws, transcriber, session } = newSession({
397
+ manager,
398
+ idleTimeoutMs: 20,
399
+ });
400
+ await session.start();
401
+ expect(manager.isActive()).toBe(true);
402
+
403
+ await Bun.sleep(60);
404
+
405
+ expect(ws.lifecycle()).toEqual(["ready", "error", "closed"]);
406
+ expect(ws.firstOfType("error")!.category).toBe("timeout");
407
+ expect(ws.closeCode).toBe(1000);
408
+ expect(transcriber!.stopCount).toBe(1);
409
+ expect(manager.isActive()).toBe(false);
410
+ expect(session.isClosed).toBe(true);
411
+ });
412
+
413
+ test("inbound audio keeps the idle timeout at bay", async () => {
414
+ const { manager } = newManager();
415
+ const { ws, session } = newSession({ manager, idleTimeoutMs: 40 });
416
+ await session.start();
417
+
418
+ for (let i = 0; i < 4; i += 1) {
419
+ await Bun.sleep(15);
420
+ session.handleBinaryAudio(Buffer.from([i]));
421
+ }
422
+
423
+ expect(ws.lifecycle()).toEqual(["ready"]);
424
+ expect(manager.isActive()).toBe(true);
425
+
426
+ session.destroy();
427
+ });
428
+
429
+ test("teardown runs the retrospective once, on the session it just ended", async () => {
430
+ const { manager } = newManager();
431
+ const { ws, transcriber, session, retros } = newSession({ manager });
432
+ await session.start();
433
+ const ready = ws.firstOfType("ready")!;
434
+
435
+ transcriber!.emit({ type: "final", text: "renaming the export" });
436
+ await Bun.sleep(5);
437
+
438
+ expect(retros).toHaveLength(0);
439
+
440
+ session.handleMessage(JSON.stringify({ type: "stop" }));
441
+ transcriber!.emit({ type: "closed" });
442
+
443
+ expect(retros).toHaveLength(1);
444
+ expect(retros[0]!.sessionId).toBe(ready.sessionId);
445
+ expect(retros[0]!.conversationId).toBe(ready.conversationId);
446
+ expect(retros[0]!.entryCount).toBe(2);
447
+
448
+ // The close that follows the provider's own is a no-op, so a socket that
449
+ // reports both does not report the session twice.
450
+ session.handleClose(1000, "session complete");
451
+ expect(retros).toHaveLength(1);
452
+ });
453
+
454
+ test("a socket turned away as busy runs no retrospective", async () => {
455
+ const { manager } = newManager();
456
+ const first = newSession({ manager });
457
+ await first.session.start();
458
+
459
+ const second = newSession({ manager });
460
+ await second.session.start();
461
+
462
+ expect(second.retros).toHaveLength(0);
463
+
464
+ first.session.handleClose(1000, "done");
465
+ expect(first.retros).toHaveLength(1);
466
+ });
467
+
468
+ test("shutdown tears the session down without starting a retrospective", async () => {
469
+ const { manager } = newManager();
470
+ const { transcriber, session, retros } = newSession({ manager });
471
+ await session.start();
472
+ transcriber!.emit({ type: "final", text: "renaming the export" });
473
+ await Bun.sleep(5);
474
+
475
+ session.destroy();
476
+
477
+ // The process is going away, so a turn started here would be killed
478
+ // partway through. The timeline it would have read outlives the daemon.
479
+ expect(retros).toHaveLength(0);
480
+ expect(manager.isActive()).toBe(false);
481
+ expect(session.isClosed).toBe(true);
482
+ });
483
+
484
+ test("shutdown waits for a retrospective that was already running", async () => {
485
+ const { manager } = newManager();
486
+ const { session, retros, finished } = newSession({
487
+ manager,
488
+ retroDelayMs: 30,
489
+ });
490
+ await session.start();
491
+
492
+ session.handleClose(1000, "done");
493
+ expect(retros).toHaveLength(1);
494
+ // Teardown does not block on the turn, so it is still going here.
495
+ expect(finished).toHaveLength(0);
496
+
497
+ expect(await drainWatchRetros(2_000)).toBe(0);
498
+
499
+ expect(finished).toHaveLength(1);
500
+ });
501
+
502
+ test("a settled retrospective is forgotten, so the registry stays bounded", async () => {
503
+ const { manager } = newManager();
504
+ const first = newSession({ manager });
505
+ await first.session.start();
506
+ first.session.handleClose(1000, "done");
507
+ expect(await drainWatchRetros(2_000)).toBe(0);
508
+
509
+ const second = newSession({ manager });
510
+ await second.session.start();
511
+ second.session.handleClose(1000, "done");
512
+
513
+ // Only the second session's retro is outstanding. The first was dropped
514
+ // when it settled rather than accumulating for the life of the process.
515
+ expect(await drainWatchRetros(2_000)).toBe(0);
516
+ expect(first.finished).toHaveLength(1);
517
+ expect(second.finished).toHaveLength(1);
518
+ });
519
+
520
+ test("the drain gives up rather than holding shutdown open", async () => {
521
+ const { manager } = newManager();
522
+ const { session, finished } = newSession({ manager, retroDelayMs: 400 });
523
+ await session.start();
524
+
525
+ session.handleClose(1000, "done");
526
+ const startedAtMs = Date.now();
527
+ const unsettled = await drainWatchRetros(20);
528
+
529
+ // It returns on its own deadline, and the unfinished turn is cut off
530
+ // rather than allowed to fail the shutdown that is cutting it off.
531
+ expect(unsettled).toBe(1);
532
+ expect(Date.now() - startedAtMs).toBeLessThan(300);
533
+ expect(finished).toHaveLength(0);
534
+ // Let the straggler settle so it does not leak into the next test.
535
+ await Bun.sleep(450);
536
+ });
537
+
538
+ test("a session arriving after ingress closes is refused, not opened", async () => {
539
+ const { manager } = newManager();
540
+ const { ws, transcriber, session, retros } = newSession({ manager });
541
+
542
+ closeWatchIngress();
543
+ await session.start();
544
+
545
+ expect(ws.types()).toEqual(["error", "closed"]);
546
+ expect(ws.firstOfType("error")!.message).toContain("shutting down");
547
+ expect(ws.closeCode).toBe(1001);
548
+ // Nothing was claimed, so nothing is left running for the drain to miss.
549
+ expect(manager.isActive()).toBe(false);
550
+ expect(retros).toHaveLength(0);
551
+ expect(transcriber!.stopCount).toBe(0);
552
+ expect(session.isClosed).toBe(true);
553
+ });
554
+
555
+ test("a session that opens during the drain registers no retrospective", async () => {
556
+ const { manager } = newManager();
557
+ const running = newSession({ manager, retroDelayMs: 60 });
558
+ await running.session.start();
559
+ running.session.handleClose(1000, "done");
560
+
561
+ // Shutdown's order: ingress first, then the open sessions, then the wait.
562
+ closeWatchIngress();
563
+
564
+ // A socket that opens and closes while the wait is already under way. Its
565
+ // retrospective would register after the drain took its snapshot, so the
566
+ // drain would return believing nothing was left. The long stand-in keeps
567
+ // it running past the drain, which is what makes the count tell the truth.
568
+ const latecomer = newSession({ manager, retroDelayMs: 500 });
569
+ setTimeout(() => {
570
+ void latecomer.session.start().then(() => {
571
+ latecomer.session.handleClose(1000, "done");
572
+ });
573
+ }, 15);
574
+
575
+ expect(await drainWatchRetros(2_000)).toBe(0);
576
+
577
+ expect(running.finished).toHaveLength(1);
578
+ expect(latecomer.retros).toHaveLength(0);
579
+
580
+ // Let any straggler settle so it cannot leak into the next test.
581
+ await Bun.sleep(600);
582
+ });
583
+
584
+ test("a dropped socket releases the session slot", async () => {
585
+ const { manager } = newManager();
586
+ const { transcriber, session } = newSession({ manager });
587
+ await session.start();
588
+
589
+ session.handleClose(1006, "abnormal closure");
590
+
591
+ expect(manager.isActive()).toBe(false);
592
+ expect(transcriber!.stopCount).toBe(1);
593
+
594
+ // A second close is a no-op rather than a second stop.
595
+ session.handleClose(1006, "abnormal closure");
596
+ expect(transcriber!.stopCount).toBe(1);
597
+ });
598
+ });
@@ -9,6 +9,7 @@
9
9
  */
10
10
  import { z } from "zod";
11
11
 
12
+ import { PendingToolQuestionSchema } from "../../api/responses/conversation-message.js";
12
13
  import { findConversation } from "../../daemon/conversation-registry.js";
13
14
  import type {
14
15
  SecretDelivery,
@@ -210,9 +211,18 @@ function handleSecret({ body }: RouteHandlerArgs) {
210
211
  * GET /v1/pending-interactions?conversationKey=...&conversationId=...
211
212
  *
212
213
  * Returns pending interactions. When conversationKey or conversationId is
213
- * provided, returns the first pending confirmation and secret for that
214
- * conversation. When neither is provided, returns all pending interactions
215
- * across all conversations (diagnostic mode).
214
+ * provided, returns the outstanding confirmation, secret, and question for
215
+ * that conversation. When neither is provided, returns all pending
216
+ * interactions across all conversations (diagnostic mode).
217
+ *
218
+ * This registry is the authority on whether a prompt is still awaiting the
219
+ * user, so the conversation-scoped shape is what clients project their prompt
220
+ * UI from: a key present with a `null` value states "nothing outstanding of
221
+ * this kind" as positively as an object states the opposite. Every
222
+ * conversation-scoped return path below therefore names all three keys, even
223
+ * the early return for an unresolvable conversation. A client that sees a key
224
+ * missing entirely is talking to an assistant that predates it, which is how
225
+ * `pendingQuestion` consumers detect support without a version check.
216
226
  */
217
227
  function handleListPendingInteractions({ queryParams }: RouteHandlerArgs) {
218
228
  const conversationKey = queryParams?.conversationKey;
@@ -241,7 +251,11 @@ function handleListPendingInteractions({ queryParams }: RouteHandlerArgs) {
241
251
  }
242
252
 
243
253
  if (!resolvedConversationId) {
244
- return { pendingConfirmation: null, pendingSecret: null };
254
+ return {
255
+ pendingConfirmation: null,
256
+ pendingSecret: null,
257
+ pendingQuestion: null,
258
+ };
245
259
  }
246
260
 
247
261
  const interactions = pendingInteractions.getByConversation(
@@ -252,6 +266,13 @@ function handleListPendingInteractions({ queryParams }: RouteHandlerArgs) {
252
266
  (i) => i.kind === "confirmation" || i.kind === "acp_confirmation",
253
267
  );
254
268
  const secret = interactions.find((i) => i.kind === "secret");
269
+ // Newest-first for questions: a new user message supersedes an open
270
+ // ask_question by steering to it, which settles the old prompt through its
271
+ // abort signal rather than synchronously, so both can sit in the registry
272
+ // for the width of that turn. The newer prompt is the one the user is being
273
+ // asked, so it is the one to report.
274
+ const questions = interactions.filter((i) => i.kind === "question");
275
+ const question = questions[questions.length - 1];
255
276
 
256
277
  return {
257
278
  pendingConfirmation: confirmation
@@ -288,6 +309,15 @@ function handleListPendingInteractions({ queryParams }: RouteHandlerArgs) {
288
309
  allowOneTimeSend: secret.secretDetails?.allowOneTimeSend,
289
310
  }
290
311
  : null,
312
+ // Reported only with its `entries`, since the batch is what the card
313
+ // renders; a prompt that somehow carries none is not something a client
314
+ // could raise.
315
+ pendingQuestion: question?.questionDetails
316
+ ? {
317
+ requestId: question.requestId,
318
+ entries: question.questionDetails.entries,
319
+ }
320
+ : null,
291
321
  };
292
322
  }
293
323
 
@@ -396,6 +426,9 @@ export const ROUTES: RouteDefinition[] = [
396
426
  .nullable()
397
427
  .describe("Pending secret request or null")
398
428
  .optional(),
429
+ pendingQuestion: PendingToolQuestionSchema.nullable()
430
+ .describe("Outstanding ask_question prompt or null")
431
+ .optional(),
399
432
  interactions: z
400
433
  .array(
401
434
  z.object({