@vellumai/assistant 0.11.0 → 0.11.1-staging.2

package/src/persistence/migrations/196-strip-integration-prefix-from-provider-keys.ts

@@ -113,7 +113,9 @@ export function migrateStripIntegrationPrefixFromProviderKeysDown(
       .all() as Array<{ provider_key: string }>;
 
     for (const { provider_key: bareKey } of rows) {
-      if (ALWAYS_BARE.has(bareKey)) continue;
+      if (ALWAYS_BARE.has(bareKey)) {
+        continue;
+      }
 
       const prefixedKey = `integration:${bareKey}`;
 
@@ -162,7 +164,9 @@ export function migrateStripIntegrationPrefixFromProviderKeysDown(
       .all() as Array<{ credential_service: string }>;
 
     for (const { credential_service: bareKey } of watcherRows) {
-      if (ALWAYS_BARE.has(bareKey)) continue;
+      if (ALWAYS_BARE.has(bareKey)) {
+        continue;
+      }
       raw
         .prepare(
           /*sql*/ `UPDATE watchers SET credential_service = ? WHERE credential_service = ?`,

package/src/persistence/migrations/206-scrub-corrupted-image-attachments.ts

@@ -70,7 +70,9 @@ export function migrateScrubCorruptedImageAttachments(
       file_path: string | null;
     }>;
 
-    if (rows.length === 0) break;
+    if (rows.length === 0) {
+      break;
+    }
 
     for (const row of rows) {
       lastRowid = row.rowid;

package/src/persistence/migrations/209-strip-thinking-from-consolidated.ts

@@ -146,7 +146,9 @@ export async function migrateStripThinkingFromConsolidated(
       m: number | null;
     }
   ).m;
-  if (maxRow == null) return; // empty table — nothing to sweep
+  if (maxRow == null) {
+    return;
+  } // empty table — nothing to sweep
 
   const watermarkRow = raw
     .query(`SELECT value FROM memory_checkpoints WHERE key = ?`)

package/src/persistence/migrations/220-normalize-user-file-by-principal.ts

@@ -46,11 +46,17 @@ export function isAutoIncrementedUserFile(
   userFile: string,
   displayName?: string,
 ): boolean {
-  if (DATE_LIKE_SUFFIX.test(userFile)) return false;
-  if (!INTEGER_SUFFIX.test(userFile)) return false;
+  if (DATE_LIKE_SUFFIX.test(userFile)) {
+    return false;
+  }
+  if (!INTEGER_SUFFIX.test(userFile)) {
+    return false;
+  }
   if (displayName !== undefined) {
     const expectedBase = `${computeUserFileBaseSlug(displayName)}.md`;
-    if (expectedBase === userFile) return false;
+    if (expectedBase === userFile) {
+      return false;
+    }
   }
   return true;
 }
@@ -89,7 +95,9 @@ export function migrateNormalizeUserFileByPrincipal(database: DrizzleDb): void {
       `SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'contacts'`,
     )
     .get();
-  if (!tableExists) return;
+  if (!tableExists) {
+    return;
+  }
 
   const userFileColExists = raw
     .query(
@@ -101,7 +109,9 @@ export function migrateNormalizeUserFileByPrincipal(database: DrizzleDb): void {
       `SELECT 1 FROM pragma_table_info('contacts') WHERE name = 'principal_id'`,
     )
     .get();
-  if (!userFileColExists || !principalColExists) return;
+  if (!userFileColExists || !principalColExists) {
+    return;
+  }
 
   try {
     raw.exec("BEGIN");
@@ -141,7 +151,9 @@ export function migrateNormalizeUserFileByPrincipal(database: DrizzleDb): void {
         created_at: number;
         id: string;
       }>;
-      if (candidates.length === 0) continue;
+      if (candidates.length === 0) {
+        continue;
+      }
 
       candidates.sort((a, b) => {
         const aAuto = isAutoIncrementedUserFile(a.user_file, a.display_name)
@@ -150,8 +162,12 @@ export function migrateNormalizeUserFileByPrincipal(database: DrizzleDb): void {
         const bAuto = isAutoIncrementedUserFile(b.user_file, b.display_name)
           ? 1
           : 0;
-        if (aAuto !== bAuto) return aAuto - bAuto;
-        if (a.created_at !== b.created_at) return a.created_at - b.created_at;
+        if (aAuto !== bAuto) {
+          return aAuto - bAuto;
+        }
+        if (a.created_at !== b.created_at) {
+          return a.created_at - b.created_at;
+        }
         return a.id < b.id ? -1 : a.id > b.id ? 1 : 0;
       });
 

package/src/persistence/migrations/222-strip-placeholder-sentinels-from-messages.ts

@@ -148,7 +148,9 @@ export async function migrateStripPlaceholderSentinelsFromMessages(
       m: number | null;
     }
   ).m;
-  if (maxRow == null) return; // empty table — nothing to sweep
+  if (maxRow == null) {
+    return;
+  } // empty table — nothing to sweep
 
   for (let lo = 0; lo < maxRow; lo += ROWID_WINDOW) {
     const hi = Math.min(lo + ROWID_WINDOW, maxRow);

package/src/persistence/migrations/231-repair-memory-graph-event-dates.ts

@@ -51,15 +51,23 @@ export function repairMemoryGraphEventDate(
 
   const createdYear = utcYear(createdMs);
   const eventYear = utcYear(eventDateMs);
-  if (createdYear !== REPAIR_CREATED_YEAR) return null;
-  if (!CORRUPT_EVENT_YEARS.includes(eventYear as 2024 | 2025)) return null;
+  if (createdYear !== REPAIR_CREATED_YEAR) {
+    return null;
+  }
+  if (!CORRUPT_EVENT_YEARS.includes(eventYear as 2024 | 2025)) {
+    return null;
+  }
 
   // If the memory's prose explicitly mentions the prior year, the date is
   // user-anchored history — not the partial-date inference bug — so leave it.
-  if (contentMentionsYear(content, eventYear)) return null;
+  if (contentMentionsYear(content, eventYear)) {
+    return null;
+  }
 
   const corrected = replaceUtcYear(eventDateMs, createdYear);
-  if (corrected === eventDateMs) return null;
+  if (corrected === eventDateMs) {
+    return null;
+  }
 
   // This targets the observed extractor failure: a recent or near-future
   // month/day was anchored to a prior year. Leave distant historical dates
@@ -97,7 +105,9 @@ export function migrate231RepairMemoryGraphEventDates(
       row.event_date,
       row.content ?? "",
     );
-    if (corrected == null) continue;
+    if (corrected == null) {
+      continue;
+    }
     repairs.push({
       id: row.id,
       oldEventDate: row.event_date,
@@ -105,7 +115,9 @@ export function migrate231RepairMemoryGraphEventDates(
     });
   }
 
-  if (repairs.length === 0) return;
+  if (repairs.length === 0) {
+    return;
+  }
 
   const updateNode = raw.prepare(/*sql*/ `
       UPDATE memory_graph_nodes

package/src/persistence/migrations/241-activation-state-fk-cascade.ts

@@ -15,8 +15,12 @@ export function migrateActivationStateFkCascade(database: DrizzleDb): void {
       `SELECT sql FROM sqlite_master WHERE type='table' AND name='activation_state'`,
     )
     .get() as { sql: string } | null;
-  if (!row) return;
-  if (row.sql.includes("ON DELETE CASCADE")) return;
+  if (!row) {
+    return;
+  }
+  if (row.sql.includes("ON DELETE CASCADE")) {
+    return;
+  }
 
   raw.exec("PRAGMA foreign_keys = OFF");
   try {

package/src/persistence/migrations/246-backfill-provider-connection-label.ts

@@ -32,7 +32,9 @@ export function migrateBackfillProviderConnectionLabel(
   const checkpoint = raw
     .query(`SELECT 1 FROM memory_checkpoints WHERE key = ?`)
     .get(checkpointKey);
-  if (checkpoint) return;
+  if (checkpoint) {
+    return;
+  }
 
   // Guard: skip if the table doesn't exist yet (first-boot edge case where
   // migration 243 hasn't run, e.g. fresh install ordering test harness).

package/src/persistence/migrations/247-external-conversation-binding-thread-id.ts

@@ -18,7 +18,9 @@ export function migrateExternalConversationBindingThreadId(
       `SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'external_conversation_bindings'`,
     )
     .get();
-  if (!tableExists) return;
+  if (!tableExists) {
+    return;
+  }
 
   const columns = raw
     .query(`PRAGMA table_info(external_conversation_bindings)`)

package/src/persistence/migrations/249-normalize-slack-external-content.ts

@@ -33,7 +33,9 @@ export function migrateNormalizeSlackExternalContent(
       `SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'messages'`,
     )
     .get();
-  if (!tableExists) return;
+  if (!tableExists) {
+    return;
+  }
 
   let lastRowid = 0;
 
@@ -55,12 +57,16 @@ export function migrateNormalizeSlackExternalContent(
       )
       .all(lastRowid, BATCH_SIZE) as CandidateMessageRow[];
 
-    if (rows.length === 0) break;
+    if (rows.length === 0) {
+      break;
+    }
 
     for (const row of rows) {
       lastRowid = row.rowid;
       const normalized = normalizeSlackMessageRow(row);
-      if (!normalized) continue;
+      if (!normalized) {
+        continue;
+      }
 
       raw
         .query(`UPDATE messages SET content = ?, metadata = ? WHERE id = ?`)
@@ -78,7 +84,9 @@ function normalizeSlackMessageRow(
   row: CandidateMessageRow,
 ): NormalizedMessageRow | null {
   const parsed = parseSlackMetadataEnvelope(row.metadata);
-  if (!parsed) return null;
+  if (!parsed) {
+    return null;
+  }
 
   const normalizedContent = normalizeMessageContent(row.content);
   if (normalizedContent !== null) {
@@ -129,9 +137,13 @@ function parseSlackMetadataEnvelope(rawMetadata: string): {
   }
 
   const metadata = parsed as Record<string, unknown>;
-  if (typeof metadata.slackMeta !== "string") return null;
+  if (typeof metadata.slackMeta !== "string") {
+    return null;
+  }
   const slackMeta = readSlackMetadata(metadata.slackMeta);
-  if (!slackMeta) return null;
+  if (!slackMeta) {
+    return null;
+  }
   return { metadata, slackMeta };
 }
 
@@ -181,8 +193,12 @@ function isLegacyGuardianBackfillRow(
     slackMeta: SlackMessageMetadata;
   },
 ): boolean {
-  if (row.role !== "user") return false;
-  if (parsed.slackMeta.eventKind !== "message") return false;
+  if (row.role !== "user") {
+    return false;
+  }
+  if (parsed.slackMeta.eventKind !== "message") {
+    return false;
+  }
   if (
     Object.prototype.hasOwnProperty.call(
       parsed.metadata,
@@ -207,7 +223,9 @@ function isLegacyGuardianBackfillRow(
 }
 
 function hasNonEmptyRawText(content: string): boolean {
-  if (parseExternalContentEnvelope(content)) return false;
+  if (parseExternalContentEnvelope(content)) {
+    return false;
+  }
 
   let parsed: unknown;
   try {
@@ -220,7 +238,9 @@ function hasNonEmptyRawText(content: string): boolean {
     return parsed.trim().length > 0 && !parseExternalContentEnvelope(parsed);
   }
 
-  if (!Array.isArray(parsed)) return false;
+  if (!Array.isArray(parsed)) {
+    return false;
+  }
 
   return parsed.some((block) => {
     if (block === null || typeof block !== "object" || Array.isArray(block)) {

package/src/persistence/migrations/256-memory-v2-injection-events.ts

@@ -48,7 +48,9 @@ export function migrateMemoryV2InjectionEvents(database: DrizzleDb): void {
       `SELECT name FROM sqlite_master WHERE type='table' AND name='memory_v2_activation_logs'`,
     )
     .get();
-  if (!logsTable) return;
+  if (!logsTable) {
+    return;
+  }
 
   // Re-run safety net independent of the checkpoint: if events already
   // exist, do not append duplicates. The step runner normally skips
@@ -56,21 +58,27 @@ export function migrateMemoryV2InjectionEvents(database: DrizzleDb): void {
   const existing = raw
     .query(`SELECT COUNT(*) as n FROM memory_v2_injection_events`)
     .get() as { n: number };
-  if (existing.n > 0) return;
+  if (existing.n > 0) {
+    return;
+  }
 
   const rows = raw
     .query(
       `SELECT concepts_json, created_at FROM memory_v2_activation_logs ORDER BY created_at ASC`,
     )
     .all() as Array<{ concepts_json: string; created_at: number }>;
-  if (rows.length === 0) return;
+  if (rows.length === 0) {
+    return;
+  }
 
   const insert = raw.prepare(
     `INSERT INTO memory_v2_injection_events (slug, injected_at) VALUES (?, ?)`,
   );
   const replay = raw.transaction(
     (events: ReadonlyArray<{ slug: string; t: number }>) => {
-      for (const e of events) insert.run(e.slug, e.t);
+      for (const e of events) {
+        insert.run(e.slug, e.t);
+      }
     },
   );
 
@@ -87,16 +95,24 @@ export function migrateMemoryV2InjectionEvents(database: DrizzleDb): void {
       parseFailures += 1;
       continue;
     }
-    if (!Array.isArray(concepts)) continue;
+    if (!Array.isArray(concepts)) {
+      continue;
+    }
     for (const c of concepts) {
-      if (typeof c.slug !== "string") continue;
+      if (typeof c.slug !== "string") {
+        continue;
+      }
       // Carry-over entries were not router-selected this turn — exclude.
-      if (c.source !== "router") continue;
+      if (c.source !== "router") {
+        continue;
+      }
       buffer.push({ slug: c.slug, t: row.created_at });
     }
   }
 
-  if (buffer.length > 0) replay(buffer);
+  if (buffer.length > 0) {
+    replay(buffer);
+  }
   log.info(
     { inserted: buffer.length, rowsScanned: rows.length, parseFailures },
     `Backfilled ${buffer.length} injection events from ${rows.length} activation log rows`,

package/src/persistence/migrations/296-rewrite-balanced-economy-profile-pins.test.ts

@@ -14,7 +14,9 @@ function writeWorkspaceConfig(config: Record<string, unknown>): void {
 
 afterEach(() => {
   const path = getWorkspaceConfigPath();
-  if (existsSync(path)) rmSync(path);
+  if (existsSync(path)) {
+    rmSync(path);
+  }
 });
 
 function createTestDb(withColumns = true) {

package/src/persistence/migrations/296-rewrite-balanced-economy-profile-pins.ts

@@ -36,7 +36,9 @@ const PIN_TABLES = ["conversations", "cron_jobs"] as const;
 export function migrateRewriteBalancedEconomyProfilePins(
   database: DrizzleDb,
 ): void {
-  if (isUserOwnedEconomyProfile()) return;
+  if (isUserOwnedEconomyProfile()) {
+    return;
+  }
 
   const raw = getSqliteFrom(database);
 
@@ -44,7 +46,9 @@ export function migrateRewriteBalancedEconomyProfilePins(
     const cols = raw.prepare(`PRAGMA table_info(${table})`).all() as {
       name: string;
     }[];
-    if (!cols.some((c) => c.name === "inference_profile")) continue;
+    if (!cols.some((c) => c.name === "inference_profile")) {
+      continue;
+    }
 
     raw
       .prepare(

package/src/persistence/migrations/297-move-llm-request-logs-to-logs-db.ts

@@ -107,5 +107,7 @@ export async function migrateMoveLlmRequestLogsToLogsDb(
   const raw = getSqliteFrom(database);
   const needsDrain = stageTableForRelocation(raw, RELOCATION.table);
 
-  if (needsDrain) await drainStagedTable(raw, RELOCATION);
+  if (needsDrain) {
+    await drainStagedTable(raw, RELOCATION);
+  }
 }

package/src/persistence/migrations/302-create-compaction-events.ts

@@ -60,7 +60,9 @@ export function migrateCreateCompactionEvents(database: DrizzleDb): void {
   const checkpoint = raw
     .query(`SELECT 1 FROM memory_checkpoints WHERE key = ?`)
     .get(checkpointKey);
-  if (checkpoint) return;
+  if (checkpoint) {
+    return;
+  }
 
   try {
     raw.exec("BEGIN");

package/src/persistence/migrations/306-rewrite-frontier-profile-pins.test.ts

@@ -14,7 +14,9 @@ function writeWorkspaceConfig(config: Record<string, unknown>): void {
 
 afterEach(() => {
   const path = getWorkspaceConfigPath();
-  if (existsSync(path)) rmSync(path);
+  if (existsSync(path)) {
+    rmSync(path);
+  }
 });
 
 function createTestDb(withColumns = true) {

package/src/persistence/migrations/306-rewrite-frontier-profile-pins.ts

@@ -33,7 +33,9 @@ const PIN_TABLES = ["conversations", "cron_jobs"] as const;
  * skips a table an install hasn't created the column on yet.
  */
 export function migrateRewriteFrontierProfilePins(database: DrizzleDb): void {
-  if (isUserOwnedFrontierProfile()) return;
+  if (isUserOwnedFrontierProfile()) {
+    return;
+  }
 
   const raw = getSqliteFrom(database);
 
@@ -41,7 +43,9 @@ export function migrateRewriteFrontierProfilePins(database: DrizzleDb): void {
     const cols = raw.prepare(`PRAGMA table_info(${table})`).all() as {
       name: string;
     }[];
-    if (!cols.some((c) => c.name === "inference_profile")) continue;
+    if (!cols.some((c) => c.name === "inference_profile")) {
+      continue;
+    }
 
     raw
       .prepare(

package/src/persistence/migrations/311-create-subagents-table.ts

@@ -12,9 +12,11 @@ import { getSqlite } from "../db-connection.js";
  * from the child conversation's messages) and mark any that were still in
  * flight as `interrupted` rather than silently orphaning them.
  *
- * Rows are written on spawn and on every status transition, and deleted when
- * the manager disposes the subagent during normal operation (TTL sweep or
- * parent eviction) — never on shutdown, so in-flight rows survive the restart.
+ * Rows are written on spawn and on every status transition, and live as long as
+ * the parent conversation: only the disposal paths that mean the parent's data
+ * is going away (conversation deletion, clear-all) delete them. The retention
+ * sweep frees a terminal subagent's in-memory metadata while leaving its row,
+ * and shutdown keeps rows too, so in-flight runs survive the restart.
  *
  * Idempotent (`IF NOT EXISTS`). No backfill — pre-existing subagents predate
  * the table and were already only in-memory.

package/src/persistence/migrations/318-drop-contact-channel-telemetry.ts

@@ -25,7 +25,9 @@ export function migrateDropContactChannelTelemetry(database: DrizzleDb): void {
   const raw = getSqliteFrom(database);
 
   for (const column of TELEMETRY_COLUMNS) {
-    if (!tableHasColumn(database, "contact_channels", column)) continue;
+    if (!tableHasColumn(database, "contact_channels", column)) {
+      continue;
+    }
     raw.run(/*sql*/ `ALTER TABLE contact_channels DROP COLUMN ${column}`);
     log.info(`Dropped ${column} column from contact_channels`);
   }

package/src/persistence/migrations/319-remove-legacy-managed-connections.ts

@@ -35,7 +35,9 @@ export function migrateRemoveLegacyManagedConnections(
       `SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'provider_connections'`,
     )
     .get();
-  if (!tableExists) return;
+  if (!tableExists) {
+    return;
+  }
 
   const placeholders = LEGACY_MANAGED_CONNECTION_NAMES.map(() => "?").join(
     ", ",

package/src/persistence/migrations/329-move-onboarding-events-to-telemetry-db.ts

@@ -115,5 +115,7 @@ export async function migrateMoveOnboardingEventsToTelemetryDb(
     ONBOARDING_EVENTS_RELOCATION.table,
   );
 
-  if (needsDrain) await drainStagedTable(raw, ONBOARDING_EVENTS_RELOCATION);
+  if (needsDrain) {
+    await drainStagedTable(raw, ONBOARDING_EVENTS_RELOCATION);
+  }
 }

package/src/persistence/migrations/340-sweep-orphaned-graph-node-vectors.test.ts

@@ -107,6 +107,15 @@ beforeEach(() => {
     source_type TEXT NOT NULL DEFAULT 'inferred',
     scope_id TEXT NOT NULL DEFAULT 'default'
   )`);
+  // memory_embeddings is also on the memory DB; this
+  // migration reads it on the main connection too, so recreate its shape here.
+  raw.run(/*sql*/ `CREATE TABLE IF NOT EXISTS memory_embeddings (
+    id TEXT PRIMARY KEY, target_type TEXT NOT NULL, target_id TEXT NOT NULL,
+    provider TEXT NOT NULL, model TEXT NOT NULL, dimensions INTEGER NOT NULL,
+    vector_json TEXT, vector_blob BLOB, content_hash TEXT,
+    created_at INTEGER NOT NULL, updated_at INTEGER NOT NULL,
+    UNIQUE (target_type, target_id, provider, model)
+  )`);
   raw.run("DELETE FROM memory_embeddings");
   raw.run("DELETE FROM memory_graph_nodes");
   getMemorySqlite()!.run("DELETE FROM memory_jobs");

package/src/persistence/migrations/342-add-conversation-parent-id.test.ts

@@ -134,8 +134,6 @@ describe("migration 342: conversations.parent_conversation_id", () => {
     expect(() => migrateAddConversationParentId(db)).not.toThrow();
 
     const names = columnInfo(sqlite).map((c) => c.name);
-    expect(
-      names.filter((n) => n === "parent_conversation_id"),
-    ).toHaveLength(1);
+    expect(names.filter((n) => n === "parent_conversation_id")).toHaveLength(1);
   });
 });

package/src/persistence/migrations/352-drop-schedule-skill-script-handoff.ts

@@ -29,7 +29,9 @@ export function migrateDropScheduleSkillScriptHandoff(
   const columnNames = new Set(columns.map((c) => c.name));
 
   for (const column of ["then_execute", "skill_id", "skill_version_hash"]) {
-    if (!columnNames.has(column)) continue;
+    if (!columnNames.has(column)) {
+      continue;
+    }
     raw.exec(`ALTER TABLE cron_jobs DROP COLUMN ${column}`);
     log.info({ column }, "Dropped reverted schedule column from cron_jobs");
   }

package/src/persistence/migrations/355-add-schedule-group-id.ts

@@ -0,0 +1,22 @@
+import type { DrizzleDb } from "../db-connection.js";
+import { tableHasColumn } from "./schema-introspection.js";
+
+/**
+ * Add `group_id` column to the `cron_jobs` table.
+ *
+ * The column holds a `conversation_groups` id; conversations created by the
+ * schedule's runs are filed into that sidebar group instead of the default
+ * `system:scheduled`. NULL keeps the default. The consumer
+ * (`resolveScheduleConversationGroupId` in `schedule-store.ts`) falls back to
+ * `system:scheduled` when the referenced group no longer exists, so no
+ * backfill or FK is needed.
+ *
+ * Idempotent: the ALTER is guarded with `tableHasColumn` so a crash between
+ * the `ALTER TABLE` and the checkpoint write doesn't cause a duplicate-column
+ * error on the next boot.
+ */
+export function migrateAddScheduleGroupId(database: DrizzleDb): void {
+  if (!tableHasColumn(database, "cron_jobs", "group_id")) {
+    database.run(`ALTER TABLE cron_jobs ADD COLUMN group_id TEXT`);
+  }
+}